Re: Dangerous space bar key (was: Preventing the user shooting themself in the foot)

2011-07-04 Thread Jameson Graef Rollins
On Mon, 04 Jul 2011 23:36:35 +0200, Matthieu Lemerre ra...@free.fr wrote: I like to use the space (and sometimes the backspace key) to read threads back and forth, but sometimes I might read stuff to quickly and archive a thread without wanting it. It is then complex to find it back

[SCM] notmuch - thread-based email index, search and tagging. annotated tag, 0.6, created. 0.6

2011-07-01 Thread Jameson Graef Rollins
On Fri, 1 Jul 2011 13:13:27 -0700 (PDT), notmuch-commits-sender at notmuchmail.org (David Bremner) wrote: > The annotated tag, 0.6 has been created > at 6eae40d57f12bb44d1b375a1d37454974f6dafd2 (tag) >tagging 6bd02fb4dbee9e0fc372661af573a2ac380fed8a (commit) > replaces 0.6rc1 >

Preventing the user shooting themself in the foot

2011-07-01 Thread Jameson Graef Rollins
On Fri, 01 Jul 2011 09:26:48 +1200, Michael Hudson-Doyle wrote: > On Wed, 29 Jun 2011 22:40:07 -0700, Carl Worth wrote: > Non-text part: multipart/mixed > Non-text part: multipart/signed > > not sure why notmuch reply is putting that there :) They shouldn't be, and I sent a patch to fix that a

Re: Preventing the user shooting themself in the foot

2011-07-01 Thread Jameson Graef Rollins
On Fri, 01 Jul 2011 09:26:48 +1200, Michael Hudson-Doyle michael.hud...@canonical.com wrote: On Wed, 29 Jun 2011 22:40:07 -0700, Carl Worth cwo...@cworth.org wrote: Non-text part: multipart/mixed Non-text part: multipart/signed not sure why notmuch reply is putting that there :) They

Preventing the user shooting themself in the foot

2011-06-29 Thread Jameson Graef Rollins
On Thu, 30 Jun 2011 13:04:23 +1000, Brian May wrote: > Are there any keyboard bindings to go forwards to the next message or > backwards to the last message without marking anything as archived? 'n' and 'p'. These are documented in the notmuch-show mode help ('?' while in notmuch-show mode).

notmuch Digest, Vol 20, Issue 57

2011-06-29 Thread Jameson Graef Rollins
On Wed, 29 Jun 2011 14:21:11 -0600, Mark Anderson wrote: > I personally prefer --output=files remain as it was, with one file per > mail (even though I submitted the patch to change it). I suggest that > we could add another format to supply all files (perhaps > --output=allfiles, or

Preventing the user shooting themself in the foot

2011-06-29 Thread Jameson Graef Rollins
On Wed, 29 Jun 2011 20:42:01 +0100, Robin Green wrote: > It's really dangerous to use the 'a' key in notmuch-mode in an inbox > thread which has multiple unread replies! Yes, the other unread replies > will still be tagged unread, but the user might not immediately be aware > of them. It would be

[PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

2011-06-29 Thread Jameson Graef Rollins
On Tue, 28 Jun 2011 07:31:31 +, Jani Nikula wrote: > Add a pseudo saved search that matches all the mail that no other saved > search matches. Add new customization option notmuch-saved-searches-nomatch > to enable and name the pseudo saved search. Hi, Jani. I haven't looked too closely at

[PATCH] test: document test_expect_equal_file

2011-06-29 Thread Jameson Graef Rollins
This test was not properly documented when it was originally added (my bad). --- test/README |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/test/README b/test/README index 8fbf78d..f9ac607 100644 --- a/test/README +++ b/test/README @@ -156,6 +156,13 @@ library for

[PATCH] test: document test_expect_equal_file

2011-06-29 Thread Jameson Graef Rollins
This test was not properly documented when it was originally added (my bad). --- test/README |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/test/README b/test/README index 8fbf78d..f9ac607 100644 --- a/test/README +++ b/test/README @@ -156,6 +156,13 @@ library for

Re: [PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

2011-06-29 Thread Jameson Graef Rollins
On Tue, 28 Jun 2011 07:31:31 +, Jani Nikula j...@nikula.org wrote: Add a pseudo saved search that matches all the mail that no other saved search matches. Add new customization option notmuch-saved-searches-nomatch to enable and name the pseudo saved search. Hi, Jani. I haven't looked too

Re: Preventing the user shooting themself in the foot

2011-06-29 Thread Jameson Graef Rollins
On Wed, 29 Jun 2011 20:42:01 +0100, Robin Green gree...@greenrd.org wrote: It's really dangerous to use the 'a' key in notmuch-mode in an inbox thread which has multiple unread replies! Yes, the other unread replies will still be tagged unread, but the user might not immediately be aware of

Re: [PATCH 3/4] emacs: Add pseudo saved search to match mail that no saved search matches

2011-06-29 Thread Jameson Graef Rollins
On Wed, 29 Jun 2011 20:15:22 +, Jani Nikula j...@nikula.org wrote: So to clarify, do you prefer having on/off switches, or just enabling this without customization at all? Personally I'd shy away from the latter, but I guess it depends on how useful vs. distracting people find this. My

Notmuch 0.6: Let's do it.

2011-06-27 Thread Jameson Graef Rollins
On Wed, 22 Jun 2011 22:26:06 -0300, David Bremner wrote: > 3) Cherry-pick/merge a small number of _important_ [2] bug fixes between now >and July 1. Hi, David. You might want to consider applying the following patches for 0.6: Bug fix for raw output of gmime parts:

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-27 Thread Jameson Graef Rollins
On Thu, 23 Jun 2011 16:33:18 -0700, Carl Worth wrote: > I'd like to investigate this case a little bit to help answer the > question of whether "notmuch should have done anything in this case". Hi, Carl. You can see this error if you try to output raw a multipart/* or message/rfc822 part, ie:

Re: [PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-27 Thread Jameson Graef Rollins
On Thu, 23 Jun 2011 16:33:18 -0700, Carl Worth cwo...@cworth.org wrote: I'd like to investigate this case a little bit to help answer the question of whether notmuch should have done anything in this case. Hi, Carl. You can see this error if you try to output raw a multipart/* or

Re: Notmuch 0.6: Let's do it.

2011-06-27 Thread Jameson Graef Rollins
On Wed, 22 Jun 2011 22:26:06 -0300, David Bremner da...@tethera.net wrote: 3) Cherry-pick/merge a small number of _important_ [2] bug fixes between now and July 1. Hi, David. You might want to consider applying the following patches for 0.6: Bug fix for raw output of gmime parts:

Re: [PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-27 Thread Jameson Graef Rollins
On Mon, 27 Jun 2011 16:43:36 -0400, Austin Clements amdra...@mit.edu wrote: Just to clarify my understanding, --format=raw is only intended to work on either the whole message (special-cased in do_show_single) or a leaf MIME part, and in any other case, it will output nothing? The raw output

Race condition for '*' command

2011-06-25 Thread Jameson Graef Rollins
On Sat, 25 Jun 2011 23:18:52 +0100, Robin Green wrote: > A race condition in the '*' command was noted when it was first > proposed. It looks to me like it still exists - has anything been done > about it? Hi, Robin. Can you explain what you mean by the "'*' command"? Are you referring to '*'

Re: Race condition for '*' command

2011-06-25 Thread Jameson Graef Rollins
On Sat, 25 Jun 2011 23:18:52 +0100, Robin Green gree...@greenrd.org wrote: A race condition in the '*' command was noted when it was first proposed. It looks to me like it still exists - has anything been done about it? Hi, Robin. Can you explain what you mean by the '*' command? Are you

Debian package not building

2011-06-24 Thread Jameson Graef Rollins
Hey, folks. As of today I am for some reason no longer able to build the Notmuch Debian package. I'm using the same build technique I have been using for a while (git-buildpackage). The tail of the failing build log is pasted at the bottom of this message. Is anyone else encountering anything

Re: Notmuch 0.6: Let's do it.

2011-06-23 Thread Jameson Graef Rollins
On Thu, 23 Jun 2011 09:13:05 +0200, Sebastian Spaeth sebast...@sspaeth.de wrote: Me bows to the tyrant and the hard-working henchmen. :) We (henchmen) generally prefer to go by the official title of Interim Distinguished co-Chief Vice Tyrant. jamie. pgp6gQsY9ndfp.pgp Description: PGP

[PATCH] emacs: Show all multipart/alternative parts by default.

2011-06-22 Thread Jameson Graef Rollins
This is patch is a temporary work-around for a slight regression that popped up in the part handling reorganization. Currently, text/plain parts are always preferred, if present, over other non-text/plain parts in multipart/alternative. However, this means that if there is a blank text/plain

I feel a release coming!

2011-06-22 Thread Jameson Graef Rollins
I think we just agreed with cworth on irc that this simple patch will satisfy his regression worry for 0.6. Meaning that we can push out the release after this patch is merged. bremner, our new "Release Tyrant", has his finger on the trigger...

[PATCH] emacs: Show all multipart/alternative parts by default.

2011-06-22 Thread Jameson Graef Rollins
This is patch is a temporary work-around for a slight regression that popped up in the part handling reorganization. Currently, text/plain parts are always preferred, if present, over other non-text/plain parts in multipart/alternative. However, this means that if there is a blank text/plain

[PATCH 2/2] debian: break up Build-Depends on separate lines

2011-06-21 Thread Jameson Graef Rollins
--- debian/control | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/debian/control b/debian/control index 90bd0ee..3289282 100644 --- a/debian/control +++ b/debian/control @@ -6,9 +6,15 @@ Uploaders: martin f. krafft , Jameson Graef Rollins , David Bremner

[PATCH 1/2] debian: break up uploaders on separate lines

2011-06-21 Thread Jameson Graef Rollins
-Uploaders: martin f. krafft , - Jameson Graef Rollins , - David Bremner +Uploaders: + martin f. krafft , + Jameson Graef Rollins , + David Bremner , Build-Depends: debhelper (>= 7.0.50~), pkg-config, libxapian-dev, libgmime-2.4-dev, libtalloc-dev, libz-dev, emacs23-nox, pyt

No subject

2011-06-21 Thread Jameson Graef Rollins
hrm, sorry. Looks like those last two patches got a little messed up. These two patches replace the previous two. jamie.

[PATCH 4/4] debian: bump standards version to 3.9.2

2011-06-21 Thread Jameson Graef Rollins
--- debian/control |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/debian/control b/debian/control index 49f6961..52c2e5a 100644 --- a/debian/control +++ b/debian/control @@ -15,7 +15,7 @@ Build-Depends: libz-dev, emacs23 | emacs23-nox, python-all (>= 2.6.6-3~),

[PATCH 3/4] debian: build depend on emacs23 or emacs23-nox

2011-06-21 Thread Jameson Graef Rollins
--- debian/control |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/debian/control b/debian/control index 0c998df..49f6961 100644 --- a/debian/control +++ b/debian/control @@ -13,7 +13,7 @@ Build-Depends: libgmime-2.4-dev, libtalloc-dev, libz-dev, - emacs23-nox, +

[PATCH 2/4] debian: break up Build-Depends on separate lines

2011-06-21 Thread Jameson Graef Rollins
: - martin f. krafft , + martin f. krafft , Jameson Graef Rollins , David Bremner , -Build-Depends: debhelper (>= 7.0.50~), pkg-config, libxapian-dev, - libgmime-2.4-dev, libtalloc-dev, libz-dev, emacs23-nox, - python-all (>= 2.6.6-3~) +Build-Depends: + debhelper (>= 7.0.50~), + p

[PATCH 1/4] debian: break up uploaders on separate lines

2011-06-21 Thread Jameson Graef Rollins
-Uploaders: martin f. krafft , - Jameson Graef Rollins , - David Bremner +Uploaders: + martin f. krafft , + Jameson Graef Rollins , + David Bremner , Build-Depends: debhelper (>= 7.0.50~), pkg-config, libxapian-dev, libgmime-2.4-dev, libtalloc-dev, libz-dev, emacs23-nox, pyt

[PATCH 4/4] debian: bump standards version to 3.9.2

2011-06-21 Thread Jameson Graef Rollins
--- debian/control |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/debian/control b/debian/control index 49f6961..52c2e5a 100644 --- a/debian/control +++ b/debian/control @@ -15,7 +15,7 @@ Build-Depends: libz-dev, emacs23 | emacs23-nox, python-all (= 2.6.6-3~),

[PATCH 2/4] debian: break up Build-Depends on separate lines

2011-06-21 Thread Jameson Graef Rollins
...@debian.org Uploaders: - martin f. krafft madd...@debian.org, + martin f. krafft madd...@debian.org, Jameson Graef Rollins jroll...@finestructure.net, David Bremner brem...@debian.org, -Build-Depends: debhelper (= 7.0.50~), pkg-config, libxapian-dev, - libgmime-2.4-dev, libtalloc-dev, libz-dev

[PATCH 1/4] debian: break up uploaders on separate lines

2011-06-21 Thread Jameson Graef Rollins
...@debian.org -Uploaders: martin f. krafft madd...@debian.org, - Jameson Graef Rollins jroll...@finestructure.net, - David Bremner brem...@debian.org +Uploaders: + martin f. krafft madd...@debian.org, + Jameson Graef Rollins jroll...@finestructure.net, + David Bremner brem

[PATCH 3/4] debian: build depend on emacs23 or emacs23-nox

2011-06-21 Thread Jameson Graef Rollins
--- debian/control |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/debian/control b/debian/control index 0c998df..49f6961 100644 --- a/debian/control +++ b/debian/control @@ -13,7 +13,7 @@ Build-Depends: libgmime-2.4-dev, libtalloc-dev, libz-dev, - emacs23-nox, +

[no subject]

2011-06-21 Thread Jameson Graef Rollins
hrm, sorry. Looks like those last two patches got a little messed up. These two patches replace the previous two. jamie. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] debian: break up uploaders on separate lines

2011-06-21 Thread Jameson Graef Rollins
...@debian.org -Uploaders: martin f. krafft madd...@debian.org, - Jameson Graef Rollins jroll...@finestructure.net, - David Bremner brem...@debian.org +Uploaders: + martin f. krafft madd...@debian.org, + Jameson Graef Rollins jroll...@finestructure.net, + David Bremner brem

[PATCH 2/2] debian: break up Build-Depends on separate lines

2011-06-21 Thread Jameson Graef Rollins
--- debian/control | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/debian/control b/debian/control index 90bd0ee..3289282 100644 --- a/debian/control +++ b/debian/control @@ -6,9 +6,15 @@ Uploaders: martin f. krafft madd...@debian.org, Jameson Graef Rollins

bug in emacs-ui ?

2011-06-20 Thread Jameson Graef Rollins
On Tue, 21 Jun 2011 02:01:17 +0200, Sebastien Binet wrote: > and I checked there were no lingering .el files... > > so... > any way to tell which notmuch-emacs-ui I am actually using ? (I am a newbie > when comes to hacking lisp) Hey, Sebastien. You can determine the loaded version of a

bug in emacs-ui ?

2011-06-20 Thread Jameson Graef Rollins
On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet wrote: > > You didn't try forwarding the email to the list ;) > ah! that easy, heh ? > Attachment: 1300323326_0.6276.farnsworth,U=250482,FMD5=af1cd994dfcb9286c394d142687ff5a0:2,S (application/octet-stream) Hi, Sebastien. I don't seem to

bug in emacs-ui ?

2011-06-20 Thread Jameson Graef Rollins
On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet wrote: > > You didn't try forwarding the email to the list ;) > ah! that easy, heh ? > > Attachment: > 1300323326_0.6276.farnsworth,U=250482,FMD5=af1cd994dfcb9286c394d142687ff5a0:2,S > (application/octet-stream) Are you sure this is the

bug in emacs-ui ?

2011-06-20 Thread Jameson Graef Rollins
On Mon, 20 Jun 2011 17:52:03 +0200, Sebastien Binet wrote: > it is only when the signature is lumped like below, that I get the error: > [ 4-line signature. Click/Enter to show. ] > > also, it's only happening to the last message of a thread. Ah, ok. Have you tried looking at the raw

bug in emacs-ui ?

2011-06-20 Thread Jameson Graef Rollins
On Mon, 20 Jun 2011 09:15:06 +0200, Sebastien Binet wrote: > recently, using the head of notmuch-git: > > git://notmuchmail.org/git/notmuch > > when a mail ends with an url and is recognized as a signature: ... > I can't hit [space] to go to the next thread and I get the following > error: >

Re: bug in emacs-ui ?

2011-06-20 Thread Jameson Graef Rollins
On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet seb.bi...@gmail.com wrote: You didn't try forwarding the email to the list ;) ah! that easy, heh ? Attachment: 1300323326_0.6276.farnsworth,U=250482,FMD5=af1cd994dfcb9286c394d142687ff5a0:2,S (application/octet-stream) Are you sure this

[PATCH] debian: break up build-depends on separate lines

2011-06-19 Thread Jameson Graef Rollins
Maintainer: Carl Worth Uploaders: Jameson Graef Rollins , martin f. krafft -Build-Depends: debhelper (>= 7.0.50~), pkg-config, libxapian-dev, - libgmime-2.4-dev, libtalloc-dev, libz-dev, emacs (>= 23~), - python-all (>= 2.6.6-3~) +Build-Depends: + debhelper (>= 7.0.50~), + pkg-config,

[PATCH] debian: break up build-depends on separate lines

2011-06-19 Thread Jameson Graef Rollins
Maintainer: Carl Worth cwo...@debian.org Uploaders: Jameson Graef Rollins jroll...@finestructure.net, martin f. krafft madd...@debian.org -Build-Depends: debhelper (= 7.0.50~), pkg-config, libxapian-dev, - libgmime-2.4-dev, libtalloc-dev, libz-dev, emacs (= 23~), - python-all (= 2.6.6-3~) +Build

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Jameson Graef Rollins
On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin wrote: > I know you prefer tests to go before patches and I agree with that. But > most of the time I do tests after coding. I do not know an easy way to > reorder patches in git. (Also I do not know how to amend an old patch, > wish more

[PATCH] emacs: Add callback functions to crypto sigstatus button.

2011-06-15 Thread Jameson Graef Rollins
On Tue, 31 May 2011 10:07:13 -0700, Jameson Graef Rollins wrote: > This adds two callback functions to the sigstatus button. If the sig > status is "good", then clicking the button displays the output of "gpg > --list-keys" on the key fingerprint. If the sigsta

Re: [PATCH] emacs: Add callback functions to crypto sigstatus button.

2011-06-15 Thread Jameson Graef Rollins
On Tue, 31 May 2011 10:07:13 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This adds two callback functions to the sigstatus button. If the sig status is good, then clicking the button displays the output of gpg --list-keys on the key fingerprint. If the sigstatus is bad

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Jameson Graef Rollins
On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I know you prefer tests to go before patches and I agree with that. But most of the time I do tests after coding. I do not know an easy way to reorder patches in git. (Also I do not know how to amend an

[PATCH 3/3] emacs: Test for thread-outlining

2011-06-14 Thread Jameson Graef Rollins
On Tue, 14 Jun 2011 21:58:48 +0530, "Aneesh Kumar K.V" wrote: > Lars Kellogg-Stedman - 2009-11-17 > |-> Mikhail Gusarov - 2009-11-17 > |-> Lars Kellogg-Stedman - 2009-11-17 > |->"Mikhail Gusarov" - 2009-11-17 > |->"Keith Packard" - 2009-11-17 Or better yet: ?? Lars

Re: [PATCH 3/3] emacs: Test for thread-outlining

2011-06-14 Thread Jameson Graef Rollins
On Tue, 14 Jun 2011 21:58:48 +0530, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Lars Kellogg-Stedman l...@seas.harvard.edu - 2009-11-17 |- Mikhail Gusarov dotted...@dottedmag.net - 2009-11-17 |- Lars Kellogg-Stedman l...@seas.harvard.edu - 2009-11-17 |-Mikhail Gusarov

[PATCH 4/4] Ignore "application/pgp-*" parts in reply.

2011-06-08 Thread Jameson Graef Rollins
The quoted text doesn't need to mention that the message being replied to had these crufty parts. --- notmuch-reply.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 7a76ba3..0eb295e 100644 --- a/notmuch-reply.c +++

[PATCH 3/4] test: test for absence of "Non-text part: application/pgp-*" lines in reply

2011-06-08 Thread Jameson Graef Rollins
In reply, the quoted text does not need to mention that the original message had "application/pgp-signed" or "application/pgp-encrypted" parts. --- test/crypto|2 -- test/multipart |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/test/crypto b/test/crypto index

[PATCH 2/4] Fix notmuch-reply to not output "Non-text part:" lines for non-leafnode parts.

2011-06-08 Thread Jameson Graef Rollins
These lines are just cruft in this case, and can be removed. --- notmuch-reply.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index a19eb19..7a76ba3 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -93,7 +93,12 @@

[PATCH 1/4] test/multipart: test for absence of "Non-text part:" lines in reply for multipart/* and message/rfc822 parts

2011-06-08 Thread Jameson Graef Rollins
There's no reason to output "Non-text part:" lines for parts that are not leaf nodes, eg. multipart/* and message/rfc822. We fix the text here to test for their absence. The next patch will fix reply accordingly. --- test/multipart |3 --- 1 files changed, 0 insertions(+), 3 deletions(-)

tweaks for handling parts in reply

2011-06-08 Thread Jameson Graef Rollins
This is a small set of tweaks to remove unneccessary "Non-text part:" lines in reply, for parts that really don't need to be mentioned. This patch set is not really related to the series that it is being sent in reply to, but it has been worked on top of the message/rfc822 rework of the multipart

tag sharing [was: Re: release-candidate/0.6 redux]

2011-06-08 Thread Jameson Graef Rollins
On Mon, 06 Jun 2011 13:20:00 -0400, Jesse Rosenthal wrote: > After a conversation with David last year about bug-tracking, I worked > up a rough python-based prototype of this. It worked in terms of > namespaces, so Carl could associate the namespace "public" with a list > of tags he publishes

Re: tag sharing [was: Re: release-candidate/0.6 redux]

2011-06-08 Thread Jameson Graef Rollins
On Mon, 06 Jun 2011 13:20:00 -0400, Jesse Rosenthal jrosent...@jhu.edu wrote: After a conversation with David last year about bug-tracking, I worked up a rough python-based prototype of this. It worked in terms of namespaces, so Carl could associate the namespace public with a list of tags he

[PATCH 4/4] Ignore application/pgp-* parts in reply.

2011-06-08 Thread Jameson Graef Rollins
The quoted text doesn't need to mention that the message being replied to had these crufty parts. --- notmuch-reply.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 7a76ba3..0eb295e 100644 --- a/notmuch-reply.c +++

[PATCH 2/4] Fix notmuch-reply to not output Non-text part: lines for non-leafnode parts.

2011-06-08 Thread Jameson Graef Rollins
These lines are just cruft in this case, and can be removed. --- notmuch-reply.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index a19eb19..7a76ba3 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -93,7 +93,12 @@

[PATCH 3/4] test: test for absence of Non-text part: application/pgp-* lines in reply

2011-06-08 Thread Jameson Graef Rollins
In reply, the quoted text does not need to mention that the original message had application/pgp-signed or application/pgp-encrypted parts. --- test/crypto|2 -- test/multipart |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/test/crypto b/test/crypto index

When will we have our next release?

2011-06-07 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 15:56:42 -0700, Carl Worth wrote: > Frankly, I wouldn't mind doing strict time-based releases with something > like the following: Hi, Carl. I think this is a fine idea, and we (not you) can definitely run this process. I'm quite sure that at least bremner and I can

Re: When will we have our next release?

2011-06-07 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 15:56:42 -0700, Carl Worth cwo...@cworth.org wrote: Frankly, I wouldn't mind doing strict time-based releases with something like the following: Hi, Carl. I think this is a fine idea, and we (not you) can definitely run this process. I'm quite sure that at least bremner

tag sharing [was: Re: release-candidate/0.6 redux]

2011-06-06 Thread Jameson Graef Rollins
On Mon, 06 Jun 2011 05:17:27 -0700, Carl Worth wrote: > Hopefully, someone will provide me with a good way to publish my queue > soon, ("notmuch search --output=html" ?), and then communication like > this will be a bit easier. ;-) I've been thinking about this more and it really seems we need a

tag sharing [was: Re: release-candidate/0.6 redux]

2011-06-06 Thread Jameson Graef Rollins
On Mon, 06 Jun 2011 05:17:27 -0700, Carl Worth cwo...@cworth.org wrote: Hopefully, someone will provide me with a good way to publish my queue soon, (notmuch search --output=html ?), and then communication like this will be a bit easier. ;-) I've been thinking about this more and it really

improving message/rfc822 part handling

2011-06-05 Thread Jameson Graef Rollins
Here's the gmime bug about returning rfc822 messages as GMimeObjects: https://bugzilla.gnome.org/show_bug.cgi?id=651964 jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available

release-candidate/0.6 redux

2011-06-05 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 18:27:42 -0700, Carl Worth wrote: > From a quick rebase of your release-candidate branch and a comparison > with what I have queued it looks like only the following commits are > left on your branch and not in my email queue: > > emacs: update notmuch-crypto-process-mime

improving message/rfc822 part handling

2011-06-05 Thread Jameson Graef Rollins
I forgot to mention that this patch series (well the last patch in particular) supersedes the previous emacs rfc822 part handling patch I sent in: id:"1307034386-6107-1-git-send-email-jrollins at finestructure.net" jamie. -- next part -- A non-text attachment was

[PATCH 5/5] emacs: Improve support for message/rfc822 parts.

2011-06-05 Thread Jameson Graef Rollins
The insert-part-message/rfc822 function is overhauled to properly processes the new formatting of message/rfc822 parts. The json output for message parts now includes "headers" and "body" fields, which are now parsed and output appropriately. --- emacs/notmuch-show.el | 21

[PATCH 4/5] Improve handling of message/rfc822 parts by adding a new header_message_part function to the formating structure.

2011-06-05 Thread Jameson Graef Rollins
This new function takes a GMimeMessage as input, and outputs the formatted headers. This allows for message/rfc822 parts to be formatted on output in a similar way to full messages (see previous patch that overhauls the multipart test for more info). --- notmuch-client.h |1 +

[PATCH 3/5] test: overhaul multipart test to test for improved message/rfc822 handling

2011-06-05 Thread Jameson Graef Rollins
The main goal of this overhaul is to define how message/rfc822 parts should be handled. message/rfc822 parts should be output in a similar fashion to the outer message, including some subset of the rfc822 headers. The following decisions about formatting of message/rfc822 parts were made: The

[PATCH 2/5] test: Fix date in test message in multipart test.

2011-06-05 Thread Jameson Graef Rollins
The test message date, "Tue, 05 Jan 2001 15:43:57 -", is not actually a real date. 05 Jan 2001 was in fact a Friday, not a Tuesday. Date parsers (such as "date" in coreutils) will return "Fri" as the day for this string, even if "Tue" is specified. Also, the time zone "-" is actually

[PATCH 1/5] test: some small fixes to multipart test

2011-06-05 Thread Jameson Graef Rollins
There were two "--format=text --part=0" tests. One of them was supposed to be a test for "--format=text --part=1". There were also two errant "test_expect_equal_file OUTPUT EXPECTED" lines, that are removed here. --- test/multipart | 17 ++--- 1 files changed, 2 insertions(+), 15

improving message/rfc822 part handling

2011-06-05 Thread Jameson Graef Rollins
So the following patch series is my attempt to improve handling of message/rfc822 parts. The first couple of patches fix/overhaul the multipart test, and the last two improve the message/rfc822 part output and emacs handling, respectively. The fix outputs the rfc822 message in a format similar

[PATCH 4/5] Improve handling of message/rfc822 parts by adding a new header_message_part function to the formating structure.

2011-06-05 Thread Jameson Graef Rollins
This new function takes a GMimeMessage as input, and outputs the formatted headers. This allows for message/rfc822 parts to be formatted on output in a similar way to full messages (see previous patch that overhauls the multipart test for more info). --- notmuch-client.h |1 +

[PATCH 5/5] emacs: Improve support for message/rfc822 parts.

2011-06-05 Thread Jameson Graef Rollins
The insert-part-message/rfc822 function is overhauled to properly processes the new formatting of message/rfc822 parts. The json output for message parts now includes headers and body fields, which are now parsed and output appropriately. --- emacs/notmuch-show.el | 21 + 1

[PATCH 2/5] test: Fix date in test message in multipart test.

2011-06-05 Thread Jameson Graef Rollins
The test message date, Tue, 05 Jan 2001 15:43:57 -, is not actually a real date. 05 Jan 2001 was in fact a Friday, not a Tuesday. Date parsers (such as date in coreutils) will return Fri as the day for this string, even if Tue is specified. Also, the time zone - is actually always

improving message/rfc822 part handling

2011-06-05 Thread Jameson Graef Rollins
So the following patch series is my attempt to improve handling of message/rfc822 parts. The first couple of patches fix/overhaul the multipart test, and the last two improve the message/rfc822 part output and emacs handling, respectively. The fix outputs the rfc822 message in a format similar

[PATCH 1/5] test: some small fixes to multipart test

2011-06-05 Thread Jameson Graef Rollins
There were two --format=text --part=0 tests. One of them was supposed to be a test for --format=text --part=1. There were also two errant test_expect_equal_file OUTPUT EXPECTED lines, that are removed here. --- test/multipart | 17 ++--- 1 files changed, 2 insertions(+), 15

[PATCH 3/5] test: overhaul multipart test to test for improved message/rfc822 handling

2011-06-05 Thread Jameson Graef Rollins
The main goal of this overhaul is to define how message/rfc822 parts should be handled. message/rfc822 parts should be output in a similar fashion to the outer message, including some subset of the rfc822 headers. The following decisions about formatting of message/rfc822 parts were made: The

Re: improving message/rfc822 part handling

2011-06-05 Thread Jameson Graef Rollins
I forgot to mention that this patch series (well the last patch in particular) supersedes the previous emacs rfc822 part handling patch I sent in: id:1307034386-6107-1-git-send-email-jroll...@finestructure.net jamie. pgpMyp64jKP3K.pgp Description: PGP signature

Re: release-candidate/0.6 redux

2011-06-05 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 18:27:42 -0700, Carl Worth cwo...@cworth.org wrote: From a quick rebase of your release-candidate branch and a comparison with what I have queued it looks like only the following commits are left on your branch and not in my email queue: emacs: update

Re: improving message/rfc822 part handling

2011-06-05 Thread Jameson Graef Rollins
Here's the gmime bug about returning rfc822 messages as GMimeObjects: https://bugzilla.gnome.org/show_bug.cgi?id=651964 jamie. pgpqPmrMDqcxr.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 15:38:29 -0700, Carl Worth wrote: > commit d5b4d950245605b84c56ce991fa3c59a073a70e5 > Author: Jameson Graef Rollins > Date: Sat May 28 14:52:00 2011 -0700 > > show: Avoid inadvertently closing stdout > > GMime has a nasty habit of taking

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth wrote: > Otherwise, the patches up to this point in the thread have all either > been pushed or I've asked for some additional information (perhaps > that's just this patch and the "old style fcc dirs" patch?). Great! That's really great news,

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth wrote: > On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins finestructure.net> wrote: > > The declaration of the GMimeStream pointer to stdout in > > format_part_content_text was somehow preventing subsequent printf > &g

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-03 Thread Jameson Graef Rollins
This was a minor oversite in checking of part type when outputing content raw. This was causing gmime was to throw an exception to stderr. Unfortunately the gmime exception was not being caught by notmuch, or the test suite. I'm not sure if notmuch should have done anything in this case, but

Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth cwo...@cworth.org wrote: On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: The declaration of the GMimeStream pointer to stdout in format_part_content_text was somehow preventing subsequent printf

Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth cwo...@cworth.org wrote: Otherwise, the patches up to this point in the thread have all either been pushed or I've asked for some additional information (perhaps that's just this patch and the old style fcc dirs patch?). Great! That's really

Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 15:38:29 -0700, Carl Worth cwo...@cworth.org wrote: commit d5b4d950245605b84c56ce991fa3c59a073a70e5 Author: Jameson Graef Rollins jroll...@finestructure.net Date: Sat May 28 14:52:00 2011 -0700 show: Avoid inadvertently closing stdout GMime has a nasty

Decryption fails

2011-06-02 Thread Jameson Graef Rollins
On Thu, 02 Jun 2011 18:49:22 +0200, Felix Geller wrote: > Jeff replied and sent me a working patch :) Not sure yet how he prefers > to publish the patch, but the problem is fixed. That's great! What did Jeff say exactly? Is the patch to gmime 2.4? Did he mention that he was including them in

problems with message/rfc822 parts

2011-06-02 Thread Jameson Graef Rollins
Hey, folks. I've been noticing a couple of issues with message/rfc822 part handling in recent builds of notmuch/master. They are rooted in the new part handling rework that was done recently. I just want to mention them here, to make people aware of them, until we get a chance to address them.

[PATCH] emacs: Fix handling of message/rfc822 parts.

2011-06-02 Thread Jameson Graef Rollins
After the recent part-handling overhaul, emacs handling of message/rfc822 parts broke, not outputting the message contents. This "fixes" then handling as is, but there are still problems with how notmuch is outputting message parts that needs to be addressed (for instance, message headers are not

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-02 Thread Jameson Graef Rollins
This was a minor oversite in checking of part type when outputing content raw. This was causing gmime was to throw an exception to stderr. Unfortunately the gmime exception was not being caught by notmuch, or the test suite. I'm not sure if notmuch should have done anything in this case, but

Decryption fails

2011-06-02 Thread Jameson Graef Rollins
On Tue, 31 May 2011 19:33:29 +0200, Felix Geller wrote: > I get the following trace when using show --decrypt to decrypt a > specific message (have to kill the process to actually get the trace): > > #0 0x0001006121a6 in poll () > #1 0x00010006d3d2 in gpg_ctx_op_step () > #2

Re: Decryption fails

2011-06-02 Thread Jameson Graef Rollins
On Tue, 31 May 2011 19:33:29 +0200, Felix Geller fgel...@gmail.com wrote: I get the following trace when using show --decrypt to decrypt a specific message (have to kill the process to actually get the trace): #0 0x0001006121a6 in poll () #1 0x00010006d3d2 in gpg_ctx_op_step () #2

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-02 Thread Jameson Graef Rollins
This was a minor oversite in checking of part type when outputing content raw. This was causing gmime was to throw an exception to stderr. Unfortunately the gmime exception was not being caught by notmuch, or the test suite. I'm not sure if notmuch should have done anything in this case, but

[PATCH] emacs: Fix handling of message/rfc822 parts.

2011-06-02 Thread Jameson Graef Rollins
After the recent part-handling overhaul, emacs handling of message/rfc822 parts broke, not outputting the message contents. This fixes then handling as is, but there are still problems with how notmuch is outputting message parts that needs to be addressed (for instance, message headers are not

<    9   10   11   12   13   14   15   16   17   >