[PATCH 1/3] configure: add ${NOTMUCH_SRCDIR} -- absolute path to notmuch source

The ${srcdir} -- usually relative path to notmuch source -- works fine in current ./configure and all makefiles. To have simple access to notmuch source in tests and out of tree builds holding absolute path to the source directory is useful. --- configure | 8 1 file changed, 8

[PATCH 2/3] fix out of tree build

In addition to use ${srcdir} and deliver ${NOTMUCH_SRCDIR} where needed, source from ruby bindings had to be copied to the out-of-tree target directory -- if the source files in source directory were referenced in build and there were also built object files there, those could have been considered

Re: Trouble decrypting multipart/encrypted

On Sat, Dec 03 2016, David Bremner wrote: > Eric Skoglund writes: > > >> Thank you David! Seems like notmuch used the gpg1 binary (that fedora >> has installed by default also), I switched the gpg binary to gpg2 and it >> now works like a charm! >> >> Thank

Re: [PATCH 1/2] fix out of tree build for ruby bindings

On Tue, Nov 29 2016, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <t...@guru.guru-group.fi> writes: > >> From: Tomi Ollila <tomi.oll...@iki.fi> >> >> Ruby bindings source files had to be copied to the out-of-tree >

Re: [PATCH v2] test: check the handling of files vanishing between scandir and indexing

On Tue, Nov 29 2016, David Bremner wrote: > Jani Nikula writes: > >> +gdb --batch-silent --return-child-result -x notmuch-new-vanish.gdb \ >> +--args notmuch new 2>OUTPUT 1>/dev/null > > I wonder if Tomi's suggestion of > >

[PATCH] test: gdb insert: redirect input inside gdb script

Running `gdb command < input` is not as reliable way to give input to the command (some installations of gdb consume it). Use "set args" gdb command to have input redirected at gdb 'run' time. --- With this change, these tests work on FreeBSD-11.0-RELEASE-amd64[.qcow2] when adding gdb 7.11.1

[PATCH] doc: whitespace cleanup

In most part, our .rst documents are indented with 8 spaces instead of tabs. Bring the rest of the lines to the same format. Also, on one (supposedly empty) line, trailing spaces were removed. --- This set is something that does not collide with anything that is currently in the review queue --

Re: [PATCH v3] build: install notmuch-emacs-mua.desktop file with emacs

On Sat, Nov 26 2016, Jani Nikula wrote: > There is really no need to have a separate install target for the > desktop file. Just install the desktop file with emacs, with a > configure option to opt out. > > --- > > v3: check for desktop-file-install in configure. This and the

Re: provide elpa packages

On Sat, Nov 26 2016, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > >> >> (you could amend copying Makefile.global for out of tree builds -- or use >> include $(srcdir)/Makefile.global) >> > > OK, I did that,

[PATCH 2/2] fix (rest of the) out of tree build

From: Tomi Ollila <tomi.oll...@iki.fi> With working tests (on various Linux systems). --- V3 of id:1479146030-17083-1-git-send-email-tomi.oll...@iki.fi configure | 6 -- test/test-lib-common.sh | 7 +++ test/test-lib.sh| 4 ++-- 3 files changed, 13 inse

[PATCH 1/2] fix out of tree build for ruby bindings

From: Tomi Ollila <tomi.oll...@iki.fi> Ruby bindings source files had to be copied to the out-of-tree target directory -- final obstacle avoiding that was that if there were built object files in source directory, new target object files were not built (caused link failure, fortu

Re: provide elpa packages

On Fri, Nov 25 2016, Tomi Ollila <tomi.oll...@iki.fi> wrote: > On Sat, Nov 19 2016, David Bremner <da...@tethera.net> wrote: > >> This is an answer to the discussion we were having on irc the other day >> about easily installing the emacs front-end for

Re: provide elpa packages

On Sat, Nov 19 2016, David Bremner wrote: > This is an answer to the discussion we were having on irc the other day about > easily installing the emacs front-end for a single user. > > For users of package.el supporting emacs (iirc, emacs 24.1+), you can > > 1) make elpa > 2)

Re: [PATCH v2 8/9] build: install notmuch-emacs-mua.desktop file with emacs

On Mon, Nov 21 2016, Jani Nikula wrote: > There is really no need to have a separate install target for the > desktop file. Just install the desktop file with emacs, with a > configure option to opt out. This and the following patch could check with something like if command

Re: [PATCH v2 4/9] notmuch-emacs-mua: add --hello parameter

On Mon, Nov 21 2016, Jani Nikula wrote: > If the --hello parameter is given, display the notmuch hello buffer > instead of the message composition buffer if no message composition > parameters are given. +1 for --hello option Tomi > > Signed-off-by: Jani Nikula

Re: [PATCH] gzclose_r() and gzclose_w() are not available in older...

On Mon, Nov 21 2016, David Bremner wrote: > I take the submitters word for the first version supporting gzclose I tried this patch on Scientific Linux 6.2 -- after applied it I changed the check to >= 1.2.3 (to the one used in sl62). This compiles fine but tests fails

Re: [PATCH 6/8] emacs/desktop: update to use notmuch-emacs-mua and handle mailto

On Mon, Nov 21 2016, Jani Nikula wrote: > On Mon, Nov 21, 2016 at 1:34 PM, David Bremner wrote: >> Jani Nikula writes: >> >>> -Exec=emacs -f notmuch >>> +GenericName=Email Client >>> +Comment=Emacs based email client >>>

Re: [PATCH v2] fix out of tree build

On Sun, Nov 20 2016, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > >> With working tests. >> --- >> >> This is v2 of id:1479066903-28310-1-git-send-email-tomi.oll...@iki.fi >> >> with this ${srcdir}

Re: notmuch 0.23.2 in preparation

On Thu, Nov 17 2016, David Bremner wrote: > I have pushed to the release branch a few emacs related fixes > > 6e1628d debian: convert to use dh-elpa > 297d27e emacs: generate notmuch-pkg.el > a3e712f emacs: add compatibility functions for emacs 23 > 09caa0f emacs:

Re: [PATCH v3] emacs: add compatibility functions for emacs 23

On Tue, Nov 15 2016, Mark Walters wrote: > Some of the recent changes to the emacs code have used functions > introduced in emacs 24. The functions used are read-char-choice and > setq-local. This changeset adds a file notmuch-compat.el which > contains compatibility

Re: [PATCH 1/3] emacs: generate notmuch-pkg.el

On Fri, Nov 11 2016, David Bremner wrote: > This file contains metadata for the built in (as of emacs 24) packaging > system. Series LGTM. Tomi > --- > Makefile.local| 3 +++ > emacs/.gitignore | 1 + > emacs/Makefile.local | 8 +++- >

Re: [PATCH 0/9] doc: config and build improvements

On Sat, Nov 05 2016, Jani Nikula wrote: > Here's a bunch of fixes to the documentation config and build. > > BR, > Jani. This series looks good to me. Tomi > > > Jani Nikula (9): > doc/conf.py: add notmuch-emacs-mua to texinfo documents > doc/conf.py: generate

[PATCH v2] fix out of tree build

With working tests. --- This is v2 of id:1479066903-28310-1-git-send-email-tomi.oll...@iki.fi with this ${srcdir} being absolute path will also work (relevant in tests!) ... and commit message is fixed: I accuse qt for "shadow build" ;) Out of tree builds breaks every now and then; perhaps it

Re: [PATCH] Test: fix draft test for emacs23

On Mon, Nov 14 2016, David Bremner wrote: > Mark Walters writes: > >> emacs24 and emacs23 have different secure tag defaults: in particular, >> mml-secure-message-sign only signs the part on emacs23 but the whole >> message on emacs24. This

[PATCH] fix "shadow build"

With working tests. --- Some day we dump `find_notmuch_path()` configure | 6 -- test/test-lib-common.sh | 2 ++ test/test-lib.sh| 6 +++--- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 2a0ce9e..05b964d 100755 ---

Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

(Trying to send this w/o Mark in To: -- in the hope also Mark receive this email to his gmail account...) On Sun, Nov 13 2016, Mark Walters <markwalters1...@gmail.com> wrote: > On Sat, 12 Nov 2016, David Bremner <da...@tethera.net> wrote: >> Tomi Ollila <tomi.oll...@iki

Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

On Fri, Nov 04 2016, David Bremner wrote: > This hook can be used to update the message based on the results of > address completion. For example using message-templ or gnus-alias to set > the From address based on the To address just completed. > > The post-completion command

Re: [PATCH v3] completion: complete mimetype: search prefix

On Wed, Nov 02 2016, Jani Nikula wrote: > Use /etc/mime.types if available, parsed using a sed one-liner, and > fall back to a handful of common types otherwise. > > --- > > v2: smarter sed thanks to Lucas Hoffmann > > v3: use Tomi's sed... though I'm not sure what the

Re: [PATCH v2] emacs: add compatability functions for emacs 23

On Fri, Nov 11 2016, David Bremner wrote: > David Bremner writes: > >> The plot thickens. With this patch applied, I can generate an emacs >> segfault with >> >> 1) EMACS=emacs23 ./devel/try-emacs-mua -q >> >> 2) M-x notmuch-search >> >> 3) tag:inbox > >

Re: [PATCH v2] completion: complete mimetype: search prefix

Jani Nikula <j...@nikula.org> writes: > On Tue, 25 Oct 2016, Tomi Ollila <domo...@gmail.com> wrote: >> Jani Nikula <j...@nikula.org> writes: >> >>> Use /etc/mime.types if available, with a homebrew sed parser, and fall >>> back to a h

Re: [PATCH] test/test-lib.sh: execute basename(1)s lazier in test_expect_equal_file ()

On Wed, Oct 26 2016, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > >> Moved the 2 basename(1) executions to the test failure branch in >> test_expect_equal_file (). >> >> The output of basename(1) executions in func

Re: [PATCH v2] completion: complete mimetype: search prefix

Jani Nikula writes: > Use /etc/mime.types if available, with a homebrew sed parser, and fall > back to a handful of common types otherwise. I'd suggest the following line: sed -n '/^[[:alpha:]]/ s/[[:space:]].*//p' /etc/mime.types I tested the sed expression works on

Re: [PATCH] emacs: interesting-buffer bugfixes/updates

On Sat, Oct 22 2016, Mark Walters wrote: > The command notmuch-interesting-buffer has got out of date -- it > doesn't mention notmuch-tree, and it still refers to message-mode not > notmuch-message-mode. Update both of these. > > This fixes the bug that

Re: [PATCH] nmbug: allow excluded messages

On Sat, Oct 22 2016, Mark Walters wrote: > This makes nmbug work even if the notmuch mailing list messages are > excluded (i.e., have a tag in the excluded tags list). > --- > > I keep all my mailing list emails under an excluded tag (initially > this was to test the

Re: bash completion install location

On Tue, Oct 04 2016, David Bremner wrote: > Debian complains about /etc/bash_completion.d begin obsolete and also > claims that /usr/share/bash-completion/completions is the right location > [1]. Can someone who uses bash (ideally also some non-Debian platform) > please

[PATCH 1/2] test-lib.sh: rename $DTACH_TERM to $SMART_TERM

--- test/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index bda8a80..77879c2 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -57,7 +57,7 @@ ORIGINAL_TERM=$TERM # dtach(1) provides more capable terminal

[PATCH 2/2] test: use vt100 as "smart" terminal for known dumb/unknown terminals

Otherwise use whatever user environment has set for TERM so that there is more chance to test on users' actual environments. --- test/test-lib.sh | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 77879c2..e7b8339 100644

Re: [PATCH v6 0/8] Add refresh all buffers functionality

On Sat, Oct 15 2016, Mark Walters wrote: > Version 5 of this set is at > id:1476045223-5238-1-git-send-email-markwalters1...@gmail.com > > The changes from the previous version fix Tomi's comments (give an > error if the refresh function is non-interactive rather than

Re: [PATCH] emacs: search face bugfix

On Wed, Oct 12 2016, Mark Walters wrote: > In commit 2a7b11b064233afc4feead876fa396e3c18a6b91 the default faces > for unread and flagged were accidentally swapped. This swaps them back. > --- > > rlb reported this on irc yesterday. I am assuming all the rest of us >

Re: notmuch-insert Fcc handling w/spaces in dir name

On Mon, Oct 10 2016, Keith Amidon wrote: > I just upgraded to 0.23 and tried out the Fcc handling using notmuch- > insert.  I think this is a significant improvement and I'm excited to > use it.   I have it working successfully for my use case now, but it > did require

Re: [PATCH v5 2/7] emacs: make the refresh functions more consistent

On Mon, Oct 10 2016, Mark Walters <markwalters1...@gmail.com> wrote: > On Sun, 09 Oct 2016, Tomi Ollila <tomi.oll...@iki.fi> wrote: >> On Sun, Oct 09 2016, Mark Walters <markwalters1...@gmail.com> wrote: >> >>> diff --git a/emacs/notmuch-lib.el b/emacs

Re: [PATCH v5 2/7] emacs: make the refresh functions more consistent

On Sun, Oct 09 2016, Mark Walters wrote: > The different refreshed functions were called differently: some were > called interactively and some were not. Make them all interactive. > --- > emacs/notmuch-hello.el | 1 + > emacs/notmuch-lib.el | 9 - >

[PATCH] test/test-lib.sh: execute basename(1)s lazier in test_expect_equal_file ()

Moved the 2 basename(1) executions to the test failure branch in test_expect_equal_file (). The output of basename(1) executions in function test_expect_equal_file () are only used when tests fails -- when all tests pass these 2 basename(1) executions are no longer done at all. ---

[PATCH] test/T000-basic: replaced use of which(1) with shell builtin command -v

Some minimal chroot/container environments don't have which(1) installed. --- test/T000-basic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/T000-basic.sh b/test/T000-basic.sh index d6811bd10756..0a8d6cdf40fc 100755 --- a/test/T000-basic.sh +++ b/test/T000-basic.sh @@

Re: [PATCH v4 1/6] emacs: make the refresh code more consistent

On Sun, Oct 09 2016, Ioan-Adrian Ratiu wrote: > From: Mark Walters > > The current refresh code is a little haphazard with some of the > refresh functions called interactively, and some not. Some of the > refresh functions take arguments and they

Re: [PATCH] emacs: tag-jump: make k binding for the reverse tag change map

On Fri, Oct 07 2016, Mark Walters wrote: > Currently, by default k invokes the tag-jump menu, and following it by > r invokes the reverse tag change jump menu. This is awkward to type > (e.g. k r u for undoing a -unread change). This changes it so that k > followed by

Re: [PATCH 1/2] emacs: tag-jump: make k binding for the reverse tag change map

On Thu, Oct 06 2016, Mark Walters wrote: > Currently, by default k invokes the tag-jump menu, and following it by > r invokes the reverse tag change jump menu. This is awkward to type > (e.g. k r u for undoing a -unread change). This changes it so that k > followed by

Re: [PATCH v2 0/4] Add refresh all buffers functionality

On Thu, Oct 06 2016, Daniel Kahn Gillmor <d...@fifthhorseman.net> wrote: > > > On Sun 2016-09-25 03:32:08 -0400, Tomi Ollila wrote: >> 2) then, minor commit message related comment: if there is going to be v3, >> in id:20160924200735.25425-2-...@adirat.com

Re: [PATCH] require xapian >= 1.2.6

On Wed, Oct 05 2016, David Bremner wrote: > It seems that no-one tried to compile without Xapian compact support > since March of 2015, since that's when I introduced a syntax error in > that branch of the ifdef. > > Given the choice of maintaining this underused branch of

Re: [PATCH] lib: bump minor version to mark added symbols

On Sun, Oct 02 2016, David Bremner wrote: > This should not change the SONAME, and therefore won't change the > dynamic linking behaviour, but it may help some users debug missing > symbols in case their libnotmuch is too old. > --- > > this should probably go into 0.23 +1

[PATCH] configure: set platform variables also when `uname` is unrecognized

Since commit 124a67e96ecab5495c0f17b6875d53dfd67ff137: configure: add set -u all variables must be set before their expansion are attempted. These 2 variables: "platform" and "linker_resolves_library_dependencies" were not given value in the final 'else' branch when platform check failed due to

Re: [PATCH] NEWS: add news for fcc insert and address completion changes

On Wed, Sep 28 2016, Mark Walters wrote: > --- > > I think this fixes the comments for the first version of this (see > id:1472997204-15411-1-git-send-email-markwalters1...@gmail.com ) yes. +1 > > Best wishes > > Mark > > NEWS | 37

[PATCH] NEWS: emacs notmuch-show-resend-message

--- This obsoletes the previous message with same Subject:. It is also borken. NEWS | 8 1 file changed, 8 insertions(+) diff --git a/NEWS b/NEWS index 5590bb813da9..04ab32d2180f 100644 --- a/NEWS +++ b/NEWS @@ -55,6 +55,14 @@ Dump/Restore support for configuration information and

[PATCH] lib/database.cc: fix misleading indentation

Found by gcc 6.1.1 -Wmisleading-indentation option (set by -Wall). --- I suggest this change to be included in 0.23: this does not affect binary content and this will give users of gcc 6 more enjoyable compilation experience. lib/database.cc | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] nmbug: Add --no-renames to default log options

On Mon, Sep 26 2016, "W. Trevor King" wrote: > Git has supported this since b68ea12e (diff.c: respect diff.renames > config option, 2006-07-07, v1.4.2). All of our information is in the > paths (the files are empty), so we don't want rename detection. By > using --no-renames,

Re: [PATCH] emacs: tree: make b bounce a message and backspace scroll message pane up

On Sun, Sep 25 2016, Mark Walters wrote: > This tweaks the keybindings in tree-mode. It make b do bounce/resend > matching show-mode. Since b was already bound to scroll message pane > back, we now use backspace for that. > > This means space/backspace scroll the

Re: [PATCH v2 0/4] Add refresh all buffers functionality

On Sun, Sep 25 2016, Mark Walters wrote: > On Sun, 25 Sep 2016, Ioan-Adrian Ratiu wrote: >> On Sat, 24 Sep 2016, David Bremner wrote: >>> Ioan-Adrian Ratiu writes: >>> On Sat, 24 Sep 2016, Ioan-Adrian Ratiu

[PATCH] test: test-lib.sh: use $BASH instead of ${SHELL-sh} to relaunch

In case of the test script is to be relaunced under valgrind, or --tee is requested, use the $BASH shell variable to locate the command interpreter. The $SHELL environment variable is not set by bash if it already had non-empty value (e.g. "/bin/zsh"). After this change requesting script relaunch

[PATCH] test: test-lib.sh: use $BASH instead of ${SHELL-sh} to relaunch

In case of the test script is to be relaunced under valgrind, or --tee is requested, use the $BASH shell variable to locate the command interpreter. The $SHELL variable is re-set by non-interactive shells so in case the shell uses some other shell (e.g. zsh) for interactive use these bash scripts

Re: [PATCH] lib: add talloc reference from string map iterator to map

On Sat, Sep 24 2016, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: >> >> I tried to run this under valgrind ( ./T610-message-property.sh --valgrind ) >> but got so noisy output that I could not resolve anything definite >&g

Re: [PATCH] lib: add talloc reference from string map iterator to map

On Fri, Sep 23 2016, David Bremner wrote: > This is needed so that when the map is modified during traversal, and > thus unlinked by the database code, the map is not disposed of until the > iterator is done with it. > --- > > According to my obviously fallible memory, this

Re: [PATCH] build system: choose gnu99 as a C standard

On Thu, Sep 22 2016, David Bremner wrote: > Apparently pre 5.1 gcc defaulted to gnu89, but we decided it was ok to > use some c99 features. > > '-std=c99' by itself is not enough for notmuch to compile. > > '-std=gnu99' seems to work with clang and gcc, so I'm not convinced >

Re: v3 of message properties patches

On Wed, Sep 21 2016, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> I've been running this series of patches since shortly after they were >> released. They work for me, and they're a critical feature to enable >> the cleartext index series

[PATCH] NEWS: emacs notmuch-show-resend-message

--- This will conflict w/ Mark's NEWS patch bit that needs to be edited anyway :D NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index c0b865d..fe594bd 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,13 @@ Notmuch 0.23 (UNRELEASED) Emacs - +Resend messages + + The

Re: [PATCH] emacs: tree: make jump close message pane

On Mon, Sep 19 2016, Mark Walters wrote: > j is in the global notmuch keymap bound to notmuch jump. In tree-mode > it makes sense to close the message pane first (otherwise the new > search runs in the small top pane of tree-mode). looks good plus one > --- > > I

Re: [PATCH] emacs: tag deleted face bugfix

On Sun, Sep 18 2016, Mark Walters wrote: > Commit d25d33ff cleaned up some of the tag face code. However, for the > face notmuch-tag-deleted it used the test > > ((class color) (supports :strike-through)) > > to decide whether to use red strikethrough or inverse-video

[WIP PATCH] emacs: add "--" to finish notmuch command line args before search terms

I don't (yet) know how complete this is (Someone's "workflow" it may break) but tests pass... --- This is related to id:m2lgyr378r@guru.guru-group.fi -- notmuch cli supports "--" to separate options from rest of the command line universally. The change here would complete the particular need

Re: [PATCH] emacs: notmuch-show: remove extraneous shell quoting

On Fri, Sep 16 2016, Matt Armstrong wrote: > Tomi, thanks for your reply asking for some motivation behind this > patch. I can't reply directly to your message because, for some reason, > it doesn't appear in my mailbox (I discovered your message while reading > the mail

Re: [PATCH] emacs: notmuch-show: remove extraneous shell quoting

On Wed, Sep 14 2016, Matt Armstrong wrote: > Remove shell quoting from notmuch-show--build-buffer. The args list > is ultimately passed to call-process, which passes them verbatim to > the subprocess (typically, notmuch). The quoting, intended for a > shell, is

Re: [PATCH v3 00/15] reply refactor, fixes

On Tue, Sep 13 2016, Jani Nikula wrote: > Updated version of [1] to address David's review comments, mostly just > commit message updates. Also incorporates the multiple corpora support > from [2], with the commit message extended a bit, and rebasing patch 2 > on top of it. I

Re: [PATCH] emacs: use define-derived-mode for defining modes.

On Sat, Sep 10 2016, Steven Allen wrote: > [ Unknown signature status ] > > David Bremner writes: >> Steven Allen writes: >> >>> This sets up and runs all the correct hooks and reduces some redundancy. >>> --- >> >> The idea seems

Re: [PATCH] test/crypto: hard code fingerprint

On Thu, Sep 08 2016, David Bremner wrote: > Originally the intent was to make the test more robust against changing > test keys. It turns out that (unscientifically) gpg --with-colons output > changes more often than our test key. Rather than making the script more > complex,

Re: [PATCH] NEWS: add news for fcc insert and address completion changes

On Sun, Sep 04 2016, Mark Walters wrote: > --- > > I am not totally sure about the wording, so any suggestions gratefully > received. I don't know about the wording (and perhaps it does not need to be "perfect") -- just a few other comments (inline). (almost forgot,

Re: [PATCH] emacs: use define-derived-mode for defining modes.

On Sun, Aug 28 2016, Steven Allen wrote: > This sets up and runs all the correct hooks and reduces some redundancy. I don't why this would work or not, but I put this into my build configuration so let's see... Tomi > --- > emacs/notmuch-hello.el | 8 +--- >

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

On Tue, Aug 30 2016, Tomi Ollila <tomi.oll...@iki.fi> wrote: > On Tue, Aug 30 2016, Tomi Ollila <tomi.oll...@iki.fi> wrote: > >> On Sat, Aug 27 2016, Erik Rybakken <erik.rybak...@math.ntnu.no> wrote: >> >>> Hi, >>> >>> Thanks Tomi an

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

On Tue, Aug 30 2016, Tomi Ollila <tomi.oll...@iki.fi> wrote: > On Sat, Aug 27 2016, Erik Rybakken <erik.rybak...@math.ntnu.no> wrote: > >> Hi, >> >> Thanks Tomi and David for the feedback! >> >> On Fri, Aug 26, 2016 at 02:32:19PM +0300, Tomi Ollila

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

On Sat, Aug 27 2016, Erik Rybakken <erik.rybak...@math.ntnu.no> wrote: > Hi, > > Thanks Tomi and David for the feedback! > > On Fri, Aug 26, 2016 at 02:32:19PM +0300, Tomi Ollila wrote: > >> ... but I can think of one problem there (if my memory server corre

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

On Thu, Aug 25 2016, Erik Rybakken wrote: > Hi again, > > I implemented the option for hooks myself. The patch is included. Please > bear with me, this is my first contribution to notmuch (and my first > attempt to write C code). I tested the option, and it seems to

Re: [PATCH] emacs: wash: make word-wrap bound message width

On Wed, Aug 24 2016, Mark Walters wrote: >> Now I understand. Does 999d473299781cb2a38fba5d9e2452504799a7a2 make this >> stale ? > > Hi > > I am not sure which commit that is (it doesn't seem to be in my tree) -- > I am guessing you mean the patch from >

Re: [PATCH] emacs: wash: make word-wrap bound message width

On Mon, Aug 22 2016, Mark Walters <markwalters1...@gmail.com> wrote: > On Sat, 20 Aug 2016, Tomi Ollila <tomi.oll...@iki.fi> wrote: >> On Wed, Jul 06 2016, Mark Walters <markwalters1...@gmail.com> wrote: >> >> >> The change looks good to me -- but I j

Re: [PATCH] emacs: wash: make word-wrap bound message width

On Wed, Jul 06 2016, Mark Walters wrote: > Previously if notmuch-wash-wrap-lines-length was set then all messages > would be wrapped at this value (or window-width if that is > smaller). This was done regardless of the message's depth in a thread: > for example, if the

Re: [PATCH] doc: update cross references for notmuch.1

On Wed, Jun 29 2016, David Bremner wrote: > In particular add notmuch-compact(1) (Debian bug #825884) LGTM. Tomi > --- > doc/man1/notmuch.rst | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/doc/man1/notmuch.rst b/doc/man1/notmuch.rst >

Re: [feature request] emacs: use `notmuch insert` for FCC

On Sat, Aug 20 2016, Steven Allen wrote: > Instead of directly dropping messages into a maildir on FCC, it would be > better to pipe to `notmuch insert --folder=$dir -- $tags`. This way, > > 1. The message is indexed immediately and shows up in searches without > requiring

Re: [RFC PATCH] test: add devel/test-in-docker.sh

On Wed, Aug 17 2016, Tomi Ollila <tomi.oll...@iki.fi> wrote: > With this user can try and test notmuch in docker container, > in fixed environment where it should compile and tests should pass... > > Currently provided container environments are Debian 8.5 and > Ubuntu 16.04

[RFC PATCH] test: add devel/test-in-docker.sh

With this user can try and test notmuch in docker container, in fixed environment where it should compile and tests should pass... Currently provided container environments are Debian 8.5 and Ubuntu 16.04 based. Host OS could be any Linux environment with modern enough docker; Perhaps this works

Re: database error

On Mon, Aug 15 2016, David Bremner wrote: > Ken writes: > >> I'm getting the following error: >> >> >> ken@ken-Presario-CQ57-Notebook-PC:~$ notmuch new >> Error: Notmuch database at /home/ken/Mail/.notmuch >> has a newer database format version

Re: Applying patches directly from emails?

On Sat, Aug 13 2016, Jani Nikula wrote: > On Sun, 24 Jul 2016, Nicolas Petton wrote: >> Daniel Kahn Gillmor writes: >>> If you're asking about notmuch-emacs, I just use "|" (or ". |" if a >>> MIME subpart is the patch instead of the

Re: [WIP PATCH] emacs: query: completion for from: in searches

On Fri, Aug 12 2016, Mark Walters wrote: > This is a first attempt at tab completion for from: searches > --- Nice work! I did not test this, but tried to get a grasp of it by testing tag: completion -- It took me a while to find out where to test -- in interactive

Re: [PATCH v4 02/16] Move crypto.c into libutil

On Fri, Aug 12 2016, David Bremner wrote: > Daniel Kahn Gillmor writes: >> +++ b/util/crypto.c >> @@ -0,0 +1,138 @@ > >> +#include "notmuch.h" > > It feels wrong to me for a file in util/ to include notmuch.h. It seems > the same situation holds with

Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH

On Fri, Aug 12 2016, Daniel Kahn Gillmor wrote: > On Fri 2016-08-12 03:38:53 -0400, David Bremner wrote: >> Daniel Kahn Gillmor writes: >> Should we distinguish between relative and absolute paths here? I can't think of any security

Re: [PATCH] configure: add --without-api-docs option

On Wed, Aug 10 2016, mp39...@gmail.com wrote: > From: Mikhail > > Add option to explicitly disable API man page build even if doxygen > binary is available. --without-docs also implies not building API > manpage. This LGTM and worked fine on my manual ./configure command line

Re: [PATCH] configure: add --without-api-docs option

On Tue, Aug 09 2016, David Bremner wrote: > mp39...@gmail.com writes: > >> From: Mikhail >> >> Add option to explicitly disable API man page build even if doxygen is >> available. > > I'm not sure about the use case here. For some reason you want to >

Re: [PATCH 0/2] emacs: wash: word-wrap bugfix and tweak

On Sat, Aug 06 2016, Mark Walters wrote: > Jani pointed out on irc that there was a bug in notmuch-tree that when > a message very deep in a thread is viewed in the message pane it is > wordwrapped too soon. > > This is actually a bug in notmuch-wash: it assumes that >

Re: [PATCH v3] emacs: postpone/resume support

On Fri, Jul 08 2016, Daniel Kahn Gillmor <d...@fifthhorseman.net> wrote: > [ Unknown signature status ] > On Sun 2016-06-05 07:18:25 -0400, David Bremner wrote: >> Tomi Ollila <tomi.oll...@iki.fi> writes: >> >>> ... but I think I am not biased when I think t

Re: Issue with verifying cleartext signed messages

On Fri, Jul 01 2016, Sanel Zukan wrote: > Hi, > > I'm using epa-verify-cleartext-in-region to verify cleartext signed > messages and noticed it will sometimes fail with notmuch, especially > when target mail message is part of longer thread. > > For example, when signed mail is

Re: bug fix release 0.22.1

I'd say nil -- I have something to check on this ... (*) > Stefano Zacchiroli: > notmuch-mutt: use env to locate perl for increased portability > - I don't use notmuch mutt, but it's a small fix #t > Tomi Ollila: > test: set LD_LIBRARY_PATH early and keep its

Re: [PATCH] doc: forbid further operations on a closed database

On Mon, Jun 27 2016, David Bremner wrote: > We could add many null pointer checks, but currently I don't see a use > case that justifies it. > --- > lib/notmuch.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/notmuch.h b/lib/notmuch.h > index

Re: [PATCH v2] test: add "set -u" to test-lib.sh

On Mon, Jun 27 2016, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > >> This prohibits unset variables to expand to empty strings. >> Without this e.g misspelled variables cause unintentional results. >> >> Now all

Re: v4 of DB_RETRY_LOCK patches

On Sun, Jun 26 2016, David Bremner wrote: > This obsoletes > >id:1465043356-23420-2-git-send-email-da...@tethera.net > > I investigated adding a timeout (including talking a bit to Xapian > upstream about it), and thought about some runtime configuration > options, but for

Re: Problem with draft mails when using offlineimap

On Mon, Jun 13 2016, Daniel Kahn Gillmor wrote: > On Fri 2016-06-10 13:59:34 -0400, Torben Hoffmann wrote: >> The link you sent me does not work for me > > the link should work in notmuch-emacs if you already have a copy of the > existing messages in your mailstore. if

<    3   4   5   6   7   8   9   10   11   12   >