[notmuch] [PATCH 2/9] Adjust autoload comments

[James Rowe]

  [Sorry, I'm flipping back and forth between mail clients at the moment and
I appear to have inadvertently marked a lot of mail as read that wasn't.]

Excerpts from Carl's message of Fri Dec 04 01:07:07 + 2009:
> On Mon, 30 Nov 2009 20:38:00 +, James Rowe wrote:
> >   I had planned on posting a patch for inclusion in packaging/Gentoo per
> > Carl's mail[2], but the whole GPL 2 vs 3 thing made me put it on the
> > backburner and I haven't looked again. Might still be useful to people
> > unless there is going to be a "real" release soon, as then it would be
> > easier to push for it on bugs.gentoo.org.
>
> Is the GPLv3 a problem for you and your ebuild for some reason, or is it
> just that you happened to start with a GPLv2 file or so?

  GPL v3 isn't a problem for me personally.  The problem is Gentoo ebuilds in
the main tree are all GPL v2, and I accepted changes with a clear GPL v2 header
on the ebuild.  I don't claim to understand the licensing stuff enough to know
if mixing the two together is valid, so I just moved on to something more fun.

  I might have pushed the issue if it was important, but it isn't even
a valuable change.

> I'm definitely interested in hearing, since this is the first project
> I've let loose myself under the GPLv3. So far, it hasn't seemed to be a
> big impediment to contributions, which I think is great.

  It definitely doesn't seem to have been an impediment.  git-rank-contributors
shows 29 contributors already, and that is very impressive given the age of the
project.
-- 
Thanks,

James
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 290 bytes
Desc: not available
URL: 

[notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Thu, 17 Dec 2009 17:17:12 +, "James Rowe"  wrote:
>   [Sorry, I'm flipping back and forth between mail clients at the moment and
> I appear to have inadvertently marked a lot of mail as read that
> wasn't.]

No worries. I don't even have the excuse of flipping back and forth, and
I keep messing up my mail too.

Most recently I realized that just moving existing mail files into the
mail store keeps them hidden from notmuch, (the mtime of the containing
directory is updated, but the mtime of the file itself is still older so
gets ignored). This bug will be fixed with the rewrite of new-file
detection (with support for deleted/renamed files). I'll be landing that
soon (promise!).

>   GPL v3 isn't a problem for me personally.

OK. Thanks for following up.

> The problem is Gentoo ebuilds in
> the main tree are all GPL v2, and I accepted changes with a clear GPL v2 
> header
> on the ebuild.  I don't claim to understand the licensing stuff enough to know
> if mixing the two together is valid, so I just moved on to something more fun.

GPLv2 and GPLv3 are incompatible by design. So there's no way to mix
them unless the code with the GPLv2 license has a notice that says
"either version 2 of the License, or (at your option) any later
version."

>   It definitely doesn't seem to have been an impediment.  
> git-rank-contributors
> shows 29 contributors already, and that is very impressive given the age of 
> the
> project.

I agree. It's delightful to have so much help on the project
already. (And a bunch more will be landing soon once I start working
through my patch backlog.)

-Carl
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 

Re: [notmuch] [PATCH 2/9] Adjust autoload comments

[James Rowe]

  [Sorry, I'm flipping back and forth between mail clients at the moment and
I appear to have inadvertently marked a lot of mail as read that wasn't.]

Excerpts from Carl's message of Fri Dec 04 01:07:07 + 2009:
 On Mon, 30 Nov 2009 20:38:00 +, James Rowe wrote:
I had planned on posting a patch for inclusion in packaging/Gentoo per
  Carl's mail[2], but the whole GPL 2 vs 3 thing made me put it on the
  backburner and I haven't looked again. Might still be useful to people
  unless there is going to be a real release soon, as then it would be
  easier to push for it on bugs.gentoo.org.

 Is the GPLv3 a problem for you and your ebuild for some reason, or is it
 just that you happened to start with a GPLv2 file or so?

  GPL v3 isn't a problem for me personally.  The problem is Gentoo ebuilds in
the main tree are all GPL v2, and I accepted changes with a clear GPL v2 header
on the ebuild.  I don't claim to understand the licensing stuff enough to know
if mixing the two together is valid, so I just moved on to something more fun.

  I might have pushed the issue if it was important, but it isn't even
a valuable change.

 I'm definitely interested in hearing, since this is the first project
 I've let loose myself under the GPLv3. So far, it hasn't seemed to be a
 big impediment to contributions, which I think is great.

  It definitely doesn't seem to have been an impediment.  git-rank-contributors
shows 29 contributors already, and that is very impressive given the age of the
project.
-- 
Thanks,

James


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Thu, 17 Dec 2009 17:17:12 +, James Rowe jnr...@gmail.com wrote:
   [Sorry, I'm flipping back and forth between mail clients at the moment and
 I appear to have inadvertently marked a lot of mail as read that
 wasn't.]

No worries. I don't even have the excuse of flipping back and forth, and
I keep messing up my mail too.

Most recently I realized that just moving existing mail files into the
mail store keeps them hidden from notmuch, (the mtime of the containing
directory is updated, but the mtime of the file itself is still older so
gets ignored). This bug will be fixed with the rewrite of new-file
detection (with support for deleted/renamed files). I'll be landing that
soon (promise!).

   GPL v3 isn't a problem for me personally.

OK. Thanks for following up.

 The problem is Gentoo ebuilds in
 the main tree are all GPL v2, and I accepted changes with a clear GPL v2 
 header
 on the ebuild.  I don't claim to understand the licensing stuff enough to know
 if mixing the two together is valid, so I just moved on to something more fun.

GPLv2 and GPLv3 are incompatible by design. So there's no way to mix
them unless the code with the GPLv2 license has a notice that says
either version 2 of the License, or (at your option) any later
version.

   It definitely doesn't seem to have been an impediment.  
 git-rank-contributors
 shows 29 contributors already, and that is very impressive given the age of 
 the
 project.

I agree. It's delightful to have so much help on the project
already. (And a bunch more will be landing soon once I start working
through my patch backlog.)

-Carl


pgpslDw4fGhOs.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Thu, 3 Dec 2009 20:24:59 -0500, Jameson Graef Rollins  wrote:
> I actually really like having notmuch open right into my "inbox".

Well, at least that option won't ever go away. :-)

> I thought part of the point of notmuch was to get rid of the whole dump
> idea of folders!

There's certainly lots of brain-damage in "folder-based" email
programs. And obviously, we don't want to encourage that. I think one of
the biggest things that notmuch provides to avoid the brain damage is
global search.

So what I'm imagining for the default notmuch view is something like
this:

Welcome to notmuch.

Notmuch search: _

Saved searches:

55,342  All messages
22  Inbox

Recent searches:

 1  from:"someone special" and tag:unread
34  tag:notmuch and tag:todo

Click (or press Enter) on any search to see the results.
Right-click (or press Space) on any recent search to save it.

So the "saved searches" portion of the view is basically just what
notmuch-folder displays now. Above that there's an obvious place to
start a new search, (in a slightly more "web-browser-like" way than the
typical mini-buffer approach).

All recent searches appear in the list at the bottom automatically, and
there's the documented mechanism for saving a search, (giving it a name
and having it appear above).

I think the above should do a good job of emphasizing what notmuch is,
and how a search-based email program is fundamentally different than a
folder-based approach.

Feedback?

-Carl
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 

[notmuch] [PATCH 2/9] Adjust autoload comments

[James Rowe]

  Firstly, thanks for the full explanations!

On Thu, 03 Dec 2009 17:04:52 -0800, Carl Worth  wrote:
> The notmuch-folder command is definitely a nice primary interface to
> notmuch for some people. I'm seriously considering making it the view
> that one gets with "M-x notmuch" (after the notmuch-folder view gets a
> little sprucing up).

  Coming from sup and being a gmail user "emacs -f notmuch" seems like
the natural mail interface to me. Still, even if the default view
changes I can switch to just opening a tag:inbox search.

  I've left the elisp-make-autoload-file change in our builds, which
means all the ";;;###autoload" enveloped functions are available. Nobody
seems to be upset by the change.

> As for notmuch-search, I find it very convenient to have the ability to
> do a "M-x notmuch-search" (or perhaps even a simpler keybinding for it)
> From any random emacs buffer. If you don't live inside emacs, and just
> have a single emacs frame open for notmuch sake, maybe that's not as
> interesting.

  Carl, you've got me pegged.  I use the /other/ editor, I only
installed emacs for notmuch.

  For me, I've already managed to train myself to just fire up notmuch
and hit 's' when searching. The extra search buffer that method creates
makes no difference to my personal usage patterns.

-- 
Thanks,

James

[notmuch] [PATCH 2/9] Adjust autoload comments

[Jameson Graef Rollins]

On Thu, Dec 03, 2009 at 05:04:52PM -0800, Carl Worth wrote:
> The notmuch-folder command is definitely a nice primary interface to
> notmuch for some people. I'm seriously considering making it the view
> that one gets with "M-x notmuch" (after the notmuch-folder view gets a
> little sprucing up).

I actually really like having notmuch open right into my "inbox".  I
thought part of the point of notmuch was to get rid of the whole dump
idea of folders!

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: 

[notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Mon, 30 Nov 2009 20:38:00 +, James Rowe  wrote:
>   I had planned on posting a patch for inclusion in packaging/Gentoo per
> Carl's mail[2], but the whole GPL 2 vs 3 thing made me put it on the
> backburner and I haven't looked again. Might still be useful to people
> unless there is going to be a "real" release soon, as then it would be
> easier to push for it on bugs.gentoo.org.

Is the GPLv3 a problem for you and your ebuild for some reason, or is it
just that you happened to start with a GPLv2 file or so?

I'm definitely interested in hearing, since this is the first project
I've let loose myself under the GPLv3. So far, it hasn't seemed to be a
big impediment to contributions, which I think is great.

-Carl
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 

[notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Mon, 30 Nov 2009 20:38:00 +, James Rowe  wrote:
>   I have to admit I played with elisp-make-autoload-file in my ebuild
> initially, but came to the conclusion there wasn't a great deal of
> purpose to exposing more than the main notmuch function. Mostly because
> it muddies my emacs and shell autocompletion, and my laziness prevailed.
> Am I missing some obviously useful things that can be done if
> notmuch-{folder,search} are available directly?

The notmuch-folder command is definitely a nice primary interface to
notmuch for some people. I'm seriously considering making it the view
that one gets with "M-x notmuch" (after the notmuch-folder view gets a
little sprucing up).

As for notmuch-search, I find it very convenient to have the ability to
do a "M-x notmuch-search" (or perhaps even a simpler keybinding for it)

Re: [notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Mon, 30 Nov 2009 20:38:00 +, James Rowe jnr...@gmail.com wrote:
   I have to admit I played with elisp-make-autoload-file in my ebuild
 initially, but came to the conclusion there wasn't a great deal of
 purpose to exposing more than the main notmuch function. Mostly because
 it muddies my emacs and shell autocompletion, and my laziness prevailed.
 Am I missing some obviously useful things that can be done if
 notmuch-{folder,search} are available directly?

The notmuch-folder command is definitely a nice primary interface to
notmuch for some people. I'm seriously considering making it the view
that one gets with M-x notmuch (after the notmuch-folder view gets a
little sprucing up).

As for notmuch-search, I find it very convenient to have the ability to
do a M-x notmuch-search (or perhaps even a simpler keybinding for it)
From any random emacs buffer. If you don't live inside emacs, and just
have a single emacs frame open for notmuch sake, maybe that's not as
interesting.

-Carl


pgpDwyxv7wvMU.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Mon, 30 Nov 2009 20:38:00 +, James Rowe jnr...@gmail.com wrote:
   I had planned on posting a patch for inclusion in packaging/Gentoo per
 Carl's mail[2], but the whole GPL 2 vs 3 thing made me put it on the
 backburner and I haven't looked again. Might still be useful to people
 unless there is going to be a real release soon, as then it would be
 easier to push for it on bugs.gentoo.org.

Is the GPLv3 a problem for you and your ebuild for some reason, or is it
just that you happened to start with a GPLv2 file or so?

I'm definitely interested in hearing, since this is the first project
I've let loose myself under the GPLv3. So far, it hasn't seemed to be a
big impediment to contributions, which I think is great.

-Carl


pgpscK31hu3ei.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [notmuch] [PATCH 2/9] Adjust autoload comments

[Jameson Graef Rollins]

On Thu, Dec 03, 2009 at 05:04:52PM -0800, Carl Worth wrote:
 The notmuch-folder command is definitely a nice primary interface to
 notmuch for some people. I'm seriously considering making it the view
 that one gets with M-x notmuch (after the notmuch-folder view gets a
 little sprucing up).

I actually really like having notmuch open right into my inbox.  I
thought part of the point of notmuch was to get rid of the whole dump
idea of folders!

jamie.


signature.asc
Description: Digital signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[notmuch] [PATCH 2/9] Adjust autoload comments

[James Rowe]

On Sat, 28 Nov 2009 09:27:00 -0800, Keith Amidon  
wrote:
> I was interested in them because the gentoo packaging support for emacs
> includes the ability to automatically create autoloads from these
> comments for installed add-on packages that then get loaded system-wide
> when emacs is started.  

  I have to admit I played with elisp-make-autoload-file in my ebuild
initially, but came to the conclusion there wasn't a great deal of
purpose to exposing more than the main notmuch function. Mostly because
it muddies my emacs and shell autocompletion, and my laziness prevailed.
Am I missing some obviously useful things that can be done if
notmuch-{folder,search} are available directly?

  I just pushed out an update that uses it, mostly so I can see the
reaction of my work colleagues in the morning. So, it may or may not be
there by lunchtime GMT tomorrow :)

> I've my own ebuild using this functionality right now that is just
> slightly different from the one that was posted here a little while ago.
> I've been meaning to merge my version with that one but haven't gotten
> to it yet.

  Post a link! If it is better than mine I'll happily switch our
installs to it.

  If you're merging the two please look at the github version[1] as it
is significantly different from the version I originally posted, almost
entirely as a result of the helpful contributions from others.

  I had planned on posting a patch for inclusion in packaging/Gentoo per
Carl's mail[2], but the whole GPL 2 vs 3 thing made me put it on the
backburner and I haven't looked again. Might still be useful to people
unless there is going to be a "real" release soon, as then it would be
easier to push for it on bugs.gentoo.org.

1. http://github.com/JNRowe/misc-overlay/tree/master/mail-client/notmuch/
2. id:87lji1k014.fsf at yoom.home.cworth.org
-- 
Thanks,

James

[notmuch] [PATCH 2/9] Adjust autoload comments

[Keith Amidon]

{-- Fri, 27 Nov 2009 21:06:45 -0800: Carl  wrote: --}

  Carl> On Fri, 27 Nov 2009 05:30:08 -0800, camalot at picnicpark.org wrote:
  Carl> I had a patch (on a side branch that I must have never merged)
  Carl> that just removed these autoload comments. Do these even do
  Carl> anything for a file that's not being built along with all the
  Carl> lisp code within emacs?

I was interested in them because the gentoo packaging support for emacs
includes the ability to automatically create autoloads from these
comments for installed add-on packages that then get loaded system-wide
when emacs is started.  

I've my own ebuild using this functionality right now that is just
slightly different from the one that was posted here a little while ago.
I've been meaning to merge my version with that one but haven't gotten
to it yet.

   --- Keith

Re: [notmuch] [PATCH 2/9] Adjust autoload comments

[Keith Amidon]

{-- Fri, 27 Nov 2009 21:06:45 -0800: Carl cwo...@cworth.org wrote: --}

  Carl On Fri, 27 Nov 2009 05:30:08 -0800, cama...@picnicpark.org wrote:
  Carl I had a patch (on a side branch that I must have never merged)
  Carl that just removed these autoload comments. Do these even do
  Carl anything for a file that's not being built along with all the
  Carl lisp code within emacs?

I was interested in them because the gentoo packaging support for emacs
includes the ability to automatically create autoloads from these
comments for installed add-on packages that then get loaded system-wide
when emacs is started.  

I've my own ebuild using this functionality right now that is just
slightly different from the one that was posted here a little while ago.
I've been meaning to merge my version with that one but haven't gotten
to it yet.

   --- Keith

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Fri, 27 Nov 2009 05:30:08 -0800, camalot at picnicpark.org wrote:
> From: Keith Amidon 
> 
> The previous location of autoload comments didn't seem to correspond
> with the functions most likely to be the entry points for using
> notmuch.  This change adjusts them to match those likely entry points.

I had a patch (on a side branch that I must have never merged) that just
removed these autoload comments. Do these even do anything for a file
that's not being built along with all the lisp code within emacs?

-Carl
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 

[notmuch] [PATCH 2/9] Adjust autoload comments

[cama...@picnicpark.org]

From: Keith Amidon 

The previous location of autoload comments didn't seem to correspond
with the functions most likely to be the entry points for using
notmuch.  This change adjusts them to match those likely entry points.
---
 notmuch.el |6 --
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/notmuch.el b/notmuch.el
index a1efa4f..6400199 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -707,8 +707,6 @@ view, (remove the \"inbox\" tag from each), with
mode-name "notmuch-show")
   (setq buffer-read-only t))

-;;;###autoload
-
 (defgroup notmuch nil
   "Notmuch mail reader for Emacs."
   :group 'mail)
@@ -1002,6 +1000,7 @@ This function advances point to the next line when 
finished."
  (set 'more nil))
   (delete-process proc

+;;;###autoload
 (defun notmuch-search (query  oldest-first)
   "Run \"notmuch search\" with the given query string and display results."
   (interactive "sNotmuch search: ")
@@ -1081,6 +1080,8 @@ current search results AND that are tagged with the given 
tag."
(list (notmuch-select-tag-with-completion "Filter by tag: ")))
   (notmuch-search (concat notmuch-search-query-string " and tag:" tag) 
notmuch-search-oldest-first))

+
+;;;###autoload
 (defun notmuch ()
   "Run notmuch to display all mail with tag of 'inbox'"
   (interactive)
@@ -1156,6 +1157,7 @@ results for the search terms in that line.
 (if search
(notmuch-search (cdr search) notmuch-search-oldest-first

+;;;###autoload
 (defun notmuch-folder ()
   "Show the notmuch folder view and update the displayed counts."
   (interactive)
-- 
1.6.5.3

[notmuch] [PATCH 2/9] Adjust autoload comments

[camalot]

From: Keith Amidon ke...@nicira.com

The previous location of autoload comments didn't seem to correspond
with the functions most likely to be the entry points for using
notmuch.  This change adjusts them to match those likely entry points.
---
 notmuch.el |6 --
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/notmuch.el b/notmuch.el
index a1efa4f..6400199 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -707,8 +707,6 @@ view, (remove the \inbox\ tag from each), with
mode-name notmuch-show)
   (setq buffer-read-only t))
 
-;;;###autoload
-
 (defgroup notmuch nil
   Notmuch mail reader for Emacs.
   :group 'mail)
@@ -1002,6 +1000,7 @@ This function advances point to the next line when 
finished.
  (set 'more nil))
   (delete-process proc
 
+;;;###autoload
 (defun notmuch-search (query optional oldest-first)
   Run \notmuch search\ with the given query string and display results.
   (interactive sNotmuch search: )
@@ -1081,6 +1080,8 @@ current search results AND that are tagged with the given 
tag.
(list (notmuch-select-tag-with-completion Filter by tag: )))
   (notmuch-search (concat notmuch-search-query-string  and tag: tag) 
notmuch-search-oldest-first))
 
+
+;;;###autoload
 (defun notmuch ()
   Run notmuch to display all mail with tag of 'inbox'
   (interactive)
@@ -1156,6 +1157,7 @@ results for the search terms in that line.
 (if search
(notmuch-search (cdr search) notmuch-search-oldest-first
 
+;;;###autoload
 (defun notmuch-folder ()
   Show the notmuch folder view and update the displayed counts.
   (interactive)
-- 
1.6.5.3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [notmuch] [PATCH 2/9] Adjust autoload comments

[Carl Worth]

On Fri, 27 Nov 2009 05:30:08 -0800, cama...@picnicpark.org wrote:
 From: Keith Amidon ke...@nicira.com
 
 The previous location of autoload comments didn't seem to correspond
 with the functions most likely to be the entry points for using
 notmuch.  This change adjusts them to match those likely entry points.

I had a patch (on a side branch that I must have never merged) that just
removed these autoload comments. Do these even do anything for a file
that's not being built along with all the lisp code within emacs?

-Carl


pgp9ZApKH5glr.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch