[jira] [Commented] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-17 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842011#comment-16842011 ] Thomas Mueller commented on OAK-8294: - New patch OAK-8294_v2.patch for review [~catholicon] [~tihom88]

[jira] [Updated] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-17 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8294: Attachment: OAK-8294_v2.patch > Make it possible to mark a (customer) query as bad and skip it >

[jira] [Commented] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-17 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842007#comment-16842007 ] Thomas Mueller commented on OAK-8294: - > I think the match would happen against converted sql2

[jira] [Comment Edited] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-16 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841038#comment-16841038 ] Thomas Mueller edited comment on OAK-8294 at 5/16/19 6:56 AM: -- [~catholicon]

[jira] [Commented] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-16 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841038#comment-16841038 ] Thomas Mueller commented on OAK-8294: - [~catholicon] sorry for the delay. > exact string matches I

[jira] [Commented] (OAK-8309) SLOW_QUERY_COUNT don't get updated for each slow query.

2019-05-16 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841029#comment-16841029 ] Thomas Mueller commented on OAK-8309: - [~tihom88] if you have time, could you remove formatting changes

[jira] [Commented] (OAK-8309) SLOW_QUERY_COUNT don't get updated for each slow query.

2019-05-16 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841025#comment-16841025 ] Thomas Mueller commented on OAK-8309: - The patch looks good! It is a bit large due to formatting

[jira] [Resolved] (OAK-8305) Don't log a warning for queries that use "option(traversal fail)"

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8305. - Resolution: Fixed > Don't log a warning for queries that use "option(traversal fail)" >

[jira] [Updated] (OAK-8305) Don't log a warning for queries that use "option(traversal fail)"

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8305: Fix Version/s: 1.14.0 > Don't log a warning for queries that use "option(traversal fail)" >

[jira] [Commented] (OAK-8305) Don't log a warning for queries that use "option(traversal fail)"

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835540#comment-16835540 ] Thomas Mueller commented on OAK-8305: - http://svn.apache.org/r1858913 (trunk) > Don't log a warning

[jira] [Assigned] (OAK-8305) Don't log a warning for queries that use "option(traversal fail)"

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8305: --- Assignee: Thomas Mueller > Don't log a warning for queries that use "option(traversal fail)"

[jira] [Updated] (OAK-8305) Don't log a warning for queries that use "option(traversal fail)"

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8305: Component/s: query > Don't log a warning for queries that use "option(traversal fail)" >

[jira] [Created] (OAK-8305) Don't log a warning for queries that use "option(traversal fail)"

2019-05-08 Thread Thomas Mueller (JIRA)
Thomas Mueller created OAK-8305: --- Summary: Don't log a warning for queries that use "option(traversal fail)" Key: OAK-8305 URL: https://issues.apache.org/jira/browse/OAK-8305 Project: Jackrabbit Oak

[jira] [Commented] (OAK-8258) Active deletion can delete blobs despite indexing cycle deleting them failed

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835368#comment-16835368 ] Thomas Mueller commented on OAK-8258: - As an alternative to catching Throwable what about setting

[jira] [Commented] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-07 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834498#comment-16834498 ] Thomas Mueller commented on OAK-8294: - > normal string comparison Many queries don't use bind

[jira] [Commented] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832372#comment-16832372 ] Thomas Mueller commented on OAK-8294: - Example query validator json: {noformat} QueryValidatorJson

[jira] [Commented] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832370#comment-16832370 ] Thomas Mueller commented on OAK-8294: - Attached a first patch for review. I don't consider it done, as

[jira] [Updated] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8294: Attachment: OAK-8294.patch > Make it possible to mark a (customer) query as bad and skip it >

[jira] [Created] (OAK-8294) Make it possible to mark a (customer) query as bad and skip it

2019-05-03 Thread Thomas Mueller (JIRA)
Thomas Mueller created OAK-8294: --- Summary: Make it possible to mark a (customer) query as bad and skip it Key: OAK-8294 URL: https://issues.apache.org/jira/browse/OAK-8294 Project: Jackrabbit Oak

[jira] [Commented] (OAK-8271) Lucene path transformed result doesn't accomodate wildcards in relative path

2019-04-24 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825070#comment-16825070 ] Thomas Mueller commented on OAK-8271: - I will need to read the code to understand... Before I do that,

[jira] [Updated] (OAK-7074) Ensure that all Documents are read with document order traversal indexing

2019-04-24 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-7074: Sprint: (was: L16) > Ensure that all Documents are read with document order traversal indexing >

[jira] [Updated] (OAK-7254) Indexes with excludedPaths, or includedPaths should not be picked for queries without path

2019-04-24 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-7254: Sprint: (was: L16) > Indexes with excludedPaths, or includedPaths should not be picked for queries

[jira] [Resolved] (OAK-8167) With uneven distribution of ACL restriction across facet labels statistical facet count become too inaccurate

2019-04-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8167. - Resolution: Won't Fix Assignee: Thomas Mueller > With uneven distribution of ACL restriction

[jira] [Commented] (OAK-8167) With uneven distribution of ACL restriction across facet labels statistical facet count become too inaccurate

2019-04-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824155#comment-16824155 ] Thomas Mueller commented on OAK-8167: - I updated the documentation of facets in

[jira] [Commented] (OAK-8167) With uneven distribution of ACL restriction across facet labels statistical facet count become too inaccurate

2019-04-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824078#comment-16824078 ] Thomas Mueller commented on OAK-8167: - In my view, there are two items: * the security aspect of the

[jira] [Updated] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-04-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8162: Fix Version/s: 1.14.0 > When query with OR is divided into union of queries, options (like index

[jira] [Commented] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-04-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823815#comment-16823815 ] Thomas Mueller commented on OAK-8162: - Fixed in http://svn.apache.org/r1857996 (trunk) > When query

[jira] [Updated] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-04-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8162: Description: When query with OR is divided into union of queries, options (like index tag) are not

[jira] [Updated] (OAK-7256) Query: option to wait for indexes to be updated

2019-04-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-7256: Fix Version/s: (was: 1.14.0) > Query: option to wait for indexes to be updated >

[jira] [Assigned] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-04-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8162: --- Assignee: Thomas Mueller > When query with OR is divided into union of queries, options (like

[jira] [Commented] (OAK-8245) Add column for explained "statement" to "explain" Query result, next to 'plan' column.

2019-04-17 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819768#comment-16819768 ] Thomas Mueller commented on OAK-8245: - Thanks [~madamcin]! I agree it is useful to add the SQL-2

[jira] [Assigned] (OAK-8245) Add column for explained "statement" to "explain" Query result, next to 'plan' column.

2019-04-17 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8245: --- Assignee: Thomas Mueller > Add column for explained "statement" to "explain" Query result,

[jira] [Comment Edited] (OAK-8166) Index definition with orderable property definitions with and without functions breaks index

2019-04-04 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808720#comment-16808720 ] Thomas Mueller edited comment on OAK-8166 at 4/4/19 2:30 PM: - [~tmueller] ,

[jira] [Comment Edited] (OAK-8166) Index definition with orderable property definitions with and without functions breaks index

2019-04-04 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808720#comment-16808720 ] Thomas Mueller edited comment on OAK-8166 at 4/4/19 2:29 PM: - [~tmueller] ,

[jira] [Commented] (OAK-8138) In cases where search hit count is less than sample size defined for statistical mode for facets, secure mode should be used so that the counts are accurate for non-admin

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808760#comment-16808760 ] Thomas Mueller commented on OAK-8138: - [~catholicon] I think you are more familiar in this area, I

[jira] [Resolved] (OAK-8177) Add logging around getReferenceCheckpoint method

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8177. - Resolution: Fixed Fix Version/s: 1.12.0 > Add logging around getReferenceCheckpoint method

[jira] [Commented] (OAK-8177) Add logging around getReferenceCheckpoint method

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808755#comment-16808755 ] Thomas Mueller commented on OAK-8177: - [~nitigup] no problem! Sorry for not seeing this earlier...

[jira] [Assigned] (OAK-8177) Add logging around getReferenceCheckpoint method

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8177: --- Assignee: Thomas Mueller > Add logging around getReferenceCheckpoint method >

[jira] [Commented] (OAK-8166) Index definition with orderable property definitions with and without functions breaks index

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808699#comment-16808699 ] Thomas Mueller commented on OAK-8166: - Could you check if my understanding is correct? I think the

[jira] [Resolved] (OAK-8189) Getting warning message in error logs while trying to search using filters

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8189. - Resolution: Fixed http://svn.apache.org/r1856862 (trunk) > Getting warning message in error logs

[jira] [Updated] (OAK-8189) Getting warning message in error logs while trying to search using filters

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8189: Fix Version/s: 1.12.0 > Getting warning message in error logs while trying to search using filters >

[jira] [Assigned] (OAK-8189) Getting warning message in error logs while trying to search using filters

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8189: --- Assignee: Thomas Mueller > Getting warning message in error logs while trying to search using

[jira] [Resolved] (OAK-8134) Index Copier Stats MBean shows stale info

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8134. - Resolution: Fixed > Index Copier Stats MBean shows stale info >

[jira] [Commented] (OAK-8134) Index Copier Stats MBean shows stale info

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808438#comment-16808438 ] Thomas Mueller commented on OAK-8134: - http://svn.apache.org/r1856854 (trunk) > Index Copier Stats

[jira] [Updated] (OAK-8134) Index Copier Stats MBean shows stale info

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8134: Fix Version/s: 1.12.0 > Index Copier Stats MBean shows stale info >

[jira] [Resolved] (OAK-7947) Lazy loading of Lucene index files startup

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-7947. - Resolution: Fixed I consider this closed for now. Related / follow up issues will be tracked

[jira] [Commented] (OAK-8134) Index Copier Stats MBean shows stale info

2019-04-03 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808427#comment-16808427 ] Thomas Mueller commented on OAK-8134: - Looks good! I will apply the patch. > Index Copier Stats MBean

[jira] [Commented] (OAK-8177) Add logging around getReferenceCheckpoint method

2019-04-02 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807758#comment-16807758 ] Thomas Mueller commented on OAK-8177: - I don't think the comment "// Additional logging needed for " is

[jira] [Commented] (OAK-8177) Add logging around getReferenceCheckpoint method

2019-04-02 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807755#comment-16807755 ] Thomas Mueller commented on OAK-8177: - I think the first "log.info("Getting checkpoint info for {}",

[jira] [Commented] (OAK-8166) Index definition with orderable property definitions with and without functions breaks index

2019-04-02 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807638#comment-16807638 ] Thomas Mueller commented on OAK-8166: - > this only happens in case the properties defined on this index

[jira] [Commented] (OAK-8177) Add logging around getReferenceCheckpoint method

2019-03-29 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804733#comment-16804733 ] Thomas Mueller commented on OAK-8177: - About logging a stack trace, I think it's sufficient to do this:

[jira] [Updated] (OAK-7731) Order by jcr:score descending is not always ignored

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-7731: Fix Version/s: 1.12.0 > Order by jcr:score descending is not always ignored >

[jira] [Resolved] (OAK-7731) Order by jcr:score descending is not always ignored

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-7731. - Resolution: Fixed > Order by jcr:score descending is not always ignored >

[jira] [Commented] (OAK-7731) Order by jcr:score descending is not always ignored

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804020#comment-16804020 ] Thomas Mueller commented on OAK-7731: - http://svn.apache.org/r1856483 (trunk, test case) > Order by

[jira] [Commented] (OAK-7731) Order by jcr:score descending is not always ignored

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804009#comment-16804009 ] Thomas Mueller commented on OAK-7731: - http://svn.apache.org/r1856481 (trunk) > Order by jcr:score

[jira] [Commented] (OAK-7731) Order by jcr:score descending is not always ignored

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803984#comment-16803984 ] Thomas Mueller commented on OAK-7731: - The patch looks good to me, thanks! However... I will add a

[jira] [Assigned] (OAK-8134) Index Copier Stats MBean shows stale info

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8134: --- Assignee: Thomas Mueller > Index Copier Stats MBean shows stale info >

[jira] [Resolved] (OAK-8116) Expose text extraction metrics as sling metrics

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8116. - Resolution: Fixed Fix Version/s: 1.12.0 > Expose text extraction metrics as sling metrics >

[jira] [Commented] (OAK-8116) Expose text extraction metrics as sling metrics

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803900#comment-16803900 ] Thomas Mueller commented on OAK-8116: - Changes I made: I only called

[jira] [Commented] (OAK-8116) Expose text extraction metrics as sling metrics

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803898#comment-16803898 ] Thomas Mueller commented on OAK-8116: - http://svn.apache.org/r1856472 > Expose text extraction

[jira] [Commented] (OAK-8116) Expose text extraction metrics as sling metrics

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803870#comment-16803870 ] Thomas Mueller commented on OAK-8116: - Thanks a lot [~tihom88] for the patch! It looks good to me now.

[jira] [Assigned] (OAK-8116) Expose text extraction metrics as sling metrics

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8116: --- Assignee: Thomas Mueller > Expose text extraction metrics as sling metrics >

[jira] [Assigned] (OAK-7731) Order by jcr:score descending is not always ignored

2019-03-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-7731: --- Assignee: Thomas Mueller > Order by jcr:score descending is not always ignored >

[jira] [Resolved] (OAK-7991) Composite node store: tests with queries

2019-03-22 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-7991. - Resolution: Fixed > Composite node store: tests with queries >

[jira] [Updated] (OAK-7991) Composite node store: tests with queries

2019-03-22 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-7991: Fix Version/s: 1.12 > Composite node store: tests with queries >

[jira] [Commented] (OAK-7991) Composite node store: tests with queries

2019-03-22 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798843#comment-16798843 ] Thomas Mueller commented on OAK-7991: - http://svn.apache.org/r1856033 (code documentation) > Composite

[jira] [Updated] (OAK-8126) Load Lucene index files before writing to the index: close directory

2019-03-20 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8126: Fix Version/s: 1.12 > Load Lucene index files before writing to the index: close directory >

[jira] [Commented] (OAK-7991) Composite node store: tests with queries

2019-03-20 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797200#comment-16797200 ] Thomas Mueller commented on OAK-7991: - I also found that the index isn't built if a hidden node

[jira] [Commented] (OAK-7991) Composite node store: tests with queries

2019-03-20 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797196#comment-16797196 ] Thomas Mueller commented on OAK-7991: - http://svn.apache.org/r1855907 > Composite node store: tests

[jira] [Resolved] (OAK-8126) Load Lucene index files before writing to the index: close directory

2019-03-20 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8126. - Resolution: Fixed > Load Lucene index files before writing to the index: close directory >

[jira] [Commented] (OAK-8126) Load Lucene index files before writing to the index: close directory

2019-03-20 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797195#comment-16797195 ] Thomas Mueller commented on OAK-8126: - http://svn.apache.org/r1855906 > Load Lucene index files before

[jira] [Commented] (OAK-8134) Index Copier Stats MBean shows stale info

2019-03-19 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796106#comment-16796106 ] Thomas Mueller commented on OAK-8134: - Comments: The method "int totalLocalIndexes(Map> mapping)" is

[jira] [Commented] (OAK-8116) Expose text extraction metrics as sling metrics

2019-03-19 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796084#comment-16796084 ] Thomas Mueller commented on OAK-8116: - [~tihom88] comments: extractedTextCache.getStatisticsProvider()

[jira] [Commented] (OAK-8138) In cases where search hit count is less than sample size defined for statistical mode for facets, secure mode should be used so that the counts are accurate for non-admin

2019-03-19 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795977#comment-16795977 ] Thomas Mueller commented on OAK-8138: - If the space is missing, then it reads like

[jira] [Commented] (OAK-8138) In cases where search hit count is less than sample size defined for statistical mode for facets, secure mode should be used so that the counts are accurate for non-admin

2019-03-19 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795976#comment-16795976 ] Thomas Mueller commented on OAK-8138: - [~nitigup] the patch looks good to me! It's good to have this

[jira] [Commented] (OAK-8114) IndexDefinitionBuilder should be smarter when to reindex while updating a definition

2019-03-15 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793395#comment-16793395 ] Thomas Mueller commented on OAK-8114: - I'm wondering, is there a test case that contains changes that

[jira] [Created] (OAK-8126) Load Lucene index files before writing to the index: close directory

2019-03-13 Thread Thomas Mueller (JIRA)
Thomas Mueller created OAK-8126: --- Summary: Load Lucene index files before writing to the index: close directory Key: OAK-8126 URL: https://issues.apache.org/jira/browse/OAK-8126 Project: Jackrabbit Oak

[jira] [Commented] (OAK-8114) IndexDefinitionBuilder should be smarter when to reindex while updating a definition

2019-03-12 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790360#comment-16790360 ] Thomas Mueller commented on OAK-8114: - If the documentation is not clear, we need to improve it...

[jira] [Commented] (OAK-8097) Load Lucene index files before writing to the index

2019-03-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784487#comment-16784487 ] Thomas Mueller commented on OAK-8097: - [~catholicon] feedback is welcome. > Load Lucene index files

[jira] [Resolved] (OAK-8097) Load Lucene index files before writing to the index

2019-03-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8097. - Resolution: Fixed > Load Lucene index files before writing to the index >

[jira] [Commented] (OAK-8097) Load Lucene index files before writing to the index

2019-03-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784485#comment-16784485 ] Thomas Mueller commented on OAK-8097: - I think I will keep the implementation for now. To me it seems

[jira] [Assigned] (OAK-8097) Load Lucene index files before writing to the index

2019-03-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8097: --- Assignee: Thomas Mueller > Load Lucene index files before writing to the index >

[jira] [Commented] (OAK-8097) Load Lucene index files before writing to the index

2019-03-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784461#comment-16784461 ] Thomas Mueller commented on OAK-8097: - http://svn.apache.org/r1854855 (trunk) > Load Lucene index

[jira] [Commented] (OAK-8051) PersistentCache: error during open can lead to incomplete initialization and subsequent NPEs

2019-03-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784399#comment-16784399 ] Thomas Mueller commented on OAK-8051: - Sorry... the changes look good to me! > PersistentCache: error

[jira] [Commented] (OAK-8097) Load Lucene index files before writing to the index

2019-03-01 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781500#comment-16781500 ] Thomas Mueller commented on OAK-8097: - Test: sure, I agree :-) I don't consider this issue fixed right

[jira] [Commented] (OAK-8097) Load Lucene index files before writing to the index

2019-03-01 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781471#comment-16781471 ] Thomas Mueller commented on OAK-8097: - http://svn.apache.org/r1854565 (trunk) A review would still be

[jira] [Updated] (OAK-8097) Load Lucene index files before writing to the index

2019-03-01 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8097: Fix Version/s: 1.12 > Load Lucene index files before writing to the index >

[jira] [Commented] (OAK-8097) Load Lucene index files before writing to the index

2019-02-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780717#comment-16780717 ] Thomas Mueller commented on OAK-8097: - Possible patch, [~catholicon] could you review please? I locally

[jira] [Created] (OAK-8097) Load Lucene index files before writing to the index

2019-02-28 Thread Thomas Mueller (JIRA)
Thomas Mueller created OAK-8097: --- Summary: Load Lucene index files before writing to the index Key: OAK-8097 URL: https://issues.apache.org/jira/browse/OAK-8097 Project: Jackrabbit Oak Issue

[jira] [Commented] (OAK-8051) PersistentCache: error during open can lead to incomplete initialization and subsequent NPEs

2019-02-26 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777819#comment-16777819 ] Thomas Mueller commented on OAK-8051: - [~reschke] is it OK if I commit my patch? > PersistentCache:

[jira] [Updated] (OAK-8046) Result items are not always correctly counted against the configured read limit if a query uses a lucene index

2019-02-26 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8046: Issue Type: Improvement (was: Bug) > Result items are not always correctly counted against the

[jira] [Updated] (OAK-8067) Measure fsync (called when closing the NRT index) and try to reduce disk I/O

2019-02-22 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8067: Fix Version/s: 1.10.1 > Measure fsync (called when closing the NRT index) and try to reduce disk I/O

[jira] [Resolved] (OAK-8067) Measure fsync (called when closing the NRT index) and try to reduce disk I/O

2019-02-22 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8067. - Resolution: Fixed Closing the issue now. Backport might be needed, but first let's test this. >

[jira] [Commented] (OAK-8051) PersistentCache: error during open can lead to incomplete initialization and subsequent NPEs

2019-02-22 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774920#comment-16774920 ] Thomas Mueller commented on OAK-8051: - > The patch broke the test (that's why I @ignored it) because

[jira] [Commented] (OAK-8067) Measure fsync (called when closing the NRT index) and try to reduce disk I/O

2019-02-21 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774863#comment-16774863 ] Thomas Mueller commented on OAK-8067: - http://svn.apache.org/r1854115 (trunk) FYI [~catholicon] >

[jira] [Updated] (OAK-8067) Measure fsync (called when closing the NRT index) and try to reduce disk I/O

2019-02-21 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8067: Summary: Measure fsync (called when closing the NRT index) and try to reduce disk I/O (was: Measure

[jira] [Commented] (OAK-8067) Measure fsync (called when closing the NRT index)

2019-02-21 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774850#comment-16774850 ] Thomas Mueller commented on OAK-8067: - As we have "FileUtils.deleteQuietly(indexDir)" right after

[jira] [Commented] (OAK-8067) Measure fsync (called when closing the NRT index)

2019-02-21 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774143#comment-16774143 ] Thomas Mueller commented on OAK-8067: - I removed the "deleteAll" call. Still, I kept close(false),

[jira] [Commented] (OAK-8051) PersistentCache: error during open can lead to incomplete initialization and subsequent NPEs

2019-02-21 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774151#comment-16774151 ] Thomas Mueller commented on OAK-8051: - > Actually what's wrong is that if the first attempt to open the

[jira] [Commented] (OAK-8067) Measure fsync (called when closing the NRT index)

2019-02-21 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774145#comment-16774145 ] Thomas Mueller commented on OAK-8067: - http://svn.apache.org/r1854057 > Measure fsync (called when

<    5   6   7   8   9   10   11   12   13   14   >