[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327087#comment-15327087
]
Davide Giannella commented on OAK-3263:
---
[~chetanm], [~baedke] there was a request to backport this
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725008#comment-14725008
]
Thomas Mueller commented on OAK-3263:
-
svn.apache.org/r1700425 (trunk)
Not included is support for
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725081#comment-14725081
]
Thomas Mueller commented on OAK-3263:
-
http://svn.apache.org/r1700451 (oak-lucene, trunk)
> Support
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725004#comment-14725004
]
Thomas Mueller commented on OAK-3263:
-
> On the other hand, what's the point then of allowing
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725044#comment-14725044
]
Thomas Mueller commented on OAK-3263:
-
http://svn.apache.org/r1700434 (doc)
> Support including and
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718187#comment-14718187
]
Thomas Mueller commented on OAK-3263:
-
If the path restriction is /a, the includedPath
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718195#comment-14718195
]
Thomas Mueller commented on OAK-3263:
-
About the queryPaths: I think I remember now how
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720303#comment-14720303
]
Manfred Baedke commented on OAK-3263:
-
[~tmueller],
bq. I think no. Let's say the query
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720312#comment-14720312
]
Manfred Baedke commented on OAK-3263:
-
bq. That way, it is possible to force using the
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716729#comment-14716729
]
Manfred Baedke commented on OAK-3263:
-
[~tmueller],
bq. I would switch the logic here
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716653#comment-14716653
]
Thomas Mueller commented on OAK-3263:
-
I think PropertyIndexTest.testPathIncludeExclude
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716655#comment-14716655
]
Manfred Baedke commented on OAK-3263:
-
Hi [~tmueller],
Thanks for reviewing.
bq. Do
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716663#comment-14716663
]
Thomas Mueller commented on OAK-3263:
-
Still missing:
* Additional unit tests for
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717099#comment-14717099
]
Manfred Baedke commented on OAK-3263:
-
[~tmueller],
I don't understand your changes in
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717057#comment-14717057
]
Manfred Baedke commented on OAK-3263:
-
[~tmueller], currenttly oak-core tests hang on my
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716403#comment-14716403
]
Thomas Mueller commented on OAK-3263:
-
A few remarks:
{noformat}
if
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716493#comment-14716493
]
Thomas Mueller commented on OAK-3263:
-
The method name and the documentation for
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716531#comment-14716531
]
Thomas Mueller commented on OAK-3263:
-
Looking at PathFilter (before the patch): The
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716535#comment-14716535
]
Thomas Mueller commented on OAK-3263:
-
In the patch, the property indexes now uses
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716537#comment-14716537
]
Thomas Mueller commented on OAK-3263:
-
Even thought the PathFilter class was extended,
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716547#comment-14716547
]
Thomas Mueller commented on OAK-3263:
-
Do the existing unit tests work for you with the
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14711339#comment-14711339
]
Manfred Baedke commented on OAK-3263:
-
Thx [~chetanm], [~mueller],
bq .May be in leave
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710699#comment-14710699
]
Thomas Mueller commented on OAK-3263:
-
According to the fix version, it just looks like
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710701#comment-14710701
]
Thomas Mueller commented on OAK-3263:
-
PropertyIndexPlan
Looking at the history, this
[
https://issues.apache.org/jira/browse/OAK-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710664#comment-14710664
]
Chetan Mehrotra commented on OAK-3263:
--
Approach looks fine. May be in leave method
25 matches
Mail list logo
