Jarko Poutiainen wrote:
Hi,
I have agreed with Sjur that I would take ownership of this.
...
- Owner: Sjur Brændeland sjur.brandel...@stericsson.com
+ Owner: Jarko Poutiainen jarko.poutiai...@tieto.com
Acked-by: Sjur Brændeland sjur.brandel...@stericsson.com
Regards
/Sjur
From: Sjur Brændeland sjur.brandel...@stericsson.com
With latest changes the P-CSCF addresses from ISIM can be read
from the IpMultimediaIdentity objects and the P-CSCF addresses
returned as dynamic parameters for the PDN Connection are avilable
in the ConnectionContext object.
I have also added
Hi Rémi,
+ boolean PreConditionCheck(string Type, string
PeerAddress, + uint16 PeerPort,
uint16 LocalPort) +
That stuff is per context. Should it not be in the context object rather
than in the IMS manager?
oFono should only
From: Sjur Brændeland sjur.brandel...@stericsson.com
Thanks for lots of useful feedback from last RFC,
here is my next revision on the LTE/IMS API.
Comments are still very much welcome!
Changes from RFC-V1:
- Renamed IMS to IpMultimediaSubsystem (some places)
- Changed
Hi Rémi,
+Service org.ofono
+Interface org.ofono.IpMultimediaSubsystem
+Object path [variable prefix]
I guess this is meant to be a modem object path, but it seems the oFono
documentation is already a bit sloppy on this point.
Yes, this should be the modem object path.
Hi Redouane,
+ void UnRegister(object path)
+
+ Un-register a IpMultimediaSubsystemAgent.
Register and UnRegister functions are not really symmetric here ...
How object path is used by UnRegister function ??
Maybe we should have :
void UnRegister(string
Hi Pekka.
Do you think we will ever have more than one IMS ConnectionContext pr SIM?
If not not we could probably keep the PcscfAddresses in this IMS API (see
object-path proposal below).
Unfortunately, yes.
Could you please elaborate on this.
Do you really foresee a scenario where an
From: Simon Lethbridge simon.lethbri...@stericsson.com
This patch introduces support for Global Satellite Navigation System (GNSS),
using the AT commands AT+CPOS and +CPOSR as specified 3GPP 27.007.
---
Changes from v1 (28 Jan):
s/SendPositioningControl/SendPositioningElement/
Thanks Rémi, for
From: Simon Lethbridge simon.lethbri...@stericsson.com
This patch introduces support for Global Satellite Navigation System (GNSS),
using the AT commands AT+CPOS and +CPOSR as specified 3GPP 27.007.
---
Hi Denis,
2010/11/30 Denis Kenzior denk...@gmail.com:
+AssistedSatelliteNavigation hierarchy
Hi,
+ dict IPv6Settings [readonly, optional]
+
+ Holds all the IPv6 network settings.
+
+ string Interface [readonly, optional]
+
+ Holds the name of the IPv6 network interface
+
Hi Rémi,
- The QoS information is presented as an array of QoS settings with
an associated list IP Packet Filters. Only the QoS data for
connection context of type IMS will be reported.
The assumption is that QoS is only going to be used by IMS applications.
Initially I was planning
Hi Pekka,
Features:
- The QoS information is presented as an array of QoS settings with
an associated list IP Packet Filters. Only the QoS data for
connection context of type IMS will be reported.
The assumption is that QoS is only going to be used by IMS applications.
Initially I was
Hi,
I notice that there has been a couple of bug reports sent on this list lately,
and usually the response is care to send a patch for it?.
oFono homepage states: A bug tracking system is in the process of
being set up.
What is the status of this?
It seems to be possible to submit bugs on
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
I think we should consider changing the way we handle
signal strength in oFono.
In the past I have seen very frequent signal strength
reports from the modem under certain network conditions.
I think we can improve the power consumption
Hi,
Pekka Pessi ppe...@gmail.com wrote:
The 27.007 for release 9 (from version 9.3.0 onwards) says:
NOTE 1: The cids for network-initiated PDP contexts will have values
outside the ranges indicated for the
cid in the test form of the commands +CGDCONT and +CGDSCONT.
The change was proposed
Hi,
So far we have been discussing CID races, but if we solve the CID issue,
we still might end up with two identical Connections activated with the same
connection properties (APN, Username, Password), one initiated by the modem
in the LTE Combined Attach procedure and the other being a normal
Hi Pekka.
Pekka Pessi ppe...@gmail.com wrote:
I'm not sure we have any problems with Network Initiated Connection in oFono,
unless someone is planning to add support for Network Initiated
Primary Contexts / PDN Connections.
AFAIK the initial LTE default bearer context can be
Hi Tomasz, don't worry the tone on the list is quite rough. If you
like marit or I can review tomorrow, but feel free to send patch as
well if you like. :) Sjur
2011/1/12, Tomasz Gregorek tomasz.grego...@gmail.com:
Hi Marcel
I already had my solution in head and misunderstood you. I will
Hi Marcel.
+static void get_modems()
+{
so these are declared as get_modems(void) btw. The compiler should have
warned you about this.
I don't get a compiler warning for this one, not even with -Wall
-Wextra -Wpedantic on GCC 4.4.3.
But a new rule in the coding-style should perhaps be
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
Marcel, Denis,
Here is the patch, please apply it if you agree. I'm easy :-)
Regards,
Sjur
doc/coding-style.txt | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/doc/coding-style.txt b/doc/coding
Hi Marcel.
you are out of luck today ;)
Darn, I forgot to pull. Hang on I'll be back shortly
Regards,
Sjur
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch introduces auto discovery of ST-Ericsson modems.
ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a
Modem Init Daemon responsible for start, power cycles,
flashing etc. This STE plugin monitors the modem state exposed
from
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch introduces auto discovery of ST-Ericsson modems.
ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a
Modem Init Daemon responsible for start, power cycles,
flashing etc. This STE plugin monitors the modem state exposed
from
Hi Martin.
On Thu, Jan 6, 2011 at 10:46 AM, martin...@intel.com wrote:
From: blutolan bluto...@blutolan-desktop.(none)
Your git-config is wrong, you need to set name and email right in your
git-config before committing.
Regards,
Sjur
___
ofono
Hi Redouane,
...
+static void gprs_cid_take(struct ofono_gprs *gprs, unsigned int id)
+{
+ idmap_take(gprs-cid_map, id);
+}
+
How do we assure that this CID is not already in use?
I think the M7400 is going to use CID=0 and M700 uses CID=1.
Perhaps we should make sure CID=0 is a legal
Hi,
From my understanding the ID in the core is an internal ID for oFono core,
even if today we usually have a mapping 1 to 1 between oFono core ID and
modems CID.
Denis, Marcel could you confirm ?
Negative, to my understanding the CID is allocated in src/gprs.c and used
when
From: Sjur Brændeland sjur.brandel...@stericsson.com
This is the latest version of the Modem Init Daemon API.
STE Modem Init Deamon Manager
=
Service com.stericsson.modeminit
Interface com.stericsson.modeminit.Manager
Object path /
Methods
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch introduces auto discovery of ST-Ericsson modems.
ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a
Modem Init Daemon responsible for start, power cycles,
flashing etc. This STE plugin monitors the modem state exposed
from
Hi Marcel.
is this the full API or only part of it. If it is just a part of it,
please send the full API for the daemon. Just looking at this piece, I
am not really thinking that this is a good API. It is actually pretty
much broken :(
Ok, here's an updated version of the Modem Init Daemon
Hi Marcel,
Signals StateChange(string State)
The modems state sent from when
a modem state change occurs. State is the only
dynamic property in this Interface.
I would personally just go straight for PropertyChanged
Hi Marcel,
what about potential USB based CAIF devices?
Good question, but in a Bridge Setup for a phone this will not really
be devices that come and go.
I belive it will still be a fixed HW setup where the Modem Init Daemon
will have static knowledge of the
USB modems. But I'll discuss this
Hi Marcel.
+
+/* ResetState requests resending of StateChange. */
+#define MID_RESEND_STATE ResendState
This is a bad D-Bus API btw. Using a D-Bus method to trigger signal
sending. You will wake up any listener for that signal. What is wrong
with just having a GetState?
My problem is
Hi Marcel.
This is a bad D-Bus API btw. Using a D-Bus method to trigger signal
sending. You will wake up any listener for that signal. What is wrong
with just having a GetState?
My problem is that I need to get the path, or modem serial-number if
you like, to the
modem(s). As I don't
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch introduces auto discovery of ST-Ericsson modems.
ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a
Modem Init Daemon responsible for start, power cycles,
flashing etc. This STE plugin monitors the modem state exposed
from
Hi Kris,
I am trying to understand CAIF protocol implementation in OFono. I am
getting Failed to create CAIF socket for AT when i am trying to enable my
modem.
Maybe the easies way to check if you have CAIF running is to try out
unit/test-caif.
It will try to open a CAIF Socket to the modem
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch introduces auto discovery of ST-Ericsson modems.
ST-Ericsson modems (M5XX, M57XX, M7XX, M74XX) are managed by a
Modem Init Daemon responsible for start, power cycles,
flashing etc. This STE plugin monitors the modem state exposed
From: Sjur Brændeland sjur.brandel...@stericsson.com
Changes:
o Restructure code so interfaces are created statically when probe is called,
instead of creating interfaces dynamically at activation.
o Changed debug messages.
o Removed some of the unnecessary initializations at declaration.
o
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/stemodem/gprs-context.c | 43 --
1 files changed, 36 insertions(+), 7 deletions(-)
diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c
index 7bdcdb8..1762fb3 100644
Hi Marcel,
Marcel Holtmann wrote:
Or should oFono automatically create a Connection Context?
Furthermore, should oFono automatically proceed and
set Active=true, bind the connection to a network interface
and set network interface in state UP,
Definitely not. This would interfere with
From: Sjur Brændeland sjur.brandel...@stericsson.com
Changes:
o Restructure code so interfaces are created statically when probe is called,
instead of creating interfaces dynamically at activation.
o Changed debug messages.
o Removed some of the unnecessary initializations at declaration.
o
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/stemodem/gprs-context.c | 44 --
1 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c
index bfc0d65..21ca126 100644
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch introduces auto discovery of ST-Ericsson modems.
ST-Ericsson modems (M57XX, M7XX, M74XX) are managed by a
Modem Init Daemon that is responsible for start/stop/restart
flashing etc. This STE plugin monitors the modem state exposed
From: Simon Lethbridge simon.lethbri...@stericsson.com
This is our second proposal for the Assisted Satellite Navigation API,
this time including an Agent API. Hopefully most of the review comments
on our last proposal are included here.
As you can see we have changed the name again, this time
From: Sjur Brændeland sjur.brandel...@stericsson.com
Changes:
o Restructure code so interfaces are created statically when probe is called.
o Removed some of the unnecessary initializations at declaration.
o No longer reporting default gateway on PtP IP Interface.
o Bugfix: Handle network
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/stemodem/gprs-context.c | 43 ++-
1 files changed, 42 insertions(+), 1 deletions(-)
diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c
index 3ccda87..3859107 100644
From: Sjur Brændeland sjur.brandel...@stericsson.com
Use the type __u32 for sequence counting rather than guint32,
and void * instead of gpointer.
Reduce the size of RTNL message buffer from 4096 to 1024,
as this should be sufficient to hold the NEWLINK message.
---
Last patch was sent
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch set introduces unit tests for functionality in
o CAIF RTNL functions in drivers/stemodem/caif_rtnl.c
o GPRS context handling in drivers/stemodem/gprs-context.c
o Radio State settings in drivers/stemodem/radio-settings.c
o Test
From: Sjur Brændeland sjur.brandel...@stericsson.com
- Remove tests for CAIF Character device. Character devices are depreceated
and replaced with Sockets.
- Add RTNL Tests for creating and removing CAIF GPRS Network Interface.
---
Makefile.am |4 +-
unit/test-caif.c | 108
Hi George.
it looks as if two functions:
caif_if_create/remove (struct conn_info *conn)
do nothing but verify the return results of functions:
caif_rtnl_create_interface/caif_rtnl_delete_interface
declared in in caif_rtnl.h
Which means if you #include caif_rtnl.h in gprs-context.c
From: Sjur Brændeland sjur.brandel...@stericsson.com
Changes:
o Restructure code so interfaces are created statically when probe is called.
o Removed some of the unnecessary initializations at declaration.
o No longer reporting default gateway on PtP IP Interface.
o Bugfix: Handle network
Hi Denis Marcel.
From: Sjur Brændeland sjur.brandel...@stericsson.com
Changes:
o Restructure code so interfaces are created statically when probe is called.
o Removed some of the unnecessary initializations at declaration.
o No longer reporting default gateway on PtP IP Interface.
o
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch introduces auto discovery of ST-Ericsson modems.
ST-Ericsson modems are managed by a Modem Init Daemon that
is responsible for start/stop/restart flashing etc. The
STE plugin monitors the modem state exposed from the
Modem Init Damon
Hi Marcel.
So far this looks like a nice and simple proposal. And it is driven by
an existing standard. I like that.
Sjur, are you guys up to the task of sending an initial atom
implementation and atmodem driver for it?
Yes, I think we should be able to, as longs as there is no big hurry.
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
doc/coding-style.txt |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/doc/coding-style.txt b/doc/coding-style.txt
index 6fa355e..fb43891 100644
--- a/doc/coding-style.txt
+++ b/doc/coding-style.txt
@@ -205,6
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
TODO |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/TODO b/TODO
index bf2305b..dec43fd 100644
--- a/TODO
+++ b/TODO
@@ -496,3 +496,11 @@ Miscellaneous
Priority: Low
Complexity: C4
+
+- Add Location
From: Sjur Brændeland sjur.brandel...@stericsson.com
Use the type __u32 for sequence counting rather than guint32,
and void * instead of gpointer.
Reduce the size of RTNL message buffer from 4096 to 1024,
as this should be sufficient to hold the NEWLINK message.
---
drivers/stemodem/caif_rtnl.c
Hi Marcel.
- struct conn_info *conn;
+ struct conn_info *conn = NULL;
GSList *l;
why do you need the conn = NULL assignment here? I haven't even looked
into your code flow, but I prefer clearly to not have these.
I have removed this and tried to remove some of the other
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
Makefile.am |2 +
drivers/stemodem/caif_rtnl.c | 340 ++
drivers/stemodem/caif_rtnl.h | 29
3 files changed, 371 insertions(+), 0 deletions(-)
create mode 100644 drivers
From: Sjur Brændeland sjur.brandel...@stericsson.com
Create the network interfaces statically at start up
instead of dynamically for each PDP activation.
---
drivers/stemodem/gprs-context.c | 98 --
1 files changed, 52 insertions(+), 46 deletions(-)
diff
From: Sjur Brændeland sjur.brandel...@stericsson.com
Use rtnl_caif_* functions to create network interfaces.
The conn_info struct is also re-structured in order to
hold the relevant information for network interfaces.
---
drivers/stemodem/gprs-context.c | 76
Hi Marcel.
I do need another look at the RTNL magic and casting. That always drives
my crazy when I look at that. In the meantime, please address these
details first.
I have some RTNL unit tests ready if your're interested.
Also I hope I have closed most open issues from your review
in the v4
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/stemodem/gprs-context.c | 207 +--
1 files changed, 135 insertions(+), 72 deletions(-)
diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c
index 9f59579..4260d31
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
Hi Marcel.
I'm sorry about the formatting for the v3 version of this patch.
I used git send-email via my gmail account, and ended up with base64
MIME content encoding. I dont' know what went wrong :-(
I think I have closed most of your
Hi,
So in general I'm currently against introducing this API as oFono
official API. I suggest prefixing this with an IFX specific identifier.
Maybe modem.ifx.AgpsManager.
I would actually go one step further and call this com.infineon.Agps or
something like that.
As I stated this many
Hi Marcel.
+int caif_rtnl_init(void)
+{
+ struct sockaddr_nl addr;
+ int sk, err;
+ GError *gerr = NULL;
+
+ sk = socket(PF_NETLINK, SOCK_DGRAM, NETLINK_ROUTE);
+ if (sk 0)
+ return sk;
+
+ memset(addr, 0, sizeof(addr));
+
From: Sjur Brændeland sjur.brandel...@stericsson.com
This patch introduces auto discovery of ST-Ericsson modems.
ST-Ericsson modems are managed by a Modem Init Daemon which
is responsible for start/stop/restart flashing etc. The
STE plugin monitors the modem state exposed from the
Modem Init
Hi Marcel.
On positioning framework side, XML containers encoding/decoding does not
seem to be yet widely used, while the support of RRC and RRLP framing is
common, thanks to the support of SUPL.
Using XML and 27.007 format would be great as long as long as ofono is not
obliged to
Hi Denis,
What are the possible reasons as to why oFono might need to peek inside
the XML?
I was previously under the false impression that you wanted oFono API
to export AGPS functionality using dbus types only. Piping the AGPS
XML (or ASN.1 coded data)
through oFono certainly makes the oFono
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
Hi Marcel.
I hope I have closed most of your review comments so far.
I had a go at using g_io_chanel_write_chars, but couldn't make it work,
and I (stubbornly ;-) do g_caif_devices = NULL, just in case someone choose
to call caif_rtnl_init
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
drivers/stemodem/gprs-context.c | 207 +--
1 files changed, 135 insertions(+), 72 deletions(-)
diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c
index 9f59579..4260d31
Hi Denis,
Fredric wrote:
On positioning framework side, XML containers encoding/decoding does not seem
to be yet widely used, while the support of RRC and RRLP framing is common,
thanks to the support of SUPL.
Using XML and 27.007 format would be great as long as long as ofono is not
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
Changes from last patch-set:
o squashed previous patches for rtnl.c, rtnl.h and Makefile.am into one patch
o renamed rtnl.[ch] to caif_rtnl.[ch]
o renamed rtnl_init and rtnl_exit to caif_rtnl_*
o renamed rtnl_create_caif_interface
From: Sjur Brændeland sjur.brandel...@stericsson.com
Add new asynchronous rtnl interface for creating and deleting
CAIF Network interfaces.
Creation takes struct rtnl_req_param as input containing
ip type (v4/v6), channel id etc. The result is returned in
struct rtnl_rsp_param containing
From: Sjur Brændeland sjur.brandel...@stericsson.com
Add file rtnl.c for creating and deleting CAIF network
interfaces using the RTNL protocol. The interface is
asynchronous.
Only RTNL NEWLINK and DELLINK commands are implemented.
CAIF requires NEWLINK to contain channel-id and ip-type
(ipv4
From: Sjur Brændeland sjur.brandel...@stericsson.com
RTNL is now used to create and remove CAIF network interfaces.
The created CAIF interface is assigned a channel-id which is
used as parameter in the AT*EPPSD command used to activate the
PDP-Context.
The CAIF Network interfaces are created
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
Makefile.am |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 2562160..1b09a3c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -226,6 +226,8 @@ builtin_sources += drivers/atmodem
[Marcel]
STE version needs testing by the STE guys, but I did run into some SIM
not ready issues with MBM when switching online/offline a few times. So
that needs to be looked into.
OK, I'll put in on our list.
Perhaps you could send me thelogs if you still have them around?
Regards
Sjur
Marcel Holtmann mar...@holtmann.org wrote:
maybe the STE modem is a bit more specific here than the MBM one. Which
MBM modem did you test this with?
I have been using MBM as template for my sim ready changes, so I don't think
there is any point at looking at STE driver at this point in time.
This patch adds a new module rtnl.[ch] for creating and deleting a
CAIF Network Interface. The rtnl module uses standard RTNL NEWLINK
and DELLINK commands. CAIF Network Interface takes a Connection-ID
in order to be able to associate the AT command for pdp-context
activation with CAIF Channel and
Resubmitting same changes as last patch set, but
some of the patches are split up in smaller parts.
The RTNL patch is removed and replaced by a separate RFC.
Sjur Brændeland (8):
plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.
stemodem: Add polling for SIM ready.
Interim solution until support for SIM 'ready' notification is supported.
---
Change: AT-channel configuration is moved to separate patch.
plugins/ste.c | 52 ++--
1 files changed, 50 insertions(+), 2 deletions(-)
diff --git a/plugins/ste.c
---
plugins/ste.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/plugins/ste.c b/plugins/ste.c
index fcf4d15..bcf2704 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -216,7 +216,8 @@ static int ste_enable(struct ofono_modem *modem)
if (getenv(OFONO_AT_DEBUG))
---
Changes:
o Changed order of files in Makefile
o Fixed missing empty line in copyright
o Formatted enum better
o Removed default is switches
o Removed ste in function names
Makefile.am |2 +
drivers/stemodem/radio-settings.c | 230
---
drivers/stemodem/radio-settings.c |5 +
plugins/ste.c |2 ++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/plugins/ste.c b/plugins/ste.c
index bcf2704..16ddbe1 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -54,6 +54,7 @@
#include
---
plugins/ste.c | 20 +++-
1 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/plugins/ste.c b/plugins/ste.c
index 16ddbe1..479d85c 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -30,6 +30,7 @@
#include stdlib.h
#include string.h
#include unistd.h
+#include
---
plugins/modemconf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/plugins/modemconf.c b/plugins/modemconf.c
index 3747cd9..d7b1354 100644
--- a/plugins/modemconf.c
+++ b/plugins/modemconf.c
@@ -138,6 +138,7 @@ static struct {
{ g1, set_device },
---
plugins/modem.conf |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/plugins/modem.conf b/plugins/modem.conf
index 66bf932..b577114 100644
--- a/plugins/modem.conf
+++ b/plugins/modem.conf
@@ -44,3 +44,8 @@
#[n900]
#Driver=n900modem
#Interface=phonet0
+
+# Sample
Denis Kenzior denk...@gmail.com wrote:
Hi Sjur,
I have to verify this with some of my colleagues, but I am pretty sure
emergency calls cannot be applied to the AT+CHLD command. i.e. they
cannot be part of mpty.
Initial testing on STE modem indicates that emergency call cannot
participate
---
Changes:
o Use MBM stk driver implementation (avoid copying code).
Note: stemodm.h has to declare the mbm_stk_init/exit functions because
importing mbmdriver causes compile errors due to duplicated
declarations.
drivers/stemodem/stemodem.c |2 ++
Resubmitting based on rebase comments from Denis K.
Changes:
o SIM-ready and Radio-Settings are now split in two parts,
one patch for driver and one for plugin.
o Use MBM stk driver implementation (avoid copying code).
o Updated error handling for Radio Settings.
o Various Style issues
Interim solution until support for SIM 'ready' notification is supported.
---
Changes:
o Fixed style issues (tabs and newlines)
plugins/ste.c | 55 ---
1 files changed, 52 insertions(+), 3 deletions(-)
diff --git a/plugins/ste.c
---
plugins/ste.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/plugins/ste.c b/plugins/ste.c
index e1ca06c..1e3ed9d 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -55,6 +55,7 @@
#include ofono/gprs.h
#include ofono/gprs-context.h
#include ofono/stk.h
+#include
---
Changes since last patch set:
o Moved updates to plugins/ste to separate patch.
o Updated error handling.
o Style issues.
Makefile.am |4 +-
drivers/stemodem/radio-settings.c | 223 +
drivers/stemodem/stemodem.c |2 +
CAIF in Linux kernel 2.6.35 must use RTNL for configuring
CAIF interfaces.
---
Makefile.am |4 +-
drivers/stemodem/gprs-context.c | 51 +--
drivers/stemodem/rtnl.c | 318 +++
drivers/stemodem/rtnl.h | 24 +++
4
---
plugins/modem.conf |5 +
plugins/modemconf.c |1 +
plugins/ste.c | 20 +++-
3 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/plugins/modem.conf b/plugins/modem.conf
index 66bf932..b577114 100644
--- a/plugins/modem.conf
+++
Marcel Holtmann mar...@holtmann.org wrote:
Hi Sjur,
Changes since last patch set:
o Moved updates to plugins/ste to separate patch.
o Updated error handling.
o Style issues.
Makefile.am | 4 +-
drivers/stemodem/radio-settings.c | 223
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
Marcel Holtmann wrote:
... The build system builds the plugins
properly and you can cross reference modem drivers from your modem
plugin without any problems.
Simply refering to MBM driver from ste.c
plugins/ste.c |2 ++
1 files
From: Sjur Brændeland sjur.brandel...@stericsson.com
Interim solution until support for SIM 'ready' notification is supported.
---
Changes:
o Fixed style issues (tabs and newlines)
plugins/ste.c | 55 ---
1 files changed, 52 insertions
From: Sjur Brændeland sjur.brandel...@stericsson.com
CAIF in Linux kernel 2.6.35 must use RTNL for configuring
CAIF interfaces.
---
drivers/stemodem/gprs-context.c | 51 +--
drivers/stemodem/rtnl.c | 318 +++
drivers/stemodem/rtnl.h
From: Sjur Brændeland sjur.brandel...@stericsson.com
---
plugins/modem.conf |5 +
plugins/modemconf.c |1 +
plugins/ste.c | 20 +++-
3 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/plugins/modem.conf b/plugins/modem.conf
index 66bf932..b577114
1 - 100 of 121 matches
Mail list logo
