D11074: Fix opening files via a file manager on Mac

2018-03-06 Thread Sergio Bragin
sbragin added a comment. In D11074#220231 , @rjvbb wrote: > No, none of the Qt APIs you're using are Mac-specific, they just do nothing on other platforms (you won't get any QFileOpen events). Not using #ifdefs also means that if ever Qt

D11075: Make Okular show the list of opened windows in the Dock menu

2018-03-06 Thread Sergio Bragin
sbragin added a comment. In D11075#220228 , @rjvbb wrote: > Qt4 apps used to create a temporary NIB file in $TMPDIR and load that. I cannot recall having seen something similar in Qt5 and cannot find any evidence of it in the code. But just as

[GSoC]

2018-03-06 Thread Dileep Sankhla
Hello, My name is Dileep Sankhla (IRC: robstat7) and I am eager to contribute to Okular this year in GSoC. I am well versed in C++ and have been programming in it for the past four years while using Qt for development for the past three months. In addition to it, I have been contributing to the

D11074: Fix opening files via a file manager on Mac

2018-03-06 Thread René J . V . Bertin
rjvbb added a comment. > Would not it end with having #ifdefs scattered all over the QApplication anyway? No, none of the Qt APIs you're using are Mac-specific, they just do nothing on other platforms (you won't get any QFileOpen events). Not using #ifdefs also means that if ever Qt

D11075: Make Okular show the list of opened windows in the Dock menu

2018-03-06 Thread René J . V . Bertin
rjvbb added a comment. > Actually, I do not know, whether there is an API that allows to force Mac OS to create such list in the Dock menu, but if an app implements "Window" menu (systemMenu="window" in the menu xib file), then this list is generated automatically. It's been too long

D11074: Fix opening files via a file manager on Mac

2018-03-06 Thread Sergio Bragin
sbragin added a comment. In D11074#220158 , @rjvbb wrote: > There is no specific reason to hide the QFileOpenEvent handling in a Mac-specific file and behind #ifdefs . I seem to recall that the same event mechanism was used on another, now

D11075: Make Okular show the list of opened windows in the Dock menu

2018-03-06 Thread Sergio Bragin
sbragin added a comment. In D11075#219937 , @rjvbb wrote: > I'm not sure if all Mac applications always show the open documents under their Dock tile (that menu can be used for anything, of course), Not all of them (shall I reword the

D11074: Fix opening files via a file manager on Mac

2018-03-06 Thread René J . V . Bertin
rjvbb added a comment. In addition to the inline comments: There is no specific reason to hide the QFileOpenEvent handling in a Mac-specific file and behind #ifdefs . I seem to recall that the same event mechanism was used on another, now defunct Qt platform. Other KDE applications

[okular] [Bug 391407] Okular cannot display next page with hand tool

2018-03-06 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=391407 Albert Astals Cid changed: What|Removed |Added Resolution|WAITINGFORINFO |INVALID

D11075: Make Okular show the list of opened windows in the Dock menu

2018-03-06 Thread René J . V . Bertin
rjvbb accepted this revision. rjvbb added a comment. This revision is now accepted and ready to land. I'm not sure if all Mac applications always show the open documents under their Dock tile (that menu can be used for anything, of course), and I also think that it would be more useful to

Re: GSoC Project: Verifying signatures of pdf files (Requirements)

2018-03-06 Thread Oliver Sander
Hi Ahmad, > I am exited to contribute to Okular this year in GSoC and I am interested in > the project of Verifying signatures of pdf files. that's great to hear! > I would like to know if there are other requirements that I need to know to > get more familiar with the project. I don't think

[okular] [Bug 391460] print dialogue does not show advanced options

2018-03-06 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=391460 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |UPSTREAM