D10792: Raise annotation window when clicking on annotation

simgunz added a comment. In D10792#241504 , @aacid wrote: > In D10792#241405 , @simgunz wrote: > > > Thanks to your suggestions I made some progresses. > > > > My current autotest looks as in

D12013: Add suffix "with comment" to annotations containing a comment

simgunz added a comment. This review was added by mistake and can be deleted. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12013 To: simgunz Cc: #okular, michaelweghorn, ngraham, aacid

D10797: Add asterisk when an annotation is associated to non-empty popup

simgunz added a comment. I have created a new revision D12013 by mistake. That can be deleted. I have removed the commit with the asterisk I have added before, because when I just tried to revert it phabricator was complaining and didn't let me

D12013: Add suffix "with comment" to annotations containing a comment

simgunz edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12013 To: simgunz, aacid Cc: #okular, michaelweghorn, ngraham, aacid

D12013: Add suffix "with comment" to annotations containing a comment

simgunz added a reviewer: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12013 To: simgunz, aacid Cc: #okular, michaelweghorn, ngraham, aacid

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

aacid added a comment. In D11901#241751 , @ahmadosama wrote: > I tried rotating using ( const QTransform matrix = rotationMatrix() ) but it only works when rotating a page from its original orientation, this is why I modified the

D10797: Add asterisk when an annotation is associated to non-empty popup

aacid added a comment. In D10797#241744 , @simgunz wrote: > I have created a new revision D12013 by mistake. That can be deleted. > > I have removed the commit with the asterisk I have added before,

D10797: Add asterisk when an annotation is associated to non-empty popup

rkflx added a comment. (OT) Won't comment on the patch, but in the light of T7116: Streamlined onboarding of new contributors it might be worth figuring out if there are any improvements we could do to https://community.kde.org/Infrastructure/Phabricator,

D10792: Raise annotation window when clicking on annotation

simgunz updated this revision to Diff 31564. simgunz added a comment. - Set object name in AnnotWindow (for autotest) - Add basic autotest for AnnotWindow - Test AnnotWindow raised when clicking on its annotation - Test click on AnnotWindow raises it - Remove trailing spaces

D10797: Add asterisk when an annotation is associated to non-empty popup

simgunz updated this revision to Diff 31567. simgunz added a comment. Add suffix "with comment" instead of asterisk for more clarity REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10797?vs=27929=31567 BRANCH annotations-with-note REVISION DETAIL

D12013: Add suffix "with comment" to annotations containing a comment

simgunz updated this revision to Diff 31568. simgunz added a comment. - Remove extra space REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12013?vs=31566=31568 BRANCH annotations-with-note REVISION DETAIL https://phabricator.kde.org/D12013 AFFECTED

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

ahmadosama added a comment. I tried rotating using ( const QTransform matrix = rotationMatrix() ) but it only works when rotating a page from its original orientation, this is why I modified the RotationJob::rotationMatrix in a way similar to Okular::buildRotationMatrix to allow rotating

D12013: Add suffix "with comment" to annotations containing a comment

aacid commandeered this revision. aacid edited reviewers, added: simgunz; removed: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12013 To: aacid, simgunz Cc: #okular, michaelweghorn, ngraham, aacid

[okular] [Bug 392826] New: Crash when opening .xps file

https://bugs.kde.org/show_bug.cgi?id=392826 Bug ID: 392826 Summary: Crash when opening .xps file Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

D12013: Add suffix "with comment" to annotations containing a comment

aacid abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12013 To: aacid, simgunz Cc: #okular, michaelweghorn, ngraham, aacid

D12013: Add suffix "with comment" to annotations containing a comment

aacid added a comment. There's no way to delete reviews, you just abandon them. I'll do it for you REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12013 To: simgunz, aacid Cc: #okular, michaelweghorn, ngraham, aacid

D10797: Add asterisk when an annotation is associated to non-empty popup

simgunz updated this revision to Diff 31569. simgunz added a comment. - Remove extra space REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10797?vs=31567=31569 BRANCH annotations-with-note REVISION DETAIL https://phabricator.kde.org/D10797 AFFECTED

D12013: Add suffix "with comment" to annotations containing a comment

simgunz created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. simgunz requested review of this revision. REVISION SUMMARY This makes it easier to find comments hidden in an highlight, for example, out having to open all of

D12013: Add suffix "with comment" to annotations containing a comment

simgunz added a comment. I have created a new revision D12013 by mistake. That can be deleted. I have removed the commit with the asterisk I have added before, because when I just tried to revert it phabricator was complaining and didn't let me

D10797: Add asterisk when an annotation is associated to non-empty popup

simgunz added a comment. > You're not really pushing a "branch" with `arc`, you can think of it more as a diff describing a range of commits. This is indeed what I believed. My doubt is: when you want to review a "review" what do you do exactly (I never did it). You download a

[okular] [Bug 392806] Lock horizontal scroll

https://bugs.kde.org/show_bug.cgi?id=392806 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving

D10797: Add asterisk when an annotation is associated to non-empty popup

rkflx added a comment. In D10797#241886 , @simgunz wrote: > My doubt is: when you want to review a "review" what do you do exactly (I never did it). You download a patch and apply it manually to your code (probably arc does this with some

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.10 - Build # 14 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.10/14/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 07 Apr 2018 09:21:58 + Build duration: 4 hr 42 min and counting JUnit

[okular] [Bug 351849] Margins often cut when printing

https://bugs.kde.org/show_bug.cgi?id=351849 --- Comment #23 from Michael Weghorn --- Created attachment 111896 --> https://bugs.kde.org/attachment.cgi?id=111896=edit Test PDF file generated while trying to reproduce the problem -- You are receiving this mail because: You

[okular] [Bug 351849] Margins often cut when printing

https://bugs.kde.org/show_bug.cgi?id=351849 Michael Weghorn changed: What|Removed |Added Status|CONFIRMED |NEEDSINFO