Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Ulrich Windl
On 28 Jan 2009 at 22:49, Hans de Goede wrote: Hi, While testing I noticed that iscsiadmin -m fw does not work properly on newer (rawhide atleast) kernels, the attached patch (already applied to the Fedora devel packages) fixes this. Hi! I have almost no ideas on the implementation,

Re: PATCH: do not use exit()

2009-01-29 Thread Ulrich Windl
On 28 Jan 2009 at 22:51, Hans de Goede wrote: Hi All, While testing I noticed that idbm_lock() uses exit when it cannot lock, leading to interesting effect when using it from libiscsi, when typing import libiscsi in python as normal user, my entire python interpreter exited, not

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Bart Van Assche
On Thu, Jan 29, 2009 at 12:34 AM, Mike Christie micha...@cs.wisc.edu wrote: strncat(dev_dir, /, FILENAMESZ); strncat(dev_dir, dent-d_name, FILENAMESZ); I assume the third argument should have been FILENAMESZ - strlen(dev_dir) ? Bart.

Re: Filesystem corruption using iser transport

2009-01-29 Thread Ulrich Windl
On 29 Jan 2009 at 0:32, Dr. Volker Jaenisch wrote: So we think this has nothing to do with the underlying harddisc hardware nor the filesystem. We think the ISER transport may be the problem. Hi! Well if you thing the problem is transport related, and you are doing performance

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Ulrich Windl
On 28 Jan 2009 at 17:34, Mike Christie wrote: strncat(dev_dir, dent-d_name, FILENAMESZ); Hi, once again: The third argument of strncpy() counts the bytes to be added, not the bytes that are already there, so the code may not do what some of you seem to expect! The

Re: loopback interface IP problem

2009-01-29 Thread PECastro
Hi Mike thanks for your reply. My answers follow bellow right next to your questions. Tkx/Regards, PECastro So you do the ifconfig to lo after iscsi is setup and logged in right? Is the ip address different from what you originally logged into? I mean originally you did iscsiadm -m

Re: loopback interface IP problem

2009-01-29 Thread PECastro
Hi Ulrich, My response follows bellow On Jan 29, 7:11 am, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: On 28 Jan 2009 at 11:06, PECastro wrote: Hi there. I'm mounting a standard iscsi target. I've been doing a lot of interesting nice things, I can see the disk, I can play

Re: loopback interface IP problem

2009-01-29 Thread Ulrich Windl
Hi! Your output (if complete) looks quite strange, because I see no routes to lo. Also If lines were not wrapped, it would be easier to read. Something I have here looks like this: # netstat -rn Kernel IP routing table Destination Gateway Genmask Flags MSS Window irtt

Re: PATCH: do not use exit()

2009-01-29 Thread Hans de Goede
Ulrich Windl wrote: On 28 Jan 2009 at 22:51, Hans de Goede wrote: Hi All, While testing I noticed that idbm_lock() uses exit when it cannot lock, leading to interesting effect when using it from libiscsi, when typing import libiscsi in python as normal user, my entire python

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Hans de Goede
Ulrich Windl wrote: On 28 Jan 2009 at 22:49, Hans de Goede wrote: Hi, While testing I noticed that iscsiadmin -m fw does not work properly on newer (rawhide atleast) kernels, the attached patch (already applied to the Fedora devel packages) fixes this. Hi! I have almost no

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Hans de Goede
Bart Van Assche wrote: On Thu, Jan 29, 2009 at 12:34 AM, Mike Christie micha...@cs.wisc.edu wrote: strncat(dev_dir, /, FILENAMESZ); strncat(dev_dir, dent-d_name, FILENAMESZ); I assume the third argument should have been FILENAMESZ -

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Hans de Goede
Ulrich Windl wrote: On 28 Jan 2009 at 17:34, Mike Christie wrote: strncat(dev_dir, dent-d_name, FILENAMESZ); Hi, once again: The third argument of strncpy() counts the bytes to be added, not the bytes that are already there, so the code may not do what some

Re: CHAP with Open-iSCSI

2009-01-29 Thread Mike Christie
Ulrich Windl wrote: On 28 Jan 2009 at 12:06, Mike Christie wrote: Arvind Jain wrote: Hi Mike, We are using Open iSCSI initiator with our iSCSI target. I have a question on CHAP. I did some experiment and it appears to me that OneWay-CHAP does not work with open-iscsi, Mutual-CHAP does

Re: CHAP with Open-iSCSI

2009-01-29 Thread Mike Christie
Arvind Jain wrote: Hi Mike, We are using Open iSCSI initiator with our iSCSI target. I have a question on CHAP. I did some experiment and it appears to me that OneWay-CHAP does not work with open-iscsi, Mutual-CHAP does work fine for me. Have others seen the same behavior? What version

RE: CHAP with Open-iSCSI

2009-01-29 Thread Arvind Jain
Mike, This explains it. We are using: iscsid: transport class version 2.0-867. iscsid version 2.0-869 I will see how to upgrade it. We have patches for bidirectional and large CBDs. Thx, Arvind. -Original Message- From: open-iscsi@googlegroups.com [mailto:open-is...@googlegroups.com]

Re: CHAP with Open-iSCSI

2009-01-29 Thread Mike Christie
Arvind Jain wrote: Mike, This explains it. We are using: iscsid: transport class version 2.0-867. iscsid version 2.0-869 No, this is fine. Newer tools support older kernels. That combo should work fine (all login is in userspace anyways so the kernel does not even come into play at

Re: CHAP with Open-iSCSI

2009-01-29 Thread Mike Christie
Mike Christie wrote: Arvind Jain wrote: Mike, This explains it. We are using: iscsid: transport class version 2.0-867. iscsid version 2.0-869 No, this is fine. Newer tools support older kernels. That combo should work fine (all login is in userspace anyways so the kernel does not even

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Mike Christie
Hans de Goede wrote: Yes it does the same thing, is this from the open-iscsi VCS ? and where do I find that ? Ok, I will merge up your code instead with the fixes in the thread. Thanks! It is in our git tree. You can get it by doing: git clone

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Mike Christie
Mike Christie wrote: Hans de Goede wrote: Yes it does the same thing, is this from the open-iscsi VCS ? and where do I find that ? Ok, I will merge up your code instead with the fixes in the thread. Thanks! Here is the rediffed patch. I used strncat here: + strncat(dev_dir, /net,

RE: CHAP with Open-iSCSI

2009-01-29 Thread Arvind Jain
Mike, Thanks for this excellent support. Let me know if I can do anything. I can send you wire shark trace with MS initiator oneway-CHAP if this will help. Thx, Arvind. -Original Message- From: open-iscsi@googlegroups.com [mailto:open-is...@googlegroups.com] On Behalf Of Mike Christie

Re: iferror -38

2009-01-29 Thread chava45
Mike, I tried to disable nops. But the issue still persists. So what else can be the reason for this? It became show stopper. Thanks Chava On Jan 28, 12:35 pm, Mike Christie micha...@cs.wisc.edu wrote: chava45wrote: Mike , Can you also let me know if there is any workaround on this issue?

Re: iferror -38

2009-01-29 Thread chava45
Mike , What else could be the reason for it? it became showstopper. thanks Chava On Jan 28, 12:35 pm, Mike Christie micha...@cs.wisc.edu wrote: chava45 wrote: Mike , Can you also let me know if there is any workaround on this issue? Yeah, if this is the bug I thought I fixed then you can

Re: CHAP with Open-iSCSI

2009-01-29 Thread Mike Christie
Arvind Jain wrote: Mike, Thanks for this excellent support. Let me know if I can do anything. I can send you wire shark trace with MS initiator oneway-CHAP if this will help. I do not need it yet. I think I can see where you guys differ from what I get with other targets. I just need to

Re: iferror -38

2009-01-29 Thread Mike Christie
chava45 wrote: Mike , What else could be the reason for it? it became showstopper. What is the error you get now? Could you send the logs? If you see this: ping timeout of 5 secs expired then you do not have nops off. Could you also do a quick test with iet (it is the target used in open

Re: PATCH: fix iBFT firmware reading with newer kernels

2009-01-29 Thread Hans de Goede
Mike Christie wrote: Mike Christie wrote: Hans de Goede wrote: Yes it does the same thing, is this from the open-iscsi VCS ? and where do I find that ? Ok, I will merge up your code instead with the fixes in the thread. Thanks! Here is the rediffed patch. I used strncat here: +