Re: Race during logout

2009-07-23 Thread Ulrich Windl
On 22 Jul 2009 at 17:09, Erez Zilber wrote: restart) stop + if [ $RETVAL -ne 0 ]; then + echo Stopping iSCSI initiator service failed, not starting + exit $RETVAL +

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Hannes Reinecke wrote: Mike Christie wrote: On 07/22/2009 12:00 PM, Mike Christie wrote: No, wrong. The check in queuecommand is by no means relevant to the actual window. We're checking the target window at the time queuecommand is run, but we're _generating_ the CmdSN only much later

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Hannes Reinecke
Mike Christie wrote: Hannes Reinecke wrote: Mike Christie wrote: On 07/22/2009 12:00 PM, Mike Christie wrote: No, wrong. The check in queuecommand is by no means relevant to the actual window. We're checking the target window at the time queuecommand is run, but we're _generating_ the

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Hannes Reinecke wrote: Mike Christie wrote: Hannes Reinecke wrote: Mike Christie wrote: On 07/22/2009 12:00 PM, Mike Christie wrote: No, wrong. The check in queuecommand is by no means relevant to the actual window. We're checking the target window at the time queuecommand is run, but

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Hannes Reinecke
Mike Christie wrote: Hannes Reinecke wrote: [ .. ] Fsck. You are correct. But you still might be hitting a problem where the target does not like data-outs when it closed the window. Maybe they interpreted the RFC differently. You should ask the HP target guys for more info. Also

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Boaz Harrosh
On 07/23/2009 12:24 PM, Mike Christie wrote: But you still might be hitting a problem where the target does not like data-outs when it closed the window. Maybe they interpreted the RFC differently. You should ask the HP target guys for more info. Also your patch might be working because

Re: [RFC]iscsid to run in conjunction with uIP stack

2009-07-23 Thread Rakesh Ranjan
Mike Christie wrote: Sorry for the really late response on this. On 06/25/2009 08:25 AM, Rakesh Ranjan wrote: Li, I have attached the diff against git master, please go through it. I have merged the contents of uip directory and nic related files into one common libuip. So now offload dir

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Hannes Reinecke wrote: Mike Christie wrote: Hannes Reinecke wrote: [ .. ] Fsck. You are correct. But you still might be hitting a problem where the target does not like data-outs when it closed the window. Maybe they interpreted the RFC differently. You should ask the HP target guys for

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Boaz Harrosh
On 07/23/2009 07:01 PM, Mike Christie wrote: Boaz Harrosh wrote: I think I can replicate this problem now too. It was by accident. I am using a EQL target remotely (I am in the middle of the US and the target is on the west coast so there is a good deal of space between us and the

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Mike Christie wrote: Hannes Reinecke wrote: Mike Christie wrote: Hannes Reinecke wrote: [ .. ] Fsck. You are correct. But you still might be hitting a problem where the target does not like data-outs when it closed the window. Maybe they interpreted the RFC differently. You should ask

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Mike Christie wrote: Mike Christie wrote: Hannes Reinecke wrote: Mike Christie wrote: Hannes Reinecke wrote: [ .. ] Fsck. You are correct. But you still might be hitting a problem where the target does not like data-outs when it closed the window. Maybe they interpreted the RFC