Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-06-30 Thread Nicholas A. Bellinger
On Mon, 2017-06-26 at 19:38 +0200, Stephan Müller wrote: > Am Montag, 26. Juni 2017, 03:23:09 CEST schrieb Nicholas A. Bellinger: > > Hi Nicholas, > > > Hi Stephan, Lee & Jason, > > > > (Adding target-devel CC') > > > > Apologies for

Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-06-25 Thread Nicholas A. Bellinger
Hi Stephan, Lee & Jason, (Adding target-devel CC') Apologies for coming late to the discussion. Comments below. On Sun, 2017-06-18 at 10:04 +0200, Stephan Müller wrote: > Am Samstag, 17. Juni 2017, 05:45:57 CEST schrieb Lee Duncan: > > Hi Lee, > > > In your testing, how long might a process

Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

2017-03-21 Thread Nicholas A. Bellinger
Hi Elena, On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

2017-03-07 Thread Nicholas A. Bellinger
ers/target/target_core_iblock.c | 12 ++-- > drivers/target/target_core_iblock.h | 3 ++- > 2 files changed, 8 insertions(+), 7 deletions(-) For the target_core_iblock part: Acked-by: Nicholas Bellinger <n...@linux-iscsi.org> -- You received this message because you are

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Nicholas A. Bellinger
On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: On 01/07/15 22:39, Mike Christie wrote: On 01/07/2015 10:57 AM, Hannes Reinecke wrote: On 01/07/2015 05

Re: scsi-mq + open-iscsi support patches..?

2013-11-04 Thread Nicholas A. Bellinger
On Sat, 2013-11-02 at 16:10 +, Jayamohan Kallickal wrote: SNIP On a related note, some iscsi vendor has been hitting a crash with your tree. I got an email from Jayamohan recently, but the OOPs did not appear to be scsi-mq related.. I do see the crash on my Ubuntu VM running on

Re: scsi-mq + open-iscsi support patches..?

2013-11-01 Thread Nicholas A. Bellinger
On Fri, 2013-11-01 at 09:46 -0500, Mike Christie wrote: On 10/28/13 5:03 PM, Nicholas A. Bellinger wrote: Hi Mike, Just curious as to the status of the scsi-mq conversion patches for open-iscsi that you where working on a while back..? I'm asking because recently I've been spending

Re: iscsiadm login failed

2013-09-03 Thread Nicholas A. Bellinger
Hi Saeed, On Fri, 2013-08-30 at 23:19 -0700, Saeed Mirzamohamadi wrote: Hi I'm trying to connect my open-iscsi initiator to target, but failed to login with the command sudo iscsiadm -m node --login. Here is my error: Logging in to [iface: default, target:

Re: do discovery through SW transports too

2013-06-26 Thread Nicholas A. Bellinger
On Sun, 2013-06-23 at 17:47 +0300, Or Gerlitz wrote: On 23/06/2013 17:40, Or Gerlitz wrote: there you go, here's the output isert_cma_handler: event 4 status 0 conn 88011a55d600 id 8801085c5400 RDMA_CM_EVENT_CONNECT_REQUEST: Entering isert_connect_request cma_id:

Re: do discovery through SW transports too

2013-06-20 Thread Nicholas A. Bellinger
On Thu, 2013-06-20 at 19:01 +0300, Or Gerlitz wrote: On 19/06/2013 04:32, Nicholas A. Bellinger wrote: So I'm pretty sure this is due to iscsi_target_parameters.c: iscsi_set_keys_irrelevant_for_discovery() currently clearing INITIATORRECVDATASEGMENTLENGTH and TARGETRECVDATASEGMENTLENGTH

Re: do discovery through SW transports too

2013-06-18 Thread Nicholas A. Bellinger
On Tue, 2013-06-18 at 18:35 +0300, Or Gerlitz wrote: On 15/06/2013 11:25, Nicholas A. Bellinger wrote: Hi Or Mike, On Tue, 2013-06-11 at 08:04 +0300, Or Gerlitz wrote: On 06/06/2013 18:01, Mike Christie wrote: However, above I am not talking about that or doing discovery over

Re: [PATCH] iscsi: Simplify serial number comparisons

2011-04-12 Thread Nicholas A. Bellinger
On Thu, 2011-04-07 at 14:26 -0700, Mark Rustad wrote: Unsigned serial number comparison is very simple if you simply put the difference into a signed integer of the same size and then compare that value with zero. All the complexity and confusion fall away. Signed-off-by: Mark Rustad

Re: [RFC-v2 01/12] iscsi: Resolve iscsi_proto.h naming conflicts with drivers/target/iscsi

2011-03-14 Thread Nicholas A. Bellinger
On Mon, 2011-03-14 at 15:59 +0100, Christoph Hellwig wrote: On Mon, Mar 14, 2011 at 04:56:58AM -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch renames the following iscsi_proto.h structures to avoid namespace issues with drivers/target/iscsi

Re: [RFC-v2 01/12] iscsi: Resolve iscsi_proto.h naming conflicts with drivers/target/iscsi

2011-03-14 Thread Nicholas A. Bellinger
On Mon, 2011-03-14 at 17:13 -0500, Mike Christie wrote: On 03/14/2011 04:40 PM, Nicholas A. Bellinger wrote: On Mon, 2011-03-14 at 15:59 +0100, Christoph Hellwig wrote: On Mon, Mar 14, 2011 at 04:56:58AM -0700, Nicholas A. Bellinger wrote: From: Nicholas Bellingern...@linux-iscsi.org

Re: [PATCH 01/12] libiscsi: Convert to host_lock less w/ interrupts disabled internally

2010-12-23 Thread Nicholas A. Bellinger
On Mon, 2010-12-20 at 18:36 -0600, Mike Christie wrote: On 12/20/2010 03:30 AM, Nicholas A. Bellinger wrote: After a quick audit of iscsi_session-lock usage, and I see that iscsi_complete_pdu(), iscsi_tmf_timedout(), iscsi_eh_cmd_timed_out(), iscsi_check_transport_timeouts() are using

Re: [PATCH 01/12] libiscsi: Convert to host_lock less w/ interrupts disabled internally

2010-12-20 Thread Nicholas A. Bellinger
On Sun, 2010-12-19 at 19:07 -0700, Matthew Wilcox wrote: On Sun, Dec 19, 2010 at 05:22:06PM -0800, Nicholas A. Bellinger wrote: Actually sorry, Mike Christie did already make a clarification on this subject here: http://marc.info/?l=linux-scsim=129010439421506w=2 I had originally

Re: mc/s - not yet in open-iscsi?

2010-06-14 Thread Nicholas A. Bellinger
On Mon, 2010-06-14 at 23:44 +0400, Vladislav Bolkhovitin wrote: Raj, on 06/12/2010 03:17 AM wrote: Nicholas A. Bellinger n...@... writes: Btw, just for those following along, here is what MC/S and ERL=2 when used in combination (yes, they are complementary) really do: http://linux

Re: mc/s - not yet in open-iscsi?

2010-06-11 Thread Nicholas A. Bellinger
On Fri, 2010-06-11 at 23:17 +, Raj wrote: Nicholas A. Bellinger n...@... writes: Btw, just for those following along, here is what MC/S and ERL=2 when used in combination (yes, they are complementary) really do: http://linux-iscsi.org/builds/user/nab

Re: mc/s - not yet in open-iscsi?

2010-06-10 Thread Nicholas A. Bellinger
On Thu, 2010-06-10 at 13:35 -0700, Nicholas A. Bellinger wrote: On Thu, 2010-06-10 at 13:36 +0400, Vladislav Bolkhovitin wrote: Christopher Barry, on 06/10/2010 03:09 AM wrote: Greetings everyone, Had a question about implementing mc/s using open-iscsi today. Wasn't really sure

Re: mc/s - not yet in open-iscsi?

2010-06-10 Thread Nicholas A. Bellinger
On Thu, 2010-06-10 at 13:36 +0400, Vladislav Bolkhovitin wrote: Christopher Barry, on 06/10/2010 03:09 AM wrote: Greetings everyone, Had a question about implementing mc/s using open-iscsi today. Wasn't really sure exactly what it was. From googling about, I can't find any references

Re: Over one million IOPS using software iSCSI and 10 Gbit Ethernet

2010-01-29 Thread Nicholas A. Bellinger
On Thu, 2010-01-28 at 20:45 +0200, Pasi Kärkkäinen wrote: On Thu, Jan 28, 2010 at 07:38:28PM +0100, Bart Van Assche wrote: On Thu, Jan 28, 2010 at 4:01 PM, Joe Landman land...@scalableinformatics.com wrote: Pasi Kärkkäinen wrote: Please check these news items:

Re: [Fwd: [PATCH] [Target_Core_Mod/Persistent_Reservations]: Add support for PREEMPT_AND_ABORT SA]

2009-04-01 Thread Nicholas A. Bellinger
On Mon, 2009-03-30 at 19:34 -0500, Mike Christie wrote: Nicholas A. Bellinger wrote: Greetings Mike, Hannes and co: Here is the OOPs that I am seeing with upstream Open-iSCSI on kernel.org v2.6.27.10 with the TASK_ABORTED status getting returned to outstanding It looks like you

Re: [Open/iSCSI] Memory leak in repetitive --login/--logout with v2.0-870.1

2009-01-13 Thread Nicholas A. Bellinger
On Mon, 2009-01-12 at 20:41 -0600, Mike Christie wrote: Mike Christie wrote: Nicholas A. Bellinger wrote: Ok, I still have my hands full with LIO v3.0 code atm, so I am not sure how soon I could get to this.. Don't worry about it. I can replicate it here. Crazy, I guess

[Open/iSCSI] Memory leak in repetitive --login/--logout with v2.0-870.1

2009-01-09 Thread Nicholas A. Bellinger
Greetings Mike, Hannes and Co, During some recent testing using the Open/iSCSI Initiator v2.0-870.1, against the LIO-Target v3.0 tree, I noticed that while running the following script: while [ 1 ]; do iscsiadm -m node -T $TARGETNAME -p $PORTAL --login iscsiadm -m node -T

Re: iSCSI PDU timed out error trying to connect to LIO targets

2008-10-29 Thread Nicholas A. Bellinger
On Wed, 2008-10-22 at 09:43 -0500, Mike Christie wrote: Martin wrote: Target: iqn.2001-09.net.ketsds:keat.storage.fast1 Portal: 10.1.206.2:3260,1 Iface Name: default Target: iqn.2001-09.net.ketsds:keat.storage.fast2 Portal: 10.1.206.2:3260,1 Iface

[ANNOUNCE] - VHACS-VM x86_64 Alpha Preview - FOLLOWUP

2008-07-17 Thread Nicholas A. Bellinger
. :-) Lots of things going on this week. More to come soon. Please keep checking the http://Linux-iSCSI.org site for the latest information. Many thanks for your most valuable of time, --nab On Mon, 2008-07-14 at 11:02 -0700, Nicholas A. Bellinger wrote: Greetings all, I am pleased

VHACS-VM x86_64 Alpha Preview on 45nm multicore

2008-07-14 Thread Nicholas A. Bellinger
Greetings all, I am pleased to announce the Alpha availibility of VHACS-VM Demo for Hardware Virtualized x86_64 running (initially) on VMWare Workstation 6. The VHACS cluster stack also obviously runs on 'bare-metal' hardware, but today VHACS-VM is the easiest method to get your own open storage

Re: Open/iSCSI + Logout Response Timeout + replacement_timeout firing

2008-07-01 Thread Nicholas A. Bellinger
Hi Mike, On Mon, 2008-06-30 at 11:27 -0500, Mike Christie wrote: Konrad Rzeszutek wrote: Ah if your disk are using write back cache then you are going to hit some problems. So if you see this in /var/log/messages when you loging: kernel: sd 9:0:0:1: [sdb] Write cache: enabled, then

Re: Open/iSCSI + Logout Response Timeout + replacement_timeout firing

2008-06-29 Thread Nicholas A. Bellinger
On Sun, 2008-06-29 at 01:36 -0500, Mike Christie wrote: Nicholas A. Bellinger wrote: Hi Mike! Hey, looks like you doing some more cool stuff. Don't you have a job where you have to hack on boring stuff like the rest of us :) What Jerome said. :-) On Sat, 2008-06-28 at 15:33

Open/iSCSI + Logout Response Timeout + replacement_timeout firing

2008-06-27 Thread Nicholas A. Bellinger
Greetings Mike, Hannes, and all; So, and Jerome and Myself have been pushing VHACS (please see towards production, we have begin to run into a particular issue while during the 'vhacs cluster -I' (eg: cluster initilization) routine when we had a bunch of VHACS server and client clouds active,

Re: Open/iSCSI + Logout Response Timeout + replacement_timeout firing

2008-06-27 Thread Nicholas A. Bellinger
On Fri, 2008-06-27 at 16:00 -0700, Nicholas A. Bellinger wrote: Greetings Mike, Hannes, and all; So, and Jerome and Myself have been pushing VHACS (please see towards Whoops, forgot to include the VHACS link. :-) http://linux-iscsi.org/index.php/VHACS --nab production, we have begin

Re: [Cbe-oss-dev] LIO Target iSCSI/SE PS3-Linux / FC8 builds

2008-02-04 Thread Nicholas A. Bellinger
, let me know if you are missing any when you install iscsi-target-tools. Thanks, --nab On Mon, 2008-02-04 at 07:52 -0800, Nicholas A. Bellinger wrote: Hi Marc, You can generate the kernel RPM with 'make kernel ARCH=powerpc'. Also, while module-assistant is supported on debian/ubuntu, trunk