Re: Race during logout

2009-07-23 Thread Erez Zilber
On Thu, Jul 23, 2009 at 9:15 AM, Ulrich Windl wrote: > > On 22 Jul 2009 at 17:09, Erez Zilber wrote: > >>         restart) >>                         stop >> +                       if [ $RETVAL -ne 0 ]; then >> +                               echo "Stopping iSCSI initiator service >> failed, not

[PATCH] Don't kill iscsid if logout from all nodes fail

2009-07-23 Thread Erez Zilber
If 'iscsiadm -m node --logoutall=all' fails when stopping the open-iscsi service, we shouldn't kill iscsid. This solves the following race: 1. A logout from a node is initiated by the user. 2. Before the logout completes, the user runs /etc/init.d/iscsi stop. The 'stop' method logs out from all

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Hannes Reinecke
Mike Christie wrote: > On 07/22/2009 12:00 PM, Mike Christie wrote: >>> No, wrong. The check in queuecommand is by no means relevant >>> to the actual window. >>> We're checking the target window at the time queuecommand is run, >>> but we're _generating_ the CmdSN only much later after we've >>>

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Hannes Reinecke wrote: > Mike Christie wrote: >> On 07/22/2009 12:00 PM, Mike Christie wrote: No, wrong. The check in queuecommand is by no means relevant to the actual window. We're checking the target window at the time queuecommand is run, but we're _generating_ the CmdSN on

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Hannes Reinecke
Mike Christie wrote: > Hannes Reinecke wrote: >> Mike Christie wrote: >>> On 07/22/2009 12:00 PM, Mike Christie wrote: > No, wrong. The check in queuecommand is by no means relevant > to the actual window. > We're checking the target window at the time queuecommand is run, > but we

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Hannes Reinecke wrote: > Mike Christie wrote: >> Hannes Reinecke wrote: >>> Mike Christie wrote: On 07/22/2009 12:00 PM, Mike Christie wrote: >> No, wrong. The check in queuecommand is by no means relevant >> to the actual window. >> We're checking the target window at the time que

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Hannes Reinecke
Mike Christie wrote: > Hannes Reinecke wrote: [ .. ] >> Fsck. You are correct. >> > > But you still might be hitting a problem where the target does not like > data-outs when it closed the window. Maybe they interpreted the RFC > differently. You should ask the HP target guys for more info. >

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Boaz Harrosh
On 07/23/2009 12:24 PM, Mike Christie wrote: > > But you still might be hitting a problem where the target does not like > data-outs when it closed the window. Maybe they interpreted the RFC > differently. You should ask the HP target guys for more info. > > Also your patch might be working be

Re: [RFC]iscsid to run in conjunction with uIP stack

2009-07-23 Thread Rakesh Ranjan
Mike Christie wrote: > Sorry for the really late response on this. > > On 06/25/2009 08:25 AM, Rakesh Ranjan wrote: >> >> Li, I have attached the diff against git master, please go through it. I >> have merged the contents of uip directory and nic related files into one >> common libuip. So now o

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Boaz Harrosh wrote: >> I think I can replicate this problem now too. It was by accident. I am >> using a EQL target remotely (I am in the middle of the US and the target >> is on the west coast so there is a good deal of space between us and the >> connection is slow) and I am seeing the proble

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Hannes Reinecke wrote: > Mike Christie wrote: >> Hannes Reinecke wrote: > [ .. ] >>> Fsck. You are correct. >>> >> But you still might be hitting a problem where the target does not like >> data-outs when it closed the window. Maybe they interpreted the RFC >> differently. You should ask the HP

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Boaz Harrosh
On 07/23/2009 07:01 PM, Mike Christie wrote: > Boaz Harrosh wrote: >>> I think I can replicate this problem now too. It was by accident. I am >>> using a EQL target remotely (I am in the middle of the US and the target >>> is on the west coast so there is a good deal of space between us and the

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Mike Christie wrote: > Hannes Reinecke wrote: >> Mike Christie wrote: >>> Hannes Reinecke wrote: >> [ .. ] Fsck. You are correct. >>> But you still might be hitting a problem where the target does not like >>> data-outs when it closed the window. Maybe they interpreted the RFC >>> diff

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Mike Christie
Mike Christie wrote: > Mike Christie wrote: >> Hannes Reinecke wrote: >>> Mike Christie wrote: Hannes Reinecke wrote: >>> [ .. ] > Fsck. You are correct. > But you still might be hitting a problem where the target does not like data-outs when it closed the window. Maybe the