Re: [RFC]: libiscsi patch to support cxgb3i on older RHEL-5/SLES-10

2009-09-03 Thread Or Gerlitz
Mike Christie wrote: > A signature is not going to help you understand that patch will it? :) I do > not think a changelog will help either since it is the first version of a > RFC patch. Mike, signature is needed and helpful, I assume you sign all the patches you send to James, isn't it... ch

Re: [RFC]: libiscsi patch to support cxgb3i on older RHEL-5/SLES-10

2009-09-03 Thread Rakesh Ranjan
Mike Christie wrote: > On 09/01/2009 09:53 AM, Mike Christie wrote: >> On 09/01/2009 03:58 AM, Or Gerlitz wrote: >>> Mike Christie wrote: Or, I am ccing you because some time ago Erez was working on support for older RHEL and SLES kernels for OFED. It looks like the patch below would

[PATCH] Fix compilation warnings in usr/kernel code

2009-09-03 Thread Erez Zilber
Fix compilation warnings and modify the Makefiles to treat warnings as errors. Signed-off-by: Erez Zilber --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open

Re: [PATCH] Fix compilation warnings in usr/kernel code

2009-09-03 Thread Erez Zilber
On Thu, Sep 3, 2009 at 7:21 PM, Erez Zilber wrote: > Fix compilation warnings and modify the Makefiles to treat > warnings as errors. > > Signed-off-by: Erez Zilber > 2 comments about this patch: 1. I'm not familiar enough with the fwparam_ibft code, so I didn't add the -Werror flag to the Makef

Re: [RFC]: libiscsi patch to support cxgb3i on older RHEL-5/SLES-10

2009-09-03 Thread Mike Christie
On 09/03/2009 07:58 AM, Or Gerlitz wrote: > Mike Christie wrote: >> A signature is not going to help you understand that patch will it? :) I do >> not think a changelog will help either since it is the first version of a >> RFC patch. > Mike, signature is needed and helpful, I assume you sign a

Re: iscsiadm not creating default iface configs for hardware iscsi

2009-09-03 Thread Mike Christie
On 09/02/2009 11:36 AM, ofero wrote: > We are running RHEL 5U3. What do you means when you say that the open- > iscsi.org version does not have full support for bnx2i ? And is the If the bnx2i driver you are using hooks into the iscsi kernel class and libiscsi then iscsiadm can display session i

Re: [PATCH] Fix compilation warnings in usr/kernel code

2009-09-03 Thread Mike Christie
On 09/03/2009 11:21 AM, Erez Zilber wrote: > Fix compilation warnings and modify the Makefiles to treat > warnings as errors. > > Signed-off-by: Erez Zilber > Thanks. I get this compilation error on fedora 10. We used to get a warning about it not being initialized and upstream we did this

Re: [RFC]: libiscsi patch to support cxgb3i on older RHEL-5/SLES-10

2009-09-03 Thread Mike Christie
On 09/03/2009 11:37 AM, Mike Christie wrote: > On 09/03/2009 07:58 AM, Or Gerlitz wrote: >> Mike Christie wrote: >>> A signature is not going to help you understand that patch will it? :) I do >>> not think a changelog will help either since it is the first version of a >>> RFC patch. >> Mike,

Re: [RFC]: libiscsi patch to support cxgb3i on older RHEL-5/SLES-10

2009-09-03 Thread Mike Christie
On 09/03/2009 12:17 PM, Mike Christie wrote: > On 09/03/2009 11:37 AM, Mike Christie wrote: >> On 09/03/2009 07:58 AM, Or Gerlitz wrote: >>> Mike Christie wrote: A signature is not going to help you understand that patch will it? :) I do not think a changelog will help either since it i

Re: [PATCH] start iscsid when needed

2009-09-03 Thread Mike Christie
On 02/07/2009 12:32 AM, Mike Christie wrote: > This patch is from Fedora. The problem is that some distros are starting > iscsid in anticipation that iscsi might be needed, and it turns out it > might never be :( So this patch has the iscsi tools start iscsid only > when they first need it for log