On Wed, 31 Mar 2021 19:25:09 GMT, Kevin Rushforth wrote:
>> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3
>> - One bug was discovered in updated GStreamer which was causing deadlock or
>> infinite loop during seek on macOS. See gstsystemclock.c for changes between
>> ifd
On Wed, 31 Mar 2021 13:59:12 GMT, Kevin Rushforth wrote:
> I recommend trying this with the following gradle flags, to match the
> settings for production builds:
Thanks, Kevin. Good news so far. I'm posting the Linux results while I run the
macOS and Windows builds.
Linux
I ran the fol
I've found that building controls in such a way to limit the
addition/removal of child Nodes as much as possible (for example by
making them invisible/unmanaged instead of adding/removing) has a huge
impact on performance.
If you are seeing a lot of CSS churn, this could be one of the causes.
On Wed, 31 Mar 2021 21:43:02 GMT, Kevin Rushforth wrote:
> Did you find that it worked without the addition of the dependency to
> `build.gradle`? You didn't commit that change. I guess we'll see what the
> GitHub actions build shows.
I forgot to add the change I did in build.gradle, it didn't
> Small fix to clear a reference to a removed node left by Scene$MouseHandler.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Add test compile dependency on :base for :graphics
-
Changes:
- all: https://git.openjdk.j
On Wed, 31 Mar 2021 21:24:18 GMT, Kevin Rushforth wrote:
>> The fix looks good to me. I haven't run the test yet, but it seems OK except
>> for the handling of GC to check for the leak (I left an inline comment).
>
> Oh, I thought that `javafx.graphics` already referenced it. The following
> sh
On Wed, 31 Mar 2021 21:16:29 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/SceneTest.java line
>> 1019:
>>
>>> 1017: pane = null;
>>> 1018:
>>> 1019: System.gc();
>>
>> It is not sufficient to call `System.gc()` only once, since it will m
On Wed, 31 Mar 2021 13:11:23 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 3633:
>
>> 3631:
> Small fix to clear a reference to a removed node left by Scene$MouseHandler.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Fix review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/448/files
-
On Wed, 31 Mar 2021 13:13:01 GMT, Kevin Rushforth wrote:
>> Small fix to clear a reference to a removed node left by Scene$MouseHandler.
>
> The fix looks good to me. I haven't run the test yet, but it seems OK except
> for the handling of GC to check for the leak (I left an inline comment).
Oh
On Wed, 31 Mar 2021 13:07:06 GMT, Kevin Rushforth wrote:
>> Small fix to clear a reference to a removed node left by Scene$MouseHandler.
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/SceneTest.java line
> 1019:
>
>> 1017: pane = null;
>> 1018:
>> 1019: System.gc()
On Wed, 31 Mar 2021 05:15:20 GMT, Alexander Matveev
wrote:
> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3
> - One bug was discovered in updated GStreamer which was causing deadlock or
> infinite loop during seek on macOS. See gstsystemclock.c for changes between
> ifde
On Wed, 31 Mar 2021 17:54:49 GMT, Johan Vos wrote:
> don't bail when building on Apple M1 systems
> Fix for JDK-8264536
This pull request has now been integrated.
Changeset: eec2f394
Author:Johan Vos
URL: https://git.openjdk.java.net/jfx/commit/eec2f394
Stats: 1 line in 1 file ch
On Wed, 31 Mar 2021 17:54:49 GMT, Johan Vos wrote:
> don't bail when building on Apple M1 systems
> Fix for JDK-8264536
Looks good.
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/451
don't bail when building on Apple M1 systems
Fix for JDK-8264536
-
Commit messages:
- don't bail when building on Apple M1 systems
Changes: https://git.openjdk.java.net/jfx/pull/451/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=451&range=00
Issue: https://bugs.openj
On Thu, 25 Mar 2021 18:53:41 GMT, John Neffenger wrote:
>> Thanks, Kevin. I added a README file and updated the Lucene instructions, as
>> you suggested. I'm open to any other suggestions on the wording or
>> formatting, no matter how minor.
>>
>>> Some of the files listed are not used directl
On Wed, 31 Mar 2021 13:20:09 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableRowSkinTest.java
>> line 42:
>>
>>> 40:
>>> 41: import static junit.framework.Assert.assertEquals;
>>> 42:
>>
>> shouldn't that be `org.junit.Assert.*` ?
>
>
> This PR fixes an issue, where table cells are not removed from the table row
> when the corresponding table column got removed. This will lead to empty
> "ghost" cells laying around in the table.
> This bug only occurs, when a fixed cell size is set to the table.
>
> I also added 3 more tests
On Wed, 31 Mar 2021 12:32:02 GMT, Jeanette Winzenburg
wrote:
>
>
> Fix looks good, verified failing/passing test before/after fix. Left minor
> comments inline.
>
> As to the test - good to increase test coverage by including tests for
> invisible columns, IMO :)
>
> Two thingies you might
On Tue, 30 Mar 2021 19:07:31 GMT, John Neffenger wrote:
>> I think there might be a Skara bug. The pre-submit builds on Linux, macOS,
>> and Windows completed immediately. I think that's because the first of the
>> two commits in this pull request includes the Java Bug ID from [another
>> pend
On Wed, 31 Mar 2021 13:36:48 GMT, Kevin Rushforth wrote:
>> The CSR is now in the proposed state!
>
> I reviewed the CSR, and it is now ready for you to Finalize.
I've clicked now the finalize button.
-
PR: https://git.openjdk.java.net/jfx/pull/421
On Thu, 25 Mar 2021 23:23:56 GMT, Florian Kirmaier
wrote:
>> Marked as reviewed by arapte (Reviewer).
>
> The CSR is now in the proposed state!
I reviewed the CSR, and it is now ready for you to Finalize.
-
PR: https://git.openjdk.java.net/jfx/pull/421
On Wed, 31 Mar 2021 12:18:54 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8258663: Using VirtualFlowTestUtils in tests now instead of own solution
>> -> cleaner code
>
> modules/javafx.
On Wed, 31 Mar 2021 12:00:39 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8258663: Using VirtualFlowTestUtils in tests now instead of own solution
>> -> cleaner code
>
> modules/javafx.
On Wed, 31 Mar 2021 05:36:06 GMT, John Hendrikx wrote:
> Small fix to clear a reference to a removed node left by Scene$MouseHandler.
The fix looks good to me. I haven't run the test yet, but it seems OK except
for the handling of GC to check for the leak (I left an inline comment).
modules/ja
On Wed, 31 Mar 2021 10:29:03 GMT, Marius Hanl
wrote:
>> Small fix to clear a reference to a removed node left by Scene$MouseHandler.
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/SceneTest.java line
> 978:
>
>> 976:
>> 977: @Test public void
>> testNoReferencesRemainToRemov
On Thu, 25 Mar 2021 12:29:38 GMT, Kevin Rushforth wrote:
> Simple fix to add a missing closing bracket to `PickResult::toString`. This
> includes a unit test that fails without the fix and passes with the fix.
This pull request has now been integrated.
Changeset: f3e27a08
Author:Kevin Rush
On Thu, 25 Mar 2021 22:08:36 GMT, Kevin Rushforth wrote:
>> Simple fix to add a missing closing bracket to `PickResult::toString`. This
>> includes a unit test that fails without the fix and passes with the fix.
>
> Kevin Rushforth has updated the pull request incrementally with one
> additiona
On Wed, 31 Mar 2021 10:58:27 GMT, Jose Pereda wrote:
> This PR replaces the deprecated iOS native view for web (UIWebView) with
> WKWebView.
>
> While most of the native API can be easily replaced from one to the other,
> there are some changes that affect the scripts execution, and therefore
On Tue, 30 Mar 2021 15:54:37 GMT, Marius Hanl
wrote:
>> This PR fixes an issue, where table cells are not removed from the table row
>> when the corresponding table column got removed. This will lead to empty
>> "ghost" cells laying around in the table.
>> This bug only occurs, when a fixed ce
On Wed, 31 Mar 2021 12:19:10 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add new line at the end of file
>
> modules/javafx.web/src/ios/java/com/sun/javafx/sg/prism/web/NGWebView.java
> lin
On Wed, 31 Mar 2021 12:26:17 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated iOS native view for web (UIWebView) with
>> WKWebView.
>>
>> While most of the native API can be easily replaced from one to the other,
>> there are some changes that affect the scripts execution, and ther
> This PR replaces the deprecated iOS native view for web (UIWebView) with
> WKWebView.
>
> While most of the native API can be easily replaced from one to the other,
> there are some changes that affect the scripts execution, and therefore some
> minor changes in WebEngine/JS2JavaBridge are r
On Wed, 31 Mar 2021 10:58:27 GMT, Jose Pereda wrote:
> This PR replaces the deprecated iOS native view for web (UIWebView) with
> WKWebView.
>
> While most of the native API can be easily replaced from one to the other,
> there are some changes that affect the scripts execution, and therefore
Pedro has done something like this with JMetro, maybe you can contact him.
https://pixelduke.com/java-javafx-theme-jmetro/
https://github.com/JFXtras/jfxtras-styles
On 2021-03-31 13:29, Ed Kennard wrote:
Hi all,
I’m about to embark on some work which will remove our dependency on the Modena
t
Hi all,
I’m about to embark on some work which will remove our dependency on the Modena
theme. We currently import Modena then override it wherever necessary, but now
I want to replace that with our own custom CSS built from the ground up. The
new custom CSS will be simpler and flatter than M
This PR replaces the deprecated iOS native view for web (UIWebView) with
WKWebView.
While most of the native API can be easily replaced from one to the other,
there are some changes that affect the scripts execution, and therefore some
minor changes in WebEngine/JS2JavaBridge are required.
Th
On Wed, 31 Mar 2021 05:36:06 GMT, John Hendrikx wrote:
> Small fix to clear a reference to a removed node left by Scene$MouseHandler.
modules/javafx.graphics/src/test/java/test/javafx/scene/SceneTest.java line 978:
> 976:
> 977: @Test public void
> testNoReferencesRemainToRemovedNodeAfter
On Fri, 26 Mar 2021 12:26:53 GMT, Jeanette Winzenburg
wrote:
>> To clarify, this with happening with ListViews in production code.
>> In some conditions, the status of a single cell doesn't update. The effect
>> is, that a Cell is stuck in the Editing mode.
>> If I remember correctly, it was ir
39 matches
Mail list logo
