ikx:
> >> It's not binary compatible, as changing the return type results in a
> >> new method that compiled code won't be able to find.
> >>
> >> See also "change result type (including void)" here:
> >>
> https://wiki.eclipse.or
Hi,
Picking up an old issue, JDK-8091393 [1], I went ahead and looked at the
work needed to implement it.
keySet() and entrySet() can both be made to return ObservableSet rather
easily. values() will probably require an ObservableCollection type.
Before discussing these details, my question is:
On Fri, 6 May 2022 14:13:55 GMT, Michael Strauß wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-pri
On Mon, 25 Apr 2022 11:47:45 GMT, Nir Lisker wrote:
> Update the the test utility. Includes:
> * Refactoring since there is no more need the split pre- and post-attenuation
> and light types.
> * Added customizable material to the `Boxes` to test the interaction between
> light
On Fri, 6 May 2022 14:09:13 GMT, Michael Strauß wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/nativ
On Fri, 6 May 2022 14:21:58 GMT, Michael Strauß wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unused comments, clean constructor
>
> modules/javafx.graphics/src/main/native-p
dded it to `psConstants` instead.
> * `vs2ps`
> * Removed the ambient color interpolation, which frees a register (no
> change in performance).
> * Simplified the structure (what is `LocalBumpOut` and why is it called
> `light` and contains `LocalBump?).
> * `Mtl1PS` and `psM
Refactoring and renaming changes to some of the D3D pipeline files and a few
changes on the Java side. These are various "leftovers" from previous issues
that we didn't want to touch at the time in order to confine the scope of the
changes. They will make future work easier.
Since there are man
seems like there's at least 2 bugs here
> > already.
> >
> >
> https://bugs.openjdk.java.net/browse/JDK-8090548?focusedCommentId=13771150&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13771150
> >
> > On Tue, Apr 26, 2022 at 4:25 AM Nir Lisker wrote:
>
ed.
>
> Note that GitHub decided to count the removal of the `AttenLightingSample`
> and addition of the `Controls` file as renaming. The sample is now run now
> only through `LightingSample`.
Nir Lisker has updated the pull request incrementally with one additional
commit sin
ed.
>
> Note that GitHub decided to count the removal of the `AttenLightingSample`
> and addition of the `Controls` file as renaming. The sample is now run now
> only through `LightingSample`.
Nir Lisker has updated the pull request incrementally with one additional
commit since
On Wed, 27 Apr 2022 14:01:06 GMT, Nir Lisker wrote:
> Updated the README link to match the CONTRIBUTING link.
This pull request has now been integrated.
Changeset: d69a498c
Author: Nir Lisker
URL:
https://git.openjdk.java.net/jfx/commit/d69a498c2cde73339bc99e6c02c0d47fe4b1b650
St
Updated the README link to match the CONTRIBUTING link.
-
Commit messages:
- Fixed link
Changes: https://git.openjdk.java.net/jfx/pull/788/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=788&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8285725
Stats: 1 l
the same filtered list of issues that
> CONTRIBUTING.md links to.
>
> -- Kevin
>
>
> On 4/26/2022 8:54 PM, Nir Lisker wrote:
> > In the README.md, under Issue Tracking, the link to "issues list" leads
> to
> > the JBS homepage. In CONTRIBUTING.md under Bug
In the README.md, under Issue Tracking, the link to "issues list" leads to
the JBS homepage. In CONTRIBUTING.md under Bug Report, the (almost) same
paragraph links to the JavaFX filter in JBS, which is a lot more helpful.
Shouldn't the link in README also link to the filtered issues list?
- Nir
s:comment-tabpanel#comment-13771150
On Tue, Apr 26, 2022 at 4:25 AM Nir Lisker wrote:
> Hi,
>
> Using the updated lighting test sample [1], I found some odd behavior with
> regards to PhongMaterial:
>
> 1. The effect of the opacity (alpha channel) of a self-illumination map is
> no
Hi,
Using the updated lighting test sample [1], I found some odd behavior with
regards to PhongMaterial:
1. The effect of the opacity (alpha channel) of a self-illumination map is
not documented, but lowering its value makes the object darker. I looked at
the pixel shader [2] and only the rgb com
Update the the test utility. Includes:
* Refactoring since there is no more need the split pre- and post-attenuation
and light types.
* Added customizable material to the `Boxes` to test the interaction between
lights and materials..
* Light colors can now be changed.
Note that GitHub decided to
On Thu, 18 Nov 2021 21:38:28 GMT, Kevin Rushforth wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
On Tue, 22 Mar 2022 07:46:40 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Mon, 21 Mar 2022 08:59:34 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Fri, 18 Mar 2022 09:55:30 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 146:
>>
>>> 144: * Creates an {@code ObservableValue} that holds the result of
>>> applying a
>>> 145: * mapping on this {@code ObservableValue}
On Fri, 18 Mar 2022 23:55:36 GMT, Michael Strauß wrote:
>> I've changed this to use your wording as I think it does read much better.
>>
>> Perhaps also possible:
>>
>> Creates a new {@code ObservableValue} that holds the value of a nested
>> {@code ObservableValue} supplied
>> by
On Fri, 18 Mar 2022 09:32:18 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/FlatMappedBinding.java
>> line 68:
>>
>>> 66: };
>>> 67: }
>>> 68: }
>>
>> Several files are missing newlines after the last closing brace. Do we
>> enforce this?
>>
>>
On Fri, 18 Mar 2022 09:48:39 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/Subscription.java
>> line 67:
>>
>>> 65: */
>>> 66: default Subscription and(Subscription other) {
>>> 67: Objects.requireNonNull(other);
>>
>> This exception cou
On Thu, 10 Mar 2022 17:49:38 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Thu, 10 Mar 2022 05:44:35 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Tue, 8 Mar 2022 21:03:12 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix wrong test values
>
> modules/javafx.base/src/tes
On Thu, 27 Jan 2022 21:49:07 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
action.
>
> -- Kevin
>
>
> On 2/9/2022 7:11 AM, Nir Lisker wrote:
> > Hi,
> >
> > When reviewing the docs changes to TabPane, I saw that some properties
> > mention the CSS that is related to them. I was wondering if we could
> > standardize it thro
On Wed, 9 Feb 2022 18:27:55 GMT, Ajit Ghaisas wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the unneces
Hi,
When reviewing the docs changes to TabPane, I saw that some properties
mention the CSS that is related to them. I was wondering if we could
standardize it through something like a @css tag that is given the css
string constant, or read automatically through the CssMetaData.
As an example:
On Wed, 9 Feb 2022 13:17:14 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line
>> 738:
>>
>>> 736:
>>> 737: /**
>>> 738: * This specifies how the {@code TabPane} handles tab closing
>>> from an end-user's
>>
>> Since you are f
On Wed, 9 Feb 2022 07:32:20 GMT, Ajit Ghaisas wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line
>> 295:
>>
>>> 293: *
>>> 294: * This value can also be set via CSS using {@code
>>> -fx-tab-min-width}.
>>> 295: *
>>
>> I would write
>>
>> T
On Wed, 9 Feb 2022 09:39:46 GMT, Ajit Ghaisas wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the unneces
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote:
> This is a Javadoc cleanup and correction fix for the TabPane as described in
> the JBS.
>
> Changes done for all the Properties of the TabPane -
> - Moved the property description to be over the property field.
> - Removed the unnecessary d
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote:
> This is a Javadoc cleanup and correction fix for the TabPane as described in
> the JBS.
>
> Changes done for all the Properties of the TabPane -
> - Moved the property description to be over the property field.
> - Removed the unnecessary d
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote:
> Now that the standard concrete light types were added, there is an
> opportunity to rearrange and rewrite some of the class docs. Here is a
> summary of the changes:
>
> * Moved the explanations of attenuation and
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote:
>> Now that the standard concrete light types were added, there is an
>> opportunity to rearrange and rewrite some of the class docs. Here is a
>> summary of the changes:
>>
>> * Moved the explanations of a
On Thu, 27 Jan 2022 19:01:32 GMT, Kevin Rushforth wrote:
>> I think the description should focus on the meaning of the respective term
>> in the lighting equation, and not on a non-technical analogy. In this case,
>> the analogy is a bit misleading on several aspects, including the fact that
>
> mentioned the properties it has.
> * Added examples of real-world applications for each light type.
> * Consolidated the writing style for all the subclasses.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
> mentioned the properties it has.
> * Added examples of real-world applications for each light type.
> * Consolidated the writing style for all the subclasses.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fixed tabl
> mentioned the properties it has.
> * Added examples of real-world applications for each light type.
> * Consolidated the writing style for all the subclasses.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Added implNote
> mentioned the properties it has.
> * Added examples of real-world applications for each light type.
> * Consolidated the writing style for all the subclasses.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed
On Tue, 25 Jan 2022 01:17:51 GMT, Kevin Rushforth wrote:
>> Now that the standard concrete light types were added, there is an
>> opportunity to rearrange and rewrite some of the class docs. Here is a
>> summary of the changes:
>>
>> * Moved the explanations of attenuation and direction up to
On Tue, 25 Jan 2022 06:21:37 GMT, Ambarish Rapte wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/AmbientLight.java line 37:
>>
>>> 35: *
>>> 36: * {@code AmbientLight}s can represent strong light sources in an
>>> enclosed area where the lights bounces from many
>>> 37: * objec
Got it, thanks.
On Fri, Jan 21, 2022 at 11:08 AM Florian Kirmaier <
florian.kirma...@gmail.com> wrote:
> Hi Nir Lisker,
>
> Yes, these are required.
> Btw, here is the link to the project, which can be used independently of
> OpenJFX: https://github.com/Sandec/JMemory
Hi,
Looking at JMemoryBuddy, there are unused fields and methods. It's not
clear if they were left in by mistake or are part of future work.
* line 89: AssertCollectable assertCollectable = new
AssertCollectable(weakReference);
* line 237: the method setMxBeanProxyName
* line 309: setAsReferenced
On Mon, 10 Jan 2022 21:09:15 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
>
> 1. If your main class extends Application, and you try to run it like:
> java -jar MyApplication.jar
> It will fail immediately with:
> Error: JavaFX runtime components are missing, and are required to run this
> application
> 2. If you "trick" it, by making your Application class a separat
Now that the standard concrete light types were added, there is an opportunity
to rearrange and rewrite some of the class docs. Here is a summary of the
changes:
* Moved the explanations of attenuation and direction up to `LightBase` since
different light types share characteristics. `LightBase
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote:
> Now that the standard concrete light types were added, there is an
> opportunity to rearrange and rewrite some of the class docs. Here is a
> summary of the changes:
>
> * Moved the explanations of attenuation and
On Mon, 10 Jan 2022 21:09:15 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Wed, 5 Jan 2022 12:29:01 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Wed, 5 Jan 2022 10:51:28 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java
>> line 152:
>>
>>> 150: * @return an {@link ObservableValue} which provides a mapping of
>>> the value
>>> 151: * held by this {@code ObservableValu
On Wed, 5 Jan 2022 12:29:01 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Mon, 28 Jun 2021 12:13:44 GMT, Nir Lisker wrote:
> Adds a directional light as a subclass of `LightBase`. I think that this is
> the correct hierarchy for it.
>
> I tried to simulate a directional light by putting a point light far away,
> but I got artifacts when the dis
On Mon, 20 Dec 2021 13:13:09 GMT, Nir Lisker wrote:
>> Adds a directional light as a subclass of `LightBase`. I think that this is
>> the correct hierarchy for it.
>>
>> I tried to simulate a directional light by putting a point light far away,
>> but I got a
On Wed, 5 Jan 2022 09:52:29 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/beans/binding/ObjectBinding.java
>> line 204:
>>
>>> 202: *
>>> 203: * @return {@code true} if this binding is allowed to become
>>> valid, otherwise
>>> 204: * {@code false}
>>
On Wed, 15 Dec 2021 11:43:36 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Wed, 15 Dec 2021 11:43:36 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
On Wed, 15 Dec 2021 11:43:36 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good
s.
>
> I added a system test that verifies the correct color result from a few
> directions. I also updated the lighting sample application to include 3
> directional lights and tested them on all the models visually. The lights
> seem to behave the way I would expect.
Nir Lisker
On Mon, 20 Dec 2021 12:57:51 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes for review comments
>
> tests/performance/3DLighting/attenuation/Environment.
On Sat, 18 Dec 2021 16:34:21 GMT, Kevin Rushforth wrote:
>> Btw, you don't need the "abs" for the gLightAttenuation check (you don't
>> have it now when checking against 0.5) so you can just change it to
>> `gLightAttenuation[i].w < EPSILON` which seems cleaner than testing against
>> 0.5.
>
>
s.
>
> I added a system test that verifies the correct color result from a few
> directions. I also updated the lighting sample application to include 3
> directional lights and tested them on all the models visually. The lights
> seem to behave the way I would expect.
Nir Lisker
On Tue, 7 Dec 2021 16:38:03 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/psMath.
s.
>
> I added a system test that verifies the correct color result from a few
> directions. I also updated the lighting sample application to include 3
> directional lights and tested them on all the models visually. The lights
> seem to behave the way I would expect.
Nir Lisker
s.
>
> I added a system test that verifies the correct color result from a few
> directions. I also updated the lighting sample application to include 3
> directional lights and tested them on all the models visually. The lights
> seem to behave the way I would expect.
Nir Lisker
On Tue, 7 Dec 2021 16:22:25 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sce
On Fri, 17 Dec 2021 15:18:51 GMT, Kevin Rushforth wrote:
>> This PR updates the `CONTRIBUTING.md` guide to address the following:
>>
>> 1. Clarify the process for adding new features / API changes, specifically
>> that they must be discussed on the mailing list as the first step.
>> 2. Add a li
On Fri, 17 Dec 2021 14:08:23 GMT, Michael Strauß wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor updates
>
> CONTRIBUTING.md line 18:
>
>> 16:
>> 17:
>> 18: If you find yourself wishing
On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth wrote:
>> This PR updates the `CONTRIBUTING.md` guide to address the following:
>>
>> 1. Clarify the process for adding new features / API changes, specifically
>> that they must be discussed on the mailing list as the first step.
>> 2. Add a li
On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth wrote:
>> This PR updates the `CONTRIBUTING.md` guide to address the following:
>>
>> 1. Clarify the process for adding new features / API changes, specifically
>> that they must be discussed on the mailing list as the first step.
>> 2. Add a li
On Wed, 17 Nov 2021 05:34:46 GMT, Abhinay Agarwal wrote:
> This work improves the performance of `MultipleSelectionModel` over large
> data sets by caching some values and avoiding unnecessary calls to
> `SelectedIndicesList#size`. It further improves the performance by reducing
> the number
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
This pull
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the c
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
Nir Lisker has updated the pull request incrementally with one addi
On Fri, 29 Oct 2021 11:42:38 GMT, Ajit Ghaisas wrote:
>> This PR deprecates mistakenly exposed field from class
>> javafx.scene.shape.Box.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review fix
Marked as reviewed by n
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
>> [JDK-82
On Thu, 28 Oct 2021 07:23:53 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - Ther
On Tue, 26 Oct 2021 06:24:35 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
>> [JDK-82
On Tue, 26 Oct 2021 09:54:43 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - Ther
On Wed, 27 Oct 2021 15:58:38 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> modules/javafx.graphics/src/main/java/javafx/stage/Window.java
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the c
On Sun, 24 Oct 2021 16:04:40 GMT, Andreas Heger wrote:
> I tried to use the Node.snapshot method, but in this case the taken snapshot
> always had the correct illumination, no matter what display was used and even
> though the scene on the display showed the wrong illumination. I guess the
> s
On Fri, 22 Oct 2021 17:53:27 GMT, Kevin Rushforth wrote:
> The PR fixes the broken links as described in the JBS issue. The correct link
> for the Oracle Contributor Agreement (OCA) is:
>
> https://oca.opensource.oracle.com/
Marked as reviewed by nlisker (Reviewer).
-
PR: https:/
On Fri, 22 Oct 2021 11:23:07 GMT, Ajit Ghaisas wrote:
> This PR fixes javadoc warnings primarily in javafx.graphics module along with
> a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - There are
On Wed, 20 Oct 2021 14:42:44 GMT, Ajit Ghaisas wrote:
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - There are still 20 javadoc warnings remaining in javafx.controls module and
> 3 warnings
s out this was already fixed
> > -- this specific fix might have been the one that introduced the #get
> > call in ExpressionHelper.
> >
> > On 06/10/2021 04:38, Nir Lisker wrote:
> >> I would also answer "no" to both points. This is also what the docs say.
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the c
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
Nir Lisker has updated the pull request incrementally with one addi
On Thu, 14 Oct 2021 23:50:10 GMT, Kevin Rushforth wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> modules/javafx.web/src
g applications?
> >
> > I think it's something we can and should consider changing. Unless there
> > are serious concerns, I would support changing this behavior as part of
> > avoiding eager evaluation when using invalidation listeners. It would
> > need to be well te
On Tue, 24 Aug 2021 16:29:11 GMT, Nir Lisker wrote:
> Added convenience factory factory methods for Background and Border.
This pull request has now been integrated.
Changeset: bb73d43b
Author: Nir Lisker
URL:
https://git.openjdk.java.net/jfx/com
eed a CSR describing the
> compatibility risk, and should probably get a release note.
>
> Any concerns in doing this?
>
> On the related question, I like the idea of nulling out the current value
> when a property is bound.
>
> -- Kevin
>
>
> On 9/11/2021 9:41 AM, Nir
I've created https://bugs.openjdk.java.net/browse/JDK-8274771
>
> Please have a look.
>
> --John
>
> On 04/10/2021 17:51, Nir Lisker wrote:
> > I think that a PR can be created. The only point we need to decide is
> about
> > the subscription models we talked ab
and a draft CSR if you want.
On Tue, Sep 21, 2021 at 1:36 PM Nir Lisker wrote:
> The OrElseBinding is incorrect
>>
>
> Yes, that was a typo with the order of the arguments in the ternary
> statement.
>
> I can rewrite the tests for JUnit 4 but I'd need a Nested runne
lways be added later if there is a compelling need.
>
> -- Kevin
>
> On 9/24/2021 4:50 AM, Nir Lisker wrote:
>
> I don't have a strong opinion on this addition.
>
> On Fri, Sep 24, 2021 at 2:47 PM Kevin Rushforth <
> kevin.rushfo...@oracle.com> wrote:
>
>
I much prefer JUnit 5 to 4, so I'm in favor.
On Sat, Sep 25, 2021 at 12:40 AM John Hendrikx wrote:
> Posting this to gauge the interest in adding JUnit 5 as a test
> dependency to JavaFX, enabling writing tests with this new version of
> JUnit while still supporting all JUnit 4 tests.
>
> A draf
1 - 100 of 848 matches
Mail list logo
