On Thu, 16 Sep 2021 22:25:27 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Thu, 16 Sep 2021 22:25:27 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Mon, 6 Sep 2021 13:30:46 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use color to int32 converter instead of hash
>
>> The other option, as you mention, is finding out if the 32-bit int h
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
On Thu, 9 Sep 2021 08:52:31 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property,
On Thu, 9 Sep 2021 08:52:31 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property,
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
On Wed, 8 Sep 2021 21:08:40 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback from reviewers
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 2589:
>
>> 2587
On Wed, 8 Sep 2021 22:37:18 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 707:
>>
>>> 705: * level of transparency.
>>> 706: *
>>> 707: * However, if the HTML content being loaded sets its own
>>
>> I looked at the generated ja
On Wed, 8 Sep 2021 16:15:36 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property,
On Wed, 8 Sep 2021 21:10:27 GMT, Kevin Rushforth wrote:
> I looked at the generated javadoc and this will read better without a
> paragraph break.
When you remove the paragraph break, please also remove the blank line to make
it clearer to future readers of the code that it is intended to be p
On Wed, 8 Sep 2021 16:15:36 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property,
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
On Mon, 6 Sep 2021 09:28:20 GMT, Jose Pereda wrote:
>> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 97:
>>
>>> 95:
>>> 96: private int fontSmoothingType;
>>> 97: private Color backgroundColor = Color.WHITE;
>>
>> This might be a problem, since there are code paths
On Sun, 29 Aug 2021 06:36:40 GMT, Michel Jung
wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Color to int32 conversion and more changes based on feedback
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage
On Mon, 6 Sep 2021 11:05:42 GMT, Jose Pereda wrote:
>> I don't doubt that the area should be cleared. What I was questioning is
>> whether this was the best place to do it? I'd be OK with it if you document
>> it.
>
> The two options I see so far to clear the area are the one I've committed
>
On Mon, 6 Sep 2021 13:30:46 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use color to int32 converter instead of hash
>
>> The other option, as you mention, is finding out if the 32-bit int h
On Fri, 27 Aug 2021 17:01:00 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 3 Sep 2021 21:11:48 GMT, Kevin Rushforth wrote:
>> I guess the assumption might be the other way around? Since the fill color
>> was not transparent, there was no need to clear the area, when rendering the
>> same solid rect at the new position?
>>
>> If you check this
>> [comment](ht
On Fri, 27 Aug 2021 17:01:00 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 3 Sep 2021 21:19:09 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use color to int32 converter instead of hash
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 97:
On Fri, 27 Aug 2021 17:34:25 GMT, Jose Pereda wrote:
>> I'm more worried about correctness than performance. Setting a clip does not
>> necessarily imply that the clipped region should be cleared. So this feels a
>> bit like a workaround for a missing `clearRect` elsewhere. I wonder if there
>
On Fri, 27 Aug 2021 17:01:00 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 27 Aug 2021 15:41:59 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Fri, 27 Aug 2021 13:05:24 GMT, Kevin Rushforth wrote:
>> Initially, this was needed when there was some level of transparency: when
>> scrolling the old content was not cleared and you could see it at its old
>> position.
>>
>> For the full transparency case, this is still the case, but for
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
On Fri, 27 Aug 2021 13:06:18 GMT, Kevin Rushforth wrote:
>> Yes, that makes total sense.
>>
>> In fact, there was also the need to add a new
>> [method](https://github.com/openjdk/jfx/pull/563/files#diff-b80bc720bf639cde38c5197a7619561221abcd34fb9ff7a933f4b932a1f36735R2579)
>> in `WebPage` to
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
On Fri, 27 Aug 2021 09:32:24 GMT, Jose Pereda wrote:
>> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java
>> line 459:
>>
>>> 457: public void setClip(WCRectangle c) {
>>> 458: if (!isOpaque) {
>>> 459: clearRect((int)c.getX(), (int
On Wed, 25 Aug 2021 23:24:35 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 615:
>
>> 613:
On Wed, 25 Aug 2021 23:23:00 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java
> li
On Wed, 25 Aug 2021 23:49:10 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 733:
>
>> 731:
On Wed, 25 Aug 2021 23:20:37 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2Graphics.java line
> 70:
>
>> 68:
On Wed, 25 Aug 2021 23:32:47 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 708:
>
>> 706: *
>>
On Tue, 24 Aug 2021 22:12:01 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
On Tue, 24 Aug 2021 22:12:01 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
On Mon, 23 Aug 2021 14:59:57 GMT, Jose Pereda wrote:
> Do I need to update its code with the latest changes of this PR?
Yes, although you can "batch up" the changes if you like until the review is
far enough along that the API is unlikely to change. One comment on the CSR is
that the specifica
On Thu, 12 Aug 2021 21:33:57 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Set since 18
>
> The API for the new property looks fine. I left a couple comments on the
> javadoc.
>
> You can cr
On Thu, 12 Aug 2021 21:28:53 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Set since 18
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 702:
>
>> 700: /**
>> 701:
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
On Sat, 3 Jul 2021 23:09:09 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property,
On Sat, 3 Jul 2021 23:09:09 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property,
On Sat, 3 Jul 2021 23:09:09 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType` property,
On Fri, Jul 2, 2021 at 2:50 PM Kevin Rushforth wrote:
> On Fri, 2 Jul 2021 11:01:56 GMT, Jose Pereda wrote:
>
> > Currently, `WebPage` has already a public `setBackgroundColor()` method,
> but the class is not public. Therefore, public API is needed in `WebView`
> to allow developers access to i
On Fri, 2 Jul 2021 11:01:56 GMT, Jose Pereda wrote:
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this PR provides public
> support for setting the backgro
> * Should the new `WebView` property be a `Color` or should it be a
`Paint`?
WebPage.setBackgroundColor calls:
JNIEXPORT void JNICALL Java_com_sun_webkit_WebPage_twkSetBackgroundColor
(JNIEnv* env, jobject self, jlong pFrame, jint backgroundColor)
which only admits an int value for the backgrou
On Fri, 2 Jul 2021 11:01:56 GMT, Jose Pereda wrote:
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothingType` property, this
Currently, `WebPage` has already a public `setBackgroundColor()` method, but
the class is not public. Therefore, public API is needed in `WebView` to allow
developers access to it.
In line with the `fontSmoothingType` property, this PR provides public support
for setting the background color of
58 matches
Mail list logo
