Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 18 Dec 2019 18:29:59 GMT, Hadzic Samir wrote: >> @Maxoudela the CSR has been approved. Go ahead and `/integrate` this and I >> will sponsor it. > > `/integrate` I think you need to enter the integrate command "as-is" without the back-quotes. the `/` needs to be the first character.

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 18 Dec 2019 17:32:05 GMT, Kevin Rushforth wrote: >> Looks good. >> >> Once the CSR is approved, this can be integrated. > > @Maxoudela the CSR has been approved. Go ahead and `/integrate` this and I > will sponsor it. `/integrate` - PR:

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 16 Dec 2019 21:32:58 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > Looks good. > > Once the CSR is approved, this can be integrated. @Maxoudela the CSR has been approved. Go ahead and `/integrate` this and I will sponsor it.

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 16 Dec 2019 21:33:11 GMT, Hadzic Samir wrote: >> Allright, this is a fix for JDK-8207957 > > The pull request has been updated with 1 additional commit. Looks good. Once the CSR is approved, this can be integrated. - Marked as reviewed by kcr (Lead). PR:

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 16 Dec 2019 12:12:31 GMT, Jeanette Winzenburg wrote: >> > > hmm ... think that the bot isn't yet clever enough: this pull request needs > approval of two reviewer with _review_ role (mine is only informal) This one still needs an approved CSR (the CSR is Finalized, but needs to be

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 16 Dec 2019 11:46:57 GMT, Ajit Ghaisas wrote: >> The pull request has been updated with 1 additional commit. > > hmm ... think that the bot isn't yet clever enough: this pull request needs approval of two reviewer with _review_ role (mine is only informal) - PR:

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 16 Dec 2019 11:47:15 GMT, Hadzic Samir wrote: >> Allright, this is a fix for JDK-8207957 > > The pull request has been updated with 1 additional commit. - Marked as reviewed by aghaisas (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/6

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 11 Dec 2019 00:32:32 GMT, Kevin Rushforth wrote: >> Thanks for the review. I do not have access to a computer right now, I'll >> update next week on Monday. >> >> Le lun. 9 déc. 2019 à 17:01, Kevin Rushforth a >> écrit : >> >>> I would like both @aghaisas

Re: [Rev 07] RFR: 8207957: TableSkinUtils should not contain actual code implementation

> Allright, this is a fix for JDK-8207957 The pull request has been updated with 1 additional commit. - Added commits: - 79817025: Remove trailing spaces Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

Re: [Rev 06] RFR: 8207957: TableSkinUtils should not contain actual code implementation

> Allright, this is a fix for JDK-8207957 The pull request has been updated with 1 additional commit. - Added commits: - 9991ec48: Minor typo fix upon Kevin's review Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 9 Dec 2019 23:20:19 GMT, Hadzic Samir wrote: >> I would like both @aghaisas and myself to review / approve this. I will >> sponsor it. >> >> In addition, the CSR needs to be approved before this can be integrated. > > Thanks for the review. I do not have access to a computer right

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 9 Dec 2019 21:01:40 GMT, Kevin Rushforth wrote: >> The fix looks good to me. >> >> I left a few minor comments, including adding a missing comma in the API >> docs, which will also need to be changed in the CSR. Once this is updated >> I'll review the CSR and then you can move the CSR

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 9 Dec 2019 20:58:28 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > The fix looks good to me. > > I left a few minor comments, including adding a missing comma in the API > docs, which will also need to be changed in the CSR. Once this is

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 9 Dec 2019 20:58:46 GMT, Hadzic Samir wrote: >> Allright, this is a fix for JDK-8207957 > > The pull request has been updated with 1 additional commit. The fix looks good to me. I left a few minor comments, including adding a missing comma in the API docs, which will also need to be

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 13 Nov 2019 11:26:35 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e1a9d2d0: Add more unit tests upon review > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/6/files > - new:

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Fri, 15 Nov 2019 12:59:15 GMT, Jeanette Winzenburg wrote: > On Wed, 13 Nov 2019 11:26:54 GMT, Hadzic Samir wrote: > >> On Thu, 7 Nov 2019 12:07:55 GMT, Jeanette Winzenburg >> wrote: >> >>> On Fri, 1 Nov 2019 10:59:57 GMT, Hadzic Samir wrote: >>> On Tue, 29 Oct 2019 13:19:27 GMT,

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 13 Nov 2019 11:26:54 GMT, Hadzic Samir wrote: > On Thu, 7 Nov 2019 12:07:55 GMT, Jeanette Winzenburg > wrote: > >> On Fri, 1 Nov 2019 10:59:57 GMT, Hadzic Samir wrote: >> >>> On Tue, 29 Oct 2019 13:19:27 GMT, Hadzic Samir wrote: >>> On Wed, 9 Oct 2019 16:01:38 GMT, Kevin

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:07:55 GMT, Jeanette Winzenburg wrote: > On Fri, 1 Nov 2019 10:59:57 GMT, Hadzic Samir wrote: > >> On Tue, 29 Oct 2019 13:19:27 GMT, Hadzic Samir wrote: >> >>> On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: >>> On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic

Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - e1a9d2d0: Add more unit tests upon review Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6/files/2b088993..e1a9d2d0 Webrevs: - full:

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:48:47 GMT, Jeanette Winzenburg wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/6/files >

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Fri, 1 Nov 2019 10:59:57 GMT, Hadzic Samir wrote: > On Tue, 29 Oct 2019 13:19:27 GMT, Hadzic Samir wrote: > >> On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: >> >>> On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote: >>> On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Tue, 29 Oct 2019 13:19:27 GMT, Hadzic Samir wrote: > On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote: >> >>> On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg >>> wrote: >>> On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 31 Oct 2019 12:18:37 GMT, Nir Lisker wrote: > On Wed, 30 Oct 2019 14:01:58 GMT, Hadzic Samir wrote: > >> On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: >> >>> The pull request has been updated with additional changes. >>> >>> >>> >>> Added commits: >>> -

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 30 Oct 2019 14:01:58 GMT, Hadzic Samir wrote: > On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader >> >>

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/6/files >

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6/files/1f1f7c44..2b088993

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Tue, 29 Oct 2019 14:38:10 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote: >> >>> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: >>> The pull request has been updated with additional

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote: > >> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: >> >>> The pull request has been updated with additional changes. >>> >>> >>> >>> Added commits: >>> -

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote: > >> On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg >> wrote: >> >>> On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: >>> Allright, this is a fix for JDK-8207957

Re: [Rev 03] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - 1f1f7c44: Javadoc update upon review for tableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6/files/49abc7c7..1f1f7c44

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for

Re: [Rev 02] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - 49abc7c7: Add space and update Javadoc for tableColumnHeader and NestedTableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote: > On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for > clarification on TableColumnHeader > > Changes: > - all:

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote: > On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg > wrote: > >> On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: >> >>> Allright, this is a fix for JDK-8207957 >>> >>> >>> >>> Commits: >>> - 969ebb51: Fixing

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for > clarification on TableColumnHeader > > Changes: > - all:

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg wrote: > On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > >> Allright, this is a fix for JDK-8207957 >> >> >> >> Commits: >> - 969ebb51: Fixing TableColumnHeaderTest >> - 9d379619: Removing Tablecolumnbasehelper

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for clarification on TableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new:

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > Allright, this is a fix for JDK-8207957 > > > > Commits: > - 969ebb51: Fixing TableColumnHeaderTest > - 9d379619: Removing Tablecolumnbasehelper > - 4fe020fc: Fix javadoc for TableColumnHeader > - c422c80f: Minor

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > Allright, this is a fix for JDK-8207957 > > > > Commits: > - 969ebb51: Fixing TableColumnHeaderTest > - 9d379619: Removing Tablecolumnbasehelper > - 4fe020fc: Fix javadoc for TableColumnHeader > - c422c80f: Minor

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > Allright, this is a fix for JDK-8207957 > > > > Commits: > - 969ebb51: Fixing TableColumnHeaderTest > - 9d379619: Removing Tablecolumnbasehelper > - 4fe020fc: Fix javadoc for TableColumnHeader > - c422c80f: Minor

RFR: 8207957: TableSkinUtils should not contain actual code implementation

Allright, this is a fix for JDK-8207957 Commits: - 969ebb51: Fixing TableColumnHeaderTest - 9d379619: Removing Tablecolumnbasehelper - 4fe020fc: Fix javadoc for TableColumnHeader - c422c80f: Minor modification and uni test added. - b2bdfb5b: Change resizeColumn to protected