Re: 8 review request: RT-34791: Change javadoc copyright link to point to JDK 8 license
Kevin, The changes look great. Approved. Thanks, Mong On 1/13/2014 3:54 PM, Kevin Rushforth wrote: Mong, Please review the following (in the JIRA). https://javafx-jira.kenai.com/browse/RT-34791 Thanks. -- Kevin
Re: JavaFX changes in early acess JDK 8 versions
OK, I understand, but thanks for your answer though. Herve 2014/1/14 Kevin Rushforth > Unfortunately, this is not currently available, as we don't have a good > way to track and tag the bugs as to which build they were fixed in. > > -- Kevin > > > > Herve Girod wrote: > >> Hello, >> >> I just noticed that the new JDK 8 build 123 appeared today or yesterday. >> As >> usual it include the change list for the JDK. However, how is it possible >> to know what JavaFX changes (JIRA RT ?) have been applied to each build ? >> >> Thanks, >> >> Hervé >> >> >
8 review request: RT-34791: Change javadoc copyright link to point to JDK 8 license
Mong, Please review the following (in the JIRA). https://javafx-jira.kenai.com/browse/RT-34791 Thanks. -- Kevin
Re: JavaFX changes in early acess JDK 8 versions
Unfortunately, this is not currently available, as we don't have a good way to track and tag the bugs as to which build they were fixed in. -- Kevin Herve Girod wrote: Hello, I just noticed that the new JDK 8 build 123 appeared today or yesterday. As usual it include the change list for the JDK. However, how is it possible to know what JavaFX changes (JIRA RT ?) have been applied to each build ? Thanks, Hervé
hg: openjfx/8u-dev/rt: 8 new changesets
Changeset: 6216d402dc1b Author:jgiles Date: 2014-01-13 09:34 +1300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6216d402dc1b Remove VBoxBuilder dependency from HelloSplitPane ! apps/toys/Hello/src/main/java/hello/HelloSplitPane.java Changeset: e35db0874061 Author:jgiles Date: 2014-01-13 13:56 +1300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e35db0874061 RT-35233: [TreeTableView, TreeTableColumn] Fix incomplete API documentation and TODOs ! modules/controls/src/main/java/javafx/scene/control/TableView.java ! modules/controls/src/main/java/javafx/scene/control/TreeTableColumn.java ! modules/controls/src/main/java/javafx/scene/control/TreeTableView.java ! modules/controls/src/main/java/javafx/scene/control/cell/TreeItemPropertyValueFactory.java Changeset: dace65c4c5d7 Author:jgiles Date: 2014-01-13 14:11 +1300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/dace65c4c5d7 RT-35266: TableView Column Table header sort dots not consistent when hiding and showing columns ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/TableColumnHeader.java Changeset: 2f9b188da440 Author:jgiles Date: 2014-01-13 14:45 +1300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2f9b188da440 RT-35182: [Accelerators] Changing accelerator dynamically does not use the new accelerator ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ContextMenuContent.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/MenuButtonSkinBase.java Changeset: e0b13bbc1f8d Author:jgiles Date: 2014-01-14 08:25 +1300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e0b13bbc1f8d Fixing copyright year on files modified in earlier changesets. ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ContextMenuContent.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/MenuButtonSkinBase.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/TableColumnHeader.java ! modules/controls/src/main/java/javafx/scene/control/TreeTableColumn.java ! modules/controls/src/main/java/javafx/scene/control/TreeTableView.java ! modules/controls/src/main/java/javafx/scene/control/cell/TreeItemPropertyValueFactory.java Changeset: 7e904aa338e1 Author:Felipe Heidrich Date: 2014-01-13 07:54 -0800 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/7e904aa338e1 RT-34957: [Font, Linux] Crash on OSPango.pango_shape [running ensemble] ! modules/graphics/src/main/native-font/pango.c Changeset: 52393354c6dd Author:snorthov Date: 2014-01-13 15:51 -0500 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/52393354c6dd RT-4169: [Stage] Setting 'icons' to null do not reset the Stage icon Summary: The code to clean the icon in Glass was not being called by Quantum. When the code was called, there were problems in native glass on Mac and GTK that needed to be fixed. Reviewed-by: anthony ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java ! modules/graphics/src/main/native-glass/gtk/GlassWindow.cpp ! modules/graphics/src/main/native-glass/mac/GlassWindow.m Changeset: 2910f4be0016 Author:Felipe Heidrich Date: 2014-01-13 10:27 -0800 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2910f4be0016 Fix bad rendering mentioned in RT-34957. This in is preparation for RT-35255/RT-35221 ! modules/graphics/src/main/java/com/sun/javafx/font/freetype/PangoGlyphLayout.java
JavaFX changes in early acess JDK 8 versions
Hello, I just noticed that the new JDK 8 build 123 appeared today or yesterday. As usual it include the change list for the JDK. However, how is it possible to know what JavaFX changes (JIRA RT ?) have been applied to each build ? Thanks, Hervé
Re: OpenGL on Windows
Essentially, OpenGL on Windows would be another platform to support. If you build your own OpenJFX for Windows, it will work but it is completely unsupported. https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX If you run into any problems after you have successfully built (ie. the ES2 code is not there), open a JIRA request for OpenGL support on Windows and we can follow up there. Even if we don't fix the JIRA, we can capture the information for other that might want to do the same thing. Steve On 2014-01-13 1:19 PM, Felix Bembrick wrote: Having watched the presentation from Stephen and Felipe about integrating JavaFX and native technologies such as OpenGL, I am inspired to work on a solution for my own needs for fast rendering of thousands of objects using the techniques in the video which I would then contribute to the community. However, it's quite clear that any OpenGL based solution is not going to work on Windows because OpenGL is not enabled on that platform. Given that I don't want to write code that supports both OpenGL and D3D, could someone answer these questions? 1. Why is OpenGL not enabled on Windows? Is it a performance thing? Is it because of poor text rendering with OpenGL? 2. What's involved in hacking Prism to enable OpenGL? 3. If 2 is not possible, is there some way to develop an abstraction layer on top of both OpenGL and D3D? Thanks, Felix
OpenGL on Windows
Having watched the presentation from Stephen and Felipe about integrating JavaFX and native technologies such as OpenGL, I am inspired to work on a solution for my own needs for fast rendering of thousands of objects using the techniques in the video which I would then contribute to the community. However, it's quite clear that any OpenGL based solution is not going to work on Windows because OpenGL is not enabled on that platform. Given that I don't want to write code that supports both OpenGL and D3D, could someone answer these questions? 1. Why is OpenGL not enabled on Windows? Is it a performance thing? Is it because of poor text rendering with OpenGL? 2. What's involved in hacking Prism to enable OpenGL? 3. If 2 is not possible, is there some way to develop an abstraction layer on top of both OpenGL and D3D? Thanks, Felix
Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]
Fix it. You own the code. If you can test on an Android device, then great. Otherwise, get Stefan or Johan to test your changes. Steve On 2014-01-13 8:46 AM, Alexander Kouznetsov wrote: Hi Steve, In general it looks good but I want to correct some parts of it. How should I proceed in this case? Best regards, Alexander Kouznetsov (408) 276-0387 On 3 янв 2014 21:44, Stephen F Northover wrote: Hi Alex, Samples were changed to support Android. Apparently, hitting escape twice should exit an application and this behavior was coded into EnsembleApp. I'm not an Android guy but if this is standard Android behavior, it should be part of JFX, not the example code. Anyhow, I'll let Stefan or Johan comment on this and they can enter a follow on JIRA. Steve On 2014-01-03 12:32 PM, hang...@oracle.com wrote: Changeset: 6f0901527ad0 Author:snorthov Date: 2014-01-03 12:23 -0500 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6f0901527ad0 RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android Reviewed-by: snorthov Contributed-by: Stefan Fuchs ! apps/samples/Ensemble8/src/app/java/ensemble/EnsembleApp.java ! apps/samples/Ensemble8/src/app/java/ensemble/PlatformFeatures.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/Description.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SamplePageContent.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SourceTab.java ! apps/samples/Ensemble8/src/app/java/ensemble/util/FeatureChecker.java ! modules/base/src/main/java/com/sun/javafx/PlatformUtil.java
Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]
What ever the decision on this, if there is further action, please enter a JIRA. If not, then the discussion is lost to ether. Steve On 2014-01-13 8:49 AM, Alexander Kouznetsov wrote: Hi Stefan, Thank you for this summary. As an android user I would say that #2 is not a good options for Ensemble. #3 is better than #1. However, it usually responds to the second key press only within a short period of time. About the time a notice message is shown. Best regards, Alexander Kouznetsov (408) 276-0387 On 3 янв 2014 23:43, Stefan Fuchs wrote: Hi, well, the back button is always used to go back one dialog level, until the start screen has be reached. (Dialogs are canceled, browsers go to previous website, etc...) If you press the back button on the start screen of the app, I found three different strategies to handle the back button: 1. Exit the app on first button press (examples: WhatsApp, Google Maps) 2. Hide the app on first button press and let the system kill the application, if system memory is exhausted. (examples: FireFox, Chrome) 3. Exit the app on second button press (note that most apps using this strategy print a notice message, after the first key press, which is currently not implemented for Ensemble8) (examples: Samsungs App Store) Stefan Stephen F Northover wrote: Hi Alex, Samples were changed to support Android. Apparently, hitting escape twice should exit an application and this behavior was coded into EnsembleApp. I'm not an Android guy but if this is standard Android behavior, it should be part of JFX, not the example code. Anyhow, I'll let Stefan or Johan comment on this and they can enter a follow on JIRA. Steve On 2014-01-03 12:32 PM, hang...@oracle.com wrote: Changeset: 6f0901527ad0 Author:snorthov Date: 2014-01-03 12:23 -0500 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6f0901527ad0 RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android Reviewed-by: snorthov Contributed-by: Stefan Fuchs ! apps/samples/Ensemble8/src/app/java/ensemble/EnsembleApp.java ! apps/samples/Ensemble8/src/app/java/ensemble/PlatformFeatures.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/Description.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SamplePageContent.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SourceTab.java ! apps/samples/Ensemble8/src/app/java/ensemble/util/FeatureChecker.java ! modules/base/src/main/java/com/sun/javafx/PlatformUtil.java
hg: openjfx/8u-dev/rt: 3 new changesets
Changeset: f487abfe1990 Author:Martin Sladecek Date: 2014-01-13 13:29 +0100 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f487abfe1990 RT-35237 When a Bidirectional binding fails, old value restoration may cause an exception hiding the real cause ! modules/base/src/main/java/com/sun/javafx/binding/BidirectionalBinding.java ! modules/base/src/test/java/com/sun/javafx/binding/BidirectionalBindingTest.java Changeset: 838ab16784b0 Author:Martin Sladecek Date: 2014-01-13 14:27 +0100 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/838ab16784b0 [JAVADOC] RT-35234 [Layout] Fix TODO comments in the API documentation ! modules/graphics/src/main/java/javafx/scene/layout/BorderImage.java ! modules/graphics/src/main/java/javafx/scene/layout/CornerRadii.java Changeset: 399f574b5ab8 Author:snorthov Date: 2014-01-10 15:05 -0500 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/399f574b5ab8 HelloSanity: print out when any action is invoked in a menu ! apps/toys/Hello/src/main/java/hello/TestBuilder.java
Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]
Hi Stefan, Thank you for this summary. As an android user I would say that #2 is not a good options for Ensemble. #3 is better than #1. However, it usually responds to the second key press only within a short period of time. About the time a notice message is shown. Best regards, Alexander Kouznetsov (408) 276-0387 On 3 янв 2014 23:43, Stefan Fuchs wrote: Hi, well, the back button is always used to go back one dialog level, until the start screen has be reached. (Dialogs are canceled, browsers go to previous website, etc...) If you press the back button on the start screen of the app, I found three different strategies to handle the back button: 1. Exit the app on first button press (examples: WhatsApp, Google Maps) 2. Hide the app on first button press and let the system kill the application, if system memory is exhausted. (examples: FireFox, Chrome) 3. Exit the app on second button press (note that most apps using this strategy print a notice message, after the first key press, which is currently not implemented for Ensemble8) (examples: Samsungs App Store) Stefan Stephen F Northover wrote: Hi Alex, Samples were changed to support Android. Apparently, hitting escape twice should exit an application and this behavior was coded into EnsembleApp. I'm not an Android guy but if this is standard Android behavior, it should be part of JFX, not the example code. Anyhow, I'll let Stefan or Johan comment on this and they can enter a follow on JIRA. Steve On 2014-01-03 12:32 PM, hang...@oracle.com wrote: Changeset: 6f0901527ad0 Author:snorthov Date: 2014-01-03 12:23 -0500 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6f0901527ad0 RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android Reviewed-by: snorthov Contributed-by: Stefan Fuchs ! apps/samples/Ensemble8/src/app/java/ensemble/EnsembleApp.java ! apps/samples/Ensemble8/src/app/java/ensemble/PlatformFeatures.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/Description.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SamplePageContent.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SourceTab.java ! apps/samples/Ensemble8/src/app/java/ensemble/util/FeatureChecker.java ! modules/base/src/main/java/com/sun/javafx/PlatformUtil.java
Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]
Hi Steve, In general it looks good but I want to correct some parts of it. How should I proceed in this case? Best regards, Alexander Kouznetsov (408) 276-0387 On 3 янв 2014 21:44, Stephen F Northover wrote: Hi Alex, Samples were changed to support Android. Apparently, hitting escape twice should exit an application and this behavior was coded into EnsembleApp. I'm not an Android guy but if this is standard Android behavior, it should be part of JFX, not the example code. Anyhow, I'll let Stefan or Johan comment on this and they can enter a follow on JIRA. Steve On 2014-01-03 12:32 PM, hang...@oracle.com wrote: Changeset: 6f0901527ad0 Author:snorthov Date: 2014-01-03 12:23 -0500 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6f0901527ad0 RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android Reviewed-by: snorthov Contributed-by: Stefan Fuchs ! apps/samples/Ensemble8/src/app/java/ensemble/EnsembleApp.java ! apps/samples/Ensemble8/src/app/java/ensemble/PlatformFeatures.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/Description.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SamplePageContent.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SourceTab.java ! apps/samples/Ensemble8/src/app/java/ensemble/util/FeatureChecker.java ! modules/base/src/main/java/com/sun/javafx/PlatformUtil.java
[8u] Post-commit review: RT-35237, When a Bidirectional binding fails, old value restoration may cause an exception hiding the real cause
Hello, here's a changeset for RT-35237 (When a Bidirectional binding fails, old value restoration may cause an exception hiding the real cause), if anybody's interested. http://hg.openjdk.java.net/openjfx/8u-dev/graphics/rt/rev/f487abfe1990 Thanks, -Martin
Re: FX Experience Tools
As Jonathan mentioned, Scene Builder 1.1 or the 2.0 Early Access has some CSS support. http://www.oracle.com/technetwork/java/javafx/tools/index.html Take a look at the CSS Analyzer panel. There is a demo of the feature at around 31:30 of this J1 talk: http://parleys.com/play/524f2d9ae4b0c4f11ec575ff Cheers, Mo On 12 Jan 2014, at 10:15, Jonathan Giles wrote: > I'm not really sure. A good starting point would be to explore what > tooling is available in Scene Builder. > > -- Jonathan > > On 12/01/2014 10:13 p.m., Peter Penzov wrote: >> Is there any similar tool like FX Experience Tools for css layout? >> >> >> On Sun, Jan 12, 2014 at 11:09 AM, Jonathan Giles >> mailto:jonathan.gi...@oracle.com>> wrote: >> >>I doubt these tools will be refreshed for 8.0 (if necessary - I >>haven't >>tested how well they work in 8.0), but the code is all available in >>github so it would be great to see someone step up and make any >>necessary improvements! You can find all the code here: >> >>https://github.com/fxexperience/code >> >>-- Jonathan >> >>On 8/01/2014 11:29 p.m., Peter Penzov wrote: >>> Hi All, >>> I found this link about the FX Experience Tools. >>> >>> http://fxexperience.com/2012/03/announcing-fx-experience-tools/ >>> >>> It seems that this tool is no longer actively developed. Are >>there any >>> plans to continue to support it and also can I use use it in >>JavaFX 8? >>> >>> BR, >>> Peter >> >> >