Re: monitor mouse events but not capture them

2014-06-08 Thread Martin Sladecek
Hi Tom, have you tried .addEventFilter() method? It receives the Event before the controls underneath the canvas, in the capturing phase. If you don't consume the Event, it should pass down to the controls. For more on the topic, see http://docs.oracle.com/javafx/2/events/processing.htm or htt

Re: monitor mouse events but not capture them

2014-06-09 Thread Martin Sladecek
position. -Martin On 06/09/2014 08:44 AM, Tom Eugelink wrote: Ye. It does not work on the canvas pane, I suspect because of the pickOnBounds, but it does work on the stackpane. Plus, I can register to the stack pane without claiming the onMouseClick/Press hook. Many thanks! Tom On

Re: monitor mouse events but not capture them

2014-06-09 Thread Martin Sladecek
: Hm, maybe I chose bad words; I'm not using Canvas, but just a Pane. Since the Pane is only used to draw the menu on when it need to appear, I'm calling it the canvas pane, as in "what is painted on". On 2014-6-9 9:46, Martin Sladecek wrote: Just looked at the code and it se

Re: monitor mouse events but not capture them

2014-06-09 Thread Martin Sladecek
the circular menu should pass mouse events to the underlying window. -Martin On 06/09/2014 10:20 AM, Tom Eugelink wrote: Or to see in in action with a single java -jar statement, download the samples from. http://jfxtras.org/ On 2014-6-9 10:13, Martin Sladecek wrote: OK, so to avoid furt

Re: How to scale control properly?

2014-06-09 Thread Martin Sladecek
is control: https://bitbucket.org/controlsfx/controlsfx/src/96f40eb0b579277139192e2398fbbaf7fd01f91e/controlsfx/src/main/resources/org/controlsfx/control/rating.css?at=default -- Rafal 2014-06-05 16:12 GMT+02:00 Martin Sladecek : Hi Rafal, you can wrap the control in a Group. That way, it's (actual

Formatted text field API (RT-14000, RT-30881)

2014-06-11 Thread Martin Sladecek
Hello, I would like to start some discussion about formatted text field API. The related JIRA issues are RT-14000 (formatted text field) and RT-30881 (content filter). The RT-30881 defines a content filter for all text input controls (in TextInputControl class), like TextField and TextArea. T

Re: Formatted text field API (RT-14000, RT-30881)

2014-06-11 Thread Martin Sladecek
s, there should be no problem with having writable value. -Martin On 11.6.2014 15:53, Scott Palmer wrote: In FormattedTextField why is the value property returned as a read-only property? This control should allow bi-directional bindings to the value property. Scott On Wed, Jun 11, 2014 at

Re: Formatted text field API (RT-14000, RT-30881)

2014-06-11 Thread Martin Sladecek
cases for this: - a regular binding could be used with a read-only FormattedTextField for cases where you want the text representation shown in the UI and have it selectable and readable for copy/paste. - a bi-directional binding should "just work" Scott On Wed, Jun 11, 2014 at 9:59 A

Re: Formatted text field API (RT-14000, RT-30881)

2014-06-11 Thread Martin Sladecek
a editable ComboBox? Scott On Wed, Jun 11, 2014 at 10:08 AM, Martin Sladecek mailto:martin.slade...@oracle.com>> wrote: Although I'm not sure the second one can be considered a use-case, I agree that somebody might want uneditable field with some format (and it's u

hg: openjfx/8u-dev/rt: RT-37668 FilteredList reports a size of zero until a Predicate is supplied.

2014-06-24 Thread martin . sladecek
Changeset: c367a3e860f2 Author:Martin Sladecek Date: 2014-06-24 15:35 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c367a3e860f2 RT-37668 FilteredList reports a size of zero until a Predicate is supplied. ! modules/base/src/main/java/javafx/collections

[8u40] API Review: Allow auto-hiding of PopupWindow on owner node press

2014-06-25 Thread Martin Sladecek
Hello, I propose a new property for PopupWindow that would allow developer to control autohiding policy when PopupWindow has an owner node. Currently, clicking the owner Node does not hide the window, but the new property (autoHideOnOwnerNodeMouseEvents) can change this. JIRA: https://javafx-

hg: openjfx/8u-dev/rt: RT-17716 Some controls can only be created on the FX application thread

2014-06-26 Thread martin . sladecek
Changeset: 26d0acd8a72e Author:Martin Sladecek Date: 2014-06-26 09:30 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/26d0acd8a72e RT-17716 Some controls can only be created on the FX application thread Reviewed by: anthony ! modules/graphics/src/main/java/javafx

Re: API enhancement request to make stage respect scene's min size

2014-06-26 Thread Martin Sladecek
Hi Robert, I think this is the JIRA issue you are looking for: https://javafx-jira.kenai.com/browse/RT-19183 This might be a good candidate for 8u40 actually... -Martin On 06/26/2014 01:10 PM, Robert Krüger wrote: Hi, right now, I am doing this to prevent stage windows to be resizable in a

Re: Deserializing javafx.event.EventType

2014-06-30 Thread Martin Sladecek
Hi, EventTypes are serializable solely for the purpose of Event serialization (which is serializable because it inherits from java.util.EventObject). When you deserialize Events, the corresponding EventType objects are already initialized, so the EventTypes are correctly mapped. -Martin On 0

hg: openjfx/8u-dev/rt: [TEST] RT-37752 Unit test failure in Snapshot1Test after fix for RT-17716

2014-06-30 Thread martin . sladecek
Changeset: 65cabfa41abe Author:Martin Sladecek Date: 2014-06-30 09:53 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/65cabfa41abe [TEST] RT-37752 Unit test failure in Snapshot1Test after fix for RT-17716 ! tests/system/src/test/java/javafx/scene/Snapshot1Test.java

hg: openjfx/8u-dev/rt: [COMMENT-ONLY] removed obsolete comment after RT-37752 fix

2014-06-30 Thread martin . sladecek
Changeset: 030772161397 Author:Martin Sladecek Date: 2014-06-30 17:21 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/030772161397 [COMMENT-ONLY] removed obsolete comment after RT-37752 fix ! tests/system/src/test/java/javafx/scene/Snapshot1Test.java

Re: Formatted text field API (RT-14000, RT-30881)

2014-07-02 Thread Martin Sladecek
There's a new proposal here: https://javafx-jira.kenai.com/browse/RT-14000 I merged FormattedTextField and content filter to a single Formatter class, that's now part of the TextInputControl. -Martin On 06/11/2014 10:50 AM, Martin Sladecek wrote: Hello, I would like to start some

hg: openjfx/8u-dev/rt: RT-37586 [StackedAreaChart] Display problem with StackedAreaChart when the axis is not displayed

2014-07-02 Thread martin . sladecek
Changeset: c21b1705eb10 Author:Martin Sladecek Date: 2014-07-02 13:12 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c21b1705eb10 RT-37586 [StackedAreaChart] Display problem with StackedAreaChart when the axis is not displayed Reviewed by: dgrieve ! modules/controls

hg: openjfx/8u-dev/rt: RT-37747 Additional app-thread checks should be added (back) after RT-17716

2014-07-02 Thread martin . sladecek
Changeset: 8cc538c3a7f8 Author:Martin Sladecek Date: 2014-07-02 13:17 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8cc538c3a7f8 RT-37747 Additional app-thread checks should be added (back) after RT-17716 Reviewed by: kcr, anthony ! modules/graphics/src/main/java

hg: openjfx/8u-dev/rt: RT-37758 Relax restriction on creating Scene only on FX App thread

2014-07-03 Thread martin . sladecek
Changeset: 1efcff018597 Author:Martin Sladecek Date: 2014-07-03 09:08 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1efcff018597 RT-37758 Relax restriction on creating Scene only on FX App thread Reviewed by: kcr, anthony, snorthov ! modules/graphics/src/main/java

hg: openjfx/8u-dev/rt: RT-37389 Bindings class spits out a lot of unneeded log messages

2014-07-03 Thread martin . sladecek
Changeset: ebff56b4399f Author:Martin Sladecek Date: 2014-07-03 13:22 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ebff56b4399f RT-37389 Bindings class spits out a lot of unneeded log messages ! modules/base/src/main/java/javafx/beans/binding/Bindings.java

hg: openjfx/8u-dev/rt: RT-37799 api doc of Task.call incomplete

2014-07-03 Thread martin . sladecek
Changeset: 27b166eab071 Author:Martin Sladecek Date: 2014-07-03 13:29 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/27b166eab071 RT-37799 api doc of Task.call incomplete ! modules/graphics/src/main/java/javafx/concurrent/Task.java

8u40 API proposal: ScrollPane's minViewportWidth/minViewportHeight

2014-07-04 Thread Martin Sladecek
Hello, I propose to add 2 additional properties to ScrollPane: minViewportHeight and minViewportWidth. They should work the same way as prefViewportWidth/prefViewportHeight, specifying the minimum size for the viewport, not ScrollPane as a whole. JIRA: https://javafx-jira.kenai.com/browse/RT-3

hg: openjfx/8u-dev/rt: RT-37576 “tickLableRotation” property can not work as expected

2014-07-04 Thread martin . sladecek
Changeset: a2afbc47aaea Author:Martin Sladecek Date: 2014-07-04 10:03 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a2afbc47aaea RT-37576 “tickLableRotation” property can not work as expected Reviewed by: dgrieve ! modules/controls/src/main/java/javafx/scene

hg: openjfx/8u-dev/rt: RT-37497 javafx.animation.Animation#impl_finished swallows exceptions

2014-07-07 Thread martin . sladecek
Changeset: 9e28056c8de1 Author:Martin Sladecek Date: 2014-07-07 09:27 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/9e28056c8de1 RT-37497 javafx.animation.Animation#impl_finished swallows exceptions ! modules/graphics/src/main/java/javafx/animation/Animation.java

hg: openjfx/8u-dev/rt: RT-37358 [FXMLLoader]: Null builderFactory makes it impossible to load many types of classes

2014-07-07 Thread martin . sladecek
Changeset: 23b4a850e32b Author:Martin Sladecek Date: 2014-07-07 09:31 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/23b4a850e32b RT-37358 [FXMLLoader]: Null builderFactory makes it impossible to load many types of classes ! modules/fxml/src/main/java/javafx/fxml

hg: openjfx/8u-dev/rt: RT-37821 ConcurrentModificationException if an attempt is made to remove an accelerator whilst an accelerator callback is being processed

2014-07-07 Thread martin . sladecek
Changeset: dfc51c66d790 Author:Martin Sladecek Date: 2014-07-07 10:43 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/dfc51c66d790 RT-37821 ConcurrentModificationException if an attempt is made to remove an accelerator whilst an accelerator callback is being processed

hg: openjfx/8u-dev/rt: RT-37614 [StackedAreaChart]: StackedAreaChart y-axis should be always a ValueAxis

2014-07-08 Thread martin . sladecek
Changeset: 92b6c61c0942 Author:Martin Sladecek Date: 2014-07-08 12:42 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/92b6c61c0942 RT-37614 [StackedAreaChart]: StackedAreaChart y-axis should be always a ValueAxis Reviewed by: snorthov, dgrieve ! modules/controls/src

hg: openjfx/8u-dev/rt: RT-37864 MenuBar in SubScene does not work

2014-07-10 Thread martin . sladecek
Changeset: 66696ac8abca Author:Martin Sladecek Date: 2014-07-11 08:44 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/66696ac8abca RT-37864 MenuBar in SubScene does not work Reviewed by: dgrieve ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin

hg: openjfx/8u-dev/rt: [TEST] fixed failing tests caused by changeset 66696ac8abca (RT-37864 fix)

2014-07-11 Thread martin . sladecek
Changeset: 59ec777e8bf3 Author:Martin Sladecek Date: 2014-07-11 14:28 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/59ec777e8bf3 [TEST] fixed failing tests caused by changeset 66696ac8abca (RT-37864 fix) ! modules/web/src/test/java/javafx/scene/web

hg: openjfx/8u-dev/rt: RT-37928 [Monocle/Embedded] exception when using virtual keyboard

2014-07-14 Thread martin . sladecek
Changeset: ce73e967df61 Author:Martin Sladecek Date: 2014-07-15 07:37 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ce73e967df61 RT-37928 [Monocle/Embedded] exception when using virtual keyboard Reviewed by: kselle ! modules/controls/src/main/java/com/sun/javafx

hg: openjfx/8u-dev/rt: RT-37407 [ScrollPane, TextArea] Introduce minViewportWidth and minViewportHeight properties

2014-07-14 Thread martin . sladecek
Changeset: 2e66062882e9 Author:Martin Sladecek Date: 2014-07-15 07:42 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2e66062882e9 RT-37407 [ScrollPane, TextArea] Introduce minViewportWidth and minViewportHeight properties Reviewed by: snorthov, kcr ! modules

hg: openjfx/8u-dev/rt: RT-37926 JavaBeanProperties fixed DescriptorListenerCleaner still causes memory leaks

2014-07-15 Thread martin . sladecek
Changeset: 321b64885bc3 Author:Martin Sladecek Date: 2014-07-15 09:29 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/321b64885bc3 RT-37926 JavaBeanProperties fixed DescriptorListenerCleaner still causes memory leaks Contributed by: marco.schu...@eckert-partner.it

hg: openjfx/8u-dev/rt: RT-37821 ConcurrentModificationException if an attempt is made to remove an accelerator whilst an accelerator callback is being processed

2014-07-15 Thread martin . sladecek
Changeset: 982a483303a5 Author:Martin Sladecek Date: 2014-07-15 13:02 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/982a483303a5 RT-37821 ConcurrentModificationException if an attempt is made to remove an accelerator whilst an accelerator callback is being processed

hg: openjfx/8u-dev/rt: RT-37994 [FXML] ProxyBuilder does not support read-only collections

2014-07-21 Thread martin . sladecek
Changeset: 23c345e7ea20 Author:Martin Sladecek Date: 2014-07-22 07:30 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/23c345e7ea20 RT-37994 [FXML] ProxyBuilder does not support read-only collections ! modules/fxml/src/main/java/com/sun/javafx/fxml/builder

hg: openjfx/8u-dev/rt: RT-35126 [Animation] Combinations of transitions don't work as expected (circle should fade in)

2014-07-23 Thread martin . sladecek
Changeset: e248baa75433 Author:Martin Sladecek Date: 2014-07-23 15:47 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e248baa75433 RT-35126 [Animation] Combinations of transitions don't work as expected (circle should fade in) ! modules/graphics/src/main/java/j

hg: openjfx/8u-dev/rt: RT-37923 [TableView] TableColumns are not garbage collected

2014-07-23 Thread martin . sladecek
Changeset: a55da2de478e Author:Martin Sladecek Date: 2014-07-24 08:45 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a55da2de478e RT-37923 [TableView] TableColumns are not garbage collected Reviewed by: jgiles ! modules/controls/src/main/java/com/sun/javafx/scene

hg: openjfx/8u-dev/rt: RT-37961 [ScrollPane] Connecting a ScrollPane to a scenegraph reset hvalue / vvalue (cont'd)

2014-07-23 Thread martin . sladecek
Changeset: 21ac79f2feca Author:Martin Sladecek Date: 2014-07-24 08:48 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/21ac79f2feca RT-37961 [ScrollPane] Connecting a ScrollPane to a scenegraph reset hvalue / vvalue (cont'd) Reviewed by: jgiles ! modules/control

Re: Skin layoutChildren: when to get bounds of child nodes?

2014-07-27 Thread Martin Sladecek
The super.layoutChildren should size every child of the control (which is VBox), but not child's children. The control must finish the layout before children can do theirs. If you need to do layout on some child before that, you can call .layout() on it. It will do it's layout using it's curren

hg: openjfx/8u-dev/rt: RT-38076

2014-07-29 Thread martin . sladecek
Changeset: 86ffa7810b12 Author:Martin Sladecek Date: 2014-07-29 15:13 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/86ffa7810b12 RT-38076 Map- and SetExpression invalidation listeners cause eventual NPEs when removing themselves ! modules/base/src/main/java/com/sun

Re: Skin layoutChildren: when to get bounds of child nodes?

2014-07-29 Thread Martin Sladecek
for devs to know which methods are called for the pre-layout (size measuring) phase and them for the actual layout phase. Cheers, Mikael On 28 Jul 2014, at 07:38, Martin Sladecek wrote: The super.layoutChildren should size every child of the control (which is VBox), but not child's chi

hg: openjfx/8u-dev/rt: RT-37824 [Charts] Series: NPE when adding data items multiple times

2014-07-30 Thread martin . sladecek
Changeset: d515c3182f1c Author:Martin Sladecek Date: 2014-07-30 10:51 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d515c3182f1c RT-37824 [Charts] Series: NPE when adding data items multiple times Reviewed by: snorthov, jgiles ! modules/controls/src/main/java/javafx

Re: Skin layoutChildren: when to get bounds of child nodes?

2014-07-30 Thread Martin Sladecek
On 07/30/2014 05:12 PM, Werner Lehmann wrote: layoutChildren() { ... bip = child1.getBoundsInParent() if (bip.getMinX() == 0 && bip.getWidth() == 0) { vbox.layout(); bip = child1.getBoundsInParent(); } ... } I assume you don't change "child1" Nodes, so it should work. It sure

hg: openjfx/8u-dev/rt: RT-25980 Add Window setUserData and user data to other non-Node classes

2014-08-12 Thread martin . sladecek
Changeset: 7ec4725320d0 Author:Martin Sladecek Date: 2014-08-12 09:55 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/7ec4725320d0 RT-25980 Add Window setUserData and user data to other non-Node classes Reviewed by: kcr, snorthov Contributed by: tom.schi

hg: openjfx/8u-dev/rt: RT-33696 RTL orientation, submenu overlaps its parent menu.

2014-08-12 Thread martin . sladecek
Changeset: 42903ea10084 Author:Martin Sladecek Date: 2014-08-12 10:00 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/42903ea10084 RT-33696 RTL orientation, submenu overlaps its parent menu. Reviewed by: snorthov, kcr ! modules/controls/src/main/java/javafx/scene

hg: openjfx/8u-dev/rt: RT-37798 [Charts] Series: NPE when adding data items after deletion of data

2014-08-12 Thread martin . sladecek
Changeset: a7f7ec1bc33f Author:Martin Sladecek Date: 2014-08-12 10:04 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a7f7ec1bc33f RT-37798 [Charts] Series: NPE when adding data items after deletion of data Reviewed by: jgiles ! modules/controls/src/main/java/javafx

hg: openjfx/8u-dev/rt: RT-38238 unmodifiableObservableMap.entrySet() provides entries in wrong order

2014-08-12 Thread martin . sladecek
Changeset: 2326aecdf8b0 Author:Martin Sladecek Date: 2014-08-12 12:39 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2326aecdf8b0 RT-38238 unmodifiableObservableMap.entrySet() provides entries in wrong order ! modules/base/src/main/java/com/sun/javafx/collections

hg: openjfx/8u-dev/rt: RT-38273 FormatStringConverter should convert only full Strings

2014-08-13 Thread martin . sladecek
Changeset: 6f16716706c3 Author:Martin Sladecek Date: 2014-08-13 10:26 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6f16716706c3 RT-38273 FormatStringConverter should convert only full Strings ! modules/base/src/main/java/javafx/util/converter

hg: openjfx/8u-dev/rt: Reverted unrelated test comitted with RT-38723 fix

2014-08-13 Thread martin . sladecek
Changeset: d92ede143b5e Author:Martin Sladecek Date: 2014-08-13 10:29 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d92ede143b5e Reverted unrelated test comitted with RT-38723 fix ! modules/base/src/test/java/javafx/util/converter/FloatStringConverterTest.java

hg: openjfx/8u-dev/rt: RT-14000 Add Formatted TextField control

2014-08-14 Thread martin . sladecek
Changeset: 290274db83f7 Author:Martin Sladecek Date: 2014-08-15 07:57 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/290274db83f7 RT-14000 Add Formatted TextField control Reviewed by: kcr, snorthov ! modules/controls/src/main/java/com/sun/javafx/scene/control

hg: openjfx/8u-dev/rt: RT-14000 Add Formatted TextField control (cont.) : 2 missing classes

2014-08-14 Thread martin . sladecek
Changeset: 13f33b110a99 Author:Martin Sladecek Date: 2014-08-15 07:58 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/13f33b110a99 RT-14000 Add Formatted TextField control (cont.) : 2 missing classes + modules/controls/src/main/java/com/sun/javafx/scene/control

hg: openjfx/8u-dev/rt: RT-38221 [LineChart] Javafx 8 Line Chart does not plot data in order

2014-08-18 Thread martin . sladecek
Changeset: 14219b05f178 Author:Martin Sladecek Date: 2014-08-18 10:03 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/14219b05f178 RT-38221 [LineChart] Javafx 8 Line Chart does not plot data in order Reviewed by: snothov, kcr ! modules/controls/src/main/java/javafx

hg: openjfx/8u-dev/rt: [TOYS] Hello : HelloTextFieldWithTextFormatter

2014-08-18 Thread martin . sladecek
Changeset: 0fdd457a9e04 Author:Martin Sladecek Date: 2014-08-18 14:25 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0fdd457a9e04 [TOYS] Hello : HelloTextFieldWithTextFormatter + apps/toys/Hello/src/main/java/hello/HelloTextFieldWithTextFormatter.java

hg: openjfx/8u-dev/rt: RT-38344 [Ensemble] Add TextField with formatter sample to Ensemble

2014-08-18 Thread martin . sladecek
Changeset: b5b649ef6d8d Author:Martin Sladecek Date: 2014-08-19 08:36 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b5b649ef6d8d RT-38344 [Ensemble] Add TextField with formatter sample to Ensemble Reviewed by: kselle ! apps/samples/Ensemble8/src/generated/java

hg: openjfx/8u-dev/rt: RT-38278 [ScrollPane] minViewport{Height, Width} are taking effect only after changing prefViewport{Height, Width}

2014-08-18 Thread martin . sladecek
Changeset: 36a242b77366 Author:Martin Sladecek Date: 2014-08-19 08:37 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/36a242b77366 RT-38278 [ScrollPane] minViewport{Height,Width} are taking effect only after changing prefViewport{Height,Width} Reviewed by: jgiles

[API] RT-37785 Provide some useful TextInputControl.Formatter implementations

2014-08-19 Thread Martin Sladecek
Hello, as RT-14000 (https://javafx-jira.kenai.com/browse/RT-14000) - text formatter for TextInputControl has been pushed recently, it's time to discuss what implementations of Text Formatter should be included in 8u40 release. I added some ideas to (https://javafx-jira.kenai.com/browse/RT-377

hg: openjfx/8u-dev/rt: RT-38130 A node remains invisible if clip has been set while it was not visible

2014-08-19 Thread martin . sladecek
Changeset: 83f2a3753ad6 Author:Martin Sladecek Date: 2014-08-19 14:40 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/83f2a3753ad6 RT-38130 A node remains invisible if clip has been set while it was not visible ! modules/graphics/src/main/java/javafx/scene/Node.java

hg: openjfx/8u-dev/rt: RT-36453 [ColorPicker, Modena] Colorpicker changes size depending on the currently selected color

2014-08-20 Thread martin . sladecek
Changeset: 029bcb15c1e5 Author:Martin Sladecek Date: 2014-08-20 15:00 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/029bcb15c1e5 RT-36453 [ColorPicker, Modena] Colorpicker changes size depending on the currently selected color Reviewed by: jgiles ! modules

hg: openjfx/8u-dev/rt: RT-38285 [Axis] Y-Axis can not handle big values

2014-08-20 Thread martin . sladecek
Changeset: 9130fc16c129 Author:Martin Sladecek Date: 2014-08-20 15:03 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/9130fc16c129 RT-38285 [Axis] Y-Axis can not handle big values Reviewed by: jgiles ! modules/controls/src/main/java/javafx/scene/chart/NumberAxis.java

hg: openjfx/8u-dev/rt: RT-38285 [Axis] Y-Axis can not handle big values (cont.): follow-up fix

2014-08-20 Thread martin . sladecek
Changeset: adba413b52d3 Author:Martin Sladecek Date: 2014-08-20 15:21 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/adba413b52d3 RT-38285 [Axis] Y-Axis can not handle big values (cont.): follow-up fix ! modules/controls/src/main/java/javafx/scene/chart

hg: openjfx/8u-dev/rt: RT-38285 [Axis] Y-Axis can not handle big values (cont.): follow-up fix

2014-08-20 Thread martin . sladecek
Changeset: 798a93a61616 Author:Martin Sladecek Date: 2014-08-20 15:53 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/798a93a61616 RT-38285 [Axis] Y-Axis can not handle big values (cont.): follow-up fix ! modules/controls/src/main/java/javafx/scene/chart

hg: openjfx/8u-dev/rt: Incorrect method reference fix

2014-08-21 Thread martin . sladecek
Changeset: 59e71e06a1c6 Author:Martin Sladecek Date: 2014-08-21 14:34 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/59e71e06a1c6 Incorrect method reference fix ! modules/base/src/main/java/javafx/collections/transformation/SortedList.java

hg: openjfx/8u-dev/rt: RT-38329 [LineChart] Calling setForceZeroInRange doesn't update LineChart

2014-08-22 Thread martin . sladecek
Changeset: 191aab1d374d Author:Martin Sladecek Date: 2014-08-22 10:12 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/191aab1d374d RT-38329 [LineChart] Calling setForceZeroInRange doesn't update LineChart Reviewed by: jgiles ! modules/controls/src/main/java/j

hg: openjfx/8u-dev/rt: RT-38189 CategoryAxis.tickLabelRotation doesn't work properly with autoRanging

2014-08-22 Thread martin . sladecek
Changeset: 4c2f04e9e358 Author:Martin Sladecek Date: 2014-08-22 10:15 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4c2f04e9e358 RT-38189 CategoryAxis.tickLabelRotation doesn't work properly with autoRanging Reviewed by: jgiles ! modules/controls/src/main

hg: openjfx/8u-dev/rt: RT-38297 Region is not properly clipped when defined by a shape

2014-08-22 Thread martin . sladecek
Changeset: ba193bd5c30a Author:Martin Sladecek Date: 2014-08-22 10:17 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ba193bd5c30a RT-38297 Region is not properly clipped when defined by a shape Reviewed by: flar ! modules/graphics/src/main/java/com/sun/javafx/sg

hg: openjfx/8u-dev/rt: RT-37855 Providing Node.localToWindow()

2014-08-22 Thread martin . sladecek
Changeset: bcd1f1059cc2 Author:Martin Sladecek Date: 2014-08-22 10:25 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bcd1f1059cc2 RT-37855 Providing Node.localToWindow() Reviewed by: kcr ! modules/graphics/src/main/java/javafx/scene/Node.java

hg: openjfx/8u-dev/rt: RT-38388 [javadoc] Bad HTML in JavaBeanProperty and ReadOnlyJavaBeanProperty classes

2014-08-22 Thread martin . sladecek
Changeset: 7d6c721cfd7f Author:Martin Sladecek Date: 2014-08-22 11:12 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/7d6c721cfd7f RT-38388 [javadoc] Bad HTML in JavaBeanProperty and ReadOnlyJavaBeanProperty classes ! modules/base/src/main/java/javafx/beans/property

Re: NumberAxis alignment of ticks to multiples of tickUnit

2014-08-22 Thread Martin Sladecek
On 08/20/2014 08:38 AM, Adam Granger wrote: So my question to the group is, would you consider including this functionality in the main NumberAxis class? - obviously making it configurable and defaulting to current behaviour. Adam, please file a JIRA issue for that (https://javafx-jira.kenai.co

API review: RT-38292,[SortedList] should provide a sort() method

2014-08-25 Thread Martin Sladecek
Hello, based on the request in the JIRA, I propose to add SortedList.sort() and FilteredList.filter() methods that trigger the sorting or filtering operation in case the data on the last sort were outdated and it is not possible to use FXCollections.observableList(List, Callback) wrapper for so

hg: openjfx/8u-dev/rt: RT-37329 [SplitPane] Cannot set divider position in multiple splitpanes at once on button setOnAction()

2014-08-26 Thread martin . sladecek
Changeset: 0e57456b1327 Author:Martin Sladecek Date: 2014-08-26 11:04 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0e57456b1327 RT-37329 [SplitPane] Cannot set divider position in multiple splitpanes at once on button setOnAction() Reviewed by: jgiles ! modules

hg: openjfx/8u-dev/rt: RT-38165 "A bound value cannot be set" exception should print the name of the property that is causing the problem

2014-08-26 Thread martin . sladecek
Changeset: 44cac66ba3ed Author:Martin Sladecek Date: 2014-08-26 14:23 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/44cac66ba3ed RT-38165 "A bound value cannot be set" exception should print the name of the property that is causing the problem ! module

Re: GridPane percent width.

2014-08-28 Thread Martin Sladecek
Robert, with odd numbers, the space might be distributed unevenly (by a pixel), this is due to snapToPixel property of the GridPane. Setting it to false might lead to even distribution, but the border might be blurred. Anyway, if you are not sure if it is a bug, I would suggest you file a JIRA

hg: openjfx/8u-dev/rt: RT-38408 RTL orientation, ChoiceBox popup is not aligned with the ChoiceBox.

2014-09-01 Thread martin . sladecek
Changeset: 31335892f770 Author:Martin Sladecek Date: 2014-09-01 11:03 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/31335892f770 RT-38408 RTL orientation, ChoiceBox popup is not aligned with the ChoiceBox. ! modules/graphics/src/main/java/com/sun/javafx/Utils.java

hg: openjfx/8u-dev/rt: RT-38465 [SplitPane] Pixels cut off when GridPane inside SplitPane

2014-09-01 Thread martin . sladecek
Changeset: 481f8d61b1cd Author:Martin Sladecek Date: 2014-09-01 15:23 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/481f8d61b1cd RT-38465 [SplitPane] Pixels cut off when GridPane inside SplitPane ! modules/graphics/src/main/java/javafx/scene/layout/GridPane.java

hg: openjfx/8u-dev/rt: RT-38407 RTL orientation, ComboBox popup is not aligned with the ComboBox.

2014-09-03 Thread martin . sladecek
Changeset: 77ee61dc5811 Author:Martin Sladecek Date: 2014-09-03 09:21 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/77ee61dc5811 RT-38407 RTL orientation, ComboBox popup is not aligned with the ComboBox. Reviewed by: jgiles ! modules/controls/src/main/java/com/sun

hg: openjfx/8u-dev/rt: RT-37879 ArrayindexoutOfBoundsException from Parent.updateCachedBounds

2014-09-03 Thread martin . sladecek
Changeset: eb251121a360 Author:Martin Sladecek Date: 2014-09-03 14:55 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/eb251121a360 RT-37879 ArrayindexoutOfBoundsException from Parent.updateCachedBounds ! modules/graphics/src/main/java/javafx/scene/Parent.java

hg: openjfx/8u-dev/rt: RT-38288 [DatePicker] Does not change to new selected value if modal window is shown in DatePicker-action

2014-09-08 Thread martin . sladecek
Changeset: 965623d2f60c Author:Martin Sladecek Date: 2014-09-09 08:38 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/965623d2f60c RT-38288 [DatePicker] Does not change to new selected value if modal window is shown in DatePicker-action Reviewed by: jgiles ! modules

hg: openjfx/8u-dev/rt: RT-38448 [TextArea] Text scrolled and initial position of scrollbar moved from top (8u20) to bottom (8u40)

2014-09-09 Thread martin . sladecek
Changeset: 0332535f0cb2 Author:Martin Sladecek Date: 2014-09-09 09:01 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0332535f0cb2 RT-38448 [TextArea] Text scrolled and initial position of scrollbar moved from top (8u20) to bottom (8u40) Reviewed by: jgiles ! modules

hg: openjfx/8u-dev/rt: RT-38490 [TabPane] The tab disappeared after the index changed

2014-09-09 Thread martin . sladecek
Changeset: ac98aaa7adc6 Author:Martin Sladecek Date: 2014-09-09 09:03 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ac98aaa7adc6 RT-38490 [TabPane] The tab disappeared after the index changed Reviewed by: jgiles ! modules/controls/src/main/java/com/sun/javafx/scene

hg: openjfx/8u-dev/rt: RT-38507 [Regression] Animation in Progress Bar is out of place

2014-09-09 Thread martin . sladecek
Changeset: 556c2af030c1 Author:Martin Sladecek Date: 2014-09-09 09:05 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/556c2af030c1 RT-38507 [Regression] Animation in Progress Bar is out of place Reviewed by: jgiles ! modules/controls/src/main/java/com/sun/javafx

hg: openjfx/8u-dev/rt: RT-37715 [Chart] HelloStackedAreaChart has a missing symbol

2014-09-09 Thread martin . sladecek
Changeset: d94bd6d65452 Author:Martin Sladecek Date: 2014-09-09 09:06 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d94bd6d65452 RT-37715 [Chart] HelloStackedAreaChart has a missing symbol Reviewed by: jgiles ! modules/controls/src/main/java/javafx/scene/chart

hg: openjfx/8u-dev/rt: RT-38458 [Charts] Strange for loop in javafx.scence.chart.Axis

2014-09-09 Thread martin . sladecek
Changeset: f5a981fe054b Author:Martin Sladecek Date: 2014-09-09 09:07 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f5a981fe054b RT-38458 [Charts] Strange for loop in javafx.scence.chart.Axis Reviewed by: jgiles ! modules/controls/src/main/java/javafx/scene/chart

hg: openjfx/8u-dev/rt: TabPaneSkin: reverted accidental change in imports (from c98aaa7adc6)

2014-09-09 Thread martin . sladecek
Changeset: 0f7bad358c85 Author:Martin Sladecek Date: 2014-09-09 15:57 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0f7bad358c85 TabPaneSkin: reverted accidental change in imports (from c98aaa7adc6) ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin

[8u40] Review Request: RT-38582 [Transform] transform(Bounds) and inverseTransform(Bounds) produce incorrect results

2014-09-10 Thread Martin Sladecek
Hi Jim, Kevin, please review https://javafx-jira.kenai.com/browse/RT-38582 http://cr.openjdk.java.net/~msladecek/rt-38582/webrev.00/ Thanks, -Martin

hg: openjfx/8u-dev/rt: RT-38458 [Charts, Axis] TickMark's textVisible property is ignored

2014-09-12 Thread martin . sladecek
Changeset: 522fe51196c8 Author:Martin Sladecek Date: 2014-09-12 09:20 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/522fe51196c8 RT-38458 [Charts, Axis] TickMark's textVisible property is ignored follow-up fix Reviewed by: jgiles, kcr ! modules/controls/src

hg: openjfx/8u-dev/rt: RT-38582 [Transform] transform(Bounds) and inverseTransform(Bounds) produce incorrect results

2014-09-12 Thread martin . sladecek
Changeset: 726b5622b633 Author:Martin Sladecek Date: 2014-09-12 09:34 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/726b5622b633 RT-38582 [Transform] transform(Bounds) and inverseTransform(Bounds) produce incorrect results Reviewed by: kcr, flar + modules/graphics

Re: Does JavaFX lack a public Property.getObservable() method?

2014-09-12 Thread Martin Sladecek
Hi Randahl, why don't you use bidirectional binding for this purpose? -Martin On 09/12/2014 01:04 PM, Randahl Fink Isaksen wrote: I have noticed the lack of a getObservable() method of the property class, and I have come across a use case which might justify such a method, so I would like to

hg: openjfx/8u-dev/rt: [ComboBox] Popup does not respond to visibleRowCountProperty after it was shown for the first time

2014-09-15 Thread martin . sladecek
Changeset: 3d4cd94afd1c Author:Martin Sladecek Date: 2014-09-16 08:26 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/3d4cd94afd1c [ComboBox] Popup does not respond to visibleRowCountProperty after it was shown for the first time Reviewed by: jgiles, snorthov

hg: openjfx/8u-dev/rt: RT-38656 BorderStroke constructor doesn't respect widths

2014-09-15 Thread martin . sladecek
Changeset: 97e4b6fa0e98 Author:Martin Sladecek Date: 2014-09-16 08:45 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/97e4b6fa0e98 RT-38656 BorderStroke constructor doesn't respect widths ! modules/graphics/src/main/java/javafx/scene/layout/BorderStroke.java

hg: openjfx/8u-dev/rt: RT-38654 A ListView control's items do not refresh when placed inside a SubScene node.

2014-09-16 Thread martin . sladecek
Changeset: 787e23c568a5 Author:Martin Sladecek Date: 2014-09-16 09:57 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/787e23c568a5 RT-38654 A ListView control's items do not refresh when placed inside a SubScene node. ! modules/graphics/src/main/java/javafx/

hg: openjfx/8u-dev/rt: RT-38418 Dashed border with width is broken

2014-09-17 Thread martin . sladecek
Changeset: f73646deab84 Author:Martin Sladecek Date: 2014-09-17 09:31 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f73646deab84 RT-38418 Dashed border with width is broken RT-38493 [Region] After RT-38297, rectangular Region borders are drawn incorrectly Reviewed

hg: openjfx/8u-dev/rt: RT-38667 [SpltPane] Cannot set divider position in multiple splitpanes at once under certain conditions

2014-09-17 Thread martin . sladecek
Changeset: 26b2ed1d5d5b Author:Martin Sladecek Date: 2014-09-17 09:43 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/26b2ed1d5d5b RT-38667 [SpltPane] Cannot set divider position in multiple splitpanes at once under certain conditions Reviewed by: jgiles ! modules

hg: openjfx/8u-dev/rt: Follow-up fix for RT-38418 - copy paste error when splitting the line length.

2014-09-17 Thread martin . sladecek
Changeset: 27e5fd37a940 Author:Martin Sladecek Date: 2014-09-18 08:30 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/27e5fd37a940 Follow-up fix for RT-38418 - copy paste error when splitting the line length. ! modules/graphics/src/main/java/com/sun/javafx/sg/prism

Re: Focus Traversal Engine

2014-11-25 Thread Martin Sladecek
Hi Alex, unfortunately, there's none. The simplest way would be to use ParentTraversalEngine with the risk that you will have to update the code once (and if) the traversal engine goes public. You can never get the 100% correct traversal with event filters as the first node that will be trave

Re: Understanding Layout

2014-12-19 Thread Martin Sladecek
Hi Scott, On 18.12.2014 22:49, Scott Palmer wrote: Short Version: Is there good documentation on how JavaFX performs layout? (Not specific layouts, but layout in general.) Not an official documentation I'm afraid (at least I don't know of any), just the javadoc and a few blog posts: Amy Fowler

Re: Focus Traversal API for JDK 9

2015-10-01 Thread Martin Sladecek
Hi Jonathan, just a few thoughts about the API. When I was adding some of the functionality to traversal, I could not touch the public API. All we had there was the impl_ method for adding TraversalEngine. This means there is some functionality that IMO should have been directly in the scenegr

Re: [API REVIEW] RT-30576 Parent : add new public layout method, optimized to only layout this parent and it's children.

2013-05-22 Thread Martin Sladecek
Hi Mick, I would like to introduce similar call, see https://javafx-jira.kenai.com/browse/RT-30363 I called it requestParentLayout. There's an implementation in the attached diff : https://javafx-jira.kenai.com/secure/attachment/37081/rt-30363.diff Regards, -Martin On 05/22/2013 04:18 PM, mi

<    1   2