[8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
Hi all, I would like to start discussion about an addition to API in Observable, ObservableValue and all Observable collections. There were multiple requests for a way how to avoid duplicates in listeners lists. The way RT-25613 solves this is that it introduces public boolean

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Randahl Fink Isaksen
Hi Martin While I agree your proposed solution would work, I still don’t understand why JavaFX should keep on supporting duplicates in listener collections. Can anyone come up with just 1 example of an application that might be depending on having two listeners on the same Observable? E.g.

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
The reason why this was decided this way is simple : performance. You usually don't (try to) add a listener twice, so in most cases it doesn't make sense to check for duplicates every time a listener is added. So we currently leave the burden of avoiding duplicates on the developer. -Martin

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Tom Schindl
On 22.01.14 11:07, Martin Sladecek wrote: Hi all, I would like to start discussion about an addition to API in Observable, ObservableValue and all Observable collections. There were multiple requests for a way how to avoid duplicates in listeners lists. The way RT-25613 solves this is that it

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Randahl Fink Isaksen
Hi Martin Then I respectfully disagree with this design decision. In my point of view, choosing performance over ease of use is rarely a good idea. Here, the performance choice has put us in a situation where no one knows how many JavaFX apps have duplicate listener bugs, and such bugs can be

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
On 01/22/2014 11:27 AM, Tom Schindl wrote: On 22.01.14 11:07, Martin Sladecek wrote: Hi all, I would like to start discussion about an addition to API in Observable, ObservableValue and all Observable collections. There were multiple requests for a way how to avoid duplicates in listeners

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
On 01/22/2014 11:38 AM, Randahl Fink Isaksen wrote: Hi Martin Then I respectfully disagree with this design decision. In my point of view, choosing performance over ease of use is rarely a good idea. Here, the performance choice has put us in a situation where no one knows how many JavaFX

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Richard Bair
The default implementation (for Observable) would look like this: public default void ensureListener(InvalidationListener listener) { removeListener(listener); addListener(listener); } subclasses might do something more effective. The same would apply to ObservableValue and

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Randahl Fink Isaksen
I respect your point of view. Thank you for a thorough response. Randahl On 22 Jan 2014, at 12:18, Martin Sladecek martin.slade...@oracle.com wrote: On 01/22/2014 11:38 AM, Randahl Fink Isaksen wrote: Hi Martin Then I respectfully disagree with this design decision. In my point of view,

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Tomas Mikula
On Wed, Jan 22, 2014 at 11:27 AM, Tom Schindl tom.schi...@bestsolution.atwrote: On 22.01.14 11:07, Martin Sladecek wrote: Hi all, I would like to start discussion about an addition to API in Observable, ObservableValue and all Observable collections. There were multiple requests for a

Re: Monocle with VNC for Jenkins [was: Re: openjfx/8u-dev/rt: RT-35441 [Monocle] Provide a VNC back-end]

2014-01-22 Thread Uwe Sander
Hi, I'm interested in headless testing, too. I tried to use StubToolkit for including TestFX tests in a headless build, but all I got was a CNFE. If anyone is interested to give me a hand on this, details can be found at

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Tomas Mikula
Hi Randahl, I'm curious about an example where you would take advantage of the behavior where multiple addListener(listener) calls add the listener just once. Anyway, here [1] are helper classes InvalidationSubscriber and ChangeSubscriber that allow you to do that: InvalidationSubscriber

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Martin Sladecek
On 01/22/2014 12:30 PM, Richard Bair wrote: The default implementation (for Observable) would look like this: public default void ensureListener(InvalidationListener listener) { removeListener(listener); addListener(listener); } subclasses might do something more effective. The same

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Tom Schindl
[...] Actually even when you would rely on the order, in situations when you call ensureListener, you don't really know if the listener is already there. So you might really expect that listener would be added at this point as the last. It's just that will always be the outcome if the

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Randahl Fink Isaksen
Hi Tomas Great idea! I can see how the InvalidationSubscriber idea would work – but it is just a concept right? There is no official API for this, right? Randahl On 22 Jan 2014, at 13:34, Tomas Mikula tomas.mik...@gmail.com wrote: Hi Randahl, I'm curious about an example where you

Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method

2014-01-22 Thread Ali Ebrahimi
I suggest adding another overload for addListener method taking boolean parameter duplicateAllowed or duplicateNotAllowed. On Wed, Jan 22, 2014 at 3:00 PM, Richard Bair richard.b...@oracle.comwrote: The default implementation (for Observable) would look like this: public default void

[8u] Review Request: RT-35462,A controller with private fields gets broken when it's subclass is used as a fxml controller

2014-01-22 Thread Martin Sladecek
Hi David, please review: http://cr.openjdk.java.net/~msladecek/rt-35462/webrev https://javafx-jira.kenai.com/browse/RT-35462 Thanks, -Martin

Re: Monocle with VNC for Jenkins [was: Re: openjfx/8u-dev/rt: RT-35441 [Monocle] Provide a VNC back-end]

2014-01-22 Thread Daniel Blaukopf
Hi Tom, You have it right. Currently the VNC server is always running on port 5901, but feel free to open a JIRA to change that. If you want to test this today you need to build OpenJFX yourself (https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX). We don’t have snapshots of 8u20

Re: Monocle with VNC for Jenkins [was: Re: openjfx/8u-dev/rt: RT-35441 [Monocle] Provide a VNC back-end]

2014-01-22 Thread Daniel Blaukopf
Hi Uwe, On Jan 22, 2014, at 2:19 PM, Uwe Sander usan...@tesis.de wrote: Hi, I'm interested in headless testing, too. I tried to use StubToolkit for including TestFX tests in a headless build, but all I got was a CNFE. If anyone is interested to give me a hand on this, details can be

Re: Monocle with VNC [was: Re: openjfx/8u-dev/rt: RT-35441 [Monocle] Provide a VNC back-end]

2014-01-22 Thread Daniel Blaukopf
Thanks John! I agree that in an IoT environment where you can have many devices, a central gateway and a fast local network, a solution based on remote display could work well. Daniel On Jan 22, 2014, at 1:07 AM, John Smith john_sm...@symantec.com wrote: Monocle is a very interesting and

hg: openjfx/8u-dev/rt: RT-35443 Provide a headless glass implementation integrated with our JUnit tests

2014-01-22 Thread hang . vo
Changeset: aa08f837ac40 Author:Daniel Blaukopf daniel.blauk...@oracle.com Date: 2014-01-22 15:49 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/aa08f837ac40 RT-35443 Provide a headless glass implementation integrated with our JUnit tests Reviewed-by: snortho, anthony

Re: Monocle with VNC for Jenkins

2014-01-22 Thread Uwe Sander
Thanks for your answer, Daniel. If there's still a use case for StubToolkit, I'd like to know why I get a CNFE when I'm trying to use it in a simple JavaFX application (see the link in my previous message). Has anyone succeeded in building and using it (outside Oracle)? Cheers, Uwe Daniel

Move to JIRA [was: Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method]

2014-01-22 Thread Daniel Blaukopf
Hi Martin, Randahl, Tom, Richard, Tomas and Ali, This is a productive discussion, but once we get to this level of detail JIRA is the place to have it, so that we don’t lose our record of it. Would you continue the discussion on https://javafx-jira.kenai.com/browse/RT-25613 ? See

hg: openjfx/8u-dev/rt: Initial push for RT-35243 - prism should use Monocle's platform detection code. Creates a new prism es2 port (prism-es-monocle) which uses the monocle port of glass. Note that i

2014-01-22 Thread hang . vo
Changeset: 2e23e1f2b922 Author:lisa.se...@oracle.com Date: 2014-01-22 13:04 -0500 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2e23e1f2b922 Initial push for RT-35243 - prism should use Monocle's platform detection code. Creates a new prism es2 port (prism-es-monocle)

hg: openjfx/8u-dev/rt: RT-35487: build files should use IS_COMPILE_PANGO (instead of COMPILE_PANGO)

2014-01-22 Thread hang . vo
Changeset: f7e4bebcf795 Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2014-01-22 07:49 -0800 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f7e4bebcf795 RT-35487: build files should use IS_COMPILE_PANGO (instead of COMPILE_PANGO) ! buildSrc/armv6hf.gradle !

hg: openjfx/8u-dev/rt: Fix RT-33294: Canas PixelWriter can be very slow

2014-01-22 Thread hang . vo
Changeset: 3943d4344924 Author:flar james.gra...@oracle.com Date: 2014-01-22 13:39 -0800 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/3943d4344924 Fix RT-33294: Canas PixelWriter can be very slow Reviewed by Felipe and Chien !

Re: Move to JIRA [was: Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method]

2014-01-22 Thread John Hendrikx
Unfortunately, discussing things in JIRA works very poorly and is a good way to end a productive discussion IMHO. Mailinglists are much better suited to the task, as thousands of interesting mailinglists accross many developer communities will atest to. Keeping a record is good, aren't these

Re: Move to JIRA [was: Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method]

2014-01-22 Thread Jonathan Giles
The point is that we'd rather have quick reference to the historical discussion without having to cross-reference between jira and the mailing list archives (which isn't automatically done). Once you add yourself as a watcher to the jira issue you are notified of every change, in much the same way

Re: Move to JIRA [was: Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method]

2014-01-22 Thread Stephen F Northover
Hi John, The goal is not to end the discussion! It's a trade off. Mailing lists are good because they provide a threaded discussion. JIRA is bad because it is not threaded. JIRA has the advantage that it captures data in a single place and provides a good history of why a decision was

hg: openjfx/8u-dev/rt: RT-35141: [TableView] TableView Column Reordering sometimes fails and often doesn't match the visual feedback

2014-01-22 Thread hang . vo
Changeset: a46ffa89a080 Author:jgiles Date: 2014-01-23 12:54 +1300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a46ffa89a080 RT-35141: [TableView] TableView Column Reordering sometimes fails and often doesn't match the visual feedback !