On Thu, 12 Dec 2019 21:41:12 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1883:
>
>> 1882: }
>> 1883: @Override protected void
On Thu, 12 Dec 2019 21:29:06 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1450:
>
>> 1449: private static final CssMetaData TAB_SIZE =
>> 1450: new
On Thu, 12 Dec 2019 22:02:53 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1273:
>>
>>> 1272: /**
>>> 1273: * The size of a tab stop in spaces.
>>> 1274: * Values less than 1 are treated as 1.
>>
>> "tab stop" seems to be an
On Thu, 12 Dec 2019 22:02:14 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line
> 494:
>
>> 493: * Values less than 1 are treated as 1. This value overrides the
>> 494:
On Fri, 13 Dec 2019 01:29:47 GMT, Phil Race wrote:
>> The terms "tab character" or "horizontal tab" refer to the ASCII tab
>> character itself. Since a tab character isn't a fixed number of spaces,
>> changing it to "size of a tab character" could be misleading. I'd be fine
>> with another
On Wed, 11 Dec 2019 17:10:37 GMT, Ambarish Rapte wrote:
>> The change looks OK as far as it goes, meaning that it will fix the specific
>> NPE reported by the bug and is looks like a safe fix.
>>
>> Two questions:
>>
>> 1. In addition to calling the synchronized `setTKScenePaintListener`
On Thu, 12 Dec 2019 21:40:34 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1882:
>
>> 1881: return StyleableProperties.TAB_SIZE;
>> 1882:
On Mon, 9 Dec 2019 18:27:25 GMT, Thiago Milczarek Sayao
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8232811
>
> This one was hard to tackle.
>
> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
This will
> https://bugs.openjdk.java.net/browse/JDK-8225571
>
> To run tests (on the root of the source tree):
> ./gradlew apps
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
> dragdrop.DragDropWithControls
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
>
On Thu, 12 Dec 2019 15:15:38 GMT, Scott Palmer wrote:
>> I think a new `TextFlowTest.java` would be a good place for those tests.
>>
>> Our build is set up to use `ant` so if you want to wire it up to the build,
>> you'll need that (it should be as simple as having `ANT_HOME` set to
>>
On Thu, 12 Dec 2019 15:52:23 GMT, Kevin Rushforth wrote:
>> Good catch. Yes, please update it as you suggested.
>
> The following comment from @swpalmer sent to the openjfx-dev mailing list
> wasn't mirrored in the PR (I have alerted the Skara team about this).
>
>
> From: Scott Palmer
>
On Thu, 12 Dec 2019 15:19:39 GMT, Kevin Rushforth wrote:
>> I just noticed while updating the CSR that, while I mentioned it on the
>> mailing list, the fact that TextFlow's tabSize override that of any
>> contained Text nodes is not documented.
>> Shall I add to the javadoc for tabSize in
On Wed, 11 Dec 2019 01:22:54 GMT, Kevin Rushforth wrote:
>> The unit tests that were already added to `TextTest.java` cover the new
>> methods on Text, but not in every combination. I'll add a couple more to
>> ensure all combinations are covered. `TextFlow` has no existing unit tests
>>
On Wed, 11 Dec 2019 19:05:54 GMT, Thiago Milczarek Sayao
wrote:
>> With your latest patch, which reverts the changes to `GtkDnDClipboard.java`,
>> I now get the DRAG_DONE event, but the following warning printed to the
>> console in the case of a `DRAG_DONE` event with a null transfer mode:
On Thu, 12 Dec 2019 19:48:37 GMT, Scott Palmer wrote:
>> In that case, I recommend just doing the API get/set tests for `TextFlow`
>> without creating a `Scene` or `Stage`. This won't need anything from the
>> `StubToolkit`.
>
> In my attempts to address the issue with StubTextLayout I
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
> both. TextFlow's tab size overrides that of contained Text nodes.
The pull request has been updated with 1 additional commit.
-
Added commits:
- f99a3aa9: 8130738: Add tabSize property to Text and
On Thu, 12 Dec 2019 21:52:05 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
On Thu, 12 Dec 2019 21:16:32 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1273:
>
>> 1272: /**
>> 1273: * The size of a tab stop in spaces.
>> 1274: * Values less
On Thu, 12 Dec 2019 22:02:27 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
19 matches
Mail list logo