Re: [API Review] RT-15314

Does "fullScreenWarning=false" imply also that the escape key would be free for normal use? Removing the overlay is definitely good, but for apps that always run full-screen they shouldn't react to escape either. --John On 29/05/2013 23:51, David Hill wrote: We have a request

Re: JavaFX graphics performance and suitability for advanced animations

On 1/06/2013 02:24, Daniel Zwolenski wrote: Can anyone recommend any good screen capture software for windows? Not sure it would capture this problem but it would be useful for some of the other problems I'm seeing in the TD game that I can't seem to reproduce in small snippets of code. I used ht

System.err printSummary (D3D Vram Pool) lines

Hi List, In b90 and b92 I'm getting these kinds of prints (often continously) when I'm using my application, and I'm not sure if I'm supposed to report them: @com.sun.prism.impl.ManagedResource.printSummary(ManagedResource.java:134) D3D Vram Pool: 96,767,731 used (36.0%), 96,767,731 managed

Usecase for needsLayout property?

I'm having a bit of a chicken-egg problem with regards to some dynamically sized components I'm displaying in my application. Description: I have a group with a title that wraps some content and displays a title above it -- the entire group, including the title must be hidden and unmanaged whe

Re: Usecase for needsLayout property?

ach it to a JIRA issue, so I can have a look what's actually happening there? Thanks, -Martin On 06/05/2013 11:29 AM, John Hendrikx wrote: I'm having a bit of a chicken-egg problem with regards to some dynamically sized components I'm displaying in my application. Description:

ObservableValue Stacktrace

Hi List, I'm getting some log messages sometimes (see at the end) about properties being null (whereas I didn't get them before in JavaFX 2.2). Is this intended as an informative message to the developer, something I should report, or just debug code for the JavaFX team? In this case, the b

Re: ObservableValue Stacktrace

valid state, so it always prints a warning on the stderr, for the developer to see something went wrong. Regards, -Martin On 5.6.2013 21:38, John Hendrikx wrote: Hi List, I'm getting some log messages sometimes (see at the end) about properties being null (whereas I didn't get th

Re: ObservableValue Stacktrace

Perhaps using the logging system would be a better choice in the case than printing to stderr? -- Kevin Martin Sladecek wrote: On 06/06/2013 10:53 AM, John Hendrikx wrote: Hm, ok -- it is correct that it doesn't fail, the code runs without any problem and everything works as expected. Bu

Docs for Binding lacking?

Hi List, I'm having a hard time to find good documentation on some aspects of bind and bindDirectional. I found several forum posts, some books and lots of examples, but none really touch upon the subject of references between bindings and garbage collection. Would it be possible to enhance

Overriding caspian.css -fx-background

So, I'm having huge problems trying to make a simple change to a control to give it a custom look. Something that used to look exactly right on JavaFX 2.2 is now (since say 6 months) being overriden by the standard css and I just cannot find any way to get rid of it. It seems to be related

Re: ConcurrentModificationException during controls test runs

I just got one too, but not related to any ComboBox in b98 as I don't use any ComboBoxes. Probably related to a TreeView control: java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(HashMap.java:2395) at java.util.HashMap$EntryIterator.next(HashMap.ja

Re: A different way to handle pulse timing

On 5/08/2013 20:46, Richard Bair wrote: As I wrote in the previous email, it seems that we currently are not blocked waiting for vsync(), at least on Windows with D3D pipeline. Anyway, even if we "fix" that, what you propose is that sometimes both threads will be blocked (the render thread wai

Re: Is Node.setClip() expected detect changes to the clip-Node?

I think I noticed something like this some time ago, but related to a TreeCell. I basically used the clip to make a graphic capable of filling up like a progress bar (there was a graphic that showed a standard non-filled display, and an overlayed graphic that showed the filled form, but was cl

Re: JavaFX Media issues

On 9/08/2013 02:10, Scott Palmer wrote: The Media APIs are mostly useless in their current state. Other than demoing that you can play a video, they don't go far enough to be of practical value. I tried to get someone to pay attention to them back in the JavaFX 1.0 days https://javafx-jira.kena

Re: JavaFX Media issues

On 9/08/2013 03:48, Scott Palmer wrote: I have heard rumors of people being able to play HD video via Canvas. I have tried everything and can't come close. (Yes, I have been careful about the pixel format.) I mean, it looks like it is working for a few seconds, but then as the memory fills wi

Re: Canvas blowing up (was Re: JavaFX Media issues)

On 9/08/2013 17:23, Richard Bair wrote: I mean, it looks like it is working for a few seconds, but then as the memory fills with the Canvas backlog it can lead to the GC using a lot more CPU, thus reducing the ability for Canvas to process its command queue even further, well it just collapses in

Re: Canvas blowing up (was Re: JavaFX Media issues)

On 9/08/2013 20:15, Richard Bair wrote: Also the proposed clear() or empty() option only applies to Canvas correct? i.e. WritableImages don't suffer from these kind of issues and don't require such methods? That is correct (WritableImage we don't provide a 2D API to use to fill the buffer, you

Re: Canvas blowing up (was Re: JavaFX Media issues)

On 10/08/2013 05:46, John Hendrikx wrote: On 9/08/2013 20:15, Richard Bair wrote: Also the proposed clear() or empty() option only applies to Canvas correct? i.e. WritableImages don't suffer from these kind of issues and don't require such methods? That is correct (WritableImag

Re: Canvas blowing up (was Re: JavaFX Media issues)

} } On 10/08/2013 06:07, Richard Bair wrote: Scale the imageview? On Aug 9, 2013, at 8:57 PM, John Hendrikx wrote: On 10/08/2013 05:46, John Hendrikx wrote: On 9/08/2013 20:15, Richard Bair wrote: Also the proposed clear() or empty() option only applies to Canvas correct? i.e. WritableI

Re: Poor quality font rendering

I think I also noticed a change in font rendering around b99 somewhere... the fonts seem to be thinner than before, or perhaps more poorly aligned with pixel boundaries. I'd prefer glyphs laid out in the same way each time, ie. letters are always on a new pixel boundary, so the same letter wil

Re: Poor quality font rendering

th sub-pixel positioned text (as opposite to pixel grid aligned). That said, on Windows for grayscale text, we are not doing that (yet). Are you running Windows, with D3D pipeline ? I would need to see a picture to be sure I understand the problem you describe. Felipe On Aug 21, 2013, at 10:19 A

Re: Poor quality font rendering

instance at the text in the "Plot" section, to me that text looks awful. Is that inside a WebView or some other control? -jct -Original Message- From: openjfx-dev-boun...@openjdk.java.net [mailto:openjfx-dev-boun...@openjdk.java.net] On Behalf Of John Hendrikx Sent: Thursday, 22 Augu

Re: Poor quality font rendering

ome other control? -jct -Original Message- From: openjfx-dev-boun...@openjdk.java.net [mailto:openjfx-dev-boun...@openjdk.java.net] On Behalf Of John Hendrikx Sent: Thursday, 22 August 2013 17:29 To: openjfx-dev@openjdk.java.net Subject: Re: Poor quality font rendering I took another good look

Re: Poor quality font rendering

On 22/08/2013 16:45, Phil Race wrote: On 8/22/13 12:29 AM, John Hendrikx wrote: System.setProperty("prism.lcdtext", "false"); So you deliberately asked for it to be different than usual Windows apps ? I'm not sure why you do this, but if its in effect we

Re: Poor quality font rendering

wouldn't even describe the differences as "subtle" as to me there is a dramatic difference in quality. Can this be fixed or are JavaFX apps always going to stand out for all the wrong reasons like this? On 23/08/2013, at 0:05, John Hendrikx wrote: Those are all normal controls, the

Re: Poor quality font rendering

but I assume it asks Windows for this information. --John Regards, Felipe On Aug 22, 2013, at 7:05 AM, John Hendrikx wrote: Those are all normal controls, the plot section is just a Label for example. On 22/08/2013 13:39, John C. Turnbull wrote: John H, it may be just me but pretty

Re: Poor quality font rendering

hat I am talking about. I wouldn't even describe the differences as "subtle" as to me there is a dramatic difference in quality. Can this be fixed or are JavaFX apps always going to stand out for all the wrong reasons like this? On 23/08/2013, at 0:05, John Hendrikx wrote: T

Re: Font size

On 22/08/2013 22:58, Peter Penzov wrote: Hi, I'm working on JavaFX application based on Java 8. It seems that from version b97 there is a issue with -fx-font-size. It's not working properly. If you compare the two images from application tested on JavaFX 2.2 and JavaFX 8 b103 you will see tha

Re: Poor quality font rendering

memoryBar.setWidth(150); memoryBar.heightProperty().bind(memText.heightProperty()); }}; Is it possible to run the same test case on Mac ? (Grayscale text, prism.text=t2k *not* set). Unfortunately, I donot own a mac, and can't easily borrow one at this time. --John Regards Felip

Re: Why is almost everything in the API final

On 3/09/2013 20:34, Richard Bair wrote: I would strongly recommend leaving the shared JRE install world behind. As a suggestion, try JWrapper - we have flawless installs now, even using an OSGI deployment procedure! Bundled JVMs are really the only dependable way to go now it seems? If my bus

Re: Make SubScene Resizable (RT-31377)

+1 on the ImageView case... getting ImageViews to resize properly, like a Button or other node would, is tricky and often gives unexpected results or doesn't behave the same in all cases. A custom Wrapper class mitigates the problem somewhat, but I can't help thinking, why isn't there a proper

Re: Moving on to a "round house kick" (forked from Re: JavaOne roundup?)

On 30/09/2013 17:38, Anton Epple wrote: Hi guys, I understand your frustration about the cancelled sessions, and I share it. But when I talk to the engineers and see their posts here, they're clearly interested in the same stuff we'd like to see in JavaFX. I guess nobody was more frustrated

Problem with Timeline keeping references around

Hi List, I just submitted https://javafx-jira.kenai.com/browse/RT-33600 which is asking for the Timeline JavaDocs to be more clear on when and where hard references are being created and how to properly clean up after oneself. Most of the docs hardly mention anything when it comes to referen

Re: Problem with Timeline keeping references around

} } } --John On 16/10/2013 00:47, Stephen F Northover wrote: This looks like a bug. Timeline should not be holding on to references. Please enter a JIRA. Steve On 2013-10-15 6:35 PM, John Hendrikx wrote: Hi List, I just submitted https://javafx-jira.kenai.com/browse/RT-33600 which is

Use ScenePulseListener to avoid expensive recalculations?

Hi List, I'm considering using a ScenePulseListener to avoid expensive recalculations when multiple bindings trigger an action. My problem is this: I like to build Views (Controls) that are dumb and expose properties that can be manipulated by whatever is using the View. The View listens t

Re: Use ScenePulseListener to avoid expensive recalculations?

es and the documentation for it is also pretty lean. I'll experiment with a ScenePulseListener and see how it pans out, it looks like it would be an elegant solution. Thanks Jonathan! I hope that helps. -- Jonathan On 6/11/2013 3:58 a.m., John Hendrikx wrote: Hi List, I'

Re: Use ScenePulseListener to avoid expensive recalculations?

On 7/11/2013 09:20, Martin Sladecek wrote: On 11/06/2013 07:31 PM, John Hendrikx wrote: On 5/11/2013 20:10, Jonathan Giles wrote: You're right in that controls don't tend to use ScenePulseListener. This may be due to an oversight on our part, or just that our requirements diffe

Re: Use ScenePulseListener to avoid expensive recalculations?

On 7/11/2013 14:08, Tomas Mikula wrote: On Thu, Nov 7, 2013 at 11:58 AM, John Hendrikx wrote: Hm, I found it googling, and since it showed up here: http://docs.oracle.com/javafx/2/api/javafx/scene/Scene.ScenePulseListener.html I figured it was public, but I just noticed the class is defined

enterNestedEventLoop as public API?

Hi List, Any chance that Toolkit.getToolkit().enterNestedEventLoop() will in the future become public API? I'm currently using this to create Dialogs based on a Pane to avoid creating Stages (which have the nice show and showAndWait functionality). I duplicated this functionality in a Pane,

Re: enterNestedEventLoop as public API?

to workaround it by using Stage, or calling into com.sun.javafx.*, which is not good. Thanks, Artem On 11/13/2013 10:15 AM, John Hendrikx wrote: Hi List, Any chance that Toolkit.getToolkit().enterNestedEventLoop() will in the future become public API? I'm currently using this to cre

Re: enterNestedEventLoop as public API?

avafx.* level, people will have to workaround it by using Stage, or calling into com.sun.javafx.*, which is not good. Thanks, Artem On 11/13/2013 10:15 AM, John Hendrikx wrote: Hi List, Any chance that Toolkit.getToolkit().enterNestedEventLoop() will in the future become public API? I

Re: enterNestedEventLoop as public API?

Hi Anthony, I just filed https://javafx-jira.kenai.com/browse/RT-34268 for this. --John On 13/11/2013 17:42, Anthony Petrov wrote: Hi John, Please file an RFE to introduce this public API. -- best regards, Anthony On 11/13/2013 08:35 PM, John Hendrikx wrote: On 13/11/2013 16:35, Stephen F

Two Level Focus

Hi list, I'm wondering how well the Conditional Feature "TWO_LEVEL_FOCUS" works, and if it is allowed to be used on non-embedded platforms. My main JavaFX project is basically a Windows/Linux application that runs without focus and is controlled with a remote control (no mouse or keyboard, a

Re: Two Level Focus

On 18/11/2013 14:25, mick.fleming wrote: However, if you do click on it with the mouse (by selecting one of its items), focus is stuck there and cannot be moved anymore with just the 5 buttons. when you click on a two_level control with a mouse it goes straight into 'internal mode', as at th

Dead horse, Bindings spam when something is null

Run the following code. It has a simple ObjectProperty that -can- be null when there is no Media inserted. I want to make a binding that displays this information to the user, but will display "-no-media-" if nothing is inserted. Is it really necessary to spam my logs with fake NPE's when i

Re: [announce] InhiBeans: mitigate redundant recalculations

Since you are only allowed to modify properties on the JavaFX thread (in most cases), I've been using Platform.runLater() to make sure I observe only complete changes. Basically I register an InvalidationListener on the properties that are relevant, and when one gets triggered I set a boolean

Future of Skins

Hi List, I'm wondering if Skins in their current form are "finished" or that more changes are still likely to come. The Skin interface is public, and SkinBase is as well. Unfortunately, it seems that even though SkinBase is treated differently by JavaFX from regular Skins, the opportunity wa

Re: Future of Skins

On 7/01/2014 14:50, Tomas Mikula wrote: Interesting ideas. I'm wondering, do you switch skins often enough that you are worried about performance (and thus care about reusability of skins)? Because I don't see how reusability of skins saves you lines of code - whether the code is in the constru

CSS metadata boilerplate

Hi List, I'm in the process of adding CSS metadata to a new control, and I noticed there is a lot of boilerplate. In order to reduce this, I've created some custom classes StyleableProperty classes (SimpleStyleableXXXProperty), which reduces the boilerplate significantly without sacrificing

Re: CSS metadata boilerplate

@Override public StyleableDoubleProperty getStyleableProperty(Styleable styleable) { return SimpleStyleableDoubleProperty.this; } }; } return cssMetaData; } @Override public Object getBean() { return bean; } @Override public String getName

Re: Future of Skins

That's basically how I've solved it so far (although I call the reusable skins "Layouts" for lack of a more imaginitive name). However, I'd like to support CSS properties as well for the delegates, and I'm not sure how the CSS engine deals with Skins that can change their properties when som

Re: Future of Skins

On 7/01/2014 18:11, Tomas Mikula wrote: With a non-reusable skin, dispose is pretty much just removing the listeners. With a reusable instance, I suspect there is more work to reset the state of the instance (e.g. removing children, or, if you were concerned about performance, returning them to

Re: CSS metadata boilerplate

Noticed a slight bug in the code. The line: cssMetaDataByName.put(cssName, cssMetaData); ...needs to be added in the if block where the CssMetaData is created. --John

Re: Move to JIRA [was: Re: [8u] API Request: RT-25613, ObservableValue should have a hasListener(listener) method]

Unfortunately, "discussing" things in JIRA works very poorly and is a good way to end a productive discussion IMHO. Mailinglists are much better suited to the task, as thousands of interesting mailinglists accross many developer communities will atest to. Keeping a record is good, aren't thes

Re: Future of Skins

e. --John On 7/01/2014 17:04, Richard Bair wrote: Could you write a single skin that delegates to one or more reusable skins? On Jan 7, 2014, at 7:26 AM, John Hendrikx wrote: On 7/01/2014 14:50, Tomas Mikula wrote: Interesting ideas. I'm wondering, do you switch skins often enough that

Re: Future of Skins

On 24/01/2014 22:28, David Grieve wrote: On Jan 24, 2014, at 4:02 PM, John Hendrikx wrote: I've got an update on this. I've rewritten the code now to make use of multiple skins, and doing some trickery with Factories to make them easily switchable. The main reason I've re

Layout issue

From an earlier posting on this list, I came to understand that in JavaFX 8 it is no longer allowed to modify the children list in layoutChildren, and that such modifications may need to be moved to the computerPref* methods. However, I get a different odd issue, and I'm wondering exactly what

Re: Layout issue

test application it would be great if you can log this as a Jira issue so that we can take a proper look into this for you. Thanks, -- Jonathan On Wednesday, 12 February 2014 5:50:15 a.m., John Hendrikx wrote: From an earlier posting on this list, I came to understand that in JavaFX 8 it is no l

Re: Layout issue

ady noted, a JIRA issue with some sample would be great. Yes, I just did, RT-35830 has a nice sample. Thanks for giving some more insight in the layout process. --John Thanks, -Martin On 02/11/2014 05:50 PM, John Hendrikx wrote: From an earlier posting on this list, I came to understand that

Supposedly lazy binding gets evaluated right away

My understanding of Bindings has always been that they're supposedly only evaluated when actually used (ie. get() is called on them). Javadoc for Binding claims (emphasis mine): "All bindings in the JavaFX runtime are calculated **lazily**. That means, if a dependency changes, the result of

Build fails at graphics:linkWinFont

Hi, I'm trying to get openjfx build on Windows, but I've run into an issue I haven't been able to resolve. Any tips I can try? --John > Task :graphics:linkWinFont FAILED Creating library P:\Dev\git\openjdk-jfx\modules\javafx.graphics\build\libs\font\win\javafx_font.lib and object P:\Dev

Re: Build fails at graphics:linkWinFont

ormation. Take a look at build/windows_tools.properties and see if anything looks odd. One thing you could try is to 'rm -rf build', then run 'gradle clean' then try the build again. -- Kevin On 8/24/2018 3:07 PM, John Hendrikx wrote: Hi, I'm trying to get openjfx build on Win

Review Request for JDK-8209968: Fix rounding error in image scale calculation

Hi, This is a review request for: https://bugs.openjdk.java.net/browse/JDK-8209968 The PR is on Github: https://github.com/javafxports/openjdk-jfx/pull/170 --John

Re: JavaFX Application Thread is recursively re-entrant into Eventhandler handle() method under some circumstances

I see nothing special in the stack trace. When you remove the component, a new MouseEvent *must* trigger (MouseEvent.EXITED) as it always needs to match with MouseEvent.ENTERED. So, the call to 'remove' triggers a new event, which gets handled by the same handler. It is indeed entered recurs

Q: Rotated labels, layout and reflow

Hi list, I get the impression that rotation of Labels needs to be something that is directly supported by Label instead of handling this with a Rotate transform (setRotate). I want to achieve something quite trivial if no rotation was involved, a layout like this, an HBox with 3 labels in it

Q: Rotated labels, layout and reflow

(Sent this twice, first message got sent prematurely) Hi list, I get the impression that rotation of Labels needs to be something that is directly supported by Label instead of handling this with a Rotate transform (setRotate). I want to achieve something quite trivial if no rotation was i

Re: Q: Rotated labels, layout and reflow

elated to the development of OpenJFX itself. Graciously, John-Val On 15 Dec 2018, at 12:50, John Hendrikx wrote: (Sent this twice, first message got sent prematurely) Hi list, I get the impression that rotation of Labels needs to be something that is directly supported by Label instead of ha

Re: Q: Rotated labels, layout and reflow

018, at 22:06, John Hendrikx wrote: I asked here because, although not a bug, it may be a good feature to support -- and I was looking for confirmation that this really isn't currently possible. It's not a bug because a rotation transform is expected to not change the layout bounds.

Re: Proposal on getting warning free (controls) packages

On 20/03/2014 20:57, Tom Schindl wrote: Hi, I've just started looking into getting the controls package warning free and/or suppress them in case not fixable. Most of the generic warnings I've come accross in a first pass involve StyleableProperty cast like this: ((StyleableProperty)graphicPro

Re: Exposing native surface or opengl handle

On 13/06/2014 08:57, Robert Krüger wrote: Hi, it has been discussed a number of time in the passed but let me quickly summarize: A number of people have requested a feature that provides the ability to have native code draw into a surface provided by a JavaFX application as fast as technically

Re: The trouble with Skins

On 14/03/2015 08:31, Tom Eugelink wrote: Hi Tomas, I have looked into it, but not yet attempted, but I did do a lot of custom controls. And I agree that it is dubious that a control is a node, and has the properties that come with it. I try to maintain a strict separation in my controls in JF

Re: The trouble with Skins

use a List model, but flipping to a page system from a scrollable list is not something I would expect when changing the look and feel. I might expect to have the view change from pixel-based scrolling to line based scrolling, or have up/down arrows at one end of the scroll bar instead of each end.

Re: The trouble with Skins

On 22/03/2015 09:59, Tom Eugelink wrote: On 22-3-2015 00:12, John Hendrikx wrote: What I do need however is a way to restore the control to the exact same state it was in before (the same amount of pixels scrolled, the same item at the top, the same item at the bottom). That is an

Re: The trouble with Skins

On 22/03/2015 16:18, Tom Eugelink wrote: On 22-3-2015 13:53, John Hendrikx wrote: On 22/03/2015 09:59, Tom Eugelink wrote: On 22-3-2015 00:12, John Hendrikx wrote: What I do need however is a way to restore the control to the exact same state it was in before (the same amount of pixels

Proof of concept for fluent bindings for ObservableValue

I just wanted to draw some attention to a recent proof of concept I made in this pull request: https://github.com/openjdk/jfx/pull/434 It is based on the work I did in https://github.com/hjohn/hs.jfx.eventstream which is in part based on work done in ReactFX by Tomas Mikula. The PR itself howe

Detecting memory leaks in a Scene

I've created a bit of helper code I've been using to detect Nodes that have been removed from a Scene that are not getting garbage collected. It takes a Scene as input, and will then monitor all Nodes that are added and removed to compile a list of Nodes that are no longer part of the Scene bu

Re: Detecting memory leaks in a Scene

Hah, managed to reproduce it in a small sample program. Filed bug: https://bugs.openjdk.java.net/browse/JDK-8264330 --John On 28/03/2021 14:03, John Hendrikx wrote: I've created a bit of helper code I've been using to detect Nodes that have been removed from a Scene that are n

RFR: 8264330: Scene MouseHandler is referencing removed nodes

Small fix to clear a reference to a removed node left by Scene$MouseHandler. - Commit messages: - 8264330: Scene MouseHandler is referencing removed nodes Changes: https://git.openjdk.java.net/jfx/pull/448/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=448&range=00 I

Re: RFR: 8264330: Scene MouseHandler is referencing removed nodes

On Wed, 31 Mar 2021 13:07:06 GMT, Kevin Rushforth wrote: >> Small fix to clear a reference to a removed node left by Scene$MouseHandler. > > modules/javafx.graphics/src/test/java/test/javafx/scene/SceneTest.java line > 1019: > >> 1017: pane = null; >> 1018: >> 1019: System.gc()

Re: RFR: 8264330: Scene MouseHandler is referencing removed nodes [v2]

On Wed, 31 Mar 2021 13:11:23 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix review comments > > modules/javafx.graphics/src/main/java/javafx/scene/Sc

Re: RFR: 8264330: Scene MouseHandler is referencing removed nodes [v2]

> Small fix to clear a reference to a removed node left by Scene$MouseHandler. John Hendrikx has updated the pull request incrementally with one additional commit since the last revision: Fix review comments - Changes: - all: https://git.openjdk.java.net/jfx/pull/448/fi

Re: RFR: 8264330: Scene MouseHandler is referencing removed nodes [v2]

On Wed, 31 Mar 2021 21:16:29 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/test/java/test/javafx/scene/SceneTest.java line >> 1019: >> >>> 1017: pane = null; >>> 1018: >>> 1019: System.gc(); >> >> It is not

Re: RFR: 8264330: Scene MouseHandler is referencing removed nodes [v3]

> Small fix to clear a reference to a removed node left by Scene$MouseHandler. John Hendrikx has updated the pull request incrementally with one additional commit since the last revision: Add test compile dependency on :base for :graphics - Changes: - all: ht

Re: RFR: 8264330: Scene MouseHandler is referencing removed nodes [v3]

On Wed, 31 Mar 2021 21:43:02 GMT, Kevin Rushforth wrote: > Did you find that it worked without the addition of the dependency to > `build.gradle`? You didn't commit that change. I guess we'll see what the > GitHub actions build shows. I forgot to add the change I did in build.gradle, it didn't

Re: Fully custom theme vs overriding Modena

I've found that building controls in such a way to limit the addition/removal of child Nodes as much as possible (for example by making them invisible/unmanaged instead of adding/removing) has a huge impact on performance. If you are seeing a lot of CSS churn, this could be one of the causes.

Integrated: 8264330: Scene MouseHandler is referencing removed nodes

On Wed, 31 Mar 2021 05:36:06 GMT, John Hendrikx wrote: > Small fix to clear a reference to a removed node left by Scene$MouseHandler. This pull request has now been integrated. Changeset: 015dad07 Author: John Hendrikx Committer: Kevin Rushforth URL: https://git.openjdk.java.net/

Re: Proof of concept for fluent bindings for ObservableValue

I've for this reason kept the PoC small with only the most basic functionality. I did however add some work for a different subscription model, mainly because the internals of this code benefits greatly from it. It is however kept to a minimum. I'd be happy to spend more time and w

Re: Proof of concept for fluent bindings for ObservableValue

lly the same as `Val`, and the equivalent to `Var` is `ObjectProperty`. Aside from it being a good companion to `Val` (and less typing), I don't see a reason to implement `Var`. --John On Sun, Apr 4, 2021 at 12:43 PM John Hendrikx mailto:hj...@xs4all.nl>> wrote: On 02/04/20

Re: platformWidth

Perhaps an example will help from my machine. I'm running on a 4k screen at 150% scaling. These are the values: outputScaleX = 1.5 outputScaleY = 1.5 platformScaleX = 1.5 platformScaleY = 1.5 width = 2560 height = 1440 visibleWidth = 2560 visibleHeight = 1400 platformWidth = 3840 platformHeight

Re: RFR: 8267551: Support loading images from inline data-URIs

I have a question about this. Why would you make this part of JavaFX directly instead of offering it as a dependency that people can include in their project? As far as I know, it is possible to register custom URL handlers in Java, which should be used automatically by JavaFX assuming it co

Re: RFR: 8267551: Support loading images from inline data-URIs [v13]

On Wed, 26 May 2021 16:36:24 GMT, Michael Strauß wrote: >> This PR adds support for loading images from [inline data >> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely >> supported by web browsers. This enables developers to package small images >> in CSS files, rath

Re: RFR: 8267551: Support loading images from inline data-URIs [v13]

On Sat, 5 Jun 2021 16:10:59 GMT, Kevin Rushforth wrote: >> In this specific case, image loading has failed for some reason. The call to >> `DataURI.tryParse` is only there to potentially call `DataURI.toString()` >> for a truncated log output, instead of logging the entire `url` String. If >>

Re: [External] : Re: Convenience factories for Border and Background

I'm not entirely convinced taking width is all that useful. The (final) pxiel width of a border is normally a calculated value based on the chosen unit and scaling needs of the platform. A lot of methods in JavaFX work with pixel values only, while for proper scaling I often find myself needin

Re: Enhancements for JavaFX 18

Perhaps: Fluent bindings for ObservableValue https://github.com/openjdk/jfx/pull/434 It was received well I think, and there was some interest from Nir Lisker to work on a proposal. --John On 30/07/2021 14:56, Kevin Rushforth wrote: Now that JavaFX 17 is in RDP2, we can turn more attention

Re: Enhancements for JavaFX 18

On 04/08/2021 19:05, Ty Young wrote: * A late "showing" property for when the application has been shown to the user and all first viewing UI components have had their sizes calculated and are being displayed, if it doesn't exist already and I'm completely blind. Do you mean a property that

Re: Re-examine the risks of JDK-8264770 breaking third party libraries and applications.

Was it taken into account that when you register an invalidation listener: property1.setValue(property2.getValue()); property1.addListener(binding); property2.addListener(binding); ... that if property2 is currently invalid it will not send any further invalidations? P

Re: Re-examine the risks of JDK-8264770 breaking third party libraries and applications.

thing until something revalidates the property, so any changes made after the bidirectional binding is established to this property will not be copied to the other property (although the other way around will work). --John On 28/08/2021 22:14, John Hendrikx wrote: Was it taken into account that

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing [v2]

On Fri, 14 May 2021 22:30:16 GMT, Michael Strauß wrote: >> The internal BidirectionalBinding class implements bidirectional bindings >> for JavaFX properties. The design intent of this class is to provide >> specializations for primitive value types to prevent boxing conversions (cf. >> specia

Re: Re-examine the risks of JDK-8264770 breaking third party libraries and applications.

println("Setting p2 to " + p1.get()); p2.set(p1.get()); } else { System.out.println("Setting p1 to " + p2.get()); p1.set(p2.get()); } } finally { updating = false; } } } } --John On 28/08/2021 22:14, John

Re: Re-examine the risks of JDK-8264770 breaking third party libraries and applications.

On 29/08/2021 01:34, Nir Lisker wrote: This actually isn't an issue because adding an invalidation listener revalidates the property as well (I'm not sure why, but I noticed this before while working on fluent bindings). There is an open issue on this: https://bugs.openjdk.java.net/browse/

  1   2   3   >