Re: MSAA and Scene anti aliasing

2013-07-14 Thread Chien Yang
Hi Richard, Yes, I agree an enum is probably better than a boolean for controlling the visual quality of a rendered scene. As a matter of fact we did explore using enum is earlier 3d discussions but decided to go with boolean due to concerns of complexity we aren't ready to handle for Jav

Re: MSAA and Scene anti aliasing

2013-07-15 Thread Chien Yang
+1. Well said. - Chien Sent from my mobile phone. Please excuse my brevity. On Jul 15, 2013, at 12:19 PM, Thor Johannesson wrote: > I think there should be a simple way to request full scene anti-aliasing to > improve 3D rendering. And also an optional more advanced way to specify which >

Re: ConcurrentModificationException during controls test runs

2013-07-16 Thread Chien Yang
Yes, this has already been filed today. https://javafx-jira.kenai.com/browse/RT-31714 - Chien On 7/16/13 3:58 PM, Richard Bair wrote: Is anybody else seeing this? javafx.scene.control.ComboBoxTest > test_rt31479 FAILED java.util.ConcurrentModificationException at java.util.HashM

API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-23 Thread Chien Yang
Hi all, We appreciate all the feedback you have contributed to this topic. After listening to the feedback and an internal discussion, we would like to propose a minor change to the API for supporting scene anti-aliasing. We intentionally choose not to expose the number of samples and tec

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-23 Thread Chien Yang
g only 2x. The comment for DEFAULT implies that it's really more of a BALANCED or MODERATE setting that would have the same characteristics on each platform. On 24 July 2013 06:29, Chien Yang <mailto:chien.y...@oracle.com>> wrote: Hi all, We appreciate all the feedb

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-23 Thread Chien Yang
de to not expose the setting of either the AA type or number of samples? I would have though that serious graphics developers would really like to have such options available to them. On 24 July 2013 06:58, Chien Yang <mailto:chien.y...@oracle.com>> wrote: Yes, very good point,

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-23 Thread Chien Yang
he comment for DEFAULT implies that it's really more of a BALANCED or MODERATE setting that would have the same characteristics on each platform. On 24 July 2013 06:29, Chien Yang wrote: Hi all, We appreciate all the feedback you have contributed to this topic. After listening to the

Re: Fwd: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-23 Thread Chien Yang
ed message -- From: Scott Palmer Date: Tue, Jul 23, 2013 at 9:33 PM Subject: Re: API Change Proposal - Re: MSAA and Scene anti aliasing To: Chien Yang Is DEFAULT intended to defer to the settings in the system graphics drivers (e.g. nVidia control panel) such that the precise settings used a

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-24 Thread Chien Yang
, // disables anti-aliasing FASTEST, // enables anti-aliasing using minimum system setting available that results in better frame rate NICEST // enables anti-aliasing using maximum system setting available that results in best visual quality } Thanks, - Chien On 7/23/2013 1:29 PM, Chien Yang

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-24 Thread Chien Yang
seems more consistent to have the only OFF mode to be first and then all the rest of the options (which happen to then have ordinals > 0) will be some form of ON mode. Richard On Jul 24, 2013, at 2:37 PM, Chien Yang wrote: Thank you for the feedback! We decided to drop DEFAULT in favor

Re: Mixing 2D and 3D

2013-07-25 Thread Chien Yang
Hi August, We did talk through some use cases such as PIP and rear view mirror. You can do simultaneous viewing from different points of view into a single 3D scene via the use of SubScenes. The key point, as you have clearly stated, is the need to clone the scene graph nodes per SubSce

Re: Mixing 2D and 3D

2013-07-25 Thread Chien Yang
from different points of view? On Jul 25, 2013, at 5:17 PM, Chien Yang wrote: Hi August, We did talk through some use cases such as PIP and rear view mirror. You can do simultaneous viewing from different points of view into a single 3D scene via the use of SubScenes. The key point, as you

Re: Antialiasing in 3D

2013-07-26 Thread Chien Yang
Hi John, My apology, I must have grouped this thread with the long "MSAA" thread in my earlier reply. For JavaFX 8 we have no plan to read in control setting from the user via Control Panel or some sort. I'm not sure how feasible it is to access this information from different GPU vend

Re: Mixing 2D and 3D

2013-07-26 Thread Chien Yang
e level of "cloning" needed within JavaFX if we want to free application developer from doing it. - Chien On 7/25/2013 7:31 PM, Richard Bair wrote: I thought the approach was not to have multiple parents, but to render into an image. On Jul 25, 2013, at 5:26 PM, Chien Yang wrote:

Re: Mixing 2D and 3D

2013-07-26 Thread Chien Yang
from this work so that we can evaluate it to see if there are any performance / semantic problems. You will likely ended up with a one frame behind rendering in those sub views, but do let us know for your finding. Thanks, - Chien On 7/26/2013 10:53 AM, Chien Yang wrote: Yes, that is sti

Re: NSInvalidSendPortException

2013-07-27 Thread Chien Yang
Hi Sven, Yes, please do. Can you provide more specific details? What is the program you were running? It will be great if you have a simple test case to go with the bug report. Thanks, - Chien On 7/27/2013 9:31 AM, Sven Reimers wrote: Hi, I get 2013-07-27 18:28:51.911 java[65246:707] [

Re: Mixing 2D and 3D

2013-07-29 Thread Chien Yang
jfx3dtuxcube.html#simview August Am Freitag, den 26.07.2013, 17:43 +0200 schrieb Chien Yang : Hi August, John Yoon, Richard and I have a private discussion on the possibility of avoiding "cloning" for your use case. We wonder do you ever need to interact with the 3D scene via t

Re: API Change Proposal - Re: MSAA and Scene anti aliasing

2013-07-31 Thread Chien Yang
thout providing public constructors so that these become statically defined by the system. What about Anisotropic filtering? Is that considered a form of AA, or an option on top of AA? ...jim On 7/24/2013 3:07 PM, Chien Yang wrote: Thanks for the help! I was of 2 minds about it;

Re: Mixing 2D and 3D

2013-08-05 Thread Chien Yang
Hi Jim, We worked closely with Pavel to ensure 3D picking did extend nicely. I believe the specification at this link is still up-to-date: https://wiki.openjdk.java.net/display/OpenJFX/Picking3dAPI - Chien On 8/5/2013 3:44 AM, Pavel Safrata wrote: On 1.8.2013 22:33, Richard Bair wrote: How

Re: JavaFX 3D Material

2013-08-27 Thread Chien Yang
Hi Kensuke, Both are known issues that we have tentative plan to address in FX 8. Here are the links for you to track their status: https://javafx-jira.kenai.com/browse/RT-29527 https://javafx-jira.kenai.com/browse/RT-28874 BTW, please note the limitation of applying opacity on Group node

Re: 3D scene antialiasing

2013-09-11 Thread Chien Yang
Hi John, > Should it be noticeable? (hopefully yes!) You should see the difference on shape with sloped edge if you platform supports MSAA. >Is it just a matter of providing true to the second of the boolean parameters in the Scene constructor? Yes this is correct, however this API is sti

Re: 3D scene antialiasing

2013-09-11 Thread Chien Yang
how I can attach anything... how do I do that? -Original Message- From: John C. Turnbull [mailto:ozem...@ozemail.com.au] Sent: Thursday, 12 September 2013 07:37 To: 'Chien Yang' Cc: 'Kevin Rushforth'; 'openjfx-dev@openjdk.java.net' Subject: RE: 3D scene antialia

Re: CFV: New OpenJFX Committer: Yao Wang

2013-09-25 Thread Chien Yang
Vote: YES. Thanks, - Chien On 9/25/2013 9:01 AM, Artem Ananiev wrote: I hereby nominate Yao Wang to OpenJFX Committer. Yao is a member of JavaFX Graphics team at Oracle. Most of recent Yao's changes are in 3D support code, but not only there: hg log -u "Yao Wang" Incomplete list of Yao'

Re: JavaFX 3D Issues reported in April

2013-09-26 Thread Chien Yang
Hi Richard, Don and I did exchange emails to work through the list of issues he encountered this April. As far as I remembered all were tracked with JIRAs and most, such as material and mesh computation bugs, were already fixed. - Chien On 9/26/2013 2:32 PM, Richard Bair wrote: Gre

Re: Bounds constructor validation

2013-10-01 Thread Chien Yang
min* > max* implies empty bounds. This semantic can be traced back to https://javafx-jira.kenai.com/browse/RT-11793 - Chien On 10/1/2013 5:59 PM, Joseph Andresen wrote: Kevin and I had this exact conversation years ago. I believe our answer was that anything less than 0 meant uninitialized?

Re: Cylinder divisions and PerspectiveCamera fixedEyePosition should be mutable

2013-10-04 Thread Chien Yang
We did discuss making divisions in the predefined 3D shapes mutable in earlier meeting. However we decided against it since it is a heavy weight operation as the supporting mesh will has to be regenerated. I believe the constructor with the divisions argument will not have much use in the futur

[API-REVIEW] RT-33211 - Fix TriangleMesh API to support a range of vertex format in the future

2013-10-16 Thread Chien Yang
Hi all, We realized the existing TriangleMesh API is too restrictive to support additional vertex formats in the future, for examples, user specified normal and multi-texture units. We will need to make at least 2 changes to allow TriangleMesh be used for a range of vertex formats in the futur

V-up texture coordinate support

2013-10-17 Thread Chien Yang
Hi all, Java images are defined such that (0, 0) references the top left most pixel of the image. In JavaFX, the texture coordinate system for 3D objects is defined with its U axis increasing from left to right and the V axis increasing from top to bottom. Hence a texture coordinate of (0

Re: V-up texture coordinate support

2013-10-22 Thread Chien Yang
K_FLIP_Y_WEBGL, true); Regards -- Remi From: Chien Yang <mailto:chien.y...@oracle.com> Date: Thu, Oct 17, 2013 at 3:08 PM Subject: V-up texture coordinate support To: OpenJFX <mailto:openjfx-dev@openjdk.java.net> Hi all, Java images are defined such that (0, 0) references the t

Re: V-up texture coordinate support

2013-10-22 Thread Chien Yang
discussed in "Getting Started with JavaFX 3D Graphics/Camera/Y-down versus Y-up" (http://docs.oracle.com/javafx/8/3d_graphics/camera.htm#CJAHFAHB). Doesn't this approach require an immediate availability of a v-flipping feature? August Am Donnerstag, den 17.10.2013, 15:0

Re: Build fail: unresolved external symbol mainCRTStartup

2013-11-08 Thread Chien Yang
Hi Leonid, I have no problem doing 32 bit build on my Windows 7 laptop though I haven't done a 64 bit build since we switched to gralde. Here is information about my gradle environment just in case it is helpful: $ gradle -v Grad

Code Review Request For RT-33212: Java FX 8 on Windows Vista - nodes show unpainted regions and distort with resizing with components disappearing

2013-11-15 Thread Chien Yang
Vadim and Kevin, Please review review the following change. Webrev: http://cr.openjdk.java.net/~ckyang/RT-33212/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-33212 Thanks, - Chien

Code Review Request For RT-32525: [FX3D] 3D does not working with Windows 2008 R2

2013-11-15 Thread Chien Yang
Kevin and Vadim, Please review the following change. Webrev: http://cr.openjdk.java.net/~ckyang/RT-32525/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-32525 Thanks, - Chien

Code Review Request For RT-34226: Shading of PhongMaterial Boxes appears unnatural

2013-11-18 Thread Chien Yang
Kevin and Jim, Please review this simple fix. I have also included the report test case this change: JIRA: https://javafx-jira.kenai.com/browse/RT-34226 Webrev: http://cr.openjdk.java.net/~ckyang/RT-34226/webrev.00/ Thanks, - Chien

Code Review Request For RT-29527: MeshView textures are not repeated

2013-11-19 Thread Chien Yang
Kevin and Vadim, Please review my proposed fix for this bug: JIRA: https://javafx-jira.kenai.com/browse/RT-29527 Wevrev: http://cr.openjdk.java.net/~ckyang/RT-29527/webrev.00/ I have done a fairly extensive testing on our 3D programs. This fix exposes a d3d 3D state bug in Prism in 2 test

Code Review Request For RT-34343: [JFX 8 3D] BaseMesh throws NPE in case of dead face(s)

2013-11-22 Thread Chien Yang
Hi Kevin, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-34343 Thanks, - Chien

Code Review Request For RT-33461: Release native resource used by MSAA buffer when it is freed

2013-11-25 Thread Chien Yang
Hi Kevin, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-33461 Thanks, - Chien

Code Review Request For RT-29101: SubScene require unit test coverage

2013-11-26 Thread Chien Yang
Hi Kevin, Please review my proposed test coverage: https://javafx-jira.kenai.com/browse/RT-29101 Thanks, - Chien

[Doc only] Code Review Request RT-30404: [FX3D] Need better documentation for the default PointLight

2013-12-05 Thread Chien Yang
Hi Kevin, Please review this simple javadoc change: JIRA: https://javafx-jira.kenai.com/browse/RT-30404 Webrev: http://cr.openjdk.java.net/~ckyang/RT-30404/webrev.00/ Thanks, - Chien

8 post-commit review: [Doc only] RT-34292: Document importance of TriangleMesh order of elements

2013-12-06 Thread Chien Yang
In case anyone is interested in this post commit javadoc change: (initial draft was reviewed by kcr) http://cr.openjdk.java.net/~ckyang/RT-34292/webrev.00/ Thanks, - Chien

Re: CFV: New OpenJFX Committer: Vadim Pakhnushev

2013-12-12 Thread Chien Yang
Vote: YES Sent from my mobile phone. Please excuse my brevity. > On Dec 11, 2013, at 1:17 PM, David Hill wrote: > > > I hereby nominate Vadim Pakhnushev to OpenJFX Committer. > > Vadim is a member of JavaFX Embedded team at Oracle. Vadim's changes are in > Glass Windows/D3d: > > hg log -M

Code Review Request For RT-28883: Rendering artifacts on NVIDIA GeForce 6600

2013-12-14 Thread Chien Yang
Hi Kevin and Vadim, Please review my proposed fix: https://javafx-jira.kenai.com/browse/RT-28883 Thanks, - Chien

[8u] Code Review Request - RT-31749: Support Intel GPU on Linux platform

2013-12-23 Thread Chien Yang
Hi Kevin, Please review this simple one line fix to enable support for Intel GPU on the Linux platform: https://javafx-jira.kenai.com/browse/RT-31749 Thanks, - Chien

[8u] Code Review Request - RT-34385: Support Prism HW acceleration on Linux with open-source driver

2013-12-23 Thread Chien Yang
Hi Felipe and Kevin, Please review this simple one line fix to support X.Org open source drivers for ATI/AMD and Nvidia: http://cr.openjdk.java.net/~ckyang/RT-34385/webrev.00/ Thanks, - Chien

Re: [8u] Code Review Request - RT-34385: Support Prism HW acceleration on Linux with open-source driver

2013-12-24 Thread Chien Yang
Here is the link to the JIRA: https://javafx-jira.kenai.com/browse/RT-34385 - Chien On 12/23/2013 3:30 PM, Chien Yang wrote: Hi Felipe and Kevin, Please review this simple one line fix to support X.Org open source drivers for ATI/AMD and Nvidia: http://cr.openjdk.java.net/~ckyang/RT

8u post-commit review: RT-34900: Upgrade Netbeans projects to Netbeans 7.4

2013-12-26 Thread Chien Yang
JIRA: https://javafx-jira.kenai.com/browse/RT-34900 Thanks, - Chien

[8u] Code Review Request - RT-32631: D3D: Need to improve OS version checking into GPU qualifying logic

2013-12-31 Thread Chien Yang
Hi Kevin and Vadim, Can you please review my proposed fix? http://cr.openjdk.java.net/~ckyang/RT-32631/webrev.00/ Thanks, - Chien

Re: [8u] Code Review Request - RT-32631: D3D: Need to improve OS version checking into GPU qualifying logic

2013-12-31 Thread Chien Yang
I should have used the JIRA where link to the webrev is included: https://javafx-jira.kenai.com/browse/RT-32631 - Chien On 12/31/2013 11:40 AM, Chien Yang wrote: Hi Kevin and Vadim, Can you please review my proposed fix? http://cr.openjdk.java.net/~ckyang/RT-32631/webrev.00/ Thanks

Re: JavaFX versus AWT/Swing Hardware Acceleration

2014-01-03 Thread Chien Yang
The Graphics Support section in this link has a detail information on the list of GPUs JavaFX can take advantage of: http://docs.oracle.com/javafx/2/system_requirements_2-2-5/jfxpub-system_requirements_2-2-5.htm Note: Linux and Mac should have the same support coverage except for Intel GMA 4

Re: JavaFX versus AWT/Swing Hardware Acceleration

2014-01-03 Thread Chien Yang
Jim will probably has more to say about how the caching works. JavaFX has a unified texture resource management system for Prism. An aging algorithm is used to determine which native texture resource to be released when the system is low on VRAM or reached a system configurable VRAM threshold

Code Review Request for RT-35956: Add a stopgap fix to improve mesh update performance for limited use cases that doesn't do 3d lighting in the scene

2014-02-20 Thread Chien Yang
Kevin and Vadim, Please review this very limited and guarded fix as a temporary solution till we have a better API to support dynamic mesh update. More information about performance is captured in the JIRA. Webrev: http://cr.openjdk.java.net/~ckyang/RT-35956/webrev.00/ JIRA: https://javafx-jir

[8u20] Review request: RT-21702 - [Touch, Windows] MouseEvents generated from touch-screen action have isSynthesized() == false

2014-03-03 Thread Chien Yang
JIRA: https://javafx-jira.kenai.com/browse/RT-21702 Webrev: http://cr.openjdk.java.net/~ckyang/RT-21702/webrev.00/ Thanks, - Chien

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Chien Yang
I have a quick question. Did you get your embedded JavaFX library from Glueon? http://gluonhq.com/open-source/javafxports/downloads/ - Chien On 2/29/16, 7:21 AM, Maurice wrote: Should I file a bug? I can't determine whether this is a client platform issue or a major bug in the EGL that JavaF

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Chien Yang
the Wiki <https://wiki.openjdk.java.net/display/OpenJFX/Cross+Building+for+ARM+Hard+Float>. Maurice. Op 29-02-16 om 17:49 schreef Chien Yang: I have a quick question. Did you get your embedded JavaFX library from Glueon? http://gluonhq.com/open-source/javafxports/downloads/ - Chien

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-02 Thread Chien Yang
Hi Maurice, Can you please file a JIRA on this issue? Thanks, - Chien On 3/1/16, 11:45 PM, Maurice wrote: Jim, A solution in line of that of Johan Vos [1] works. JavaFX can be run and doesn't crash on startup when compiling the shaders. I think they should be taken into account for at leas

Re: ProgressIndicator indeterminate transition bugs

2016-03-08 Thread Chien Yang
You may track the progress of this work with this JIRA for now. We are still investigating the scope and impact of this work. We may decide to create a new JIRA and resolve this as a duplicate if we decide to go with a better naming. https://bugs.openjdk.java.net/browse/JDK-8090322 - Chien

[9] API Review Request: 8144556 - Add support to allow user specified rendering order

2016-03-19 Thread Chien Yang
Hi Kevin and all, Please review the following new API proposal to add a priorityOrder property to Node: JIRA: https://bugs.openjdk.java.net/browse/JDK-8144556 Here is a prototype of the implementation with a simple toy example if you wish to play with: Webrev: http://cr.openjdk.java.net/~c

Re: JavaFX Application Heat up MacBook Pro

2016-03-27 Thread Chien Yang
You are correct. MBP 13 only has an integrated GPU and those 2 fixes mentioned earlier don't apply to your case. - Chien On 3/25/16, 3:15 PM, Tai Hu wrote: I have a MacBook Pro 13 inch (2014 model). If I remembered correctly, it only has an integrated GPU. There is no discreet GPU Thanks, Ta

Re: JavaFX Application Heat up MacBook Pro

2016-03-28 Thread Chien Yang
, Chien Yang wrote: You are correct. MBP 13 only has an integrated GPU and those 2 fixes mentioned earlier don't apply to your case. - Chien On 3/25/16, 3:15 PM, Tai Hu wrote: I have a MacBook Pro 13 inch (2014 model). If I remembered correctly, it only has an integrated GPU. There

Re: JavaFX Application Heat up MacBook Pro

2016-03-28 Thread Chien Yang
Great! Can you please file a JIRA with your test program. We will investigate the issue. https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report - Chien On 3/28/16, 9:06 AM, Tai Hu wrote: My MacBook Pro is a i5 dual core with 16GB of memory. The minimal application that exhibit

[9] Code Review Request: 8144556: Add support to allow user specified rendering order

2016-03-31 Thread Chien Yang
Please review the proposed specification and implementation. JIRA: https://bugs.openjdk.java.net/browse/JDK-8144556 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8144556/webrev.00/ - Chien

Re: Jvm crash: es2 pipeline crashs jvm on macosx vm

2016-04-14 Thread Chien Yang
Thanks reporting your finding and suggestion. Do you mind filing a bug report? Please include the steps and your system configuration that we may reproduce the crash on our end. https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report Thanks, - Chien On 4/14/2016 12:16 PM, Ali

Re: Glass: CGLCreateContext error: 10002: empty window on MacOSX VM

2016-04-14 Thread Chien Yang
We are interested in knowing how and when you use the software pipe of JavaFX on Mac. Can you please submit a bug report and provide those information? https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report Thanks, - Chien On 4/14/2016 11:41 AM, Ali Ebrahimi wrote: On macosx v

Re: Glass: CGLCreateContext error: 10002: empty window on MacOSX VM

2016-04-16 Thread Chien Yang
/14/16, 11:20 PM, Ali Ebrahimi wrote: Done. Review ID: JI-9035391 On Fri, Apr 15, 2016 at 2:47 AM, Chien Yang <mailto:chien.y...@oracle.com>> wrote: We are interested in knowing how and when you use the software pipe of JavaFX on Mac. Can you please submit a bug report and

Re: Jvm crash: es2 pipeline crashs jvm on macosx vm

2016-04-16 Thread Chien Yang
also works for javafx8. On Fri, Apr 15, 2016 at 2:07 AM, Chien Yang <mailto:chien.y...@oracle.com>> wrote: Thanks reporting your finding and suggestion. Do you mind filing a bug report? Please include the steps and your system configuration that we may reproduce the cr

Re: Jvm crash: es2 pipeline crashs jvm on macosx vm

2016-04-18 Thread Chien Yang
Hi Ali, Context management is tightly couple between Glass and Prism. The fix will likely touches both places. - Chien On 4/16/16, 11:05 AM, Ali Ebrahimi wrote: Hi, On Sat, Apr 16, 2016 at 10:11 PM, Chien Yang <mailto:chien.y...@oracle.com>> wrote: Hi Ali, Thanks! I b

[9] Code Review Request JDK-8154509: Remove the word impl_ in the name of private methods and members

2016-04-19 Thread Chien Yang
Hi Kevin, Please review this simple name change cleanup fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8154509 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8154509/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8155053: Encapsulate impl_ methods in Effect and on the setting of TraversalEngine

2016-04-25 Thread Chien Yang
Hi Kevin, Please review the purposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8155053 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8155053/webrev.00/ Thanks, - Chien

Re: CFV: New OpenJFX Committer: Guru Hb

2016-04-28 Thread Chien Yang
Vote: YES On 4/28/16, 8:16 AM, Kevin Rushforth wrote: I hereby nominate Guru Hb [1] to OpenJFX Committer. Guru is a member of JavaFX team at Oracle working on WebKit, who has contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant. Votes are due by May 12, 2016. Only

Code Review Request For 8155757: Encapsulate impl_ methods in animation, canvas, image, input, layout, paint, and text packages

2016-04-29 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8155757 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8155757/webrev.00/ Thanks, - Chien

Re: Code Review Request For 8155757: Encapsulate impl_ methods in animation, canvas, image, input, layout, paint, and text packages

2016-05-01 Thread Chien Yang
od java/lang/Object."":()V 9: return public void bar(); Code: 0: aload_0 1: getfield #1 // Field this$0:LInnerPackageTest; 4: invokevirtual #3 // Method InnerPackageTest.foo:()V 7: return }

[9] Code Review Request For 8155762: Encapsulate JavaFX impl_* implementation methods in transform package

2016-05-03 Thread Chien Yang
Kevin and Jim, Please review the proposed fix: Webrev: https://bugs.openjdk.java.net/browse/JDK-8155762 JIRA: http://cr.openjdk.java.net/~ckyang/JDK-8155762/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8156170: Clean up Stage and StageHelper

2016-05-06 Thread Chien Yang
Hi Kevin and Jonathan, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8156170 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8156170/webrev.00/ - Chien

Re: [9] Code Review Request For 8155762: Encapsulate JavaFX impl_* implementation methods in transform package

2016-05-07 Thread Chien Yang
lack of mutating methods and possibly mentioning the intent in the javadoc... ...jim On 5/3/2016 11:24 PM, Chien Yang wrote: Kevin and Jim, Please review the proposed fix: Webrev: https://bugs.openjdk.java.net/browse/JDK-8155762 JIRA: http://cr.openjdk.java.net/~ckyang/JDK-8155762/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8155998: Encapsulate JavaFX impl_* implementation methods in stage package

2016-05-15 Thread Chien Yang
Hi Jonathan and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8155998 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8155998/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8157186: Remove unnecessary @treatasprivate tag in source code

2016-05-17 Thread Chien Yang
Hi Jonathan and Kevin, Please review this simple clean up fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8157186 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8157186/webrev.00/index.html

[9] Code Review Request For 8157295: Encapsulate impl_ methods in Scene and KeyValue classes

2016-05-18 Thread Chien Yang
Hi Jonathan and Kevin, Please review the proposed fix: Webrev: https://bugs.openjdk.java.net/browse/JDK-8157295 JIRA: http://cr.openjdk.java.net/~ckyang/JDK-8157295/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8157350: Encapsulate impl_ methods in Shapes related classes

2016-05-20 Thread Chien Yang
Hi Kevin, Please review the proposed fix as we have discussed. JIRA: https://bugs.openjdk.java.net/browse/JDK-8157350 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8157350/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8091874: Need API in GridPane to get row count, column count, and cell bounds

2016-05-20 Thread Chien Yang
Hi Kevin, Please review the suggested fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8091874 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8091874/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8157900: Encapsulate JavaFX impl_* implementation methods in Node (peer and dirty)

2016-05-26 Thread Chien Yang
Hi Kevin, Jonathon and Vadim, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8157900 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8157900/webrev.00/ PS: This is a huge webrev and touches many components. I believe most component owners would want to do a quick

[9] Code Review Request For 8158659: Encapsulate impl_ methods in Node and its subclasses

2016-06-03 Thread Chien Yang
Hi all, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8158659 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8158659/webrev.00/ Thanks, - Chien

[9] Code Review For 8144585: Encapsulate JavaFX impl_* implementation methods

2016-06-03 Thread Chien Yang
Hi all, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8144585 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8144585/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8159021: Redo layout bounds tests in GroupTest

2016-06-07 Thread Chien Yang
Kevin and Vadim, Please review this simple fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8159021 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8159021/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8159383: Mouse hover on Webview scroll bar leads to NPE in ScrollBarThemeImpl.hitTest

2016-06-15 Thread Chien Yang
Hi Kevin, Please review the simple bug fix as we have investigated: https://bugs.openjdk.java.net/browse/JDK-8159383 Thanks, - Chien

[9] Code Review Request For 8157500: Create unit tests for new public methods in GridPane

2016-06-17 Thread Chien Yang
Hi Kevin, Please review the proposed unit test: JIRA: https://bugs.openjdk.java.net/browse/JDK-8157500 Webev: http://cr.openjdk.java.net/~ckyang/JDK-8157500/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8158004: Node, Shape and Shape3D need meaningful runtime exception message when application directly extends these classes

2016-06-22 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8158004 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8158004/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8159005: SceneBuilder needs public access to FXMLLoader setStaticLoad support from JavaFX that is no longer available

2016-06-23 Thread Chien Yang
Hi Kevin, Please review this proposed fix as we have discussed earlier. Webrev: https://bugs.openjdk.java.net/browse/JDK-8159005 Thanks, - Chien

[9] Review Request For 8158948: SceneBuilder needs public access to CSS styling support from JavaFX that is no longer available

2016-06-23 Thread Chien Yang
Hi Kevin, Please review this proposed fix as we have discussed earlier. Webrev: https://bugs.openjdk.java.net/browse/JDK-8158948 Thanks, - Chien

[9] Code Review Request For 8158006: Improve javadoc for abstract classes that application should not directly extend

2016-06-23 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8158006 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8158006/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8090322: Need new tree visible property in Node that consider Scene and Stage visibility

2016-07-05 Thread Chien Yang
Hi Jonathan, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8090322 Thanks, - Chien

[9] Code Review Request For 8088846: PopupWindow does not disappear when associated Control is not visible.

2016-07-08 Thread Chien Yang
Hi Dave and Jonathan, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8088846 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088846/webrev.00/ Thanks, - Chien

Re: ProgressIndicator indeterminate transition bugs

2016-07-13 Thread Chien Yang
e progress indicator issues are all done as talked, GREAT! Are they planned to be included in Java 8? Cheers, Diego -Original Message----- From: Chien Yang [mailto:chien.y...@oracle.com] Sent: Dienstag, 8. März 2016 20:41 To: Cirujano Cuesta, Diego; jonathan.gi...@oracle.com; openjfx-dev@openjd

[9] Code Review Request For 8148721: Memory leak caused by scroll gesture

2016-07-16 Thread Chien Yang
Hi Jonathan, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8148721 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8148721/webrev.00/ Thanks, - Chien

Re: CFV: New OpenJFX Committer: Ankit Srivastava

2016-07-25 Thread Chien Yang
Vote: YES On 7/19/16 6:37 AM, David Hill wrote: I hereby nominate Ankit Srivastava to OpenJFX Committer. Ankit Srivastava is part of the JavaFX team focusing on Web. A list of Ankit's commits and reviews is available by the following links http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev

[9] Code Review Request For 8154148: JavaFX crashes on startup when run on Mac in VMWare

2016-07-28 Thread Chien Yang
Hi Kevin and Dave, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8154148 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8154148/webrev.00/ Thanks, - Chien

Code Review Request For 8162883: ESC button fails to cancel Dialog

2016-08-01 Thread Chien Yang
Hi Jonathan and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8162883 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8162883/webrev.00/ Thanks, - Chien

Code Review Request For 8156078: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-02 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8156078 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8156078/webrev.00/ Thanks, - Chien

[8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang
Hi Kevin, Please review the proposed backport: JIRA: https://bugs.openjdk.java.net/browse/JDK-8163302 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163302/webrev.00/ Thanks, - Chien

[8udev (backport)] Code Review Request For 8156078: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang
Hi Kevin, Please review the proposed backport: JIRA: https://bugs.openjdk.java.net/browse/JDK-8156078 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8156078/backport.00/ Thanks, - Chien

Re: [8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang
should have the Bug ID of the main bug: 8156078 Thanks. -- Kevin Chien Yang wrote: Hi Kevin, Please review the proposed backport: JIRA: https://bugs.openjdk.java.net/browse/JDK-8163302 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163302/webrev.00/ Thanks, - Chien

  1   2   3   >