Re: [Openocd-development] [PATCH] make sure file name case of at91sam3uxx matches what other files include

2011-12-01 Thread Andreas Fritiofson
Patch awaiting review at http://openocd.zylin.com/247 . Next time, please push it directly to gerrit yourself. Read HACKING for instructions. Thanks! ___ Openocd-development mailing list Openocd-development@lists.berlios.de

Re: [Openocd-development] [OpenOCD-devel] Change in openocd[master]: gdb: add config command to auto send halt cmd

2011-11-25 Thread Andreas Fritiofson
I just want to add that there is a tcl hook that gets called when gdb connects. Depending on how you use openocd/gdb, that one can be more convenient for doing a reset init than with monitor commands from within gdb. As has been said already, openocd (and gdb) should do as little as possible to

Re: [Openocd-development] openocd patch: 96c3cbf cortex_m: add missing error checking

2011-11-02 Thread Andreas Fritiofson
On Tue, Nov 1, 2011 at 11:16 PM, Tomek CEDRO tomek.ce...@gmail.com wrote: Hey does this code is related anyhow to arm_adi_v5 or this is totally alternative solution? Yes, it *uses* arm_adi_v5. /Andreas ___ Openocd-development mailing list

Re: [Openocd-development] pointers modification within functions

2011-11-02 Thread Andreas Fritiofson
On Thu, Nov 3, 2011 at 12:41 AM, Tomek CEDRO tomek.ce...@gmail.com wrote: Hey, I have some problems with pointers and need some support plz ;-) I'm not sure I understand what the problem is, but I can give some general hints. int swd_bus_read_ack(swd_ctx_t *swdctx, swd_operation_t

Re: [Openocd-development] pointers modification within functions

2011-11-02 Thread Andreas Fritiofson
On Thu, Nov 3, 2011 at 1:43 AM, Tomek CEDRO tomek.ce...@gmail.com wrote: Hello Andreas :-) On Thu, Nov 3, 2011 at 12:36 AM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: This won't even compile. You pass a pointer-to-int, but swd_bus_read_ack expects a pointer-to-pointer-to-char

[Openocd-development] scan-build and gerrit rant (Was: Re: openocd patch: 620ba7e clang: fix warning by adding assert that shows that a variable is used)

2011-10-29 Thread Andreas Fritiofson
On Sat, Oct 29, 2011 at 10:56 AM, ger...@openocd.zylin.com wrote: This is an automated email from Gerrit. ?yvind Harboe (oyvindhar...@gmail.com) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/134 -- gerrit commit

Re: [Openocd-development] Remove qP from rtos code?

2011-10-19 Thread Andreas Fritiofson
Sorry for bringing this old thread up (no pun intended). This code got a few minutes of my attention after I browsed through the clang static analysis report someone posted recently. rtos.c was one of the first in the list, and while the bug report probably was a false positive, I noticed some

Re: [Openocd-development] Remove qP from rtos code?

2011-10-19 Thread Andreas Fritiofson
Hi! On Thu, Oct 20, 2011 at 12:47 AM, Evan Hunter ehun...@broadcom.com wrote: You are right – Looking at it again, the “qP” code looks like I got halfway through implementing it, then found that I should be using qThreadExtraInfo instead. Please feel free to remove it. The only reason I

Re: [Openocd-development] Only every second programming works

2011-10-19 Thread Andreas Fritiofson
On Wed, Oct 19, 2011 at 2:23 PM, freddie_chopin freddie_cho...@op.plwrote: W dniu 2011-10-19 14:14:11 użytkownik Akos Vandra axo...@gmail.com napisał: #lpcfixchecksum takes only binary files, so #make a binary file from the elf, and fix the checksum. arm-eabi-objcopy -O binary $FILE

Re: [Openocd-development] Clock setup script for STM32F107

2011-10-09 Thread Andreas Fritiofson
On Sun, Oct 9, 2011 at 12:37 PM, Simon Barner bar...@gmx.de wrote: Dear list, I have already posted the attached script some weeks ago. It enables the PLL of the STM32F107 and thus configures the MCU to run at 72 MHz which allows for higher JTAG speeds. Since this should be useful for

Re: [Openocd-development] What's up? Why so slow?

2011-10-09 Thread Andreas Fritiofson
On Sun, Oct 9, 2011 at 10:43 PM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: On Sun, Oct 9, 2011 at 3:40 AM, Peter Stuge pe...@stuge.se wrote: Transfer rate: 3 KB/sec, 13848 bytes/write. USB roundtrips? Ḯ'll have a look with usbmon soon. U+0618 LATIN CAPITAL LETTER I

Re: [Openocd-development] What's up? Why so slow?

2011-10-09 Thread Andreas Fritiofson
On Sun, Oct 9, 2011 at 11:28 PM, Akos Vandra axo...@gmail.com wrote: P.S. Is it just me, or the default reply address is the sender himself, and not the list? The list server doesn't set Reply-To to the list address, for some very good reason which I have forgotten now. Easiest fix is to set

Re: [Openocd-development] arm-jtag-ew fixes: Rebased patches

2011-10-08 Thread Andreas Fritiofson
On Fri, Oct 7, 2011 at 12:03 AM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Thu, Sep 22, 2011 at 9:15 PM, Simon Barner bar...@gmx.de wrote: Dear list, I finally found some time to rebase my patches and to split them into smaller pieces (as suggested by Ųyvind Harboe

Re: [Openocd-development] [PATCH] contrib: fix udev rules for tty based adaptors

2011-10-08 Thread Andreas Fritiofson
On Sat, Oct 8, 2011 at 6:12 PM, Luca BRUNO lu...@debian.org wrote: Luca Bruno scrisse: This patch fix udev rules to work with any listed tty-based adaptor. Speaking of udev, another related patch is currently sitting in the bug tracker at http://sourceforge.net/apps/trac/openocd/ticket/39

Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms

2011-10-08 Thread Andreas Fritiofson
On Wed, Aug 31, 2011 at 1:21 AM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Tue, Aug 16, 2011 at 8:40 AM, Simon Barner bar...@gmx.de wrote: On 16.08.2011 01:25, Andreas Fritiofson wrote: On Wed, Aug 10, 2011 at 12:01 AM, Spencer Oliver s...@spen-soft.co.uk mailto:s

Re: [Openocd-development] load_image trouble

2011-10-07 Thread Andreas Fritiofson
On Fri, Oct 7, 2011 at 7:34 AM, Dmitry E. Oboukhov un...@debian.org wrote: I cant upload an image into internal SRAM (AT91SAM9). it can really write only 20 bytes. load_image into internal flash area works fine. But why it doesn't fail if it writes the other regions? It crashes only

Re: [Openocd-development] Atmel SAM3N with OpenOCD 0.5.0 (and git HEAD too)

2011-10-07 Thread Andreas Fritiofson
On Fri, Oct 7, 2011 at 2:37 PM, Attila Kinali att...@kinali.ch wrote: On Thu, 6 Oct 2011 23:07:44 +0200 Andreas Fritiofson andreas.fritiof...@gmail.com wrote: It obviously hangs during init, which could mean just about anything. It's impossible to tell without a debug log (-d3). I

Re: [Openocd-development] [PATCH] FT2232: Add additional debug information with libftdi when cable connection fails.

2011-10-06 Thread Andreas Fritiofson
Hi, On Sun, Oct 2, 2011 at 7:34 PM, Karl Kurbjun kkurb...@gmail.com wrote: This additional output was helpful when debugging a FTDI device with a broken EEPROM. I was expecting to connect to a cable with a particular description, but the device was not found. This error message would

Re: [Openocd-development] Atmel SAM3N with OpenOCD 0.5.0

2011-10-06 Thread Andreas Fritiofson
Hi, On Wed, Oct 5, 2011 at 3:15 PM, Attila Kinali att...@kinali.ch wrote: Moin, Has anyone got a Atmel SAM3N (N, not U) working with OpenOCD? SAM3U works with OpenOCD 0.5.0, but not with SAM3N. The device is properly detected, but when accessing the flash, OpenOCD hangs indefinitely.

Re: [Openocd-development] Atmel SAM3N with OpenOCD 0.5.0

2011-10-06 Thread Andreas Fritiofson
On Thu, Oct 6, 2011 at 11:14 PM, Tomek CEDRO tomek.ce...@gmail.com wrote: On Thu, Oct 6, 2011 at 9:07 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: That log doesn't show that OpenOCD hangs after accessing flash. The Flash bank access DONE part is wrong, the flash bank has only

Re: [Openocd-development] Show of hands for/against gerrit

2011-10-06 Thread Andreas Fritiofson
On Thu, Oct 6, 2011 at 11:01 PM, Øyvind Harboe oyvind.har...@zylin.comwrote: I find gerrit intriguing as a way of managing patches. Can I have a show of hands of contributors for/against/don't care/don't know? Haven't heard of it until now, but sure, a tool like that could be useful. What

Re: [Openocd-development] arm-jtag-ew fixes: Rebased patches

2011-10-06 Thread Andreas Fritiofson
On Thu, Sep 22, 2011 at 9:15 PM, Simon Barner bar...@gmx.de wrote: Dear list, I finally found some time to rebase my patches and to split them into smaller pieces (as suggested by Ųyvind Harboe). Please refer to the commit messages for the purpose of the individual patches. I would

Re: [Openocd-development] load_image trouble

2011-10-06 Thread Andreas Fritiofson
Hi, On Sat, Sep 24, 2011 at 2:00 PM, Dmitry E. Oboukhov un...@debian.orgwrote: Dmitry E. Oboukhov wrote: I cant upload an image into internal SRAM (AT91SAM9). it can really write only 20 bytes. load_image into internal flash area works fine. But why it doesn't fail if it writes the

Re: [Openocd-development] Possible bug in xscale_receive()

2011-10-06 Thread Andreas Fritiofson
On Mon, Sep 19, 2011 at 4:30 PM, Matt Reimer mrei...@sdgsystems.com wrote: The code in xscale_receive() that tries to skip invalid reads (i.e. reads that don't have the DBG_SR[0] 'valid' bit set) seems to be wrong, as it only looks at the first word's valid flag rather than each word's own

Re: [Openocd-development] [PATCH] Fixes and spellchecks for various Buspirate output messages

2011-09-10 Thread Andreas Fritiofson
It's merged. Thanks! /Andreas ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH]style: typedefs are evil

2011-08-30 Thread Andreas Fritiofson
On Wed, Aug 31, 2011 at 12:27 AM, Martin Schmölzer martin.schmoel...@student.tuwien.ac.at wrote: Hi, On Tue, 2011-08-30 at 15:25 -0400, Eric Wetzel wrote: I don't think I have a way to verify the changes I made to src/flash/ocl/at91sam7x (from the second patch) or the changes I would

Re: [Openocd-development] [PATCH]style: typedefs are evil

2011-08-30 Thread Andreas Fritiofson
On Tue, Aug 30, 2011 at 9:25 PM, Eric Wetzel thewet...@gmail.com wrote: On the discussion of style, I mentioned that the Linux coding standard doesn't really like typedefs. Here is an article from Greg K-H that partially addresses the subject: http://www.linuxjournal.com/article/5780?page=0,2

Re: [Openocd-development] [PULL REQUEST] dsp5680xx fix - halt, flash lock-unlock procedures

2011-08-30 Thread Andreas Fritiofson
Did we decide whether patches should be posted to the list, in addition to the pull request, to ease reviews? Personally I much rather check the patches via a web interface, if one is available for the repo. On the other hand, having the patches in the list archive could be good (if they're not

Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms

2011-08-30 Thread Andreas Fritiofson
On Tue, Aug 16, 2011 at 8:40 AM, Simon Barner bar...@gmx.de wrote: On 16.08.2011 01:25, Andreas Fritiofson wrote: On Wed, Aug 10, 2011 at 12:01 AM, Spencer Oliver s...@spen-soft.co.uk mailto:s...@spen-soft.co.uk wrote: On 09/08/2011 22:15, Øyvind Harboe wrote: Any

Re: [Openocd-development] GDB notification of processor reset

2011-08-30 Thread Andreas Fritiofson
On Sat, Aug 27, 2011 at 12:43 AM, Evan Hunter e...@ozhiker.com wrote: Hi All, ** ** I've noticed that if my processor gets reset whilst debugging a program, GDB knows nothing about it. I would have thought GDB should stop, in a similar way as hitting a breakpoint. ** ** Is

Re: [Openocd-development] Errors encountered programming an FPGA using 13MB SVF file

2011-08-26 Thread Andreas Fritiofson
On Fri, Aug 26, 2011 at 7:10 PM, Sam Jansen sam.jan...@starleaf.com wrote: ** Hello, In attempting to use openocd with an Amontec JTAG key to program a Xilinx FPGA, I encountered a series of issues I though others might be interested in. I don't have sensible proposed solutions for any of

Re: [Openocd-development] Errors encountered programming an FPGA using 13MB SVF file

2011-08-26 Thread Andreas Fritiofson
On Fri, Aug 26, 2011 at 8:51 PM, Sam Jansen sam.jan...@starleaf.com wrote: ** On 26/08/11 19:18, Andreas Fritiofson wrote: On Fri, Aug 26, 2011 at 7:10 PM, Sam Jansen sam.jan...@starleaf.comwrote: At this stage I got the libftdi driver giving the same error message as the libftd2xx driver

Re: [Openocd-development] [PATCH] fix cross compilation: host libsub was used before

2011-08-23 Thread Andreas Fritiofson
On Mon, Aug 22, 2011 at 9:10 PM, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On 19:35 Tue 09 Aug , Jean-Christophe PLAGNIOL-VILLARD wrote: tested in buildroot any comments? Spelling error: + LDFLAGS=$LFFLAGS $LIBUSB_LDFLAGS I'm pretty sure I've seen some hard

Re: [Openocd-development] [PATCH] A fix (was Re: Git revision string missing from banner)

2011-08-16 Thread Andreas Fritiofson
On Tue, Aug 16, 2011 at 4:19 PM, Jie Zhang jzhang...@gmail.com wrote: On Mon, Aug 15, 2011 at 6:21 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: +if test -f $srcdir/guess-rev.sh ; then Great, but you should probably check if it's executable instead of just a regular file

Re: [Openocd-development] [PATCH] A fix (was Re: Git revision string missing from banner)

2011-08-15 Thread Andreas Fritiofson
On Mon, Aug 15, 2011 at 5:03 PM, Jie Zhang jzhang...@gmail.com wrote: On Mon, Aug 15, 2011 at 9:35 AM, Spencer Oliver s...@spen-soft.co.uk wrote: On 15 August 2011 14:22, Eric Wetzel thewet...@gmail.com wrote: if test $cross_compiling = no; then # guess-rev.sh only exists in the

Re: [Openocd-development] Please welcome Andreas Fritiofson as a new OpenOCD maintainer!

2011-08-12 Thread Andreas Fritiofson
Thank you all for the encouraging comments! I've been an OpenOCD user and followed the project several years now and watched it getting better and better. I'm excited to join the maintainer crew, taking a closer part in that positive progress. I'll start by getting acquainted with the procedures

[Openocd-development] [PULL Request] RLink interface speedup and fixes

2011-08-09 Thread Andreas Fritiofson
The following changes since commit 194e3c5bc5e0fbb7d41cfcbe913c4264782cdd5b: Rodrigo L. Rosa (1): fix tapenabler return code are available in the git repository at: http://repo.or.cz/r/openocd/andreasf.git rlink Andreas Fritiofson (7): rlink: fix indentation errors rlink

Re: [Openocd-development] [PULL Request] Flash program speedup through asynchronous algorithms

2011-08-09 Thread Andreas Fritiofson
On Wed, Aug 10, 2011 at 12:01 AM, Spencer Oliver s...@spen-soft.co.ukwrote: On 09/08/2011 22:15, Øyvind Harboe wrote: Any objections? I would like to give this a test-run tomorrow. One observation - other targets that do not yet support the new functions will output a LOG_ERROR to the

Re: [Openocd-development] Tags

2011-08-05 Thread Andreas Fritiofson
On Fri, Aug 5, 2011 at 8:56 AM, Øyvind Harboe oyvind.har...@zylin.comwrote: When I run git describe now I get v0.4.0-973-g0d7a948 rather than a v0.5.0-rc2-. Is that intentional? I think it's nice that we stick to v0.4.0- until v0.5.0- goes out of the door. I have no

Re: [Openocd-development] Tags

2011-08-05 Thread Andreas Fritiofson
On Fri, Aug 5, 2011 at 11:02 AM, Spencer Oliver s...@spen-soft.co.ukwrote: On 5 August 2011 09:58, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Fri, Aug 5, 2011 at 8:56 AM, Øyvind Harboe oyvind.har...@zylin.com wrote: When I run git describe now I get v0.4.0-973

Re: [Openocd-development] Tags

2011-08-05 Thread Andreas Fritiofson
On Fri, Aug 5, 2011 at 11:26 AM, Spencer Oliver s...@spen-soft.co.ukwrote: Release tags are annotated, but not rc tags Oh, but they are, or am I completely oblivious of git tags (quite possible)? $ git checkout v0.4.0-rc2~2 $ git describe v0.4.0-rc1-193-g747a607

Re: [Openocd-development] [PATCH] Automatically generate ChangeLog from git log for release tarball

2011-08-03 Thread Andreas Fritiofson
On Wed, Aug 3, 2011 at 12:28 PM, Luca Bruno lu...@debian.org wrote: Andreas Fritiofson scrisse: make dist should use git2cl to genereate ChangeLog from git history, populating the placeholder file in released tarball. Still not working for srcdir != builddir make[1]: Entering

Re: [Openocd-development] Last call before release

2011-08-03 Thread Andreas Fritiofson
On Wed, Aug 3, 2011 at 3:32 PM, Tomek CEDRO tomek.ce...@gmail.com wrote: Hello Jean, please provide full featured RC package (generated by make distcheck, containing configure scripts) to test it on FreeBSD, as for now bootstrap fails, so the status is no-go. Best regards, Tomek Yes, we

Re: [Openocd-development] [OpenOCD][PULL Request][MIPS32] Fixed single byte memory write

2011-07-30 Thread Andreas Fritiofson
On Sat, Jul 30, 2011 at 4:26 AM, Mahr, Stefan stefan.m...@sphairon.comwrote: Hi Drasko. Drasko DRASKOVIC (1): mips32 : Fixed memory byte access Your patch fixes the broken byte access, but not the big endian host issue. Since both problems are tied together, I would prefer a more

Re: [Openocd-development] OpenOCD 0.5.0-rc2 release

2011-07-30 Thread Andreas Fritiofson
On Sat, Jul 30, 2011 at 7:10 PM, Tomek CEDRO tomek.ce...@gmail.com wrote: Hello! :-) Trying to bootstrap on FreeBSD 8.2-RELEASE fails with the 0.5.0-rc2 as given at:

Re: [Openocd-development] [PATCH 3/4] cfg: update scripts to use new stm32 driver names

2011-07-29 Thread Andreas Fritiofson
On Thu, Jul 28, 2011 at 1:52 PM, Spencer Oliver s...@spen-soft.co.ukwrote: delete mode 100644 tcl/target/stm32.cfg delete mode 100644 tcl/target/stm32f2xxx.cfg For compatibility with existing user scripts, it would be best to keep these files during the 0.5.x period. Just make them print a

Re: [Openocd-development] [PATCH 3/4] cfg: update scripts to use new stm32 driver names

2011-07-29 Thread Andreas Fritiofson
On Fri, Jul 29, 2011 at 4:09 PM, Spencer Oliver s...@spen-soft.co.ukwrote: On 29 July 2011 14:54, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Thu, Jul 28, 2011 at 1:52 PM, Spencer Oliver s...@spen-soft.co.uk wrote: delete mode 100644 tcl/target/stm32.cfg delete mode

Re: [Openocd-development] [PATCH 3/4] cfg: update scripts to use new stm32 driver names

2011-07-29 Thread Andreas Fritiofson
On Fri, Jul 29, 2011 at 5:38 PM, Spencer Oliver s...@spen-soft.co.ukwrote: On 29 July 2011 15:43, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: That one won't help for all scripts out there that are currently sourcing target/stm32.cfg. /Andreas Good point - how about http

Re: [Openocd-development] write_image hangs on lpc2138

2011-07-26 Thread Andreas Fritiofson
On Tue, Jul 26, 2011 at 11:25 PM, Steve Franks bahamasfra...@gmail.comwrote: Every year or so I try openocd, and still no joy. Actually, seems the script and config stuff has all finally matured/stabilized, so I'll assume I can make it work w/o too much pain, after I fix this hang: I have a

Re: [Openocd-development] write_image hangs on lpc2138

2011-07-26 Thread Andreas Fritiofson
On Wed, Jul 27, 2011 at 12:22 AM, Steve Franks bahamasfra...@gmail.comwrote: On Tue, Jul 26, 2011 at 3:06 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: 0.4.0 is rather old, you may be seeing a bug that has already been fixed. Grab the latest version from the repo and give

Re: [Openocd-development] [PATCH 0/7] RLink interface speedup, and fixes

2011-07-22 Thread Andreas Fritiofson
On Fri, Jul 22, 2011 at 12:29 AM, Peter Horn peter.h...@bluewin.ch wrote: Am 19.07.2011 22:43, schrieb Peter Horn: Last time I've used OpenOCD with RLink stepping was awfully slow, about 3 seconds or more per step. This was some weeks ago and on Windows / Mingw. On Linux, stepping is

Re: [Openocd-development] [PATCH 0/7] RLink interface speedup, and fixes

2011-07-22 Thread Andreas Fritiofson
On Fri, Jul 22, 2011 at 11:59 AM, Peter Horn peter.h...@bluewin.ch wrote: Patches 1/7 to 4/7 work ok, the problem is caused by patch 5/7 On Windows using the embedded RLink, OpenOCD: Open On-Chip Debugger 0.5.0-dev-snapshot (2011-07-21-07:10) Licensed under GNU GPL v2

Re: [Openocd-development] Problem with OpenOCD 0.5.0-rc1 and STM32 verify_image

2011-07-22 Thread Andreas Fritiofson
On Fri, Jul 22, 2011 at 4:57 PM, Freddie Chopin freddie_cho...@op.plwrote: On 2011-07-21 23:02, Andreas Fritiofson wrote: However I can't explain Freddie's reproduced failures. Maybe post the hex files (matching, slightly different and very different) and I can see if I can take a closer

Re: [Openocd-development] [PATCH 0/7] RLink interface speedup, and fixes

2011-07-22 Thread Andreas Fritiofson
On Fri, Jul 22, 2011 at 2:55 PM, Peter Horn peter.h...@bluewin.ch wrote: Am 22.07.2011 13:36, schrieb Andreas Fritiofson: I don't see how this error could be caused by my patches. If I'm not mistaken, none of them have run at this point. It fails during init, and that code is unchanged

Re: [Openocd-development] SRST TRST have to be buffered?

2011-07-22 Thread Andreas Fritiofson
On Fri, Jul 8, 2011 at 1:19 AM, Matthew Lai cyberf...@wecheer.com wrote: Hello! I'm trying to embed a FT2232D based programmer into my board with a STM32 (Cortex-M3 MCU). I want the programmer to be compatible with jtagkey, so I looked at schematics of compaible designs. I noticed that

Re: [Openocd-development] Problem with OpenOCD 0.5.0-rc1 and STM32 verify_image

2011-07-21 Thread Andreas Fritiofson
On Thu, Jul 21, 2011 at 10:44 PM, Magnus S. mankk...@yahoo.se wrote: Freddie Chopin freddie_chopin@... writes: I can partially confirm... Tested with 0.5.0-rc1 Comparing with right image works fine: Comparing with almost right image (compilation date inside has changed)

Re: [Openocd-development] [PATCH] Automatically generate ChangeLog from git log for release tarball

2011-07-19 Thread Andreas Fritiofson
On Mon, Jul 18, 2011 at 3:46 PM, Spencer Oliver s...@spen-soft.co.ukwrote: On 17 July 2011 10:18, Luca Bruno lu...@debian.org wrote: make dist should use git2cl to genereate ChangeLog from git history, populating the placeholder file in released tarball. Still not working for srcdir !=

[Openocd-development] [PATCH 0/7] RLink interface speedup and fixes

2011-07-18 Thread Andreas Fritiofson
This patch set fixes some general problems in the RLink interface driver. Most importantly it fixes a performance bug that have been causing decreased throughput. Speed test on a STM32 Primer (STM32F103 platform with built in RLink) with the following openocd.cfg --- source [find

[Openocd-development] [PATCH 1/7] rlink: fix indentation errors

2011-07-18 Thread Andreas Fritiofson
Indentation was inconsistent and some lines not indented at all. Quickfix using Eclipse's auto-indentation. Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/jtag/drivers/rlink.c | 726 +++--- 1 files changed, 363 insertions(+), 363

[Openocd-development] [PATCH 2/7] rlink: more indentation fixes

2011-07-18 Thread Andreas Fritiofson
Remove unnecessary block scopes to reduce indentation level. Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/jtag/drivers/rlink.c | 203 +++--- 1 files changed, 100 insertions(+), 103 deletions(-) diff --git a/src/jtag/drivers

[Openocd-development] [PATCH 3/7] rlink: fix reply counter to enable sending full buffers

2011-07-18 Thread Andreas Fritiofson
dtc_queue.reply_index was wrongly being increased during out scans, causing the queue to be sent before the out buffer was full. This patch increases raw upload speed by 50% or so. Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/jtag/drivers/rlink.c | 16

[Openocd-development] [PATCH 4/7] rlink: remove duplicated code

2011-07-18 Thread Andreas Fritiofson
After the reply_index handling is fixed, there's no need to special case the out scan. Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/jtag/drivers/rlink.c | 28 +--- 1 files changed, 9 insertions(+), 19 deletions(-) diff --git a/src/jtag/drivers

[Openocd-development] [PATCH 5/7] rlink: read only the expected number of bytes

2011-07-18 Thread Andreas Fritiofson
After correcting the reply size counter, it should be safe to rely on it for the number of bytes expected in the USB read, instead of reading the endpoint maximum. This doesn't make things go any faster but it's nicer and removes the local buffer. Signed-off-by: Andreas Fritiofson andreas.fritiof

[Openocd-development] [PATCH 6/7] rlink: remove redundant text from log messages

2011-07-18 Thread Andreas Fritiofson
__FILE__ and __LINE__ are already printed using the log macros. Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/jtag/drivers/rlink.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/jtag/drivers/rlink.c b/src/jtag/drivers/rlink.c

[Openocd-development] [PATCH 7/7] rlink: simplify and optimize queue fill level checks

2011-07-18 Thread Andreas Fritiofson
Add a helper function for running the queue if it would overflow otherwise. Use it to simplify the queue fill level checks and optimize in a few cases that would previously run the queue prematurely. Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/jtag/drivers/rlink.c

[Openocd-development] [PATCH 0/5] Flash program speedup through asynchronous algorithms

2011-07-18 Thread Andreas Fritiofson
This patch set enables targets to implement asynchronous algorithms that can be run in the background while OpenOCD performs other tasks. It also implements async algorithm support for ARMv7-M and enables it for the Cortex-M3 target. The final two patches rewrites the stm32x flash driver to use an

[Openocd-development] [PATCH 1/5] target: add async algorithm entries to the target type

2011-07-18 Thread Andreas Fritiofson
the algorithm is flashing the current. Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/target/target.c | 75 ++ src/target/target.h | 22 + src/target/target_type.h |2 + 3 files changed, 99 insertions(+), 0

[Openocd-development] [PATCH 2/5] armv7m: implement async algorithm functions

2011-07-18 Thread Andreas Fritiofson
Split armv7m_run_algorithm into two pieces and use them to reimplement it. The arch_info parameter is used to keep context between the two calls, so both calls must refer to the same armv7m_algorithm struct. Ugly but works for a proof-of-concept. Signed-off-by: Andreas Fritiofson andreas.fritiof

[Openocd-development] [PATCH 3/5] cortex_m3: use armv7m's async algorithm implementation

2011-07-18 Thread Andreas Fritiofson
Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/target/cortex_m3.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/target/cortex_m3.c b/src/target/cortex_m3.c index 98a775c..a2f8b78 100644 --- a/src/target/cortex_m3.c +++ b/src/target/cortex_m3

[Openocd-development] [PATCH 4/5] stm32x: use register base instead of register offset

2011-07-18 Thread Andreas Fritiofson
Access the different flash banks' registers using a bank specific register base and a register specific offset. This is equivalent but feels more natural. Some accesses were discovered that maybe should not be hard coded to bank0 registers. Add a note about that. Signed-off-by: Andreas

[Openocd-development] [PATCH 5/5] stm32x: use async algorithm in flash programming routine

2011-07-18 Thread Andreas Fritiofson
accesses (really inefficient) and algorithm uploads caused the flash programming to be latency bound in many cases. Now it should scale better with increased throughput. Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- contrib/loaders/flash/stm32x.S | 71 -- src/flash

Re: [Openocd-development] [PATCH 0/7] RLink interface speedup and fixes

2011-07-18 Thread Andreas Fritiofson
On Mon, Jul 18, 2011 at 4:03 PM, Spencer Oliver s...@spen-soft.co.ukwrote: On 18 July 2011 11:13, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: This patch set fixes some general problems in the RLink interface driver. Most importantly it fixes a performance bug that have been

Re: [Openocd-development] [PATCH 0/7] RLink interface speedup and fixes

2011-07-18 Thread Andreas Fritiofson
On Mon, Jul 18, 2011 at 2:33 PM, Tomek CEDRO tomek.ce...@gmail.com wrote: Hello Andreas! Do you know what is the difference between JTAG (on Stm32Primer) and SWD (on Stm32Primer2) RLink interface? Would they run on existing driver? Do you have some kind of manual or technical specification?

Re: [Openocd-development] [PATCH 0/7] RLink interface speedup and fixes

2011-07-18 Thread Andreas Fritiofson
On Mon, Jul 18, 2011 at 4:59 PM, Jean-Claude Repetto jcr...@mxm.eu wrote: Le 18/07/2011 16:25, Andreas Fritiofson a écrit : Yes it's best to put these on hold for 0.5.0. It needs some testing on the standalone RLink or other variants, I currently only have access to STM32 Primers. Also more

Re: [Openocd-development] MIPS target, big endian host

2011-07-08 Thread Andreas Fritiofson
On Fri, Jul 8, 2011 at 12:52 PM, Øyvind Harboe oyvind.har...@zylin.comwrote: What puzzles me is that there is no warning on x86, even if I the -Wcast-align option is there -Wcast-align Warn whenever a pointer is cast such that the required alignment of the target is increased.

Re: [Openocd-development] MIPS target, big endian host

2011-07-08 Thread Andreas Fritiofson
On Fri, Jul 8, 2011 at 1:17 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: I am just wandering, would : t32 = *(uint32_t*)((void *)buffer[i]); quite the compiler ;) Yes probably, but it would still crash on an architecture that doesn't support unaligned accesses. /Andreas

Re: [Openocd-development] MIPS target, big endian host

2011-07-08 Thread Andreas Fritiofson
On Fri, Jul 8, 2011 at 1:38 PM, Mahr, Stefan stefan.m...@sphairon.comwrote: are you sure about this ? It seems to me that buffer[i] is directly filled by target, and I see no reason that it is in the host endianess... Hi Drasko, Yes I'm sure. I tested it on my big endian host

Re: [Openocd-development] MIPS target, big endian host

2011-07-08 Thread Andreas Fritiofson
On Fri, Jul 8, 2011 at 2:05 PM, Mahr, Stefan stefan.m...@sphairon.comwrote: Where are those functions defined and how do they know what the target endianness is? They doesn't know the target endianness, but host endianness. It sounds a little strange to do the swapping at this low level.

Re: [Openocd-development] MIPS target, big endian host

2011-07-08 Thread Andreas Fritiofson
On Fri, Jul 8, 2011 at 2:05 PM, Mahr, Stefan stefan.m...@sphairon.comwrote: Where are those functions defined and how do they know what the target endianness is? They doesn't know the target endianness, but host endianness. You can't convert between target and host endianness if you don't

Re: [Openocd-development] MIPS target, big endian host

2011-07-08 Thread Andreas Fritiofson
On Fri, Jul 8, 2011 at 1:26 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: On Fri, Jul 8, 2011 at 1:19 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: I looked briefly at the memory read functions in mips32_dmaacc.c and mips32_pracc.c and it looks like the type usage

Re: [Openocd-development] MIPS target, big endian host

2011-07-06 Thread Andreas Fritiofson
On Wed, Jul 6, 2011 at 11:35 PM, Øyvind Harboe oyvind.har...@zylin.comwrote: On Wed, Jul 6, 2011 at 11:28 PM, Mahr, Stefan stefan.m...@sphairon.com wrote: mips32_pracc_read_mem casts uint32 to void, so we need to cast it back to uint32. I found no suitable macro in actual sources.

Re: [Openocd-development] eclipse indigo (pipe usage)

2011-07-06 Thread Andreas Fritiofson
On Fri, Jul 1, 2011 at 12:47 PM, Spencer Oliver s...@spen-soft.co.ukwrote: On 1 July 2011 00:41, Andrew Leech coronasen...@gmail.com wrote: One other point, do you know whether you can get openocd to add it's own program directory to the search path for the source [find ...] lines? It'd

Re: [Openocd-development] compiler warnings with dsp5680xx.c

2011-06-29 Thread Andreas Fritiofson
On Wed, Jun 29, 2011 at 9:17 PM, Rodrigo Rosa rodrigorosa...@gmail.comwrote: On Wed, Jun 29, 2011 at 12:44 AM, Øyvind Harboe oyvind.har...@zylin.com wrote: This is disturbing. Why switch to global variables? +static uint32_t data_read_dummy; static int jtag_data_write(struct target *

Re: [Openocd-development] USB Blaster support broken

2011-06-28 Thread Andreas Fritiofson
On Tue, Jun 28, 2011 at 9:19 AM, Domien Nowicki domien.nowi...@gmail.comwrote: ** 1. The USB Blaster clone does not use the original FT245 chip, and so it tries to emulate its behavior. As it turns out, the API call FT_GetLatencyTimer is not properly emulated by the clone, and this makes

Re: [Openocd-development] Cortex M3: Patch for automatic handling of interrupt mask during stepping

2011-06-18 Thread Andreas Fritiofson
Great, but does it really work? There has been discussions about this on this list in the past. I think the conclusion was that there's no way to robustly know GDB's intentions based on the remote commands. When you do a source-level step in GDB, it may send a step command to OpenOCD. Then we can

Re: [Openocd-development] Cortex M3: Patch for automatic handling of interrupt mask during stepping

2011-06-18 Thread Andreas Fritiofson
Resending, Cc to the list got lost somewhere... On Sat, Jun 18, 2011 at 8:27 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Sat, Jun 18, 2011 at 6:38 PM, Peter Horn peter.h...@bluewin.ch wrote: Hi Andreas Am 18.06.2011 17:32, schrieb Andreas Fritiofson: Great, but does

Re: [Openocd-development] [PATCH] transport selection fix

2011-06-16 Thread Andreas Fritiofson
On Thu, Jun 16, 2011 at 8:02 PM, Tomek CEDRO tomek.ce...@gmail.com wrote: On Thu, Jun 16, 2011 at 5:50 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: I take it is just a bugfix? Yes - it changes: retval = allow_transports(CMD_CTX, jtag_interface-transports ? : jtag_only); into:

Re: [Openocd-development] [PATCH] ft2232: fix memory leak in ft2232_large_scan()

2011-06-09 Thread Andreas Fritiofson
On Thu, Jun 9, 2011 at 8:40 AM, Øyvind Harboe oyvind.har...@zylin.comwrote: Definitely! I'm holding off on this patch in favor of a patch that deletes cruft instead of decorating it :-) I have a soft spot for patches that delete code that nobody understands IF the function is

Re: [Openocd-development] Outstanding patches = Fix: Correctly exit function: ft2232_init when an error occurred

2011-06-09 Thread Andreas Fritiofson
On Thu, Jun 9, 2011 at 9:06 AM, Øyvind Harboe oyvind.har...@zylin.comwrote: On Thu, Jun 9, 2011 at 7:29 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: Nit, the construct below is a little bit fancy. I'd prefer splitting it over multiple lines to make it more accessible to the

Re: [Openocd-development] [PATCH 1/5] ft2232: Clean up infinite loop condition in ft2232_init()

2011-06-09 Thread Andreas Fritiofson
On Thu, Jun 9, 2011 at 12:12 PM, Peter Stuge pe...@stuge.se wrote: - for (int i = 0; 1; i++) + for (int i = 0; ft2232_vid[i] || ft2232_pid[i]; i++) What's the point? This condition can never become false, or the function would have returned in the previous iteration. /Andreas

Re: [Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-09 Thread Andreas Fritiofson
On Thu, Jun 9, 2011 at 12:25 PM, Peter Stuge pe...@stuge.se wrote: + retval = ft2232_initone(ft2232_vid[i], ft2232_pid[i], more, try_more); This is a good start, but what's with the function name?? How about ft2232_init_{device,interface,ftdilib,hardware,handle,whatever}

Re: [Openocd-development] [PATCH 3/5] ft2232: Clean up on ft2232_init() errors after a device has been opened

2011-06-09 Thread Andreas Fritiofson
This together with patch 5/5 is equivalent to my patch, only with gotos. Both patches are perfectly fine with me, although I prefer getting rid of the forward declaration as well. /Andreas ___ Openocd-development mailing list

Re: [Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-09 Thread Andreas Fritiofson
On Fri, Jun 10, 2011 at 12:26 AM, Peter Stuge pe...@stuge.se wrote: Andreas Fritiofson wrote: + retval = ft2232_initone(ft2232_vid[i], ft2232_pid[i], more, try_more); This is a good start, but what's with the function name?? Short. And one from one device

Re: [Openocd-development] Outstanding patches = Fix: Correctly exit function: ft2232_init when an error occurred

2011-06-09 Thread Andreas Fritiofson
On Thu, Jun 9, 2011 at 10:17 PM, Tomek CEDRO tomek.ce...@gmail.com wrote: Hello Laurent! :-) On Thu, Jun 9, 2011 at 6:21 AM, Laurent Gauch laurent.ga...@amontec.com wrote: But before to close the handle we should still be able : -1- to tristate signal High-Z via all the out enable signals

Re: [Openocd-development] Outstanding patches = Fix: Correctly exit function: ft2232_init when an error occurred

2011-06-09 Thread Andreas Fritiofson
On Fri, Jun 10, 2011 at 1:40 AM, Tomek CEDRO tomek.ce...@gmail.com wrote: Hello Andreas :-) On Thu, Jun 9, 2011 at 11:30 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: I have created simple quit() that sets all port pins high and as input (mpsse command 0x80 0x82) but that did

[Openocd-development] ft2232 layout refactoring plans

2011-06-09 Thread Andreas Fritiofson
Hi all! The recent activity surrounding the ft2232 driver makes it obvious that there are lots of bugfixes and structural improvements that need to be done. Unfortunately, trying to understand the code or even just browsing around in it is complicated by the fact that its cluttered with functions

Re: [Openocd-development] Outstanding patches = Fix: Correctly exit function: ft2232_init when an error occurred

2011-06-09 Thread Andreas Fritiofson
On Fri, Jun 10, 2011 at 2:18 AM, Tomek CEDRO tomek.ce...@gmail.com wrote: On Thu, Jun 9, 2011 at 11:46 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: Setting the FTDI pins to Hi-Z is not necessarily the same as setting the pins in the JTAG connector to Hi-Z. There is arbitrary

Re: [Openocd-development] ft2232 layout refactoring plans

2011-06-09 Thread Andreas Fritiofson
On Fri, Jun 10, 2011 at 2:36 AM, Tomek CEDRO tomek.ce...@gmail.com wrote: Uhm, from what I understand LAYOUT is only used for initialization of specific device based on FT*232 device, maybe other minor stuff, all work is done in fact by queue_flush() and it is common for all devices as it

Re: [Openocd-development] Outstanding patches = Fix: Correctly exit function: ft2232_init when an error occurred

2011-06-08 Thread Andreas Fritiofson
On Tue, Jun 7, 2011 at 5:19 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: I suggest to drop this patch and merge a simpler fix for the problem adressed by this patch. Only a few lines of code would need to change. Attached is such a patch. The benefit over Tomek's patch

[Openocd-development] [PATCH] ft2232: fix memory leak in ft2232_large_scan()

2011-06-08 Thread Andreas Fritiofson
anywhere. Maybe the entire function is flawed, or is the data really supposed to be discarded? Signed-off-by: Andreas Fritiofson andreas.fritiof...@gmail.com --- src/jtag/drivers/ft2232.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/jtag/drivers/ft2232.c b

  1   2   >