[devel] [PATCH 1/1] fmd: prevent data races between MDS and main threads [#2763]

--- src/fm/fmd/fm_cb.h| 89 ++- src/fm/fmd/fm_main.cc | 32 +- src/fm/fmd/fm_mds.cc | 27 src/fm/fmd/fm_mds.h | 2 ++ 4 files changed, 79 insertions(+), 71 deletions(-) diff --git a/src/fm/fmd/fm_cb.h

[devel] [PATCH 0/1] Review Request for osaf: add retry loop to IsWritable [#2774]

revision ea6806eee1b1cbd854d5fb64cb668c24d80f743a Author: Gary Lee <gary@dektech.com.au> Date: Wed, 31 Jan 2018 16:42:35 +1100 osaf: add retry loop to IsWritable [#2774] Sometimes a set fails if the underlying key-value store is 'busy', particuarly when there are network topology changes occurring.

[devel] [PATCH 1/1] osaf: add retry loop to IsWritable [#2774]

Sometimes a set fails if the underlying key-value store is 'busy', particuarly when there are network topology changes occurring. We should retry a few times, before returning not writable. --- src/osaf/consensus/consensus.cc | 8 1 file changed, 8 insertions(+) diff --git

[devel] [PATCH 1/1] fmd: indent to Google style guide [#2763]

ran 'clang-format -style=Google' on fmd files no other changes made --- src/fm/fmd/fm.h | 50 +- src/fm/fmd/fm_amf.cc | 457 src/fm/fmd/fm_amf.h |2 +- src/fm/fmd/fm_cb.h|8 +- src/fm/fmd/fm_main.cc | 1388 +++

[devel] [PATCH 0/1] Review Request for fmd: indent to Google style guide [#2763]

y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision a00236279afaa39d041ad8c67ece0abaec2f4005 Author: Gary

[devel] Review Request for doc: update overview PR for split brain prevention with consensus service [#64]

Hi I have updated the OpenSAF Overview PR document for ticket #64. Please have a look. https://sourceforge.net/p/opensaf/tickets/_discuss/thread/0d47d4b9/5489/attachment/OpenSAF_Overview_PR.odt Thanks Gary -- Check

Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention V2 [#64]

is up Should be - isolating the network of the standby controller for a short duration (ie seconds). And variations of the active / standby controller residing in the split network partition with/without quorum. On 25/1/18, 5:55 pm, "Gary Lee" <gary@dektech.com.au> wro

Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention V2 [#64]

ge- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Friday, January 19, 2018 5:09 PM To: hans.nordeb...@ericsson.com; anders.wid...@ericsson.com; quyen@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 0/5] Review Request for Add s

Re: [devel] [PATCH 2/5] rded: add split brain prevention support [#64]

Hi Anders Will change according to your comments, one comment below: On 24/01/18 01:53, Anders Widell wrote: Ack for this patch with comments, marked AndersW> regards, Anders Widell +   case RDE_MSG_NEW_ACTIVE_CALLBACK: +  { +    const std::string my_node = base::Conf::NodeName();

Re: [devel] [PATCH 1/5] osaf: add consensus API [#64]

sus. Currently, the files are added in this patch but Makefile.am is updated in patch number 5, so the Makefile.am updates should be moved to this patch. regards, Anders Widell On 01/23/2018 09:06 AM, Gary Lee wrote: ---   src/osaf/consensus/Makefile  |  18 +++   src/osaf/consen

Re: [devel] [PATCH 5/5] doc: update README and makefiles [#64]

Hi One comment from Quyen about the readme. Revised paragraph below, please see [Gary]. On 23/01/18 19:06, Gary Lee wrote: --- 00-README.conf | 56 Makefile.am | 4 +++- src/osaf/Makefile.am | 8 ++-- 3 files

[devel] [PATCH 5/5] doc: update README and makefiles [#64]

--- 00-README.conf | 56 Makefile.am | 4 +++- src/osaf/Makefile.am | 8 ++-- 3 files changed, 65 insertions(+), 3 deletions(-) diff --git a/00-README.conf b/00-README.conf index a8848e632..6c3cff1dd 100644 ---

[devel] [PATCH 4/5] fmd: update consensus service during controller failover [#64]

--- src/fm/Makefile.am| 1 + src/fm/fmd/fm_main.cc | 37 +++-- src/fm/fmd/fm_rda.cc | 13 + src/fm/fmd/fmd.conf | 6 ++ 4 files changed, 51 insertions(+), 6 deletions(-) diff --git a/src/fm/Makefile.am b/src/fm/Makefile.am index

[devel] [PATCH 1/5] osaf: add consensus API [#64]

--- src/osaf/consensus/Makefile | 18 +++ src/osaf/consensus/keyvalue.cc | 221 ++ src/osaf/consensus/keyvalue.h| 66 src/osaf/consensus/plugins/etcd.plugin | 253 ++

[devel] [PATCH 2/5] rded: add split brain prevention support [#64]

* consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed (if remote fencing is disabled) --- src/rde/Makefile.am | 3 ++- src/rde/rded/osaf-rded.in | 4 src/rde/rded/rde_cb.h | 4 +++-

[devel] [PATCH 0/5] Review Request for Add support for split brain prevention V3 [#64]

or threads revision 39f15d483557e6b6623d9ccdab1bb5f02599d95d Author: Gary Lee <gary@dektech.com.au> Date: Tue, 23 Jan 2018 18:58:50 +1100 doc: update README and makefiles [#64] revision 9d31819b0c3e831372e58b56a311509b76c68634 Author: Gary Lee <gary@dektech.com.au> Date: Tue

[devel] [PATCH 3/5] amfd: update consensus service when performing SI swap [#64]

When a node goes down and split-brain prevention is enabled, check that we still have write access to the consensus service. If not and fencing is disabled, reboot the node to prevent split brain. --- src/amf/amfd/ndproc.cc| 12 +++- src/amf/amfd/osaf-amfd.in | 4

Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention V2 [#64]

HI Anders/Hans On 20/01/18 00:56, Anders Widell wrote: Ack from me also, with comments: * I think my major comment is that I had originally envisioned that you would use the "etcdctl lock" command (in the V3 API) and that the active SC would hold the lock for as long as it is active. The

Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention V2 [#64]

Hi Hans I will respond to your questions in another reply. On 19/01/18 23:47, Hans Nordebäck wrote: - In Consensus::FenceNode, UINT_MAX is used as argument to opensaf_reboot, do this work? [Gary] Yes, I called opensaf_reboot with UINT_MAX and it worked with stonith. Thanks Gary

[devel] [PATCH 4/5] fmd: update consensus service during controller failover [#64]

--- src/fm/Makefile.am| 1 + src/fm/fmd/fm_main.cc | 37 +++-- src/fm/fmd/fm_rda.cc | 28 src/fm/fmd/fmd.conf | 8 4 files changed, 68 insertions(+), 6 deletions(-) diff --git a/src/fm/Makefile.am b/src/fm/Makefile.am

[devel] [PATCH 5/5] doc: update README and makefiles [#64]

--- 00-README.conf | 56 Makefile.am | 4 +++- src/osaf/Makefile.am | 8 ++-- 3 files changed, 65 insertions(+), 3 deletions(-) diff --git a/00-README.conf b/00-README.conf index 5de286225..007872d98 100644 ---

[devel] [PATCH 3/5] amfd: update consensus service when performing SI swap [#64]

When a node goes down and split-brain prevention is enabled, check that we still have write access to the consensus service. If not and fencing is disabled, reboot the node to prevent split brain. --- src/amf/amfd/ndproc.cc| 12 +++- src/amf/amfd/osaf-amfd.in | 4

[devel] [PATCH 2/5] rded: add split brain prevention support [#64]

* consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed (if remote fencing is disabled) --- src/rde/Makefile.am | 3 ++- src/rde/rded/osaf-rded.in | 4 src/rde/rded/rde_cb.h | 3 ++-

[devel] [PATCH 0/5] Review Request for Add support for split brain prevention V2 [#64]

fixed most cppcheck/cpplint errors in osaf/consensus * disable self-fencing if remote-fencing is enabled * reboot active controller if it loses quorum (write access) * better error handling revision 7ab1280243311058a6848c4da2b9738ab73dc861 Author: Gary Lee <gary@dektech.com.au> Date: Fri, 1

[devel] [PATCH 1/5] osaf: add consensus API [#64]

--- src/osaf/consensus/Makefile | 18 ++ src/osaf/consensus/keyvalue.cc | 174 +++ src/osaf/consensus/keyvalue.h| 57 +++ src/osaf/consensus/plugins/etcd.plugin | 220 src/osaf/consensus/plugins/sample.plugin |

Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention with consensus key-value store [#64]

network situation, unless that node has write access to the key-value store. This was suggested by Quyen to minimise cluster disruption. On 17/1/18, 6:59 pm, "Gary Lee" <gary@dektech.com.au> wrote: Hi Thanks, I’ve fixed most of the warnings. I will send

Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention with consensus key-value store [#64]

of the previous line [whitespace/braces] [4] src/osaf/consensus/service.cc:224: { should almost always be at the end of the previous line [whitespace/braces] [4] / Anders Widell On 01/10/2018 06:29 AM, Gary Lee wrote: > Summary: Add support for split brain prevention

Re: [devel] [PATCH 1/5] osaf: add consensus API [#64]

Hi There is one thing that can be improved. In Anders’ proposal, https://sourceforge.net/p/opensaf/tickets/64/attachment/Split-brain%20prevention%20in%20OpenSAF.pdf “When taking over the system controller role, the new active system controller must first acquire the lock, and then wait for a

[devel] [PATCH 1/5] osaf: add consensus API [#64]

--- src/osaf/consensus/Makefile | 18 +++ src/osaf/consensus/keyvalue.cc | 165 ++ src/osaf/consensus/keyvalue.h| 57 src/osaf/consensus/plugins/etcd.plugin | 217 +

[devel] [PATCH 5/5] doc: update README and makefiles [#64]

--- 00-README.conf | 43 +++ Makefile.am | 4 +++- src/osaf/Makefile.am | 8 ++-- 3 files changed, 52 insertions(+), 3 deletions(-) diff --git a/00-README.conf b/00-README.conf index 5de286225..24d583a89 100644 --- a/00-README.conf +++

[devel] [PATCH 4/5] amfd: update consensus service when performing SI swap [#64]

--- src/amf/amfd/osaf-amfd.in | 4 src/amf/amfd/role.cc | 35 ++- 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/src/amf/amfd/osaf-amfd.in b/src/amf/amfd/osaf-amfd.in index 45c5ab9e4..26a77ef52 100644 --- a/src/amf/amfd/osaf-amfd.in +++

[devel] [PATCH 2/5] rded: add split brain prevention support [#64]

* consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed --- src/rde/Makefile.am | 3 ++- src/rde/rded/osaf-rded.in | 4 src/rde/rded/rde_cb.h | 3 ++- src/rde/rded/rde_main.cc | 32

[devel] [PATCH 0/5] Review Request for Add support for split brain prevention with consensus key-value store [#64]

uot; above): - revision 1721faf640efa92950214a516e7f2f33c827c50b Author: Gary Lee <gary@dektech.com.au> Date: Wed, 10 Jan 2018 16:22:19 +1100 doc: update README and makefiles [#64] revision 7882b8fcd5ae5415c04345c2a32c3ff1922e70cc Author: Gary Lee <gary@dektech.com.au> Date: Wed

[devel] [PATCH 3/5] fmd: update consensus service during controller failover [#64]

--- src/fm/Makefile.am| 1 + src/fm/fmd/fm_main.cc | 12 src/fm/fmd/fm_rda.cc | 26 ++ src/fm/fmd/fmd.conf | 8 4 files changed, 47 insertions(+) diff --git a/src/fm/Makefile.am b/src/fm/Makefile.am index d48a9146c..0f254b94f 100644 ---

Re: [devel] [PATCH 0/1] Review Request for consensus: add split brain prevention support [#64]

Please ignore. I will send another patch set with the changes split up for easier commenting. On 10/1/18, 4:01 pm, "Gary Lee" <gary@dektech.com.au> wrote: Summary: consensus: add split brain prevention support [#64] Review request for Ticket(s): 64 Peer Reviewer(

[devel] [PATCH 1/1] consensus: add split brain prevention support [#64]

--- 00-README.conf | 43 ++ Makefile.am | 4 +- src/amf/amfd/osaf-amfd.in| 4 + src/amf/amfd/role.cc | 35 - src/fm/Makefile.am | 1 + src/fm/fmd/fm_main.cc

[devel] [PATCH 0/1] Review Request for consensus: add split brain prevention support [#64]

revision 8fa393fce29e64872c696c2b2fc75461996ef839 Author: Gary Lee <gary@dektech.com.au> Date: Wed, 10 Jan 2018 15:54:31 +1100 consensus: add split brain prevention support [#64] Added Files: src/osaf/consensus/Makefile src/osaf/consensus/keyvalue.cc src/osaf/consensus/keyvalue.h sr

[devel] [PATCH 1/1] fmd: convert to C++ [#2750]

Source files renamed to .cc Apply changes required to compile succesfully with g++ --- src/fm/Makefile.am | 8 src/fm/fmd/fm.h | 2 +- src/fm/fmd/{fm_amf.c => fm_amf.cc} | 6 +++--- src/fm/fmd/fm_cb.h | 4 ++--

[devel] [PATCH 0/1] Review Request for fmd: convert to C++ [#2750]

9b2 Author: Gary Lee <gary@dektech.com.au> Date: Thu, 28 Dec 2017 19:30:57 +1100 fmd: convert to C++ [#2750] Source files renamed to .cc Apply changes required to compile succesfully with g++ Complete diffstat: -- src/fm/Makefile.am | 8

Re: [devel] [PATCH 1/1] amfd: Change LOG_ER to LOG_WA if nodeid is not found in node shutting down [#2737]

Hi Ack (review only) /Gary On 28/12/17, 1:01 pm, "Minh Chau" wrote: --- src/amf/amfd/imm.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index aef988f..f36584b 100644 ---

[devel] [PATCH 1/1] amfnd: do not retrieve runtime attributes [#2582]

amf_saImmOmAccessorGet_o2() would sometimes return TIMEOUT if AMFD is updating a runtime object and IMM PBE is slow, leaving a component in UN-INSTANTIATED state. To fix this, we should only retrieve configuration attributes thus IMM will not have to read from AMFD at all. This also reduces load

[devel] [PATCH 0/1] Review Request for amfnd: do not retrieve runtime attributes [#2582]

revision 362bf779202583d5859367066cca2ade2941162e Author: Gary Lee <gary@dektech.com.au> Date: Thu, 14 Dec 2017 17:35:03 +1100 amfnd: do not retrieve runtime attributes [#2582] amf_saImmOmAccessorGet_o2() would sometimes return TIMEOUT if AMFD is updating a runtime object and IMM PBE is slow, leaving a

[devel] [PATCH 0/1] Review Request for clm: extend timeout to match immadm timeout [#2713]

revision 2efc2722b064526b16c658e638e7e22672f8bf60 Author: Gary Lee <gary@dektech.com.au> Date: Thu, 30 Nov 2017 13:42:51 +1100 clm: extend timeout to match immadm timeout [#2713] Complete diffstat: -- src/clm/apitest/tet_saClmClusterTrack.c | 30 +++--- 1 file change

[devel] [PATCH 1/1] clm: extend timeout to match immadm timeout [#2713]

--- src/clm/apitest/tet_saClmClusterTrack.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/clm/apitest/tet_saClmClusterTrack.c b/src/clm/apitest/tet_saClmClusterTrack.c index 8a8ca89db..b93347e22 100644 ---

Re: [devel] [PATCH 1/1] clm: replace immadm command with admin op call in clm test [#2654]

Hi Zoran Sorry I didn't see this email. Ack (tested and reviewed). /Gary On 26/10/17 02:28, Zoran Milinkovic wrote: Due to long execution of immadm in a separated thread and possible timeout in poll, the executing immadm command for locking, unlocking and shutting down nodes is replaced

[devel] [PATCH 1/1] amfnd: replace flags with class enum [#2672]

Replace complicated checks of is_avd_down and amfd_sync_required with a state. Remove redundant checks of is_avd_down. --- src/amf/amfnd/avnd_cb.h | 13 + src/amf/amfnd/avnd_defs.h | 7 +++ src/amf/amfnd/clc.cc | 40 +++-

[devel] [PATCH 0/1] Review Request for amfnd: replace flags with class enum [#2672]

revision eb1eca590737be2677adf302111d255687091f86 Author: Gary Lee <gary@dektech.com.au> Date: Fri, 10 Nov 2017 16:19:27 +1100 amfnd: replace flags with class enum [#2672] Replace complicated checks of is_avd_down and amfd_sync_required with a state. Remove redundant checks of is_avd_down. C

Re: [devel] [PATCH 1/1] amfnd: Return TRY_AGAIN for pg track start/stop during headless sync [#2660]

Hi Minh Ack (review only) Thanks Gary -Original Message- From: Minh Chau Date: Monday, 6 November 2017 at 1:45 pm To: , , gary Cc: , Minh

Re: [devel] [PATCH 0/1] Review Request for amfnd: do not refresh opensaf components [#2627]

s (indicate scope for each "y" above): - revision e4979b496fa52608bb607cd6f08634df98b23317 Author: Gary Lee <gary@dektech.com.au> Date: Wed, 25 Oct 2017 14:47:49 +1100 amfnd: do not refresh opensaf components [#2627] If an OpenSAF component requir

Re: [devel] [PATCH 1/1] amfd: Add retry mechanism for ClmTrackStart/Stop as job queue [#2631]

Hi Minh ack (review only) Thanks Gary On 31/10/17 09:48, Minh Hon Chau wrote: Hi, Please help to review the patch, do you have any comments ? Thanks, Minh On 20/10/17 09:36, Minh Chau wrote: Currenty amfd does not retry ClmTrackStart/Stop after swicthover if the CLM APIs are still

Re: [devel] [PATCH 0/1] Review Request for amfnd: fix segv in ncs_tmr_stop V2 [#2658]

Hi Hans Ack (reviewed / legacy tests run) Thanks Gary > On 31 Oct 2017, at 1:57 am, Hans Nordeback > wrote: > > Summary: amfnd: fix segv in ncs_tmr_stop V2 [#2658] > Review request for Ticket(s): 2658 > Peer Reviewer(s): Gary, Ravi > Pull request to: > Affected

Re: [devel] [PATCH 1/1] amfnd: fix segv in ncs_tmr_stop [#2658]

-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Opensaf-devel mailing list

Re: [devel] [PATCH 1/1] amfnd: fix segv in ncs_tmr_stop [#2658]

Hi Hans Ack (review only). Would this also do the job? diff --git a/src/amf/amfnd/di.cc b/src/amf/amfnd/di.cc index 61cea97..d678bd4 100644 --- a/src/amf/amfnd/di.cc +++ b/src/amf/amfnd/di.cc @@ -1285,13 +1285,15 @@ void avnd_di_msg_ack_process(AVND_CB *cb, uint32_t mid) { // matching

Re: [devel] [PATCH 1/1] amf: Buffer and resend data req messages in Headless state [#2601]

rue && cb->amfd_sync_required == true /Gary On 26/10/17 19:20, Gary Lee wrote: Hi Ravi ack (review only) Thanks Gary On 26/10/17 18:44, Minh Hon Chau wrote: Hi Ravi, ack from me (legacy test run). Thanks, Minh On 25/10/17 23:03, Ravi Sekhar Reddy Konda wrote: Hi Minh & Gary,

Re: [devel] [PATCH 1/1] amf: Buffer and resend data req messages in Headless state [#2601]

same way of DATA_REQUEST in this ticket too. I can check the D2N_PRESENCE_SU and PG track and raise separated tickets if there're bugs (most likely) The solution of the patch looks ok to me within Gary's comment. Thanks, Minh On 25/10/17 14:58, Gary Lee wrote: Hi Ravi >From what I can see, the main

[devel] [PATCH 0/1] Review Request for amfnd: do not refresh opensaf components [#2627]

revision e4979b496fa52608bb607cd6f08634df98b23317 Author: Gary Lee <gary@dektech.com.au> Date: Wed, 25 Oct 2017 14:47:49 +1100 amfnd: do not refresh opensaf components [#2627] If an OpenSAF component requires reload after an upgrade, then AMF should also be upgraded, requiring a node reboot. Thus there is no

[devel] [PATCH 1/1] amfnd: do not refresh opensaf components [#2627]

If an OpenSAF component requires reload after an upgrade, then AMF should also be upgraded, requiring a node reboot. Thus there is no need to refresh component config. The patch fixes a problem where OpenSAF has been upgraded and is about to be rebooted. Before the reboot occurs, IMMND aborts due

Re: [devel] [PATCH 1/1] amf: Buffer and resend data req messages in Headless state [#2601]

ch by adding queuing for Reg SU response event also Thanks, Ravi -----Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Wednesday, October 18, 2017 10:57 AM To: ravi-sekhar <ravisekhar.ko...@oracle.com>; hans.nordeb...@ericsson.

[devel] [PATCH 0/1] Review Request for amfnd: store pid before sending event [#2650]

revision 65320634c2c77114fbbfa8867a58b8b87b0af80a Author: Gary Lee <gary@dektech.com.au> Date: Mon, 23 Oct 2017 14:14:21 +1100 amfnd: store pid before sending event [#2650] The event may be processed and pm_rec deleted by the main thread, before it is read here. Complete diffstat: -- src/

[devel] [PATCH 1/1] amfnd: store pid before sending event [#2650]

The event may be processed and pm_rec deleted by the main thread, before it is read here. --- src/amf/amfnd/mon.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amf/amfnd/mon.cc b/src/amf/amfnd/mon.cc index 5d5cc2393..9cdfc3797 100644 --- a/src/amf/amfnd/mon.cc +++

Re: [devel] [PATCH 1/1] amf: Buffer and resend data req messages in Headless state [#2601]

Hi Ravi I’ve started looking at this. My initial thought is that perhaps we need to queue up all messages when is_avd_down == false && amfd_sync_required == true (ie. AMFD has come up but haven’t accepted node_up). What do you think? Will get back to you. /Gary -Original Message-

[devel] [PATCH 0/2] Review Request for amf: improve error checking and display [#2628]

revision 51bddf9bfb788f3c86f7ef05addbb954b7e311d2 Author: Gary Lee <gary@dektech.com.au> Date: Tue, 17 Oct 2017 18:04:49 +1100 amf: improve error checking and display [#2628] * nodes are prefixed with '0x', eg '0x2010f' instead of '2010f' to match input * options 's', 'c', 'u' are incompatible and are rejected wh

[devel] [PATCH 2/2] amf: improve error checking and display [#2628]

* nodes are prefixed with '0x', eg '0x2010f' instead of '2010f' to match input * options 's', 'c', 'u' are incompatible and are rejected when used together --- src/amf/tools/amf_cluster_status.cc | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git

[devel] [PATCH 1/2] amf: fix whitespace issues [#2628]

whitespace changes only --- src/amf/tools/amf_cluster_status.cc | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/amf/tools/amf_cluster_status.cc b/src/amf/tools/amf_cluster_status.cc index d54a3d6d6..668e43c01 100644 ---

Re: [devel] [PATCH 1/1] amfnd: change log level to notice for events during node failover/shutdown [#2605]

Hi I will push this on Wednesday if there are no comments. Thanks Gary -Original Message- From: gary Date: Wednesday, 4 October 2017 at 3:21 pm To: , , Ravi Sekhar Reddy Konda

Re: [devel] [PATCH 1/1] amf: Allow SI and SI Dependency object to be deleted in same ccb [#2585]

Hi Ack (review only) Thanks Gary -Original Message- From: Minh Chau Date: Thursday, 28 September 2017 at 10:54 pm To: , gary , , Cc:

[devel] [PATCH 0/1] Review Request for amfnd: change log level to notice for events during node failover [#2605]

uot; above): - revision e940657bfeb76fc2dcbd2ac5e53959d4414152b9 Author: Gary Lee <gary@dektech.com.au> Date: Wed, 4 Oct 2017 15:15:08 +1100 amfnd: change log level to notice for events during node failover/shutdown [#2605] Complete diffstat: -- src/amf/amfnd/clc.cc | 4 ++--

[devel] [PATCH 1/1] amfnd: change log level to notice for events during node failover/shutdown [#2605]

--- src/amf/amfnd/clc.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amf/amfnd/clc.cc b/src/amf/amfnd/clc.cc index c317f093b..c8e60e61b 100644 --- a/src/amf/amfnd/clc.cc +++ b/src/amf/amfnd/clc.cc @@ -783,7 +783,7 @@ uint32_t avnd_comp_clc_fsm_run(AVND_CB *cb,

[devel] [PATCH 1/1] amfd: remove node_up variable from AVD_AVND [#2595]

node_up is not checkpointed. Replace with node_state. --- src/amf/amfd/clm.cc| 6 +++--- src/amf/amfd/ndfsm.cc | 1 - src/amf/amfd/ndproc.cc | 1 - src/amf/amfd/node.cc | 1 - src/amf/amfd/node.h| 1 - 5 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/amf/amfd/clm.cc

[devel] [PATCH 0/1] Review Request for amfd: remove node_up variable from AVD_AVND [#2595]

TCH SERIES HERE *** revision ac3af0a9e971b7a501dc3eda0f4eb07aaad418dc Author: Gary Lee <gary@dektech.com.au> Date: Wed, 27 Sep 2017 15:27:12 +1000 amfd: remove node_up variable from AVD_AVND [#2595] node_up is not checkpointed. Replace with node_state. Complete diffstat: ---

Re: [devel] [PATCH 1/1] amf: Improve SC status change callback style [#2594]

Ack Thanks Gary On 26/9/17, 2:56 pm, "Quyen Dao" wrote: Make SC status change callback style to be consistent with other AMF callbacks * Define an alias named OsafAmfSCStatusChangeCallbackT for the SC status change callback type * Use

[devel] [PATCH 0/1] Review Request for amf: ensure we do not reuse version when calling OpenSAF init functions [#2587]

uot; above): - revision a9dbee80357a9f2748981fdc919ae7edc94c7e42 Author: Gary Lee <gary@dektech.com.au> Date: Fri, 22 Sep 2017 11:18:26 +1000 amf: ensure we do not reuse version when calling OpenSAF init functions [#2587] Complete diffstat: -- src/amf/amfd/imm.cc | 2 +

[devel] [PATCH 1/1] amf: ensure we do not reuse version when calling OpenSAF init functions [#2587]

--- src/amf/amfd/imm.cc | 2 +- src/amf/amfnd/avnd_util.h | 2 +- src/amf/amfnd/util.cc | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index 5e8679c3f..baf646c92 100644 --- a/src/amf/amfd/imm.cc +++

[devel] [PATCH 1/1] amfnd: retry on TIMEOUT in amf_saImmOmAccessorGet_o2 [#2582]

Sometimes immutil_saImmOmAccessorGet_o2 returns TIMEOUT, AMF should retry a few times. --- src/amf/amfnd/util.cc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/amf/amfnd/util.cc b/src/amf/amfnd/util.cc index bca642eac..a41fc338f 100644 --- a/src/amf/amfnd/util.cc +++

[devel] [PATCH 0/1] Review Request for amfnd: retry on TIMEOUT in amf_saImmOmAccessorGet_o2 [#2582]

revision 491503281cc08ad5dbcd64edba10402a491330e8 Author: Gary Lee <gary@dektech.com.au> Date: Mon, 18 Sep 2017 10:10:08 +1000 amfnd: retry on TIMEOUT in amf_saImmOmAccessorGet_o2 [#2582] Sometimes immutil_saImmOmAccessorGet_o2 returns TIMEOUT, AMF should retry a few times. C

Re: [devel] [PATCH 1/1] amfd: harden completed and apply delete callbacks [#2566]

Hi I will push this on Friday, with the changes suggested by Hans, if there are no more comments. Thanks Gary On 6/9/17, 2:19 pm, "Gary Lee" <gary@dektech.com.au> wrote: It is possible for an object to be deleted in IMM, before a standby SC finishes in

Re: [devel] [PATCH 1/1] amfd: Fix compilation error with gcc version > 6.3 [#2577]

Hi Hans Ack (review) Thanks Gary On 8/9/17, 10:39 pm, "Hans Nordeback" wrote: --- src/amf/amfd/sg_nway_fsm.cc | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/amf/amfd/sg_nway_fsm.cc

Re: [devel] [PATCH 1/1] amf: Fix amf_demo program compilation error [#2578]

Hi Hans Ack (review) Thanks Gary On 8/9/17, 10:53 pm, "Hans Nordeback" wrote: --- tools/cluster_sim_uml/build_uml | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/cluster_sim_uml/build_uml b/tools/cluster_sim_uml/build_uml index

Re: [devel] [PATCH 1/1] amfd: harden completed and apply delete callbacks [#2566]

Hi Hans Thanks - will fix before pushing. I didn't realise you added a trace object, nice! Gary On 06/09/17 18:54, Hans Nordebäck wrote: Hi Gary, ack, code review only. Minor comments below. /Thanks HansN On 09/06/2017 06:19 AM, Gary Lee wrote: It is possible for an object

Re: [devel] [PATCH 1/1] amf: Fix incorrect su failover recovery after sc absence [#2569]

Hi Minh ack (not tested) Thanks On 05/09/17 10:21, Minh Chau wrote: If su failover happens just around both SCs go down, the faulty su is auto repaired and can be instantiated during SCs absence period. As result of this, amfnd buffers oper_state(ENABLED) message. Now if su escalates to

Re: [devel] [PATCH 1/1] amfnd: fix opensaf shutdown and active monitoring failure [#2493]

Hi Praveen Ack (reviewed + legacy tests passed) Thanks Gary On 30/8/17, 8:33 pm, "Praveen" wrote: If active monitoring command is wrongly configured by the user, AMF reports fault on NPI component and AMFND restarts it. Since every time active monitoring

[devel] [PATCH 1/1] amfd: harden completed and apply delete callbacks [#2566]

It is possible for an object to be deleted in IMM, before a standby SC finishes initilization. Now, if the related callbacks are processed by the standby late, then unnecessary assertions or null pointer accesses may occur. --- src/amf/amfd/cb.h | 1 + src/amf/amfd/comp.cc

[devel] [PATCH 0/1] Review Request for amfd: harden completed and apply delete callbacks [#2566]

uot; above): - revision 07fba116480e2c661869e083136cfcc9e58bd85f Author: Gary Lee <gary@dektech.com.au> Date: Tue, 5 Sep 2017 15:41:24 +1000 amfd: harden completed and apply delete callbacks [#2566] It is possible for an object to be deleted in IMM, before a sta

[devel] [PATCH 1/1] amfd: harden completed and apply delete callbacks [#2566]

It is possible for an object to be deleted in IMM, before a standby SC finishes initilization. Now, if the related callbacks are processed by the standby late, then unnecessary assertions or null pointer accesses may occur. --- src/amf/amfd/cb.h | 1 + src/amf/amfd/comp.cc

[devel] [PATCH 1/1] amfd: update SI assignment state when SU is added or removed [#2269]

--- src/amf/amfd/sg.cc | 5 + src/amf/amfd/su.cc | 6 ++ 2 files changed, 11 insertions(+) diff --git a/src/amf/amfd/sg.cc b/src/amf/amfd/sg.cc index 8f3590190..986bb 100644 --- a/src/amf/amfd/sg.cc +++ b/src/amf/amfd/sg.cc @@ -1725,6 +1725,11 @@ void avd_sg_add_su(AVD_SU *su) {

[devel] [PATCH 0/1] Review Request for amfd: update SI assignment state when SU is added or removed [#2269]

revision c89b32698927532beab5f3e71fae3115f31ae3ce Author: Gary Lee <gary@dektech.com.au> Date: Fri, 1 Sep 2017 13:50:06 +1000 amfd: update SI assignment state when SU is added or removed [#2269] Complete diffstat: -- src/amf/amfd/sg.cc | 5 + src/amf/amfd/su.cc | 6

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

OK - thanks. Should we push it to release as well? On 31/08/17 15:30, praveen malviya wrote: Hi Gary, ack for part2. I think I did not grep on saAmfSGNumPrefInserviceSUs in all files. I have pushed part1. Please push part2. Thanks Praveen On 31-Aug-17 9:50 AM, Gary Lee wrote: Hi

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

Hi Praveen ack, but I think further changes are required (see attachment). Do you think you could push it today? Thanks Gary On 27/07/17 15:36, Praveen wrote: SG attribute saAmfSGNumPrefAssignedSUs is applicable to N-Way and N-Way Active model. AMF is assigning more than

[devel] [PATCH 1/1] amfnd: remove incorrect assertion [#2565]

It is normal for msg_id to be non-zero when roaming SC is enabled. There is no need to assert. --- src/amf/amfnd/di.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amf/amfnd/di.cc b/src/amf/amfnd/di.cc index cb0847098..e755b7435 100644 --- a/src/amf/amfnd/di.cc +++

[devel] [PATCH 0/1] Review Request for amfnd: remove incorrect assertion [#2565]

revision 0534cd4bf59fe157d6b31302188b741d13b8be93 Author: Gary Lee <gary@dektech.com.au> Date: Mon, 28 Aug 2017 12:49:49 +1000 amfnd: remove incorrect assertion [#2565] It is normal for msg_id to be non-zero when roaming SC is enabled. There is no need to assert. Complete diffstat: -- src/amf/amfnd/

Re: [devel] [PATCH 1/1] amfnd: convert dnd_list to a vector [#1945]

Hi Praveen Yes, thanks for picking that up. I will send another patch. Thanks Gary On 17/8/17, 6:24 pm, "praveen malviya" <praveen.malv...@oracle.com> wrote: Hi Gary, Please find one comment inline with [Praveen]. Thanks Praveen On 05-Jul-17 2

Re: [devel] [PATCH 1/1] amfnd: convert dnd_list to a vector [#1945]

Hi I would like to push this in a week's time if no one has comments. Thanks Gary On 05/07/17 18:45, Gary Lee wrote: --- src/amf/amfnd/avnd_cb.h | 3 +- src/amf/amfnd/avnd_di.h | 36 -- src/amf/amfnd/avnd_mds.h | 11 +- src/amf/amfnd/di.cc | 321

[devel] [PATCH 0/1] Review Request for amfd: postpone deletion of node from node_id_db [#2547]

revision 17c81d07ecac25e34d15b8970355129fa48508ab Author: Gary Lee <gary@dektech.com.au> Date: Mon, 14 Aug 2017 13:30:07 +1000 amfd: postpone deletion of node from node_id_db [#2547] CLM and MDS callbacks are delivered to the main thread via different paths. If a node is restarted quickly, sometimes CLM J

[devel] [PATCH 1/1] amfd: postpone deletion of node from node_id_db [#2547]

CLM and MDS callbacks are delivered to the main thread via different paths. If a node is restarted quickly, sometimes CLM JOIN is processed before the prior MDS down. This means the node will not be able to join the cluster as it is not in node_id_db (deleted in MDS down processing). This patch

[devel] [PATCH 1/1] clm: increase poll timeout for saClmClusterTrack tests [#2531]

--- src/clm/apitest/tet_saClmClusterTrack.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/clm/apitest/tet_saClmClusterTrack.c b/src/clm/apitest/tet_saClmClusterTrack.c index 82d792729..8a8ca89db 100644 ---

[devel] [PATCH 0/1] Review Request for clm: increase poll timeout for saClmClusterTrack tests [#2531]

revision c3954f72d97416b1d7ebcb6c5c61b3602120c444 Author: Gary Lee <gary@dektech.com.au> Date: Fri, 21 Jul 2017 14:13:25 +1000 clm: increase poll timeout for saClmClusterTrack tests [#2531] Complete diffstat: -- src/clm/apitest/tet_saClmClusterTrack.c | 30 +++---

[devel] [PATCH 0/1] Review Request for amfnd: convert dnd_list to a vector [#1945]

n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision fe4cf264725e512cd06b8b65dc7ad57ca7fc326c Author: Gary

[devel] [PATCH 1/1] amfnd: convert dnd_list to a vector [#1945]

--- src/amf/amfnd/avnd_cb.h | 3 +- src/amf/amfnd/avnd_di.h | 36 -- src/amf/amfnd/avnd_mds.h | 11 +- src/amf/amfnd/di.cc | 321 +-- src/amf/amfnd/proxy.cc | 19 ++- src/amf/amfnd/verify.cc | 14 +-- 6 files changed, 167

Re: [devel] [PATCH 1/1] amfd: increase msg priority for node ups [#2510]

Hi I will push this on Friday if there are no comments. Thanks Gary - Message from Gary Lee <gary@dektech.com.au> - Date: Fri, 23 Jun 2017 11:48:14 +1000 From: Gary Lee <gary@dektech.com.au> Subject: [PATCH 1/1] amfd: increase msg priority for nod

Re: [devel] [PATCH 1/3] amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945]

Hi Hans Ack for the series. Minor comment, perhaps compare_sanamet() can be moved to common as amfd already has a copy. Thanks Gary On 14/6/17, 5:17 pm, "Hans Nordebäck" wrote: Hi Praveen, thanks for reviewing, for info, the patch series also implies

<    1   2   3   4   5   6   7   8   9   10   >