[devel] [PATCH 1 of 1] LOG: log_stream_config_change() renames files successfully, but makes return (-1) [#1366]

2015-05-04 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_stream.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) Callers will invoke log_stream_config_chang() @ lgs_stream.c in two cases: 1. Request for old file closing and creating new files if create_files_f parameter sets to TRUE. 2. Just request for

[devel] [PATCH 0 of 1] Review Request for LOG: log_stream_config_change() renames files successfully, but makes return (-1) [#1366]

2015-05-04 Thread Vu Minh Nguyen
Core libraries n Samples n Tests n Other n Comments (indicate scope for each y above): - changeset 61c1f53421e75072237ccde88fac3331dd058cf4 Author: Vu Minh Nguyen vu.m.nguyu

[devel] [PATCH 1 of 1] ntftools: fix ntfsend says --help option is not recognized [#1352]

2015-05-04 Thread Vu Minh Nguyen
osaf/tools/safntf/ntfsend/ntfsend.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) The command ntfsend says the --help option is not recognized, even though it actually does print a help text when given this option. This defect occurs as there is no options [--help|-h]

[devel] [PATCH 0 of 1] Review Request for ntftools: ntfsend says --help option is not recognized [#1352]

2015-05-04 Thread Vu Minh Nguyen
y OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each y above): - changeset 2099a928d026d5540e9287ee5eb666ec24678a6e Author: Vu Minh

[devel] [PATCH 0 of 1] Review Request for LOG: Unnable to rename cfg file when changing saLogStreamFileName attribute [#1346]

2015-05-06 Thread Vu Minh Nguyen
OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each y above): - changeset 74a57dba79d6009094c109e30bdb05dab547099b Author: Vu Minh Nguyen

[devel] [PATCH 1 of 1] LOG: Fix unable to rename cfg file when changing saLogStreamFileName attribute [#1346]

2015-05-06 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_imm.c | 36 -- 1 files changed, 29 insertions(+), 7 deletions(-) As expectation, LOG server should close the old cfg file and opening log file, then creating new cfg/log files. But It failed to rename the configuration file. The

[devel] [PATCH 0 of 1] Review Request for ntftools: ntfread and ntfsubscribe do not check invalid options [#1355]

2015-05-05 Thread Vu Minh Nguyen
9982d7c77ad9a1ca265a31d99af0354fafd626a8 Author: Vu Minh Nguyen vu.m.nguyu...@dektech.com.au Date: Tue, 05 May 2015 05:14:44 +0100 ntftool: ntfread and ntfsubscribe do not check invalid options [#1355] ntfread/ntfsubscribe do not check invalid options. Add code to show invalid

[devel] [PATCH 1 of 1] ntftool: ntfread and ntfsubscribe do not check invalid options [#1355]

2015-05-05 Thread Vu Minh Nguyen
osaf/tools/safntf/ntfread/ntfread.c | 7 +++ osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 13 - 2 files changed, 19 insertions(+), 1 deletions(-) ntfread/ntfsubscribe do not check invalid options. Add code to show invalid options to user. diff --git

Re: [devel] [PATCH 1 of 1] ntftool: ntfread and ntfsubscribe do not check invalid options [#1355]

2015-05-20 Thread Vu Minh Nguyen
-Original Message- From: praveen malviya [mailto:praveen.malv...@oracle.com] Sent: Wednesday, May 20, 2015 7:26 PM To: Vu Minh Nguyen; minh.c...@dektech.com.au; lennart.l...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1 of 1] ntftool: ntfread and ntfsubscribe

[devel] [PATCH 0 of 1] Review Request for logsv: Improve memory handling when writing log records [#1376]

2015-06-18 Thread Vu Minh Nguyen
Minh Nguyen vu.m.nguy...@dektech.com.au Date: Thu, 28 May 2015 10:35:24 +0700 logsv: Improve memory handling when writing log records [#1376] Once having request to write log record, LOGSV allocates three separate memories and do copying log record to there. As the result

[devel] [PATCH 1 of 1] tools: Color the failed test cases by Unit Test Framework [#1390]

2015-06-17 Thread Vu Minh Nguyen
tests/unit_test_fw/src/utest.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) If running lots of test cases, it was hard to find the failed ones in the current fw. With this enhancement, the fw uses red color to alert failed ones. diff --git

[devel] [PATCH 0 of 1] Review Request for Color the failed test cases by Unit Test Framework [#1390]

2015-06-17 Thread Vu Minh Nguyen
n Samples n Tests y Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 7c81abcbd0b3848f32a74c33c019b5eaf8141275 Author: Vu Minh Nguyen

[devel] [PATCH 0 of 1] Review Request for ntftest: ntftest suite 22 test 3 fails [#1379]

2015-06-01 Thread Vu Minh Nguyen
libraries n Samples n Tests y Other n Comments (indicate scope for each y above): - changeset 415e9e29422dbaba2a14e68042712f770a68ed55 Author: Vu Minh Nguyen vu.m.nguy...@dektech.com.au Date

[devel] [PATCH 1 of 1] ntftest: Fix ntftest suite 22 test 3 fails [#1379]

2015-06-01 Thread Vu Minh Nguyen
tests/ntfsv/ntf_search_criteria_test.sh | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) Test suite 22 test 3 invokes the test script tests/ntfsv/ntf_search_criteria_test.sh. This script then passed an invalid non-option `return` to ntfread tool. This fix removed that non-option and

[devel] [PATCH 1 of 1] log: saflogger should use built-in default log file format in log server [#1433]

2015-08-11 Thread Vu Minh Nguyen
osaf/tools/saflog/saflogger/saf_logger.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Currently, saflogger tool uses its own defined log file format for application stream, instead of built-in one in log server. diff --git a/osaf/tools/saflog/saflogger/saf_logger.c

[devel] [PATCH 0 of 1] Review Request for log: saflogger should use built-in default log file format in log server [#1433]

2015-08-11 Thread Vu Minh Nguyen
Author: Vu Minh Nguyen vu.m.ngu...@dektech.com.au Date: Tue, 11 Aug 2015 09:32:29 +0100 log: saflogger should use built-in default log file format in log server [#1433] Currently, saflogger tool uses its own defined log file format for application stream, instead

Re: [devel] [PATCH 1 of 1] log: fix ownership of log files is not changed when group name is changed [#1550]

2015-10-26 Thread Vu Minh Nguyen
: opensaf-devel@lists.sourceforge.net >Subject: RE: [PATCH 1 of 1] log: fix ownership of log files is not changed when >group name is changed [#1550] > >Ack > >Thanks >Lennart > >> -Original Message- >> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >> Sent:

Re: [devel] [PATCH 0 of 1] Review Request for log: logtest sometimes gets failed at test case 15 and 38 of suite 6 [#1584]

2015-11-09 Thread Vu Minh Nguyen
Hi Mathi, Have you had time to look at this? If you have no feedback by this Wed, I will ask Lennart to push the patch since the change is minor. Regards, Vu. >-Original Message- >From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >Sent: Wednesday, November 04, 201

[devel] [PATCH 0 of 1] Review Request for log: wong condition check that might cause incorrectly configured logsv [#1596]

2015-11-16 Thread Vu Minh Nguyen
sn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset e2593a942f66afc716ce50fa26eed393b2272474 Author

[devel] [PATCH 1 of 1] log: fix not check special characters from saLogStreamFileName value [#1421]

2015-11-04 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_evt.c | 7 osaf/services/saf/logsv/lgs/lgs_imm.c | 11 +- osaf/services/saf/logsv/lgs/lgs_util.c | 57 ++ osaf/services/saf/logsv/lgs/lgs_util.h | 1 + tests/logsv/tet_LogOiOps.c | 40

[devel] [PATCH 0 of 1] Review Request for log: logtest sometimes gets failed at test case 15 and 38 of suite 6 [#1584]

2015-11-03 Thread Vu Minh Nguyen
Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset a7d00d50a84584f1d0d079e5f689e9edae6d0929 Author: Vu Minh Nguyen <v

[devel] [PATCH 1 of 1] log: logtest sometimes gets failed at test case 15 and 38 of suite 6 [#1584]

2015-11-03 Thread Vu Minh Nguyen
tests/logsv/tet_LogOiOps.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) There is an uninitialized character in an static array of characters. When outputting the string, the character at that position is unknown. It causes trouble when passing the string to shell if the

[devel] [PATCH 0 of 1] Review Request for log: fix not check special characters from saLogStreamFileName value [#1421]

2015-11-04 Thread Vu Minh Nguyen
Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 4e1fe66e277894c89282243d9c26e3fe2f4dfade Author: Vu Minh Nguyen <v

[devel] [PATCH 0 of 1] Review Request for log: fix ownership of log files is not changed when group name is changed [#1550]

2015-10-19 Thread Vu Minh Nguyen
Summary: log: fix ownership of log files is not changed when group name is changed [#1550] Review request for Trac Ticket(s): #1550 Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com; Pull request to: Lennart Affected branch(es): 4.7, default Development branch: <>

[devel] [PATCH 0 of 1] Review Request for log: fix displays incorrectly timezon if set location to west of Greenwich [#1545]

2015-10-14 Thread Vu Minh Nguyen
rvicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 243747d004feeec109937ae454e3170fcb4d6042 Author: Vu

[devel] [PATCH 1 of 1] log: fix displays incorrectly timezon if set location to west of Greenwich [#1545]

2015-10-14 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_fmt.c | 8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) Wrong processing for timezone with having negative gmt offset. diff --git a/osaf/services/saf/logsv/lgs/lgs_fmt.c b/osaf/services/saf/logsv/lgs/lgs_fmt.c ---

[devel] [PATCH 0 of 1] Review Request for log: fix crashed with saLogStreamFixedLogRecordSize=1 [#1466]

2015-10-07 Thread Vu Minh Nguyen
raries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 7218fab526b8b239cc6f9354580102c7dd958056 Author: Vu Minh Nguyen <vu.m.ng

[devel] [PATCH 1 of 1] log: incorrect verification the string length of saLogStreamFileName value [#1493]

2015-10-09 Thread Vu Minh Nguyen
osaf/libs/agents/saf/lga/lga_api.c | 2 +- osaf/libs/common/logsv/include/lgsv_defs.h | 10 + osaf/services/saf/logsv/lgs/lgs_imm.c | 22 +++- tests/logsv/tet_LogOiOps.c | 47 +- tests/logsv/tet_saLogStreamOpen_2.c| 54

[devel] [PATCH 0 of 1] Review Request for log: incorrect verification the string length of saLogStreamFileName value [#1493]

2015-10-09 Thread Vu Minh Nguyen
Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 591ac302fd705ff417088f550c1e1d911ab6d5a8 Author: Vu

Re: [devel] [PATCH 1 of 1] log: incorrect verification the string length of saLogStreamFileName value [#1493]

2015-10-13 Thread Vu Minh Nguyen
: opensaf-devel@lists.sourceforge.net >Subject: RE: [PATCH 1 of 1] log: incorrect verification the string length of >saLogStreamFileName value [#1493] > >Hi Vu, > >The patch cannot be applied. Something wrong when merging test code > >Thanks >Lennart > >>

Re: [devel] [PATCH 1 of 1] log: fix crashed with saLogStreamFixedLogRecordSize=1 [#1466]

2015-10-13 Thread Vu Minh Nguyen
: opensaf-devel@lists.sourceforge.net >Subject: RE: [PATCH 1 of 1] log: fix crashed with >saLogStreamFixedLogRecordSize=1 [#1466] > >Hi Vu, > >See my comments inline > >Thanks >Lennart > >> -Original Message- >> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.co

Re: [devel] [PATCH 0 of 1] Review Request for log: fix not check special characters from saLogStreamFileName value [#1421]

2015-11-16 Thread Vu Minh Nguyen
Hi Mathi, Have you had time to look at this? If you have no feedback by this Thursday, I will ask Lennart to push the patch. Thanks. Regards, Vu. >-Original Message- >From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >Sent: Wednesday, November 04, 2015 3:32 PM >To

Re: [devel] [PATCH 1 of 1] log: Make more configuration attributes possible to change in runtime [#1288]

2015-08-28 Thread Vu Minh Nguyen
Hi, With this patch, the lowest value for `logMaxLogrecsize` in the validation is set to `256`. But in logsv class definition, the default value of ` saLogStreamFixedLogRecordSize` is set to `150`. I think the lowest value for ` logMaxLogrecsize` should be changed to `150` instead. Regards, Vu

[devel] [PATCH 0 of 1] Review Request for log: Incorrect handling of version 4 checkpoint handling [#1459]

2015-09-08 Thread Vu Minh Nguyen
raries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset f43357e48f6aa49331207b48ac6a16bd496b34e1 Author: Vu Minh Nguyen <vu.m.ngu...@dektec

Re: [devel] [PATCH 1 of 1] log: Log server crash if SC nodes is not of same chkpt version [#1459]

2015-09-08 Thread Vu Minh Nguyen
: opensaf-devel@lists.sourceforge.net >Subject: RE: [PATCH 1 of 1] log: Log server crash if SC nodes is not of same >chkpt version [#1459] > >Hi Vu > >If possible remove version 3 checking entirely, see my previous mail > >Thanks >Lennart > >-Original Message- >From

Re: [devel] [PATCH 1 of 1] log: Log server crash if SC nodes is not of same chkpt version [#1459]

2015-09-08 Thread Vu Minh Nguyen
eded since the same thing is done >in #1459? >If that's the case #1387 should be closed and information about that #1459 fix >the problem described in #1387 must be added to the #1459 ticket > >Thanks >Lennart > >-Original Message- >From: Vu Minh Nguyen [mailto:vu.m.ngu.

Re: [devel] Review Request for log document: Update PR document with changes from latest enhancements [#1468]

2015-09-03 Thread Vu Minh Nguyen
Ack with minor comments. 1. Page 19, numbering for "Service Dependencies" is off. In previous version, it was numbered "3.4 Service Dependencies". Not sure it is your intention or not. 2. In page 19, "Initial configuration can be made by defining a configuration object off the

Re: [devel] [PATCH 0 of 1] Review Request for LOG: Log Service configuration changes are rejected on one node cluster [#1387]

2015-09-10 Thread Vu Minh Nguyen
Ack Regards, Vu >-Original Message- >From: giang do [mailto:giang.t...@dektech.com.au] >Sent: Tuesday, September 08, 2015 11:57 AM >To: mathi.naic...@oracle.com; vu.m.ngu...@dektech.com.au; >lennart.l...@ericsson.com >Cc: opensaf-devel@lists.sourceforge.net >Subject: [PATCH 0 of 1]

[devel] [PATCH 1 of 1] logsv: fix logsv gets stuck in a loop if passing zero(0) to maxFilesRotated [#1399]

2015-09-15 Thread Vu Minh Nguyen
osaf/libs/agents/saf/lga/lga_api.c| 10 ++- osaf/services/saf/logsv/lgs/lgs_evt.c |9 ++ tests/logsv/tet_LogOiOps.c| 23 +++ tests/logsv/tet_saLogStreamOpen_2.c | 103 ++ 4 files changed, 144 insertions(+), 1 deletions(-) Log agent

[devel] [PATCH 1 of 1] log: cannot delete value of logStreamFileFormat [#1490]

2015-09-17 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_imm.c | 47 ++ tests/logsv/tet_LogOiOps.c| 141 ++ 2 files changed, 170 insertions(+), 18 deletions(-) At start up, `logStreamFileFormat` attribute in configuration obj has value. Means that, built-in file

[devel] [PATCH 0 of 1] Review Request for log: cannot delete value of logStreamFileFormat [#1490]

2015-09-17 Thread Vu Minh Nguyen
amples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset e72c79da6f6c6840959fd920a2bccb737e8fdbb4 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Da

[devel] [PATCH 0 of 1] Review Request for fix cannot set saLogStreamSeverityFilter value back to default one (127) [#1395]

2015-09-30 Thread Vu Minh Nguyen
n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 2a27f0574ae7d46cef94ec83acbacdb65f74c3bb Author: Vu

[devel] [PATCH 1 of 1] logsv: fix cannot set saLogStreamSeverityFilter value back to default one (127) [#1395]

2015-09-30 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_imm.c | 4 ++-- tests/logsv/tet_LogOiOps.c| 24 2 files changed, 14 insertions(+), 14 deletions(-) logsv did validate the value incorrectly (>= 127) instead of (> 127). diff --git a/osaf/services/saf/logsv/lgs/lgs_imm.c

[devel] [PATCH 0 of 1] Review Request for logsv: crashed when performing admin op on configurable obj class [#1420]

2015-09-28 Thread Vu Minh Nguyen
raries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 344f12525e8b06f6b47312f700f5c5d72b2bb03e Author: Vu Minh Nguyen <vu.m.ng

[devel] [PATCH 1 of 1] logsv: crashed when performing admin op on configurable obj class [#1420]

2015-09-28 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_imm.c | 8 +++ tests/logsv/tet_LogOiOps.c| 39 +++ 2 files changed, 47 insertions(+), 0 deletions(-) logsv did not check if the operation is perfomed on configuration class or runtime one. Therefore, once the

Re: [devel] [PATCH 1 of 1] lgs: Correcting OI initializing thread handling [#1527]

2015-12-03 Thread Vu Minh Nguyen
Ack. Regards, Vu. >-Original Message- >From: Lennart Lund [mailto:lennart.l...@ericsson.com] >Sent: Thursday, December 03, 2015 6:55 PM >To: mathi.naic...@oracle.com; vu.m.ngu...@dektech.com.au >Cc: opensaf-devel@lists.sourceforge.net >Subject: [PATCH 1 of 1] lgs: Correcting OI

[devel] [PATCH 0 of 1] Review Request for log: switching to use the C++ compiler [#1624]

2015-12-08 Thread Vu Minh Nguyen
amples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset e59bd481b8c26a827ef023ea1abd7e0201bf2c64 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>

[devel] [PATCH 1 of 1] log: switching to use the C++ compiler [#1624]

2015-12-08 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/Makefile.am| 34 --- osaf/services/saf/logsv/lgs/lgs.h | 10 ++- osaf/services/saf/logsv/lgs/lgs_amf.c |4 +- osaf/services/saf/logsv/lgs/lgs_cb.h |8 + osaf/services/saf/logsv/lgs/lgs_config.c | 113 ++

[devel] [PATCH 0 of 1] Review Request for log: switching to use the C++ compiler [#1624] V2

2015-12-08 Thread Vu Minh Nguyen
amples n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 982a14649c9d3fd89654f02a9255707b1b4e9ccf Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au&

Re: [devel] [PATCH 1 of 1] lgs: Correcting OI initializing thread handling [#1527]

2015-12-07 Thread Vu Minh Nguyen
Hi Lennart, I have just found two things in imm_impl_set_sequence(). Please see my below comments [Vu]. > + if ( true == *(bool*) > lgs_cfg_get(LGS_IMM_LOG_OPENSAFLOGCONFIG_CLASS_EXIST)) { > + (void)immutil_saImmOiClassImplementerSet(immOiHandle, > "OpenSafLogConfig"); [Vu] Not

Re: [devel] [PATCH 1 of 1] ntfd: fix syslog warning when queueing notification for relogging [1628]

2015-12-13 Thread Vu Minh Nguyen
Ack. Regards, Vu. >-Original Message- >From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] >Sent: Monday, December 14, 2015 2:19 PM >To: vu.m.ngu...@dektech.com.au >Cc: opensaf-devel@lists.sourceforge.net >Subject: [PATCH 1 of 1] ntfd: fix syslog warning when queueing

Re: [devel] [PATCH 1 of 1] log: fix fail to recovery well-known streams [#1847]

2016-06-07 Thread Vu Minh Nguyen
Hi Lennart, Please see my comments inline [Vu]. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Monday, May 30, 2016 9:34 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; A V Mahesh > <mahesh.va...@oracle.

Re: [devel] [PATCH 1 of 1] log: fix fail to recovery well-known streams [#1847]

2016-06-08 Thread Vu Minh Nguyen
Hi all, Please see the updates from attached file. If you have any other comments, please let me know. Thanks. Regards, Vu > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Tuesday, June 7, 2016 2:50 PM > To: 'Lennart Lund

Re: [devel] [PATCH 1 of 1] log: fix fail to recovery well-known streams [#1847]

2016-06-12 Thread Vu Minh Nguyen
Hi Mahesh, Have you had time to look at this? Thanks. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Thursday, June 9, 2016 6:51 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; 'A V Mahesh' > <mahesh.va...@o

[devel] [PATCH 0 of 1] Review Request for log: fix log file sizes grow rapidly and cannot open [#1851]

2016-05-25 Thread Vu Minh Nguyen
Other n Comments (indicate scope for each "y" above): - <> changeset d71723b64fcdad28b729583098c3ca6abea94ad4 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 26 May 2016 09:10:56 +0700

[devel] [PATCH 1 of 1] log: fix fail to recovery well-known streams [#1847]

2016-05-27 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_filehdl.cc | 3 +++ osaf/services/saf/logsv/lgs/lgs_recov.cc | 16 ++-- 2 files changed, 9 insertions(+), 10 deletions(-) Return value of `lgs_get_file_params_h()` could be: 1) Return (-1) if there is problem with I/O handling or memory

[devel] [PATCH 0 of 1] Review Request for log: fix fail to recovery well-known streams [#1847] V2

2016-05-27 Thread Vu Minh Nguyen
n Other n Comments (indicate scope for each "y" above): - <> changeset 0af1b2e0dc567a36b6af0583323c8ad14a3d90c4 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Fri, 27 May 2016 12:58:40 +0700

[devel] [PATCH 0 of 1] Review Request for log: fix fail to delete appstream post headless when controllers come back [#1877]

2016-06-14 Thread Vu Minh Nguyen
Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 3d84f2074286f9c02100cd1bf2ec648b33420f62 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue

[devel] [PATCH 1 of 1] log: fix fail to delete appstream post headless when controllers come back [#1877]

2016-06-14 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_imm.cc | 54 +++ tests/logsv/logtest.c | 2 + tests/logsv/logtest.h | 1 + tests/logsv/tet_Log_recov.c| 57 ++ 4 files changed, 100 insertions(+), 14

Re: [devel] [PATCH 1 of 1] log: fix fail to recovery well-known streams [#1847]

2016-06-08 Thread Vu Minh Nguyen
Hi all, There is minor issue in test suite #9 - ticket #1865 [https://sourceforge.net/p/opensaf/tickets/1865/] I included the fix in this patch. Please have a look and give me your comments. Thanks Regards, Vu > -Original Message- > From: Vu Minh Nguyen [mailto:vu

Re: [devel] [PATCH 0 of 1] Review Request for log: fail to recovery well-known streams [#1847]

2016-05-27 Thread Vu Minh Nguyen
me = NULL; rc = -1; + goto done; } *ptr_str = '\0'; + + /* Use the CurFileName log file */ + rc = 1; } Regards, Vu. >-Original Message- >From: Lennart Lund [mailto:lennart.l..

[devel] [PATCH 0 of 1] Review Request for log: fail to recovery well-known streams [#1847]

2016-05-27 Thread Vu Minh Nguyen
n Other n Comments (indicate scope for each "y" above): - <> changeset e9d464289fd688cf73a2fa8cc50134caaefd4388 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Fri, 27 May 2016 12:58:40 +0700

[devel] [PATCH 1 of 1] log: fail to recovery well-know streams [#1847]

2016-05-27 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_filehdl.cc | 4 1 files changed, 4 insertions(+), 0 deletions(-) If receving error code `0` returned by `lgs_get_file_params_hdl`, `log_stream_open_file_restore` thought that the cluster started from scratch - means need to create log/cfg files. But error

Re: [devel] [PATCH 1 of 1] log: fix log file sizes grow rapidly and cannot open [#1851]

2016-05-26 Thread Vu Minh Nguyen
his patch is relevant to 5.0 only . >Are you planing to push now ? > > >-AVM > > > >On 5/26/2016 3:21 PM, Vu Minh Nguyen wrote: >> Hi Mahesh, >> >> So strange! >> >> The patch only did convert data type in case write request gets timeout, >&

Re: [devel] [PATCH 1 of 1] log: fix log file sizes grow rapidly and cannot open [#1851]

2016-05-26 Thread Vu Minh Nguyen
ectory=/var/log/opensaf/saflog/xxtest >logConfig=1,safApp=safLogService' Fail rc=1 > 2 FAILED (expected EXIT_SUCCESS, got EXIT_FAILURE (1)) CCB >Object Modify, root directory. Path exist. OK; >========== >===

Re: [devel] [PATCH 0 of 1] Review Request for log: fix log file size is bigger than saLogStreamMaxLogFileSize [#1438]

2016-05-27 Thread Vu Minh Nguyen
I would like to set the ticket to `accepted` state. Will back to this discussion later. Regards, Vu. >-Original Message- >From: Lennart Lund [mailto:lennart.l...@ericsson.com] >Sent: Thursday, May 26, 2016 8:12 PM >To: Vu Minh Nguyen; Canh Truong V; mathi.naic...@oracle.com;

Re: [devel] [PATCH 1 of 1] log: fix fail to delete appstream post headless when controllers come back [#1877]

2016-06-21 Thread Vu Minh Nguyen
` . Logsv should only call ` saImmOiRtObjectDelete` if the deleted app stream is runtime. Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Tuesday, June 21, 2016 3:37 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; > lenn

Re: [devel] [PATCH 0 of 1] Review Request for log: add support for cloud resilience feature [#1179]

2016-01-27 Thread Vu Minh Nguyen
Hi, I forgot adding information. To build the #1179 patch successfully, need #777 pushed. Regards, Vu. >-Original Message- >From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >Sent: Thursday, January 28, 2016 11:13 AM >To: anders.wid...@ericsson.com; lennart.l...@

Re: [devel] [PATCH 1 of 1] log: Use pathconf() instead of NAME_MAX [#279]

2016-01-25 Thread Vu Minh Nguyen
Hi Lennart, Thanks for your feedback. I have added PATH_MAX check as you recommended. Please get the updated code in attached file. Regards, Vu. >-Original Message- >From: Lennart Lund [mailto:lennart.l...@ericsson.com] >Sent: Monday, January 25, 2016 4:00 PM >To: Vu

Re: [devel] [PATCH 0 of 1] Review Request for log: add support for cloud resilience feature [#1179]

2016-02-03 Thread Vu Minh Nguyen
18311]: NO Implementer connected: > 2 (safLogService) <14, 2010f> > Feb 3 17:32:08 PM_SC-1 osafimmnd[18311]: NO Implementer locally > disconnected. Marking it as doomed 2 <14, 2010f> (safLogService) > Feb 3 17:32:08 PM_SC-1 osafimmnd[18311]: NO Implementer > disconnect

Re: [devel] [PATCH 0 of 1] Review Request for log: add support for cloud resilience feature [#1179]

2016-02-03 Thread Vu Minh Nguyen
_SC-1 osafimmnd[18311]: NO implementer for class >> > > > 'SaLogStreamConfig' is safLogService => class extent is safe. >> > > > Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO Implementer locally >> > > > disconnected. Marking it as doomed 1 <2, 2010f&

Re: [devel] [PATCH 2 of 4] log: add support for cloud resilience feature (agent part) [#1179]

2016-02-23 Thread Vu Minh Nguyen
nart.l...@ericsson.com] >Sent: Tuesday, February 23, 2016 8:30 PM >To: Mathivanan Naickan Palanivelu; Vu Minh Nguyen >Cc: opensaf-devel@lists.sourceforge.net; Anders Widell; Lennart Lund >Subject: RE: [PATCH 2 of 4] log: add support for cloud resilience feature >(agent >part) [#1179] > >H

Re: [devel] [PATCH 1 of 4] log: add support for cloud resilience feature (service part) [#1179]

2016-02-24 Thread Vu Minh Nguyen
Sorry. Please take this attach. Regards, Vu. >-Original Message- >From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >Sent: Thursday, February 25, 2016 9:23 AM >To: 'Mathivanan Naickan Palanivelu'; lennart.l...@ericsson.com >Cc: opensaf-devel@lists.sourceforge.n

Re: [devel] [PATCH 1 of 4] log: add support for cloud resilience feature (service part) [#1179]

2016-02-24 Thread Vu Minh Nguyen
Thanks, Mathi. Here is the fix for comments of patch 1/4 and 2/4. Regards, Vu. >-Original Message- >From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] >Sent: Wednesday, February 24, 2016 5:24 PM >To: vu.m.ngu...@dektech.com.au >Cc: lennart.l...@ericsson.com;

Re: [devel] [PATCH 1 of 1] log: fix info represents by millisecond token is not correct [#1619]

2016-02-24 Thread Vu Minh Nguyen
Ack. Regards, Vu. >-Original Message- >From: Canh Truong [mailto:canh.v.tru...@dektech.com.au] >Sent: Tuesday, February 23, 2016 10:18 AM >To: vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com; >anders.wid...@ericsson.com; mathi.naic...@oracle.com >Cc:

Re: [devel] [PATCH 1 of 5] NTF: Add support cloud resilience for NTF Agent [#1180]

2016-02-24 Thread Vu Minh Nguyen
Hi Minh, I have few comments below [Vu] and one question. I see, in some places, NTF APIs not always return TRY_AGAIN if both SCs down. I am not sure if I feel correctly or not. E.g: In `saNtfNotificationSend` API When the client thread comes to code line `ntfa_mds_msg_sync_send()`, headless

[devel] [PATCH 1 of 1] log: Extend information about origin of log record [#1480]

2016-02-25 Thread Vu Minh Nguyen
osaf/services/saf/logsv/README |16 + osaf/services/saf/logsv/config/Makefile.am | 4 +- osaf/services/saf/logsv/config/gcfg_classes.xml |18 + osaf/services/saf/logsv/config/gcfg_objects.xml | 6 + osaf/services/saf/logsv/lgs/Makefile.am | 6 +-

[devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

2016-02-25 Thread Vu Minh Nguyen
n Other n Comments (indicate scope for each "y" above): - <> changeset a6c0e7e9785c75c6dcf57404027fc92fc572a25f Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 02 Feb 2016 10:02:37 +070

[devel] [PATCH 1 of 1] log: Use pathconf() instead of NAME_MAX [#279]

2016-01-21 Thread Vu Minh Nguyen
osaf/libs/agents/saf/lga/lga_api.c | 58 - osaf/libs/common/logsv/include/lgsv_defs.h | 13 - osaf/libs/common/logsv/include/lgsv_msg.h |4 +- osaf/services/saf/logsv/lgs/Makefile.am | 14 +- osaf/services/saf/logsv/lgs/lgs.h | 12 +-

Re: [devel] [PATCH 1 of 1] log: Use pathconf() instead of NAME_MAX [#279]

2016-01-24 Thread Vu Minh Nguyen
nuary 22, 2016 6:44 PM >To: Vu Minh Nguyen; Anders Widell; mathi.naic...@oracle.com >Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund >Subject: RE: [PATCH 1 of 1] log: Use pathconf() instead of NAME_MAX [#279] > >Hi Vu, > >Some comments: > >General: >Indentation is

[devel] [PATCH 0 of 4] Review Request for log: add support for cloud resilience feature [#1179]

2016-02-15 Thread Vu Minh Nguyen
Summary: log: add support for cloud resilience feature [#1179] Review request for Trac Ticket(s): #1179 Peer Reviewer(s): Mathi, Anders W, Lennart Pull request to: Lennart Affected branch(es): Default Development branch: Default Impacted area Impact y/n

[devel] [PATCH 1 of 4] log: add support for cloud resilience feature (service part) [#1179]

2016-02-15 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/Makefile.am|6 +- osaf/services/saf/logsv/lgs/lgs.h | 12 + osaf/services/saf/logsv/lgs/lgs_cb.h | 14 + osaf/services/saf/logsv/lgs/lgs_evt.cc | 66 ++- osaf/services/saf/logsv/lgs/lgs_evt.h |5 +

[devel] [PATCH 2 of 4] log: add support for cloud resilience feature (agent part) [#1179]

2016-02-15 Thread Vu Minh Nguyen
osaf/libs/agents/saf/lga/Makefile.am |6 +- osaf/libs/agents/saf/lga/lga.h | 53 +- osaf/libs/agents/saf/lga/lga_api.c | 858 -- osaf/libs/agents/saf/lga/lga_mds.c | 46 +- osaf/libs/agents/saf/lga/lga_state.c | 670 +++

[devel] [PATCH 3 of 4] log: add support for cloud resilience feature (test part) [#1179]

2016-02-15 Thread Vu Minh Nguyen
tests/logsv/Makefile.am | 1 + tests/logsv/README | 4 + tests/logsv/logtest.c | 290 ++- tests/logsv/logtest.h |57 + tests/logsv/logtestfr.c | 6 +- tests/logsv/saflogtest.c|46 +- tests/logsv/tet_Log_misc.c |24 +-

[devel] [PATCH 4 of 4] log: add support for cloud resilience feature (readme file) [#1179]

2016-02-15 Thread Vu Minh Nguyen
osaf/services/saf/logsv/README-HEADLESS | 230 1 files changed, 230 insertions(+), 0 deletions(-) The patch makes LOG service be able to handle the case that both SC nodes are down at the same time. When one or both nodes go up again the log service must be

Re: [devel] [PATCH 1 of 3] MDS:TIPC include node name as a part of callback_info events [#1522]

2016-02-16 Thread Vu Minh Nguyen
Hi Mahesh, I see you are using constant HOST_NAME_MAX for node_name string. Referring to following page, it states HOST_NAME_MAX value possibly "is unspecified." http://pubs.opengroup.org/onlinepubs/009695399/basedefs/limits.h.html With _POSIX_HOST_NAME_MAX constant, the value is determined. Its

Re: [devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

2016-03-11 Thread Vu Minh Nguyen
Hi Mathi, Have you had time to look at this yet? Regards, Vu. >-Original Message- >From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >Sent: Friday, February 26, 2016 8:49 AM >To: anders.wid...@ericsson.com; lennart.l...@ericsson.com; >mathi.naic...@oracle.com >

Re: [devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

2016-03-15 Thread Vu Minh Nguyen
Please see my comments inline. Regards, Vu. >-Original Message- >From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] >Sent: Tuesday, March 15, 2016 1:29 PM >To: Vu Minh Nguyen; Anders Widell; Lennart Lund >Cc: opensaf-devel@lists.sourceforge.net; Beatriz

Re: [devel] [PATCH 1 of 1] mds-tcp: adjust the TCP fragamnet size according to new mds hdr size [#1694]

2016-03-08 Thread Vu Minh Nguyen
he RDN value of the CLM node name it self is max 255 , so their is > > no possibility of > `/etc/opensaf/node_name` exceeding 255 with combining with RDN > name > for example : > > `safAmfNode=SC-1,safAmfCluster=myAmfCluster` > > That is why I derived the name_nam

Re: [devel] [PATCH 0 of 5] Review Request for Add cloud resilience support [#1180] V2

2016-03-09 Thread Vu Minh Nguyen
Ack for the series. Regards, Vu. >-Original Message- >From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] >Sent: Tuesday, March 01, 2016 2:30 PM >To: lennart.l...@ericsson.com; praveen.malv...@oracle.com; >vu.m.ngu...@dektech.com.au; minh.c...@dektech.com.au >Cc:

Re: [devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

2016-03-15 Thread Vu Minh Nguyen
Hi Mathi, See my responses inline, with [Vu]. Regards, Vu. >-Original Message- >From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] >Sent: Tuesday, March 15, 2016 1:07 PM >To: Anders Widell; Vu Minh Nguyen; Lennart Lund >Cc: opensaf-devel@lists.sourcefor

Re: [devel] Review request for NTF: Update PR doc for cloud resilience [#1707]

2016-04-08 Thread Vu Minh Nguyen
Hi Minh, No comment from me. Ack. Regards, Vu. >-Original Message- >From: minh chau [mailto:minh.c...@dektech.com.au] >Sent: Thursday, April 07, 2016 7:28 AM >To: praveen malviya; Lennart Lund; Vu Minh Nguyen >Cc: opensaf-devel@lists.sourceforge.net >Subject: Re: [dev

[devel] [PATCH 0 of 1] Review Request for log: fix the initialized log handle is deleted when initializing with unsupported version [#1739]

2016-04-11 Thread Vu Minh Nguyen
n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 3aa4fbabf80286293f3e80719c1b9653e86561c9 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue

Re: [devel] Review Request for log: update PR document for cloud resilience [#1687]

2016-03-19 Thread Vu Minh Nguyen
PM To: Vu Minh Nguyen; mathi.naic...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: RE: Review Request for log: update PR document for cloud resilience [#1687] Hi Vu I have written some comments. See the attached document. Thanks Lennart From: Vu Minh Nguyen

Re: [devel] Review Request for log: update PR document for cloud resilience [#1687]

2016-03-22 Thread Vu Minh Nguyen
on?”, my >> answer is that >> >> the information is not only runtime state, but also other things such >> as current log files, >> >> size of current log files and record Ids for last written log record. >> >> >> >> >> Regards, Vu. >&g

Re: [devel] [PATCH 1 of 1] log: fix trouble when the number app streams reachs limitation [#1446]

2016-03-23 Thread Vu Minh Nguyen
Ack. Regards, Vu. >-Original Message- >From: Canh Truong [mailto:canh.v.tru...@dektech.com.au] >Sent: Thursday, March 17, 2016 10:00 AM >To: lennart.l...@ericsson.com; anders.wid...@ericsson.com; >mathi.naic...@oracle.com; vu.m.ngu...@dektech.com.au >Cc:

[devel] [PATCH 0 of 1] Review Request for log: miss mutex protection for common resource in log agent [#1705]

2016-03-23 Thread Vu Minh Nguyen
n Other n Comments (indicate scope for each "y" above): - <> changeset b866fd640124fcae26c98e730198e6439401387d Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 23 Mar 2016 13:08:10 +0700

[devel] [PATCH 1 of 1] log: miss mutex protection for common resource in log agent [#1705]

2016-03-23 Thread Vu Minh Nguyen
osaf/libs/agents/saf/lga/lga_state.c | 41 +++ osaf/libs/agents/saf/lga/lga_state.h | 1 + osaf/libs/agents/saf/lga/lga_util.c | 30 +++-- 3 files changed, 50 insertions(+), 22 deletions(-) There was an race condition between client

Re: [devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

2016-03-08 Thread Vu Minh Nguyen
Hi Lennart, Please see my responses inline, with [Vu]. Regards, Vu. >-Original Message- >From: Lennart Lund [mailto:lennart.l...@ericsson.com] >Sent: Thursday, March 03, 2016 10:38 PM >To: Vu Minh Nguyen; Anders Widell; mathi.naic...@oracle.com >Cc: opensaf-devel@lists.

[devel] [PATCH 0 of 1] Review Request for log: log agent library is not backward compatible [#1686] V2

2016-03-08 Thread Vu Minh Nguyen
n Other n Comments (indicate scope for each "y" above): - <> changeset 9e71920fba5261f8c138d874247a1452c6448f1b Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Fri, 04 Mar 2016 10:07:20 +0700

  1   2   3   4   5   6   7   >