On 25-Nov-15 12:42 PM, Quyen Dao wrote:
> Hi Praveen,
>
> When the cluster starts, the saAmfCtDefInstantiationLevel is .
>
> root@SC-1:~# immlist -a saAmfCtDefInstantiationLevel
> safVersion=4.0.0,safCompType=OpenSafCompTypeAMFWDOG
> saAmfCtDefInstantiationLevel=
>
> If I change saAmfCt
Ack for this series and unit test patch from version1.
Thanks,
Praveen
On 25-Nov-15 4:04 PM, Hans Nordeback wrote:
> osaf/services/saf/amf/amfd/chkop.cc|2 +-
> osaf/services/saf/amf/amfd/ckpt_dec.cc | 107 +-
> osaf/services/saf/amf/amfd/ckpt_enc.cc | 353
> ---
Summary: amfd: fix amfd crash during attribute modification in compType
v2[#1593]
Review request for Trac Ticket(s): #1593
Peer Reviewer(s): Hans, Nagendra , Quyen
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/
osaf/services/saf/amf/amfd/comptype.cc | 72 ++---
1 files changed, 57 insertions(+), 15 deletions(-)
Following commands causes amfd crash:
immcfg -a saAmfCtDefQuiescingCompleteTimeout=
safVersion=4.0.0,safCompType=OpenSafCompTypeAMFWDOG
immcfg -a saAmfCtDefInstanti
Ack with minor comment.
On 25-Nov-15 12:02 PM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/ckpt_dec.cc| 51 ++-
> osaf/services/saf/amf/amfd/ckpt_edu.cc| 54
> -
> osaf/services/saf/amf/amfd/ckpt_enc.cc| 38 +
Ack from me.
Thanks,
Praveen
On 26-Nov-15 1:11 PM, Quyen Dao wrote:
> configure.ac | 2 +
> osaf/libs/agents/saf/amfa/Makefile.am | 2 +-
> osaf/libs/agents/saf/amfa/tests/Makefile.am | 35
> +++
> osaf/services/saf/amf
Ack for the series (code review only) with one minor comment:
amfd/include/ntf.h contains an unused declaration
fill_ntf_header_part(). It can be deleted as AMF uses
fill_ntf_header_part_avd() in ntf.cc.
Thanks,
Praveen
On 02-Dec-15 1:19 PM, Hans Nordeback wrote:
> osaf/services/saf/amf/am
osaf/services/saf/amf/amfd/sg.cc | 28 +++-
1 files changed, 23 insertions(+), 5 deletions(-)
Command immcfg -a saAmfSGSuHostNodeGroup="" safSg=2N,safApp=OpenSAF
causes amfd crash.
Patch adds check to prevent deletion of saAmfSGSuHostNodeGroup or its
modification
to n
Summary: amfd: fix amfd crash during modification of saAmfSGSuHostNodeGroup
[#1594]
Review request for Trac Ticket(s): #1594
Peer Reviewer(s): Hans, Nagendra, Quyen
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact
Summary: ntfd: fix syslog warning when queueing notification for relogging
[1628]
Review request for Trac Ticket(s): #1628
Peer Reviewer(s): Vu Minh Nguyen;
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/n
-
osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
syslog is flooded with the following warnings
Dec 14 12:25:04 SC-1 osafntfd[9377]: WA Error when logging (9), queue for
relogging
Ntfd logs notifications by calling async api of LOG service. If
On 14-Dec-15 1:40 PM, Lennart Lund wrote:
> Hi Praveen
>
> It seems relevant to remove this warning but is anything logged if logging
> actually fail?
If log service callback is meant here, then there is no return code
which confirms logging other than SA_AIS_ERR_TIMEOUT and SA_AIS_OK. Also
fo
osaf/services/saf/amf/amfnd/clc.cc | 12 ++
osaf/services/saf/amf/amfnd/sidb.cc | 8
osaf/services/saf/amf/amfnd/susm.cc | 72 +
3 files changed, 92 insertions(+), 0 deletions(-)
In the reported problem, opensaf shutdown got stuck when one of the
Summary: amfnd: fix removal of assignments from faulty NPI SU during shutdown
phase [#1630]
Review request for Trac Ticket(s): #1630
Peer Reviewer(s): Hans, Nagendra, Gary.
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area
Hi Gary,
One comment on this patch inline with [Praveen].
For patch 1, declaration of avsv_edp_ckpt_msg_siass() needs to be
deleted from ckpt_edu.h.
I think patch series can be pushed after incorporating the comments.
Thanks,
Praveen
On 04-Dec-15 11:14 AM, Gary Lee wrote:
> osaf/services/sa
Ack code review only.
Thanks,
Praveen
On 14-Dec-15 5:34 AM, Minh Hon Chau wrote:
> osaf/services/saf/amf/amfnd/comp.cc | 71
> +---
> osaf/services/saf/amf/amfnd/include/avnd_comp.h | 2 +-
> 2 files changed, 40 insertions(+), 33 deletions(-)
>
>
> There's
Ack.
Thanks,
Praveen
On 15-Dec-15 9:55 AM, Minh Hon Chau wrote:
> osaf/services/saf/amf/amfnd/clc.cc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> Escalation is configured in the way that just one component restart can lead
> to su failover. If the clc cleanup script return
Ack for both the patches, code review only.
Thanks
Praveen
On 18-Dec-15 8:31 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/ckpt_dec.cc| 68
> ++
> osaf/services/saf/amf/amfd/ckpt_edu.cc| 53 --
> osaf/services/saf/amf/amfd/ckpt
On 18-Dec-15 6:27 PM, Hans Nordebäck wrote:
> Hi Praveen,
>
> A question, the opensafd script, in stop function, amfnd is sent a
> SIGTERM signal and starts to terminate its components.
> Despite the timeout retry logic, the final_clean seems to be called even
> if amfnd has not finished.
> Shoul
then do a pkill-9
osafamfnd, thereafter pkill -9 osaf* or
final_clean should be fine for the remaining services." ?
Thanks,
Praveen
./Thanks HansN
>
> -Original Message-
> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
> Sent: den 21 december 2015 08
osaf/services/infrastructure/nid/scripts/opensafd.in | 4
1 files changed, 4 insertions(+), 0 deletions(-)
During opensaf shutdown phase, if amfnd does not exit in configure
OPENSAF_TERMTIMEOUT, then
kill amfnd process after timeout.
diff --git a/osaf/services/infrastructure/nid/scripts/
osaf/services/saf/amf/amfnd/clc.cc | 12 ++
osaf/services/saf/amf/amfnd/sidb.cc | 8
osaf/services/saf/amf/amfnd/susm.cc | 72 +
3 files changed, 92 insertions(+), 0 deletions(-)
In the reported problem, opensaf shutdown got stuck when one of the
Summary: fix amfnd exit during shutdown phase V2 [#1630].
Review request for Trac Ticket(s): #1630.
Peer Reviewer(s): Hans, Gary, Mathi
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/n
--
osaf/services/saf/amf/amfd/su.cc | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
AMFD assert for the following commands:
immcfg -a saAmfSUHostNodeOrNodeGroup= safSu=SC-2,safSg=2N,safApp=OpenSAF
immcfg -a saAmfSURank= safSu=SC-2,safSg=2N,safApp=OpenSAF
Modification o
Summary: amfd: fix amfd assert during modification of su attributes[#1595]
Review request for Trac Ticket(s): #1595
Peer Reviewer(s): AMF contributors.
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/n
--
osaf/services/saf/amf/amfd/comptype.cc | 83 +
1 files changed, 63 insertions(+), 20 deletions(-)
AMFD crashes for following commands:
immcfg -a saAmfNumMaxInstantiateWithoutDelay=
safRdn=compGlobalAttributes,safApp=safAmfService
immcfg -a saAmfNumMaxInstantiate
Summary: amfd: fix amfd crash during modification of comp global
attributes[#1612]
Review request for Trac Ticket(s): #1612
Peer Reviewer(s): AMF contributors
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/n
--
Ack.
Thanks,
Praveen
On 18-Dec-15 3:29 PM, Hans Nordeback wrote:
> osaf/services/saf/amf/amfd/include/si.h |6 +-
> osaf/services/saf/amf/amfd/include/sirankedsu.h | 19 ++-
> osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 132
> ++-
> osaf/services/saf
Summary: Review request for #1556 and #1587.
Review request for Trac Ticket(s): #1556 and #1587.
Peer Reviewer(s): Hans, Nagendra, Minh, Quyen
Pull request to: <>
Affected branch(es): ALL
Development branch: Default
Impacted area Impact y/n
-
osaf/services/saf/amf/amfnd/clc.cc| 87 +++---
osaf/services/saf/amf/amfnd/include/avnd_su.h | 2 +
osaf/services/saf/amf/amfnd/su.cc | 18 +
osaf/services/saf/amf/amfnd/susm.cc | 19 +-
4 files changed, 100 insertions(+), 26 delet
osaf/services/saf/amf/amfnd/susm.cc | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
amfnd crashes when comp instantiation fails as a part of comp restart recovery.
Applicable to a NPI SU only.
Crash occurs because AMFND is trying to respond to AMFD for assignment status.
Summary: ntfs: increase limit of additionalText while logging
notification[#1660]
Review request for Trac Ticket(s): #1660
Peer Reviewer(s): Lennart, Minh
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/n
--
osaf/libs/common/ntfsv/include/ntfsv_msg.h | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
While logging alarm notifications having additionalText > 1024, Ntf server
truncates
additionalText to 1024.
There is no problem with delievery of notifications having additionalText >1024,
o
Summary: amfd: fix assignment of standby HA state in NWAY model[#1523].
Review request for Trac Ticket(s): #1523
Peer Reviewer(s): AMF contributors.
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/n
-
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 3 +--
osaf/services/saf/amf/amfd/si.cc | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
In the application, compcstype is not configured for csi of one si(say SI6).
Unlock-in and unlock of sg leads to only active assignments for Si
On 13-Jan-16 8:17 PM, Hans Nordebäck wrote:
> ack, code review only. One question below. /Thanks HansN
>
> On 01/08/2016 02:26 PM, praveen.malv...@oracle.com wrote:
>> osaf/services/saf/amf/amfnd/clc.cc| 87
>> +++---
>> osaf/services/saf/amf/amfnd/include/avnd
Ack, code review only.
Thanks,
Praveen
On 12-Jan-16 6:13 AM, Minh Hon Chau wrote:
> osaf/services/saf/amf/amfnd/comp.cc | 71
> +---
> osaf/services/saf/amf/amfnd/include/avnd_comp.h | 2 +-
> 2 files changed, 40 insertions(+), 33 deletions(-)
>
>
> There's
osaf/services/saf/amf/amfd/include/node.h | 1 +
osaf/services/saf/amf/amfd/nodegroup.cc | 95 --
2 files changed, 65 insertions(+), 31 deletions(-)
At present AMFD supports deletion of nodegroup in locked and unlocked state.
This enhancement allows deletion of n
Summary: amfd: allow deletion of locked-in nodegroup [#1533]
Review request for Trac Ticket(s): #1533
Peer Reviewer(s): AMF contributors
Pull request to: <>
Affected branch(es): Default
Development branch: <>
Impacted area Impact y/n
-
osaf/services/saf/amf/amfd/include/node.h | 3 +++
osaf/services/saf/amf/amfd/node.cc| 8
osaf/services/saf/amf/amfd/nodegroup.cc | 20 +++-
3 files changed, 10 insertions(+), 21 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/node.h
b/osaf/s
Ack for the series with a Note:Tickets #1544 and #1520 are not updated
with all the generated changesets.
Thanks
Praveen
On 14-Jan-16 12:28 PM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/ckpt_edu.cc| 215
> --
> osaf/services/saf/amf/amfd/include/ckpt_edu.h
Ack.
Thanks,
Praveen
On 15-Jan-16 5:52 PM, Hans Nordeback wrote:
> osaf/services/saf/amf/amfd/comptype.cc| 1 +
> osaf/services/saf/amf/amfd/dmsg.cc| 1 +
> osaf/services/saf/amf/amfd/hlt.cc | 1 +
> osaf/services/saf/amf/amfd/include/msg.h | 26 +---
> o
Hi Gary,
Please include leap mountaineer for review, if there are plans to
publish second version.
Thanks,
Praveen
On 25-Jan-16 1:00 PM, Gary Lee wrote:
> Hi
>
> Sorry, just realised I should have done this better.
>
>> On 25 Jan 2016, at 3:35 PM, Gary Lee wrote:
>>
>> osaf/libs/core/include/
osaf/services/saf/amf/amfd/csi.cc | 9 +
1 files changed, 5 insertions(+), 4 deletions(-)
Standby amfd crashes in ccb apply callback for su.
In the reported problem, one csi and one su is deleted in a single ccb.
Standby amfd returns BAD_OPERATION for csi completed callabck as csi dele
Summary: amfd: return ok for ccb complete cb for csi delete from standby
[#1671]
Review request for Trac Ticket(s): #1671
Peer Reviewer(s): Hans, Nagendra
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/n
--
Ack.
Thanks,
Praveen
On 20-Jan-16 5:32 PM, Hans Nordeback wrote:
> osaf/services/saf/amf/amfd/comp.cc| 105
> ++---
> osaf/services/saf/amf/amfd/include/comp.h | 67 +-
> osaf/services/saf/amf/amfd/ndfsm.cc |2 +-
> osaf/services/
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 7 +--
osaf/services/saf/amf/amfd/si.cc | 16 +++-
3 files changed, 21 insertions(+), 3 deletions(-)
When OpenSAF is stopped on one node hosting two application SUs, standby
a
Summary: amfd: fix assignment of standby HA state without active HA state, NPM
model [#1562]
Review request for Trac Ticket(s): #1562
Peer Reviewer(s): AMF contributors
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Imp
On 03-Feb-16 3:30 PM, Hans Nordebäck wrote:
> ack, code review only. One question, in ccb_apply_delete_hdlr at line 806:
>
> /* Check whether si has been assigned to any SU. */
> if ((nullptr != csi->si->list_of_sisu) &&
>
> as csi is received from the saved opdata->userData and may be
Hi Minh,
I am going through the patches.
Thanks,
Praveen
On 10-Feb-16 11:32 AM, minh chau wrote:
> Hi Lennart, Praveen
>
> If you are not too busy, can you help to review the patches of #1180?
>
> Thanks,
> Minh
>>> -Original Message-
>>> From: Minh Hon Chau [mailto:minh.c...@dektech.com
Hi Minh,
I have marked some doubts with [Praveen]. Could you please answer them,
it will helpful in understanding the changes in AMFD and AMFND.
Thanks,
Praveen
On 20-Jan-16 9:03 AM, Minh Hon Chau wrote:
> osaf/services/saf/amf/README-HEADLESS | 123
> ++
>
Hi Minh,
Please find some initial comments on this patch marked with [Praveen].
Thanks,
Praveen
On 20-Jan-16 9:03 AM, Minh Hon Chau wrote:
> osaf/services/saf/amf/amfd/cluster.cc| 69 -
> osaf/services/saf/amf/amfd/comp.cc |8 +-
> osaf/services/saf/amf/am
FYI. (Mail could not reach in community because of its size, now removed
some parts.)
Thanks,
Praveen
Forwarded Message
Subject: Re: [PATCH 2 of 5] amfd: Add support for cloud resilience at
director [#1620] V2
Date: Thu, 11 Feb 2016 16:45:58 +0530
From: praveen malviya
Hi Minh,
Please find some initial comments and questions marked with [Praveen].
One question regarding the approach.
In most of the changed APIs from saNtfInitialize() to
saNtfNotificationReadFinalize(), clients are being recovered. Why the
idea of recovering them is not considered in mds callb
Please see the responses with [Praveen]
Thanks,
Praveen
On 12-Feb-16 8:52 PM, minh chau wrote:
> Hi Praveen,
>
> Please find my comments inline [Minh]
>
> Thanks,
> Minh
>
> On 12/02/16 22:10, praveen malviya wrote:
>> Hi Minh,
>>
>> Please find some
Ack code review only.
Thanks,
Praveen
On 18-Feb-16 2:02 PM, Hans Nordeback wrote:
> osaf/services/saf/amf/amfd/ckpt_dec.cc | 30 ++
> 1 files changed, 30 insertions(+), 0 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc
> b/osaf/services/saf/
Ack code review only.
Thanks,
Praveen
On 18-Feb-16 8:39 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/clc.cc | 8 +++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
>
> When an Su contains one PI and one NPI comp and if terminate script
> of NPI comp returns non-ze
Please see responses with [Praveen].
Thanks,
Praveen
On 18-Feb-16 9:41 PM, Lennart Lund wrote:
> Please see responses with [Lennart]
>
> Thanks
> Lennart
>
>> -Original Message-----
>> From: praveen malviya [mailto:praveen.malv...@oracle.com]
>> Sent: den 1
Hi Minh,
Only minor comment on this patch.
saNtfDispatch() does not talk to the server directly, but client is
being recovered inside it. I think it should be moved to "Affected API
list".
Thanks,
Praveen
On 23-Dec-15 9:32 AM, Minh Hon Chau wrote:
> osaf/services/saf/ntfsv/README.HYDRA | 110
On 19-Feb-16 2:17 PM, Anders Widell wrote:
> Hi!
>
> See my comment inline, marked [AndersW].
>
> regards,
> Anders Widell
>
> On 02/19/2016 07:01 AM, praveen malviya wrote:
>> Please see responses with [Praveen].
>>
>> Thanks,
>> Pravee
.
b)Also ntftest dows not work with -vpe and prints only -help output.
I do not have any further comments other.
Thanks,
Praveen
On 18-Feb-16 6:31 PM, praveen malviya wrote:
> Please see the responses with [Praveen]
>
> Thanks,
> Praveen
>
> On 12-Feb-16 8:52 PM, minh chau wr
Please see the response inline with [Praveen].
Thanks,
Praveen
On 01-Mar-16 6:12 PM, Hans Nordebäck wrote:
> Hi Praveen,
>
> code review only. One question inlined/Thanks HansN
>
>
> On 01/20/2016 11:00 AM, praveen.malv...@oracle.com wrote:
>> osaf/services/saf/amf/amfd/include/node.h | 1 +
>>
Hi Minh,
One query on patch 03.
From headless state when first controller joins, in
avd_cluster_tmr_init_evh(), SG is being realigned. During realignment
AMF will take care of new assignments but not of those SUSIs whose FSMs
are in transition state.
Is AMF rebooting the node which hosts SUs
id not mean the case of inst and term failed of su.
The SUSI may be in transition state because of admin operations and
system becomes headless. So when first controller comes up, realign
logic will not be helpful and will not correct the state.
Thanks,
Praveen
> Thanks,
> Minh
>
> On
U1\,safSg=AmfDemo\,safApp=AmfDemo1,safSi=AmfDemo1,safApp=AmfDemo1
>>>
>>> saAmfSISUHAState=ACTIVE(1)
>>>
>>> saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1)
>>>
>>> TC #6: After TC #5, start PL-3:
>>>
>>> SU1 is not given
>> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
>> Sent: 03 March 2016 12:48
>> To: Nagendra Kumar; Praveen Malviya; Minh Chau H; Gary Lee
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: RE: [devel] [PATCH 1 of 1] amfd: delete su and its child objects at
>>
Summary: ntf/imcn: handle ERR_TIME_OUT returned by saImmOmClassDescriptionGet_2
[#1689]
Review request for Trac Ticket(s): #1689
Peer Reviewer(s): Lennart, Minh,
Pull request to: <>
Affected branch(es): ALL
Development branch: <>
Impacted area Impact y/
osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_imm.c | 9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
For getting rdn attribute name, IMCN calls saImmOmClassDescriptionGet_2() API.
If this API returns ERR-TIME_OUT, IMCN is not giving a retry and asserts.
Currently IMCN give a retry onl
Hi Anders,
When applied over cloud resilience patches (#1620) failures observed for
amf patch:
Hunk #6 succeeded at 673 (offset 20 lines).
1 out of 6 hunks FAILED -- saving rejects to file
osaf/services/saf/amf/amfd/main.cc.rej
..
1 out of 4 hunks FAILED -- saving rejects to file
osaf/ser
not done
in this patch.
Thanks,
Praveen.
On 04-Mar-16 9:11 AM, minh chau wrote:
Hi Praveen,
Please see my comments in line with [Minh]
Thanks,
Minh
On 04/03/16 00:41, praveen malviya wrote:
Hi Minh,
The second version of the patches you had published handles immediate
escalation only(1
Please apply this patch on top of l to 4.
Thanks
Praveen
On 08-Mar-16 5:08 PM, praveen malviya wrote:
> Hi,
>
> Attached is the PoC patch that re-uses existing SG FSM code, by resuming
> the SG FSM state after first controller comes up.
> Thereby, the patch avoids rebooting
Ack for the series with minor comments below:
-Most of the information of README must go in PR doc especially
unavailability of old alarms through reader APIs after headless state is
observed.
-I think recovery of clients must be done as early as possible after
first controller joins. For this
riate SUSI states, set them back to the
>> right ones. Then SG FSM can start afterwards as STABLE state. In
>> maintainability argument, it's likely a "plug-in" on top of current SG
>> FSM code, and it's separated from SG FSM code. It currently works for
>>
Summary:ntf: Integrate NTF service with CLM {#1639].
Review request for Trac Ticket(s): #1639
Peer Reviewer(s): Lennart, Minh, Mathi.
Pull request to: <>
Affected branch(es):default
Development branch: <>
Impacted area Impact y/n
--
osaf/services/saf/ntfsv/README | 78 ++
1 files changed, 78 insertions(+), 0 deletions(-)
Added information for:
-details of implementation.
-changes at NTFS.
-changes at NTFA.
diff --git a/osaf/services/saf/ntfsv/README b/osaf/services/saf/ntfsv/README
tests/ntfsv/Makefile.am | 3 ++-
tests/ntfsv/tet_ntf_common.h | 7 +++
tests/ntfsv/tet_ntf_main.c | 4 ++--
3 files changed, 11 insertions(+), 3 deletions(-)
New file tet_ntf_clm.c contains new test cases for testing this funtionality.
On a non-member node, ntf APIs must return SA_
osaf/tools/safntf/ntfread/ntfread.c | 2 +-
osaf/tools/safntf/ntfsend/ntfsend.c | 2 +-
osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
SAF version for ntfsend, ntfread and ntfsubscribe is updated from A.01.01 to
A.0
osaf/libs/common/ntfsv/include/ntfsv_defs.h | 6 +-
osaf/libs/common/ntfsv/include/ntfsv_msg.h | 7 +++
2 files changed, 12 insertions(+), 1 deletions(-)
New message structure to be used by NTFS to send CLM membership status of node
to clients.
diff --git a/osaf/libs/common/ntfsv/inc
osaf/libs/agents/saf/ntfa/ntfa.h |3 +
osaf/libs/agents/saf/ntfa/ntfa_api.c | 207 +-
osaf/libs/agents/saf/ntfa/ntfa_mds.c | 52
osaf/libs/agents/saf/ntfa/ntfa_util.c |3 +
4 files changed, 260 insertions(+), 5 deletions(-)
Changes inclu
osaf/services/saf/ntfsv/ntfs/Makefile.am |2 +
osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 203 +-
osaf/services/saf/ntfsv/ntfs/NtfAdmin.hh | 10 +-
osaf/services/saf/ntfsv/ntfs/NtfClient.cc | 42 ++
osaf/services/saf/ntfsv/ntfs/NtfClient.hh |4 +
osa
Summary: ntf: Integrate NTF service with CLM {#1639].
Review request for Trac Ticket(s): #1639
Peer Reviewer(s):Lennart, Minh, Mathi
Pull request to: <>
Affected branch(es): 5.0(default)
Development branch: <>
Impacted area Impact y/n
osaf/services/saf/ntfsv/README | 78 ++
1 files changed, 78 insertions(+), 0 deletions(-)
Added information for:
-details of implementation.
-changes at NTFS.
-changes at NTFA.
diff --git a/osaf/services/saf/ntfsv/README b/osaf/services/saf/ntfsv/README
osaf/tools/safntf/ntfread/ntfread.c | 2 +-
osaf/tools/safntf/ntfsend/ntfsend.c | 2 +-
osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
SAF version for ntfsend, ntfread and ntfsubscribe is updated from A.01.01 to
A.0
tests/ntfsv/Makefile.am |3 +-
tests/ntfsv/tet_ntf_clm.c| 501 +++
tests/ntfsv/tet_ntf_common.h |7 +
tests/ntfsv/tet_ntf_main.c |4 +-
4 files changed, 512 insertions(+), 3 deletions(-)
New file tet_ntf_clm.c contains new test case
osaf/services/saf/ntfsv/ntfs/Makefile.am |2 +
osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 203 +-
osaf/services/saf/ntfsv/ntfs/NtfAdmin.hh | 10 +-
osaf/services/saf/ntfsv/ntfs/NtfClient.cc | 42 ++
osaf/services/saf/ntfsv/ntfs/NtfClient.hh |4 +
osa
osaf/libs/common/ntfsv/include/ntfsv_defs.h | 6 +-
osaf/libs/common/ntfsv/include/ntfsv_msg.h | 7 +++
2 files changed, 12 insertions(+), 1 deletions(-)
New message structure to be used by NTFS to send CLM membership status of node
to clients.
diff --git a/osaf/libs/common/ntfsv/inc
osaf/libs/agents/saf/ntfa/ntfa.h |3 +
osaf/libs/agents/saf/ntfa/ntfa_api.c | 207 +-
osaf/libs/agents/saf/ntfa/ntfa_mds.c | 52
osaf/libs/agents/saf/ntfa/ntfa_util.c |3 +
4 files changed, 260 insertions(+), 5 deletions(-)
Changes inclu
Hi Anders,
Please find some comments and queries inline with [Praveen]
Thanks,
Praveen
On 29-Feb-16 8:44 PM, Anders Widell wrote:
> osaf/services/saf/amf/amfd/clm.cc | 21 +-
> osaf/services/saf/amf/amfd/include/amfd.h | 2 +
> osaf/services/saf/amf/amfd/include/cb.h | 1
Hi Minh,
I had already acked v2.
Ack for version 3 also.
Thanks,
Praveen
On 21-Mar-16 5:36 AM, minh chau wrote:
> Hi Praveen, Vu
>
> Any comment on V3?
>
> Thanks,
> Minh
>
> On 18/03/16 19:01, Lennart Lund wrote:
>> Hi Minh
>>
>> Ack, sorry for beeing a bit unclear
>>
>> Thanks
>> Lennart
>>
>
Ack for both patches.
Thanks,
Praveen
On 29-Feb-16 8:18 PM, Anders Widell wrote:
> osaf/services/saf/ntfsv/ntfs/ntfs.h | 7 ++-
> osaf/services/saf/ntfsv/ntfs/ntfs_amf.c | 21 -
> osaf/services/saf/ntfsv/ntfs/ntfs_cb.h | 2 +-
> osaf/services/saf/ntfsv/ntfs/
Summary: ntf: Integrate NTF service with CLM {#1639] V2
Review request for Trac Ticket(s): #1639
Peer Reviewer(s): Lennart, Minh, Mathi
Pull request to: <>
Affected branch(es): Default
Development branch: <>
Impacted area Impact y/n
--
osaf/libs/common/ntfsv/include/ntfsv_defs.h | 6 +-
osaf/libs/common/ntfsv/include/ntfsv_msg.h | 7 +++
2 files changed, 12 insertions(+), 1 deletions(-)
No change from v1.
New message structure to be used by NTFS to send CLM membership status of node
to clients.
diff --git a/osaf/l
osaf/tools/safntf/ntfread/ntfread.c | 2 +-
osaf/tools/safntf/ntfsend/ntfsend.c | 2 +-
osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
No change from V1..
SAF version for ntfsend, ntfread and ntfsubscribe is updated
osaf/services/saf/ntfsv/README | 74 ++
1 files changed, 74 insertions(+), 0 deletions(-)
No change from V1.
Added information for:
-details of implementation.
-changes at NTFS.
-changes at NTFA.
diff --git a/osaf/services/saf/ntfsv/README b/osaf/servic
osaf/services/saf/ntfsv/ntfs/Makefile.am |2 +
osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 203 +-
osaf/services/saf/ntfsv/ntfs/NtfAdmin.hh | 10 +-
osaf/services/saf/ntfsv/ntfs/NtfClient.cc | 42 ++
osaf/services/saf/ntfsv/ntfs/NtfClient.hh |4 +
osa
osaf/libs/agents/saf/ntfa/ntfa.h |2 +
osaf/libs/agents/saf/ntfa/ntfa_api.c | 226 -
osaf/libs/agents/saf/ntfa/ntfa_mds.c | 52 +++
osaf/libs/agents/saf/ntfa/ntfa_util.c |3 +
4 files changed, 272 insertions(+), 11 deletions(-)
V2 changes:
-R
tests/ntfsv/Makefile.am |3 +-
tests/ntfsv/tet_ntf_clm.c| 501 +++
tests/ntfsv/tet_ntf_common.h |7 +
tests/ntfsv/tet_ntf_main.c |4 +-
4 files changed, 512 insertions(+), 3 deletions(-)
No change from V1.
New file tet_ntf_clm.c co
Ack code reivew only.
I think commit message must include Red model name.
Thanks,
Praveen
On 31-Mar-16 9:05 AM, Gary Lee wrote:
> Hi
>
> I will push this tomorrow if there are no more comments.
>
> Thanks
> Gary
>
>
>
>
> On 11/03/2016, 7:13 PM, "Hans Nordebäck" wrote:
>
>> ack, code review onl
Hi Quyen,
avd_sg_nway_si_assign() is called even in the cases when SG is not
stable for example in
1) node_fail_su_oper() {
...
...
/* if sg hasnt transitioned to sg-realign, initiate new si
assignments */
if (AVD_SG_FSM_SG_REALIGN != sg->sg_fsm_state)
Ack (code review only) with minor comment.
avd_ckpt_app(): never returns failure. Inside this function rc value is
not corrected when app_db->insert() fails. Also avd_ckpt_app() itself
has one assert for failed value. Please correct the rc value inside
avd_ckpt_app() and remove assert in it bef
1 - 100 of 1124 matches
Mail list logo
