Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Lev Stipakov
Hi, It's lots of text that is totally uninteresting if it succeeds, but that > you need to scroll over when looking for the reason why a build fails - > which is the reason why it is the way it is today. > I have sent v2 which doesn't change the behavior for non-Windows builds. If you volunteer

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Selva Nair
Hi On Thu, Nov 7, 2019 at 7:43 AM Lev Stipakov wrote: > Hi, > > >> I'm a bit unhappy with that one, as it changes behaviour for all >> non-windows >> builds (including all the openssl build output even if it succeeds). >> > > The only place it changes behavior is this > > install: >- if [

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Antonio Quartulli
Hi, On 07/11/2019 14:36, Simon Rozman wrote: > I revoke this “master.c” idea. It makes incremental compiling ridiculously > slow. It might work for production builds, but definitely not for development. It also breaks scoping of variables/function. So, I am glad you found your own reason to

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Simon Rozman
Doering' Cc: 'Antonio Quartulli' ; 'openvpn-devel' Subject: Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support We could introduce a master.c file which would include: #include "argv.c" #include "auth_token.c" #include "base64.

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread tincanteksup
Hi, On 07/11/2019 12:42, Lev Stipakov wrote: Hi, I'm a bit unhappy with that one, as it changes behaviour for all non-windows builds (including all the openssl build output even if it succeeds). The only place it changes behavior is this install: - if [ ! -z "${CHOST}" ]; then

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Simon Rozman
We could introduce a master.c file which would include: #include "argv.c" #include "auth_token.c" #include "base64.c" #include "block_dns.c" #include "buffer.c" . . . #include "status.c" #include "tls_crypt.c" #include "tun.c" #include "win32.c" And then have Makefile.ac and MSVC

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Gert Doering
Hi, On Thu, Nov 07, 2019 at 02:42:17PM +0200, Lev Stipakov wrote: > > I'm a bit unhappy with that one, as it changes behaviour for all > > non-windows > > builds (including all the openssl build output even if it succeeds). > > The only place it changes behavior is this > > install: >- if

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Lev Stipakov
Hi, > I'm a bit unhappy with that one, as it changes behaviour for all > non-windows > builds (including all the openssl build output even if it succeeds). > The only place it changes behavior is this install: - if [ ! -z "${CHOST}" ]; then unset CC; fi - - .travis/build-deps.sh >

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Gert Doering
Hi, On Thu, Nov 07, 2019 at 02:18:25PM +0200, Lev Stipakov wrote: > This broke (again) Visual Studio build: > > > error LNK2019: unresolved external symbol vlan_process_outgoing_tun > referenced in function multi_process_outgoing_tun Can you please send a patch that adds vlan.c to the list of

Re: [Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-07 Thread Lev Stipakov
This broke (again) Visual Studio build: > error LNK2019: unresolved external symbol vlan_process_outgoing_tun referenced in function multi_process_outgoing_tun Can we please ack and merge this patch https://patchwork.openvpn.net/patch/868/ to catch these things earlier? ke 6. marrask. 2019 klo

[Openvpn-devel] [PATCH applied] Re: VLAN: add basic VLAN tagging support

2019-11-06 Thread Gert Doering
Acked-by: Gert Doering Stared at the code (twice now), run t_client and t_server tests. This patch does not really *do* much yet, but it lays the groundwork for future work - the "broadcast only to clients in the same vlan" part is there, but it's always called with "0" (= all clients). As far