Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

Hi, guys This patch isn't updated from June on, Cascardo said he/Eric is still working on this, but six months passed, we don't see any following patch for this, now I have time to revisit it, for case 3 Pravin mentioned, I can make it work by applying the below patch [1] against

[ovs-dev] [PATCH] netdev-dpdk: Don't use dev->vhost_id without mutex.

> How about "if (!vhost_id[0])", to avoid a useless strlen call? LGTM, I've posted v2 with that fix: https://mail.openvswitch.org/pipermail/ovs-dev/2016-December/325807.html Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH v2] netdev-dpdk: Don't use dev->vhost_id without mutex.

The copy should be used here. Additionally, 'strlen' changed to the faster check. Fixes: 821b86649a90 ("netdev-dpdk: Don't try to unregister empty vhost_id.") Signed-off-by: Ilya Maximets --- Version 2: * 'strlen' --> '[0]' (Suggested by Ben Pfaff)

[ovs-dev] [PATCH 4/4] build-windows: Propagate PACKAGE_VERSION to the MSI

This patch propagates the automake variable PACKAGE_VERSION when building the MSI via msys. Signed-off-by: Alin Gabriel Serdean --- windows/automake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/windows/automake.mk b/windows/automake.mk

[ovs-dev] [PATCH 2/4] build-windows: Propagate PACKAGE_VERSION to the driver files

This patch propagates the automake value 'PACKAGE_VERSION' to the driver specific information files, overwriting the Visual Studio default value of Version, when building the driver via msys. Signed-off-by: Alin Gabriel Serdean --- Makefile.am | 8 1

[ovs-dev] [PATCH 0/4] Unify the version used by the driver and MSI

The following series will allow to propagate the automake value 'PACKAGE_VERSION' to the driver information values and MSI properties. The current approach focuses only when building the driver/MSI from the command line. If projects are built seperatly via UI, the default value of '1.0.0.0' will

[ovs-dev] [PATCH 1/4] datapath-windows: Force driver version to depend on a variable

The following components use Windows driver information: - System (inf file); used during device installation - Resource file (rc file); used by applications when looking over the driver file(sys) Currently we have the following for the driver version number: - (inf file)

Re: [ovs-dev] [PATCH 5/9] lport: Add index for logical datapaths.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > This will have its first real user in an upcoming commit. > I am not sure this is really necessary. See my comments on patch 6. At the end there is deleted code for destroying patched_datapaths. That deletion should not be in

Re: [ovs-dev] [PATCH 4/9] lport: Tolerate null pointers in destroy functions.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > The coding style says to do this. > > The actual caller doesn't pass a null pointer. > Acked-by: Mickey Spiegel > Signed-off-by: Ben Pfaff > --- > ovn/controller/lport.c | 8 > 1

Re: [ovs-dev] [PATCH 3/9] lport: Be a little more careful building lport index.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > It seems like a good idea to check for and warn about all kinds of > duplicates, and to avoid segfaulting if a datapath column is empty. > (However, the database schema should prevent both issues.) > Acked-by: Mickey Spiegel

Re: [ovs-dev] [PATCH] ovsdb-server: Add ovsdb-server/is-backup-server command in unixctl

On Dec 6, 2016 3:18 AM, "Ben Pfaff" wrote: Hi Numan, is this still relevant? It seems to have been overlooked, since I can't find any followups on the mailing lists. If it's still worth merging, would you mind posting a rebased version? Thanks, and sorry to have missed this!

Re: [ovs-dev] [PATCH 6/9] ovn-controller: Handle only relevant ports and flows.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > On a particular hypervisor, ovn-controller only needs to handle ports > and datapaths that have some relationship with it, that is, the > ports that actually reside on the hypervisor, plus all the other ports on > those ports'

Re: [ovs-dev] [PATCH 2/2] tests: Add tracing to "ovn -- 2 HVs, 4 lports/HV, localnet ports" test.

On Sun, Oct 23, 2016 at 1:50 PM, Ben Pfaff wrote: > Adding ovn-trace calls makes failures easier to understand and diagnose. > > Signed-off-by: Ben Pfaff > --- > tests/ovn.at | 96 ++ > +++--- > 1 file changed, 60

Re: [ovs-dev] [PATCH 1/2] tests: Fix order confusion in "ovn -- 2 HVs, 4 lports/HV, localnet ports".

On Sun, Oct 23, 2016 at 1:50 PM, Ben Pfaff wrote: > The order of src and dst was swapped both in assignment and reference, > which meant that the result worked OK but was really confusing to try to > extend or modify. > > Signed-off-by: Ben Pfaff > Acked-by: Russell

Re: [ovs-dev] [PATCH] ovn-trace: Add output format options to usage message.

On Mon, Dec 5, 2016 at 8:01 PM, Ben Pfaff wrote: > On Sun, Oct 23, 2016 at 11:25:02AM -0700, Ben Pfaff wrote: > > Also adjust the indentation of the option explanations so that they line > up > > better. > > > > Signed-off-by: Ben Pfaff > > This still needs a review,

Re: [ovs-dev] [PATCH 1/2] tests: Fix order confusion in "ovn -- 2 HVs, 4 lports/HV, localnet ports".

On Sun, Oct 23, 2016 at 10:50:35AM -0700, Ben Pfaff wrote: > The order of src and dst was swapped both in assignment and reference, > which meant that the result worked OK but was really confusing to try to > extend or modify. > > Signed-off-by: Ben Pfaff This series still needs a

Re: [ovs-dev] [PATCH] ovn-trace: Add output format options to usage message.

On Sun, Oct 23, 2016 at 11:25:02AM -0700, Ben Pfaff wrote: > Also adjust the indentation of the option explanations so that they line up > better. > > Signed-off-by: Ben Pfaff This still needs a review, which should be trivial. ___ dev

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

On Mon, Dec 05, 2016 at 11:52:47PM +0100, Michał Mirosław wrote: > On Mon, Dec 05, 2016 at 10:55:45AM -0800, Ben Pfaff wrote: > > On Mon, Dec 05, 2016 at 06:24:36PM +0100, Michał Mirosław wrote: > > > On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > > > > On Sat, Dec 03, 2016 at

[ovs-dev] Trabajadores conflictivos e improductivos

En línea y en Vivo / Para todo su Equipo con una sola Conexión Promoción Navideña – Pregunte por Ella Seminario Experto en Rescisión Laboral Cómo despedir trabajadores flojos, conflictivos e improductivos Devolución de Impuestos Y Las Reacciones de las Autoridades fiscales Cómo proteger

[ovs-dev] Implementación de Lean Manufacturing

Una herramienta financiera para mejorar resultados Implementación de Lean Manufacturing 16 de diciembre - Zona Reforma (Ciudad de México) - 9:00 a 18:00 Imparte: MCE. Abdón Guzmán S. Lean Manufacturing es un sistema de gestión de cómo operar de forma adecuada un negocio, enfocado en

Re: [ovs-dev] [PATCH] datapath-windows: null comparison for icmp and tcp header

On 5 December 2016 at 12:16, Alin Serdean wrote: > Thanks for the tips Joe! > > It causes a kernel crash under low resources. OK, thanks. Please include this information in future git commit messages. ___ dev mailing

[ovs-dev] [PATCH v2] ovn-controller(8): ovn-remote must be an ovsdb remote.

Document that the value of the ovn-remote configuration option must be in the form of an ovsdb remote as previously documented in this man page. This came up on IRC where someone trying OVN put a hostname here and observed that it did not work. Signed-off-by: Russell Bryant ---

Re: [ovs-dev] [RFC] Introducing experimental OVN integration for Mesos

Guru, did you ever have a look at this? It's always nice to integrate with more systems. Nimay, I feel bad that apparently no one ever responded to this. On Fri, Aug 05, 2016 at 03:54:47PM -0700, Nimay Desai wrote: > This commit introduces experimental support for OVN integration with Apache >

Re: [ovs-dev] [PATCH] ovn-controller(8): ovn-remote must be an IP adddress.

On Mon, Dec 5, 2016 at 1:13 PM, Ben Pfaff wrote: > On Mon, Dec 05, 2016 at 10:10:43AM -0800, Ben Pfaff wrote: > > On Mon, Dec 05, 2016 at 12:05:33PM -0500, Russell Bryant wrote: > > > Document that the value of the ovn-remote configuration > > > option must be an IP address. This

Re: [ovs-dev] [PATCH] ovsdb-server: Add ovsdb-server/is-backup-server command in unixctl

Hi Numan, is this still relevant? It seems to have been overlooked, since I can't find any followups on the mailing lists. If it's still worth merging, would you mind posting a rebased version? Thanks, and sorry to have missed this! Ben On Fri, Aug 19, 2016 at 08:17:43PM +0530, Numan Siddique

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

> On Dec 1, 2016, at 3:44 PM, Ben Pfaff wrote: > > On Thu, Dec 01, 2016 at 01:09:12PM -0800, Jarno Rajahalme wrote: >>> If I may be permitted to nit-pick, the name "modify_forward_counts" took >>> me a bit of thinking to properly understand. Maybe "modify_keep_stats" >>> would be

Re: [ovs-dev] [RFC] ovn: Securing from compromised host - removal of MAC_Binding

On Fri, Nov 18, 2016 at 10:13:23AM +0530, Babu Shanmugam wrote: > 2) When the destination for an ARP reply is an OVN distributed router, > broadcast the response to all instances of the logical router so that the > result is available in the local cache of each router instance. This is a

Re: [ovs-dev] [PATCH 9/9] ovn-controller: Drop most uses of OVS patch ports.

On Sun, Dec 4, 2016 at 11:17 PM, Ben Pfaff wrote: > Until now, ovn-controller has implemented OVN logical patch ports and > l3gateway ports in terms of OVS patch ports. It is a hassle to create and > destroy ports, and it is also wasteful compared to what the patch ports >

[ovs-dev] [PATCH] ovsdb-data: Add support for integer ranges in database commands

Adding / removing a range of integers to a column accepting a set of integers requires enumarating all of the integers. This patch simplifies it by introducing 'range' concept to the database commands. Two integers separated by a hyphen represent an inclusive range. The patch adds positive and

Re: [ovs-dev] [PATCH] mpls: Fix MPLS restoration after patch port and group bucket.

Thanks for the review, pushed to master, branch-2.6, and branch-2.5. Jarno > On Dec 3, 2016, at 5:54 AM, Takashi YAMAMOTO wrote: > > > > On Sat, Dec 3, 2016 at 12:38 PM, Jarno Rajahalme > wrote: > This patch fixes problems with MPLS

Re: [ovs-dev] [PATCH] datapath-windows: null comparison for icmp and tcp header

The problem is here: https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Conntrack-tcp.c#L460 Looking back, it makes more sense to add them to OvsConntrackValidateIcmpPacket/OvsConntrackValidateTcpPacket. Should I revert the original patch and send one that chages the

Re: [ovs-dev] [PATCH] datapath-windows: null comparison for icmp and tcp header

Thanks for the tips Joe! It causes a kernel crash under low resources. Thanks, Alin. > -Original Message- > From: Joe Stringer [mailto:j...@ovn.org] > Sent: Tuesday, November 29, 2016 9:35 PM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re:

Re: [ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document

Sorry for the late reply. We had a few days of bank holiday last week. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, November 29, 2016 2:28 AM > To: Nithin Raju > Cc: Yin Lin ; d...@openvswitch.org; Alin Serdean >

Re: [ovs-dev] [PATCH v2 18/19] dpif-netdev: Centralized threads and queues handling code.

Thanks again for looking at this, please let me know if you have other comments. On 05/12/2016 05:39, "Ilya Maximets" wrote: >Thanks for v2. > >Global comment: >Could you please add a space between '{C,H}MAP_FOR_EACH[_WITH_HASH]' and >the expressions that follow them.

Re: [ovs-dev] [RFC PATCH] Pipeline packet processing in OVS using FVL flow director.

On Thu, Dec 01, 2016 at 06:23:55PM +, Sugesh Chandran wrote: > The RFC patch that uses the metadata information from the NIC to avoid/reduce > the > packet processing overhead in OVS. > > It uses the flow director feature in XL710 NICs to

Re: [ovs-dev] [PATCH] tunnel: set udp dst-port in tunnel metadata

Acked-by: Jarno Rajahalme Is it OK to leave the tunnel.tp_src unset, or left set to the value from the incoming tunnel? Jarno > On Dec 4, 2016, at 11:52 PM, Pravin B Shelar wrote: > > VxLan device expect valid tp-dst in tunnel metadata. > Following patch

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

On Mon, Dec 05, 2016 at 06:24:36PM +0100, Michał Mirosław wrote: > On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > > On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote: > > > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed > > > intact through

Re: [ovs-dev] [PATCH 0/4] datapath-windows: Enable support for tracking FTP connections

Thanks a lot for the series. Overall it looks like a good start for the support! Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Sairam Venugopal > Sent: Thursday, December 1, 2016 11:19 PM > To:

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

Thanks for the patch. I think OvsInitCtRelated/ OvsCleanupCtRelated would make more sense to be inside OvsInitConntrack/OvsCleanupConntrack since the functionality are tied together. One small nit. Thanks, Alin. > +ctAttr = NlAttrFindNested(a, OVS_CT_ATTR_HELPER); > +if (ctAttr) { > +

Re: [ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

Thanks for the patch! It looks good as an initial point that we can add more complexity in the future :). One personal preference would be to use the string Rtl* functions: https://msdn.microsoft.com/en-us/library/windows/hardware/ff563642(v=vs.85).aspx

Re: [ovs-dev] [PATCH] ovn-controller(8): ovn-remote must be an IP adddress.

On Mon, Dec 05, 2016 at 10:10:43AM -0800, Ben Pfaff wrote: > On Mon, Dec 05, 2016 at 12:05:33PM -0500, Russell Bryant wrote: > > Document that the value of the ovn-remote configuration > > option must be an IP address. This came up on IRC where > > someone trying OVN put a hostname here and

Re: [ovs-dev] [PATCH] ovn-controller(8): ovn-remote must be an IP adddress.

On Mon, Dec 05, 2016 at 12:05:33PM -0500, Russell Bryant wrote: > Document that the value of the ovn-remote configuration > option must be an IP address. This came up on IRC where > someone trying OVN put a hostname here and observed that > it did not work. > > Signed-off-by: Russell Bryant

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote: > > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed > > intact through linux networking stack. > > > > Signed-off-by: Michał Mirosław

[ovs-dev] [PATCH] ovn-controller(8): ovn-remote must be an IP adddress.

Document that the value of the ovn-remote configuration option must be an IP address. This came up on IRC where someone trying OVN put a hostname here and observed that it did not work. Signed-off-by: Russell Bryant --- ovn/controller/ovn-controller.8.xml | 2 +- 1 file

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2016-12-03, Jarno Rajahalme: I sent a patch to fix this on OVS master. After it is reviewed I’ll backport it to branch-2.5 (it only needs trivial fixes to apply, so you may want to try that as well). Thank you very much. I'll try it this week. Best, -Thomas On Dec 1, 2016, at 5:57 PM,

Re: [ovs-dev] [PATCH] netdev-dpdk: Don't use dev->vhost_id without mutex.

How about "if (!vhost_id[0])", to avoid a useless strlen call? On Mon, Dec 05, 2016 at 09:14:27AM +0300, Ilya Maximets wrote: > The copy should be used here. > > Fixes: 821b86649a90 ("netdev-dpdk: Don't try to unregister empty vhost_id.") > Signed-off-by: Ilya Maximets >

Re: [ovs-dev] [PATCH 2/4] datapath-windows: Cleanup Conntrack definitions and introduce related entries

Looks good, but I have a question regarding the includes. Do you need "NetProto.h", ? Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Sairam Venugopal > Sent: Thursday, December 1, 2016 11:19 PM > To:

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Conntrack - Fix OvsGetTcpPayloadLength()

Thanks for the patch. Looks good. I was wondering if we could adapt and reuse OvsParseTcp (https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketParser.c#L178) instead? Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-

[ovs-dev] [PATCH 5/5] datapath-windows: Conntrack disable type truncation warning

Compiling with the WDK 10 gave the following warning: Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to 'UINT32' ovsext (OVSExt\ovsext) Conntrack.c 1139 This patch disables the warning on the file Conntrack.c. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 4/5] datapath-windows: Fix function prototypes

There is a mismatch between OvsInitCompletionList and OvsAddPktCompletionList prototypes. Eg: https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketIO.h#L33 https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketIO.c#L54 Found while compiling with

[ovs-dev] [PATCH 3/5] datapath-windows: Remove unused section from driver inf

The new tool chain for Windows 10 driver contains a inf file checker. While compiling it found the following issue: - Common.Params.reg is missing. This patch removes the entry since it is not used, and at the moment we do not add any specific keys to the Windows registry. Signed-off-by: Alin