[ovs-dev] [PATCH v8] netdev-offload-tc: del ufid mapping if device not exist

The device may be deleted and added with ifindex changed. The tc rules on the device will be deleted if the device is deleted. The func tc_del_filter will fail when flow del. The mapping of ufid to tc will not be deleted. The traffic will trigger the same flow(with same ufid) to put to tc on the

Re: [ovs-dev] [PATCH ovn 2/3] system-ovn.at: Add system test for virtual port with floating IP.

On Wed, Mar 01, 2023 at 02:27:29PM -0800, Han Zhou wrote: > On Wed, Mar 1, 2023 at 1:50 AM Simon Horman > wrote: > > > > On Wed, Feb 22, 2023 at 10:35:25PM -0800, Han Zhou wrote: > > > > Please add a patch description here. > > Thank Simon for reviewing. For this commit, I think the commit title

Re: [ovs-dev] [PATCH v7] netdev-offload-tc: del ufid mapping if device not exist

It's great! I should have read the comment. A new patch will be published soon. From: Ilya Maximets Date: 2023-03-01 19:34:01 To: Faicker Mo Cc: d...@openvswitch.org,i.maxim...@ovn.org,Eelco Chaudron ,Simon Horman Subject: Re: [ovs-dev] [PATCH v7] netdev-offload-tc: del ufid mapping if

Re: [ovs-dev] [PATCH ovn v2 6/7] system-tests: Skip LB affinity for now with OvS userspace

On Wed, Mar 1, 2023 at 4:41 PM Simon Horman wrote: > On Wed, Mar 01, 2023 at 09:04:40AM -0500, Mark Michelson wrote: > > On 3/1/23 01:49, Simon Horman wrote: > > > On Wed, Mar 01, 2023 at 07:31:04AM +0100, Ales Musil wrote: > > > > On Tue, Feb 28, 2023 at 8:03 PM Mark Michelson > wrote: > > > >

[ovs-dev] [PATCH v6 4/5] ovs-router: Introduce src option in ovs/route/add command.

When adding a route with ovs/route/add command, the source address in "ovs_router_entry" structure is always the FIRST address that the interface has. See "ovs_router_get_netdev_source_address" function for more information. If an interface has multiple ipv4 and/or ipv6 addresses, there are use

[ovs-dev] [PATCH v6 2/5] ovs-router: Cleanup parser for ovs/route/add command.

This patch cleans up the parser to accept pkt_mark and gw in any order. pkt_mark and gw are normally expected to be specified exactly once. However, as with other tools, if specified multiple times, the last specification is used. Also, pkt_mark and gw have separate prefix strings so they can be

[ovs-dev] [PATCH v6 5/5] route-table: Retrieving the preferred source address from Netlink.

We can use the "ip route add ... src ..." command to set the preferred source address for each entry in the kernel FIB. OVS has a mechanism to cache the FIB, but the preferred source address is ignored and calculated with its own logic. This patch resolves the difference between kernel FIB and OVS

[ovs-dev] [PATCH v6 1/5] netdev-dummy: Support multiple IP addresses.

This is useful in test cases where multiple IPv4/IPv6 addresses are assigned together. Acked-by: Eelco Chaudron Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/netdev-dummy.c | 70 +- 1 file changed, 44 insertions(+), 26 deletions(-)

[ovs-dev] [PATCH v6 0/5] Add support for preffered src address in ovs-router

v6: - Fix notation quirks between man page and in-app help - Fix error message in ovs/route/add command - Fix coding style v5: - Add patch to fix man page v4: - Add cleanup patch for ovs/route/add - Remove unrelated code v3: - Fix netdev-dummy to support multiple IP addresses - Add validation and

[ovs-dev] [PATCH v6 3/5] ofproto: Fix mam page for tunnel related commands.

Fixed the manual page to indicate that both IPv4/IPv6 are supported. Also added missing pkt_mark on one side and fixed the "gw" and "bridge" notation quirks. Reviewed-by: Simon Horman Signed-off-by: Nobuhiro MIKI --- lib/ovs-router.c| 4 ++-- ofproto/ofproto-tnl-unixctl.man | 8

[ovs-dev] Can ovs dnat support 1:1 shifted port range mapping?

Hi, folks Netfilter added a shifted port range mapping function in Linux kernel 4.19, it looks like this: iptables -t nat -A zone_wan_prerouting -p tcp -m tcp --dport 5000:5100 -j DNAT --to-destination '192.168.1.2:2000-2100/5000' 5000-51000 is mapped to 2000-2100 Can ovs ct

Re: [ovs-dev] [PATCH v5 0/5] Add support for preffered src address in ovs-router

On 2023/03/01 19:56, Ilya Maximets wrote: > On 3/1/23 11:41, Eelco Chaudron wrote: >> >> >> On 1 Mar 2023, at 11:40, Ilya Maximets wrote: >> >>> On 3/1/23 08:19, Eelco Chaudron wrote: On 28 Feb 2023, at 18:37, Ilya Maximets wrote: > On 2/22/23 11:29, Nobuhiro MIKI wrote:

Re: [ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Bump libovsdb to a6a173993830.

On Wed, Mar 1, 2023 at 7:25 PM Dumitru Ceara wrote: > > This is to match the ovn-kubernetes commit > https://github.com/ovn-org/ovn-kubernetes/commit/b5b61bc64aae > > Without it building the ovn-kubernetes container image fails because the > libovsdb modelgen doesn't generate the right type of

[ovs-dev] [PATCH ovn] ci: ovn-kubernetes: Bump libovsdb to a6a173993830.

This is to match the ovn-kubernetes commit https://github.com/ovn-org/ovn-kubernetes/commit/b5b61bc64aae Without it building the ovn-kubernetes container image fails because the libovsdb modelgen doesn't generate the right type of NB/SB models. Reported-at:

Re: [ovs-dev] [ovn] Backport request

On 3/1/23 09:52, Ales Musil wrote: > Hi, > Hi Ales, > just a note that [0] should be also backported to 21.12. > I pushed this to branch-21.12: https://github.com/ovn-org/ovn/commit/4fd307259def2ce3d97dd10ec1b326ea44a103d0 > Thanks, > Ales > > [0]

Re: [ovs-dev] [PATCH ovn] controller: Fix hairpin SNAT flow explosion for the same SNAT IPs case.

On 3/1/23 23:42, Ilya Maximets wrote: > On 2/28/23 16:28, Dumitru Ceara wrote: >> On 2/28/23 16:22, Ilya Maximets wrote: >>> On 2/28/23 16:14, Dumitru Ceara wrote: On 2/28/23 15:29, Ilya Maximets wrote: > On 2/28/23 01:03, Dumitru Ceara wrote: >> Hi Ilya, >> >> Thanks for the

Re: [ovs-dev] [PATCH ovn] controller: Fix hairpin SNAT flow explosion for the same SNAT IPs case.

On 2/28/23 16:28, Dumitru Ceara wrote: > On 2/28/23 16:22, Ilya Maximets wrote: >> On 2/28/23 16:14, Dumitru Ceara wrote: >>> On 2/28/23 15:29, Ilya Maximets wrote: On 2/28/23 01:03, Dumitru Ceara wrote: > Hi Ilya, > > Thanks for the patch, you're right the hairpin SNAT IP

[ovs-dev] [PATCH ovn v2] controller: Fix hairpin SNAT flow explosion if hairpin_snat_ip is set.

It's common to have 'hairpin_snat_ip' to be configured for each and every Load Balancer in a setup. For example, ovn-kubernetes does that, setting '169.254.169.5 fd69::5' value unconditionally for every LB:

Re: [ovs-dev] [PATCH ovn 2/3] system-ovn.at: Add system test for virtual port with floating IP.

On Wed, Mar 1, 2023 at 1:50 AM Simon Horman wrote: > > On Wed, Feb 22, 2023 at 10:35:25PM -0800, Han Zhou wrote: > > Please add a patch description here. Thank Simon for reviewing. For this commit, I think the commit title tells everything I wanted to describe, so I omitted it here rather than

Re: [ovs-dev] [PATCH ovn v2 6/7] system-tests: Skip LB affinity for now with OvS userspace

On Tue, Feb 21, 2023 at 01:32:06PM +0100, Ales Musil wrote: > There is a bug in userspace datapath that causes > failures within the LB affinity test [0]. > Skip the test until the bug is fixed. > > [0] https://bugzilla.redhat.com/2170828 > Signed-off-by: Ales Musil There is some discussion in

Re: [ovs-dev] [PATCH ovn v2 4/7] system-tests: Replace use of ADD_INT with ADD_VETH

On Wed, Mar 01, 2023 at 05:00:24PM +0100, Ales Musil wrote: > On Wed, Mar 1, 2023 at 4:30 PM Simon Horman > wrote: > > > On Tue, Feb 21, 2023 at 01:32:04PM +0100, Ales Musil wrote: > > > The ADD_INT does not work very well with userspace datapath. > > > To avoid any warnings that might fail the

Re: [ovs-dev] [PATCH ovn v2 3/7] system-tests: Do not use verbose output for ping6

On Wed, Mar 01, 2023 at 04:53:57PM +0100, Ales Musil wrote: > On Wed, Mar 1, 2023 at 3:47 PM Simon Horman > wrote: > > > On Tue, Feb 21, 2023 at 01:32:03PM +0100, Ales Musil wrote: > > > Newer versions of ping6 print some info to > > > stderr when specified with -v flag. This info > > > causes

Re: [ovs-dev] [PATCH ovn 2/3] ovn-util: Optimize is_dynamic_lsp_address.

On 3/1/23 20:17, Mark Michelson wrote: > Hi Ilya, I have a small suggestion below. > > On 2/27/23 15:03, Ilya Maximets wrote: >> For non-dynamic address, current version performs 1 strcmp + 4 attempts >> for ovs_scan.  Updated code perfroms 1 strncmp + 1 ovs_scan. >> >> Also, for ports with both

Re: [ovs-dev] [PATCH ovn 3/3] northd: Don't parse LSP addresses twice.

Acked-by: Mark Michelson On 2/27/23 15:03, Ilya Maximets wrote: At the point of IPAM configuration all the addresses are already parsed. No need to waste time parsing them again. Signed-off-by: Ilya Maximets --- northd/northd.c | 54 - 1

Re: [ovs-dev] [PATCH ovn 1/3] treewide: Remove unnecessary strlen() calls.

Acked-by: Mark Michelson On 2/27/23 15:03, Ilya Maximets wrote: In many cases OVN components are using strlen() to check if the string is not empty. In that case, unnecessary scan of the whole string is performed and the length is calculated, while it's enough to just check the first byte.

Re: [ovs-dev] [PATCH ovn 2/3] ovn-util: Optimize is_dynamic_lsp_address.

Hi Ilya, I have a small suggestion below. On 2/27/23 15:03, Ilya Maximets wrote: For non-dynamic address, current version performs 1 strcmp + 4 attempts for ovs_scan. Updated code perfroms 1 strncmp + 1 ovs_scan. Also, for ports with both IPv4 and IPv6 specified, new version doesn't re-parse

Re: [ovs-dev] [PATCH ovn 10/12] tests: Fixed some tests failing on (very) slow systems

I pushed this change to main and all branches from 22.03 up to 23.03. On 2/10/23 02:58, Ales Musil wrote: On Fri, Dec 2, 2022 at 2:53 PM Xavier Simonart wrote: When running unit tests on a s390x VM with a x86 host, many tests fail due to the very slow speed of the system. Signed-off-by:

Re: [ovs-dev] [PATCH ovn v2 1/7] ci: Add support for userspace system test

On Wed, Mar 01, 2023 at 04:43:31PM +0100, Simon Horman wrote: > On Tue, Feb 21, 2023 at 01:32:01PM +0100, Ales Musil wrote: > > Add support for running system tests with > > OvS userspace netdev. > > > > Signed-off-by: Ales Musil > > Reviewed-by: Simon Horman I exercise this here:

Re: [ovs-dev] [PATCH ovn v2 7/7] ci: Replace clang jemalloc suite with system-test-userspace

On Tue, Feb 21, 2023 at 01:32:07PM +0100, Ales Musil wrote: > The test with jemalloc and clang is redundant as > we are already testing jemalloc with gcc. Replace > it with system-test-userspace which runs system tests > over userspace OvS datapath. > > Signed-off-by: Ales Musil FWIIW, I would

Re: [ovs-dev] [PATCH ovn v2 4/7] system-tests: Replace use of ADD_INT with ADD_VETH

On Wed, Mar 1, 2023 at 4:30 PM Simon Horman wrote: > On Tue, Feb 21, 2023 at 01:32:04PM +0100, Ales Musil wrote: > > The ADD_INT does not work very well with userspace datapath. > > To avoid any warnings that might fail the tests > > use ADD_VETH instead. Also encourage this in > > documentation

Re: [ovs-dev] [PATCH ovn v2 3/7] system-tests: Do not use verbose output for ping6

On Wed, Mar 1, 2023 at 3:47 PM Simon Horman wrote: > On Tue, Feb 21, 2023 at 01:32:03PM +0100, Ales Musil wrote: > > Newer versions of ping6 print some info to > > stderr when specified with -v flag. This info > > causes tests to fail. Do not use the verbose > > output. > > > > Signed-off-by:

Re: [ovs-dev] [PATCH ovn v2 5/7] system-tests: Use revalidator/purge instead of dpctl/del-flows

On Tue, Feb 21, 2023 at 01:32:05PM +0100, Ales Musil wrote: > The dpctl/del-flows shouldn't be used on running > ofproto layer, use revalidator/purge instead. > > Signed-off-by: Ales Musil Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev

Re: [ovs-dev] [PATCH ovn v2 1/7] ci: Add support for userspace system test

On Tue, Feb 21, 2023 at 01:32:01PM +0100, Ales Musil wrote: > Add support for running system tests with > OvS userspace netdev. > > Signed-off-by: Ales Musil Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn v2 6/7] system-tests: Skip LB affinity for now with OvS userspace

On Wed, Mar 01, 2023 at 09:04:40AM -0500, Mark Michelson wrote: > On 3/1/23 01:49, Simon Horman wrote: > > On Wed, Mar 01, 2023 at 07:31:04AM +0100, Ales Musil wrote: > > > On Tue, Feb 28, 2023 at 8:03 PM Mark Michelson > > > wrote: > > > > > > > Hi Ales, > > > > > > > > > > > May I suggest

Re: [ovs-dev] [PATCH ovn v2 4/7] system-tests: Replace use of ADD_INT with ADD_VETH

On Tue, Feb 21, 2023 at 01:32:04PM +0100, Ales Musil wrote: > The ADD_INT does not work very well with userspace datapath. > To avoid any warnings that might fail the tests > use ADD_VETH instead. Also encourage this in > documentation for ADD_INT, because there should > be good reasoning behind

Re: [ovs-dev] [PATCH] ofproto-dpif-mirror: Add support for pre-selection filter

Hi Mike, This patch will need some rebasing. On Tue, Nov 1, 2022 at 5:27 PM Mike Pattrick wrote: > > Currently a bridge mirror will collect all packets and tools like > ovs-tcpdump can apply additional filters after they have already been > duplicated by vswitchd. This can result in

Re: [ovs-dev] [PATCH ovn v2 3/7] system-tests: Do not use verbose output for ping6

On Tue, Feb 21, 2023 at 01:32:03PM +0100, Ales Musil wrote: > Newer versions of ping6 print some info to > stderr when specified with -v flag. This info > causes tests to fail. Do not use the verbose > output. > > Signed-off-by: Ales Musil I think it would be useful to describe the difference

Re: [ovs-dev] [PATCH ovn v2 2/7] ovs: Bump submodule to recent branch-3.1

On Tue, Feb 21, 2023 at 01:32:02PM +0100, Ales Musil wrote: > Bump ovs submodule to b72a7f92 which is after > ed44eefb ("conntrack: Properly unNAT inner header of related traffic."). > This patch is needed for "LB - ICMP related traffic" system test to work > with OvS userspace netdev. > >

Re: [ovs-dev] After enable dpdk，many threads were affinitied only to the first lcore cpu.

On 15/02/2023 05:50, ChangLimin wrote: Before enable dpdk, all ovs-vswitch threads were affinitied to cpu 0-27. Cpu 28-31 were isolated in grub, will used for pmd. After enable dpdk, many threads were affinitied only to the first lcore cpu. Below is the output: # ovs-vsctl --no-wait set

Re: [ovs-dev] [PATCH ovn v2 6/7] system-tests: Skip LB affinity for now with OvS userspace

On 3/1/23 01:49, Simon Horman wrote: On Wed, Mar 01, 2023 at 07:31:04AM +0100, Ales Musil wrote: On Tue, Feb 28, 2023 at 8:03 PM Mark Michelson wrote: Hi Ales, May I suggest placing the tests that are failing with the userspace datapath into the tests/system-ovn-kmod.at file? The current

Re: [ovs-dev] [PATCH v22 4/8] netdev-offload-tc: Add sFlow offload API for TC

On 3/1/23 14:21, Ilya Maximets wrote: > On 3/1/23 14:08, Chris Mi wrote: >> On 3/1/2023 8:44 PM, Ilya Maximets wrote: >>> On 2/28/23 14:05, Chris Mi wrote: On 2/24/2023 4:16 AM, Ilya Maximets wrote: > On 2/23/23 12:26, Chris Mi wrote: >> Initialize psample socket. Add sFlow recv API

Re: [ovs-dev] [PATCH v22 4/8] netdev-offload-tc: Add sFlow offload API for TC

On 3/1/23 14:08, Chris Mi wrote: > On 3/1/2023 8:44 PM, Ilya Maximets wrote: >> On 2/28/23 14:05, Chris Mi wrote: >>> On 2/24/2023 4:16 AM, Ilya Maximets wrote: On 2/23/23 12:26, Chris Mi wrote: > Initialize psample socket. Add sFlow recv API to receive sampled > packets from psample

Re: [ovs-dev] [PATCH v22 7/8] netdev-offload-tc: Add offload support for sFlow

On 3/1/2023 8:58 PM, Ilya Maximets wrote: On 2/28/23 14:17, Chris Mi wrote: On 2/24/2023 4:46 AM, Ilya Maximets wrote: On 2/23/23 12:27, Chris Mi wrote: Create a unique group ID to map the sFlow info when offloading sample action to TC. When showing the offloaded datapath flows, translate the

Re: [ovs-dev] [PATCH v22 4/8] netdev-offload-tc: Add sFlow offload API for TC

On 3/1/2023 8:44 PM, Ilya Maximets wrote: On 2/28/23 14:05, Chris Mi wrote: On 2/24/2023 4:16 AM, Ilya Maximets wrote: On 2/23/23 12:26, Chris Mi wrote: Initialize psample socket. Add sFlow recv API to receive sampled packets from psample socket. Add sFow recv wait API to add psample socket

Re: [ovs-dev] [PATCH v22 7/8] netdev-offload-tc: Add offload support for sFlow

On 2/28/23 14:17, Chris Mi wrote: > On 2/24/2023 4:46 AM, Ilya Maximets wrote: >> On 2/23/23 12:27, Chris Mi wrote: >>> Create a unique group ID to map the sFlow info when offloading sample >>> action to TC. When showing the offloaded datapath flows, translate the >>> group ID from TC sample

Re: [ovs-dev] [PATCH v22 4/8] netdev-offload-tc: Add sFlow offload API for TC

On 2/28/23 14:05, Chris Mi wrote: > On 2/24/2023 4:16 AM, Ilya Maximets wrote: >> On 2/23/23 12:26, Chris Mi wrote: >>> Initialize psample socket. Add sFlow recv API to receive sampled >>> packets from psample socket. Add sFow recv wait API to add psample >>> socket fd to poll list. >>> >>>

Re: [ovs-dev] [PATCH v7 1/2] ofp, dpif: Allow CT flush based on partial match

On Wed, Mar 1, 2023 at 12:34 PM Roi Dayan wrote: > > > On 01/03/2023 12:53, Roi Dayan via dev wrote: > > > > > > On 16/01/2023 13:45, Ales Musil wrote: > >> Currently, the CT can be flushed by dpctl only by specifying > >> the whole 5-tuple. This is not very convenient when there are > >> only

Re: [ovs-dev] [PATCH v7 1/2] ofp, dpif: Allow CT flush based on partial match

On 01/03/2023 12:53, Roi Dayan via dev wrote: > > > On 16/01/2023 13:45, Ales Musil wrote: >> Currently, the CT can be flushed by dpctl only by specifying >> the whole 5-tuple. This is not very convenient when there are >> only some fields known to the user of CT flush. Add new struct >>

Re: [ovs-dev] [PATCH v7] netdev-offload-tc: del ufid mapping if device not exist

On 3/1/23 03:12, Faicker Mo wrote: > The device may be deleted and added with ifindex changed. > The tc rules on the device will be deleted if the device is deleted. > The func tc_del_filter will fail when flow del. The mapping of > ufid to tc will not be deleted. > The traffic will trigger the

Re: [ovs-dev] [PATCH v5 0/5] Add support for preffered src address in ovs-router

On 3/1/23 11:41, Eelco Chaudron wrote: > > > On 1 Mar 2023, at 11:40, Ilya Maximets wrote: > >> On 3/1/23 08:19, Eelco Chaudron wrote: >>> >>> >>> On 28 Feb 2023, at 18:37, Ilya Maximets wrote: >>> On 2/22/23 11:29, Nobuhiro MIKI wrote: > With this series, the preferred source address

Re: [ovs-dev] [PATCH v7] netdev-offload-tc: del ufid mapping if device not exist

On Wed, Mar 01, 2023 at 08:33:04AM +0100, Eelco Chaudron wrote: > > > On 1 Mar 2023, at 3:12, Faicker Mo wrote: > > > The device may be deleted and added with ifindex changed. > > The tc rules on the device will be deleted if the device is deleted. > > The func tc_del_filter will fail when flow

Re: [ovs-dev] [PATCH v7 1/2] ofp, dpif: Allow CT flush based on partial match

On 16/01/2023 13:45, Ales Musil wrote: > Currently, the CT can be flushed by dpctl only by specifying > the whole 5-tuple. This is not very convenient when there are > only some fields known to the user of CT flush. Add new struct > ofputil_ct_match which represents the generic filtering that

Re: [ovs-dev] [PATCH v5 0/5] Add support for preffered src address in ovs-router

On 1 Mar 2023, at 11:40, Ilya Maximets wrote: > On 3/1/23 08:19, Eelco Chaudron wrote: >> >> >> On 28 Feb 2023, at 18:37, Ilya Maximets wrote: >> >>> On 2/22/23 11:29, Nobuhiro MIKI wrote: With this series, the preferred source address in ovs-router is obtained from both ovs/route/add

Re: [ovs-dev] [PATCH v5 0/5] Add support for preffered src address in ovs-router

On 3/1/23 08:19, Eelco Chaudron wrote: > > > On 28 Feb 2023, at 18:37, Ilya Maximets wrote: > >> On 2/22/23 11:29, Nobuhiro MIKI wrote: >>> With this series, the preferred source address in ovs-router is obtained >>> from both ovs/route/add command and kernel FIB. >>> >>> v5: >>> - Add patch to

Re: [ovs-dev] [PATCH 2/2] ci: Run tc offload tests in GitHub Actions.

On Wed, Mar 01, 2023 at 11:21:02AM +0100, Eelco Chaudron wrote: > > > On 28 Feb 2023, at 17:23, Simon Horman wrote: > > > On Tue, Feb 28, 2023 at 04:24:57PM +0100, Eelco Chaudron wrote: > >> > >> > >> On 16 Feb 2023, at 13:21, Eelco Chaudron wrote: > >> > >>> On 15 Feb 2023, at 21:15, Ilya

Re: [ovs-dev] [PATCH 2/2] ci: Run tc offload tests in GitHub Actions.

On 28 Feb 2023, at 17:23, Simon Horman wrote: > On Tue, Feb 28, 2023 at 04:24:57PM +0100, Eelco Chaudron wrote: >> >> >> On 16 Feb 2023, at 13:21, Eelco Chaudron wrote: >> >>> On 15 Feb 2023, at 21:15, Ilya Maximets wrote: >>> On 2/14/23 14:54, Eelco Chaudron wrote: > Run "make

Re: [ovs-dev] [PATCH v5 5/5] route-table: Retrieving the preferred source address from Netlink.

On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote: > We can use the "ip route add ... src ..." command to set the preferred > source address for each entry in the kernel FIB. OVS has a mechanism to > cache the FIB, but the preferred source address is ignored and > calculated with its own logic.

Re: [ovs-dev] [PATCH v5 4/5] ovs-router: Introduce src option in ovs/route/add command.

On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote: > When adding a route with ovs/route/add command, the source address > in "ovs_router_entry" structure is always the FIRST address that the > interface has. See "ovs_router_get_netdev_source_address" > function for more information. > > If an

Re: [ovs-dev] [PATCH v5 3/5] ofproto: Fix mam page for tunnel related commands.

On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote: > These commands already support both IPv4 and IPv6. > > Signed-off-by: Nobuhiro MIKI > --- > ofproto/ofproto-tnl-unixctl.man | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/ofproto/ofproto-tnl-unixctl.man

Re: [ovs-dev] [PATCH v5 2/5] ovs-router: Cleanup parser for ovs/route/add command.

On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote: > This patch cleans up the parser to accept pkt_mark and gw in any order. > > pkt_mark and gw are normally expected to be specified exactly once. > However, as with other tools, if specified multiple times, the last > specification is used. Also,

Re: [ovs-dev] [PATCH ovn 2/3] system-ovn.at: Add system test for virtual port with floating IP.

On Wed, Feb 22, 2023 at 10:35:25PM -0800, Han Zhou wrote: Please add a patch description here. > Signed-off-by: Han Zhou > --- > tests/atlocal.in| 3 + > tests/system-ovn.at | 146 > 2 files changed, 149 insertions(+) ... >

Re: [ovs-dev] [PATCH v5 1/5] netdev-dummy: Support multiple IP addresses.

On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote: > This is useful in test cases where multiple IPv4/IPv6 addresses > are assigned together. > > Reviewed-by: Simon Horman > Signed-off-by: Nobuhiro MIKI With the suggested changes applied by Ilya this patch looks good to me. Acked-by: Eelco

Re: [ovs-dev] [PATCH ovn 1/3] ovn.at: Fix virtual port tests.

On Wed, Feb 22, 2023 at 10:35:24PM -0800, Han Zhou wrote: > The check_virtual_offlows_not_present() function in the case "virtual > ports" has the wrong table id 45, which should be 44. However, > correcting the table id makes the case failing, because the two ACLs > added by the case were in fact

[ovs-dev] [ovn] Backport request

Hi, just a note that [0] should be also backported to 21.12. Thanks, Ales [0] https://github.com/ovn-org/ovn/commit/bc8691d7 -- Ales Musil Senior Software Engineer - OVN Core Red Hat EMEA amu...@redhat.comIM: amusil

Re: [ovs-dev] [PATCH ovn] system-tests: Reduce flakiness of ACL reject tests

On Tue, Feb 21, 2023 at 01:38:56PM +0100, Ales Musil wrote: > The tests are looking for specific output from tcpdump > counting number of occurrences and expecting only 1. It > might happen that in the time period there are already two > or more packets and the test simply fails. Change the

[ovs-dev] [PATCH v4] utilities/ofctl: add-meters for save and restore

put dump-meters' result in one line so add-meters can handle. save and restore meters when restart ovs. bundle functions are not implemented in this patch. Signed-off-by: Wan Junjie --- v4: code refactor according to comments v3: add '--oneline' option for dump-meter(s) command v2: fix failed