Re: [ovs-dev] [PATCH 2/2] dpif-netdev/mfex: Add AVX512 NVGRE traffic profiles.

2022-12-21 Thread Stokes, Ian
> On 12/21/22 15:59, Stokes, Ian wrote: > >> On 16 Sep 2022, at 12:12, Cian Ferriter wrote: > >> > >>> A typical NVGRE encapsulated packet starts with the ETH/IP/GRE > >>> protocols. Miniflow extract will parse just the ETH and IP headers. The >

Re: [ovs-dev] [PATCH 2/2] dpif-netdev/mfex: Add AVX512 NVGRE traffic profiles.

2022-12-21 Thread Stokes, Ian
> On 16 Sep 2022, at 12:12, Cian Ferriter wrote: > > > A typical NVGRE encapsulated packet starts with the ETH/IP/GRE > > protocols. Miniflow extract will parse just the ETH and IP headers. The > > GRE header will be processed later as part of the pop action. Add > > support for parsing the

Re: [ovs-dev] [PATCH 1/2] dpif-netdev/dpcls: Specialize 8, 1 and 5, 2 signatures.

2022-12-21 Thread Stokes, Ian
> On 16 Sep 2022, at 12:12, Cian Ferriter wrote: > > > The subtable signatures being specialized here were found in an NVGRE > > tunnel scenario. > > > > Signed-off-by: Cian Ferriter > > --- > > Sorry for the late response, but I was rather busy. > Changes look good to me, and did basic testing

Re: [ovs-dev] [v8] odp-execute: Add ISA implementation of set_masked IPv6 action

2022-12-21 Thread Stokes, Ian
> > -Original Message- > > From: dev On Behalf Of Eelco Chaudron > > Sent: Wednesday 14 December 2022 11:17 > > To: Finn, Emma > > Cc: d...@openvswitch.org; i.maxim...@ovn.org > > Subject: Re: [ovs-dev] [v8] odp-execute: Add ISA implementation of > set_masked > > IPv6 action > > > > > >

Re: [ovs-dev] [PATCH v4] dpdk: Update to use v22.11.1.

2022-12-06 Thread Stokes, Ian
> > > > On 12/5/22 22:31, Ian Stokes wrote: > > > > > This commit add support to for DPDK v22.11.1, it includes the > > > > > following changes. > > > > > > > > > > 1. ci: Reduce DPDK compilation time. > > > > > 2. system-dpdk: Update vhost tests to be compatible with DPDK 22.07. > > > > > > > > >

Re: [ovs-dev] [PATCH v4] dpdk: Update to use v22.11.1.

2022-12-06 Thread Stokes, Ian
> On 12/5/22 22:31, Ian Stokes wrote: > > This commit add support to for DPDK v22.11.1, it includes the following > > changes. > > > > 1. ci: Reduce DPDK compilation time. > > 2. system-dpdk: Update vhost tests to be compatible with DPDK 22.07. > > > >

Re: [ovs-dev] [RFC PATCH v2] dpdk: Update to use v22.11.

2022-12-05 Thread Stokes, Ian
> > On Thu, Dec 1, 2022 at 3:24 PM Ilya Maximets wrote: > Frode, do you know the approximate timeline on when we could expect > >>> > >>> As explained above, without landing this ... never :-) > >>> But speaking of timeline - we'd prefer to get this resolved for > >>> Debian/Ubuntu before

Re: [ovs-dev] [PATCH v3] dpdk: Update to use v22.11.

2022-12-05 Thread Stokes, Ian
> Hi Ian, > > On Wed, Nov 30, 2022 at 4:32 PM Ian Stokes wrote: > > > > This commit add support to for DPDK v22.11, it includes the following > > changes. > > > > 1. ci: Reduce DPDK compilation time. > > 2. system-dpdk: Update vhost tests to be compatible with DPDK 22.07. > > > >

Re: [ovs-dev] [RFC PATCH v2] dpdk: Update to use v22.11.

2022-11-30 Thread Stokes, Ian
> Hi Ian, > > Cc: Thomas and John > > On Wed, Nov 23, 2022 at 12:52 PM Ian Stokes wrote: > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > > index 23c8bbb7a..0aa90e55e 100755 > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > @@ -142,7 +142,7 @@ function install_dpdk() > >

Re: [ovs-dev] [RFC PATCH v2] dpdk: Update to use v22.11.

2022-11-30 Thread Stokes, Ian
: Re: [ovs-dev] [RFC PATCH v2] dpdk: Update to use v22.11. > > On 11/23/22 12:52, Ian Stokes wrote: > > This commit add support to for DPDK v22.11, it includes the following > > changes. > > > > 1. ci: Reduce DPDK compilation time. > > 2. system-dpdk: Update vhost tests to be compatible with DPDK

Re: [ovs-dev] [PATCH] ci: Update meson requirement for DPDK.

2022-11-05 Thread Stokes, Ian
> The current version of meson used for building DPDK is 0.49.2. > > This has the restriction of holding the required python version to 3.9. > > A recent change [1] in DPDK bumped requirements on meson to 0.53.2. > > Update the version of meson used to build DPDK to 0.53.2 to remove the >

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

2022-11-03 Thread Stokes, Ian
On Thu, Nov 3, 2022 at 1:16 PM Ilya Maximets wrote: > > > > > > On 11/3/22 13:11, David Marchand wrote: > > > > On Thu, Nov 3, 2022 at 12:51 PM Ilya Maximets > > wrote: > > > >> Can we bump meson to that new version on all branches? > > > > > > > > I would not expect an issue, but I did not test

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

2022-11-03 Thread Stokes, Ian
> On Thu, Nov 3, 2022 at 1:16 PM Ilya Maximets wrote: > > > > On 11/3/22 13:11, David Marchand wrote: > > > On Thu, Nov 3, 2022 at 12:51 PM Ilya Maximets > wrote: > > >> Can we bump meson to that new version on all branches? > > > > > > I would not expect an issue, but I did not test it. > > >

Re: [ovs-dev] [PATCH dpdk-latest] ci: Update meson requirement for DPDK 22.11.

2022-11-03 Thread Stokes, Ian
> On Thu, Nov 3, 2022 at 12:50 AM Ian Stokes wrote: > > > > A recent change [1] in DPDK bumped requirements on meson to 0.53.2. > > > > [1] https://git.dpdk.org/dpdk/commit/?id=909ad7b80e5e > > > > Signed-off-by: Ian Stokes > > Now that rc2 is out, I was about to resend my dpdk-latest series

Re: [ovs-dev] [branch-2.17, v2] dpdk: Use DPDK 21.11.2 release.

2022-10-04 Thread Stokes, Ian
> > -Original Message- > > From: Stokes, Ian > > Sent: Monday 3 October 2022 18:12 > > To: Phelan, Michael ; d...@openvswitch.org > > Cc: ktray...@redhat.com; i.maxim...@ovn.org; > > maxime.coque...@redhat.com > > Subject: RE: [branc

Re: [ovs-dev] [branch-2.17, v2] dpdk: Use DPDK 21.11.2 release.

2022-10-03 Thread Stokes, Ian
> Update OVS CLI and relevant documentation to use DPDK 21.11.2. > > DPDK 21.11.2 contains fixes for the CVEs listed below: > CVE-2022-28199 [1] > CVE-2022-2132 [2] > > A bug was introduced in DPDK 21.11.1 by the commit 01e3dee29c02 ("vhost: fix > unsafe vring addresses modifications"). > This

Re: [ovs-dev] [branch-2.13] dpdk: Use DPDK 19.11.13 release.

2022-10-03 Thread Stokes, Ian
> On 22/09/2022 15:51, Michael Phelan wrote: > > Update OVS CLI and relevant documentation to use DPDK 19.11.13. > > > > DPDK 19.11.13 contains fixes for the CVEs listed below: > > CVE-2022-28199 [1] > > CVE-2022-2132 [2] > > > > A bug was introduced in DPDK 19.11.12 by the commit 1e68fe334ff0

Re: [ovs-dev] [branch-2.14] dpdk: Use DPDK 19.11.13 release.

2022-10-03 Thread Stokes, Ian
> -Original Message- > From: Kevin Traynor > Sent: Friday, September 30, 2022 11:43 AM > To: Phelan, Michael ; d...@openvswitch.org > Cc: Stokes, Ian ; i.maxim...@ovn.org; > maxime.coque...@redhat.com > Subject: Re: [branch-2.14] dpdk: Use DPDK 19.11.13 release.

Re: [ovs-dev] [branch-2.16, v3] dpdk: Use DPDK 20.11.6 release.

2022-10-03 Thread Stokes, Ian
> -Original Message- > From: Kevin Traynor > Sent: Friday, September 30, 2022 11:43 AM > To: Phelan, Michael ; d...@openvswitch.org > Cc: Stokes, Ian ; i.maxim...@ovn.org; > maxime.coque...@redhat.com; david.march...@redhat.com > Subject: Re: [branch-2.16, v3] d

Re: [ovs-dev] [branch-2.15, v3] dpdk: Use DPDK 20.11.6 release.

2022-10-03 Thread Stokes, Ian
> On 29/09/2022 18:00, Michael Phelan wrote: > > Update OVS CLI and relevant documentation to use DPDK 20.11.6. > > > > A bug was introduced in DPDK 20.11.5 by the commit > > 33f2e3756186 ("vhost: fix unsafe vring addresses modifications"). > > This bug can cause a deadlock when vIOMMU is enabled

Re: [ovs-dev] [PATCH 0/4] dpdk-latest rebase

2022-09-14 Thread Stokes, Ian
> This series is a rebase of dpdk-latest branch on top of commit > 5046f2e35f62 ("sset, smap, hmapx: Reserve hash map space while cloning."). > > This rebase needed some additional work: > - added Debian packaging jobs in GHA are irrelevant to this branch, and > had to be disabled, > - recent

Re: [ovs-dev] [PATCH] github: Skip debian packaging for dpdk-latest.

2022-09-01 Thread Stokes, Ian
> > On 8/25/22 14:52, David Marchand wrote: > > > Debian packaging target builds OVS against a packaged DPDK version. > > > As a result, it is not relevant in the dpdk-latest branch which follows > > > DPDK development branch. > > > > > > Signed-off-by: David Marchand > > > --- > > >

Re: [ovs-dev] [PATCH branch-3.0 0/3] Release patches for v3.0.0.

2022-08-15 Thread Stokes, Ian
> Ilya Maximets (3): > releases: Mark 2.17 as a new LTS release. > Set release date for 3.0.0. > Prepare for 3.0.1. > > Documentation/faq/releases.rst | 2 +- > NEWS | 5 - > configure.ac | 2 +- > debian/changelog | 8 +++-

Re: [ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check.

2022-08-12 Thread Stokes, Ian
> > > > -Original Message- > > > > From: dev On Behalf Of Cian > > > Ferriter > > > > Sent: Thursday, August 11, 2022 4:07 PM > > > > To: ovs-dev@openvswitch.org > > > > Subject: [ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check. > > > > > > > > Support for vpopcntdq instruction

Re: [ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check.

2022-08-11 Thread Stokes, Ian
> > -Original Message- > > From: dev On Behalf Of Cian > Ferriter > > Sent: Thursday, August 11, 2022 4:07 PM > > To: ovs-dev@openvswitch.org > > Subject: [ovs-dev] [PATCH] acinclude: Improve vpopcntdq build check. > > > > Support for vpopcntdq instruction generation by the compiler was >

Re: [ovs-dev] [PATCH v2] dpif-netdev: Simplify AVX512 build time checks to enhance readability.

2022-08-10 Thread Stokes, Ian
> > > The preprocessor comparison string to check AVX512 capabilities are > > > lengthy and effecting user readability. Simpify this by aliasing the > > checks. > > > > > > Suggested-by: Eelco Chaudron > > > Signed-off-by: Sunil Pai G > > > > > > --- > > > v2: rebase on master, added alias for

Re: [ovs-dev] [PATCH dpdk-latest v2] system-dpdk: Update vhost tests to be compatible with DPDK 22.07.

2022-07-27 Thread Stokes, Ian
> The DPDK commit [1] improves the socket layer logs in the vhost library > to ease log filtering and debugging. > Update the system-dpdk vhost tests to reflect this change. > > [1] c85c35b1d447 ("vhost: improve socket layer logs") > > Signed-off-by: Sunil Pai G > Thanks for the patch Sunil,

Re: [ovs-dev] [ovs-build] |fail| pw1656877 [ovs-dev, 2/2] Prepare for post-3.0.0 (3.0.90).

2022-07-19 Thread Stokes, Ian
> On 7/15/22 20:33, Ilya Maximets wrote: > > On 7/15/22 20:24, Stokes, Ian wrote: > >>> Looks like new MTU tests are unstable. > >>> Ian, Michael, could you, please, check? > >>> > >>> Best regards, Ilya Maximets. > >> > >>

Re: [ovs-dev] [ovs-build] |fail| pw1656877 [ovs-dev, 2/2] Prepare for post-3.0.0 (3.0.90).

2022-07-15 Thread Stokes, Ian
> Looks like new MTU tests are unstable. > Ian, Michael, could you, please, check? > > Best regards, Ilya Maximets. Hey Ilya, Let me take a look at this, it passed our internal CI so not sure why it's failed externally, worst case I can revert this as it was really just a nice to have, if

Re: [ovs-dev] [PATCH] systemd-dpdk: Fix typo's and capitalize first word.

2022-07-15 Thread Stokes, Ian
> Signed-off-by: Sunil Pai G Thanks Sunil, this patch seems fairy straight forward (fixing typo and capitalizing comments), I've merged this to master. Thanks Ian ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 0/2] Patches to branch for 3.0.

2022-07-15 Thread Stokes, Ian
> Hey! It's been about 9 years since the last major version change. > And there were lots of large and important changes in OVS in that > long time frame. Nevertheless, removal of the kernel datapath > sources from the OVS's git tree seems like a notable enough point > in time to mark it with a

Re: [ovs-dev] [PATCH v4] tests: Add OVS-DPDK MTU unit tests.

2022-07-15 Thread Stokes, Ian
> This adds 8 new unit tests to the 'check-dpdk' subsystem that will > test Maximum Transmission Unit (MTU) functionality. > > Signed-off-by: Michael Phelan > Signed-off-by: Sunil Pai G > Co-authored-by: Sunil Pai G Thanks for the re-work on this, as discussed at the community call this week,

Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK QoS unit tests

2022-07-15 Thread Stokes, Ian
> This adds 4 new unit tests to the 'check-dpdk' subsystem that will > test Quality of Service (QoS) functionality. > > Signed-off-by: Michael Phelan > Thanks for the re-work on this, as discussed at the community call this week, this patch seems to be low risk and expands our unit tests for

Re: [ovs-dev] [v12 00/10] Actions Infrastructure + Optimizations

2022-07-15 Thread Stokes, Ian
> This patchset introduces actions infrastructure changes which allows > the user to choose between different action implementations based on > CPU ISA by using different commands. The infrastructure also > provides a way to check the correctness of the ISA optimized action > version against the

Re: [ovs-dev] [PATCH v2] tests: Add OVS-DPDK QoS unit tests

2022-07-15 Thread Stokes, Ian
> Hey Sunil, > Thanks for the comments, I've left some responses inline. Let me know > what you think. > > > -Original Message- > > From: Pai G, Sunil > > Sent: Wednesday 13 July 2022 14:51 > > To: Phelan, Michael ; d...@openvswitch.org > > Cc: maxime.coque...@redhat.com;

Re: [ovs-dev] [PATCH v5 0/3] DPDK shared mempool config.

2022-07-14 Thread Stokes, Ian
> This patchset optimizes for two cases when using shared mempools. > > If there are ports with different MTUs, that usually leads > to multiple shared mempools being created because mempool > mbuf size and hence creation is based from MTU. > > In fact, a port with a smaller MTU could share a

Re: [ovs-dev] [PATCH 1/14] Rename flags with CKSUM to CSUM

2022-07-12 Thread Stokes, Ian
> > Any response to these queries? I’m uncomfortable TBH with this feature > going in to 2.18 unless these are addressed/resolved. From an Intel > perspective we’re more than happy to test and review but there are > genuine issues to be discussed I feel below before merge. > > I tend to agree

Re: [ovs-dev] [PATCH v3] tests: Add OVS-DPDK MTU unit tests.

2022-07-12 Thread Stokes, Ian
nk this is safe enough. Thanks Ian. > Regards > Amber > > > > -Original Message- > > > From: Phelan, Michael > > > Sent: Monday 11 July 2022 14:49 > > > To: d...@openvswitch.org > > > Cc: Stokes, Ian ; acon...@redhat.com;

Re: [ovs-dev] [PATCH 1/14] Rename flags with CKSUM to CSUM

2022-07-12 Thread Stokes, Ian
: Amber, Kumar Sent: Thursday, July 7, 2022 10:52 AM To: f...@sysclose.org; m...@redhat.com; ovs-dev@openvswitch.org Cc: Ilya Maximets ; Van Haaren, Harry ; Stokes, Ian Subject: [ovs-dev] [PATCH 1/14] Rename flags with CKSUM to CSUM Hi Flavio, Mike, I did have a quick look over the patch-set

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Refactor simple match lookup functions.

2022-07-12 Thread Stokes, Ian
> Make the simple match functions used during lookup non-static to allow > reuse of these functions in the AVX512 DPIF. > > Signed-off-by: Cian Ferriter > Tested-by: Harry van Haaren > Thanks for the patch series Cian, given that this was discussed at the community call for exception I've

Re: [ovs-dev] [PATCH v4 1/1] netdev-dpdk: Delay vhost mempool creation.

2022-07-07 Thread Stokes, Ian
> Currently mempools for vhost are being assigned before the vhost device > is added. In some cases this may be just reusing an existing mempool but > in others it can require creation of a mempool. > > For multi-NUMA, the NUMA info of the vhost port is not known until a > device is added to the

Re: [ovs-dev] [PATCH v11 0/4] MFEX Optimizations IPv6 + Hashing Optimizations

2022-07-05 Thread Stokes, Ian
> The patchset introuduces IPv6 optimized MFEX profiles > with AVX512 which can deliver upto 20% to 30% gain in > performance over the existing scalar data-path. > > Hashing Optimization are also included which can further > improve performance by approximately 10%. > > The patch also removes

Re: [ovs-dev] [PATCH v2] Pmd.at: fix dpcls and dpif configuration test cases.

2022-07-01 Thread Stokes, Ian
> >> Without running set command first the string matching > >> fails on get command beacuse DPCLS prio value is different > >> for different default builds like with --enable-autovalidator > >> build auto-validator prio is set to 255 and if the build > >> is a scalar than generic value is default

Re: [ovs-dev] [PATCH v2] Pmd.at: fix dpcls and dpif configuration test cases.

2022-07-01 Thread Stokes, Ian
> Without running set command first the string matching > fails on get command beacuse DPCLS prio value is different > for different default builds like with --enable-autovalidator > build auto-validator prio is set to 255 and if the build > is a scalar than generic value is default 255. > > The

Re: [ovs-dev] [PATCH v6] tests/mfex: Improve pcap script for mfex tests.

2022-06-30 Thread Stokes, Ian
> The mfex pcap generation script is improved for varied length > traffic and also removes the hard coded mfex_pcap and instead uses > the script itself to generate complex traffic patterns for testing. > > Signed-off-by: Kumar Amber > Acked-by: Cian Ferriter Thanks Amber/Cian & Eelco for the

Re: [ovs-dev] [PATCH v4] tests: Add ovs-dpdk rate limiting unit tests.

2022-06-29 Thread Stokes, Ian
> From: Seamus Ryan > > This adds 4 new unit tests to the 'check-dpdk' subsystem that will > test rate limiting functionality. > > Signed-off-by: Seamus Ryan > Signed-off-by: Michael Phelan > Co-authored-by: Michael Phelan > Thanks for the patch Michael. >From what I can se all comments

Re: [ovs-dev] [PATCH] tests: Add OVS-DPDK QoS unit tests

2022-06-28 Thread Stokes, Ian
> -Original Message- > From: Phelan, Michael > Sent: Tuesday, June 21, 2022 11:19 AM > To: d...@openvswitch.org > Cc: Stokes, Ian ; acon...@redhat.com; > i.maxim...@ovn.org; maxime.coque...@redhat.com; Phelan, Michael > > Subject: [PATCH] tests: Add

Re: [ovs-dev] [PATCH] tests: Add OVS-DPDK MTU unit tests.

2022-06-28 Thread Stokes, Ian
> -Original Message- > From: Phelan, Michael > Sent: Tuesday, June 21, 2022 11:21 AM > To: d...@openvswitch.org > Cc: Stokes, Ian ; acon...@redhat.com; > i.maxim...@ovn.org; maxime.coque...@redhat.com; Phelan, Michael > > Subject: [PATCH] tests: Add

Re: [ovs-dev] [PATCH v3] tests: Add ovs-dpdk rate limiting unit tests.

2022-06-28 Thread Stokes, Ian
> This adds 4 new unit tests to the 'check-dpdk' subsystem that will > test rate limiting functionality. > > Signed-off-by: Seamus Ryan > Signed-off-by: Michael Phelan > Co-authored-by: Michael Phelan > > --- > v3: > - Removed NEWS entry. > - Added check to catch error if policer fails to

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: Delay vhost mempool creation.

2022-06-02 Thread Stokes, Ian
> On 01/06/2022 14:30, David Marchand wrote: > > On Wed, May 25, 2022 at 1:11 PM Kevin Traynor > wrote: > >> > >> Currently mempools for vhost are being assigned before the vhost > device > >> is added. In some cases this may be just reusing an existing mempool > but > >> in others it can

Re: [ovs-dev] [PATCH] dpcls: revert subtable-lookup-prio-get name change

2022-05-25 Thread Stokes, Ian
> On 25 May 2022, at 16:35, Stokes, Ian wrote: > > >> This commit reverts the name-change that was done (prio->info). > >> The change breaks a user visible ovs-appctl command, resulting in > >> breakage of tools/scripts/user-expectation outside of the OVS

Re: [ovs-dev] [PATCH] dpcls: revert subtable-lookup-prio-get name change

2022-05-25 Thread Stokes, Ian
> This commit reverts the name-change that was done (prio->info). > The change breaks a user visible ovs-appctl command, resulting in > breakage of tools/scripts/user-expectation outside of the OVS repo. > > This commit changes the documentation, command string, and unit tests > back to the

Re: [ovs-dev] [PATCH v7] dpcls: Change info-get function to fetch dpcls usage stats.

2022-05-24 Thread Stokes, Ian
> Modified the dplcs info-get command output to include > the count for different dpcls implementations. > > $ovs-appctl dpif-netdev/subtable-lookup-info-get > > Available dpcls implementations: > autovalidator (Use count: 1, Priority: 5) > generic (Use count: 0, Priority: 1) >

Re: [ovs-dev] [PATCH v5] dpcls: Change info-get function to fetch dpcls usage stats.

2022-05-10 Thread Stokes, Ian
> > Hi Ilya, > > > > Please find my replies inline. > > Hi all, this patch seems to have hit a wall, I can see there is a v6 that > came after > this that has been acked: > http://patchwork.ozlabs.org/project/openvswitch/patch/20220329101724.3148 > 572-1-kumar.am...@intel.com/ > > I would like

Re: [ovs-dev] [PATCH v5] dpcls: Change info-get function to fetch dpcls usage stats.

2022-05-04 Thread Stokes, Ian
> Hi Ilya, > > Please find my replies inline. Hi all, this patch seems to have hit a wall, I can see there is a v6 that came after this that has been acked: http://patchwork.ozlabs.org/project/openvswitch/patch/20220329101724.3148572-1-kumar.am...@intel.com/ I would like to see this work go

Re: [ovs-dev] [PATCH v10] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-05-04 Thread Stokes, Ian
> >> I'm not sure if we need a NEWS entry for this change as it's > >> only sort of user-visible. In any case, the current version > >> of the NEWS entry isn't really informative as it's unclear > >> for someone, who doesn't know the code, what does it mean. > >> Even from the developer's point

Re: [ovs-dev] [PATCH v10] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-05-04 Thread Stokes, Ian
> > Thanks for the review David, much appreciated. > > > > @Ilya Maximets are there any other blockers at this point on this series? I > > think > this is good to go from my side also but wanted to check with yourself if > outstanding issues you've flagged are resolved? > > The code changes

Re: [ovs-dev] [PATCH v10] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-05-04 Thread Stokes, Ian
> Hello Kumar, > > On Tue, Apr 12, 2022 at 4:13 PM Kumar Amber > wrote: > > > > For packets which don't already have a hash calculated, > > miniflow_hash_5tuple() calculates the hash of a packet > > using the previously built miniflow. > > > > This commit adds IPv4 profile specific hashing which

Re: [ovs-dev] [PATCH] tests: Add ovs-dpdk rate limiting unit tests.

2022-04-28 Thread Stokes, Ian
> > > > From: Seamus Ryan > > > > > > > > This adds 4 new unit tests to the 'check-dpdk' subsystem that will > > > > test rate limiting functionality. > > > > > > > > > > Thanks for the patch Michael, a few comments below. > > > > > > I'm still conducting some testing so may have some follow up

Re: [ovs-dev] [PATCH] tests: Add ovs-dpdk rate limiting unit tests.

2022-04-27 Thread Stokes, Ian
> > From: Seamus Ryan > > > > This adds 4 new unit tests to the 'check-dpdk' subsystem that will > > test rate limiting functionality. > > > > Thanks for the patch Michael, a few comments below. > > I'm still conducting some testing so may have some follow up comments for full > review. Hi

Re: [ovs-dev] [PATCH] tests: Add ovs-dpdk rate limiting unit tests.

2022-04-26 Thread Stokes, Ian
> From: Seamus Ryan > > This adds 4 new unit tests to the 'check-dpdk' subsystem that will > test rate limiting functionality. > Thanks for the patch Michael, a few comments below. I'm still conducting some testing so may have some follow up comments for full review. > Signed-off-by: Seamus

Re: [ovs-dev] [PATCH branch-2.17 0/2] Release patches for v2.17.1.

2022-04-08 Thread Stokes, Ian
> Ilya Maximets (2): > Set release date for 2.17.1. > Prepare for 2.17.2. > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 13 insertions(+), 3 deletions(-) > > -- > 2.34.1 Acked-by: Ian Stokes

Re: [ovs-dev] [PATCH branch-2.16 0/2] Release patches for v2.16.3.

2022-04-08 Thread Stokes, Ian
> Ilya Maximets (2): > Set release date for 2.16.3. > Prepare for 2.16.4. > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 13 insertions(+), 3 deletions(-) > > -- > 2.34.1 Acked-by: Ian Stokes

Re: [ovs-dev] [PATCH branch-2.15 0/2] Release patches for v2.15.4.

2022-04-08 Thread Stokes, Ian
> Ilya Maximets (2): > Set release date for 2.15.4. > Prepare for 2.15.5. > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 13 insertions(+), 3 deletions(-) > > -- > 2.34.1 Acked-by: Ian Stokes

Re: [ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.7.

2022-04-08 Thread Stokes, Ian
> Ilya Maximets (2): > Set release date for 2.13.7. > Prepare for 2.13.8. > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 13 insertions(+), 3 deletions(-) > > -- > 2.34.1 Acked-by: Ian Stokes

Re: [ovs-dev] [PATCH branch-2.14 0/2] Release patches for v2.14.5.

2022-04-08 Thread Stokes, Ian
> Ilya Maximets (2): > Set release date for 2.14.5. > Prepare for 2.14.6. > > NEWS | 6 +- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 13 insertions(+), 3 deletions(-) > > -- > 2.34.1 Acked-by: Ian Stokes

Re: [ovs-dev] [PATCH v9 1/4] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-04-08 Thread Stokes, Ian
> For packets which don't already have a hash calculated, > miniflow_hash_5tuple() calculates the hash of a packet > using the previously built miniflow. > > This commit adds IPv4 profile specific hashing which > uses fixed offsets into the packet to improve hashing > performance. > >

Re: [ovs-dev] [PATCH v8 4/4] tests/mfex: Improve pcap script for mfex tests.

2022-04-05 Thread Stokes, Ian
> The mfex pcap generation script is improved for varied length > traffic and also removes the hard coded mfex_pcap and instead uses > the script itself to generate complex traffic patterns for testing. > > Signed-off-by: Kumar Amber > So in general I think this approach is a bit more

Re: [ovs-dev] [PATCH v8 3/4] dpif-netdev/mfex: Avoid hashing when opt mfex called.

2022-04-05 Thread Stokes, Ian
> This patch avoids calculating the software hash of the packet again > if the optimized miniflow-extract hit. In cases of scalar miniflow > extract, the normal hashing calculation is performed. > > Signed-off-by: Kumar Amber Thanks for looking at this, seems straight forward enough. Think this

Re: [ovs-dev] [PATCH v8 1/4] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-04-05 Thread Stokes, Ian
> -Original Message- > From: Amber, Kumar > Sent: Friday, April 1, 2022 12:24 PM > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; Ferriter, Cian > ; f...@sysclose.org; Van Haaren, Harry > ; Amber, Kumar > Subject: [PATCH v8 1/4] dpif-netde

Re: [ovs-dev] [PATCH v8 2/4] dpif-netdev/mfex: Add packet hash check to autovalidator.

2022-04-05 Thread Stokes, Ian
> This patch adds the scalar hash calls to the autovalidator. > It also adds checks for comparing the scalar hash against > the profile based hash calculated as part of AVX512 MFEX implementations. > > The per profile AVX512 optimized hash was added to the autovalidator > in the last commit. The

[ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-03-24 Thread Stokes, Ian
Hi All, This meeting is a follow up to the call earlier this week. This week Sunil presented 3 different approaches to integrating DMA-Dev with OVS along with the performance impacts.

[ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-03-15 Thread Stokes, Ian
Hi All, The goal of this meeting is to ensure that all of DPDK DMA-dev library, DPDK Vhost library (consuming DMA-dev for acceleration) and OVS (as an end user of the DPDK DMA & VHost libraries) are working well together; and that the maintainers & contributors to those libraries are aware of

Re: [ovs-dev] OVS DPDK DSA Architecture/Design Discussion

2022-03-15 Thread Stokes, Ian
> 15/03/2022 12:14, Stokes, Ian: > > > 15/03/2022 11:27, Stokes, Ian: > > > > Hi All, > > > > > > > > We'd like to put a public meeting in place for the stakeholders > > > > of DPDK and OVS to discuss the next steps and design

[ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-03-15 Thread Stokes, Ian
Hi All, We'd like to put a public meeting in place for the stakeholders of DPDK and OVS to discuss the next steps and design of the DMA-DEV library along with its integration in OVS. There are a few different time zones involved so trying to find a best fit. Currently the suggestion is 2PM

[ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-03-15 Thread Stokes, Ian
Hi All, We'd like to put a public meeting in place for the stakeholders of DPDK and OVS to discuss the next steps and design of the DSA library along with its integration in OVS. There are a few different time zones involved so trying to find a best fit. Currently the suggestion is 2PM

Re: [ovs-dev] OVS DPDK DSA Architecture/Design Discussion

2022-03-15 Thread Stokes, Ian
> 15/03/2022 11:27, Stokes, Ian: > > Hi All, > > > > We'd like to put a public meeting in place for the stakeholders > > of DPDK and OVS to discuss the next steps and design of > > the DSA library along with its integration in OVS. > > There is no DSA

[ovs-dev] OVS DPDK DSA Architecture/Design Discussion

2022-03-15 Thread Stokes, Ian
Hi All, We'd like to put a public meeting in place for the stakeholders of DPDK and OVS to discuss the next steps and design of the DSA library along with its integration in OVS. There are a few different time zones involved so trying to find a best fit. Currently the suggestion is 2PM

Re: [ovs-dev] [PATCH] faq: Update OVS/DPDK version table for OVS 2.15/2.16

2022-03-14 Thread Stokes, Ian
> On 04/03/2022 10:12, Suneetha Kalahasthi wrote: > > FAQ is updated to reflect the latest DPDK for OVS branch 2.15 and 2.16 > > > > Signed-off-by: Suneetha Kalahasthi > > --- > > Documentation/faq/releases.rst | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

Re: [ovs-dev] [PATCH v2] dpif-netdev-dpcls: Make subtable reprobe thread-safe.

2022-02-15 Thread Stokes, Ian
> >> Thanks for the patch, in general this looks ok to me, but I realize Ilya > >> had a > few comments on the v1. I think these are addressed here but maybe Ilya would > like to confirm before sign off? > > > > Thanks, Ian. > > I'll take a look at this patch tomorrow. > > > >> > >> @Ilya

Re: [ovs-dev] [PATCH v2] dpif-netdev-dpcls: Make subtable reprobe thread-safe.

2022-02-14 Thread Stokes, Ian
> The subtable search function can be used at any time by a PMD thread. > Setting the subtable search function should be done atomically to > prevent garbage data from being read. > > A dpcls_subtable_lookup_reprobe() call can happen at the same time that > DPCLS subtables are being sorted. This

Re: [ovs-dev] [PATCH v3] system-dpdk.at: Add warning log in mfex fuzzy test.

2022-02-11 Thread Stokes, Ian
> > -Original Message- > > From: dev On Behalf Of Kumar Amber > > Sent: Wednesday 9 February 2022 09:50 > > To: ovs-dev@openvswitch.org > > Cc: Amber, Kumar ; david.march...@redhat.com > > Subject: [ovs-dev] [PATCH v3] system-dpdk.at: Add warning log in mfex fuzzy > test. > > > > Some

Re: [ovs-dev] [PATCH] netdev-dpdk: Update to use RTE_ETH namespace defines.

2022-02-08 Thread Stokes, Ian
> On 08/02/2022 12:52, Stokes, Ian wrote: > >> On Thu, Jan 13, 2022 at 5:24 PM Kevin Traynor > wrote: > >>> > >>> This patch updates OVS to use DPDK RTE_ETH namespaces. > >>> > >>> DPDK commit 295968d17407 ("ethdev: add namesp

Re: [ovs-dev] [PATCH] netdev-dpdk: Update to use RTE_ETH namespace defines.

2022-02-08 Thread Stokes, Ian
> On Thu, Jan 13, 2022 at 5:24 PM Kevin Traynor wrote: > > > > This patch updates OVS to use DPDK RTE_ETH namespaces. > > > > DPDK commit 295968d17407 ("ethdev: add namespace") [0] added RTE_ETH > > namespaces for ethdev enums and macros in DPDK 21.11. > > > > As compatibility for the older names

Re: [ovs-dev] [PATCH v3] dpif-netdev: fix vlan and ipv4 parsing in avx512

2022-02-08 Thread Stokes, Ian
> -Original Message- > From: Van Haaren, Harry > Sent: Tuesday, February 8, 2022 10:17 AM > To: Eelco Chaudron ; Amber, Kumar > > Cc: ovs-dev@openvswitch.org; Ferriter, Cian ; Stokes, > Ian ; i.maxim...@ovn.org > Subject: RE: [PATCH v3] dpif-netdev: fix vlan an

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-02-02 Thread Stokes, Ian
> > On 2/2/22 13:57, Stokes, Ian wrote: > > >>> -Original Message- > > >>> From: Ferriter, Cian > > >>> Sent: Friday 28 January 2022 16:32 > > >>> To: William Tu ; d...@openvswitch.org > > >>> Subject: R

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-02-02 Thread Stokes, Ian
> > -Original Message- > > From: Ferriter, Cian > > Sent: Friday 28 January 2022 16:32 > > To: William Tu ; d...@openvswitch.org > > Subject: RE: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler > support. > > > > > > > -Original Message- > > > From: dev On Behalf Of

Re: [ovs-dev] [PATCH] system-dpdk: Fix MFEX logs check.

2022-01-20 Thread Stokes, Ian
> > -Original Message- > > From: David Marchand > > Sent: Wednesday 19 January 2022 17:26 > > To: d...@openvswitch.org > > Cc: Stokes, Ian ; Phelan, Michael > ; Ferriter, Cian > > ; i.maxim...@ovn.org; ktray...@redhat.com > > Subject: [PATCH] s

Re: [ovs-dev] [PATCH v5 2/2] dpif-netdev/mfex: Optimize packet hash and enable autovalidator

2022-01-12 Thread Stokes, Ian
> From: Kumar Amber > > This patch adds error checking of packet hashes to the mfex > autovalidator infrastructure, ensuring that hashes calculated by > optimized mfex implementations is identical to the scalar code. > > This patch avoids calculating the software hash of the packet again > if

Re: [ovs-dev] [PATCH v5 8/8] odp-execute: Add ISA implementation of push_vlan action.

2022-01-12 Thread Stokes, Ian
> This commit adds the AVX512 implementation of the push_vlan action. > The implementation here is auto-validated by the miniflow > extract autovalidator, hence its correctness can be easily > tested and verified. > > Signed-off-by: Emma Finn Hi Emma, thanks for the patch. I think given the

Re: [ovs-dev] [PATCH v5 7/8] odp-execute: Add ISA implementation of pop_vlan action.

2022-01-12 Thread Stokes, Ian
> This commit adds the AVX512 implementation of the pop_vlan action. > The implementation here is auto-validated by the miniflow > extract autovalidator, hence its correctness can be easily > tested and verified. > > Signed-off-by: Emma Finn Hi Emma, some comments below. > --- >

Re: [ovs-dev] [PATCH v5 6/8] odp-execute: Add ISA implementation of actions.

2022-01-12 Thread Stokes, Ian
> -Original Message- > From: Finn, Emma > Sent: Wednesday, January 12, 2022 9:43 AM > To: d...@openvswitch.org; Van Haaren, Harry ; > Amber, Kumar ; Stokes, Ian ; > i.maxim...@ovn.org > Cc: Finn, Emma > Subject: [PATCH v5 6/8] odp-execute: Add ISA i

Re: [ovs-dev] [PATCH v5 4/8] odp-execute: Add command to switch action implementation.

2022-01-12 Thread Stokes, Ian
> This commit adds a new command to allow the user to switch > the active action implementation at runtime. A probe function > is executed before switching the implementation, to ensure > the CPU is capable of running the ISA required. > > Usage: > $ ovs-appctl dpif-netdev/action-impl-set

Re: [ovs-dev] [PATCH v5 3/8] odp-execute: Add auto validation function for actions.

2022-01-12 Thread Stokes, Ian
> This commit introduced the auto-validation function which > allows users to compare the batch of packets obtained from > different action implementations against the linear > action implementation. > > The autovalidator function can be triggered at runtime using the > following command: > > $

Re: [ovs-dev] [PATCH v5 2/8] odp-execute: Add function pointer for pop_vlan action.

2022-01-12 Thread Stokes, Ian
> -Original Message- > From: Finn, Emma > Sent: Wednesday, January 12, 2022 9:43 AM > To: d...@openvswitch.org; Van Haaren, Harry ; > Amber, Kumar ; Stokes, Ian ; > i.maxim...@ovn.org > Cc: Finn, Emma > Subject: [PATCH v5 2/8] odp-execute: Add function poi

Re: [ovs-dev] [PATCH v5 1/8] odp-execute: Add function pointers to odp-execute for different action implementations.

2022-01-12 Thread Stokes, Ian
> -Original Message- > From: Finn, Emma > Sent: Wednesday, January 12, 2022 9:43 AM > To: d...@openvswitch.org; Van Haaren, Harry ; > Amber, Kumar ; Stokes, Ian ; > i.maxim...@ovn.org > Cc: Finn, Emma > Subject: [PATCH v5 1/8] odp-execute: Add function

Re: [ovs-dev] [PATCH v2] dpdk: Use --in-memory by default.

2021-12-15 Thread Stokes, Ian
> On 12/15/21 16:13, Stokes, Ian wrote: > >> From: Rosemarie O'Riorden > >> > >> If anonymous memory mapping is supported by the kernel, it's better > >> to run OVS entirely in memory rather than creating shared data > >> structures. OVS doesn't

Re: [ovs-dev] [PATCH v2] dpdk: Use --in-memory by default.

2021-12-15 Thread Stokes, Ian
> From: Rosemarie O'Riorden > > If anonymous memory mapping is supported by the kernel, it's better > to run OVS entirely in memory rather than creating shared data > structures. OVS doesn't work in multi-process mode, so there is no need > to litter a filesystem. > > Reported-at:

Re: [ovs-dev] [PATCH v2 1/1] dpdk: Update to use DPDK v21.11.

2021-12-09 Thread Stokes, Ian
> On 09/12/2021 15:21, Ian Stokes wrote: > > This commit adds support for DPDK v21.11, it includes the following > > changes. > > > > 1. ci: Install python elftools for DPDK 21.02. > > 2. ci: Update meson requirement for DPDK 21.05. > > 3. netdev-dpdk: Fix build with 21.05. > > 4. ci: Compile DPDK

Re: [ovs-dev] [PATCH v1 1/1] dpdk: Update to use DPDK v21.11.

2021-12-09 Thread Stokes, Ian
> On 12/9/21 16:24, Stokes, Ian wrote: > >> On Thu, Dec 9, 2021 at 1:27 PM Ian Stokes wrote: > >>> > >>> This commit adds support for DPDK v21.11, it includes the following > >>> changes. > >>> > >>> 1. ci: Install python

  1   2   3   4   5   6   7   8   9   10   >