Re: [ovs-dev] [PATCH v7 4/4] nsh: add dec_nsh_ttl action

On Sat, Jan 06, 2018 at 01:47:54PM +0800, Yi Yang wrote: > NSH ttl is a 6-bit field ranged from 0 to 63, it should be > decremented by 1 every hop, if it is 0 or it is so after > decremented, the packet should be dropped and a packet-in > message is sent to main controller. > > Signed-off-by: Yi

Re: [ovs-dev] [PATCH] ofproto:fix abort issue when delete bridge

Ben, According to current implementation, There is no problem if rule A has a non-NULL struct rule_dpif's 'new_rule' B, because there is rcu synchronization during bridge deletion, and ovsrcu_postone() is called twice by ofproto_destroy(), which could also help to make sure ofproto will not

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

Hello everyone. I just returned from the holidays. Thanks for working on this. Find my replies inline. Best regards, Ilya Maximets. On 08.01.2018 20:58, Kevin Traynor wrote: > On 01/08/2018 05:31 PM, Stokes, Ian wrote: >>> >>> Hi Ian, >>> -Original Message- From: Stokes, Ian

Re: [ovs-dev] [PATCH] netdev-dpdk: fix port addition for ports sharing same PCI id

On Mon, Jan 08, 2018 at 01:10:10PM +, Stokes, Ian wrote: > Hi Yuanhan, > > Thanks for working on this, I've done some testing with ani40e device and a > review of the current patch, please find comments below. > > > On 12/20/2017 04:03 PM, Yuanhan Liu wrote: > > > Some NICs have only one

[ovs-dev] ovs-dpdk poor scalable capacity with PMDS for dpflow limit ?

Hi, I just test ovs-dpdk with much more pmds to improve the performace. But in some case the performance more poor with more PMDS Like follow flows: in_port=1,nw_dst=10.0.0.x, actions=output:2 Assuming there are 1 differnet flows which is active by packet. if there are 12 PMDS. In

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

Acked-By: Miguel Angel Ajo On Fri, Jan 5, 2018 at 11:44 AM Daniel Alvarez wrote: > When there are two ACLs in a Logical Switch with same direction, > priority, match and action fields, ovn-northd will generate the > exact same logical flow for them

Re: [ovs-dev] [PATCH v6 2/2] OVN: Add support for periodic router advertisements.

Awesome!, do you believe it would be possible to have this on the 2.9 series too? Having the periodic router advertisements on the next openstack release was one of our items towards parity with the reference solution in the land of IPv6. On Fri, Jan 5, 2018 at 6:05 PM Ben Pfaff

Re: [ovs-dev] master now "frozen" for forking

It actually makes a lot of sense. Please ignore my other comment on master about having the IPv6 RA patch on 2.9, doing it this way, we effectively have it already. On Fri, Jan 5, 2018 at 5:51 PM Ben Pfaff wrote: > On Fri, Jan 05, 2018 at 03:58:08PM +, Stokes, Ian wrote: > >

Re: [ovs-dev] [RFC PATCH 6/8] dpif-netdev: Refactor cycle counting

Hi Kevin, Thanks for the feedback. See below. > > @@ -3429,16 +3381,17 @@ dp_netdev_process_rxq_port(struct > > dp_netdev_pmd_thread *pmd, > > struct pmd_perf_stats *s = >perf_stats; > > struct dp_packet_batch batch; > > int error; > > -int batch_cnt = 0, output_cnt = 0; > >

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

Let's step back and consider the options. Duplicate flow matches can happen, either because of bugs at any given level of the code, or because of user-provided data that can't practically be validated before it is passed down to the next level. Consider just the ovn-northd level. ovn-northd can

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

On 01/08/2018 05:31 PM, Stokes, Ian wrote: >> >> Hi Ian, >> >>> -Original Message- >>> From: Stokes, Ian [mailto:ian.sto...@intel.com] >>> Sent: Monday, 08 January, 2018 17:09 >>> To: Jan Scheurich ; Kevin Traynor >>> ; Ilya Maximets

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

On 12/19/2017 03:00 PM, Kevin Traynor wrote: > On 12/19/2017 02:35 PM, Weglicki, MichalX wrote: >>> -Original Message- >>> From: Kevin Traynor [mailto:ktray...@redhat.com] >>> Sent: Tuesday, December 19, 2017 3:07 PM >>> To: Weglicki, MichalX ;

Re: [ovs-dev] [PATCH 0/3] rhel: Add force-reload-kmod support in ovs-systemd-reload

On Fri, Dec 22, 2017 at 04:00:50PM +0100, Timothy Redaelli wrote: > On Fedora / RHEL7 "ovs-ctl force-reload-mod" doesn't work due to systemd > dependencies so this series adds support for "force-reload-mod" inside the > rhel-only "ovs-systemd-reload" script. > > Timothy Redaelli (3): >

Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and VS2017

Thanks Ben! Applied on master. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, January 5, 2018 5:14 PM > To: aserd...@ovn.org > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and > VS2017 > > OK. > > Acked-by:

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

> Hi guys, > > It would be great to get your feedback on the proposal for combining (and > simplifying) our patches. > > Do you agree with a) the cycle counting refactoring and b) the > simplification of rxq pmd load calculation? > > For actual merge I would suggest to re-order the changes and

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

Hi Ian, That's why I brought up my original question before Christmas, but apparently too late ☹. Myself, was hoping that we could get all three changes: PMD performance metrics, time-based tx batching and Kevin's enhancement for the pmd-rxq-show command into 2.9. PMD performance metrics are

Re: [ovs-dev] [PATCH] OVN pacemaker: Fix issues when started as pacemaker container bundles

Russell, I'm going to assume that you will review this. Thanks, Ben. On Mon, Jan 08, 2018 at 01:05:56PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > When OVN dbs are created as a pacemaker container bundle resource with > meta attribute

Re: [ovs-dev] [PATCH v1] ovn: Add sanity check when adding tunnel port

On Mon, Jan 08, 2018 at 11:36:22AM +, Zhenyu Gao wrote: > 1. ovs cannot create two ports with same tunnel type and options:remote_ip > 2. add santity check to detect if two chassises have same encap ip > 3. add a sset to store tunnel ports' type & encap ip information > > Signed-off-by:

Re: [ovs-dev] [PATCH] lex: Fix parsing of long tokens.

On Fri, Jan 05, 2018 at 10:20:21AM -0800, Gregory Rose wrote: > On 1/2/2018 11:15 AM, Ben Pfaff wrote: > >When a token is longer than the built-in 256-byte buffer, a buffer is > >malloc()'d but it was not properly null-terminated. > > > >Found by afl-fuzz. > > > >Reported-by: Bhargava Shastry

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

On Mon, Jan 08, 2018 at 08:28:45AM -0800, Ben Pfaff wrote: > On Mon, Jan 08, 2018 at 11:55:26AM +, Weglicki, MichalX wrote: > > Hi Ben, > > > I don't like the idea implied in the code in a few places that name[] in > > > struct netdev_custom_counter might not be null-terminated. I think that

[ovs-dev] [RESEND PATCH 2/3] net: ovs: remove unused hardirq.h

Preempt counter APIs have been split out, currently, hardirq.h just includes irq_enter/exit APIs which are not used by openvswitch at all. So, remove the unused hardirq.h. Signed-off-by: Yang Shi Acked-by: Pravin B Shelar Cc: "David S. Miller"

[ovs-dev] [patch v3 4/5] conntrack: Some style improvements.

Fix up some instances where variable declarations were not close enough to their use, as these were missed before. This is the preferred art in OVS code and flagged heavily in code reviews. This is highly desirable due to code clarity reasons. There are also some cases where newlines were not

Re: [ovs-dev] [PATCH 1/3] Add performance measuring API

Thanks for the detailed feedback Ben. I'll work up a new revision that addresses what you have found here. There are a couple of in-line comments below. On 01/04/2018 05:58 PM, Ben Pfaff wrote: On Mon, Dec 18, 2017 at 04:51:37PM -0600, Mark Michelson wrote: This is similar to the existing

[ovs-dev] [patch v3 5/5] conntrack: Reorder sanity checks in extract_l3_ipvx().

The functions extract_l3_ipv4 and extract_l3_ipv6 check for unsupported ip fragments and return early. The checks were after an assignment that would not be needed when early return happens. This is slightly inefficient, but mostly reads poorly. Hence, reorder the ip fragment checks before the

Re: [ovs-dev] [PATCH 1/3] Add performance measuring API

OK, thanks, your feedback makes sense. On Mon, Jan 08, 2018 at 02:55:10PM -0600, Mark Michelson wrote: > Thanks for the detailed feedback Ben. I'll work up a new revision that > addresses what you have found here. There are a couple of in-line comments > below. > > On 01/04/2018 05:58 PM, Ben

[ovs-dev] [patch v3 2/5] conntrack: Fix alg expectation cleanup.

Presently, alg expectations are removed by being time expired. This was intended to happen before the control connections and was intended to minimize the extra work involved for tracking and removing the expectations. This is not the best option since it should be possible to remove expectations

[ovs-dev] [patch v3 3/5] conntrack: Add additional alg support.

In order to support more algs with different requirements, expectation handling is allowed to handle more cases, such as a wildcard source ip as in the case of SIP. NAT can also be skipped in some alg cases. Expectation_create() was otherwise simplified in the process. Some renaming was done to

Re: [ovs-dev] [PATCH] ofproto:fix abort issue when delete bridge

This seems like the wrong approach to me. If there's a problem that struct rule_dpif's 'new_rule' member can sometimes point to a rule that gets freed, then one would normally fix that through some kind of synchronization between the rules (for example, one could make sure that RCU keeps

Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

Thanks for the review. I agree with your comments. I fixed them and applied this to master. On Fri, Jan 05, 2018 at 11:21:55AM +, Jan Scheurich wrote: > Just one small observation below. Otherwise LGTM. > > I have tested the patch and it worked for all cases. I couldn't test the case >

Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

On Tue, Dec 26, 2017 at 11:12:02AM -0800, Gregory Rose wrote: > On 12/26/2017 9:33 AM, Gregory Rose wrote: > >On 12/22/2017 2:09 PM, Ben Pfaff wrote: > >>On Tue, Nov 07, 2017 at 07:04:02PM -0800, Ben Pfaff wrote: > >>>Open vSwitch has always deleted all flows from the flow table whenever > >>>a >

Re: [ovs-dev] [PATCH 2/3] Save performance stats to database.

On 01/04/2018 06:38 PM, Ben Pfaff wrote: On Mon, Dec 18, 2017 at 04:51:38PM -0600, Mark Michelson wrote: This commit builds on the performance library by storing compiled statistics in the OVS vswitchd database. This can make it more useful for administrators to keep tabs on performance in

[ovs-dev] [patch v3 1/5] hindex: Add hindex_next_node_with_hash.

Add hindex_next_node_with_hash() api which gets a next hindex node with the same hash as the parameter node or null if there is no such next node. This api will be used is a subsequent patch. Signed-off-by: Darrell Ball --- lib/hindex.h | 9 + 1 file changed, 9

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

If both ACLs have same priority, match, ..., but different actions, it is a misconfiguration in NB. What could northd do here besides raising an error log? Another point, would this type of check increase the difficulty of probably future incremental-processing in northd? >From my point of view,

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

Hi Darrell, Thanks for your initial review. I'll work on incorporating your comments into v2 (which I'm planning to submit already with some tests). A couple of small comments are in-line. On 01/05/2018 06:40 AM, Darrell Ball wrote: Thanks for the series/work; I’ll be reviewing this series,

[ovs-dev] [patch v2 0/3] dpctl conntrack: Add nconns/maxconns commands.

Commands are added to: Get the number of conntrack connections. Get the maximum limit of conntrack connections. Set the maximum limit of conntrack connections. These commands are only supported in the userspace datapath at this time. A supporting test is added. v1->v2: Use atomic_store_relaxed

[ovs-dev] [patch v2 2/3] dpctl conntrack: Add get number of connections.

A get command is added for number of conntrack connections. This command is only supported in the userspace datapath at this time. Signed-off-by: Darrell Ball Signed-off-by: Antonio Fischetti Co-authored-by: Antonio Fischetti

[ovs-dev] [patch v2 1/3] dpctl conntrack: Add get and set maxconns command.

Get and set dpctl commands are added for conntrack maxconns. These commands are only supported in the userspace datapath at this time. Signed-off-by: Darrell Ball Signed-off-by: Antonio Fischetti Co-authored-by: Antonio Fischetti

[ovs-dev] [patch v2 3/3] tests: Add dpctl test for conntrack nconns/maxconns.

Signed-off-by: Darrell Ball --- tests/system-kmod-macros.at | 19 + tests/system-traffic.at | 85 tests/system-userspace-macros.at | 12 ++ 3 files changed, 116 insertions(+) diff --git

Re: [ovs-dev] [PATCH v7 1/4] nsh: rework NSH netlink keys and actions

On Sat, Jan 06, 2018 at 01:47:51PM +0800, Yi Yang wrote: > This patch changes OVS_KEY_ATTR_NSH > to nested attribute and adds three new NSH sub attribute keys: > > OVS_NSH_KEY_ATTR_BASE: for length-fixed NSH base header > OVS_NSH_KEY_ATTR_MD1: for length-fixed MD type 1 context >

Re: [ovs-dev] [PATCH] ofp-errors: Send as much of a message as possible in an error reply.

> On Jan 6, 2018, at 10:33 AM, Ben Pfaff wrote: > > /* Creates and returns an OpenFlow message of type OFPT_ERROR that conveys the > diff --git a/ofproto/bundles.c b/ofproto/bundles.c > index 849f99a15e40..195b9f90ef11 100644 > --- a/ofproto/bundles.c > +++ b/ofproto/bundles.c >

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

I think this is an interesting idea. One caveat is that in this case we use the rules' field to infer the flows' field. If the rule does not consider a field within which the flow has high entropy, it still does not help. Or if the rule considers many fields but the flow does not have high

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Sat, Jan 6, 2018 at 10:57 AM, Pravin Shelar wrote: > On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk wrote: >> >> >> On Jan 5, 2018 22:17, "Pravin Shelar" wrote: >> >> On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk

Re: [ovs-dev] [PATCH v7 2/4] nsh: add new flow key 'ttl'

On Sat, Jan 06, 2018 at 01:47:52PM +0800, Yi Yang wrote: > IETF NSH draft added a new filed ttl in NSH header, this patch > is to add new nsh key 'ttl' for it. > > Signed-off-by: Yi Yang Thanks for v7! The field assignments in meta-flow.h seem wrong to me: - The

[ovs-dev] Cobranza judicial y extrajudicial

Un último recurso para la recuperación de la cartera morosa Cobranza judicial y extrajudicial 25 de enero- CP. y MAN. Fernando García Zárate - 9am-6pm En el proceso de cobranza extrajudicial, el propósito es llegar a un acuerdo sin la necesidad de ingresar a un proceso de cobranza judicial.

Re: [ovs-dev] [RESEND PATCH 2/3] net: ovs: remove unused hardirq.h

From: "Yang Shi" Date: Tue, 09 Jan 2018 03:52:53 +0800 > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by openvswitch at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On 1/6/18 10:57, Pravin Shelar wrote: > On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk wrote: >> >> >> On Jan 5, 2018 22:17, "Pravin Shelar" wrote: >> >> On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk >> wrote: >>> On Fri, Jan 5,

[ovs-dev] [PATCH v3] netdev: Custom statistics.

- New get_custom_stats interface function is added to netdev. It allows particular netdev implementation to expose custom counters in dictionary format (counter name/counter value). - New statistics are retrieved using experimenter code and are printed as a result to ofctl dump-ports. - New

Re: [ovs-dev] [PATCH] netdev-dpdk: fix port addition for ports sharing same PCI id

Hi Yuanhan, Thanks for working on this, I've done some testing with ani40e device and a review of the current patch, please find comments below. > On 12/20/2017 04:03 PM, Yuanhan Liu wrote: > > Some NICs have only one PCI address associated with multiple ports. > > This patch extends the

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

Hi guys, It would be great to get your feedback on the proposal for combining (and simplifying) our patches. Do you agree with a) the cycle counting refactoring and b) the simplification of rxq pmd load calculation? For actual merge I would suggest to re-order the changes and take the cycle

Re: [ovs-dev] [PATCH v2 3/3] xlate: call tnl_neigh_snoop() from terminate_native_tunnel()

Hi Ben, > I don't understand yet the motivation here. What does it mean "to keep > ARP neighbor cache clean"? Is this a bug fix, a performance fix, a > cleanup, or something else? > > What is the goal of the filtering you mention? Is that a second change, > that can and should be a separate

[ovs-dev] [PATCH v1] ovn: Add sanity check when adding tunnel port

1. ovs cannot create two ports with same tunnel type and options:remote_ip 2. add santity check to detect if two chassises have same encap ip 3. add a sset to store tunnel ports' type & encap ip information Signed-off-by: Zhenyu Gao --- ovn/controller/encaps.c | 46

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

Hi Ben, I've just sent V3 of the patch, but please find my comments inline. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, December 20, 2017 12:42 AM > To: Weglicki, MichalX > Cc: d...@openvswitch.org > Subject: Re:

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Hi Satyavalli, Please find my responses below. Regards, Jan From: Satyavalli Rama [mailto:satyavalli.r...@tcs.com] Sent: Friday, 05 January, 2018 12:25 To: Ben Pfaff ; Jan Scheurich Cc: SatyaValli ; d...@openvswitch.org;

Re: [ovs-dev] [PATCH v6 2/2] OVN: Add support for periodic router advertisements.

On Mon, Jan 8, 2018 at 3:24 AM, Miguel Angel Ajo Pelayo wrote: > Awesome!, do you believe it would be possible to have this on the 2.9 > series too? > > Having the periodic router advertisements on the next openstack release was > one of our items > towards parity with the

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

> Hi Ian, > > That's why I brought up my original question before Christmas, but > apparently too late ☹. Apologies, Christmas was a bit hectic with the last push for output batching and finishing for the holidays so I missed following up on it. > > Myself, was hoping that we could get all

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

On Mon, Jan 08, 2018 at 11:55:26AM +, Weglicki, MichalX wrote: > Hi Ben, > > I don't like the idea implied in the code in a few places that name[] in > > struct netdev_custom_counter might not be null-terminated. I think that > > we should ensure that it is always null terminated. Otherwise

Re: [ovs-dev] why so many junk mails in ovs community's dev-maillist? 转发：Response !!!

I don't know. Maybe Linux Foundation does not have a good spam filter. On Mon, Jan 08, 2018 at 09:54:11AM +0800, xiucai wrote: > Hi, > > > In other maillist had never seen junk mails such as python, qemu. > > > But in ovs, you know. > > > I responsed the mail below because i

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

Hi Ian, > -Original Message- > From: Stokes, Ian [mailto:ian.sto...@intel.com] > Sent: Monday, 08 January, 2018 17:09 > To: Jan Scheurich ; Kevin Traynor > ; Ilya Maximets > Cc: d...@openvswitch.org > Subject: RE:

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

I suspect that this doesn't go far enough, because it includes actions in the hash, so that it would fail to deduplicate two identical ACLs with different actions (e.g. "drop" versus "allow"). On Fri, Jan 05, 2018 at 10:43:16AM +, Daniel Alvarez wrote: > When there are two ACLs in a Logical

Re: [ovs-dev] [PATCH] OVN: remove useless ds_clear() on actions ds

On Fri, Jan 05, 2018 at 06:52:00PM +0100, Lorenzo Bianconi wrote: > Remove ds_clear() on actions dynamic string in build_acls() > since they have just been initialized to DS_EMPTY_INITIALIZER > > Signed-off-by: Lorenzo Bianconi Thanks, applied to master.

Re: [ovs-dev] [PATCH V2] Documentation: Update Faucet tutorial.

On Sat, Jan 06, 2018 at 04:45:17PM +1300, Brad Cowie wrote: > Updates Faucet tutorial to work with newer versions than 1.6.7: > > * Tutorial now shows how to check out latest tag from Faucet's git. > > * Set minimum_ip_size_check flag to False so that the >payloadless packets generated by

Re: [ovs-dev] [RFC PATCH 6/8] dpif-netdev: Refactor cycle counting

On 01/04/2018 08:02 PM, Jan Scheurich wrote: > Simplify the historically grown TSC cycle counting in PMD threads. > Cycles are currently counted for the following purposes: > > 1. Measure PMD ustilization > > PMD utilization is defined as ratio of cycles spent in busy iterations > (at least one

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

Right! We didn't hit that issue, but it'd make sense to fix in this patch I guess. We could modify the hashing function to not include the action (not sure if it does now..), and also have a separate search function that ignores the action. On Mon, Jan 8, 2018 at 5:39 PM Ben Pfaff