On Tue, Aug 29, 2017 at 10:06:54AM -0700, Greg Rose wrote:
> On 08/28/2017 08:23 AM, Lance Richardson wrote:
> >Sparse version 0.5.1 will be released in the near future. Prepare
> >for it by eliminating the only new warning (as of 0.5.1-rc5):
> >
> >ofproto/fail-open.c:134:22: error: Initializer en
On Tue, Sep 19, 2017 at 04:38:04PM +0800, wang.qia...@zte.com.cn wrote:
> To support taas function, this patch add two type of logica_switch_port,
> "mirror" and "taas". port with type "mirror" is used as inport for monitor
> flow in logica_switch, and port with type "taas" is used as outport for
On Thu, Sep 21, 2017 at 07:45:23PM +0800, wang.qia...@zte.com.cn wrote:
> From 80260a2950f10544e307d6f20cb1cfe8c9bb885f Mon Sep 17 00:00:00 2001
> From: wang qianyu
> Date: Thu, 21 Sep 2017 18:05:16 +0800
> Subject: [PATCH] ovn: reduce logical flow applied to ovn-controller
>
> Add a logical_port
On Tue, Oct 31, 2017 at 10:08:08AM -0700, Greg Rose wrote:
> On 10/24/2017 03:19 PM, Ben Pfaff wrote:
> >On Tue, Jun 06, 2017 at 01:42:08PM -0700, Greg Rose wrote:
> >>On 06/06/2017 08:22 AM, Ben Pfaff wrote:
> >>>On Mon, Jun 05, 2017 at 08:34:32PM -0700, Greg Rose wr
On Thu, Aug 17, 2017 at 12:06:24AM +0800, Xiao Liang wrote:
> Rconn provides useful features over vconn. Make it available to library
> users.
>
> Signed-off-by: Xiao Liang
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://ma
On Thu, Aug 17, 2017 at 12:06:25AM +0800, Xiao Liang wrote:
> Poll-loop is the core to implement main loop. It should be available in
> libopenvswitch.
>
> Signed-off-by: Xiao Liang
I'm concerned about the way that this adds a definition of HANDLE in a
public header. That seems unfriendly to co
On Fri, Sep 22, 2017 at 07:44:52AM -0700, Greg Rose wrote:
> In kernels < 4.9 the maximum netlink message size is 16KB.
>
> See http://www.spinics.net/lists/netdev/msg431592.html
>
> Signed-off-by: Greg Rose
Thanks, applied to master, branch-2.8, and branch-2.7.
On Fri, Sep 22, 2017 at 07:44:53AM -0700, Greg Rose wrote:
> The maximum message size for recent Linux kernels is 32Kb and in older
> kernels it is 16KB.
>
> See http://www.spinics.net/lists/netdev/msg431592.html
>
> Adjust the size checked and update a comment.
>
> Signed-off-by: Greg Rose
..
On Thu, Aug 17, 2017 at 02:14:13PM -0500, Terry Wilson wrote:
> The JSON C extensions performs much better than the pure Python
> version, so build it when producing RPMs.
>
> Signed-off-by: Terry Wilson
Hi Russell, would you mind taking a look at this? It is Pythonic and
touches only the RHEL
On Tue, Oct 31, 2017 at 03:47:35PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > On Fri, Oct 20, 2017 at 12:39:10AM -0700, Gurucharan Shetty wrote:
> >> Signed-off-by: Gurucharan Shetty
> >> ---
> >> Documentation/intro/install/rhel.rst | 2 +-
On Mon, Aug 21, 2017 at 08:34:41AM +, Zoltán Balogh wrote:
> Instead of using the value 1 a new enum should be used for indicating
> translation error which occurs because of unsupported packet type.
>
> Signed-off-by: Zoltan Balogh
> Signed-off-by: Jan Scheurich
> Co-authored-by: Jan Scheur
On Mon, Oct 30, 2017 at 12:22:50PM +0100, Zoltan Balogh wrote:
> When all OF actions have been translated, there could be actions at
> the end of list of odp actions which are not needed to be executed.
> So, the list can be normalized at the end of xlate_actions().
>
> Signed-off-by: Zoltan Balog
On Mon, Oct 30, 2017 at 12:22:50PM +0100, Zoltan Balogh wrote:
> When all OF actions have been translated, there could be actions at
> the end of list of odp actions which are not needed to be executed.
> So, the list can be normalized at the end of xlate_actions().
>
> Signed-off-by: Zoltan Balog
On Tue, Oct 31, 2017 at 09:59:08AM +0100, Zoltan Balogh wrote:
> It turned out, checking datapath flow statistics during system-userspace
> test is not reliable. Unwanted packets can be injected depending on
> system configuration. As a workaround, this commit removes checking
> statistics of datap
I see that this series appears to have stalled. Should we expect a new
version sometime soon? Do you need more reviews on the current version?
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
It's been a long time since there's been activity in this series. I'm
not entirely following the discussion, so I'd like some guidance on how
to proceed with it. For now, I'm just marking it "Deferred" in
patchwork.
On Mon, Sep 04, 2017 at 09:28:45AM +, Weglicki, MichalX wrote:
> Hello Neil,
On Fri, Aug 25, 2017 at 05:40:23PM +0100, Ian Stokes wrote:
> LibIpsecMB is required to enable the use of vdev cryptodev devices in
> DPDK. This patch adds a condition to check for the library when it is
> detected that ONFIG_RTE_LIBRTE_PMD_AESNI_MB=y is enabled in the DPDK
> config.
>
> Signed-of
On Fri, Aug 25, 2017 at 05:40:24PM +0100, Ian Stokes wrote:
> Upon callback for building/pushing a packet header when encapsulating
> for tunneling a reference to the vport in question is required to access
> associated devices such as cryptodevs. This patch adds this pointer and
> will enable futu
On Fri, Aug 25, 2017 at 05:40:25PM +0100, Ian Stokes wrote:
> This patch introduces structs for both ESP headers and ESP trailers
> along with expected size assertions.
>
> Signed-off-by: Ian Stokes
Applied to master, thanks!
___
dev mailing list
d...@
On Fri, Aug 25, 2017 at 05:40:26PM +0100, Ian Stokes wrote:
> This patch adds a field to the flow struct to represent the ESP security
> parameter index of a packet.
>
> Signed-off-by: Ian Stokes
> ---
> include/openvswitch/flow.h |5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
On Fri, Aug 25, 2017 at 05:40:27PM +0100, Ian Stokes wrote:
> The patch modifies the miniflow extract function to hande the case where
> the network protocol for a packet is ESP. In this case the SPI value in
> the ESP header is extracted and set in the minflow map.
>
> Signed-off-by: Ian Stokes
On Tue, Oct 31, 2017 at 02:46:15PM -0700, Ben Pfaff wrote:
> On Fri, Aug 25, 2017 at 05:40:26PM +0100, Ian Stokes wrote:
> > This patch adds a field to the flow struct to represent the ESP security
> > parameter index of a packet.
> >
> > Signed-off-by: Ian S
On Fri, Aug 25, 2017 at 05:40:28PM +0100, Ian Stokes wrote:
> This patch introduces a new tunnel port type 'vxlanipsec'. This port
> combines vxlan tunnelling with IPsec operating in transport mode.
>
> Ciphering and authentication actions ares provided by a DPDK cryptodev.
> The cryptodev operate
On Fri, Aug 25, 2017 at 05:40:30PM +0100, Ian Stokes wrote:
> This commit adds details to the vswitch xml regarding the use of the
> vxlanipsec interface type. This patch is not intended for upstreaming
> and simply seeks to solicit feedback on the user interface design of
> the vxlanipsec port typ
On Fri, Aug 25, 2017 at 03:51:11PM -0700, Yi-Hung Wei wrote:
> Free the allocated memory in the pop function.
>
> Fixes: 0f2f05bbcf743 ("ofproto/trace: Add --ct-next option to ofproto/trace")
> Signed-off-by: Yi-Hung Wei
> ---
> ofproto/ofproto-dpif-trace.c | 13 -
> 1 file changed,
On Thu, Aug 31, 2017 at 02:38:35PM -0700, Greg Rose wrote:
> On 08/25/2017 03:51 PM, Yi-Hung Wei wrote:
> >This patch propagates ct_zone when ofproto/trace automatically runs
> >through the recirculation process.
> >
> >Fixes: e6bc8e749381 ("ofproto/trace: Add support for tracing conntrack
> >reci
On Fri, Aug 25, 2017 at 03:51:14PM -0700, Yi-Hung Wei wrote:
> Instead of using fixed default conntrack state 'trk|new' in
> ofproto/trace for conntrack recirculation, this patch queries the
> conntrack state from datapath using ct_dpif_get_info().
>
> Signed-off-by: Yi-Hung Wei
I'm getting a pa
On Fri, Aug 25, 2017 at 03:51:17PM -0700, Yi-Hung Wei wrote:
> Refactor parse_ct_state() to support different delimiters.
>
> Signed-off-by: Yi-Hung Wei
> ---
> lib/flow.c | 6 +++---
> lib/flow.h | 2 +-
> ofproto/ofproto-dpif-trace.c | 2 +-
> ovn/utilities/
On Mon, Oct 30, 2017 at 10:31:14AM -0700, William Tu wrote:
> On Thu, Oct 26, 2017 at 2:24 PM, Yi-Hung Wei wrote:
> > Three conntrack system-traffic tests are broken because of a recent
> > change 7827edcaebd8 ("Add dl_type to flow metadata for correct
> > interpretation of conntrack metadata"). I
On Sat, Sep 02, 2017 at 08:52:38AM -0700, Ben Pfaff wrote:
> On Mon, Aug 28, 2017 at 08:14:59PM +0300, Alin Gabriel Serdean wrote:
> > Let's suppose that ovsdb-server is running properly, but ovs-vswitchd
> > is not responsive/crashed. We try to add a port via ovs-vsctl
On Tue, Oct 31, 2017 at 07:25:31PM +0200, Alin Gabriel Serdean wrote:
> Installer fixes to allow the MSI build using msbuild(64bit variant).
>
> Alin Gabriel Serdean (6):
> build-windows: Suppress output from MSBuild
> installer-windows: Remove unused entries from WIX project
> installer-win
On Wed, Nov 01, 2017 at 11:24:30PM +0800, Yuanhan Liu wrote:
> On Tue, Oct 31, 2017 at 02:19:20PM -0700, Ben Pfaff wrote:
> > I see that this series appears to have stalled. Should we expect a new
> > version sometime soon? Do you need more reviews on the current version?
>
&
On Tue, Oct 31, 2017 at 05:16:59PM -0700, Yi-Hung Wei wrote:
> On Mon, Oct 23, 2017 at 12:40 PM, Guru Shetty wrote:
> > On 23 October 2017 at 09:39, William Tu wrote:
> >
> >> Run "brew update" before any installs.
> >> This yields a clean build:
> >> https://travis-ci.org/williamtu/ovs-t
On Wed, Nov 01, 2017 at 04:01:10PM +, Stokes, Ian wrote:
> > On Fri, Aug 25, 2017 at 05:40:23PM +0100, Ian Stokes wrote:
> > > LibIpsecMB is required to enable the use of vdev cryptodev devices in
> > > DPDK. This patch adds a condition to check for the library when it is
> > > detected that ON
On Wed, Nov 01, 2017 at 04:14:23PM +, Stokes, Ian wrote:
> > On Fri, Aug 25, 2017 at 05:40:24PM +0100, Ian Stokes wrote:
> > > Upon callback for building/pushing a packet header when encapsulating
> > > for tunneling a reference to the vport in question is required to
> > > access associated de
On Wed, Nov 01, 2017 at 08:28:48AM -0700, Greg Rose wrote:
> On 10/31/2017 12:53 PM, Ben Pfaff wrote:
> >On Fri, Sep 22, 2017 at 07:44:53AM -0700, Greg Rose wrote:
> >>The maximum message size for recent Linux kernels is 32Kb and in older
> >>kernels it is 16KB.
> >
On Wed, Nov 01, 2017 at 05:01:42PM +, Stokes, Ian wrote:
> > On Fri, Aug 25, 2017 at 05:40:28PM +0100, Ian Stokes wrote:
> > > This patch introduces a new tunnel port type 'vxlanipsec'. This port
> > > combines vxlan tunnelling with IPsec operating in transport mode.
> > >
> > > Ciphering and a
On Wed, Nov 01, 2017 at 10:33:25AM -0700, Greg Rose wrote:
> On 11/01/2017 09:38 AM, Ben Pfaff wrote:
> >On Wed, Nov 01, 2017 at 08:28:48AM -0700, Greg Rose wrote:
> >> On 10/31/2017 12:53 PM, Ben Pfaff wrote:
> >>> On Fri, Sep 22, 2017 at 07:44:53AM -0700, Greg
On Tue, Oct 31, 2017 at 05:03:41PM -0700, William Tu wrote:
> The HAVE_SKB_GSO_UDP checks whether skbuff.h defines SKB_GSO_UDP.
> However, it falsely returns yes because grep matches SKB_GSO_UDP_TUNNEL.
> Thus, add space character '[:space:]' before and after it.
>
> Fixes: ad283644f0e4 ("acinclud
On Tue, Oct 31, 2017 at 05:29:51PM -0700, William Tu wrote:
> Clang reports possible null pointer 'lflows' passed to qsort.
> This is due to the checker unable to make sure whether 'lflows'
> gets malloc or not in the previous loop. Fix it by checking the
> 'n_flows' before calling qsort.
>
> Sig
On Wed, Nov 01, 2017 at 08:43:20AM -0700, Greg Rose wrote:
> On 10/30/2017 06:13 PM, fukaige wrote:
> >From: Kaige Fu
> >
> >IFF_NO_QUEUE is checked twice. This cause a situation
> >that HAVE_IFF_NO_QUEUE is defined no matter whether
> >the flag IFF_NO_QUEUE is defined in kernel or not.
> >
> >Sig
On Wed, Nov 01, 2017 at 01:17:04PM -0700, Greg Rose wrote:
> On 11/01/2017 01:01 PM, Ben Pfaff wrote:
> >On Wed, Nov 01, 2017 at 10:33:25AM -0700, Greg Rose wrote:
> >>On 11/01/2017 09:38 AM, Ben Pfaff wrote:
> >>>On Wed, Nov 01, 2017 at 08:28:48AM -0700, Greg Rose wr
The NSH draft added a TTL field. This adds basic support.
CC: Yi Yang
CC: Jan Scheurich
Signed-off-by: Ben Pfaff
---
include/openvswitch/nsh.h | 11 +++
lib/flow.c| 2 +-
lib/odp-execute.c | 10 +-
lib/packets.c | 4 +++-
4 files changed
On Wed, Aug 30, 2017 at 02:21:01AM +0800, Yi Yang wrote:
> IETF NSH draft will be approved by end of August, NSH header
> format has been finalized and won't be change anymore, so we
> need to follow this final spec to implement nsh.
>
> kernel data path also needs finalized uAPIs, they can't be
>
On Wed, Aug 30, 2017 at 03:58:58AM +0100, minglumlu wrote:
> In active-active bond, a non-active slave failure doesn't trigger
> the sending of learning packets. This patch fixes this issue.
>
> Signed-off-by: minglumlu
Thanks, I applied this to master.
Sorry about the long wait before I looked
On Wed, Sep 06, 2017 at 10:31:28AM -0400, Lance Richardson wrote:
> > From: "Mark Michelson"
> > To: d...@openvswitch.org
> > Sent: Wednesday, September 6, 2017 9:38:40 AM
> > Subject: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port
> > types.
> >
> > OVN is lenient with the types
On Wed, Oct 18, 2017 at 11:53:48AM -0500, Mark Michelson wrote:
> When this flag is set, then a multicast packet that would normally be
> delivered to ports on multiple hypervisors is only delivered to ports
> on the local hypervisor.
>
> The primary known use case for this is when multicast packe
On Wed, Oct 18, 2017 at 11:53:49AM -0500, Mark Michelson wrote:
> This change adds three new options to the Northbound
> Logical_Router_Port's ipv6_ra_configs option:
>
> * send_periodic: If set to "true", then OVN will send periodic router
> advertisements out of this router port.
> * max_interva
On Thu, Oct 26, 2017 at 01:09:01PM -0500, Mark Michelson wrote:
> There are a couple of places in ovn-northd that set the "peer" option on
> certain ports to "" in certain cases. In every case where a peer is
> looked up on a port binding, the code performs a NULL check in order to
> ensure a peer
On Tue, Oct 31, 2017 at 09:27:02AM -0500, Mark Michelson wrote:
> The ct_lb action previously assumed that any address arguments were
> IPv4. This patch expands the parsing, formatting, and encoding of ct_lb
> to be amenable to IPv6 addresses as well.
>
> Signed-off-by: Mark Michelson
Thanks for
On Thu, Nov 02, 2017 at 02:50:13PM +, Mark Michelson wrote:
> On Wed, Nov 1, 2017 at 4:38 PM Ben Pfaff wrote:
>
> > On Wed, Oct 18, 2017 at 11:53:49AM -0500, Mark Michelson wrote:
> > > This change adds three new options to the Northbound
> > > Logical_Router
On Thu, Nov 02, 2017 at 01:35:11PM +, Alin Serdean wrote:
>
>
> > -Original Message-
> > From: Xiao Liang [mailto:shaw.l...@gmail.com]
> > Sent: Thursday, November 2, 2017 4:32 AM
> > To: Alin Serdean
> > Cc: Ben Pfaff ; d...@openvswitch.org
&
On Thu, Nov 02, 2017 at 08:51:59AM +0800, Kaige Fu wrote:
> On 2017/11/2 4:19, Ben Pfaff wrote:
> > On Wed, Nov 01, 2017 at 08:43:20AM -0700, Greg Rose wrote:
> >> On 10/30/2017 06:13 PM, fukaige wrote:
> >>> From: Kaige Fu
> >>>
> >>>
On Thu, Nov 02, 2017 at 04:55:14PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> Presently if the user wants to start OVN db servers as separate containers,
> 'ovn-ctl'
> script is not useful as '--detach' option is passed when ovsdb-servers are
> started.
> If the container comm
On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote:
> On certain Ubuntu systems running the 4.4 based kernel depmod
> may not correctly search for module dependencies when newer
> openvswitch kernel modules have been installed in the extra
> directory at /lib/modules/$(uname -r)/extra. A sy
On Thu, Nov 02, 2017 at 02:57:00PM +, Mark Michelson wrote:
> On Wed, Nov 1, 2017 at 4:53 PM Ben Pfaff wrote:
>
> > On Tue, Oct 31, 2017 at 09:27:02AM -0500, Mark Michelson wrote:
> > > The ct_lb action previously assumed that any address arguments were
> > >
On Thu, Nov 02, 2017 at 11:13:55AM -0500, Mark Michelson wrote:
> This patchset adds the necessary items in order to support IPv6 load
> balancers in OVN. No syntax has changed in ovn-nbctl or in the
> northbound database to support this. Appropriate tests have been
> added to the testsuite as well
On Thu, Nov 02, 2017 at 06:53:02PM +0100, Jakub Sitnicki wrote:
> On Fri, 27 Oct 2017 08:40:23 -0700
> Ben Pfaff wrote:
>
> > When revalidation occurs at the same time that a bridge is being removed
> > or ovs-vswitchd is exiting, xlate_lookup_ofproto() races with deleti
On Thu, Nov 02, 2017 at 06:58:39PM +0100, Jakub Sitnicki wrote:
> On Thu, 2 Nov 2017 18:53:02 +0100
> Jakub Sitnicki wrote:
>
> > On Fri, 27 Oct 2017 08:40:23 -0700
> > Ben Pfaff wrote:
> >
> > > When revalidation occurs at the same time that a bridge is be
I'd appreciate it if someone would review this change. It is
documentation only.
On Tue, Oct 24, 2017 at 09:33:07AM -0700, Ben Pfaff wrote:
> It always seems odd that this isn't in the repo, so this adds it, with
> internal links properly directed.
>
> Si
On Thu, Nov 02, 2017 at 11:41:17PM +0530, Numan Siddique wrote:
> On Thu, Nov 2, 2017 at 11:15 PM, Ben Pfaff wrote:
>
> > On Thu, Nov 02, 2017 at 04:55:14PM +0530, nusid...@redhat.com wrote:
> > > From: Numan Siddique
> > >
> > > Presently if the user wa
On Thu, Nov 02, 2017 at 10:46:58AM +0800, wei wrote:
> ---
> ovn/northd/ovn-northd.8.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml
> index e9799e18a..37284301b 100644
> --- a/ovn/northd/ovn-northd.8.xml
> +++
On Wed, Nov 01, 2017 at 04:59:52PM -0700, Yi-Hung Wei wrote:
> Free the allocated memory in the pop function.
>
> Fixes: 0f2f05bbcf743 ("ofproto/trace: Add --ct-next option to ofproto/trace")
> Signed-off-by: Yi-Hung Wei
Thank you for the fix! I applied this to master and branch-2.8.
__
On Wed, Nov 01, 2017 at 02:40:27PM -0700, Yi-Hung Wei wrote:
> This patch fixes three C++ compilation errors when it includes
> "lib/packets.h".
>
> 1) Fix in "include/openvswitch/util.h" is to avoid duplicated
> named_member__ in struct pkt_metadata.
>
> 2) Fix in "lib/packets.h" is because desi
On Wed, Nov 01, 2017 at 09:53:48PM +, Alin Serdean wrote:
> > -Original Message-
> > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> > boun...@openvswitch.org] On Behalf Of Ben Pfaff
> > Sent: Wednesday, November 1, 2017 12:32 AM
> > To: A
On Thu, Nov 02, 2017 at 11:07:02AM +0800, fukaige wrote:
> From: Kaige Fu
>
> When max-rate is less than 8bit, the hc->max_rate will be set
> as htb->max_rate mistakenly instead of mtu of netdev.
>
> Fixes: 13c1637 ("smap: New function smap_get_ullong().")
>
> Signed-off-by: Kaige Fu
Thanks,
On Thu, Nov 02, 2017 at 12:55:13PM -0700, Greg Rose wrote:
> On 11/02/2017 11:12 AM, Greg Rose wrote:
> >On 11/02/2017 11:07 AM, Ben Pfaff wrote:
> >>On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote:
> >>> On certain Ubuntu systems running the 4.4 bas
Thank you for the patches! They look good to me, so I will apply them
to master soon. I folded in a few minor changes to patch 2, which I'll
mention in a reply to that patch.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman
On Thu, Nov 02, 2017 at 06:19:24AM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> This patch adds a new OVN action 'put_nd_ra_opts' to support native
> IPv6 Router Advertisement in OVN. This action can be used to respond
> to the IPv6 Router Solicitation requests.
Thanks for the pa
On Thu, Nov 02, 2017 at 01:37:40PM -0700, Ben Pfaff wrote:
> Thank you for the patches! They look good to me, so I will apply them
> to master soon. I folded in a few minor changes to patch 2, which I'll
> mention in a reply to that patch.
Oh, one more thing: I'd appreci
On Thu, Nov 02, 2017 at 06:42:22AM -0700, Yifeng Sun wrote:
> netdev_dummy_ip6addr() calls netdev_close() twice though it increases
> netdev's reference only once from netdev_from_name(). As a result, Valgrind
> test 788 (tunnel_push_pop - action) reports the error below:
Thanks a lot! I applie
On Tue, Oct 31, 2017 at 10:52:08AM -0700, Yifeng Sun wrote:
> Valgrind testcase 2339 (ovn -- ipam connectivity) reports the leak below:
> 45 (32 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss
> record 65 of 83
> at 0x4C2DB8F: malloc (in
> /usr/lib/valgrind/vgpreload_memche
On Tue, Oct 31, 2017 at 10:52:09AM -0700, Yifeng Sun wrote:
> Valgrind testcase 1465 (integer atom enum from string) reports the leak below:
> 16 bytes in 1 blocks are definitely lost in loss record 2 of 5
> at 0x4C2DB8F: malloc (in
> /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
>
On Tue, Oct 31, 2017 at 10:52:10AM -0700, Yifeng Sun wrote:
> Valgrind testcase 2349 (ovn -- DSCP marking check) reports the leak below:
> 21 bytes in 21 blocks are definitely lost in loss record 24 of 362
> at 0x4C2DB8F: malloc (in
> /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
>
On Mon, Sep 18, 2017 at 02:56:35PM -0700, Greg Rose wrote:
> On 09/06/2017 03:12 PM, Joe Stringer wrote:
> >In most situations, we don't expect that a flow we've successfully
> >dumped, which we intend to delete, cannot be deleted. However, to make
> >this code more resilient to ensure that ukeys *
On Thu, Nov 02, 2017 at 09:25:56PM +, Mark Michelson wrote:
> Looks good to me.
>
> On Thu, Nov 2, 2017 at 1:16 PM Ben Pfaff wrote:
>
> > I'd appreciate it if someone would review this change. It is
> > documentation only.
> >
> > On Tue, Oct 24,
On Fri, Nov 03, 2017 at 09:13:16AM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> OVN now supports sending IPv6 RA packet in response to the RS packet
> and resolves the unknown next hop MACs by generating a NS packet.
>
> Mention this in the NEWS.
>
> Signed-off-by: Numan Siddiqu
On Fri, Nov 03, 2017 at 09:16:36AM +0530, Numan Siddique wrote:
> On Fri, Nov 3, 2017 at 2:10 AM, Ben Pfaff wrote:
>
> > On Thu, Nov 02, 2017 at 01:37:40PM -0700, Ben Pfaff wrote:
> > > Thank you for the patches! They look good to me, so I will apply them
> > >
On Fri, Nov 03, 2017 at 09:08:26AM +0800, wei wrote:
> Signed-off-by: wei
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Nov 02, 2017 at 05:19:07PM -0700, Yi-Hung Wei wrote:
> On Tue, Oct 24, 2017 at 3:17 PM, Ben Pfaff wrote:
> > This patch, from July, still applies and still needs a review.
> >
> > On Fri, Jul 14, 2017 at 12:51:43PM -0700, Ben Pfaff wrote:
> >> The late
On Thu, Nov 02, 2017 at 11:54:16PM +, Haitham Ghalwash wrote:
> I am a little bit confused when interpreting the action part for the
> following rule, I got the rule by initiating the "ovs-ofctl dump-flows" on
> my mininet openflow switch.
>
>
> cookie=0x2ba5, duration=528.939s
On Fri, Nov 03, 2017 at 10:32:57AM -0700, Yi-Hung Wei wrote:
> Signed-off-by: Yi-Hung Wei
Thanks! Applied to master and branch-2.8.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Nov 03, 2017 at 01:53:53PM +0800, Xiao Liang wrote:
> Poll-loop is the core to implement main loop. It should be available in
> libopenvswitch.
>
> Signed-off-by: Xiao Liang
Applied to master, thanks!
___
dev mailing list
d...@openvswitch.org
h
On Fri, Nov 03, 2017 at 09:21:34PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> This patch adds the options to start clustered OVN db servers.
> To support this following options are added - '--db-nb-cluster-local-addr',
> '--db-nb-cluster-remote-addr', '--db-sb-cluster-local-addr
On Wed, Nov 01, 2017 at 05:46:43PM +, Sugesh Chandran wrote:
> DPDK allocate memory regions at the time of vswitchd init. To run multiple
> primary instance of DPDK including OVS on a single platform, the memory map
> regions in the filesystem should be distinct.
>
> The new configuration opti
On Tue, Oct 31, 2017 at 04:39:37PM -0700, Yipeng Wang wrote:
> This patch adds a delay during test 1215 for considering CD
> initialization time.
>
> CC: Darrell Ball
> CC: Jan Scheurich
> Signed-off-by: Yipeng Wang
> Signed-off-by: Antonio Fischetti
> Co-authored-by: Antonio Fischetti
> ---
Is this something that should be included in the repo?
On Fri, Nov 03, 2017 at 04:14:56PM +, Wang, Yipeng1 wrote:
> To make it easier for the code reviewers to build and test the patchset, a
> TREX profile that presents a very simple synthetic test case of random
> traffic with 20 different
On Tue, Oct 31, 2017 at 04:39:33PM -0700, Yipeng Wang wrote:
> Cuckoo distributor (CD) is a double-hash function hash table, that helps
> redirect packets to their corresponding subtables to avoid the sequential
> search of megaflow subtables. This is another layer of cache to cache flows
> and th
On Fri, Nov 03, 2017 at 01:55:00PM -0200, Flavio Leitner wrote:
> On Tue, 31 Oct 2017 12:11:32 +0100
> Timothy Redaelli wrote:
>
> > The reload procedure will trigger a script that saves the flows and tlv
> > maps (using ovs-save) then it restarts ovsdb-server, it stops ovs-vswitchd,
> > it sets
Thanks a lot for the reports. I'll see what I can do.
On Fri, Nov 03, 2017 at 10:05:02PM +0530, Numan Siddique wrote:
> Hi Ben,
>
> I have noticed a couple of issues when testing raft support in
> ovsdb-server. I am testing from your ovs-reviews/raft9 repo.
>
> 1) As I had mentioned in the IRC
On Thu, Nov 02, 2017 at 05:05:02PM -0200, Flavio Leitner wrote:
> The netlink notification's ancillary data contains the network
> namespace id (netnsid) needed to identify the device correctly.
> (ifindex and netnsid).
>
> Signed-off-by: Flavio Leitner
Thanks a lot for working on this.
I did n
On Fri, Nov 03, 2017 at 07:18:05PM +0100, Timothy Redaelli wrote:
> lib/pool-loop.h is moved to to include/openvswitch, but lib/pool-loop.h
> is still used in lib_libopenvswitch_la_SOURCES.
>
> This commit removes lib/pool-loop.h from lib_libopenvswitch_la_SOURCES.
>
> CC: Xiao Liang
> Fixes: fd
To start, I added this to my TODO file on that branch ;-)
On Fri, Nov 03, 2017 at 11:22:19AM -0700, Ben Pfaff wrote:
> Thanks a lot for the reports. I'll see what I can do.
>
> On Fri, Nov 03, 2017 at 10:05:02PM +0530, Numan Siddique wrote:
> > Hi Ben,
> >
> > I
On Wed, Nov 01, 2017 at 07:19:04PM +0200, Alin Gabriel Serdean wrote:
> _set_output_format is deprecated ang no longer required
> starting from MSC_VER 1900 (VS 2015):
> https://msdn.microsoft.com/en-us/library/bb531344(v=vs.140).aspx .
>
> Signed-off-by: Alin Gabriel Serdean
n-us/library/191ca0sk.aspx).
>
> This patch adds mappings for used functions.
>
> Signed-off-by: Alin Gabriel Serdean
How odd. I'll take your word for it.
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvsw
indows pthread we recommend checks for? I
don't see any checks for it in the OVS codebase itself.
If so,
Acked-by: Ben Pfaff
Thanks!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
it compare, although we could redefine the macro
> for the same effect.
>
> Signed-off-by: Alin Gabriel Serdean
That's super weird.
If this solves the problem, it's fine with me.
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Nov 03, 2017 at 07:26:05PM +0100, Timothy M. Redaelli wrote:
> On 11/03/2017 07:20 PM, Ben Pfaff wrote:
> [...]
> >>
> >> This looks good to me, my only comment is that the script is in rhel/
> >> and uses systemd so maybe we should reflect that in th
On Thu, Nov 02, 2017 at 05:05:01PM -0200, Flavio Leitner wrote:
> Today Open vSwitch doesn't know about network namespaces (netns), but
> users are moving internal ports to other namespaces. Although packets
> are still flowing, the daemon fails to find out basic port information,
> like if it is
On Fri, Sep 08, 2017 at 09:34:07AM +0800, Duan Jiong wrote:
> From 415ad9ffdb57a012729bef4ff19d1dc7b5b4cbcd Mon Sep 17 00:00:00 2001
> From: Duan Jiong
> Date: Fri, 8 Sep 2017 09:30:31 +0800
> Subject: [PATCH] fix the comment in struct ofbundle
>
> the ovs_list ports should contain struct ofport_
701 - 800 of 7535 matches
Mail list logo
