Re: [ovs-dev] [PATCH ovs V8 06/26] dpif-netlink: Flush added ports using netdev flow api

an <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> Flavio Leitner provided an Ack for v7 of this patch. You may want to consider adding that tag. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovs V8 03/26] other-config: Add hw-offload switch to control netdev flow offloading

f the kernel datapath. > This configuration option defaults to false - disabled. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> ... This does not appear

Re: [ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> Please add some text to the changelog. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon H

Re: [ovs-dev] [PATCH ovs V8 04/26] other-config: Add tc-policy switch to control tc flower flag

ule both to sw and hw. > This option is only relevant if hw-offload is enabled. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> This does not appear

Re: [ovs-dev] [PATCH ovs V8 07/26] netdev-tc-offloads: Implement netdev flow flush using tc interface

On Wed, May 03, 2017 at 06:07:58PM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [ovs-dev] [PATCH ovs V8 01/26] tc: Add tc flower interface

m itself. > Move some tc related functions from netdev-linux.c to tc.c > > Co-authored-by: Shahar Klein <shah...@mellanox.com> > Signed-off-by: Shahar Klein <shah...@mellanox.com> > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan &

Re: [ovs-dev] [PATCH v2 4/8] netdev-dpdk: implement flow put with rte flow

On Thu, Sep 14, 2017 at 10:35:10AM +0800, Yuanhan Liu wrote: > On Wed, Sep 13, 2017 at 11:45:30AM +0200, Simon Horman wrote: > > > > > +rte_memcpy(_spec.dst, >flow.dl_dst, > > > sizeof(eth_spec.dst)); > > > > > +rte_

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On Mon, Sep 18, 2017 at 07:16:03AM +0300, Roi Dayan wrote: > From: Paul Blakey > > To be later used to implement ovs action set offloading. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > --- > lib/tc.c | 372 >

Re: [ovs-dev] [PATCH V2] netdev-tc-offloads: Fix vxlan tunnel offloading

On Wed, Sep 13, 2017 at 05:04:58PM +0300, Roi Dayan wrote: > From: Paul Blakey > > This commit fixes offloading when tunnel id is 0 by checking > for valid tunnel dst ipv4 or ipv6, like done in the normal flow. > > Also need to reset the tunnel mask outside the condition >

Re: [ovs-dev] [PATCH] ovs-atomic: Reintroduce atomic_uint64_t and atomic_int64_t.

x uses > the 64-bit atomic_ullong and it is in Debian, which has tons of > architectures. > > CC: Simon Horman <ho...@verge.net.au> > Signed-off-by: Ben Pfaff <b...@ovn.org> Hi Ben, I do not have any recollection of the discussion around e09d61c41b4f, but this s

Re: [ovs-dev] [PATCH v2 2/8] dpif-netdev: retrieve flow directly from the flow mark

On Tue, Sep 05, 2017 at 05:22:55PM +0800, Yuanhan Liu wrote: > So that we could skip the heavy emc processing, notably, the > miniflow_extract function. A simple PHY-PHY forwarding testing > shows 53% performance improvement. > > Note that though the heavy miniflow_extract is skipped, we > still

Re: [ovs-dev] [PATCH v2 4/8] netdev-dpdk: implement flow put with rte flow

On Tue, Sep 05, 2017 at 05:22:57PM +0800, Yuanhan Liu wrote: > From: Finn Christensen > > The basic yet the major part of this patch is to translate the "match" > to rte flow patterns. And then, we create a rte flow with a MARK action. > Afterwards, all pkts matches the flow

Re: [ovs-dev] [PATCH v2 3/8] netdev-dpdk: convert ufid to dpdk flow

On Tue, Sep 05, 2017 at 05:22:56PM +0800, Yuanhan Liu wrote: > Flows offloaded to DPDK are identified by rte_flow pointer while OVS > flows are identified by ufid. This patches adds a hmap to convert ufid > to dpdk flow (rte_flow). > > Most of the code are stolen from netdev-tc-offloads.c, with

Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config

On Tue, Sep 05, 2017 at 05:23:01PM +0800, Yuanhan Liu wrote: > From: Finn Christensen > > The Intel i40e PMD driver requires the fdir mode set to > RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would > be failed. This appears to update a setting that is used more

Re: [ovs-dev] [PATCH v2 5/8] dpif-netdev: record rx queue id for the upcall

On Tue, Sep 05, 2017 at 05:22:58PM +0800, Yuanhan Liu wrote: > From: Shachar Beiser > > For the DPDK flow offload, which basically just binds a MARK action to > a flow, the MARK is required to be used together with a QUEUE action for > the most NICs I'm aware of. The

Re: [ovs-dev] [PATCH v2 7/8] netdev-dpdk: remove offloaded flow on deletion

On Tue, Sep 05, 2017 at 05:23:00PM +0800, Yuanhan Liu wrote: > Inovke netdev class '->flow_del' method on flow deletion. The dpdk netdev > implementation will then remove the rte flow associated with the ufid. > > Co-authored-by: Finn Christensen > Signed-off-by: Yuanhan Liu

Re: [ovs-dev] [PATCH 1/2] lib/odp: Fix handling of set masked action in parse_odp_action

-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> Some minor nits below but that notwithstanding Acked-by: Simon Horman <simon.hor...@netronome.com> > --- > lib/odp-util.c | 9 + > 1 file changed, 9 insertions(+)

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Fix offloading when tunnel id is 0

; > Fix this by testing the mask of tunnel id instead. > > Fixes: 8f283af89298 ("netdev-tc-offloads: Implement netdev flow put using tc > interface") > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> Acked-by: S

Re: [ovs-dev] [PATCH 2/2] tests/odp: Add set vlan test to odp testsuite

On Tue, Aug 29, 2017 at 07:30:24AM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> > > We support parsing set(vlan(vid,pcp,cfi)) so let's test it. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com>

Re: [ovs-dev] [PATCH v2 2/8] dpif-netdev: retrieve flow directly from the flow mark

On Mon, Sep 11, 2017 at 01:37:10PM +0800, Yuanhan Liu wrote: > On Fri, Sep 08, 2017 at 05:38:07PM +, Darrell Ball wrote: > > > +static inline bool > > > +dp_packet_has_flow_mark(struct dp_packet *p OVS_UNUSED, > > > +uint32_t *mark OVS_UNUSED) > > > +{ >

Re: [ovs-dev] [PATCH v2 4/8] netdev-dpdk: implement flow put with rte flow

On Tue, Sep 12, 2017 at 08:34:44AM +, Darrell Ball wrote: > > > On 9/10/17, 11:11 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yuanhan > Liu" <ovs-dev-boun...@openvswitch.org on behalf of y...@fridaylinux.org> > wrote: > > On Fri, Sep 08, 2

Re: [ovs-dev] [PATCH v2 6/8] netdev-dpdk: retry with queue action

On Tue, Sep 12, 2017 at 08:36:19AM +, Darrell Ball wrote: > > On 9/10/17, 11:14 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yuanhan > Liu" <ovs-dev-boun...@openvswitch.org on behalf of y...@fridaylinux.org> > wrote: > > On Fri, Sep 08, 2017 at 06

Re: [ovs-dev] [PATCH v2 3/8] netdev-dpdk: convert ufid to dpdk flow

On Mon, Sep 11, 2017 at 01:46:28PM +0800, Yuanhan Liu wrote: > On Fri, Sep 08, 2017 at 05:48:36PM +, Darrell Ball wrote: > > > > > +static inline void > > > +del_ufid_dpdk_flow_mapping(const ovs_u128 *ufid) > > > +{ > > > +struct ufid_dpdk_flow_data *data; > > > + > >

Re: [ovs-dev] [PATCH V2 0/2] fix odp parsing of set masked action

On Wed, Sep 13, 2017 at 04:57:23PM +0300, Roi Dayan wrote: > > > On 13/09/2017 16:44, Simon Horman wrote: > >On Sun, Sep 10, 2017 at 08:00:05AM +0300, Roi Dayan wrote: > >>Hi, > >> > >>The first commit is a fix for parsing set masked action

Re: [ovs-dev] [PATCH 3/4] tc: Add header rewrite using tc pedit action

On Thu, Aug 17, 2017 at 12:21:43PM +0300, Paul Blakey wrote: > > > On 14/08/2017 16:00, Simon Horman wrote: > >On Tue, Aug 08, 2017 at 05:21:53PM +0300, Roi Dayan wrote: > >>From: Paul Blakey <pa...@mellanox.com> > >> > >>To be later used to impl

Re: [ovs-dev] [PATCH V2 4/4] netdev-tc-offloads: Add support for action set

On Mon, Sep 25, 2017 at 05:48:49PM +0300, Paul Blakey wrote: > > > On 18/09/2017 18:05, Simon Horman wrote: > >On Mon, Sep 18, 2017 at 07:16:04AM +0300, Roi Dayan wrote: > >>From: Paul Blakey <pa...@mellanox.com> > >> > >>Implement support f

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote: > > > On 18/09/2017 18:01, Simon Horman wrote: > >On Mon, Sep 18, 2017 at 07:16:03AM +0300, Roi Dayan wrote: > >>From: Paul Blakey <pa...@mellanox.com> > >> > >>To be later used to impl

Re: [ovs-dev] [PATCH 0/7] Fixes for header rewrite feature

On Tue, Nov 21, 2017 at 02:40:35PM +0200, Roi Dayan wrote: > Hi, > > The following series fixes some issues with header rewrite > and some small refactoring. Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote: > > > On 27/09/2017 12:08, Simon Horman wrote: > > On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote: > > > > > > > > > On 18/09/2017 18:01, Simon Horman wrote: > > > &g

Re: [ovs-dev] [PATCH V2 0/4] Add offload support for action set

On Mon, Sep 18, 2017 at 07:16:00AM +0300, Roi Dayan wrote: > Hi, > > This series adds support for offloading action set using > tc interface. > > V1->V2: > - Check patch whitespaces fixes > - Changed flower_pedit_map to be non sparse. > - Missing handling of unsupported attributes

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: update stats properly on flow deletion

On Fri, Nov 17, 2017 at 04:45:05PM -0200, Flavio Leitner wrote: > On Fri, 17 Nov 2017 14:36:22 +0100 > Paolo Abeni wrote: > > Currently, when an offloaded DP flow is deleted, the related stats > > are unconditionally cleared. As a result the counters for the > > originating

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On Tue, Nov 21, 2017 at 07:50:24AM +0200, Roi Dayan wrote: > > > On 20/11/2017 14:30, Simon Horman wrote: > > On Sun, Nov 19, 2017 at 08:45:19AM +0200, Roi Dayan wrote: > > > > > > > > > On 16/11/2017 18:29, Simon Horman wrote: > > > > On

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On Sun, Nov 19, 2017 at 08:45:19AM +0200, Roi Dayan wrote: > > > On 16/11/2017 18:29, Simon Horman wrote: > > On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote: > > > > > > > > > On 27/09/2017 12:08, Simon Horman wrote: > > > >

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote: > > > On 27/09/2017 12:08, Simon Horman wrote: > > On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote: > > > > > > > > > On 18/09/2017 18:01, Simon Horman wrote: > > > &g

Re: [ovs-dev] [PATCH V2 3/4] tc: Add header rewrite using tc pedit action

On Tue, Oct 31, 2017 at 09:20:55AM +0200, Paul Blakey wrote: > > > On 30/10/2017 15:42, Simon Horman wrote: > > On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote: > > > > > > > > > On 27/09/2017 12:08, Simon Horman wrote: > > > >

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Probe for allowing multiple masks on single priority

On Sun, May 06, 2018 at 03:26:35PM +0300, Paul Blakey wrote: > OVS datapath flows aren't overlapping, so having their tc flower > counterparts be prioritized makes no sense, we did so because of a > tc flower restriction. > > Kernel tc flower added support for multiple masks on a single flower >

Re: [ovs-dev] [PATCH] lib: fix typo in fragment handling error message

s > Reviewed-by: Pieter Jansen van Vuuren > Reviewed-by: Simon Horman Thanks Louis. Everyone else, are there any objections to me applying this change? > --- > lib/meta-flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/meta-flow.c b/lib/meta

Re: [ovs-dev] [PATCH] lib: fix typo in fragment handling error message

On Wed, Jun 06, 2018 at 07:41:08AM -0700, Ben Pfaff wrote: > On Wed, Jun 06, 2018 at 11:47:13AM +0200, Simon Horman wrote: > > On Tue, May 29, 2018 at 08:51:15PM +0200, Louis Peens wrote: > > > The error message states that "not_first" is a valid selection > > &g

Re: [ovs-dev] [PATCH] dpctl: Properly reflect a rule's offloaded to HW state

On Sun, Jun 10, 2018 at 03:05:39PM +, Gavi Teitz wrote: > From: Simon Horman, Sent: Thursday, June 7, 2018 3:13 PM > >On Thu, Jun 07, 2018 at 09:36:59AM +0300, Gavi Teitz wrote: > >> Previously, any rule that is offloaded via a netdev, not necessarily > >> t

Re: [ovs-dev] [PATCH 0/6] offload Linux LAG devices to the TC datapath

On Thu, Jun 21, 2018 at 04:31:35PM -0700, Ben Pfaff wrote: > On Thu, Jun 21, 2018 at 06:27:19PM +0200, Simon Horman wrote: > > On 21 June 2018 at 18:15, Ben Pfaff wrote: > > > > > Simon, I see that you have reviewed these patches. Are you handling > > > t

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Fix probing multi mask per prio

On Mon, Jul 02, 2018 at 12:07:58PM +0300, Roi Dayan wrote: > When adding TC rules we save the prio so can reuse same prio > for same mask since different mask will have to use different prio. > The multi mask per prio probe broke this by using a prio but > get_prio_for_tc_flower() didn't know

Re: [ovs-dev] [PATCH v2] odp-util: Remove unnecessary TOS ECN bits rewrite for tunnels

On Tue, May 01, 2018 at 12:36:06PM +, Jianbo Liu wrote: > For tunnels, TOS ECN bits are never wildcard for the reason that they > are always inherited. OVS will create a rewrite action if we add rule > to modify other IP headers. But it also adds an extra ECN rewrite for > the action because

Re: [ovs-dev] [PATCH] odp-util: Remove unnecessary TOS ECN bits rewrite for tunnels

On 26 April 2018 at 14:50, Simon Horman <simon.hor...@netronome.com> wrote: > Thanks Jianbo, > > On 26 April 2018 at 07:54, Jianbo Liu <jian...@mellanox.com> wrote: > >> For tunnels, TOS ECN bits are never wildcard for the reason that they >> are always inherit

Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

umbo RX. Add a quirk for "igb" while the PMD is fixed. > > Reported-by: Louis Peens <louis.pe...@netronome.com> > Signed-off-by: Pablo Cascón <pablo.cas...@netronome.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> Hi Ian, this is a pretty importa

Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

RX support. This change fixes > > > the issue by only enabling scatter for NICs known to need it to > > > support jumbo RX. Add a quirk for "igb" while the PMD is fixed. > > > > > > Reported-by: Louis Peens <louis.pe...@netronome.com> > > > Signed-o

Re: [ovs-dev] [PATCH branch-2.8 1/1] tc flower: reorder tunnel encap/decap actions

e > unset, leading to an incorrect TC rule. This patch reorders the netlink > generation to ensure a decap is done before an encap if both exist. > > Patch was committed to master. Backport to branch 2.8 requested by Simon > Horman. > > Signed-off-by: John Hurley <john.hur...@ne

Re: [ovs-dev] [PATCH v5 0/5] OVS-DPDK flow offload with rte_flow

On Wed, Jan 10, 2018 at 02:53:19PM +, Chandran, Sugesh wrote: > Hi All, > > Based on the comments below, I wanted to call out for a meeting to decide > what further needs to be done to handle different kinds of hardware > acceleration in OVS-DPDK. We have some POC implementation that

Re: [ovs-dev] [PATCH 0/6] offload Linux LAG devices to the TC datapath

On 21 June 2018 at 18:15, Ben Pfaff wrote: > Simon, I see that you have reviewed these patches. Are you handling > this series? > Hi Ben, yes, I reviewed these patches during internal review. I'm happy to handle the series now its in external review. > On Thu, Jun 21, 2018 at 02:35:55PM

Re: [ovs-dev] [PATCH 1/4] lib/tc: Handle ttl for ipv6 too

On Thu, Jul 26, 2018 at 05:54:51PM +0300, Or Gerlitz wrote: > On Thu, Jul 26, 2018 at 5:41 PM, Simon Horman > wrote: > > On Wed, Jul 25, 2018 at 09:20:06PM +0300, Or Gerlitz wrote: > >> TTL can and should be used to match on IPv6's hop-limit, fix that. > > >>

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

Hi Gavi, On 26 July 2018 at 17:36, Justin Pettit wrote: > > > On Jul 26, 2018, at 7:29 AM, Gavi Teitz wrote: > > > > From: Justin Pettit, sent: Thursday, July 26, 2018 12:02 AM: > >> Commit ab15e70eb587 ("dpctl: Expand the flow dump type filter") had a > number of issues with style, build

Re: [ovs-dev] [PATCH] dpctl: Expand the flow dump type filter

On 25 July 2018 at 23:13, Justin Pettit wrote: > > > On Jul 25, 2018, at 9:17 AM, Simon Horman > wrote: > > > > On Thu, Jul 12, 2018 at 09:46:40AM +0300, Roi Dayan wrote: > >> > >> it could. > >> currently offload unit tests in the repo fail a

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

> >> number of issues with style, build breakage, and failing unit tests. > >> The patch is being reverted so that they can addressed. > >> > >> This reverts commit ab15e70eb5878b46f8f84da940ffc915b6d74cad. > >> > >> CC: Gavi Teitz >

Re: [ovs-dev] [PATCH 4/4] lib/tc: Support matching on ip tunnel tos and ttl

On Wed, Jul 25, 2018 at 09:20:09PM +0300, Or Gerlitz wrote: > Support matching on tos and ttl of ip tunnels > for the TC data-path. > > Signed-off-by: Or Gerlitz > Reviewed-by: Roi Dayan > --- ... > diff --git a/lib/tc.c b/lib/tc.c > index aa3147f..f5901d1 100644 > --- a/lib/tc.c > +++

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

Thanks Or, Thanks Ben, On 1 August 2018 at 08:43, Or Gerlitz wrote: > On Tue, Jul 31, 2018 at 1:40 PM, Or Gerlitz wrote: > > This series comes to address the case to set (encap) and match (decap) > > also the tos and ttl fields of TC based IP tunnels. This happens e.g > > due to inherit setup

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

On 1 August 2018 at 11:31, Simon Horman wrote: > Thanks Or, Thanks Ben, > > On 1 August 2018 at 08:43, Or Gerlitz wrote: > >> On Tue, Jul 31, 2018 at 1:40 PM, Or Gerlitz >> wrote: >> > This series comes to address the case to set (encap) and match (decap) >&

Re: [ovs-dev] [PATCH v2 3/3] ovn-northd: Propagate dynamic addresses to port group address sets.

Hi Jakub, On Mon, Jul 30, 2018 at 04:37:49PM +0200, Jakub Sitnicki wrote: > If a logical switch port belongs to a port group and has dynamic > addresses assigned, propagate the addresses to the auto-generated > address sets for the port group. > > Signed-off-by: Jakub Sitnicki > Acked-by: Han

Re: [ovs-dev] [PATCH] ovn: Fix typos in "ovn -- Address Set generation..." test.

([ovn-sbctl get Address_Set pg1_ip6 addresses], > - [0], [[["2001:db8:11::ff:fe00:1", "2001:db8:2::ff:fe00:2"]] > + [0], [[["2001:db8:1::ff:fe00:1", "2001:db8:2::ff:fe00:2"]] > ]) > > AT_CLEANUP Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 3/3] ovn-northd: Propagate dynamic addresses to port group address sets.

On Wed, Aug 01, 2018 at 11:44:58AM +0200, Jakub Sitnicki wrote: > Hi Simon, > > On Wed, 1 Aug 2018 11:23:30 +0200 > Simon Horman wrote: > > > Hi Jakub, > > > > On Mon, Jul 30, 2018 at 04:37:49PM +0200, Jakub Sitnicki wrote: > > > If a logical switch po

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

Hi Or, On 1 August 2018 at 13:21, Or Gerlitz wrote: > On Wed, Aug 1, 2018 at 2:07 PM, Simon Horman > wrote: > > On 1 August 2018 at 11:31, Simon Horman > wrote: > >> > >> Thanks Or, Thanks Ben, > >> > >> On 1 August 2018 at 08:43, Or Gerlitz

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

On Sun, Jul 29, 2018 at 11:46:35PM -0700, Justin Pettit wrote: > Add support for configuring meters through the Meter and Meter_Band > tables in the Northbound database. This commit also has ovn-northd > sync those tables between the Northbound and Southbound databases. > > Add support for

Re: [ovs-dev] [PATCH] ovn: Fix typos in "ovn -- Address Set generation..." test.

On Wed, Aug 01, 2018 at 11:56:09AM +0200, Simon Horman wrote: > On Tue, Jul 31, 2018 at 12:45:41PM -0700, Ben Pfaff wrote: > > These caused the test to fail. > > > > CC: Jakub Sitnicki > > Fixes: 984c7d5ea8fe ("ovn-northd: Propagate dynamic addresses to port group

Re: [ovs-dev] [PATCH V2 0/4] Enable set/match of tos/ttl for IP tunnels on TC data-path

On Wed, Aug 01, 2018 at 04:28:03PM +0300, Or Gerlitz wrote: > On Wed, Aug 1, 2018 at 2:29 PM, Simon Horman > wrote: > > Hi Or, > > > > On 1 August 2018 at 13:21, Or Gerlitz wrote: > >> > >> On Wed, Aug 1, 2018 at 2:07 PM, Simon Horman > >> wr

Re: [ovs-dev] [PATCH 2/4] lib/tc: Support matching on ip tos

Hi Or, On Wed, Jul 25, 2018 at 09:20:07PM +0300, Or Gerlitz wrote: > Add the missing code to match on ip tos when dealing > with the TC data-path. > > Signed-off-by: Or Gerlitz > Reviewed-by: Roi Dayan > --- > include/openvswitch/match.h | 1 + > lib/match.c | 7 +++ >

Re: [ovs-dev] [PATCH 0/2] Reflecting a flow's offloaded state - continuation

Hi Gavi, On 10 August 2018 at 10:30, Gavi Teitz wrote: > Continuing work done on improving visibility of a flow's offloaded > state via dpctl, which was begun in commit d63ca5329ff9 ("dpctl: > Properly reflect a rule's offloaded to HW state"). > > The first commit addresses the initialization

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

On Tue, Aug 07, 2018 at 05:07:58PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > The python function ovs.socket_util.check_connection_completion() uses > select() > (provided by python) to monitor the socket file descriptor. The select() > returns 1 when the file descriptor

Re: [ovs-dev] [PATCH 1/2] vswitch.xml: Fix key type and description style of tc-policy.

control tc flower flag") > Signed-off-by: Ilya Maximets Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] RX Mirroing issue with Decap in vxlan case

Hi Ben, given the history of the offload code where output to more than one port is a relatively new feature it does seem entirely possible to me that there is a bug in the offload code as described below. I will look into getting this investigated and if necessary fixed. On Tue, Aug 21, 2018

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

On 19 August 2018 at 00:12, Ben Pfaff wrote: > On Sat, Aug 18, 2018 at 09:40:05PM +0200, Simon Horman wrote: > > On Tue, Aug 07, 2018 at 05:07:58PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > The python function ovs.socket_util.

Re: [ovs-dev] [PATCH v3 0/4] Add support to offload QinQ

e OVS tree to finish before applying this series. Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] dpctl: Expand the flow dump type filter

On Thu, Jul 12, 2018 at 09:46:40AM +0300, Roi Dayan wrote: > > > On 11/07/2018 16:24, Simon Horman wrote: > > On Sun, Jul 08, 2018 at 02:15:38PM +0300, Gavi Teitz wrote: > >> Added new types to the flow dump filter, and allowed multiple filter > >> types

Re: [ovs-dev] [PATCH v3 0/4] Add support to offload QinQ

On Tue, Jul 24, 2018 at 10:15:27AM +0200, Simon Horman wrote: > On Tue, Jul 17, 2018 at 02:01:53AM +, Jianbo Liu wrote: > > This patchset is to support QinQ offloading, as TC flower supports QinQ. > > > > v3: > > fix checkpatch warning in patch 4. > &

Re: [ovs-dev] [PATCH 0/2] Fixes for TC DP matching on IP tunnels ttl/tos

On Thu, Sep 06, 2018 at 01:52:24PM +0300, Or Gerlitz wrote: > The tc library wrongly programs the kernel tc stack to match > on tunnel ttl/tos also when not needed. Fix that by taking into > account the mask. Thanks Or, pushed to master. ___ dev mailing

Re: [ovs-dev] [ovs-dev, v2] tests: Make test result more predictable.

On Fri, May 18, 2018 at 09:52:23AM -0700, Darrell Ball wrote: > The test 'ofproto-dpif - in place modification (vlan)' fails often > due to miss handling. Hence, make it more predictable by specifying > that misses should just be dropped. > > Signed-off-by: Darrell Ball This patch was applied

Re: [ovs-dev] [PATCH 2/2] ovn-northd: Support learning neighbor from ARP request.

On Sun, Aug 19, 2018 at 10:27:31PM -0700, Han Zhou wrote: > Current LR dynamic ARP learning support only ARP responses. If a > IP-MAC binding is learned, it will not get updated even if a host > send a GARP *request* to inform the new binding. This patch supports > learning neighbor changes from

Re: [ovs-dev] [ovs-dev, v2] tests: Make test result more predictable.

On Fri, Sep 07, 2018 at 07:52:07AM -0700, Darrell Ball wrote: > should be fine to backport as far as applicable Simon Thanks, for now I pushed backports going back as far as branch-2.8. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v2] lib/tc: add single mpls match offload support

On Mon, Sep 03, 2018 at 11:22:00AM +0200, Simon Horman wrote: > On Sun, Sep 02, 2018 at 02:07:49PM +0100, Pieter Jansen van Vuuren wrote: > > Add TC offload support for classifying single MPLS tagged traffic. > > > > Signed-off-by: Pieter Jansen van Vuuren > > &g

Re: [ovs-dev] [PATCH ovs] lib/tc: reject offloading of non-Ethernet packets

by: Louis Peens > Reviewed-by: Pieter Jansen van Vuuren > Reviewed-by: Simon Horman Thanks Louis, this looks good to me. I would, however, like to wait a little before applying in order to allow time for others to review this patch. > --- > lib/netdev-tc-offloads.c | 4 >

Re: [ovs-dev] [PATCH 2/2] ovn-northd: Support learning neighbor from ARP request.

On Fri, Sep 07, 2018 at 11:41:54AM -0700, Han Zhou wrote: > On Fri, Sep 7, 2018 at 5:43 AM Simon Horman > wrote: > > > > On Sun, Aug 19, 2018 at 10:27:31PM -0700, Han Zhou wrote: > > > Current LR dynamic ARP learning support only ARP responses. If a >

Re: [ovs-dev] [PATCH ovs] lib/tc: reject offloading of non-Ethernet packets

On Thu, Sep 06, 2018 at 10:08:15AM +0200, Simon Horman wrote: > On Wed, Sep 05, 2018 at 03:26:24PM +0200, Louis Peens wrote: > > When a packet is marked with the special ethtype of OFP_DL_TYPE_NOT_ETH_TYPE > > it got wrongly installed into tc datapath as a match on a packet with t

Re: [ovs-dev] [PATCH] lib/tc: treat vlan id and prio as independent fields

c >Action statistics: >Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >backlog 0b 0p requeues 0 >cookie 47040ae7a94fff6afd7ed8aa04b11ba4 > > Signed-off-by: Pieter Jansen van Vuuren > Reviewed-by: Simon Horman Thanks Pieter, this looks goo

Re: [ovs-dev] [PATCH 2/2] dpctl: Expand the flow dump type filter

On Fri, Aug 10, 2018 at 11:30:08AM +0300, Gavi Teitz wrote: > Added new types to the flow dump filter, and allowed multiple filter > types to be passed at once, as a comma separated list. The new types > added are: > * tc - specifies flows handled by the tc dp > * non-offloaded - specifies flows

Re: [ovs-dev] [PATCH 1/2] vswitch.xml: Fix key type and description style of tc-policy.

On Mon, Aug 27, 2018 at 01:56:53PM +0200, Simon Horman wrote: > On Fri, Aug 24, 2018 at 06:13:19PM +0300, Ilya Maximets wrote: > > The set of supported values specified. > > Style fixed to look good in man page. Fixed indents. > > > > CC: Paul Blakey > > Fixes:

Re: [ovs-dev] [PATCH ovs-2.8] lib/tc: reject offloading of non-Ethernet packets

On Mon, Sep 10, 2018 at 08:37:40PM +0200, Louis Peens wrote: > When a packet is marked with the special ethtype of OFP_DL_TYPE_NOT_ETH_TYPE > it got wrongly installed into tc datapath as a match on a packet with that > ethtype. This prevents that from happening. > > Signed-off-by: Louis Peens >

Re: [ovs-dev] [PATCH] dpctl: Expand the flow dump type filter

On Sun, Jul 08, 2018 at 02:15:38PM +0300, Gavi Teitz wrote: > Added new types to the flow dump filter, and allowed multiple filter > types to be passed at once, as a comma separated list. The new types > added are: > * tc - specifies flows handled by the tc dp > * non-offloaded - specifies flows

Re: [ovs-dev] [PATCH OVS 1/1] tc flower: reorder tunnel encap/decap actions

Signed-off-by: John Hurley <john.hur...@netronome.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- > lib/tc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/tc.c b/lib/tc.c > index bfe20ce..

Re: [ovs-dev] [PATCH OVS 1/1] tc flower: reorder tunnel encap/decap actions

e > unset, leading to an incorrect TC rule. This patch reorders the netlink > generation to ensure a decap is done before an encap if both exist. > > Signed-off-by: John Hurley <john.hur...@netronome.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> Thanks John,

Re: [ovs-dev] [PATCH branch-2.8] lib/tc: Handle error parsing action in nl_parse_single_action

On Thu, Apr 05, 2018 at 05:16:59PM +0300, Simon Horman wrote: > On Wed, Apr 04, 2018 at 04:51:01PM -0700, Ben Pfaff wrote: > > On Thu, Mar 22, 2018 at 03:32:58PM +0100, Simon Horman wrote: > > > On Thu, Mar 22, 2018 at 03:46:17PM +0200, Roi Dayan wrote: > > > > >

Re: [ovs-dev] [PATCH] tc: Change filter error to debug once

On Wed, Apr 11, 2018 at 10:57:30AM +0300, Roi Dayan wrote: > Also update the message to be more correct. > Before this commit if there were tc rules that are not of type > flower the log was getting filled quickyl with errors about it > and always appeared to the user when dumping flows from user

Re: [ovs-dev] [Suspected-Phishing] [ovs-dev 0/2] Add offloading of multiple outputs

On 12 April 2018 at 09:29, Chris Mi wrote: > A reminder. > Thanks Chris, this is on my todo list. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovs-dev 0/2] Add offloading of multiple outputs

On Tue, Apr 10, 2018 at 02:18:07PM +0900, Chris Mi wrote: > This patchset adds the offloading support of multiple outputs. > > The first patch makes the actions order consistent. In previous > implementation, the actions order is lost when offloading. If there > is only one output, there is on

Re: [ovs-dev] [PATCH] lib/tc: Remove unnecessary icmp recalculation

On 25 April 2018 at 10:09, Jianbo Liu wrote: > ICMP checksum is calculated from ICMP headers and data, so hardware doesn't > need to calculate it again because we only rewrite IP headers. > > Signed-off-by: Jianbo Liu > Reviewed-by: Paul Blakey

Re: [ovs-dev] [PATCH] lib/netdev-tc-offloads: Fix frag first/later translation

On Sun, Mar 25, 2018 at 12:53:25PM +0300, Roi Dayan wrote: > > > On 25/03/2018 12:11, Roi Dayan wrote: > > Fragment mask (any and later) always exists so we need to test > > for FLOW_NW_FRAG_LATER only if the state is FLOW_NW_FRAG_ANY. > > Before this fix we could pass frag no and first at the

Re: [ovs-dev] [PATCH] lib/netdev-tc-offloads: Fix frag first/later translation

On Thu, Mar 29, 2018 at 03:46:00PM +0300, Roi Dayan wrote: > > > On 28/03/2018 15:54, Simon Horman wrote: > > On Sun, Mar 25, 2018 at 12:53:25PM +0300, Roi Dayan wrote: > > > > > > > > > On 25/03/2018 12:11, Roi Dayan wrote: > > > >

Re: [ovs-dev] [PATCH branch-2.8] lib/tc: Handle error parsing action in nl_parse_single_action

e an error an incorrect rule was also printed. > > > > > > Signed-off-by: Roi Dayan <r...@mellanox.com> > > > Reviewed-by: Paul Blakey <pa...@mellanox.com> > > > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > > > oops sorry about t

Re: [ovs-dev] [PATCH V1 1/2] lib/tc: Handle error parsing action in nl_parse_single_action

On Mon, Mar 12, 2018 at 02:58:46PM +0200, Roi Dayan wrote: > Raise the error up instead of ignoring it. > Before this commit beside an error an incorrect rule was also printed. > > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey Thanks, applied to

Re: [ovs-dev] [PATCH V1 2/2] netdev-tc-offloads: Add support for IP fragmentation

On Mon, Mar 12, 2018 at 02:58:47PM +0200, Roi Dayan wrote: > Add support for frag no, first and later. > > Signed-off-by: Roi Dayan > Reviewed-by: Shahar Klein > Reviewed-by: Paul Blakey Thanks, applied to master.

Re: [ovs-dev] [PATCH V1 0/2] TC offload dump fix and add frag

2018/03/20 17:21 "Roi Dayan" : On 12/03/2018 14:58, Roi Dayan wrote: > Hi, > > The first patch fixing error handling when parsing tc rules for dump flows. > The second patch adds support for IP fragmentation to TC parsing. > > V1: > - also support frag first/later > >

Re: [ovs-dev] [PATCH] odp-util: Remove unnecessary TOS ECN bits rewrite for tunnels

Thanks Jianbo, On 26 April 2018 at 07:54, Jianbo Liu wrote: > For tunnels, TOS ECN bits are never wildcard for the reason that they > are always inherited. OVS will create a rewrite action if we add rule > to modify other IP headers. But it also adds an extra ECN rewrite

Re: [ovs-dev] [PATCH v3 0/6] offload Linux LAG devices to the TC datapath

On Thu, Jun 28, 2018 at 05:03:01PM +0100, John Hurley wrote: > This patchset extends OvS TC and the linux-netdev implementation to > support the offloading of Linux Link Aggregation devices (LAG) and their > slaves. TC blocks are used to provide this offload. Blocks, in TC, group > together a

Re: [ovs-dev] [PATCH v7 0/3] Support dynamic rebalancing of offloaded flows

On Thu, Oct 11, 2018 at 04:01:40PM -0700, Ben Pfaff wrote: > Thanks for the revision. > > This seems basically OK at a glance but I'd like a second set of eyes. > Simon, are you willing to review this? It seems roughly in your area > too. Thanks Ben, this has been on my todo list for a little

<    1   2   3   4   5   6   7   8   9   10   >