On Fri, Nov 10, 2017 at 7:54 AM, Eric Garver wrote:
> On Fri, Nov 10, 2017 at 05:36:25AM -0800, William Tu wrote:
>> Before we introduce dpif-netlink-rtnl, creating a tunnel device
>> depends on openvswitch/vport kernel module calling kernel's tunnel API.
>> Ex
>> After the dpif-netlink-rtnl, a tunnel device can be created by using
>> rtnetlink, so the creation of fb device comes from the ovs-vswitchd
>> instead of going through OVS kernel modules. This breaks the module
>> dependency between 1) and 2). As a result, when ovs-vswitchd is running,
>> the
>> yes, this is an artificial dependency. Another way I'm thinking is for
>> ovs-vswitchd
>> to hold the geneve.ko dependency instead of openvswitch.ko, when user
>> creates
>> a geneve device. Is there a way to do that through rtnetlink or at
>> dpif_netlink_rtnl_create()?
>
> It should be vport
n "iptables stop" runs, since
> "geneve" has nothing to do with conntrack, it spares it.
> Ideally, we should fix this by incrementing the refcount
> on the kernel modules.
>
> Signed-off-by: Gurucharan Shetty
> ---
Looks good to me.
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Nov 13, 2017 at 5:01 AM, Pravin Shelar wrote:
> On Sat, Nov 11, 2017 at 11:53 PM, Guru Shetty wrote:
>> On 10 November 2017 at 22:54, Gregory Rose wrote:
>>
>>> On 11/11/2017 9:57 AM, William Tu wrote:
>>>
>>>> yes, this is an artificia
>>
>> That is always been behavior of the port lifecycle. If you remove the
>> driver of a device, port is removed from kernel datapath and the
>> device is deleted from kernel networking stack. For example you can
>> remove intel NIC driver, or veth module even if there is a
>> corresponding port
ravis which appear to be because, although the system
>> supports
>> IPv6, test programs are not allowed to connect or bind IPv6 addresses.
>> This commit refines the test for IPv6 to also try to bind the IPv6
>> localhost address, which should convert the test failures to &quo
On Tue, Nov 14, 2017 at 10:15 AM, Ben Pfaff wrote:
> White space changes only.
>
> Signed-off-by: Ben Pfaff
> ---
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
other since either one could change independently. This commit
> merges them into a single data structure (with two indexes), which at least
> means that if one is removed then the other is as well.
>
> Signed-off-by: Ben Pfaff
> ---
Looks good t
skip processing of further actions from the action-set
> once a batch is emptied. Doing so centralizes the check in one place and
> avoids the possibility of crashes.
>
> Signed-off-by: Vishal Deep Ajmera
> ---
nit: please wrap your commit messages to about 75 columns
otherwise looks
to generate coredump
file to help debugging.
Signed-off-by: William Tu
---
lib/memory.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/lib/memory.c b/lib/memory.c
index da97476c6a45..75cce6e5dcc3 100644
--- a/lib/memory.c
+++ b/lib/memory.c
@@ -25,6 +25,7
On Tue, Dec 19, 2017 at 3:08 PM, Wang, Yipeng1 wrote:
> Hi, Jan,
>
> Please see my comments inlined.
>
> Thanks
> Yipeng
>
>>-Original Message-
>>From: Jan Scheurich [mailto:jan.scheur...@ericsson.com]
>>Sent: Monday, December 18, 2017 9:01 AM
>>To: Wang, Yipeng1 ; d...@openvswitch.org
>>C
Hi Yipeng,
Thanks for the reply.
On Tue, Jan 2, 2018 at 10:45 AM, Wang, Yipeng1 wrote:
> Hi, William,
>
> Thanks for the comment. You are right. If the RSS hash does not consider the
> fields that matter, the situation you mentioned could happen.
>
> There are two design options for CD as you m
On Thu, Jan 4, 2018 at 5:41 PM, Wang, Yipeng1 wrote:
> I agree with you guys on the issue with RSS hash.
>
> RSS is not originally designed for hash table so it is not flexible enough to
> be configured
> in the NICs. Smart NICs will be more capable to offload hash calculation etc,
> I think.
>
Hi Yipeng,
On Mon, Jan 8, 2018 at 1:54 PM, Wang, Yipeng1 wrote:
> I think this is an interesting idea.
>
> One caveat is that in this case we use the rules' field to infer the flows'
> field. If the rule
> does not consider a field within which the flow has high entropy, it still
> does not hel
no key set up, so we should match
'flags(df)' instead of 'flags(df|key)'. The second case
'tunnel - concomitant IPv6 and IPv4 tunnels' follows the same pattern.
One additional test case 'tunnel - Mix Geneve/GRE options' is added.
VMWare-BZ: #2019012
Sig
On Wed, Jan 10, 2018 at 1:27 PM, Ben Pfaff wrote:
> On Wed, Jan 10, 2018 at 10:04:48AM -0800, William Tu wrote:
>> Existing code only set these tunnel flags (df, csum, and key) when the
>> flag is set in the output tunnel port, but did not clear when the flag
>> is unset.
no key set up, so we should match
'flags(df)' instead of 'flags(df|key)'. The second case
'tunnel - concomitant IPv6 and IPv4 tunnels' follows the same pattern.
One additional test case 'tunnel - Mix Geneve/GRE options' is added.
Signed-off-by: William Tu
VMW
d time if it reported an error.
>
> Signed-off-by: Ben Pfaff
> ---
Acked-by: William Tu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
kie
> for the log message. This fixes the problem.
>
> (The greatest likely consequence of this bug was logging the wrong cookie
> value.)
>
> Signed-off-by: Ben Pfaff
> ---
Looks good to me.
Acked-by: William Tu
> ofproto/ofproto.c | 10 --
> 1 file chang
On Thu, Jan 25, 2018 at 3:39 PM, Ben Pfaff wrote:
> This avoids a memory leak warning from valgrind.
>
> ovn-sbctl and ovn-nbctl already followed this pattern.
>
> Signed-off-by: Ben Pfaff
> ---
Looks good to me.
Acked-by: William Tu
> utilities/ovs-vsctl.c | 12
rwise users
have to remember to bump up this barrier number.
Acked-by: William Tu
> lib/ovs-rcu.c | 55
> +++--
> lib/ovs-rcu.h | 2 ++
> vswitchd/ovs-vswitchd.c | 2 ++
> 3 files changed, 57 insertions(+),
t of the job for glibc since it keeps the threads around for some
> undefined idle time before killing them, so in addition this commit adds a
> valgrind suppression to stop displaying these warnings in any case.
>
> Signed-off-by: Ben Pfaff
> ---
Looks good to me.
Acked-by: William
On Mon, Jan 29, 2018 at 2:27 PM, Ben Pfaff wrote:
> On Mon, Jan 29, 2018 at 02:16:24PM -0800, William Tu wrote:
>> On Thu, Jan 25, 2018 at 3:39 PM, Ben Pfaff wrote:
>> > ovs-vswitchd makes extensive use of RCU to defer freeing memory past the
>> > latest time that it
On Mon, Jan 29, 2018 at 2:44 PM, Ben Pfaff wrote:
> On Mon, Jan 29, 2018 at 02:35:35PM -0800, William Tu wrote:
>> On Mon, Jan 29, 2018 at 2:27 PM, Ben Pfaff wrote:
>> > On Mon, Jan 29, 2018 at 02:16:24PM -0800, William Tu wrote:
>> >> On Thu, Jan 25, 201
The offsetof(struct ovs_router_entry, cr) should always be 0,
thus the else statement should never be reached.
Signed-off-by: William Tu
---
lib/ovs-router.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ovs-router.c b/lib/ovs-router.c
index cd2ab15fb003..bc8616858a84
On Wed, Jan 31, 2018 at 11:27 AM, Ben Pfaff wrote:
> On Wed, Jan 31, 2018 at 11:03:04AM -0800, William Tu wrote:
>> The offsetof(struct ovs_router_entry, cr) should always be 0,
>> thus the else statement should never be reached.
>>
>> Signed-off-by: William Tu
>
The offsetof(struct ovs_router_entry, cr) should always be 0,
thus the else statement should never be reached.
Signed-off-by: William Tu
---
lib/ovs-router.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/ovs-router.c b/lib/ovs-router.c
index cd2ab15fb003
Current learn test cases use only ovs-ofctl add/del flows.
The patch add a new test case for learn with delete_learned and
limit option enabled.
Signed-off-by: William Tu
---
tests/learn.at | 38 ++
1 file changed, 38 insertions(+)
diff --git a/tests
> Thanks William.
> I have question - is this test case trying to delineate some related bug or
> observed special behavior ?
We suspect that there might be a memory leak in learn action. So I
created this test.
> I am asking because I don't immediately see the intersection b/w the
> delete_learn
Hi Zhike,
On Fri, Feb 2, 2018 at 7:48 AM, Ben Pfaff wrote:
> On Fri, Feb 02, 2018 at 12:37:58PM +, 王志克 wrote:
>> I also found that if once theres are lots of flows, the memory (RSS) usage
>> of OVS process would be quite high, 2~3GB. Even then the flows disappear
>> later, the memory still
recursion is too deep or too many resubmit, by
invoking the translation again, and log the ofproto trace as warnings.
VMWare-BZ: #2054659
Signed-off-by: William Tu
---
ofproto/ofproto-dpif-trace.c | 7 +--
ofproto/ofproto-dpif-trace.h | 6 ++
ofproto/ofproto-dpif-upcall.c | 19
On Thu, Feb 8, 2018 at 3:18 PM, Ben Pfaff wrote:
> Bundles are implemented for both OF1.3 and OF1.4+, so no need to keep it
> in the list. Packet type aware pipeline is now implemented too.
>
> Signed-off-by: Ben Pfaff
Looks good to me.
Acked-by: William Tu
> ---
> Do
On Thu, Feb 8, 2018 at 3:18 PM, Ben Pfaff wrote:
> Also implements the backports of relevant errors to OF1.3 as specified in
> ONF extension pack 1 for OF1.3.
>
> ONF-JIRA: EXT-237
> ONF-JIRA: EXT-230
> ONF-JIRA: EXT-264
> Signed-off-by: Ben Pfaff
> ---
Looks good to
On Thu, Feb 8, 2018 at 3:18 PM, Ben Pfaff wrote:
> This removes the requirement of exactly two spaces before the error
> description (now one or more is fine). It also makes an error message
> clearer.
>
> Signed-off-by: Ben Pfaff
> ---
Looks good to me.
Acked-by: William
---
Looks good to me. I tested it without seeing any failure.
Acked-by: William Tu
> Documentation/topics/openflow.rst | 8 -
> NEWS | 2 ++
> include/openvswitch/ofp-msgs.h| 5 ++-
> lib/ofp-util.c| 33 ++-
When hitting max translation depth of 64, printing the full
ofproto trace is huge and consumes too much log. The patch
adds a short trace log, which prints the 64 backward resubmit
table IDs during the translation.
VMWare-BZ: #2054659
Signed-off-by: William Tu
---
An example output:
2018-02
recursion is too deep or too many resubmit, by
invoking the translation again, and log the ofproto trace as warnings.
Since the log will be huge, rate limit to one per minute.
VMWare-BZ: #2054659
Signed-off-by: William Tu
Tested-by: Greg Rose
Reviewed-by: Greg Rose
---
ofproto/ofproto-dpif-trace.c
Replace 'set' with 'sed'.
Signed-off-by: William Tu
---
tests/odp.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/odp.at b/tests/odp.at
index ea8f40ede78b..cdf3d6645ea4 100644
--- a/tests/odp.at
+++ b/tests/odp.at
@@ -30,9 +30,9 @@
in_port
On Fri, Feb 16, 2018 at 3:12 PM, Ben Pfaff wrote:
> On Fri, Feb 16, 2018 at 10:42:42AM -0800, William Tu wrote:
>> Replace 'set' with 'sed'.
>>
>> Signed-off-by: William Tu
>> ---
>> tests/odp.at | 4 ++--
>> 1 file changed, 2 inse
Signed-off-by: William Tu
---
datapath/linux/compat/include/net/ip6_fib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath/linux/compat/include/net/ip6_fib.h
b/datapath/linux/compat/include/net/ip6_fib.h
index 4d58375958a2..8545f4001f40 100644
--- a/datapath
The RFC patch adds erspan support for OVS to use the
erspan feature in its kernel datapath. Currently the
patch only works on kernel 4.15 thus I mark it as RFC.
The first patch fixes the compile error on 4.15, and
the second patch introduces erspan tunnel protocol.
William Tu (2):
erspan: fix
fields for more details.
Signed-off-by: William Tu
---
datapath/linux/compat/include/linux/openvswitch.h | 2 +
include/openvswitch/flow.h| 4 +-
include/openvswitch/match.h | 8 ++
include/openvswitch/meta-flow.h | 56 +++
Trivial grammer fix.
Signed-off-by: William Tu
---
datapath/linux/compat/include/net/ip_tunnels.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/linux/compat/include/net/ip_tunnels.h
b/datapath/linux/compat/include/net/ip_tunnels.h
index abb8ca63e5e4..ae60f09e2a23
On Sat, Feb 24, 2018 at 2:33 PM, Gregory Rose wrote:
> On 2/21/2018 2:19 PM, William Tu wrote:
>>
>> The RFC patch adds erspan support for OVS to use the
>> erspan feature in its kernel datapath. Currently the
>> patch only works on kernel 4.15 thus I mark it as RFC.
&
On Wed, Feb 14, 2018 at 3:03 PM, Ben Pfaff wrote:
> On Wed, Feb 14, 2018 at 10:56:08AM -0800, William Tu wrote:
>> Usually ofproto/trace is used to debug the flow translation error.
>> When translation error such as recursion too deep or too many resubmit,
>> the issue m
counts.
VMWare-BZ: #2054659
Signed-off-by: William Tu
---
ofproto/ofproto-dpif-xlate.c | 45 ++--
tests/ofproto-dpif.at| 2 ++
2 files changed, 45 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif
"dpif-netlink" is the dpif to communicate with kernel.
So replace "dpif-linux" with "dpif-netlink".
Signed-off-by: William Tu
---
ofproto/ofproto-dpif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.h b/ofproto/ofp
On Wed, Feb 28, 2018 at 2:14 PM, Ben Pfaff wrote:
> On Mon, Feb 26, 2018 at 01:43:39PM -0800, William Tu wrote:
>> On Wed, Feb 14, 2018 at 3:03 PM, Ben Pfaff wrote:
>> > On Wed, Feb 14, 2018 at 10:56:08AM -0800, William Tu wrote:
>> >> Usually ofproto/trace is used
recursion is too deep or too many resubmit, by
invoking the translation again, and log the ofproto trace as warnings.
Since the log will be huge, rate limit to one per minute.
VMWare-BZ: #2054659
Signed-off-by: William Tu
---
ofproto/ofproto-dpif-trace.c | 7 +--
ofproto/ofproto-dpif-trace.h
When hitting max translation depth of 64, printing the full
ofproto trace is huge and consumes too much log. The patch
adds a short trace log, which prints the top 3 table id and
its count of the 64 backward resubmits during the translation.
VMWare-BZ: #2054659
Signed-off-by: William Tu
The patch adds additional 'struct netdev *' to the
native tunnel's push_header() interface. This is used
for later GRE sequence number support.
Signed-off-by: William Tu
---
lib/netdev-native-tnl.c | 6 --
lib/netdev-native-tnl.h | 6 --
lib/netdev-provider.h | 3 ++
The patch adds support for gre sequence number.
Default is disable. When enable with 'options:seq=true',
the outgoing gre packet will have its sequence number
incremented by one.
Signed-off-by: William Tu
---
lib/netdev-native-tnl.c | 18 +-
lib/netdev-vport.c
On Mon, Mar 5, 2018 at 5:06 PM, Ben Pfaff wrote:
> On Wed, Feb 28, 2018 at 04:32:28PM -0800, William Tu wrote:
>> When hitting max translation depth of 64, printing the full
>> ofproto trace is huge and consumes too much log. The patch
>> adds a short trace log, which prin
nd of the
> trace. This created a race and occasional test failures.
>
> CC: William Tu
> Fixes: d1ea2cc3de99 ("xlate: auto ofproto trace when recursion too deep")
> Signed-off-by: Ben Pfaff
> ---
Thanks for the fix!
Acked-by: William Tu
> I noticed this only a
Looks good to me, thanks for the fix.
Acked-by: William Tu
On Sun, Mar 26, 2017 at 8:16 PM, Zhenyu Gao wrote:
> Currently, the mirror code doesn't check new value of snaplen when try
> to reconfigure snaplen.
> This patch fix this issue and add testings to reconfigure snaplen.
ich will invoke several kernel elements who has registered on the
netdevice notifier chain. One of the notifier, the inetdev_event rejects
this devname and register_netdevice fails. The patch prohibits creating
"default" bridge name.
VMWare-BZ: #1842388
Signed-off-by: William Tu
---
vsw
On Thu, Apr 27, 2017 at 9:57 AM, Ben Pfaff wrote:
> On Thu, Apr 27, 2017 at 04:02:10AM -0700, William Tu wrote:
>> Before the patch, when users create bridge named "default", although
>> ovs-vsctl fails but vswitchd in the background will keep retrying it,
>> causin
On Thu, Apr 27, 2017 at 11:17 AM, Ben Pfaff wrote:
> On Thu, Apr 27, 2017 at 10:17:20AM -0700, William Tu wrote:
>> On Thu, Apr 27, 2017 at 9:57 AM, Ben Pfaff wrote:
>> > On Thu, Apr 27, 2017 at 04:02:10AM -0700, William Tu wrote:
>> >> Before the patch, when user
> OK, if I understand properly here, the problem is that asking the Linux
> kernel datapath to add a bridge named "default" does two things. First,
> it fails. Second, it triggers a notifier that causes OVS to try again.
> The second part is what makes this different from other failures and
> wha
Footnote reference 5, 8, and 9 are not referenced in the windws.rst content,
causing the following error:
Warning, treated as error:
/root/ovs/Documentation/topics/windows.rst:506:Footnote [5] is not referenced.
Signed-off-by: William Tu
---
Documentation/topics/windows.rst | 6 +++---
1 file
who
has registered on the netdevice notifier chain. And due to creation failed,
OVS wakes up and re-recreate the device, which ends up as a high CPU loop.
VMWare-BZ: #1842388
Signed-off-by: William Tu
Signed-off-by: Ben Pfaff
Acked-by: Greg Rose
---
v1->v2: move to Linux speci
On Thu, May 4, 2017 at 4:39 AM, Zoltán Balogh
wrote:
>> I think that what's happening is that when build_tunnel_send()
>> serializes the ODP action for push_tunnel, it doesn't update the
>> 'flow' to reflect the new encapsulated state of the packet. Then, when
>> calling apply_nested_clone_actions
but flow stats are not correct on the
> underlay bridge.
>
> Could you confirm this, please?
>
> Best regards,
> Zoltan
>
>> -Original Message-
>> From: Zoltán Balogh
>> Sent: Sunday, May 07, 2017 9:16 PM
>> To: 'Joe Stringer' ; William Tu
&g
Thanks. I will re-submit this test.
William
On Mon, May 8, 2017 at 3:56 PM, Joe Stringer wrote:
> On 8 May 2017 at 11:35, Greg Rose wrote:
>> On Mon, 2017-05-08 at 11:15 -0700, Joe Stringer wrote:
>>> From: William Tu
>>>
>>> This test highlights a bug th
the intention to apply GRE tunnel headers and
send the packet through the underlay bridge. The underlay bridge should
observe GRE traffic.
Signed-off-by: William Tu
Signed-off-by: Joe Stringer
Acked-by: Greg Rose
---
tests/tunnel-push-pop.at | 69
[snip]
> -dnl Check ARP Snoop
> +dnl Use arp reply to achieve tunnel next hop mac binding
> AT_CHECK([ovs-appctl netdev-dummy/receive br0
> 'recirc_id(0),in_port(100),eth(src=f8:bc:12:44:34:b6,dst=ff:ff:ff:ff:ff:ff),eth_type(0x0806),arp(sip=1.1.2.92,ti
>
> AT_CHECK([ovs-appctl tnl/neigh/show |
the intention to apply GRE tunnel headers and
send the packet through the underlay bridge. The underlay bridge should
observe GRE traffic.
Signed-off-by: William Tu
Signed-off-by: Joe Stringer
Acked-by: Greg Rose
---
tests/tunnel-push-pop.at | 55
Hi Joe and Greg,
Maybe it's better I put this revert tunneling patch (1/2) and its
tunnel-tests (2/2) in one patch, so the "make check" can pass?
Regards,
William
On Mon, May 8, 2017 at 11:34 AM, Greg Rose wrote:
> On Mon, 2017-05-08 at 11:15 -0700, Joe Stringer wrote:
>> This reverts commit f1
> It may be cleaner if we add a new trunc action for the datapath, say
> trunc2 that applies
> to all outputs within the clone.
>
> So the translation will look like: clone(trunc2, native tunnel
> translation). Would this
> approach work?
>
Or how about we apply actual packet truncation when clon
On Wed, May 10, 2017 at 3:07 PM, Darrell Ball wrote:
> fyi:
>
> I submitted an updated patch here
> https://patchwork.ozlabs.org/patch/760876/
>
> I removed the ack since there were significant changes from the
> original patch.
>
>
Hi Darrell,
Thanks for the tunnel v3 test patch. Looks good to
On Wed, May 10, 2017 at 11:04 AM, Darrell Ball wrote:
> What are the use case(s) of truncate “outside” of sampling/mirroring ?
> The use of truncation in the context of sampling/mirroring is well known.
>
I don't know any other use cases outside sampling/mirroring.
Truncate the current packet, se
[snip]
>>> Picking up the topic of trunc on patch port.
>>>
>>> Instead of banning trunc output to a patch port, any down side of
>>> translating that
>>> to trunc, clone()? After all, native tunneling
>>> looks a lot like patch port conceptually.
>>
>> How does clone() interact with trunc() in the
On Tue, Feb 7, 2017 at 6:25 AM, Big Strong wrote:
> hello, sir
>
> I noticed that you commit a patch to add truncate action to ovs at
> https://github.com/openvswitch/ovs/commit/aaca4fe0ce9e90a41b3f4db84be7d05823c733e4.
> It is a great job. Would you be kind to tell me what is the granularity of
>
: William Tu
---
lib/ovs-router.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/ovs-router.c b/lib/ovs-router.c
index d98de20..53fb834 100644
--- a/lib/ovs-router.c
+++ b/lib/ovs-router.c
@@ -280,6 +280,7 @@ rt_entry_delete(uint32_t mark, uint8_t priority,
res = __rt_entry_delete(cr
Testcase 1057 ofproto-dpif - fragment handling - upcall reports
the following leak:
xrealloc (util.c:123)
vconn_dump_flows (vconn.c:1030)
read_flows_from_switch (ovs-ofctl.c:3360)
ofctl_replace_flows (ovs-ofctl.c:3433)
ovs_cmdl_run_command__ (command-line.c:115)
Signed-off-by: William
yes, thanks.
I will introduce cls_rule_destroy() and free the minimatch inside.
--William
On Tue, Feb 7, 2017 at 11:33 PM, Andy Zhou wrote:
> On Tue, Feb 7, 2017 at 10:41 PM, William Tu wrote:
>> Valgrind testcase 772: appctl - route/lookup6 reports the
>> following
Hi,
It seems that all the expr_symtab_xxx function has a return and needs
to be freed. I'm really not familiar with these code, can someone give
some suggestion? Thanks.
testcase:
2315: ovn-controller.at:188 ovn-controller - change Encap properties
==6859== 79 (72 direct, 7 indirect) bytes in 1
yes, thanks. I will submit v2.
On Tue, Feb 7, 2017 at 11:25 PM, Andy Zhou wrote:
> On Tue, Feb 7, 2017 at 10:41 PM, William Tu wrote:
>> Testcase 1057 ofproto-dpif - fragment handling - upcall reports
>> the following leak:
>> xrealloc (util.c:123)
>> vco
: William Tu
---
lib/ovs-router.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ovs-router.c b/lib/ovs-router.c
index d98de20..0c5430a 100644
--- a/lib/ovs-router.c
+++ b/lib/ovs-router.c
@@ -280,6 +280,8 @@ rt_entry_delete(uint32_t mark, uint8_t priority,
res = __rt_entry_delete(cr
Testcase 1057 ofproto-dpif - fragment handling - upcall reports
the following leak:
xrealloc (util.c:123)
vconn_dump_flows (vconn.c:1030)
read_flows_from_switch (ovs-ofctl.c:3360)
ofctl_replace_flows (ovs-ofctl.c:3433)
ovs_cmdl_run_command__ (command-line.c:115)
Signed-off-by: William
thanks! I tested it and found no problem.
On Wed, Feb 8, 2017 at 8:40 AM, Ben Pfaff wrote:
> This fixes a memory leak, although it was not a significant leak because
> the symbol table is in use until shortly before ovn-controller exits.
>
> Reported-by: William Tu
> Signed-of
On Thu, Feb 8, 2018 at 10:42 AM, Eric Garver wrote:
> On Thu, Feb 08, 2018 at 04:40:38PM +0100, Eelco Chaudron wrote:
>> While OVS userspace datapath (OVS-DPDK) supports GREv6, it does not
>> inter-operate with a native Linux ip6gretap tunnel. This is because
>> the Linux driver uses IPv6 optional
Add new tunnel-args for creating ipv6 tunnel through iproute2.
Signed-off-by: William Tu
---
tests/system-common-macros.at | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index f7d4adb947a0..d2a9b59e9684
The series adds support for userspace erspan implementation.
Currently it supports both ipv4 and ipv6 erspan v1/v2.
The kernel support is disabled in this series and will
add it later in separate patch series.
Tested-at: https://travis-ci.org/williamtu/ovs-travis/jobs/351420224
William Tu (5
The ipv6 header len might have extension header, but current
code simply returns fixed ipv6 header length 40-byte.
Signed-off-by: William Tu
---
lib/netdev-native-tnl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
index
The patch adds additional 'struct netdev *' to the
native tunnel's push_header() interface. This is used
for later GRE sequence number support.
Signed-off-by: William Tu
---
lib/netdev-native-tnl.c | 6 --
lib/netdev-native-tnl.h | 6 --
lib/netdev-provider.h | 3 ++
The patch adds support for gre sequence number.
Default is disable. When enable with 'options:seq=true',
the outgoing gre packet will have its sequence number
incremented by one.
Signed-off-by: William Tu
---
lib/netdev-native-tnl.c | 18 +-
lib/netdev-vport.c
ovs-fields for more details.
Signed-off-by: William Tu
---
datapath/linux/compat/include/linux/openvswitch.h | 2 +
include/openvswitch/flow.h| 4 +-
include/openvswitch/match.h | 12 ++
include/openvswitch/meta-flow.h | 56 ++
When users set queue id larger than the 61440 limit,
ex: set_queue: 65500, print the value in wanring message.
VMWare-BZ: #207
Signed-off-by: William Tu
---
lib/dpif-netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index acf1a6debcf7
On Wed, Mar 28, 2018 at 9:52 AM, Eelco Chaudron wrote:
> On 03/09/2018 03:59 PM, William Tu wrote:
>>
>> On Thu, Feb 8, 2018 at 10:42 AM, Eric Garver wrote:
>>>
>>> On Thu, Feb 08, 2018 at 04:40:38PM +0100, Eelco Chaudron wrote:
>>>>
>>>&g
On Wed, Apr 4, 2018 at 5:44 PM, Ben Pfaff wrote:
> On Fri, Mar 09, 2018 at 05:35:45PM -0800, William Tu wrote:
>> When users set queue id larger than the 61440 limit,
>> ex: set_queue: 65500, print the value in wanring message.
>>
>> VMWare-BZ: #2071111
&
, when there is a rule forwarding
the geneve packet to vxlan/erspan tunnel port. A userspace test case
using geneve and gre also demonstrates the issue.
Reported-by: Xiaoyan Jin
Signed-off-by: William Tu
Cc: Greg Rose
---
ofproto/tunnel.c | 6 ++
tests/tunnel.at | 18 ++
On Thu, May 10, 2018 at 11:51 PM, William Tu wrote:
> When there is a flow rule which forwards a packet from geneve
> port to another tunnel port, ex: gre, the tun_metadata carried
> from the geneve port needs to be clean up. Otherwise, the output
> tunnel port will incorrectly
tunnel port. A userspace test case
using geneve and gre also demonstrates the issue.
The patch makes the tun_key_to_attr aware of the tunnel type. So only
the relevant output tunnel's options are set.
Reported-by: Xiaoyan Jin
Signed-off-by: William Tu
Cc: Greg Rose
---
v1->v2:
- Remove u
On Mon, May 14, 2018 at 4:22 PM, Ben Pfaff wrote:
> On Mon, May 14, 2018 at 11:46:47AM -0700, William Tu wrote:
>> When there is a flow rule which forwards a packet from geneve
>> port to another tunnel port, ex: gre, the tun_metadata carried
>> from the geneve port might aff
On Fri, May 18, 2018 at 8:41 AM, Gregory Rose wrote:
> On 5/17/2018 6:57 PM, Greg Rose wrote:
>>
>> From: William Tu
>>
>> This patch adds support for erspan and ip6erspan.
>>
>> Signed-off-by: William Tu
>> ---
>> lib/odp-util.c | 3 +
On Fri, May 18, 2018 at 9:59 AM, William Tu wrote:
> On Fri, May 18, 2018 at 8:41 AM, Gregory Rose wrote:
>> On 5/17/2018 6:57 PM, Greg Rose wrote:
>>>
>>> From: William Tu
>>>
>>> This patch adds support for erspan and ip6erspan.
>>>
>&
On Fri, May 18, 2018 at 10:52 AM, William Tu wrote:
> On Fri, May 18, 2018 at 9:59 AM, William Tu wrote:
>> On Fri, May 18, 2018 at 8:41 AM, Gregory Rose wrote:
>>> On 5/17/2018 6:57 PM, Greg Rose wrote:
>>>>
>>>> From: William Tu
>>>>
On Fri, May 18, 2018 at 5:49 PM, Greg Rose wrote:
> From: William Tu
>
> Upstream commit:
> commit e3d0328c76dde0b957f62f8c407b79f1d8fe3ef8
> Author: William Tu
> Date: Tue Aug 22 17:04:05 2017 -0700
>
> gre: fix goto statement typo
>
>
101 - 200 of 1254 matches
Mail list logo
