Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to include/openvswitch

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 01:35:11PM +, Alin Serdean wrote: > > > > -Original Message- > > From: Xiao Liang [mailto:shaw.l...@gmail.com] > > Sent: Thursday, November 2, 2017 4:32 AM > > To: Alin Serdean > > Cc: Ben Pfaff ;

Re: [ovs-dev] [PATCH 1/6] build-windows: Suppress output from MSBuild

2017-11-02 Thread Alin Balutoiu
Acked-by: Alin Balutoiu > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.org > Cc: Alin Gabriel

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Fix ovs_geneve probing after restart

2017-11-02 Thread William Tu
On Wed, Nov 1, 2017 at 8:29 AM, Eric Garver wrote: > On Mon, Oct 30, 2017 at 10:36:29AM -0700, William Tu wrote: >> Thanks for the review. >> >> Guru and I had some offline discussion. We have concern about possible >> packet lost when unconditionally remove the interface and bring

[ovs-dev] [PATCH v3 4/4] ovn: Add IPv6 capability to ovn-nbctl lb-add

2017-11-02 Thread Mark Michelson
ovn-nbctl will now accept IPv6 addresses for load balancer VIPs and desetination addresses. In addition, the ovn-nbctl lb-list, lr-lb-list, and ls-lb-list have been modified to be able to fit IPv6 addresses on screen. Signed-off-by: Mark Michelson ---

Re: [ovs-dev] [PATCH 3/6] installer-windows: Resolve WIX solution build type

2017-11-02 Thread Alin Balutoiu
Acked-by: Alin Balutoiu > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.org > Cc: Alin Gabriel

[ovs-dev] [PATCH v3 2/4] ovn: Allow ct_lb actions to take IPv6 address arguments.

2017-11-02 Thread Mark Michelson
The ct_lb action previously assumed that any address arguments were IPv4. This patch expands the parsing, formatting, and encoding of ct_lb to be amenable to IPv6 addresses as well. Signed-off-by: Mark Michelson --- include/ovn/actions.h | 6 +++- ovn/lib/actions.c |

[ovs-dev] [PATCH v3 3/4] ovn: Allow northd to install IPv6 ct_lb logical flows.

2017-11-02 Thread Mark Michelson
For this commit, ovn-northd will now accept both IPv4 and IPv6 addresses in the northbound database for a load balancer VIP or destination addresses. For IPv4, the behavior remains the same. For IPv6, the following logical flows will be added to the southbound database: * An ND_NA response for

Re: [ovs-dev] [PATCH 5/6] installer-windows: Modify installer so it can be compiled on x64

2017-11-02 Thread Alin Balutoiu
Minor comment inline. Acked-by: Alin Balutoiu > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.org

Re: [ovs-dev] [PATCH 4/6] installer-windows: Call WIX binaries outside of MSBuild on x64

2017-11-02 Thread Alin Balutoiu
Acked-by: Alin Balutoiu > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.org > Cc: Alin Gabriel

Re: [ovs-dev] [PATCH] datapath: Remove redundant check for IFF_NO_QUEUE

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 08:51:59AM +0800, Kaige Fu wrote: > On 2017/11/2 4:19, Ben Pfaff wrote: > > On Wed, Nov 01, 2017 at 08:43:20AM -0700, Greg Rose wrote: > >> On 10/30/2017 06:13 PM, fukaige wrote: > >>> From: Kaige Fu > >>> > >>> IFF_NO_QUEUE is checked twice. This cause

Re: [ovs-dev] [PATCH 2/2] OVN: Add support for periodic router advertisements.

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 02:50:13PM +, Mark Michelson wrote: > On Wed, Nov 1, 2017 at 4:38 PM Ben Pfaff wrote: > > > On Wed, Oct 18, 2017 at 11:53:49AM -0500, Mark Michelson wrote: > > > This change adds three new options to the Northbound > > > Logical_Router_Port's

[ovs-dev] [PATCH v3 1/4] Add general-purpose IP/port parsing function.

2017-11-02 Thread Mark Michelson
OVS has functions for parsing IPv4 addresses, parsing IPv4 addresses with a port, and parsing IPv6 addresses. What is lacking though is a function that can take an IPv4 or IPv6 address, with or without a port. This commit adds ipv46_parse(), which breaks the given input string into its component

Re: [ovs-dev] [PATCH 6/6] installer-windows: Add x64 installer build via command line

2017-11-02 Thread Alin Balutoiu
Acked-by: Alin Balutoiu > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Tuesday, October 31, 2017 6:26 PM > To: d...@openvswitch.org > Cc: Alin Gabriel

Re: [ovs-dev] [PATCHv2] dpif-netlink-rtnl: Fix ovs_geneve probing after restart.

2017-11-02 Thread Eric Garver
On Wed, Nov 01, 2017 at 12:35:40PM -0700, William Tu wrote: > When using the out-of-tree (openvswitch compat) geneve module, > the first time oot tunnel probing returns true (correct). > Without unloading the geneve module, if the userspace ovs-vswitchd > restarts, because the 'geneve_sys_6081'

Re: [ovs-dev] [PATCH] ovn-ctl: Provide the option to detach the OVN db servers or not when starting

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 04:55:14PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Presently if the user wants to start OVN db servers as separate containers, > 'ovn-ctl' > script is not useful as '--detach' option is passed when ovsdb-servers are > started. >

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

2017-11-02 Thread Greg Rose
On 11/02/2017 11:07 AM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote: > On certain Ubuntu systems running the 4.4 based kernel depmod > may not correctly search for module dependencies when newer > openvswitch kernel modules have been installed in the extra >

Re: [ovs-dev] [PATCH v3 0/4] Add support for IPv6 load balancers

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 11:13:55AM -0500, Mark Michelson wrote: > This patchset adds the necessary items in order to support IPv6 load > balancers in OVN. No syntax has changed in ovn-nbctl or in the > northbound database to support this. Appropriate tests have been > added to the testsuite as

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix null pointer dereference on exit.

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 06:58:39PM +0100, Jakub Sitnicki wrote: > On Thu, 2 Nov 2017 18:53:02 +0100 > Jakub Sitnicki wrote: > > > On Fri, 27 Oct 2017 08:40:23 -0700 > > Ben Pfaff wrote: > > > > > When revalidation occurs at the same time that a bridge is being

Re: [ovs-dev] [PATCH] Documentation: Add the Open vSwitch project charter.

2017-11-02 Thread Ben Pfaff
I'd appreciate it if someone would review this change. It is documentation only. On Tue, Oct 24, 2017 at 09:33:07AM -0700, Ben Pfaff wrote: > It always seems odd that this isn't in the repo, so this adds it, with > internal links properly directed. > > Signed-off-by: Ben Pfaff >

Re: [ovs-dev] [PATCH] ovn-northd.8: Fix wrong description

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 10:46:58AM +0800, wei wrote: > --- > ovn/northd/ovn-northd.8.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > index e9799e18a..37284301b 100644 > --- a/ovn/northd/ovn-northd.8.xml >

Re: [ovs-dev] [PATCH] netdev-linux: Fix wrong ceil rate when max-rate less than 8bit.

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 11:07:02AM +0800, fukaige wrote: > From: Kaige Fu > > When max-rate is less than 8bit, the hc->max_rate will be set > as htb->max_rate mistakenly instead of mtu of netdev. > > Fixes: 13c1637 ("smap: New function smap_get_ullong().") > >

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix null pointer dereference on exit.

2017-11-02 Thread Jakub Sitnicki
On Thu, 2 Nov 2017 18:53:02 +0100 Jakub Sitnicki wrote: > On Fri, 27 Oct 2017 08:40:23 -0700 > Ben Pfaff wrote: > > > When revalidation occurs at the same time that a bridge is being removed > > or ovs-vswitchd is exiting, xlate_lookup_ofproto() races with

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix null pointer dereference on exit.

2017-11-02 Thread Jakub Sitnicki
On Fri, 27 Oct 2017 08:40:23 -0700 Ben Pfaff wrote: > When revalidation occurs at the same time that a bridge is being removed > or ovs-vswitchd is exiting, xlate_lookup_ofproto() races with deletion of > the ofproto. This caused a null pointer dereference if revalidation lost >

Re: [ovs-dev] [PATCH] ovn-ctl: Provide the option to detach the OVN db servers or not when starting

2017-11-02 Thread Numan Siddique
On Thu, Nov 2, 2017 at 11:15 PM, Ben Pfaff wrote: > On Thu, Nov 02, 2017 at 04:55:14PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Presently if the user wants to start OVN db servers as separate > containers, 'ovn-ctl' > > script is not

Re: [ovs-dev] [PATCH v2 2/4] ovn: Allow ct_lb actions to take IPv6 address arguments.

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 02:57:00PM +, Mark Michelson wrote: > On Wed, Nov 1, 2017 at 4:53 PM Ben Pfaff wrote: > > > On Tue, Oct 31, 2017 at 09:27:02AM -0500, Mark Michelson wrote: > > > The ct_lb action previously assumed that any address arguments were > > > IPv4. This patch

Re: [ovs-dev] [PATCH] ovn-ctl: Provide the option to detach the OVN db servers or not when starting

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 11:41:17PM +0530, Numan Siddique wrote: > On Thu, Nov 2, 2017 at 11:15 PM, Ben Pfaff wrote: > > > On Thu, Nov 02, 2017 at 04:55:14PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > Presently if the user wants to

[ovs-dev] [PATCHv3] dpif-netlink-rtnl: Fix ovs_geneve probing after restart.

2017-11-02 Thread William Tu
When using the out-of-tree (openvswitch compat) geneve module, the first time oot tunnel probing returns true (correct). Without unloading the geneve module, if the userspace ovs-vswitchd restarts, because the 'geneve_sys_6081' still exists, the probing incorrectly returns false and loads the

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote: > On certain Ubuntu systems running the 4.4 based kernel depmod > may not correctly search for module dependencies when newer > openvswitch kernel modules have been installed in the extra > directory at /lib/modules/$(uname -r)/extra. A

Re: [ovs-dev] [PATCH v2] ofproto/trace: Fix memory leak in oftrace_push_ct_state()

2017-11-02 Thread Ben Pfaff
On Wed, Nov 01, 2017 at 04:59:52PM -0700, Yi-Hung Wei wrote: > Free the allocated memory in the pop function. > > Fixes: 0f2f05bbcf743 ("ofproto/trace: Add --ct-next option to ofproto/trace") > Signed-off-by: Yi-Hung Wei Thank you for the fix! I applied this to master and

Re: [ovs-dev] [PATCH] packets: Fix C++ compilation issues when include packets.h

2017-11-02 Thread Ben Pfaff
On Wed, Nov 01, 2017 at 02:40:27PM -0700, Yi-Hung Wei wrote: > This patch fixes three C++ compilation errors when it includes > "lib/packets.h". > > 1) Fix in "include/openvswitch/util.h" is to avoid duplicated > named_member__ in struct pkt_metadata. > > 2) Fix in "lib/packets.h" is because

[ovs-dev] [PATCH] netdev-dummy: Remove wrong netdev_close

2017-11-02 Thread Yifeng Sun
netdev_dummy_ip6addr() calls netdev_close() twice though it increases netdev's reference only once from netdev_from_name(). As a result, Valgrind test 788 (tunnel_push_pop - action) reports the error below: ==20465== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) Invalid read of

[ovs-dev] [PATCH net-next 3/3] rtnetlink: use netnsid to query interface

2017-11-02 Thread Flavio Leitner
From: Jiri Benc Currently, when an application gets netnsid from the kernel (for example as the result of RTM_GETLINK call on one end of the veth pair), it's not much useful. There's no reliable way to get to the netns fd from the netnsid, nor does any kernel API accept

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix null pointer dereference on exit.

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 06:53:02PM +0100, Jakub Sitnicki wrote: > On Fri, 27 Oct 2017 08:40:23 -0700 > Ben Pfaff wrote: > > > When revalidation occurs at the same time that a bridge is being removed > > or ovs-vswitchd is exiting, xlate_lookup_ofproto() races with deletion of > >

Re: [ovs-dev] [PATCH, RFC] tests: Add a default timeout for control utilities

2017-11-02 Thread Ben Pfaff
On Wed, Nov 01, 2017 at 09:53:48PM +, Alin Serdean wrote: > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > boun...@openvswitch.org] On Behalf Of Ben Pfaff > > Sent: Wednesday, November 1, 2017 12:32 AM > > To: Alin Gabriel Serdean

[ovs-dev] [PATCH net-next 2/3] openvswitch: reliable interface indentification in port dumps

2017-11-02 Thread Flavio Leitner
From: Jiri Benc This patch allows reliable identification of netdevice interfaces connected to openvswitch bridges. In particular, user space queries the netdev interfaces belonging to the ports for statistics, up/down state, etc. Datapath dump needs to provide enough

[ovs-dev] [PATCH net-next 1/3] net: export peernet2id_alloc

2017-11-02 Thread Flavio Leitner
From: Jiri Benc It will be used by openvswitch. Signed-off-by: Jiri Benc --- net/core/net_namespace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 6cfdc7c84c48..b797832565d3 100644 ---

[ovs-dev] [PATCH net-next 0/3] Allow openvswitch to query ports in another netns.

2017-11-02 Thread Flavio Leitner
Today Open vSwitch users are moving internal ports to other namespaces and although packets are flowing OK, the userspace daemon can't find out basic information like if the port is UP or DOWN, for instance. This patchset extends openvswitch API to retrieve the current netnsid of a port. It will

Re: [ovs-dev] [PATCH v10 0/4] Add Router Solicitation responder support and generate Neighbor Solicitation request for unknown

2017-11-02 Thread Ben Pfaff
Thank you for the patches! They look good to me, so I will apply them to master soon. I folded in a few minor changes to patch 2, which I'll mention in a reply to that patch. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCHv3] dpif-netlink-rtnl: Fix ovs_geneve probing after restart.

2017-11-02 Thread Eric Garver
On Thu, Nov 02, 2017 at 12:01:17PM -0700, William Tu wrote: > When using the out-of-tree (openvswitch compat) geneve module, > the first time oot tunnel probing returns true (correct). > Without unloading the geneve module, if the userspace ovs-vswitchd > restarts, because the 'geneve_sys_6081'

Re: [ovs-dev] [PATCHv3 1/3] ovsdb-idl: Fix memory leak

2017-11-02 Thread Yifeng Sun
Thanks for all your advice. I will pay close attention next time. On Thu, Nov 2, 2017 at 2:14 PM, Ben Pfaff wrote: > On Tue, Oct 31, 2017 at 10:52:08AM -0700, Yifeng Sun wrote: > > Valgrind testcase 2339 (ovn -- ipam connectivity) reports the leak below: > > 45 (32 direct, 13

Re: [ovs-dev] [PATCHv3 3/3] ovsdb-server.c: Fix memory leak

2017-11-02 Thread Ben Pfaff
On Tue, Oct 31, 2017 at 10:52:10AM -0700, Yifeng Sun wrote: > Valgrind testcase 2349 (ovn -- DSCP marking check) reports the leak below: > 21 bytes in 21 blocks are definitely lost in loss record 24 of 362 > at 0x4C2DB8F: malloc (in > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) >

[ovs-dev] [PATCH 1/8] netlink: provide network namespace id from a msg.

2017-11-02 Thread Flavio Leitner
The netlink notification's ancillary data contains the network namespace id (netnsid) needed to identify the device correctly. (ifindex and netnsid). Signed-off-by: Flavio Leitner --- configure.ac | 3 +- lib/automake.mk| 1 + lib/dpif-netlink.c | 6

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

2017-11-02 Thread Greg Rose
On 11/02/2017 11:12 AM, Greg Rose wrote: On 11/02/2017 11:07 AM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote: > On certain Ubuntu systems running the 4.4 based kernel depmod > may not correctly search for module dependencies when newer > openvswitch kernel modules

Re: [ovs-dev] [PATCH v10 0/4] Add Router Solicitation responder support and generate Neighbor Solicitation request for unknown

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 01:37:40PM -0700, Ben Pfaff wrote: > Thank you for the patches! They look good to me, so I will apply them > to master soon. I folded in a few minor changes to patch 2, which I'll > mention in a reply to that patch. Oh, one more thing: I'd appreciate it if you would

Re: [ovs-dev] [PATCH v10 2/4] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 06:19:24AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds a new OVN action 'put_nd_ra_opts' to support native > IPv6 Router Advertisement in OVN. This action can be used to respond > to the IPv6 Router Solicitation

Re: [ovs-dev] [PATCHv3 1/3] ovsdb-idl: Fix memory leak

2017-11-02 Thread Ben Pfaff
On Tue, Oct 31, 2017 at 10:52:08AM -0700, Yifeng Sun wrote: > Valgrind testcase 2339 (ovn -- ipam connectivity) reports the leak below: > 45 (32 direct, 13 indirect) bytes in 1 blocks are definitely lost in loss > record 65 of 83 > at 0x4C2DB8F: malloc (in >

[ovs-dev] [PATCH 2/8] netdev-linux: initialize netns as invalid.

2017-11-02 Thread Flavio Leitner
A port might be already in another netns, so initialize it as invalid to force a state update. Signed-off-by: Flavio Leitner --- lib/netdev-linux.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 0d03ca876..3c80690f4 100644

[ovs-dev] [PATCH 4/8] netdev: update device info only if netns matches.

2017-11-02 Thread Flavio Leitner
A network device in another network namespace could have the same name, so once the socket starts listening to other network namespaces, it is necessary to confirm the netns id. Signed-off-by: Flavio Leitner --- lib/netdev-linux.c | 50

[ovs-dev] [PATCH 6/8] netlink linux: enable listening to all nsids

2017-11-02 Thread Flavio Leitner
Internal ports may be moved to another network namespace and when that happens, the vswitch stops receiving netlink notifications. This patch enables the vswitch to listen to all network namespaces that have a nsid assigned into the network namespace where the socket has been opened. It requires

[ovs-dev] [PATCH 5/8] netdev-linux: use netlink to update netdev.

2017-11-02 Thread Flavio Leitner
The ioctl interface doesn't support network namespaces, so try updating the netdev using netlink message instead. To provide backwards compatibility, fall back to the previous method if netlink isn't supported or fails. Signed-off-by: Flavio Leitner --- lib/netdev-linux.c |

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

2017-11-02 Thread Greg Rose
On 11/02/2017 01:09 PM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 12:55:13PM -0700, Greg Rose wrote: On 11/02/2017 11:12 AM, Greg Rose wrote: On 11/02/2017 11:07 AM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote: On certain Ubuntu systems running the 4.4 based

[ovs-dev] [PATCH v2 0/2] OVN: Add support for periodic router advertisements

2017-11-02 Thread Mark Michelson
This patch series adds support for sending periodic router advertisements from OVN. The patch is divided into two commits * Commit 1 introduces a method to ensure that multicast packets are sent only to targets on the local hypervisor * Commit 2 adds the ability to actually send the periodic

[ovs-dev] [PATCH 3/8] vport: retrieve the netnsid if available.

2017-11-02 Thread Flavio Leitner
Recent kernels provide the network namespace ID of a port, so use that to discover where the port currently is. Signed-off-by: Flavio Leitner --- datapath/linux/compat/include/linux/openvswitch.h | 2 ++ lib/dpif-netlink.c| 6 ++

[ovs-dev] Importancia a Nivel Mundial

2017-11-02 Thread Desarrollo Sustentable
Conozca los ODS y establezca alianzas con las empresas del futuro Los Objetivos del Desarrollo Sustentable y su importancia en los negocios 16 de noviembre - Mtra. Guillermina Barrera Zaragoza9am-6pm En septiembre de 2015, se llevó a cabo la Cumbre para el Desarrollo Sostenible, en la cual los

[ovs-dev] Investment Proposal.

2017-11-02 Thread mickbrewis
Good Morning, I am Mick Brewis, one of the Directors of The Scottish Investment Trust PLC, One of UK`s largest oldest independent self managed funds management company with over £45billion Capital Investment Funds. Nevertheless, as Scottish Investment Funds Manager, I handle all our

Re: [ovs-dev] [PATCH] netdev-dummy: Remove wrong netdev_close

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 06:42:22AM -0700, Yifeng Sun wrote: > netdev_dummy_ip6addr() calls netdev_close() twice though it increases > netdev's reference only once from netdev_from_name(). As a result, Valgrind > test 788 (tunnel_push_pop - action) reports the error below: Thanks a lot! I

Re: [ovs-dev] [PATCH] Documentation: Add the Open vSwitch project charter.

2017-11-02 Thread Mark Michelson
Looks good to me. On Thu, Nov 2, 2017 at 1:16 PM Ben Pfaff wrote: > I'd appreciate it if someone would review this change. It is > documentation only. > > On Tue, Oct 24, 2017 at 09:33:07AM -0700, Ben Pfaff wrote: > > It always seems odd that this isn't in the repo, so this adds

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

2017-11-02 Thread Guru Shetty
On 2 November 2017 at 12:55, Greg Rose wrote: > On 11/02/2017 11:12 AM, Greg Rose wrote: > >> On 11/02/2017 11:07 AM, Ben Pfaff wrote: >> >>> On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote: >>> > On certain Ubuntu systems running the 4.4 based kernel depmod >>> >

Re: [ovs-dev] [PATCHv3] dpif-netlink-rtnl: Fix ovs_geneve probing after restart.

2017-11-02 Thread Guru Shetty
On 2 November 2017 at 12:01, William Tu wrote: > When using the out-of-tree (openvswitch compat) geneve module, > the first time oot tunnel probing returns true (correct). > Without unloading the geneve module, if the userspace ovs-vswitchd > restarts, because the

[ovs-dev] [PATCH 0/8] Add minimum network namespace support.

2017-11-02 Thread Flavio Leitner
Today Open vSwitch doesn't know about network namespaces (netns), but users are moving internal ports to other namespaces. Although packets are still flowing, the daemon fails to find out basic port information, like if it is UP or DOWN, for instance. This patchset rely on a new kernel vport API

[ovs-dev] [PATCH 8/8] netdev-linux: fail ops not supporting remote netns.

2017-11-02 Thread Flavio Leitner
When the netdev is in another namespace and the operation doesn't support network namespaces, return the correct error. Signed-off-by: Flavio Leitner --- lib/netdev-linux.c | 134 +++-- 1 file changed, 120 insertions(+), 14

[ovs-dev] [PATCH 7/8] nlmon: added netns support.

2017-11-02 Thread Flavio Leitner
Signed-off-by: Flavio Leitner --- utilities/nlmon.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/utilities/nlmon.c b/utilities/nlmon.c index 08a117b58..609b152f9 100644 --- a/utilities/nlmon.c +++ b/utilities/nlmon.c @@ -41,6 +41,7 @@ main(int argc

Re: [ovs-dev] [PATCHv2] dpif-netlink-rtnl: Fix ovs_geneve probing after restart.

2017-11-02 Thread William Tu
On Thu, Nov 2, 2017 at 10:32 AM, Eric Garver wrote: > On Wed, Nov 01, 2017 at 12:35:40PM -0700, William Tu wrote: >> When using the out-of-tree (openvswitch compat) geneve module, >> the first time oot tunnel probing returns true (correct). >> Without unloading the geneve module, if

[ovs-dev] [PATCH v2 2/2] OVN: Add support for periodic router advertisements.

2017-11-02 Thread Mark Michelson
This change adds three new options to the Northbound Logical_Router_Port's ipv6_ra_configs option: * send_periodic: If set to "true", then OVN will send periodic router advertisements out of this router port. * max_interval: The maximum amount of time to wait between sending periodic router

[ovs-dev] [PATCH v2 1/2] OVN: Add multicast keep-local flag.

2017-11-02 Thread Mark Michelson
When this flag is set, then a multicast packet that would normally be delivered to ports on multiple hypervisors is only delivered to ports on the local hypervisor. The primary known use case for this is when multicast packets originate from ovn-controller. Multiple ovn-controllers will be

[ovs-dev] [Patch V2] Documentation: Document additional module dependency

2017-11-02 Thread Greg Rose
On certain Ubuntu systems running the 4.4 based kernel depmod may not correctly search for module dependencies when newer openvswitch kernel modules have been installed in the extra directory at /lib/modules/$(uname -r)/extra. A symptom of this are the following messages in system log that can be

Re: [ovs-dev] [PATCHv3 2/3] test-ovsdb: Fix memory leak

2017-11-02 Thread Ben Pfaff
On Tue, Oct 31, 2017 at 10:52:09AM -0700, Yifeng Sun wrote: > Valgrind testcase 1465 (integer atom enum from string) reports the leak below: > 16 bytes in 1 blocks are definitely lost in loss record 2 of 5 > at 0x4C2DB8F: malloc (in > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) >

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Transition ukey on dp_ops error.

2017-11-02 Thread Ben Pfaff
On Mon, Sep 18, 2017 at 02:56:35PM -0700, Greg Rose wrote: > On 09/06/2017 03:12 PM, Joe Stringer wrote: > >In most situations, we don't expect that a flow we've successfully > >dumped, which we intend to delete, cannot be deleted. However, to make > >this code more resilient to ensure that ukeys

[ovs-dev] Recursos Humanos Rumbo al 2018

2017-11-02 Thread Evite Riesgo de una Demanda
Buenas Tardes: Este mes de septiembre le invitamos a adquirir una de nuestras pólizas de Capacitación online en PREVENTA, los cuáles constan de 12 Temas que son utilizables durante 3 meses, las 24 hrs del día, las veces que usted así lo requiera. En Específico le ofrecemos el plan de Recursos

Re: [ovs-dev] [PATCH] ofp-util: Update OpenFlow 1.6 port support to track latest proposal.

2017-11-02 Thread Yi-Hung Wei
On Tue, Oct 24, 2017 at 3:17 PM, Ben Pfaff wrote: > This patch, from July, still applies and still needs a review. > > On Fri, Jul 14, 2017 at 12:51:43PM -0700, Ben Pfaff wrote: >> The latest updates to the OpenFlow 1.6 proposal removes the hw_addr_type >> fields from ofp_port and

[ovs-dev] actions in openflow rules

2017-11-02 Thread Haitham Ghalwash
Hi all I am a little bit confused when interpreting the action part for the following rule, I got the rule by initiating the "ovs-ofctl dump-flows" on my mininet openflow switch. cookie=0x2ba5, duration=528.939s, table=0, n_packets=176, n_bytes=33116, idle_age=0,

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

2017-11-02 Thread Greg Rose
On 11/02/2017 02:39 PM, Guru Shetty wrote: On 2 November 2017 at 12:55, Greg Rose > wrote: On 11/02/2017 11:12 AM, Greg Rose wrote: On 11/02/2017 11:07 AM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 10:46:48AM -0700,

Re: [ovs-dev] *** SPAM *** Re: [PATCH] Documentation: Add the Open vSwitch project charter.

2017-11-02 Thread Ben Pfaff
On Thu, Nov 02, 2017 at 09:25:56PM +, Mark Michelson wrote: > Looks good to me. > > On Thu, Nov 2, 2017 at 1:16 PM Ben Pfaff wrote: > > > I'd appreciate it if someone would review this change. It is > > documentation only. > > > > On Tue, Oct 24, 2017 at 09:33:07AM -0700, Ben

[ovs-dev] BUSINESS OPPORTUNITY

2017-11-02 Thread Peter Alexandra
Hello I am Mr. Peter Alexandra, representing the operation and corporate affairs in contract related matters of Exxon Mobil in London (http://www.exxonmobil.com). Exxon Mobil is one of the World Largest oil producing and Management Company with over 1.2 Trillion pounds Capital contract

[ovs-dev] [PATCH v4 1/2] netdev-dpdk: Helper function for vHost device setup

2017-11-02 Thread Ciara Loftus
dpdkvhostuser and dpdkvhostuserclient ports share a lot of the same setup & configuration code. Create a common function they can share in order to remove some duplication of code. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 113

[ovs-dev] [PATCH v4 0/2] vHost Dequeue Zero Copy

2017-11-02 Thread Ciara Loftus
This patch enables optional dequeue zero copy for vHost ports. This gives a performance increase for some use cases. I'm using the cover letter to report my results. vhost (vm1) -> vhost (vm2) Using testpmd to source (txonly) in vm1 and sink (rxonly) in vm2. 4C1Q 64B packets: 5.05Mpps -> 5.52Mpps

[ovs-dev] [PATCH v4 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-11-02 Thread Ciara Loftus
Enabled per port like so: ovs-vsctl set Interface dpdkvhostuserclient0 options:dq-zero-copy=true The feature is disabled by default and can only be enabled/disabled when a vHost port is down. When packets from a vHost device with zero copy enabled are destined for a 'dpdk' port, the number of tx

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-02 Thread Yang, Yi
On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > >> > > >> > OVS

Re: [ovs-dev] [Patch V2] Documentation: Document additional module dependency

2017-11-02 Thread Greg Rose
On 11/02/2017 02:02 PM, Greg Rose wrote: On certain Ubuntu systems running the 4.4 based kernel depmod may not correctly search for module dependencies when newer openvswitch kernel modules have been installed in the extra directory at /lib/modules/$(uname -r)/extra. A symptom of this are the

[ovs-dev] [PATCH v2] ovn-northd.8: Fix wrong description

2017-11-02 Thread wei
Signed-off-by: wei --- ovn/northd/ovn-northd.8.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml index e9799e18a..37284301b 100644 --- a/ovn/northd/ovn-northd.8.xml +++ b/ovn/northd/ovn-northd.8.xml

[ovs-dev] [PATCH] NEWS: Add recently added OVN IPv6 features

2017-11-02 Thread nusiddiq
From: Numan Siddique OVN now supports sending IPv6 RA packet in response to the RS packet and resolves the unknown next hop MACs by generating a NS packet. Mention this in the NEWS. Signed-off-by: Numan Siddique --- NEWS | 6 ++ 1 file changed, 6

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-02 Thread Yang, Yi
On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > >> > > >> > OVS

[ovs-dev] Your first payment of $7.000.00 From Money Gram.

2017-11-02 Thread Rose Amadi
Attn Pls. Your compensation payment sum of $4,700,000.00 usd has been released from Ministry Of Finance Benin Republic. We are hereby to let you know that the first payment of $7000 per day with the Reference: through Money Gram have been transferred to your Name for you to pick up but you have

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-02 Thread Pravin Shelar
On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi wrote: > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: >> > >> > OVS master and 2.8 branch has merged NSH userspace >> > patch series, this patch

[ovs-dev] [PATCH] ovn-ctl: Provide the option to detach the OVN db servers or not when starting

2017-11-02 Thread nusiddiq
From: Numan Siddique Presently if the user wants to start OVN db servers as separate containers, 'ovn-ctl' script is not useful as '--detach' option is passed when ovsdb-servers are started. If the container command is 'ovn-ctl start_nb_ovsdb', the container exits as

Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to include/openvswitch

2017-11-02 Thread Alin Serdean
> -Original Message- > From: Xiao Liang [mailto:shaw.l...@gmail.com] > Sent: Thursday, November 2, 2017 4:32 AM > To: Alin Serdean > Cc: Ben Pfaff ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to >

Re: [ovs-dev] [PATCH 2/2] OVN: Add support for periodic router advertisements.

2017-11-02 Thread Mark Michelson
On Wed, Nov 1, 2017 at 4:38 PM Ben Pfaff wrote: > On Wed, Oct 18, 2017 at 11:53:49AM -0500, Mark Michelson wrote: > > This change adds three new options to the Northbound > > Logical_Router_Port's ipv6_ra_configs option: > > > > * send_periodic: If set to "true", then OVN will send

Re: [ovs-dev] [PATCH v10 0/4] Add Router Solicitation responder support and generate Neighbor Solicitation request for unknown

2017-11-02 Thread Numan Siddique
On Fri, Nov 3, 2017 at 2:10 AM, Ben Pfaff wrote: > On Thu, Nov 02, 2017 at 01:37:40PM -0700, Ben Pfaff wrote: > > Thank you for the patches! They look good to me, so I will apply them > > to master soon. I folded in a few minor changes to patch 2, which I'll > > mention in a

Re: [ovs-dev] [PATCH 2/2] lib: Move lib/poll-loop.h to include/openvswitch

2017-11-02 Thread Xiao Liang
On Fri, Nov 3, 2017 at 1:12 AM, Ben Pfaff wrote: > On Thu, Nov 02, 2017 at 01:35:11PM +, Alin Serdean wrote: >> >> >> > -Original Message- >> > From: Xiao Liang [mailto:shaw.l...@gmail.com] >> > Sent: Thursday, November 2, 2017 4:32 AM >> > To: Alin Serdean

[ovs-dev] [PATCH v2] lib: Move lib/poll-loop.h to include/openvswitch

2017-11-02 Thread Xiao Liang
Poll-loop is the core to implement main loop. It should be available in libopenvswitch. Signed-off-by: Xiao Liang --- include/openvswitch/automake.mk | 1 + {lib => include/openvswitch}/poll-loop.h | 7 ++- lib/bfd.c | 2 +-