Re: [ovs-dev] [PATCH RFC 4/4] dpif-netdev: Don't uninit emc on reload.

2017-05-29 Thread Ferriter, Cian
> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Daniele Di Proietto > Sent: 10 March 2017 04:35 > To: Ilya Maximets > Cc: d...@openvswitch.org; Heetae Ahn > Subject:

Re: [ovs-dev] [PATCH 2/4] dpif-netdev: Incremental addition/deletion of PMD threads.

2017-05-29 Thread Ferriter, Cian
> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Daniele Di Proietto > Sent: 10 March 2017 04:13 > To: Ilya Maximets > Cc: d...@openvswitch.org; Heetae Ahn > Subject:

Re: [ovs-dev] [patch_v5 1/3] dpif-netdev: Fix per packet cycles statistics.

2017-09-01 Thread Ferriter, Cian
Hi, > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Darrell Ball > Sent: 21 August 2017 19:52 > To: dlu...@gmail.com; d...@openvswitch.org > Cc: Ilya Maximets > Subject: [ovs-dev] [patch_v5 1/3]

Re: [ovs-dev] [PATCH] dpif-netdev: Fix comments in function headers

2017-09-01 Thread Ferriter, Cian
Hi Antonio, > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of antonio.fische...@intel.com > Sent: 11 August 2017 11:57 > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] dpif-netdev: Fix comments in function headers

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

2017-12-11 Thread Ferriter, Cian
Hi Jan, This is a very interesting patch with compelling results. I had a few questions after reading the commit message for this patch: How did you decide on 1M as the proposed size for the DFC? Will the size of this DFC be configurable (i.e. map a different number of hash bits)? I was

Re: [ovs-dev] [PATCH] tests: Add system-dpdk-testsuite

2017-12-20 Thread Ferriter, Cian
Hi Marcin, Thanks for this patch on testing! I have applied it to the latest master and done some testing. Please find some feedback from my testing below: I have both an ixgbe and an i40e device on my platform, and was able to test with both. I can confirm that all three tests in this initial

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Enable HW_CRC_STRIP for virtual functions.

2018-05-25 Thread Ferriter, Cian
Hi, I did all my testing with DPDK 17.11.2 and the following OVS commit (patch doesn't apply cleanly to master): cferrite@silpixa00393943:~/ovs$ git show --summary commit 6b71df2fc06921758798e41833d67d9daf647d19 Author: Kevin Traynor Date: Wed Apr 25 12:20:53 2018 +0100

Re: [ovs-dev] [PATCH v2 1/1] netdev-dpdk: Handle ENOTSUP for rte_eth_dev_set_mtu.

2018-05-25 Thread Ferriter, Cian
Hi Ian, I did all my testing with DPDK 17.11.2 and the following OVS commit (HEAD of master at the time of testing): cferrite@silpixa00393943:~/ovs$ git show --summary commit 55b259471719ceca1f0083bdd6a5f8c3e7690bae Author: Numan Siddique Date: Thu May 24 17:45:53 2018

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Enable HW_CRC_STRIP for virtual functions.

2018-05-31 Thread Ferriter, Cian
> > > > Hi, > > > > > > I did all my testing with DPDK 17.11.2 and the following OVS commit > > > (patch doesn't apply cleanly to master): > > > cferrite@silpixa00393943:~/ovs$ git show --summary commit > > > 6b71df2fc06921758798e41833d67d9daf647d19 > > > Author: Kevin Traynor > > > Date: Wed

Re: [ovs-dev] [PATCH v2] tests: Add system-dpdk-testsuite

2018-01-10 Thread Ferriter, Cian
Hi Marcin, Thanks for the v2 of this patch and thank you for addressing my comments. I have tested again with the latest master and can confirm that this works like in the v1 with ixgbe and i40e devices. I can also confirm that the 3rd test (Add vhost-user-client port) is no longer skipped

Re: [ovs-dev] [v12 15/16] dpif-netdev: Optimize dp output action.

2021-06-16 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 15 June 2021 18:04 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; > Ferriter, Cian ; Van Haaren, Harry > > Cc: i.maxim...@ovn.org > Subject: RE: [o

Re: [ovs-dev] [v12 16/16] netdev: Optimize netdev_send_prepare_batch.

2021-06-16 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 15 June 2021 18:04 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org; Gaetan Rivet ; Sriharsha > Basav

Re: [ovs-dev] [v12 04/16] dpif-avx512: Add ISA implementation of dpif.

2021-06-16 Thread Ferriter, Cian
Hi Ian, Further comments are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 16 June 2021 12:03 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 04/16] dpif-avx512: A

Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

2021-06-16 Thread Ferriter, Cian
Hi Ian, I've replied on the checkpatch issues inline below. Thanks, Cian > -Original Message- > From: Stokes, Ian > Sent: Tuesday 15 June 2021 18:26 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org; Gaetan Rivet ; Srihar

Re: [ovs-dev] [v12 16/16] netdev: Optimize netdev_send_prepare_batch.

2021-06-16 Thread Ferriter, Cian
> -Original Message- > From: Stokes, Ian > Sent: Wednesday 16 June 2021 13:48 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org; Gaetan Rivet ; Sriharsha > Basavapatna > Subject: RE: [ovs-dev] [v12

Re: [ovs-dev] [v12 15/16] dpif-netdev: Optimize dp output action.

2021-06-16 Thread Ferriter, Cian
Hi Ian, Further responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 16 June 2021 13:47 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry ; > i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 15/16] dpif-netdev: Opti

Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 19 May 2021 16:54 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 01/16] dpif-netdev: Refactor

Re: [ovs-dev] [v12 06/16] dpif-netdev: Add command to switch dpif implementation.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 18:16 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 06

Re: [ovs-dev] [v12 05/16] dpif-avx512: Add HWOL support to avx512 dpif.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 1 June 2021 19:59 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Finn, > Emma ; Van Haaren, Harry > > Cc: i.maxim...@ovn.org > Subject: RE: [o

Re: [ovs-dev] [v12 13/16] dpdk: Cache result of CPU ISA checks.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 9 June 2021 16:23 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 13/1

Re: [ovs-dev] [v12 04/16] dpif-avx512: Add ISA implementation of dpif.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 1 June 2021 19:59 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 04/16]

Re: [ovs-dev] [v12 12/16] dpif-netdev/dpcls: Specialize more subtable signatures.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 20:08 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 12/

Re: [ovs-dev] [v12 02/16] dpif-netdev: Split HWOL out to own header file.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 1 June 2021 19:58 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org; Gaetan Rivet ; el...@nvidia.com >

Re: [ovs-dev] [v12 03/16] dpif-netdev: Add function pointer for netdev input.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Tuesday 1 June 2021 19:58 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 03

Re: [ovs-dev] [v12 09/16] docs/dpdk/bridge: Add dpif performance section.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 19:41 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 09/16]

Re: [ovs-dev] [v12 08/16] dpif-netdev: Add a partial HWOL PMD statistic.

2021-06-10 Thread Ferriter, Cian
ginal Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 19:10 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry ; Gaetan > Rivet ; Sriharsha Basavapatna > > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 08/16] dpif-netdev

Re: [ovs-dev] [v12 10/16] dpif-netdev/dpcls: Refactor function names to dpcls.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 2 June 2021 19:56 > To: Ferriter, Cian ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 10/

Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

2021-06-22 Thread Ferriter, Cian
Hi all, Thanks for the feedback. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Tuesday 22 June 2021 17:39 > To: Stokes, Ian > Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; > i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

2021-06-23 Thread Ferriter, Cian
> -Original Message- > From: dev On Behalf Of Ferriter, Cian > Sent: Wednesday 23 June 2021 13:38 > To: Ilya Maximets ; Eli Britstein ; > d...@openvswitch.org > Cc: ivan.ma...@oktetlabs.ru; Ameer Mahagneh ; Majd Dibbiny > > Subject: Re: [ovs-dev] [PATCH V6 0

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

2021-06-23 Thread Ferriter, Cian
Hi all, As part of rebasing our AVX512 DPIF on this patchset, I tested this patchset with partial HWOL and I'm seeing strange behaviour. I'll report back more detailed findings soon, just wanted to mention this here as soon as I found the issue. Thanks, Cian > -Original Message- >

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

2021-06-23 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Wednesday 23 June 2021 16:25 > To: Ferriter, Cian ; Ilya Maximets > ; Eli Britstein > ; d...@openvswitch.org > Cc: ivan.ma...@oktetlabs.ru; Ameer Mahagneh ; Majd Dibbiny > > Subject: Re: [ovs-dev] [PATCH V

Re: [ovs-dev] [v13 04/12] dpif-avx512: Add ISA implementation of dpif.

2021-06-21 Thread Ferriter, Cian
Hi Flavio, Thanks for the review. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Sunday 20 June 2021 21:09 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; Amber, Kumar ; > i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 04

Re: [ovs-dev] [v13 01/12] dpif-netdev: Refactor to multiple header files.

2021-06-21 Thread Ferriter, Cian
Hi Flavio, Thanks for the review. My responses are inline. Thanks, Cian > -Original Message- > From: Flavio Leitner > Sent: Friday 18 June 2021 13:12 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 01/12] dpi

Re: [ovs-dev] [v13 02/12] dpif-netdev: Split HWOL out to own header file.

2021-06-21 Thread Ferriter, Cian
Hi Flavio, Thanks for the review. My comments are inline, Cian > -Original Message- > From: Flavio Leitner > Sent: Friday 18 June 2021 13:12 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 02/12] dpif-netdev: Spl

Re: [ovs-dev] [v13 03/12] dpif-netdev: Add function pointer for netdev input.

2021-06-21 Thread Ferriter, Cian
Hi Flavio, Thanks for the review. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Friday 18 June 2021 13:53 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 03/12] dpif-netdev: Ad

Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

2021-06-22 Thread Ferriter, Cian
Hi Flavio, Thanks for the review. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Monday 21 June 2021 19:22 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 08/12] dpif-netdev-uni

Re: [ovs-dev] [v13 06/12] dpif-netdev: Add command to get dpif implementations.

2021-06-24 Thread Ferriter, Cian
Hi Flavio, Thanks for the review. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Wednesday 23 June 2021 20:21 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 06/12] dpif-netdev:

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-24 Thread Ferriter, Cian
Hi Flavio, Thanks for clarifying. My response is inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Thursday 24 June 2021 13:26 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 05/12] dpif-netdev: Add

Re: [ovs-dev] [v13 04/12] dpif-avx512: Add ISA implementation of dpif.

2021-06-24 Thread Ferriter, Cian
Hi Flavio, Thanks for the testing here. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Thursday 24 June 2021 05:06 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; Amber, Kumar ; > i.maxim...@ovn.org > Subject: Re: [ovs-

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-24 Thread Ferriter, Cian
Hi Flavio, Thanks for the review. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Wednesday 23 June 2021 19:18 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 05/12] dpif-n

Re: [ovs-dev] [PATCH V7 06/13] dpif-netdev: Add HW miss packet state recover logic.

2021-06-25 Thread Ferriter, Cian
; > Sriharsha Basavapatna > ; Hemal Shah ; > Ivan Malov > ; Ferriter, Cian ; Eli > Britstein ; > Finn, Emma ; Kovacevic, Marko > Subject: [PATCH V7 06/13] dpif-netdev: Add HW miss packet state recover logic. > > Recover the packet if it was partially processed by

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-25 Thread Ferriter, Cian
Hi Flavio, Just one correction I noticed while implementing your feedback. I've replied inline. Thanks, Cian > -Original Message- > From: Ferriter, Cian > Sent: Thursday 24 June 2021 12:54 > To: Flavio Leitner > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Sub

Re: [ovs-dev] [v14 05/11] dpif-netdev: Add command to switch dpif implementation.

2021-07-07 Thread Ferriter, Cian
Hi Flavio, Thanks for your comments. My responses are inline. Thanks, Cian > -Original Message- > From: Flavio Leitner > Sent: Wednesday 7 July 2021 15:40 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v14 05/11

Re: [ovs-dev] [v14 06/11] dpif-netdev: Add command to get dpif implementations.

2021-07-08 Thread Ferriter, Cian
Hi Flavio, Thanks for your comments. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Wednesday 7 July 2021 18:29 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v14 06/11] dpif-n

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Introduce netdev array cache

2021-07-08 Thread Ferriter, Cian
Gaëtan Rivet > Sent: Wednesday 7 July 2021 17:36 > To: Eli Britstein ; > ; Van Haaren, Harry > ; Ferriter, Cian > Cc: Majd Dibbiny ; Ilya Maximets > Subject: Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Introduce netdev array cache > > On Wed, Jul 7, 2021, at 17:05, Eli Bri

Re: [ovs-dev] [v13 06/12] dpif-netdev: Add command to get dpif implementations.

2021-06-30 Thread Ferriter, Cian
Hi Eelco, Thanks for you comment. My reply is inline. Cian > -Original Message- > From: Eelco Chaudron > Sent: Tuesday 29 June 2021 09:25 > To: Ferriter, Cian ; Van Haaren, Harry > > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; Flavio Leitner > > Subjec

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-28 Thread Ferriter, Cian
Hi Eelco, Thanks for the comments. My responses are inline. Cian > -Original Message- > From: Eelco Chaudron > Sent: Monday 28 June 2021 15:35 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; Flavio Leitner > ; Van Haaren, Harry > > Sub

Re: [ovs-dev] [v13 05/12] dpif-netdev: Add command to switch dpif implementation.

2021-06-29 Thread Ferriter, Cian
Hi Eelco, Thanks for your comments. My response is inline. Cian > -Original Message- > From: Eelco Chaudron > Sent: Friday 25 June 2021 16:14 > To: Ferriter, Cian > Cc: Flavio Leitner ; ovs-dev@openvswitch.org; > i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v

Re: [ovs-dev] [v14 01/11] dpif-netdev: Refactor to multiple header files.

2021-07-07 Thread Ferriter, Cian
Hi Flavio, Thanks for the info. My response is inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Tuesday 6 July 2021 20:36 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v14 01/11] dpif-netdev: Re

Re: [ovs-dev] [v14 02/11] dpif-netdev: Split HWOL out to own header file.

2021-07-07 Thread Ferriter, Cian
Hi Flavio, Thanks for your comment. My response is inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Wednesday 7 July 2021 00:06 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v14 02/11] dpif-netd

Re: [ovs-dev] [v10 02/15] dpif-netdev: Split HWOL out to own header file.

2021-04-07 Thread Ferriter, Cian
This is a genuine unexpected sign-off, caused by an error in my .gitconfig. I've fixed this, so all warnings like this in the patchset will be fixed for the next version. Sorry about that. > -Original Message- > From: 0-day Robot > Sent: Wednesday 7 April 2021 11:04 >

Re: [ovs-dev] [RFC 0/1] Userspace deferral of work

2021-04-15 Thread Ferriter, Cian
> -Original Message- > From: David Marchand > Sent: Wednesday 14 April 2021 17:02 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [RFC 0/1] Userspace deferral of work > > On Wed, Apr 14, 2021 at 5:44 PM Ferriter, Cian > wrote: &g

Re: [ovs-dev] [RFC 0/1] Userspace deferral of work

2021-04-14 Thread Ferriter, Cian
I am sending this RFC again, since the first one didn't show up on Patchwork. Nothing else about the RFC has changed. > -Original Message- > From: Ferriter, Cian > Sent: Monday 12 April 2021 17:31 > To: ovs-dev@openvswitch.org > Cc: Pai G, Sunil ; Van Haaren, Harry >

Re: [ovs-dev] [PATCH 1/3] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

2021-08-13 Thread Ferriter, Cian
> -Original Message- > From: Stokes, Ian > Sent: Thursday 12 August 2021 15:43 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: f...@sysclose.org > Subject: RE: [ovs-dev] [PATCH 1/3] dpif-netdev-unixctl.man: Document > subtable-lookup-* CMDs > > > Fix

Re: [ovs-dev] [PATCH 2/3] dpif-netdev-unixctl.man: Document miniflow-parser-* CMDs

2021-08-13 Thread Ferriter, Cian
> -Original Message- > From: Stokes, Ian > Sent: Thursday 12 August 2021 15:46 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: f...@sysclose.org > Subject: RE: [ovs-dev] [PATCH 2/3] dpif-netdev-unixctl.man: Document > miniflow-parser-* CMDs > > > Fix

Re: [ovs-dev] [PATCH 3/3] docs/dpdk/bridge: Fix dpif-netdev/miniflow-parser-set formatting

2021-08-13 Thread Ferriter, Cian
> -Original Message- > From: Stokes, Ian > Sent: Thursday 12 August 2021 15:58 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: f...@sysclose.org > Subject: RE: [ovs-dev] [PATCH 3/3] docs/dpdk/bridge: Fix > dpif-netdev/miniflow-parser-set formatting >

Re: [ovs-dev] [PATCH] dpif-netdev: Mention SMC in 2 pmd_thread comments

2021-09-09 Thread Ferriter, Cian
> -Original Message- > From: Kevin Traynor > Sent: Thursday 9 September 2021 14:39 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Mention SMC in 2 pmd_thread > comments > > pmd_thread seems like it is refere

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Introduce netdev array cache

2021-07-15 Thread Ferriter, Cian
> -Original Message- > From: Eli Britstein > Sent: Wednesday 14 July 2021 16:21 > To: Ferriter, Cian ; Ilya Maximets > ; Gaëtan Rivet > ; d...@openvswitch.org; Van Haaren, Harry > > Cc: Majd Dibbiny ; Stokes, Ian ; > Flavio Leitner > > Subject: Re:

Re: [ovs-dev] [v15 06/10] dpif-netdev: Add a partial HWOL PMD statistic.

2021-07-15 Thread Ferriter, Cian
> -Original Message- > From: Flavio Leitner > Sent: Friday 9 July 2021 18:54 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v15 06/10] dpif-netdev: Add a partial HWOL PMD > statistic. > > &

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Introduce netdev array cache

2021-07-14 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Friday 9 July 2021 21:53 > To: Ferriter, Cian ; Gaëtan Rivet ; > Eli Britstein > ; d...@openvswitch.org; Van Haaren, Harry > > Cc: Majd Dibbiny ; Ilya Maximets ; > Stokes, Ian > ; Flavio Leitner >

Re: [ovs-dev] [PATCH] acinclude: Don't set AVX512-related configuration via CFLAGS.

2021-08-04 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Tuesday 3 August 2021 18:37 > To: ovs-dev@openvswitch.org; Stokes, Ian > Cc: Flavio Leitner ; Amber, Kumar ; > Ferriter, Cian > ; Van Haaren, Harry ; > Ilya Maximets > > Subject: [PATCH] acinc

Re: [ovs-dev] [PATCH] Documentation: Change the address in userspace-tunneling.rst

2021-09-30 Thread Ferriter, Cian
> -Original Message- > From: dev On Behalf Of Paolo Valerio > Sent: Wednesday 29 September 2021 21:43 > To: d...@openvswitch.org > Cc: f...@redhat.com; i.maxim...@ovn.org > Subject: [ovs-dev] [PATCH] Documentation: Change the address in > userspace-tunneling.rst > > Fixes:

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Introduce netdev array cache

2021-07-16 Thread Ferriter, Cian
> -Original Message- > From: Eli Britstein > Sent: Thursday 15 July 2021 15:10 > To: Ferriter, Cian ; Ilya Maximets > ; Gaëtan Rivet > ; d...@openvswitch.org; Van Haaren, Harry > > Cc: Majd Dibbiny ; Stokes, Ian ; > Flavio Leitner > > Subject: Re:

Re: [ovs-dev] [v15 06/10] dpif-netdev: Add a partial HWOL PMD statistic.

2021-07-16 Thread Ferriter, Cian
> -Original Message- > From: Flavio Leitner > Sent: Thursday 15 July 2021 19:58 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v15 06/10] dpif-netdev: Add a partial HWOL PMD > statistic. > > On Thu, Jul 1

Re: [ovs-dev] [PATCH] dpif-netdev: Fix non-atomic read of smc_enable_db.

2021-07-27 Thread Ferriter, Cian
> Atomic variables must be read atomically. And since we already have > 'smc_enable_db' in the PMD context, we need to use it from there to > avoid reading atomically twice. > > Also, 'smc_enable_db' is a global configuration, there is no need > to read it per-port or per-rxq. > > CC: Harry

Re: [ovs-dev] [PATCH 1/3] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

2021-07-28 Thread Ferriter, Cian
> -Original Message- > From: Ferriter, Cian > Sent: Wednesday 28 July 2021 14:20 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; Ferriter, Cian > Subject: [PATCH 1/3] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs > > Fixes: 9ff7cabfd78d (&q

Re: [ovs-dev] OVS DPDK MFEX Unit Tests Failing

2022-01-12 Thread Ferriter, Cian
Hi David, I tested your fix and it works, but I had to modify the port number from 0 to 1. If I leave it at 0, the tests still fail. I put the modifications I made inline below. Perhaps we need to wildcard this number? Thanks, Cian > -Original Message- > From: dev On Behalf Of David

Re: [ovs-dev] OVS DPDK MFEX Unit Tests Failing

2022-01-12 Thread Ferriter, Cian
> -Original Message- > From: David Marchand > Sent: Wednesday 12 January 2022 17:05 > To: Ferriter, Cian > Cc: Phelan, Michael ; d...@openvswitch.org; Ilya > Maximets > Subject: Re: [ovs-dev] OVS DPDK MFEX Unit Tests Failing > > On Wed, Jan 12, 202

Re: [ovs-dev] [PATCH v3] system-dpdk.at: Add warning log in mfex fuzzy test.

2022-02-10 Thread Ferriter, Cian
> -Original Message- > From: dev On Behalf Of Kumar Amber > Sent: Wednesday 9 February 2022 09:50 > To: ovs-dev@openvswitch.org > Cc: Amber, Kumar ; david.march...@redhat.com > Subject: [ovs-dev] [PATCH v3] system-dpdk.at: Add warning log in mfex fuzzy > test. > > Some specific

Re: [ovs-dev] [PATCH v1] system-dpdk.at: Improve mfex test to include dpif avx512.

2022-02-28 Thread Ferriter, Cian
y > ; Amber, Kumar ; Ferriter, > Cian > > Subject: [PATCH v1] system-dpdk.at: Improve mfex test to include dpif avx512. For the commit title, how about: system-dpdk: Fix mfex autovalidator tests. And adding a "Fixes:" tag? > > AVX512 DPIF must be active in order for the MF

Re: [ovs-dev] [PATCH] dpif-netdev: Simplify atomic function pointer stores

2022-02-22 Thread Ferriter, Cian
Hi Amber, Thanks for reviewing and Acking! > -Original Message- > From: Amber, Kumar > Sent: Tuesday 22 February 2022 06:15 > To: ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; Ferriter, Cian > Subject: RE: [PATCH] dpif-netdev: Simplify atomic function pointer s

Re: [ovs-dev] [PATCH v2 4/5] acinclude: Add seperate check for AVX512VBMI ISA.

2022-03-02 Thread Ferriter, Cian
> -Original Message- > From: Ferriter, Cian > Sent: Wednesday 2 March 2022 12:18 > To: ovs-dev@openvswitch.org > Cc: Ferriter, Cian ; Van Haaren, Harry > > Subject: [PATCH v2 4/5] acinclude: Add seperate check for AVX512VBMI ISA. > > Only use the "

Re: [ovs-dev] [PATCH v2] system-dpdk: Fix mfex autovalidator tests.

2022-03-03 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Tuesday 1 March 2022 15:08 > To: ovs-dev@openvswitch.org > Cc: Ferriter, Cian ; echau...@redhat.com; Stokes, > Ian ; > Van Haaren, Harry ; Amber, Kumar > > Subject: [PATCH v2] system-dpdk: Fix mfex autov

Re: [ovs-dev] [PATCH v2 4/5] acinclude: Add seperate check for AVX512VBMI ISA.

2022-03-03 Thread Ferriter, Cian
> -Original Message- > From: Van Haaren, Harry > Sent: Wednesday 2 March 2022 14:36 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Subject: RE: [PATCH v2 4/5] acinclude: Add seperate check for AVX512VBMI ISA. > > > -Original Message----- > >

Re: [ovs-dev] [PATCH v6 6/6] tests/mfex: Improve pcap script for complex testing traffic

2022-03-22 Thread Ferriter, Cian
To: ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; Ferriter, Cian ; Stokes, Ian > ; > f...@sysclose.org; echau...@redhat.com; Van Haaren, Harry > ; Amber, Kumar > > Subject: [PATCH v6 6/6] tests/mfex: Improve pcap script for complex testing > traffic > > The mfex pcap g

Re: [ovs-dev] [PATCH v6 1/6] dpif-netdev/mfex: Add AVX512 ipv6 traffic profiles

2022-03-22 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Tuesday 15 March 2022 04:12 > To: ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; Ferriter, Cian ; Stokes, Ian > ; > f...@sysclose.org; echau...@redhat.com; Van Haaren, Harry > ; Amber, Kumar > > Subject: [PATCH v6 1/6

Re: [ovs-dev] [PATCH v7 3/4] dpif-netdev/mfex: Avoid hashing when opt mfex called.

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar >

Re: [ovs-dev] [PATCH v7 2/4] dpif-netdev/mfex: Add packet hash check to autovalidator.

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar >

Re: [ovs-dev] [PATCH v7 0/4] IPv4 Hashing AVX512 Optimizations

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar >

Re: [ovs-dev] [PATCH v7 1/4] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar >

Re: [ovs-dev] [PATCH v7 4/4] tests/mfex: Improve pcap script for mfex tests.

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar >

Re: [ovs-dev] [PATCH v8 1/4] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-04-01 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Friday 1 April 2022 12:24 > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; Ferriter, Cian > ; > f...@sysclose.org; Van Haaren, Harry ; Amber, > Kumar > Subject: [PATCH v8 1/4] dpif-ne

Re: [ovs-dev] [PATCH v8 4/4] tests/mfex: Improve pcap script for mfex tests.

2022-04-01 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Friday 1 April 2022 12:24 > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; Ferriter, Cian > ; > f...@sysclose.org; Van Haaren, Harry ; Amber, > Kumar > Subject: [PATCH v8 4/4] test

Re: [ovs-dev] [PATCH v8 2/4] dpif-netdev/mfex: Add packet hash check to autovalidator.

2022-04-01 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Friday 1 April 2022 12:24 > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; Ferriter, Cian > ; > f...@sysclose.org; Van Haaren, Harry ; Amber, > Kumar > Subject: [PATCH v8 2/4] dpif-n

Re: [ovs-dev] [PATCH v8 3/4] dpif-netdev/mfex: Avoid hashing when opt mfex called.

2022-04-01 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Friday 1 April 2022 12:24 > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; Ferriter, Cian > ; > f...@sysclose.org; Van Haaren, Harry ; Amber, > Kumar > Subject: [PATCH v8 3/4] dpif

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-02-02 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Wednesday 2 February 2022 13:57 > To: Stokes, Ian ; Ferriter, Cian > ; William Tu > ; d...@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-01-28 Thread Ferriter, Cian
> -Original Message- > From: dev On Behalf Of William Tu > Sent: Thursday 27 January 2022 03:45 > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler > support. > > Ubuntu Xenial 16.04 is using GCC 5.4 and it does not support > target

Re: [ovs-dev] [BUG] dpcls_subtable_lookup_reprobe is not thread-safe.

2022-01-27 Thread Ferriter, Cian
> -Original Message- > From: dev On Behalf Of Ilya Maximets > Sent: Friday 14 January 2022 11:44 > To: ovs-dev > Cc: i.maxim...@ovn.org > Subject: [ovs-dev] [BUG] dpcls_subtable_lookup_reprobe is not thread-safe. > > The function currently looks like this: > > lib/dpif-netdev.c: > >

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-02-01 Thread Ferriter, Cian
> -Original Message- > From: Ferriter, Cian > Sent: Friday 28 January 2022 16:32 > To: William Tu ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler > support. > > > > -Original Message- > >

Re: [ovs-dev] [PATCH] dpif-netdev-dpcls: Make subtable reprobe thread-safe.

2022-02-08 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Friday 4 February 2022 12:11 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; Van Haaren, Harry > Subject: Re: [PATCH] dpif-netdev-dpcls: Make subtable reprobe thread-safe. > > On 2/2

Re: [ovs-dev] [PATCH v3] system-dpdk.at: Add warning log in mfex fuzzy test.

2022-02-11 Thread Ferriter, Cian
> -Original Message- > From: Stokes, Ian > Sent: Friday 11 February 2022 10:49 > To: Ferriter, Cian ; Amber, Kumar > ; ovs- > d...@openvswitch.org > Cc: Amber, Kumar ; david.march...@redhat.com > Subject: RE: [ovs-dev] [PATCH v3] system-dpdk.at: Add warning l

Re: [ovs-dev] [PATCH] system-dpdk: Fix MFEX logs check.

2022-01-20 Thread Ferriter, Cian
> -Original Message- > From: David Marchand > Sent: Wednesday 19 January 2022 17:26 > To: d...@openvswitch.org > Cc: Stokes, Ian ; Phelan, Michael > ; Ferriter, Cian > ; i.maxim...@ovn.org; ktray...@redhat.com > Subject: [PATCH] system-dpdk: Fix MFEX logs check

Re: [ovs-dev] [PATCHv2] IPv6: Add IPv6 extension header support

2022-04-20 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Monday 21 March 2022 16:56 > To: d...@openvswitch.org; Stokes, Ian ; Van Haaren, > Harry > ; Ferriter, Cian ; > Amber, Kumar > > Cc: i.maxim...@ovn.org; Toms Atteka > Subject: Re: [ovs-dev] [PATCHv2] I

Re: [ovs-dev] [PATCH v2 0/4] Miniflow Extract Testing Improvements

2022-04-25 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Sunday 27 March 2022 08:09 > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; > ktray...@redhat.com; i.maxim...@ovn.org; > Ferriter, Cian ; f...@sysclose.org; Van Haaren, Harry > ; Amber, Kum

Re: [ovs-dev] [PATCH v2 2/4] dpif-netdev: Refactor hashing function.

2022-04-25 Thread Ferriter, Cian
> Sent: Sunday 27 March 2022 08:09 > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; > ktray...@redhat.com; i.maxim...@ovn.org; > Ferriter, Cian ; f...@sysclose.org; Van Haaren, Harry > ; Amber, Kumar > Subject: [PATCH v2 2/4] dpif-netdev: Refactor hashing funct

Re: [ovs-dev] [PATCH v2 4/4] miniflow_extract: Add autovalidator support to miniflow_extract.

2022-04-25 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Sunday 27 March 2022 08:09 > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; > ktray...@redhat.com; i.maxim...@ovn.org; > Ferriter, Cian ; f...@sysclose.org; Van Haaren, Harry > ; Amber, Kum

Re: [ovs-dev] [PATCH v2 3/4] Miniflow_extract: Refactor miniflow_extract into api.

2022-04-25 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Sunday 27 March 2022 08:09 > To: ovs-dev@openvswitch.org > Cc: Stokes, Ian ; echau...@redhat.com; > ktray...@redhat.com; i.maxim...@ovn.org; > Ferriter, Cian ; f...@sysclose.org; Van Haaren, Harry > ; Amber, Kum

Re: [ovs-dev] [PATCH v4 5/5] acinclude: Add seperate checks for AVX512 ISA.

2022-05-17 Thread Ferriter, Cian
> -Original Message- > From: Pai G, Sunil > Sent: Thursday 5 May 2022 11:26 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: Van Haaren, Harry > Subject: RE: [PATCH v4 5/5] acinclude: Add seperate checks for AVX512 ISA. > > Hi Cian, > > Few comme

Re: [ovs-dev] [PATCH] dpif-netdev: Only hash port number when necessary.

2022-05-18 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Wednesday 18 May 2022 11:35 > To: Mike Pattrick ; Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Only hash port number when > necessary. >

Re: [ovs-dev] [PATCH] classifier: adjust segment boundary to execute prerequisite processing

2022-05-19 Thread Ferriter, Cian
Hi Aaron, > --- > include/openvswitch/flow.h | 7 +++ > tests/classifier.at| 27 +++ > 2 files changed, 30 insertions(+), 4 deletions(-) > > diff --git a/include/openvswitch/flow.h b/include/openvswitch/flow.h > index 3054015d93..df10cf579e 100644 > ---

  1   2   >