[Bug 1380442] Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380442



--- Comment #7 from Benjamin Lefoul  ---
I don't have any experience building with cargo, but I found this:

https://czanik.blogs.balabit.com/2016/07/how-to-package-rust-applications-to-rpm-using-vendoring/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1110070] Review Request: vert.x - A lightweight, high-performance, polyglot, event-driven application platform for JVM

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1110070

Lin Gao  changed:

   What|Removed |Added

  Flags|needinfo?(l...@redhat.com)  |



--- Comment #3 from Lin Gao  ---
@gil cattaneo, The active master branch of Vert.x is 3.x now, see
https://github.com/eclipse/vert.x, which is Maven based build.

I don't have much time to follow this anymore because of busy JBoss EAP
sustaining tasks. If you want to take over, feel free to do so. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1380442] Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380442



--- Comment #8 from Igor Gnatenko  ---
We're still working on packaging guidelines for rust/cargo. It's not that
trivial and can be targeted only for cargo > 0.13

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1211529] Review Request: docker-machine - Tool for managing Docker hosts

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1211529



--- Comment #24 from Yajo  ---
Ping! :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1380442] Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380442



--- Comment #9 from Benjamin Lefoul  ---
(In reply to Igor Gnatenko from comment #8)
> We're still working on packaging guidelines for rust/cargo. 

Thanks Igor. Where can we follow the discussions on packaging guidelines for
rust/cargo? Any way to automate a notification here when a consensus is
reached?


> It's not that trivial and can be targeted only for cargo > 0.13

So far cargo is > 0.13 only in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1211517] Review Request: docker-swarm - Docker-native clustering system

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1211517



--- Comment #30 from Yajo  ---
It seems to me that this is not necessary anymore after Docker 1.12 with its
built-in swarm mode.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1380442] Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380442



--- Comment #10 from Igor Gnatenko  ---
(In reply to Benjamin Lefoul from comment #9)
> (In reply to Igor Gnatenko from comment #8)
> > We're still working on packaging guidelines for rust/cargo. 
> 
> Thanks Igor. Where can we follow the discussions on packaging guidelines for
> rust/cargo? Any way to automate a notification here when a consensus is
> reached?
We discussed it last friday on #fedora-rust. We will send some notification to
devel@ ML once we will have something working.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1380442] Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380442



--- Comment #11 from Benjamin Lefoul  ---
(In reply to Benjamin Lefoul from comment #9)
> So far cargo is > 0.13 only in rawhide.

It's = 0.13 actually.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384242] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and affiliated package

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384242

Dominika Krejčí  changed:

   What|Removed |Added

 CC||dkre...@redhat.com



--- Comment #1 from Dominika Krejčí  ---
Hi Orion, links to SPEC and SRPM are invalid.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1381132] Review Request: python-wikipedia - Wikipedia API for Python

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1381132

Dominika Krejčí  changed:

   What|Removed |Added

 CC||dkre...@redhat.com



--- Comment #1 from Dominika Krejčí  ---
Hi Martin, I have some comments.

* The last version of barrust/Wikipedia is 1.4.5 and the commit used in
`Source0` also corresponds with 1.4.5. Why is there 1.4.4 in the `Version` tag?

* The `Source0` url creates directory with ugly name, it should be named
`%{srcname}-%{version}.tar.gz`.

* It is useless to create a %{sum} macro. Just write the content to `Summary`
and in the rest of the file you can use %{summary} marco. ;)

* Rather then `python-requests` be more specific and use `python2-requests`,
wherever it is possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1382332] Review Request: python-axolotl-curve25519 - curve25519 with ed25519 signatures

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1382332

Dominika Krejčí  changed:

   What|Removed |Added

 CC||dkre...@redhat.com



--- Comment #1 from Dominika Krejčí  ---
Hello Christian, I have some comments:

* It is useless to create a %{sum} macro. Just write the content to `Summary`
and in the rest of the file you can use %{summary} macro. ;)

* `%description` should contain more comprehensive description then `Summary`.

* The file `PKG-INFO` is not a license. ("If the source package does not
include license text(s) as a separate file from upstream, the packager SHOULD
query upstream to include it.")

* If you run rpmlint, you will get many errors and warnings. Some of them: 

python3-axolotl-curve25519.x86_64: W: summary-not-capitalized C curve25519 with
ed25519 signatures
python3-axolotl-curve25519.x86_64: W: no-documentation
python3-axolotl-curve25519.x86_64: E: script-without-shebang
/usr/share/licenses/python3-axolotl-curve25519/PKG-INFO
python3-axolotl-curve25519.x86_64: E: script-without-shebang
/usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg-info/dependency_links.txt
python3-axolotl-curve25519.x86_64: E: script-without-shebang
/usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg-info/PKG-INFO
python3-axolotl-curve25519.x86_64: E: script-without-shebang
/usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg-info/top_level.txt
python3-axolotl-curve25519.x86_64: E: script-without-shebang
/usr/lib64/python3.5/site-packages/python_axolotl_curve25519-0.1-py3.5.egg-info/SOURCES.txt
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Dominika Krejčí  changed:

   What|Removed |Added

 CC||dkre...@redhat.com



--- Comment #1 from Dominika Krejčí  ---
Hello David, I have some comments:

* It is better to be more specific and use `python2-setuptools` instead of
`python-setuptools`.

* It is good to indicate in the subpackage description whether it is Python 2
or Python3.

* Tests are packaged but the %check section is not present.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #40 from Antonio Trande  ---
(In reply to Orion Poplawski from comment #38)
> (In reply to Dave Love from comment #37)
> > (In reply to Antonio Trande from comment #36)
> > > PETSc needs fftw-mpi libraries; it does not work with fftw actually
> > > available on Fedora/EPEL.
> > 
> > OK, so we should get rid of that (and chase the change for fftw mpi
> > support...).
> 
> fftw with mpi support:
> https://bodhi.fedoraproject.org/updates/FEDORA-2016-ae8fc16aac

Thank you Orion.

New release:

SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/petsc/petsc.git/plain/petsc.spec?id=6dfb01819ef4d5619b440cd52e096bb15a5bd826

SRPM:
https://copr-be.cloud.fedoraproject.org/results/sagitter/petsc/fedora-rawhide-x86_64/00465011-petsc/petsc-3.7.4-5.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384917] New: Review Request: python-pykwalify - Python lib/ cli for JSON/YAML schema validation

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384917

Bug ID: 1384917
   Summary: Review Request: python-pykwalify - Python lib/cli for
JSON/YAML schema validation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: chku...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://chandankumar.fedorapeople.org/python-pykwalify.spec
SRPM URL:
https://chandankumar.fedorapeople.org/python-pykwalify-1.5.1-1.fc24.src.rpm
Description: It is a YAML/JSON validation library.
This framework is a port with alot added functionality
of the java version of the framework kwalify that can be
found at: http://www.kuwata-lab.com/kwalify/

Fedora Account System Username: chandankumar

Successful Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16086837

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384917

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1373019] Review Request: python-fuse - Python module that provides a simple interface to FUSE and MacFUSE

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1373019

Dominika Krejčí  changed:

   What|Removed |Added

 CC||dkre...@redhat.com



--- Comment #1 from Dominika Krejčí  ---
Hi Juan, I have some recommendations for you.

* Is there any reason for defining `commit` and `shortcommit` macros? I would
be more benefitial to define `srcname` macro for "fuse".

* The `Source0` url should create directory which is named
`%{srcname}-%{version}.tar.gz`, not just `%{version}.tar.gz`. (You can just add
`#/%{srcname}-%{version}.tar.gz` to your current url.)

* You do not have to rewrite summary manually. Just reuse the first Summary tag
with the %{summary} macro.

* "If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it."

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384583] Review Request: rubygem-string-scrub - String#scrub for Ruby

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384583

Sandro Bonazzola  changed:

   What|Removed |Added

 CC||paulo.cesar.pereira.de.andr
   ||a...@gmail.com
  Flags||needinfo?(paulo.cesar.perei
   ||ra.de.andr...@gmail.com)



--- Comment #2 from Sandro Bonazzola  ---
Paulo can you sponsor Andrei?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1110070] Review Request: vert.x - A lightweight, high-performance, polyglot, event-driven application platform for JVM

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1110070



--- Comment #4 from gil cattaneo  ---
(In reply to Lin Gao from comment #3)
> @gil cattaneo, The active master branch of Vert.x is 3.x now, see
> https://github.com/eclipse/vert.x, which is Maven based build.

Yes, i know

> I don't have much time to follow this anymore because of busy JBoss EAP
No problems, can you close this bug?
> sustaining tasks. If you want to take over, feel free to do so. :-)
Maybe next mounths, the latest release use netty == 4.1.5.Final

Thanks in advance
Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1110070] Review Request: vert.x - A lightweight, high-performance, polyglot, event-driven application platform for JVM

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1110070



--- Comment #5 from gil cattaneo  ---
months^ sorry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384583] Review Request: rubygem-string-scrub - String#scrub for Ruby

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384583



--- Comment #3 from Sandro Bonazzola  ---
Spec URL:
https://gist.githubusercontent.com/a15y87/ea09cfd5fb92fccc670703938fb3be40/raw/ee764a69c8a580cb89e532f3552831695e5db6b3/rubygem-string-scrub-0.1.1.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/a15/fluent/fedora-rawhide-x86_64/00463765-rubygem-string-scrub/rubygem-string-scrub-0.1.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384583] Review Request: rubygem-string-scrub - String#scrub for Ruby

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384583



--- Comment #4 from Sandro Bonazzola  ---
This package already exists in Fedora:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-string-scrub/
and is currently orphan.

Asking for unretirement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1371502] Review Request: Siril - Astronomical image (pre-) processing program

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1371502



--- Comment #13 from Christian Dersch  ---
Done, as you can see here I mostly used your spec to rework the package :)
http://pkgs.fedoraproject.org/cgit/rpms/siril.git/tree/siril.spec

Builds are running, I'll submit updates for Fedora 24 and 25 to get 0.9.4 there
:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384583] Review Request: rubygem-string-scrub - String#scrub for Ruby

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384583

Sandro Bonazzola  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-10-14 08:32:42



--- Comment #5 from Sandro Bonazzola  ---
Already under review on Bug #1373003

*** This bug has been marked as a duplicate of bug 1373003 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Sandro Bonazzola  changed:

   What|Removed |Added

 CC||a15...@gmail.com



--- Comment #7 from Sandro Bonazzola  ---
*** Bug 1384583 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Sandro Bonazzola  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NOTABUG
  Flags||needinfo?(mru...@redhat.com
   ||)
Last Closed||2016-10-14 08:35:20



--- Comment #8 from Sandro Bonazzola  ---
So, close wontfix?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Sandro Bonazzola  changed:

   What|Removed |Added

 Status|CLOSED  |POST
 Resolution|NOTABUG |---
   Keywords||Reopened



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Sandro Bonazzola  changed:

   What|Removed |Added

   Keywords|Reopened|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1205872] Review Request: python-padme - Mostly transparent proxy class for Python

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205872

Dominika Krejčí  changed:

   What|Removed |Added

 CC||dkre...@redhat.com
  Flags||needinfo?(m...@zygoon.pl)



--- Comment #5 from Dominika Krejčí  ---
Hi Zygmunt, is this request still relevant? Links do not work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1372889



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-thriftpy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1372888



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-toro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Matthias Runge  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(mru...@redhat.com |
   |)   |
Last Closed|2016-10-14 08:35:20 |2016-10-14 08:50:33



--- Comment #9 from Matthias Runge  ---
Yes, I missed that completely. Sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384242] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and affiliated package

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384242



--- Comment #2 from Orion Poplawski  ---
Sorry, should be working now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384976] New: Review Request: rubygem-serverengine - Ruby ServerEngine

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384976

Bug ID: 1384976
   Summary: Review Request: rubygem-serverengine - Ruby
ServerEngine
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: a15...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gist.githubusercontent.com/a15y87/d3aa9e890673897dee7e4936e8117ed6/raw/8d3c892e9bbfd239b8d04bc213202fd3b5a1b899/rubygem-serverengine-2.0.0.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/a15/fluent/fedora-rawhide-x86_64/00463759-rubygem-serverengine/rubygem-serverengine-2.0.0-1.fc26.src.rpm
Description: ServerEngine - multiprocess server framework
dependency of fluentd
https://bugzilla.redhat.com/show_bug.cgi?id=1384934
This is my first package, and I'm seeking a sponsor.
FE-NEEDSPONSOR
Fedora Account System Username: a15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1371502] Review Request: Siril - Astronomical image (pre-) processing program

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1371502



--- Comment #14 from Christian Dersch  ---
https://bodhi.fedoraproject.org/updates/FEDORA-2016-99c6b31855
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4a425ce77

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1343977] Review Request: asciidoctor-mallard - A Project Mallard converter for AsciiDoc

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1343977

Tummala Dhanvi (c0mrad3)  changed:

   What|Removed |Added

  Flags|needinfo?(dhanvicse@gmail.c |
   |om) |



--- Comment #5 from Tummala Dhanvi (c0mrad3)  ---
(In reply to William Moreno from comment #4)
> Hi dhanvi, there is a lot of time since last update, do you want to continue
> with this review? If not I can take care of it.

Hello William, I would like to continue with this review, but I might need your
help for the same.

> 
> Please remenber than acording to the Stalle Package Review process(0) if you
> do not reponse in one week I can close this review a open a new one.

I will update the spec file and continue with the feedback process before the
end of this week 

> 
> Regards
> 
> 0: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384984] New: Review Request: rubygem-strptime - Fast strptime engine

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384984

Bug ID: 1384984
   Summary: Review Request: rubygem-strptime - Fast strptime
engine
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: a15...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gist.githubusercontent.com/a15y87/68d06bbfd3e98ac92c066524763ec357/raw/9d96473caed36091144bf4362e968dbeeb55827f/rubygem-strptime-0.1.8.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/a15/fluent/fedora-rawhide-x86_64/00465049-rubygem-strptime/rubygem-strptime-0.1.8-1.fc26.src.rpm
Description: a fast strptime engine which uses VM.
rubygem-strptime is a dependency of fluentd
https://bugzilla.redhat.com/show_bug.cgi?id=1384924

Fedora Account System Username: a15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1384976] Review Request: rubygem-serverengine - Ruby ServerEngine

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1384976



--- Comment #1 from Sandro Bonazzola  ---
Only a partial review, but already contains things to be fixed.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains Requires: ruby(release).
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: rubygem-serverengine-2.0.0.spec should be rubygem-serverengine.spec
  See:
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
 Spec file contains wrong license id, should be: ASL 2.0
[x]: License file installed when any subpackage combination is installed.
 License is not included in doc subpackage
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[-]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[ ]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
 serverengine-doc
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[x

[Bug 1310368] review request: rubygem-jekyll - A simple, blog aware, static site generator

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1310368

François Kooman  changed:

   What|Removed |Added

 CC||fkoo...@tuxed.net



--- Comment #6 from François Kooman  ---
It seems rubygem-jekyll is already in Fedora (24)? It doesn't really seem to
work though.

rubygem-jekyll-3.2.1-1.fc24.noarch

Running it:

[fkooman@fralen ~]$ jekyll new foo
New jekyll site installed in /home/fkooman/foo. 
[fkooman@fralen ~]$ cd foo/
[fkooman@fralen foo]$ jekyll serve
/usr/share/gems/gems/bundler-1.10.6/lib/bundler/resolver.rb:347:in `block in
verify_gemfile_dependencies_are_found!': Could not find gem 'minima (>= 0)
ruby' in any of the gem sources listed in your Gemfile or available on this
machine. (Bundler::GemNotFound)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1359402

Antonio Trande  changed:

   What|Removed |Added

 Whiteboard||AwaitingSubmitter



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1358041] Review Request: python3-scipy - Scientific Tools for Python

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1358041

Antonio Trande  changed:

   What|Removed |Added

 Whiteboard||AwaitingSubmitter



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1382152] Review Request: orpie - scientific calculator

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1382152

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1359402

Tim Fenn  changed:

   What|Removed |Added

  Flags|needinfo?(tim.f...@gmail.co |
   |m)  |



--- Comment #4 from Tim Fenn  ---
(In reply to Antonio Trande from comment #3)
> Hi Tim.
> First of all:
> 
> - Leave a comment about what patches do.
> 

Done.

> - python(2)-sitelib macro is already defined
> 

Removed.

> - Use python2-devel as BR package
> 

Done.

> - Use macros instead of hardlinks:
>   /usr --> %{_prefix}
>   /usr/include/ssm --> %{_includedir}/ssm
> 

Where do you see this in the spec file?

> - 'rm -rf %{buildroot}' and '%defattr(-,root,root,-)' lines are used on
> epel5 only.
> 

Added rhel checks for these lines.

> - doc sub-package isn't noarch
> 

I didn't specify it as such?

> - COPYING is not tagged with %license

Fixed.

New files:

spec: https://drive.google.com/open?id=0BxOz1eBnQT3nOW9XWXZwNzhEY1U
srpm: https://drive.google.com/open?id=0BxOz1eBnQT3nT2FJQjlhYXVTdDA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #5 from Antonio Trande  ---
(In reply to Tim Fenn from comment #4)
> 
> > - doc sub-package isn't noarch
> > 
> 
> I didn't specify it as such?

I don't see any 'BuildArch: noarch' line...

> 
> New files:
> 
> spec: https://drive.google.com/open?id=0BxOz1eBnQT3nOW9XWXZwNzhEY1U
> srpm: https://drive.google.com/open?id=0BxOz1eBnQT3nT2FJQjlhYXVTdDA

'%defattr(-,root,root,-)' and 'rm -rf %{buildroot}' are used for epel5 only.

Why coot-1.spec ?
SPEC file must have same name of src-rpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1359402

Antonio Trande  changed:

   What|Removed |Added

 Whiteboard|AwaitingSubmitter   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1385105] New: Review Request: python-marathon - Python client library /interface to the Mesos Marathon REST API.

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Bug ID: 1385105
   Summary: Review Request: python-marathon - Python client
library/interface to the Mesos Marathon REST API.
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: d...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/dmsimard/python-marathon-distgit/master/python-marathon.spec
SRPM URL:
https://github.com/dmsimard/python-marathon-distgit/raw/master/python-marathon-0.8.6-1.fc24.src.rpm
Description: Python client library/interface to the Mesos Marathon REST API.

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=16090139

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API.

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1385105

David Moreau Simard  changed:

   What|Removed |Added

 Blocks||1385086




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385086
[Bug 1385086] openstack-magnum now requires marathon
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1381132] Review Request: python-wikipedia - Wikipedia API for Python

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1381132



--- Comment #2 from MartinKG  ---
Hi Dominika,

(In reply to Dominika Krejčí from comment #1)
> Hi Martin, I have some comments.
> 
> * The last version of barrust/Wikipedia is 1.4.5 and the commit used in
> `Source0` also corresponds with 1.4.5. Why is there 1.4.4 in the `Version`
> tag?

ok update to new version
> 
> * The `Source0` url creates directory with ugly name, it should be named
> `%{srcname}-%{version}.tar.gz`.
> 
done
> * It is useless to create a %{sum} macro. Just write the content to
> `Summary` and in the rest of the file you can use %{summary} marco. ;)
> 

done
> * Rather then `python-requests` be more specific and use `python2-requests`,
> wherever it is possible.

done

New rpm files:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-wikipedia.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/python-wikipedia-1.4.5-1.fc24.src.rpm

%changelog
* Fri Oct 14 2016 Martin Gansser  - 1.4.5-1
- Update to 1.4.5-1
- Cleanup spec file
- Use Requires python2-requests
- Write the content to Summary and in the rest use %%{summary} marco

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1385105

David Moreau Simard  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-marathon - Python|python-marathon - Python
   |client library/interface to |client library/interface to
   |the Mesos Marathon REST |the Mesos Marathon REST API
   |API.|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #1 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-marathon-distgit/master/python-marathon.spec
SRPM URL:
https://github.com/dmsimard/python-marathon-distgit/raw/master/python-marathon-0.8.6-1.fc24.src.rpm
Description: Python client library/interface to the Mesos Marathon REST API.

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=16090283

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1383680] Review Request: mate-menu - Advanced Menu for the MATE Desktop

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1383680

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-14 15:33:44



--- Comment #6 from Fedora Update System  ---
mate-menu-16.10.1-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #6 from Tim Fenn  ---
(In reply to Antonio Trande from comment #5)
> (In reply to Tim Fenn from comment #4)
> > 
> > > - doc sub-package isn't noarch
> > > 
> > 
> > I didn't specify it as such?
> 
> I don't see any 'BuildArch: noarch' line...
> 

OK I'll have that fixed in the next build - sorry, I misread this the first
time.

> > 
> > New files:
> > 
> > spec: https://drive.google.com/open?id=0BxOz1eBnQT3nOW9XWXZwNzhEY1U
> > srpm: https://drive.google.com/open?id=0BxOz1eBnQT3nT2FJQjlhYXVTdDA
> 
> '%defattr(-,root,root,-)' and 'rm -rf %{buildroot}' are used for epel5 only.
> 

Is the %if 0%{?rhel} not sufficient around these statements?  Or should it just
be removed all together?

> Why coot-1.spec ?
> SPEC file must have same name of src-rpm.

Doh, silly google drive renaming.  I'll fix in the next upload.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #7 from Antonio Trande  ---
(In reply to Tim Fenn from comment #6)
> (In reply to Antonio Trande from comment #5)
> > (In reply to Tim Fenn from comment #4)
> > > 
> > > > - doc sub-package isn't noarch
> > > > 
> > > 
> > > I didn't specify it as such?
> > 
> > I don't see any 'BuildArch: noarch' line...
> > 
> 
> OK I'll have that fixed in the next build - sorry, I misread this the first
> time.
> 
> > > 
> > > New files:
> > > 
> > > spec: https://drive.google.com/open?id=0BxOz1eBnQT3nOW9XWXZwNzhEY1U
> > > srpm: https://drive.google.com/open?id=0BxOz1eBnQT3nT2FJQjlhYXVTdDA
> > 
> > '%defattr(-,root,root,-)' and 'rm -rf %{buildroot}' are used for epel5 only.
> > 
> 
> Is the %if 0%{?rhel} not sufficient around these statements?  Or should it
> just be removed all together?

If this package isn't for epel5, you can remove all.

> 
> > Why coot-1.spec ?
> > SPEC file must have same name of src-rpm.
> 
> Doh, silly google drive renaming.  I'll fix in the next upload.

Why not fedorapeople?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #2 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-marathon-distgit/master/python-marathon.spec
SRPM URL:
https://github.com/dmsimard/python-marathon-distgit/raw/master/python-marathon-0.8.6-1.fc24.src.rpm
Description: Python client library/interface to the Mesos Marathon REST API.

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=16090465

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1370449] Review Request: rtv - A simple terminal viewer for Reddit ( Reddit Terminal Viewer)

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1370449

Germano Massullo  changed:

   What|Removed |Added

  Flags|needinfo?(germano.massullo@ |
   |gmail.com)  |



--- Comment #3 from Germano Massullo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 19 files have
 unknown license. Detailed output of licensecheck in
 /home/caterpillar/canc/rtv/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mo

[Bug 1370449] Review Request: rtv - A simple terminal viewer for Reddit ( Reddit Terminal Viewer)

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1370449

Germano Massullo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1370449] Review Request: rtv - A simple terminal viewer for Reddit ( Reddit Terminal Viewer)

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1370449



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rtv

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1341099] Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1341099



--- Comment #10 from Fedora Update System  ---
taskotron-trigger-0.4.1-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8cc8f5a18a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1341099] Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1341099



--- Comment #11 from Fedora Update System  ---
taskotron-trigger-0.4.1-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5727de3374

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1371502] Review Request: Siril - Astronomical image (pre-) processing program

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1371502

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NOTABUG |---
   Keywords||Reopened



--- Comment #15 from Fedora Update System  ---
siril-0.9.4-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4a425ce77

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1341099] Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1341099



--- Comment #12 from Fedora Update System  ---
taskotron-trigger-0.4.1-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-222f28e6b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1371502] Review Request: Siril - Astronomical image (pre-) processing program

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1371502



--- Comment #16 from Fedora Update System  ---
siril-0.9.4-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-99c6b31855

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1385180] New: Review Request: purple-facebook - Facebook protocol plugin for Purple2

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1385180

Bug ID: 1385180
   Summary: Review Request: purple-facebook - Facebook protocol
plugin for Purple2
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Purple Facebook implements the Facebook Messenger protocol into pidgin,
  finch, and libpurple.  While the primary implementation is for purple3,
  this plugin is back-ported for purple2.


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=16091239


Issues:

  No known issues, but some false positives about spelling from rpmlint.


FAS-User:

  besser82


Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/purple-facebook.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/purple-facebook-0.0.0.20160409.66ee77378d82-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1385180] Review Request: purple-facebook - Facebook protocol plugin for purple2

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1385180

Björn "besser82" Esser  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |purple-facebook - Facebook  |purple-facebook - Facebook
   |protocol plugin for Purple2 |protocol plugin for purple2
  Alias||purple-facebook



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1378740] Review Request: python-pytest-faulthandler - py.test plugin that activates the fault handler module for tests

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1378740

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-14 22:50:31



--- Comment #8 from Fedora Update System  ---
python-pytest-faulthandler-1.3.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380156



--- Comment #12 from Fedora Update System  ---
php-webmozart-assert-1.1.0-1.fc24, php-webmozart-path-util-2.3.0-1.fc24 has
been pushed to the Fedora 24 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380155



--- Comment #12 from Fedora Update System  ---
php-webmozart-assert-1.1.0-1.fc24, php-webmozart-path-util-2.3.0-1.fc24 has
been pushed to the Fedora 24 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380156



--- Comment #13 from Fedora Update System  ---
php-webmozart-assert-1.1.0-1.fc23, php-webmozart-path-util-2.3.0-1.fc23 has
been pushed to the Fedora 23 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1380155



--- Comment #13 from Fedora Update System  ---
php-webmozart-assert-1.1.0-1.fc23, php-webmozart-path-util-2.3.0-1.fc23 has
been pushed to the Fedora 23 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1297281] Review Request: endless-sky - Space exploration, trading, and combat game

2016-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1297281



--- Comment #13 from Link Dupont  ---
I can take this now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org