https://bugzilla.redhat.com/show_bug.cgi?id=1530084
--- Comment #5 from Brendan Early ---
Sorry about the SRPM link, I let it die.
Spec URL:
https://raw.githubusercontent.com/mymindstorm/numix-square-spec/70bafe33bffd222164d7ab70e5d9c4565f9f729f/numix-icon-theme-square.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1635930
--- Comment #3 from Jerry James ---
(In reply to Robert-André Mauchin from comment #1)
> - Python 2 is deprecated(), you're not supposed to package new stuff with
> it.
(* Smacks forehead *) Yes, I knew that. This spec file has been
https://bugzilla.redhat.com/show_bug.cgi?id=1635415
Jerry James changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from
https://bugzilla.redhat.com/show_bug.cgi?id=1636101
Igor Gnatenko changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1636087
Igor Gnatenko changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1635368
Robert-André Mauchin changed:
What|Removed |Added
Summary|Review Request: |Review Request:
https://bugzilla.redhat.com/show_bug.cgi?id=1634443
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1554022
--- Comment #2 from Robert-André Mauchin ---
Sorry to have forgotten you.
- Please space out your changelog entry, they are difficult to read
- I would rather have you not mix Suse stuff with Fedora stuff.
- Install the license file
https://bugzilla.redhat.com/show_bug.cgi?id=1554021
--- Comment #4 from Robert-André Mauchin ---
- Use %autosetup or %setup -q to make the setup quiet:
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and
https://bugzilla.redhat.com/show_bug.cgi?id=1554021
--- Comment #3 from Robert-André Mauchin ---
- Please space out your changelog entry, they are difficult to read
- I would rather have you not mix Suse stuff with Fedora stuff.
- Install the license file with %license, not %doc
%doc
https://bugzilla.redhat.com/show_bug.cgi?id=1554020
--- Comment #2 from Robert-André Mauchin ---
- Please space out your changelog entry, they are difficult to read
- I would rather have you not mix Suse stuff with Fedora stuff.
- In order to avoid unintintional soname bump, we now forbid
https://bugzilla.redhat.com/show_bug.cgi?id=1611611
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1611606
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1611598
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1632243
--- Comment #19 from Fedora Update System ---
shaderc-2018.0-1.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1634701
--- Comment #7 from Fedora Update System ---
R-quantities-0.1.1-2.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1512226
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1634912
Robert-André Mauchin changed:
What|Removed |Added
Status|ASSIGNED|POST
https://bugzilla.redhat.com/show_bug.cgi?id=1517451
--- Comment #19 from Robert-André Mauchin ---
- Remove %post
- Run %make_build after %configure
- Appdata file should now be installed in /usr/share/metainfo . Patch your
install scrip appropriately.
appstream-util validate-relax
https://bugzilla.redhat.com/show_bug.cgi?id=1634912
--- Comment #4 from Neil Horman ---
Thanks!
New Spec/SRPM
Spec URL: https://nhorman.fedorapeople.org/redfish-finder.spec
SRPM URL: https://nhorman.fedorapeople.org/redfish-finder-0.1-3.src.rpm
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1522690
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1530084
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1531567
Robert-André Mauchin changed:
What|Removed |Added
CC||jonh.wend...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1535384
--- Comment #5 from Robert-André Mauchin ---
Using:
* SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00793623-tomb/tomb.spec
* SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1535549
Robert-André Mauchin changed:
What|Removed |Added
Status|POST|ASSIGNED
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1544239
--- Comment #3 from Robert-André Mauchin ---
I am sorry I have forgotten this Review.
- Please use:
%global ver_patch 4
for the latest stable release. Otherwise the Source0 is 404.
- The new archive root folder is just named src/
https://bugzilla.redhat.com/show_bug.cgi?id=1632243
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--- Comment #18 from
https://bugzilla.redhat.com/show_bug.cgi?id=1634701
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--- Comment #6 from
https://bugzilla.redhat.com/show_bug.cgi?id=1636157
Neal Gompa changed:
What|Removed |Added
Status|NEW |POST
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1549011
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #4 from
https://bugzilla.redhat.com/show_bug.cgi?id=1634407
--- Comment #6 from Antonio Trande ---
- Dependencies (save some exception) are automatically resolved.
The 'Requires:' lines are not needed.
- With "BuildRequires: pkgconfig(libssh) <= 0.7.5" you can't currently build
this package on
https://bugzilla.redhat.com/show_bug.cgi?id=1558683
Sandhya Dasu changed:
What|Removed |Added
Flags|needinfo?(amoralej@redhat.c |
|om)
https://bugzilla.redhat.com/show_bug.cgi?id=1636157
Neal Gompa changed:
What|Removed |Added
CC||ngomp...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1554050
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1635340
Marek Skalický changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1558312
--- Comment #4 from Robert-André Mauchin ---
I'm sorry I have forgotten this review.
The problem I have with this is that you're distributing the end result instead
of building from the source with gulp.
You might need to package some gulp
https://bugzilla.redhat.com/show_bug.cgi?id=1634407
--- Comment #5 from Luis Segundo ---
Hi Antonio, I have updated the files
1- I removed the debug "%global debug_package %{nil}"
2 -I included the license
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1558683
Robert-André Mauchin changed:
What|Removed |Added
Flags||needinfo?(sad...@cisco.com)
https://bugzilla.redhat.com/show_bug.cgi?id=1558683
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1558976
--- Comment #4 from Robert-André Mauchin ---
Use the source and use Gulp in build, then install the whole.
Bump to the latest revision.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1562526
--- Comment #19 from Robert-André Mauchin ---
libfullock.x86_64: W: incoherent-version-in-changelog 1.0.27 ['1.0.27-1.fc27',
'1.0.27-1']
→ You need to add the release info in the %changelog too:
* Tue May 15 2018 Takeshi Nakatani
https://bugzilla.redhat.com/show_bug.cgi?id=1636169
--- Comment #4 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/libxmlb
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1565848
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1636169
--- Comment #3 from Richard Hughes ---
> Can you add ... in the right spots in the spec file please?
Done! Thanks for the super speedy review. I'm waiting for Paquire now.
--
You are receiving this mail because:
You are on the CC list for
https://bugzilla.redhat.com/show_bug.cgi?id=1636169
Kalev Lember changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #2 from
https://bugzilla.redhat.com/show_bug.cgi?id=1567819
--- Comment #10 from Robert-André Mauchin ---
(In reply to Pawel Stolowski from comment #9)
> (In reply to Neal Gompa from comment #8)
> > @Pawel, before I approve this review and sponsor you into the maintainers
> > group, I'd like you to do
https://bugzilla.redhat.com/show_bug.cgi?id=1570551
--- Comment #11 from Robert-André Mauchin ---
Run the command separatly, it will tell you why it's failing. Probably a
missing dep.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1575257
Robert-André Mauchin changed:
What|Removed |Added
CC||sas...@peilicke.de
https://bugzilla.redhat.com/show_bug.cgi?id=1576056
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1632502
Luis Bazan changed:
What|Removed |Added
Fixed In Version||python-lark-parser-0.6.4-1.
https://bugzilla.redhat.com/show_bug.cgi?id=1632502
Luis Bazan changed:
What|Removed |Added
Status|ON_QA |CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1636169
Kalev Lember changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1199693
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1632436
Miro Hrončok changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Fixed In Version|
https://bugzilla.redhat.com/show_bug.cgi?id=1476434
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1636101
Bug 1636101 depends on bug 1636098, which changed state.
Bug 1636098 Summary: Review Request: rust-delta_e - Pure-Rust implementation of
the CIEDE2000 algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1636098
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=1636098
Igor Gnatenko changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1636169
Bug ID: 1636169
Summary: Review Request: libxmlb - Library for querying
compressed XML metadata
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1636087
Bug 1636087 depends on bug 1636086, which changed state.
Bug 1636086 Summary: Review Request: rust-clang-sys - Rust bindings for libclang
https://bugzilla.redhat.com/show_bug.cgi?id=1636086
What|Removed |Added
https://bugzilla.redhat.com/show_bug.cgi?id=1636086
Igor Gnatenko changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1636111
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1632436
--- Comment #11 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-jeepney
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1636101
--- Comment #2 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-ansi_colours
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1634443
leigh scott changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #6 from
https://bugzilla.redhat.com/show_bug.cgi?id=1632436
Luis Bazan changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from
https://bugzilla.redhat.com/show_bug.cgi?id=1636098
--- Comment #2 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-delta_e
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1636101
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1636087
--- Comment #2 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-cexpr
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1636157
Bug ID: 1636157
Summary: Review Request: rust-bindgen - Automatically generates
Rust FFI bindings to C and C++ libraries
Product: Fedora
Version: rawhide
Component:
https://bugzilla.redhat.com/show_bug.cgi?id=1636098
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #12 from jiri vanek ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not contain duplicates in %files.
Note:
https://bugzilla.redhat.com/show_bug.cgi?id=1636086
--- Comment #2 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-clang-sys
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1636087
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #11 from jiri vanek ---
In gui, maaybe hsow path to the config files?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1635930
--- Comment #2 from Robert-André Mauchin ---
I forgot this:
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
Please detail what licenses cover which parts in a comment.
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1635340
--- Comment #7 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/mongo-cxx-driver-legacy
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1636086
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #10 from jiri vanek ---
There is a bug in the luncher:
cp $cpfile $PLUGIN_HOME
This always rewirte custom configuration. Please check for its existence before
copying! This is necessary for this review.
Simialrly, grep for
https://bugzilla.redhat.com/show_bug.cgi?id=1635340
--- Comment #6 from Marek Skalický ---
Thanks for the quick review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1635930
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #9 from Severin Gehwolf ---
(In reply to jiri vanek from comment #7)
> Are you sure with:
> mvn(com.sun:tools)
> being adde dautoagically?
The tools.jar from JDK 8 is in java-1.8.0-openjdk-devel. Since the package
requires it
https://bugzilla.redhat.com/show_bug.cgi?id=1636111
Bug ID: 1636111
Summary: Review Request: glyr - Glyr is a music related
metadata searchengine
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1635415
--- Comment #2 from Robert-André Mauchin ---
Thanks for the review!
1. /usr/share/color-schemes is not owned by this package, nor by any package
that it Requires.
Now owned by Plasma desktop
2. Can the files under /usr/share/Kvantum go
https://bugzilla.redhat.com/show_bug.cgi?id=1636101
Igor Gnatenko changed:
What|Removed |Added
Depends On||1636098 (rust-delta_e)
Referenced
https://bugzilla.redhat.com/show_bug.cgi?id=1636098
Igor Gnatenko changed:
What|Removed |Added
Blocks||1636101 (rust-ansi_colours)
https://bugzilla.redhat.com/show_bug.cgi?id=1636101
Bug ID: 1636101
Summary: Review Request: rust-ansi_colours - true-colour ↔ ANSI
terminal palette converter
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1636098
Bug ID: 1636098
Summary: Review Request: rust-delta_e - Pure-Rust
implementation of the CIEDE2000 algorithm
Product: Fedora
Version: rawhide
Component: Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #8 from jiri vanek ---
It do not build in rawhide. Restarting review with f29, but you will need to
fix it for rawhide.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #7 from jiri vanek ---
Are you sure with:
mvn(com.sun:tools)
being adde dautoagically?
I dont believe jrdc currently do support jdk11, so indeed,
Requires: java-devel >= 1:1.8.0
may be bad.
I'm not sure if = 1:1.8.0 is
https://bugzilla.redhat.com/show_bug.cgi?id=1150393
Robert-André Mauchin changed:
What|Removed |Added
CC||jkal...@redhat.com,
https://bugzilla.redhat.com/show_bug.cgi?id=1636087
Igor Gnatenko changed:
What|Removed |Added
Depends On||1636086 (rust-clang-sys)
Referenced
https://bugzilla.redhat.com/show_bug.cgi?id=1636086
Igor Gnatenko changed:
What|Removed |Added
Blocks||1636087 (rust-cexpr)
Referenced
https://bugzilla.redhat.com/show_bug.cgi?id=1636086
Bug ID: 1636086
Summary: Review Request: rust-clang-sys - Rust bindings for
libclang
Product: Fedora
Version: rawhide
Component: Package Review
Assignee:
https://bugzilla.redhat.com/show_bug.cgi?id=1636087
Bug ID: 1636087
Summary: Review Request: rust-cexpr - C expression parser and
evaluator
Product: Fedora
Version: rawhide
Component: Package Review
Assignee:
https://bugzilla.redhat.com/show_bug.cgi?id=1634443
--- Comment #5 from Robert-André Mauchin ---
Thanks for the review. I've fixed the inconsistent macro usage, the unowned lib
directory and added a Requires to kde-filesystem for owning the doc directories
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1635340
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #6 from Severin Gehwolf ---
A couple of observations:
Please run rpmlint on specs/RPMs.
Please use, "License: GPLv3"
Provides look strange:
mvn(java:decompiler-agent)
mvn(java:decompiler-agent:pom:)
https://bugzilla.redhat.com/show_bug.cgi?id=1615895
Jared Smith changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #5 from jiri vanek ---
Yup. those works.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #4 from Severin Gehwolf ---
Still doesn't seem quite right. Trying again:
Spec URL:
https://raw.githubusercontent.com/pmikova/fedora-packaging-jrd/master/java-runtime-decompiler.spec
SRPM URL:
1 - 100 of 118 matches
Mail list logo