Re: Code Folding in Code Mirror

[Sarah McAlear]

Ok, it does work for the cases defined. We misunderstood how it works.
Still, could we enable this everywhere? What is the reason not to?

Thanks,
Bing & Sarah

On Tue, Aug 15, 2017 at 5:00 PM, Sarah McAlear <smcal...@pivotal.io> wrote:

> Hi Hackers!
>
> We are working on unifying the CodeMirror stuff into one location. While
> looking at this we noticed that while there is logic for code folding, it
> doesn't seem to be working. Does it work for everyone else? We also started
> to wonder if there is a specific reason that code folding should be
> disabled anywhere? Would it not make more sense to have it look the same
> throughout pgAdmin? We understand that there are a few things that should
> be depending on the place in the app where it is used, such as 'editable'.
> Other than that, would it be acceptable to have the same configuration
> throughout?
>
> Thanks,
> Bing & Sarah
>

Code Folding in Code Mirror

[Sarah McAlear]

Hi Hackers!

We are working on unifying the CodeMirror stuff into one location. While
looking at this we noticed that while there is logic for code folding, it
doesn't seem to be working. Does it work for everyone else? We also started
to wonder if there is a specific reason that code folding should be
disabled anywhere? Would it not make more sense to have it look the same
throughout pgAdmin? We understand that there are a few things that should
be depending on the place in the app where it is used, such as 'editable'.
Other than that, would it be acceptable to have the same configuration
throughout?

Thanks,
Bing & Sarah

Re: [pgAdmin4][RM2586] Cleanup feature test

[Sarah McAlear]

Great job on cleaning up the whole feature test suite! This is really going
to benefit all of the developers a lot.

Thanks,
Matt & Sarah

On Fri, Aug 11, 2017 at 12:24 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached updated patch. In this patch I have removed unused
> imports.
> Regarding ajax calls on slow network/computer I have already taken care of
> those.
> Before sending first version of patch I tested this on Murtuza's machine
> and also
> tested on slow machine as well.
>
>
> Thanks,
> Harshal
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Aug 7, 2017 at 8:55 AM, Sarah McAlear <smcal...@pivotal.io> wrote:
>
>> Hi Harshal!
>>
>> There are a few files in which there are leftover imports that are not
>> needed anymore:
>>
>>- PGDataypeFeatureTest
>>- PgadminPage
>>- CheckForXssFeatureTest
>>- CheckDebuggerForXssFeatureTest
>>
>>
>> We also noticed that there were quite a few time.sleep functions that
>> were removed. This seems great overall, but we think that some of them were
>> in place because of varying network and computer speeds. So for example, in
>> QueryToolFeatureTest, there is an ajax call that was followed by a
>> time.sleep to ensure that it had finished executing before continuing to
>> execute. Removing this may reintroduce some flakiness. If there are no
>> issues with flakiness after this patch, it seems like a great idea. We ran
>> the tests a few times and didn't notice any flakiness, but we're unsure if
>> it will be a problem on a different system.
>>
>> Thanks!
>> Wenlin & Sarah
>>
>>
>> On Wed, Aug 2, 2017 at 9:32 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch to improve feature test execution time.
>>> Now on my machine overall execution time is cut down to 280 seconds from
>>> 400+ seconds
>>>
>>> Changes:
>>>
>>> 1. Removed fixed python time.sleeps where ever possible.
>>> 2. Removed connect to server test cases.
>>> 3. Query tool test cases:
>>>  i. Merged 3 test cases On demand result on scroll, grid select all
>>> and column select all.
>>>  ii. Merged 3 test cases Explain query, Explain query with verbose
>>> and Explain query with cost.
>>>  iii. Merged 3 test cases Explain analyze query, Explain
>>> analyze with buffers and Explain analyze with timing.
>>> 4. Improved debugger XSS test case execution time.
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Sarah McAlear]

Hi!

We fixed that issue and created a new patch
<https://www.postgresql.org/message-id/flat/CAGRPzo9wUDtYE2jFz-%3DPbJr%2Btf20zyFncdEoAFdVMkTgoXzf3w%40mail.gmail.com>
.

Thanks!

On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng <vch...@pivotal.io> wrote:

> Here's the Redmine link
>
> https://redmine.postgresql.org/issues/2644
>
> On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng <vch...@pivotal.io> wrote:
>
>> Hi Surinder!
>>
>> Are you referring to the green message popup? If so, it also appears to
>> be happening on master. We'll log a bug in our backlog and Redmine and
>> prioritize it. We agree that it needs to be fixed, but don't think it's
>> unrelated to this patch.
>>
>> Thanks!
>> Violet & Sarah
>>
>> On Thu, Aug 10, 2017 at 2:32 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Please find attached screenshot.
>>>
>>> On Thu, Aug 10, 2017 at 11:30 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
>>>> Hi Sarah,
>>>>
>>>> We noticed that due to this patch, the alert style of "Database
>>>> connected" message is changed.
>>>> Can you please look into this?
>>>>
>>>> Thanks,
>>>> Surinder
>>>>
>>>> On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar <
>>>> surinder.ku...@enterprisedb.com> wrote:
>>>>
>>>>> ​Hi,
>>>>>
>>>>> ​The updated patch looks good to me.
>>>>>
>>>>> On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear <smcal...@pivotal.io>
>>>>> wrote:
>>>>>
>>>>>> As discussed with Surinder, we have created a Redmine ticket for his
>>>>>> 4th comment regarding the error message not showing up when the app can't
>>>>>> be reached. This issue existed prior to this patch and should be
>>>>>> prioritized.
>>>>>>
>>>>>> https://redmine.postgresql.org/issues/2640
>>>>>>
>>>>>> Thanks!
>>>>>> Matt & Sarah
>>>>>>
>>>>>> On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear <smcal...@pivotal.io>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Surinder!
>>>>>>>
>>>>>>> I am not able to see anything different from what I see on Master
>>>>>>> with or without the patch applied. I tried adjusting the preferences. I 
>>>>>>> did
>>>>>>> update the dashboard.js to instantiate a new object, great idea!
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Sarah
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
>>>>>>> surinder.ku...@enterprisedb.com> wrote:
>>>>>>>
>>>>>>>> Hi Wenlin,
>>>>>>>>
>>>>>>>> On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang <wzh...@pivotal.io>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi Surinder,
>>>>>>>>>
>>>>>>>>>Thanks for your review.
>>>>>>>>>
>>>>>>>>>We have changed the indentation for _dashboard.scss file and
>>>>>>>>> also removed the style about icon-postgres:before, like
>>>>>>>>> margin-top,etc, but we are not sure if it is perfectly aligned now, 
>>>>>>>>> you can
>>>>>>>>> add further change to it.
>>>>>>>>>
>>>>>>>>> As the second comment, I'm sorry I'm not sure what's the
>>>>>>>>> problem, could you please clarify it? Because we replace css with scss
>>>>>>>>> right now, dashboard.css doesn't exist. So maybe you are looking at 
>>>>>>>>> the css
>>>>>>>>> file that are complied by the scss?
>>>>>>>>>
>>>>>>>> ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
>>>>>>>> ​In dashboard.js can we change `return DashboardAlert;` to `return
>>>>>>>> new DashboardAlert();`
>>>>>>>> and then we can remove the instances bei

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Sarah McAlear]

As discussed with Surinder, we have created a Redmine ticket for his 4th
comment regarding the error message not showing up when the app can't be
reached. This issue existed prior to this patch and should be prioritized.

https://redmine.postgresql.org/issues/2640

Thanks!
Matt & Sarah

On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear <smcal...@pivotal.io> wrote:

> Hi Surinder!
>
> I am not able to see anything different from what I see on Master with or
> without the patch applied. I tried adjusting the preferences. I did update
> the dashboard.js to instantiate a new object, great idea!
>
> Thanks,
> Sarah
>
>
>
> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Wenlin,
>>
>> On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang <wzh...@pivotal.io> wrote:
>>
>>> Hi Surinder,
>>>
>>>Thanks for your review.
>>>
>>>We have changed the indentation for _dashboard.scss file and also
>>> removed the style about icon-postgres:before, like margin-top,etc, but
>>> we are not sure if it is perfectly aligned now, you can add further change
>>> to it.
>>>
>>> As the second comment, I'm sorry I'm not sure what's the problem,
>>> could you please clarify it? Because we replace css with scss right now,
>>> dashboard.css doesn't exist. So maybe you are looking at the css file that
>>> are complied by the scss?
>>>
>> ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
>> ​In dashboard.js can we change `return DashboardAlert;` to `return new
>> DashboardAlert();`
>> and then we can remove the instances being created(var alertDashboard =
>> new AlertDashboard();) from dashboard.js, and simply
>> use `AlertDashboard.info('message')`.
>>
>>
>>> For the fourth comment, we tried the steps you suggested on master
>>> branch, the error is not shown either. So it should be an existing issue.
>>> But if you want to see the error message, navigate to "Servers" at the top
>>> of browser, then navigate back to postgresql server, then you will see the
>>> error message.
>>>
>> ​The error in console will appear when you selected a database which is
>> connected and stop the backend Python server because the request for graphs
>> for database level will fail and there is no response returned from server.
>> It might be not reproducible to you If you set the refresh rate to higher
>> value (i.e. Preferences > Graphs) in preferences. Just set refresh rate to
>> 1 for all dashboard graphs and repeat the steps.
>>
>>>
>>>
>>> Thanks,
>>>
>>> Wenlin 
>>>
>>>
>>>
>>> On Mon, Aug 7, 2017 at 2:30 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
>>>> Hi
>>>> Review comments:
>>>>
>>>>1.
>>>>
>>>>For consistency, we use two spaces for indentation in CSS files.
>>>>Four spaces are used in _dashboard.scss file. The configurations
>>>>are defined in web/.editorconfig file.
>>>>2.
>>>>
>>>>In,dashboard.css Can we return function object in return instead of
>>>>function class itself, this will eliminate the need of creating function
>>>>object every time we use info and error?
>>>>3.
>>>>
>>>>On Dashboard, I can see Postgres icon is misaligned compared to
>>>>other icons in Getting Started section. It is not related to this
>>>>patch. adjusting margin top will fix it.
>>>>4.
>>>>
>>>>I tried to test out Error message displayed, but I encounter an
>>>>error(screenshot attached).
>>>>Steps to reproduce:
>>>>   - Open pgAdmin4 in browser
>>>>   - Connect to PostgreSQL Server, Keep dashboard tab open.
>>>>   - Navigate to the database which is connected.
>>>>   - Now disconnect pgAdmin4 python server.
>>>>   ​
>>>>
>>>> ​Here I mean Stop Python server. I​
>>
>>
>>>
>>>>1.
>>>>   - ​
>>>>   - No error message is displayed on Dashboard because it breaks
>>>>   in JS as xhr.responseText is empty.
>>>>   However, it might be an existing issue.
>>>>
>>>> Thanks,
>>>> Surinder
>>>>
>>>> On Mon, Aug 7, 

Re: [pgadmin4] unable to pull remote

[Sarah McAlear]

Hi!

Yes, this did fix it for us, but we did use https instead.

Thanks!
Matt & Sarah

On Wed, Aug 9, 2017 at 6:19 PM, Magnus Hagander <mag...@hagander.net> wrote:

> Hi!
>
> Did that actually fix it?
>
> I've noticed a couple of other jobs complaining about the git server, but
> so far I was under the impression that it was a specific upstream network
> that had issues. BUt if switching to http fixed it, then that's not it, and
> I have something else to investigate.
>
> Also as a note -- it should be https and not http. If you use http it will
> generate redirects so it will work, but you both miss out on the security
> and will get lower performance because it will be more requests.
>
> //Magnus
>
>
> On Wed, Aug 9, 2017 at 11:30 AM, Sarah McAlear <smcal...@pivotal.io>
> wrote:
>
>> Great, thank you!
>>
>> On Wed, Aug 9, 2017 at 5:26 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> hi
>>>
>>> Change below url in your git config
>>> from *git://git.postgresql.org/git/pgadmin4.git
>>> <http://git.postgresql.org/git/pgadmin4.git>* to  
>>> *http://git.postgresql.org/git/pgadmin4.git
>>> <http://git.postgresql.org/git/pgadmin4.git>*
>>>
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Wed, Aug 9, 2017 at 2:39 PM, Sarah McAlear <smcal...@pivotal.io>
>>> wrote:
>>>
>>>> Hi Hackers!
>>>>
>>>> We noticed that as of some time today (it worked this morning) we are
>>>> unable to pull git.postgresql.org/git/pgadmin4.git. Is this a known
>>>> issue? Our other repos seem to work fine still.
>>>>
>>>> Thanks,
>>>> Sarah
>>>>
>>>
>>>
>>
>
>
> --
>  Magnus Hagander
>  Me: https://www.hagander.net/ <http://www.hagander.net/>
>  Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
>

Re: [pgadmin4] unable to pull remote

[Sarah McAlear]

Great, thank you!

On Wed, Aug 9, 2017 at 5:26 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> hi
>
> Change below url in your git config
> from *git://git.postgresql.org/git/pgadmin4.git
> <http://git.postgresql.org/git/pgadmin4.git>* to  
> *http://git.postgresql.org/git/pgadmin4.git
> <http://git.postgresql.org/git/pgadmin4.git>*
>
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Aug 9, 2017 at 2:39 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
>
>> Hi Hackers!
>>
>> We noticed that as of some time today (it worked this morning) we are
>> unable to pull git.postgresql.org/git/pgadmin4.git. Is this a known
>> issue? Our other repos seem to work fine still.
>>
>> Thanks,
>> Sarah
>>
>
>

[pgadmin4] unable to pull remote

[Sarah McAlear]

Hi Hackers!

We noticed that as of some time today (it worked this morning) we are
unable to pull git.postgresql.org/git/pgadmin4.git. Is this a known issue?
Our other repos seem to work fine still.

Thanks,
Sarah

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Sarah McAlear]

Hi Surinder!

I am not able to see anything different from what I see on Master with or
without the patch applied. I tried adjusting the preferences. I did update
the dashboard.js to instantiate a new object, great idea!

Thanks,
Sarah



On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi Wenlin,
>
> On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang <wzh...@pivotal.io> wrote:
>
>> Hi Surinder,
>>
>>Thanks for your review.
>>
>>We have changed the indentation for _dashboard.scss file and also
>> removed the style about icon-postgres:before, like margin-top,etc, but
>> we are not sure if it is perfectly aligned now, you can add further change
>> to it.
>>
>> As the second comment, I'm sorry I'm not sure what's the problem,
>> could you please clarify it? Because we replace css with scss right now,
>> dashboard.css doesn't exist. So maybe you are looking at the css file that
>> are complied by the scss?
>>
> ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
> ​In dashboard.js can we change `return DashboardAlert;` to `return new
> DashboardAlert();`
> and then we can remove the instances being created(var alertDashboard =
> new AlertDashboard();) from dashboard.js, and simply
> use `AlertDashboard.info('message')`.
>
>
>> For the fourth comment, we tried the steps you suggested on master
>> branch, the error is not shown either. So it should be an existing issue.
>> But if you want to see the error message, navigate to "Servers" at the top
>> of browser, then navigate back to postgresql server, then you will see the
>> error message.
>>
> ​The error in console will appear when you selected a database which is
> connected and stop the backend Python server because the request for graphs
> for database level will fail and there is no response returned from server.
> It might be not reproducible to you If you set the refresh rate to higher
> value (i.e. Preferences > Graphs) in preferences. Just set refresh rate to
> 1 for all dashboard graphs and repeat the steps.
>
>>
>>
>> Thanks,
>>
>> Wenlin 
>>
>>
>>
>> On Mon, Aug 7, 2017 at 2:30 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>> Review comments:
>>>
>>>1.
>>>
>>>For consistency, we use two spaces for indentation in CSS files.
>>>Four spaces are used in _dashboard.scss file. The configurations are
>>>defined in web/.editorconfig file.
>>>2.
>>>
>>>In,dashboard.css Can we return function object in return instead of
>>>function class itself, this will eliminate the need of creating function
>>>object every time we use info and error?
>>>3.
>>>
>>>On Dashboard, I can see Postgres icon is misaligned compared to
>>>other icons in Getting Started section. It is not related to this
>>>patch. adjusting margin top will fix it.
>>>4.
>>>
>>>I tried to test out Error message displayed, but I encounter an
>>>error(screenshot attached).
>>>Steps to reproduce:
>>>   - Open pgAdmin4 in browser
>>>   - Connect to PostgreSQL Server, Keep dashboard tab open.
>>>   - Navigate to the database which is connected.
>>>   - Now disconnect pgAdmin4 python server.
>>>   ​
>>>
>>> ​Here I mean Stop Python server. I​
>
>
>>
>>>1.
>>>   - ​
>>>   - No error message is displayed on Dashboard because it breaks in
>>>   JS as xhr.responseText is empty.
>>>   However, it might be an existing issue.
>>>
>>> Thanks,
>>> Surinder
>>>
>>> On Mon, Aug 7, 2017 at 10:40 AM, Wenlin Zhang <wzh...@pivotal.io> wrote:
>>>
>>> Hi Ashesh,
>>>>
>>>> That's correct. This patch just changed alert style in the 'tabs',
>>>> such as Dependency and Dependents.
>>>>
>>>> Thanks
>>>>
>>>> Wenlin
>>>>
>>>> On Mon, Aug 7, 2017 at 12:51 PM, Ashesh Vashi <
>>>> ashesh.va...@enterprisedb.com> wrote:
>>>>
>>>>> Surinder,
>>>>>
>>>>> Please take a look at this patch.
>>>>>
>>>>> If I recalls correctly, this patch is related to styling of the 'tabs'
>>>>> shown on the main window.
>>>>> Wenlin - please correct me if my unders

Re: [pgAdmin4][patch] Fix feature tests failure

[Sarah McAlear]

Hi Hackers!

Could someone review this patch, please?

Thanks so much!
Sarah

On Mon, Aug 7, 2017 at 4:42 PM, Wenlin Zhang  wrote:

> Hi Hackers,
>
> This patch is about fixing the feature tests failure.
>
> Thanks,
> Wenlin, Violet & Hao
>

Re: [pgAdmin4][RM2586] Cleanup feature test

[Sarah McAlear]

Hi Harshal!

There are a few files in which there are leftover imports that are not
needed anymore:

   - PGDataypeFeatureTest
   - PgadminPage
   - CheckForXssFeatureTest
   - CheckDebuggerForXssFeatureTest


We also noticed that there were quite a few time.sleep functions that were
removed. This seems great overall, but we think that some of them were in
place because of varying network and computer speeds. So for example, in
QueryToolFeatureTest, there is an ajax call that was followed by a
time.sleep to ensure that it had finished executing before continuing to
execute. Removing this may reintroduce some flakiness. If there are no
issues with flakiness after this patch, it seems like a great idea. We ran
the tests a few times and didn't notice any flakiness, but we're unsure if
it will be a problem on a different system.

Thanks!
Wenlin & Sarah


On Wed, Aug 2, 2017 at 9:32 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch to improve feature test execution time.
> Now on my machine overall execution time is cut down to 280 seconds from
> 400+ seconds
>
> Changes:
>
> 1. Removed fixed python time.sleeps where ever possible.
> 2. Removed connect to server test cases.
> 3. Query tool test cases:
>  i. Merged 3 test cases On demand result on scroll, grid select all
> and column select all.
>  ii. Merged 3 test cases Explain query, Explain query with verbose and
> Explain query with cost.
>  iii. Merged 3 test cases Explain analyze query, Explain analyze with
> buffers and Explain analyze with timing.
> 4. Improved debugger XSS test case execution time.
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Sarah McAlear]

Hi hackers,

Could you please review this patch?

Thanks

Wenlin and Sarah

On Wed, Aug 2, 2017 at 2:15 PM, Wenlin Zhang  wrote:

> Hi Hackers,
>
> This patch changes the alert style in the sub-navigation to match style
> guide.
>
> Thanks,
> Wenlin, Shirley & Sarah
>
>
>

Re: Discussion on improving alertify notifications logic

[Sarah McAlear]

Hi Akshay!

That seems like a good idea. When we're using the extended
pgadmin.alerrtify in the codebase it would be beneficial to call it
pgAdminAlertify or something similar so that it is clear that it isn't only
the alertify library, but it's been extended.

Rob & Sarah

On Thu, Jul 27, 2017 at 9:41 PM, Akshay Joshi  wrote:

> Hi All
>
> As in commit "Update alertify alerts to use the styling defined in
> the style guide":
>
> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=
> 2a30a86e7d5e562040500f448fbb0d143ff2cff9
>
> https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=
> f2d2075d81718ec02550fb592851aa330d327b24
>
> We have introduce new wrapper class "AlertifyWrapper" and replace calls
> to alertify.success and alertify.error with following two lines in most
> of the files
>
> var alertifyWrapper = new AlertifyWrapper();
>
> alertifyWrapper.success(message);  or  alertifyWrapper.error(message);
>
> For each call we are creating dynamic object of AlertifyWrapper and call
> the appropriate function. For example there are 20 such calls in a single
> js file every time are are creating object and call appropriate function.
>
>
> I have tried to improve the logic here and implemented it as below:
>
>- Extend alertify and move success, error and info functions from "
>alertify_wrapper.js" file to "alertify.pgadmin.defaults.js", there
>will be no use of "alertify_wrapper.js"
>- Modify only "server.js" as POC, remove 'alertify' and replace
>'sources/alerts/alertify_wrapper' with 'pgadmin.alertifyjs' which is
>nothing but mapping of "alertify.pgadmin.defaults.js" from defines and
>named the reference object to 'alertify' so no need to change any function
>call like "alertify.success, alertify.error".
>
> One more benefit of the above approach is if in future we want to use the
> same style for alertify.warning, alertify.info, alertify.message etc..,
> we will just have to extend that method in "alertify.pgadmin.defaults.js"
> and no need to change the rest of the function call with AlertifyWrapper.
>
>
> Attached is the POC patch, if it looks good then I'll start working on
> replacing AlertifyWrapper with the above mentioned approach.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Sarah McAlear]

Hi!

We looked at the patch and realized that the function to check if an
element is not clickable because it's out of view was using an incorrect
assertion. We changed it and created a small patch. We also realized that
on the current master the yarn.lock is causing changes when running the
app. It looks like maybe eclint was added to package.json and it and its
corresponding dependencies were not added to the checked in yarn.lock file.

Thanks,
Shruti & Sarah



On Fri, Jul 21, 2017 at 4:09 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Robert,
>
> I mean rather than using cmd key for Mac and CTRL key for Windows/Linux, I
> used "CTRL" key for all the platforms.
> And regarding choosing comma & period keys, they all are near each to each
> other so user can remember them easily.
>
> Let me know If my thinking was wrong for shortcut keys, I'll change them
> accordingly and send new patch.
>
> On Fri, Jul 21, 2017 at 4:25 PM, Robert Eckhardt 
> wrote:
>
>> I'm not sure what you mean by across platforms.  Do you mean that those
>> are the keyboard shortcuts in pgAdmin 3?
>>
>> Rob
>>
>> On Jul 21, 2017 4:42 AM, "Murtuza Zabuawala" <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>> Hi Robert,
>>
>> Just to make shortcut keys uniform across all the platforms.
>>
>> On Fri, Jul 21, 2017 at 1:25 AM, Robert Eckhardt 
>> wrote:
>>
>>> Murtuza,
>>>
>>> Is there a particular reason you choose the keyboard shortcuts that you
>>> choose. When we were looking at this earlier to see what was being used
>>> elsewhere we discovered:
>>>
>>> jetbrains  cmd+/
>>> pycharmcmd+/
>>> SublimeCtrl+/ Toggle line comment
>>>Ctrl+Shift+/ Toggle block comment
>>> EclipseCTRL + /
>>> Notepad++  CTRL+Q   Toggle line comment
>>>CTRL+SHIFT+Q Toggle block comment
>>> TextWrangler   Ctrl+/
>>>
>>> -- Rob
>>>
>>>
>>> On Thu, Jul 20, 2017 at 1:05 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>

 On Thu, Jul 20, 2017 at 10:29 PM, Dave Page  wrote:

> Hi
>
> On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find patch attached, There were two issues,
>> 1) We removed the default button to clear the editor window, it
>> broke _clear_query_tool() functionality.
>> 2) The buttons arrangements, we added new Edit button in between
>> Delete and Filter button causing the "Explain" -> "Explain Options" sub
>> menu to go out of browser visibility in feature test, so it was failing.
>>
>> I have put Edit button near Clear button for now, until we come up
>> with new design for our editor for displaying these options.
>>
>
> Hmm, I moved it there intentionally as it's a more traditional
> position and thus more discoverable.
>
> Can we just launch the browser with a wider size, say, 1280? It's on
> line 43 of app_starter.py...
>
>
 Yes, that will work too.

>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Jul 20, 2017 at 6:04 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> I am working on this, will send you patch soon.
>>>
>>> On Thu, Jul 20, 2017 at 5:53 PM, Dave Page 
>>> wrote:
>>>
 Did you get a chance to look at this yet Murtuza?

 On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Sure, Will take a look.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jul 19, 2017 at 8:00 PM, Dave Page 
> wrote:
>
>> Except I managed to break a couple of tests :-(. Can you take a
>> look please? I've had some other work come up that I need to deal 
>> with.
>>
>> 
>> ==
>> ERROR: runTest (pgadmin.feature_tests.query_t
>> ool_journey_test.QueryToolJourneyTest)
>> Tests the path through the query tool
>> 
>> --
>> Traceback (most recent call last):
>>   File "/Users/dpage/git/pgadmin4/web
>> /pgadmin/feature_tests/query_tool_journey_test.py", line 45, in
>> runTest
>> self._test_history_tab()
>>   File "/Users/dpage/git/pgadmin4/web
>> /pgadmin/feature_tests/query_tool_journey_test.py", line 71, in
>> 

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Sarah McAlear]

Hello,

Attached is a refactor that extracts the keyAction function in the sqlEditor
and placed it into a keyboard_shortcuts file. The extracted code is unit
tested. I did not look at the feature tests.

We are planning on diving into it a bit more but maybe not immediately. Up
next we will be pulling out the implementations of the functions that were
being triggered in the keyAction function.

-- Sarah





On Thu, Jul 20, 2017 at 12:55 PM, Robert Eckhardt 
wrote:

> Murtuza,
>
> Is there a particular reason you choose the keyboard shortcuts that you
> choose. When we were looking at this earlier to see what was being used
> elsewhere we discovered:
>
> jetbrains  cmd+/
> pycharmcmd+/
> SublimeCtrl+/ Toggle line comment
>Ctrl+Shift+/ Toggle block comment
> EclipseCTRL + /
> Notepad++  CTRL+Q   Toggle line comment
>CTRL+SHIFT+Q Toggle block comment
> TextWrangler   Ctrl+/
>
> -- Rob
>
>
> On Thu, Jul 20, 2017 at 1:05 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>>
>> On Thu, Jul 20, 2017 at 10:29 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Please find patch attached, There were two issues,
 1) We removed the default button to clear the editor window, it
 broke _clear_query_tool() functionality.
 2) The buttons arrangements, we added new Edit button in between Delete
 and Filter button causing the "Explain" -> "Explain Options" sub menu to go
 out of browser visibility in feature test, so it was failing.

 I have put Edit button near Clear button for now, until we come up with
 new design for our editor for displaying these options.

>>>
>>> Hmm, I moved it there intentionally as it's a more traditional position
>>> and thus more discoverable.
>>>
>>> Can we just launch the browser with a wider size, say, 1280? It's on
>>> line 43 of app_starter.py...
>>>
>>>
>> Yes, that will work too.
>>
>>>

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Thu, Jul 20, 2017 at 6:04 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> I am working on this, will send you patch soon.
>
> On Thu, Jul 20, 2017 at 5:53 PM, Dave Page  wrote:
>
>> Did you get a chance to look at this yet Murtuza?
>>
>> On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Sure, Will take a look.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Wed, Jul 19, 2017 at 8:00 PM, Dave Page 
>>> wrote:
>>>
 Except I managed to break a couple of tests :-(. Can you take a
 look please? I've had some other work come up that I need to deal with.

 
 ==
 ERROR: runTest (pgadmin.feature_tests.query_t
 ool_journey_test.QueryToolJourneyTest)
 Tests the path through the query tool
 
 --
 Traceback (most recent call last):
   File 
 "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
 line 45, in runTest
 self._test_history_tab()
   File 
 "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
 line 71, in _test_history_tab
 self.__clear_query_tool()
   File 
 "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
 line 91, in __clear_query_tool
 self.page.click_element(self.page.find_by_xpath("//*[@id='bt
 n-edit']"))
   File 
 "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
 line 148, in find_by_xpath
 return self.wait_for_element(lambda driver:
 driver.find_element_by_xpath(xpath))
   File 
 "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
 line 232, in wait_for_element
 return self._wait_for("element to exist", element_if_it_exists)
   File 
 "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
 line 282, in _wait_for
 "Timed out waiting for " + waiting_for_message)
   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa
 ges/selenium/webdriver/support/wait.py", line 80, in until
 raise TimeoutException(message, screen, stacktrace)

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

[Sarah McAlear]

Hi Surinder & Murtuza!

We are actually working on that right now. We should be sending a patch
soon.

Thanks!
Shruti & Sarah

On Thu, Jul 20, 2017 at 7:52 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi Murtuza,
>
> Can the code related to Menu KeyEvents be moved out into a separate file
> say 'menu_actions.js' if feasible ?
>
> As the more functionality will be added to sqleditor, codemirror and its
> file menu in future, the codebase will eventually increase.
> It will ease writing jasmine test cases as well.
>
> Thanks,
> Surinder
>
> On Thu, Jul 20, 2017 at 8:03 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find patch attached, There were two issues,
>> 1) We removed the default button to clear the editor window, it
>> broke _clear_query_tool() functionality.
>> 2) The buttons arrangements, we added new Edit button in between Delete
>> and Filter button causing the "Explain" -> "Explain Options" sub menu to go
>> out of browser visibility in feature test, so it was failing.
>>
>> I have put Edit button near Clear button for now, until we come up with
>> new design for our editor for displaying these options.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Jul 20, 2017 at 6:04 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> I am working on this, will send you patch soon.
>>>
>>> On Thu, Jul 20, 2017 at 5:53 PM, Dave Page  wrote:
>>>
 Did you get a chance to look at this yet Murtuza?

 On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Sure, Will take a look.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jul 19, 2017 at 8:00 PM, Dave Page  wrote:
>
>> Except I managed to break a couple of tests :-(. Can you take a look
>> please? I've had some other work come up that I need to deal with.
>>
>> 
>> ==
>> ERROR: runTest (pgadmin.feature_tests.query_t
>> ool_journey_test.QueryToolJourneyTest)
>> Tests the path through the query tool
>> 
>> --
>> Traceback (most recent call last):
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
>> line 45, in runTest
>> self._test_history_tab()
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
>> line 71, in _test_history_tab
>> self.__clear_query_tool()
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
>> line 91, in __clear_query_tool
>> self.page.click_element(self.page.find_by_xpath("//*[@id='bt
>> n-edit']"))
>>   File 
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>> line 148, in find_by_xpath
>> return self.wait_for_element(lambda driver:
>> driver.find_element_by_xpath(xpath))
>>   File 
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>> line 232, in wait_for_element
>> return self._wait_for("element to exist", element_if_it_exists)
>>   File 
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>> line 282, in _wait_for
>> "Timed out waiting for " + waiting_for_message)
>>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa
>> ges/selenium/webdriver/support/wait.py", line 80, in until
>> raise TimeoutException(message, screen, stacktrace)
>> TimeoutException: Message: Timed out waiting for element to exist
>>
>>
>> 
>> ==
>> ERROR: runTest (pgadmin.feature_tests.query_t
>> ool_tests.QueryToolFeatureTest)
>> Query tool feature test
>> 
>> --
>> Traceback (most recent call last):
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>> line 52, in runTest
>> self._clear_query_tool()
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>> line 173, in _clear_query_tool
>> self.page.find_by_id("btn-edit").click()
>>   File 
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
>> line 151, in find_by_id
>> return self.wait_for_element(lambda driver:
>> driver.find_element_by_id(element_id))
>>   File 
>> 

Re: [PATCH] Persist opened nodes in tree

[Sarah McAlear]

Hello,

In order to save everything in the backend sqlite database, maybe a jQuery
plugin needs to be developed that has the same interface as jStorage and
that will do Ajax calls instead of using the Local Storage.
The only caveat for this is that it needs to be registered in window.
$.jStorage in order to replace the one in place.

João & Sarah



On Tue, Jul 18, 2017 at 5:30 AM, Dave Page  wrote:

> Hi
>
> This would be a welcome feature addition, but why not store the treeview
> state in the configuration database? I'd prefer not to add another storage
> mechanism without a very compelling reason.
>
> If you need info on how it works, please feel free to ask questions.
>
> Thanks.
>
> On Tue, Jul 18, 2017 at 9:42 AM, Versus Void  wrote:
>
>> ---
>>  web/pgadmin/browser/__init__.py|  13 +-
>>  .../browser/static/vendor/jStorage/jstorage.js | 996
>> +
>>  .../browser/static/vendor/jStorage/jstorage.min.js |  16 +
>>  .../browser/templates/browser/js/browser.js|   6 +-
>>  4 files changed, 1029 insertions(+), 2 deletions(-)
>>  create mode 100644 web/pgadmin/browser/static/ven
>> dor/jStorage/jstorage.js
>>  create mode 100644 web/pgadmin/browser/static/ven
>> dor/jStorage/jstorage.min.js
>>
>> diff --git a/web/pgadmin/browser/__init__.py
>> b/web/pgadmin/browser/__init__.py
>> index 77e052f0..ecf3afba 100644
>> --- a/web/pgadmin/browser/__init__.py
>> +++ b/web/pgadmin/browser/__init__.py
>> @@ -100,13 +100,24 @@ class BrowserModule(PgAdminModule):
>>  'preloaded': True
>>  })
>>  scripts.append({
>> +'name': 'jStorage',
>> +'path': url_for(
>> +'browser.static',
>> +filename='vendor/jStorage/jstorage' if
>> +current_app.debug else 'vendor/jStorage/jstorage.min'
>> +),
>> +'deps': ['jquery'],
>> +'exports': 'jStorage',
>> +'preloaded': True
>> +})
>> +scripts.append({
>>  'name': 'jquery.acitree',
>>  'path': url_for(
>>  'browser.static',
>>  filename='vendor/aciTree/jquery.aciTree' if
>>  current_app.debug else 'vendor/aciTree/jquery.aciTree
>> .min'
>>  ),
>> -'deps': ['jquery', 'jquery.aciplugin'],
>> +'deps': ['jquery', 'jquery.aciplugin', 'jStorage'],
>>  'exports': 'aciPluginClass.plugins.aciTree',
>>  'preloaded': True
>>  })
>> diff --git a/web/pgadmin/browser/static/vendor/jStorage/jstorage.js
>> b/web/pgadmin/browser/static/vendor/jStorage/jstorage.js
>> new file mode 100644
>> index ..1ac8fccc
>> --- /dev/null
>> +++ b/web/pgadmin/browser/static/vendor/jStorage/jstorage.js
>> @@ -0,0 +1,996 @@
>> +/*
>> + * - JSTORAGE --
>> ---
>> + * Simple local storage wrapper to save data on the browser side,
>> supporting
>> + * all major browsers - IE6+, Firefox2+, Safari4+, Chrome4+ and Opera
>> 10.5+
>> + *
>> + * Author: Andris Reinman, andris.rein...@gmail.com
>> + * Project homepage: www.jstorage.info
>> + *
>> + * Licensed under Unlicense:
>> + *
>> + * This is free and unencumbered software released into the public
>> domain.
>> + *
>> + * Anyone is free to copy, modify, publish, use, compile, sell, or
>> + * distribute this software, either in source code form or as a compiled
>> + * binary, for any purpose, commercial or non-commercial, and by any
>> + * means.
>> + *
>> + * In jurisdictions that recognize copyright laws, the author or authors
>> + * of this software dedicate any and all copyright interest in the
>> + * software to the public domain. We make this dedication for the benefit
>> + * of the public at large and to the detriment of our heirs and
>> + * successors. We intend this dedication to be an overt act of
>> + * relinquishment in perpetuity of all present and future rights to this
>> + * software under copyright law.
>> + *
>> + * THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
>> + * IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + *
>> + * For more information, please refer to 
>> + */
>> +
>> +/* global ActiveXObject: false */
>> +/* jshint browser: true */
>> +
>> +(function() {
>> +'use strict';
>> +
>> +var
>> +/* jStorage version */
>> +JSTORAGE_VERSION = '0.4.12',
>> +
>> +/* detect a dollar object or create one if not found */
>> +$ = window.jQuery || window.$ || (window.$ = {}),

[pgadmin4][patch] fix history panel on ie11

[Sarah McAlear]

Hi Hackers!

This patch fixes the layout issues on IE11. There is a known issue on
react-split-pane that requires a previous version of bowser in order to
render correctly on IE11. We had to downgrade the version of bowser to
1.6.1 until the relevant pull request to react-split-pane has been accepted.

Thanks!
Sarah & Rob
diff --git a/web/package.json b/web/package.json
index 0082d95e..8b2ccf5c 100644
--- a/web/package.json
+++ b/web/package.json
@@ -34,6 +34,7 @@
 "babel-polyfill": "^6.23.0",
 "babel-preset-es2015-without-strict": "~0.0.4",
 "babelify": "~7.3.0",
+"bowser": "1.6.1",
 "browserify": "~14.1.0",
 "exports-loader": "~0.6.4",
 "immutability-helper": "^2.2.0",
diff --git a/web/yarn.lock b/web/yarn.lock
index 9f091992..afe871da 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -864,9 +864,9 @@ boom@2.x.x:
   dependencies:
 hoek "2.x.x"
 
-bowser@^1.6.0:
-  version "1.7.0"
-  resolved 
"https://registry.yarnpkg.com/bowser/-/bowser-1.7.0.tgz#169de4018711f994242bff9a8009e77a1f35e003;
+bowser@1.6.1, bowser@^1.6.0:
+  version "1.6.1"
+  resolved 
"https://registry.yarnpkg.com/bowser/-/bowser-1.6.1.tgz#9157e9498f456e937173a2918f3b2161e5353eb3;
 
 brace-expansion@^1.1.7:
   version "1.1.8"

[pgadmin-hackers][pgAdmin4][Patch] Make karma test results output to browser

[Sarah McAlear]

Hi Hackers!

Attached is a minor patch that enables pretty html output of our karma test
results. While running yarn test:karma, visit localhost:9876/debug.html to
see test output.

Thanks,
Matt and Sarah
diff --git a/web/karma.conf.js b/web/karma.conf.js
index 39697ca7..e9b0e062 100644
--- a/web/karma.conf.js
+++ b/web/karma.conf.js
@@ -5,6 +5,7 @@ const webpackConfig = require('./webpack.test.config.js');
 module.exports = function (config) {
   config.set({
 frameworks: ['jasmine'],
+reporters: ['progress', 'kjhtml'],
 plugins: [
   'karma-webpack',
   'karma-phantomjs-launcher',
diff --git a/web/package.json b/web/package.json
index 0082d95e..41852e0b 100644
--- a/web/package.json
+++ b/web/package.json
@@ -16,7 +16,7 @@
 "karma-babel-preprocessor": "^6.0.1",
 "karma-browserify": "~5.1.1",
 "karma-jasmine": "~1.1.0",
-"karma-jasmine-html-reporter": "~0.2.2",
+"karma-jasmine-html-reporter": "^0.2.2",
 "karma-phantomjs-launcher": "~1.0.2",
 "karma-requirejs": "~1.1.0",
 "karma-sourcemap-loader": "~0.3.7",
diff --git a/web/yarn.lock b/web/yarn.lock
index 9f091992..b5363de6 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -1439,16 +1439,16 @@ crypto-browserify@^3.0.0, crypto-browserify@^3.11.0:
 public-encrypt "^4.0.0"
 randombytes "^2.0.0"
 
+css-color-names@0.0.4:
+  version "0.0.4"
+  resolved 
"https://registry.yarnpkg.com/css-color-names/-/css-color-names-0.0.4.tgz#808adc2e79cf84738069b646cb20ec27beb629e0;
+
 css-in-js-utils@^1.0.3:
   version "1.0.3"
   resolved 
"https://registry.yarnpkg.com/css-in-js-utils/-/css-in-js-utils-1.0.3.tgz#9ac7e02f763cf85d94017666565ed68a5b5f3215;
   dependencies:
 hyphenate-style-name "^1.0.2"
 
-css-color-names@0.0.4:
-  version "0.0.4"
-  resolved 
"https://registry.yarnpkg.com/css-color-names/-/css-color-names-0.0.4.tgz#808adc2e79cf84738069b646cb20ec27beb629e0;
-
 css-loader@^0.28.4:
   version "0.28.4"
   resolved 
"https://registry.yarnpkg.com/css-loader/-/css-loader-0.28.4.tgz#6cf3579192ce355e8b38d5f42dd7a1f2ec898d0f;
@@ -3061,7 +3061,7 @@ karma-browserify@~5.1.1:
 minimatch "^3.0.0"
 os-shim "^0.1.3"
 
-karma-jasmine-html-reporter@~0.2.2:
+karma-jasmine-html-reporter@^0.2.2:
   version "0.2.2"
   resolved 
"https://registry.yarnpkg.com/karma-jasmine-html-reporter/-/karma-jasmine-html-reporter-0.2.2.tgz#48a8e5ef18807617ee2b5e33c1194c35b439524c;
   dependencies:

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

[Sarah McAlear]

Hello!

Thank you for committing the patch!

We are currently looking into CEF (
https://bitbucket.org/chromiumembedded/cef) as an alternative to QTWebKit.
So far it looks promising. It works on all platforms. It is the base for
Google Chrome, so it should be maintained for some time to come. Version 60
is currently in development. At this point we are developing a prototype
for Mac as a proof of concept. We will keep you posted as we go.

We are able to launch the server in one terminal and launch our browser app
in another and use pgAdmin from that app.

It would be useful to have a framework to follow to decide what library
will be used to support pgAdmin in the future. What metrics are you
currently using? What data should we collect on prototypes in order to help
the selection process?

Thanks!
João & Sarah

On Wed, Jun 21, 2017 at 6:37 AM, Dave Page  wrote:

> Hi George
>
> On Tue, Jun 20, 2017 at 10:29 PM, George Gelashvili
>  wrote:
> > We learned that the underlying issue was related to react-dom's
> > SyntheticEvent.augmentClass function being undefined.
> >
> > This seems to be caused by attempted property assignment after the
> > SyntheticEvent had been replaced by a Proxy of itself. This works fine in
> > Chromium et al, but QtWebKit doesn't deal with Proxy Event objects well.
> > Moving the augmentClass definition and assignment up above the Proxy
> stuff
> > resolves the issue in a PR to React:
> > https://github.com/facebook/react/pull/10011
> >
> > This has a decent chance of being rejected, as QtWebKit appears to be
> losing
> > support.
> >
> > While and if this is being sorted out, we vendorized React, as one does.
> > Here are patches on the version we were using previously, and the fix
> from
> > the above PR.
>
> Thanks - committed.
>
> > We started talking to some Pivotal folks about QtWebKit to see if we can
> fix
> > the Proxy Event issue in the browser.
> > We are also looking into replacements for QtWebKit.
>
> Yeah, so here's the current state of play there:
>
> - Some major Linuxes don't seem to have added QtWebEngine to their
> packages yet.
>
> - QtWebEngine has multiple issues under Windows; it's *very* slow, and
> doesn't play nicely with some graphics cards and Remote Desktop.
>
> - QtWebKit (official) has rendering issues, and has been deprecated by Qt.
>
> - QtWebKit (annulen) fixes the rendering issues, and generally works
> well, but is very slow on Windows (though not as bad as QtWebEngine).
>
> - QtWebKit (annulen) is a fork, which may or may not live for long.
> It's also still quite far behind the latest WebKit code.
>
> - ActiveQt is looking extremely promising on Windows, embedding IE as
> the browser. It's speed is on par with QtWebKit on Mac. We're
> currently working on handling multiple tabs/windows and sharing
> cookies between them.
>
> - Electron and Node-Webkit are performant options, but don't support
> tabs, and may not even support multiple windows in the same session.
>
> Neel is currently working on the ActiveQt option for Windows. I've
> been very impressed by its speed, and of course, JS support is per the
> installed version of IE. If that pans out, we could potentially move
> back to QtWebEngine on Linux/Mac (where the latest versions may well
> be improved), and use ActiveQt on Windows, thus dropping WebKit
> altogether.
>
> Another option would be to help get the annulen QtWebKit port up to
> par; fix the performance issues on Windows, and get it up to the
> latest WebKit code. That seems like it would take much more work, and
> I don't think our team has the capacity for that. If yours does, then
> it's certainly worth exploring.
>
> Ashesh is also planning to spend a little more time looking more
> deeply at Electron/Node-Webkit as well as other options, once he's
> finished his current work.
>
> Other thoughts/experiences are definitely welcome.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>