pgsql: Add missing EPQ recheck for TID Scan

2025-09-17 Thread David Rowley
Add missing EPQ recheck for TID Scan The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Scans where the ctid of the new (updated) tuple no longer matches the claus

pgsql: Add missing EPQ recheck for TID Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Scan The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Scans where the ctid of the new (updated) tuple no longer matches the claus

pgsql: Add missing EPQ recheck for TID Range Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Range Scan The EvalPlanQual recheck for TID Range Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Range Scans where the ctid of the new (updated) tuple no longer

pgsql: Add missing EPQ recheck for TID Range Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Range Scan The EvalPlanQual recheck for TID Range Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Range Scans where the ctid of the new (updated) tuple no longer

pgsql: Add missing EPQ recheck for TID Range Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Range Scan The EvalPlanQual recheck for TID Range Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Range Scans where the ctid of the new (updated) tuple no longer

pgsql: Add missing EPQ recheck for TID Range Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Range Scan The EvalPlanQual recheck for TID Range Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Range Scans where the ctid of the new (updated) tuple no longer

pgsql: Add missing EPQ recheck for TID Range Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Range Scan The EvalPlanQual recheck for TID Range Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Range Scans where the ctid of the new (updated) tuple no longer

pgsql: Add missing EPQ recheck for TID Range Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Range Scan The EvalPlanQual recheck for TID Range Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Range Scans where the ctid of the new (updated) tuple no longer

pgsql: Add missing EPQ recheck for TID Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Scan The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Scans where the ctid of the new (updated) tuple no longer matches the claus

pgsql: Add missing EPQ recheck for TID Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Scan The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Scans where the ctid of the new (updated) tuple no longer matches the claus

pgsql: Add missing EPQ recheck for TID Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Scan The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Scans where the ctid of the new (updated) tuple no longer matches the claus

pgsql: Add missing EPQ recheck for TID Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Scan The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Scans where the ctid of the new (updated) tuple no longer matches the claus

pgsql: Add missing EPQ recheck for TID Scan

2025-09-16 Thread David Rowley
Add missing EPQ recheck for TID Scan The EvalPlanQual recheck for TID Scan wasn't rechecking the TID qual still passed after following update chains. This could result in tuples being updated or deleted by plans using TID Scans where the ctid of the new (updated) tuple no longer matches the claus

pgsql: Add missing Datum conversions

2025-08-08 Thread Peter Eisentraut
Add missing Datum conversions Add various missing conversions from and to Datum. The previous code mostly relied on implicit conversions or its own explicit casts instead of using the correct DatumGet*() or *GetDatum() functions. We think these omissions are harmless. Some actual bugs that were

pgsql: Add missing newlines to PQescapeInternal() messages pre-v16.

2025-05-01 Thread Tom Lane
Add missing newlines to PQescapeInternal() messages pre-v16. While back-patching 9f45e6a91, I neglected that the convention in pre-v16 libpq was to include a trailing newline in error message strings (since then, we add those separately). Add them now. Reported-by: Peter Eisentraut Discussion:

pgsql: Add missing newlines to PQescapeInternal() messages pre-v16.

2025-05-01 Thread Tom Lane
Add missing newlines to PQescapeInternal() messages pre-v16. While back-patching 9f45e6a91, I neglected that the convention in pre-v16 libpq was to include a trailing newline in error message strings (since then, we add those separately). Add them now. Reported-by: Peter Eisentraut Discussion:

pgsql: Add missing newlines to PQescapeInternal() messages pre-v16.

2025-05-01 Thread Tom Lane
Add missing newlines to PQescapeInternal() messages pre-v16. While back-patching 9f45e6a91, I neglected that the convention in pre-v16 libpq was to include a trailing newline in error message strings (since then, we add those separately). Add them now. Reported-by: Peter Eisentraut Discussion:

Re: pgsql: Add missing string terminator

2025-04-30 Thread Daniel Gustafsson
> On 30 Apr 2025, at 15:14, David Rowley wrote: > On Thu, 1 May 2025 at 00:44, Peter Eisentraut wrote: >> I think it's best in general to use str* for strings and mem* for >> not-strings. That's easier to read and also better for static analyzers >> etc. > > The reason I think memcpy is better

Re: pgsql: Add missing string terminator

2025-04-30 Thread David Rowley
On Thu, 1 May 2025 at 00:44, Peter Eisentraut wrote: > > On 30.04.25 13:56, David Rowley wrote: > > In case you're looking for inspiration on a standard to follow, > > commits such as 586dd5d6a did seem to favour memcpy() when the length > > was known and only use strlcpy() when it wasn't. > > It

Re: pgsql: Add missing string terminator

2025-04-30 Thread Peter Eisentraut
On 30.04.25 13:56, David Rowley wrote: On Wed, 30 Apr 2025 at 23:43, David Rowley wrote: memcpy() would make more sense IMO, since the length is known already. I'm fine with either, however. In case you're looking for inspiration on a standard to follow, commits such as 586dd5d6a did seem to

Re: pgsql: Add missing string terminator

2025-04-30 Thread David Rowley
On Wed, 30 Apr 2025 at 23:43, David Rowley wrote: > memcpy() would make more sense IMO, since the length is > known already. I'm fine with either, however. In case you're looking for inspiration on a standard to follow, commits such as 586dd5d6a did seem to favour memcpy() when the length was kno

Re: pgsql: Add missing string terminator

2025-04-30 Thread David Rowley
On Wed, 30 Apr 2025 at 23:27, Daniel Gustafsson wrote: > How about using strlcpy as suggested by Peter? > > - strncpy(nameptr, "Remaining Totals", namelen); > - nameptr[namelen] = '\0'; > + strlcpy(nameptr, "Remaining Totals", namel

Re: pgsql: Add missing string terminator

2025-04-30 Thread Daniel Gustafsson
> On 30 Apr 2025, at 12:57, David Rowley wrote: > > On Wed, 30 Apr 2025 at 21:36, Daniel Gustafsson > wrote: >> Add missing string terminator > > A possible minor niggle. Would memcpy not be a more suitable function > for this? How about using strlcpy as suggested by Peter? -

Re: pgsql: Add missing string terminator

2025-04-30 Thread David Rowley
On Wed, 30 Apr 2025 at 21:36, Daniel Gustafsson wrote: > Add missing string terminator A possible minor niggle. Would memcpy not be a more suitable function for this? It's just there've been a few efforts in the past to try and minimise the usage of strncpy(). There should really just be a smal

pgsql: Add missing string terminator

2025-04-30 Thread Daniel Gustafsson
Add missing string terminator When copying the string strncpy won't add nul termination since the string length is equal to the length specified. Explicitly set a nul terminator after copying to properly terminate. Found via post-commit review. Author: Rahila Syed Reviewed-by: Daniel Gustafsson

pgsql: Add missing space in pg_restore documentation.

2025-04-11 Thread Nathan Bossart
Add missing space in pg_restore documentation. Oversight in commit 1495eff7bd. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5822bf21d50eb3a4938066951727294e3d33ca6c Modified Files -- doc/src/sgml/ref/pg_restore.sgml | 2 +- 1 file changed, 1 insertion

pgsql: Add missing source file to pg_verifybackup/nls.mk

2025-04-11 Thread Peter Eisentraut
Add missing source file to pg_verifybackup/nls.mk added by commit 8dfd3129027 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/914ea1c93c0e446a0cd174497fd6a22fd6071c5e Modified Files -- src/bin/pg_verifybackup/nls.mk | 1 + 1 file changed, 1 insertion(+)

pgsql: Add missing source file to pg_upgrade/nls.mk

2025-04-11 Thread Peter Eisentraut
Add missing source file to pg_upgrade/nls.mk added by commit 40e2e5e92b7 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9e0e1cfc3ef2f683be514b9ef7a7567404fc327f Modified Files -- src/bin/pg_upgrade/nls.mk | 1 + 1 file changed, 1 insertion(+)

pgsql: Add missing source file to pg_dump/nls.mk

2025-04-11 Thread Peter Eisentraut
Add missing source file to pg_dump/nls.mk added by commit c1da7281060 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b63cbacb86cf7fa75ca872633ce55fd327b5c7e7 Modified Files -- src/bin/pg_dump/nls.mk | 1 + 1 file changed, 1 insertion(+)

pgsql: Add missing PGDLLIMPORT markings

2025-04-11 Thread Peter Eisentraut
Add missing PGDLLIMPORT markings Discussion: https://www.postgresql.org/message-id/flat/25095db5-b595-4b85-9100-d358907c25b5%40eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7d430a57281f0050b66e5eb9eb587193e4cc54ed Modified Files -- src

pgsql: Add missing declarations to pg_config.h.in

2025-04-05 Thread Daniel Gustafsson
Add missing declarations to pg_config.h.in Add missing pg_config.h.in declarations from 09be39112654 where the corresponding autoconf/meson declarations were added. Reviewed-by: Heikki Linnakangas Discussion: https://postgr.es/m/[email protected] Branch -- master

pgsql: Add missing deparsing of [NO] IDENT to XMLSERIALIZE()

2025-02-21 Thread Michael Paquier
Add missing deparsing of [NO] IDENT to XMLSERIALIZE() NO INDENT is the default, and is added if no explicit indentation flag was provided with XMLSERIALIZE(). Oversight in 483bdb2afec9. Author: Jim Jones Discussion: https://postgr.es/m/[email protected] Backp

pgsql: Add missing deparsing of [NO] IDENT to XMLSERIALIZE()

2025-02-21 Thread Michael Paquier
Add missing deparsing of [NO] IDENT to XMLSERIALIZE() NO INDENT is the default, and is added if no explicit indentation flag was provided with XMLSERIALIZE(). Oversight in 483bdb2afec9. Author: Jim Jones Discussion: https://postgr.es/m/[email protected] Backp

pgsql: Add missing deparsing of [NO] IDENT to XMLSERIALIZE()

2025-02-21 Thread Michael Paquier
Add missing deparsing of [NO] IDENT to XMLSERIALIZE() NO INDENT is the default, and is added if no explicit indentation flag was provided with XMLSERIALIZE(). Oversight in 483bdb2afec9. Author: Jim Jones Discussion: https://postgr.es/m/[email protected] Backp

pgsql: Add missing entry to oauth_validator test .gitignore

2025-02-20 Thread Daniel Gustafsson
Add missing entry to oauth_validator test .gitignore Commit b3f0be788 accidentally missed adding the oauth client test binary to the relevant .gitignore. Reported-by: Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.post

pgsql: Add missing CommandCounterIncrement

2025-01-26 Thread Álvaro Herrera
Add missing CommandCounterIncrement For commit b663b9436e75 I thought this was useless, but turns out not to be for the case where a partitioned table has two identical foreign key constraints which can both be matched by the same constraint in a partition during attach. This CCI makes the match

pgsql: Add missing typedefs.list entry for AggStatePerGroupData.

2025-01-07 Thread Jeff Davis
Add missing typedefs.list entry for AggStatePerGroupData. Discussion: https://postgr.es/m/7530bd8783b1a78d53a3c70383e38d8da0a5ffe5.camel%40j-davis.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/834c9e807cf12e355f06479a8b1f7a82aba77315 Modified Files -

pgsql: Add missing BUFFERS OFF in regression tests, take 2

2024-12-11 Thread David Rowley
Add missing BUFFERS OFF in regression tests, take 2 Similar to 9fa1aaa65, but running with -D RELCACHE_FORCE_RELEASE and -D CATCACHE_FORCE_RELEASE yielded some additional missing places that needed BUFFERS OFF. Discussion: https://postgr.es/m/CANNMO++W7MM8T0KyXN3ZheXXt-uLVM3aEtZd+WNfZ=obxff...@m

pgsql: Add missing BUFFERS OFF in select_into regression tests

2024-12-11 Thread David Rowley
Add missing BUFFERS OFF in select_into regression tests c2a4078eb adjusted EXPLAIN ANALYZE to include BUFFERS by default, but a few tests in select_into.sql neglected to add BUFFERS OFF. The failing tests seem unlikely to ever access buffers during execution, but they certainly could during plann

pgsql: Add missing word in comment

2024-11-12 Thread Amit Langote
Add missing word in comment Discussion: https://postgr.es/m/CA+HiwqFgdp8=0_gi+du0fpwzbg7qy3kz_c1wj1devzxc4bc...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bfeeb065ea2c870cf4d9dfcd552d23d72432e692 Modified Files -- src/include/storag

pgsql: Add missing include guard to win32ntdll.h.

2024-11-07 Thread Andrew Dunstan
Add missing include guard to win32ntdll.h. Oversight in commit e2f0f8ed. Also add this file to the exclusion lists in headerscheck and cpluscpluscheck, because Unix systems don't have a header it includes. Reported-by: Tom Lane Discussion: https://postgr.es/m/2760528.1641929756%40sss.pgh.pa.us

pgsql: Add missing include guard to win32ntdll.h.

2024-11-07 Thread Andrew Dunstan
Add missing include guard to win32ntdll.h. Oversight in commit e2f0f8ed. Also add this file to the exclusion lists in headerscheck and cpluscpluscheck, because Unix systems don't have a header it includes. Reported-by: Tom Lane Discussion: https://postgr.es/m/2760528.1641929756%40sss.pgh.pa.us

pgsql: Add missing newlines at the end of two SQL files

2024-11-03 Thread Michael Paquier
Add missing newlines at the end of two SQL files arrays.sql was already missing it before 49d6c7d8daba, and I have just noticed it thanks to this commit. The second one in test_slru has been introduced by 768a9fd5535f. Branch -- master Details --- https://git.postgresql.org/pg/commitdif

pgsql: Add missing CommandCounterIncrement() in stats import functions.

2024-10-29 Thread Jeff Davis
Add missing CommandCounterIncrement() in stats import functions. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f22e436bff779fee4e1ce49733ba5791d4634fb1 Mo

pgsql: Add missing FATAL => 'all' to a use warnings in Perl

2024-10-29 Thread Peter Eisentraut
Add missing FATAL => 'all' to a use warnings in Perl Author: Anton Voloshin Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/014720c6d9fb1285846f0b7cc1c80bdbe887a7

pgsql: Add missing command for pg_maintain in comment

2024-09-30 Thread Daniel Gustafsson
Add missing command for pg_maintain in comment The comment in pg_class_aclmask_ext() which lists the allowed commands for the pg_maintain role lacked LOCK TABLE. Reported-by: Yusuke Sugie Reviewed-by: Yugo Nagata Discussion: https://postgr.es/m/[email protected]

pgsql: Add missing query ID reporting in extended query protocol

2024-09-17 Thread Michael Paquier
Add missing query ID reporting in extended query protocol This commit adds query ID reports for two code paths when processing extended query protocol messages: - When receiving a bind message, setting it to the first Query retrieved from a cached cache. - When receiving an execute message, settin

pgsql: Add missing query ID reporting in extended query protocol

2024-09-17 Thread Michael Paquier
Add missing query ID reporting in extended query protocol This commit adds query ID reports for two code paths when processing extended query protocol messages: - When receiving a bind message, setting it to the first Query retrieved from a cached cache. - When receiving an execute message, settin

pgsql: Add missing query ID reporting in extended query protocol

2024-09-17 Thread Michael Paquier
Add missing query ID reporting in extended query protocol This commit adds query ID reports for two code paths when processing extended query protocol messages: - When receiving a bind message, setting it to the first Query retrieved from a cached cache. - When receiving an execute message, settin

pgsql: Add missing query ID reporting in extended query protocol

2024-09-17 Thread Michael Paquier
Add missing query ID reporting in extended query protocol This commit adds query ID reports for two code paths when processing extended query protocol messages: - When receiving a bind message, setting it to the first Query retrieved from a cached cache. - When receiving an execute message, settin

pgsql: Add missing query ID reporting in extended query protocol

2024-09-17 Thread Michael Paquier
Add missing query ID reporting in extended query protocol This commit adds query ID reports for two code paths when processing extended query protocol messages: - When receiving a bind message, setting it to the first Query retrieved from a cached cache. - When receiving an execute message, settin

pgsql: Add missing wait_for_catchup() to pg_visibility tap test

2024-08-15 Thread Alexander Korotkov
Add missing wait_for_catchup() to pg_visibility tap test e2ed7e32271a introduced check of pg_visibility on standby. This commit adds missing wait_for_catchup() to synchronize standby before querying it. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e3ec9dc1bf4983

pgsql: Add missing pointer dereference in pg_backend_memory_contexts vi

2024-07-28 Thread David Rowley
Add missing pointer dereference in pg_backend_memory_contexts view 32d3ed816 moved the logic for setting the context's name and ident into a reusable function. I missed adding a pointer dereference after copying and pasting the code into that function. The ident parameter is a pointer to the ide

pgsql: Add missing call to ConditionVariableCancelSleep().

2024-07-22 Thread Robert Haas
Add missing call to ConditionVariableCancelSleep(). After calling ConditionVariableSleep() or ConditionVariableTimedSleep() one or more times, code is supposed to call ConditionVariableCancelSleep() to remove itself from the waitlist. This code neglected to do so. As far as I know, that had no obs

pgsql: Add missing call to ConditionVariableCancelSleep().

2024-07-22 Thread Robert Haas
Add missing call to ConditionVariableCancelSleep(). After calling ConditionVariableSleep() or ConditionVariableTimedSleep() one or more times, code is supposed to call ConditionVariableCancelSleep() to remove itself from the waitlist. This code neglected to do so. As far as I know, that had no obs

pgsql: Add missing RestrictSearchPath() calls.

2024-07-15 Thread Jeff Davis
Add missing RestrictSearchPath() calls. Reported-by: Noah Misch Backpatch-through: 17 Discussion: https://postgr.es/m/[email protected] Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a15b0edb5dd9d2a3731f374b576485799c00431c Modified Files

pgsql: Add missing RestrictSearchPath() calls.

2024-07-15 Thread Jeff Davis
Add missing RestrictSearchPath() calls. Reported-by: Noah Misch Backpatch-through: 17 Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8e28778ce396c3dac74a5fa8724e1ca7cea16d19 Modified Files ---

pgsql: Add missing includes for some global variables

2024-07-01 Thread Peter Eisentraut
Add missing includes for some global variables src/backend/libpq/pqcomm.c: "postmaster/postmaster.h" for Unix_socket_group, Unix_socket_permissions src/backend/utils/init/globals.c: "postmaster/postmaster.h" for MyClientSocket src/backend/utils/misc/guc_tables.c: "utils/rls.h" for row_security sr

pgsql: Add missing source files to nls.mk

2024-06-13 Thread Peter Eisentraut
Add missing source files to nls.mk Files in common/ and fe_utils/ that contain translatable strings need to be listed in the nls.mk files of the programs that use them. (Not great, but that's the way it works for now.) This usually requires some manual analysis which is done about once during ea

Re: pgsql: Add missing source files to nls.mk

2024-06-13 Thread Peter Eisentraut
On 13.06.24 10:25, Peter Eisentraut wrote: Add missing source files to nls.mk Files in common/ and fe_utils/ that contain translatable strings need to be listed in the nls.mk files of the programs that use them. (Not great, but that's the way it works for now.) This usually requires some manua

pgsql: Add missing newline at the end of index_including.sql

2024-05-14 Thread Michael Paquier
Add missing newline at the end of index_including.sql Thinko in a63224be49b8. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/54b69f1bd730a228a666441592a12d2a0cbe2a06 Modified Files -- src/test/regress/sql/index_including.sql | 2 +- 1 file changed, 1 in

pgsql: Add missing gettext triggers

2024-05-14 Thread Peter Eisentraut
Add missing gettext triggers Commit d6607016c7 moved all the jsonapi.c error messages into token_error(). This needs to be added to the various nls.mk files that use this. Since that makes token_error() effectively a globally known symbol, the name seems a bit too general, so rename to json_toke

pgsql: Add missing source files to pg_combinebackup/nls.mk

2024-05-14 Thread Peter Eisentraut
Add missing source files to pg_combinebackup/nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9eb54a258f53dd1d7f198e74c1b11b516ad2e98a Modified Files -- src/bin/pg_combinebackup/nls.mk | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(

pgsql: Add missing gettext triggers

2024-05-14 Thread Peter Eisentraut
Add missing gettext triggers Due to commit dc212340058, which added use of src/common/parse_manifest.c in the backend. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ab4d7a38c36dba3997e9b585448837ccf6384aed Modified Files -- src/backend/nls.mk | 7

pgsql: Add missing index_insert_cleanup calls

2024-04-19 Thread Tomas Vondra
Add missing index_insert_cleanup calls The optimization for inserts into BRIN indexes added by c1ec02be1d79 relies on a cache that needs to be explicitly released after calling index_insert(). The commit however failed to invoke the cleanup in validate_index(), which calls index_insert() indirectl

pgsql: Add missing source file to libpq/nls.mk

2024-04-17 Thread Peter Eisentraut
Add missing source file to libpq/nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e75492b3c33beaf226981b796d81b6127544fea Modified Files -- src/interfaces/libpq/nls.mk | 1 + 1 file changed, 1 insertion(+)

pgsql: Add missing PGDLLIMPORT markings

2024-04-15 Thread Michael Paquier
Add missing PGDLLIMPORT markings All backend-side variables should be marked with PGDLLIMPORT, as per policy introduced in 8ec569479f. aafc05de1bf5 has forgotten MyClientSocket, and 05c3980e7f47 LoadedSSL. These can be spotted with a command like this one (be careful of not switching __pg_log_le

pgsql: Add missing set_pglocale_pgservice() for pg_walsummary and pg_co

2024-04-08 Thread Michael Paquier
Add missing set_pglocale_pgservice() for pg_walsummary and pg_combinebackup These calls are required to make both tools work with NLS. Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https

pgsql: Add missing initialization in transformJsonFuncExpr()

2024-04-04 Thread Amit Langote
Add missing initialization in transformJsonFuncExpr() de3600452b added some code for the new JSON_TABLE_OP to that function but missed to initialize the default_format variable. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/[email protected] Branch -

pgsql: Add missing source files to nls.mk

2024-03-18 Thread Peter Eisentraut
Add missing source files to nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5162f663fcbe837648ae28f00e18ed972f5e360b Modified Files -- src/bin/initdb/nls.mk | 1 + src/bin/pg_resetwal/nls.mk | 3 ++- 2 files changed, 3 insertions(+), 1 deletion

pgsql: Add missing connection statuses to docs

2024-03-11 Thread Alvaro Herrera
Add missing connection statuses to docs The list of connection statuses that PQstatus might return during an asynchronous connection attempt was outdated: 1. CONNECTION_SETENV is never returned anymore and is only part of the enum for backwards compatibility, so remove it from the docs. 2. CON

pgsql: Add missing RangeTblEntry field to jumble

2024-02-29 Thread Peter Eisentraut
Add missing RangeTblEntry field to jumble RangeTblEntry.funcordinality should be jumbled, because the WITH ORDINALITY clause changes the query result. This was apparently an oversight in the past. Discussion: https://www.postgresql.org/message-id/flat/d7f421f8-fd6d-4759-adc3-247090a5d44b%40eise

pgsql: Add missing check_stack_depth() to some recursive functions

2024-02-16 Thread Alexander Korotkov
Add missing check_stack_depth() to some recursive functions Reported-by: Egor Chindyaskin, Alexander Lakhin Discussion: https://postgr.es/m/1672760457.940462079%40f306.i.mail.ru Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d57b7cc3338e9d9aa1d7c5da1b25a17c5a72dcce

pgsql: Add missing PGDLLIMPORT markings

2024-01-16 Thread Heikki Linnakangas
Add missing PGDLLIMPORT markings Since commit 8ec569479f, we have a policy of marking all backend variables with PGDLLIMPORT. Reported-by: Anton A. Melnikov Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- master Details --

pgsql: Add missing file to nls Makefile

2023-11-30 Thread Daniel Gustafsson
Add missing file to nls Makefile Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c3f4a84481b6a8d84b1928165a7bf459e5304ed8 Modified Files

pgsql: Add missing unicode_category.c to MSVC build scripts

2023-11-03 Thread David Rowley
Add missing unicode_category.c to MSVC build scripts Fixes MSVC build failure introduced by a02b37fc0 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/39c959ef25bd9cdd966ee024ab14f8f4214bb276 Modified Files -- src/tools/msvc/Mkvcbuild.pm | 1 + 1 file cha

pgsql: Add missing include dir and references to libpq for MSVC build

2023-10-24 Thread David Rowley
Add missing include dir and references to libpq for MSVC build 66d6086cb adjusted pg_regress to require this but forgot to adjust the Visual Studio build script. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/673a17e31202cc47a9309e9b0b9b5fbec36080d3 Modified Files

pgsql: Add missing TidRangePath handling in print_path()

2023-09-28 Thread David Rowley
Add missing TidRangePath handling in print_path() Tid Range scans were added back in bb437f995. That commit forgot to add handling for TidRangePaths in print_path(). Only people building with OPTIMIZER_DEBUG might have noticed this, which likely is the reason it's taken 4 years for anyone to not

pgsql: Add missing TidRangePath handling in print_path()

2023-09-28 Thread David Rowley
Add missing TidRangePath handling in print_path() Tid Range scans were added back in bb437f995. That commit forgot to add handling for TidRangePaths in print_path(). Only people building with OPTIMIZER_DEBUG might have noticed this, which likely is the reason it's taken 4 years for anyone to not

pgsql: Add missing TidRangePath handling in print_path()

2023-09-28 Thread David Rowley
Add missing TidRangePath handling in print_path() Tid Range scans were added back in bb437f995. That commit forgot to add handling for TidRangePaths in print_path(). Only people building with OPTIMIZER_DEBUG might have noticed this, which likely is the reason it's taken 4 years for anyone to not

pgsql: Add missing TidRangePath handling in print_path()

2023-09-28 Thread David Rowley
Add missing TidRangePath handling in print_path() Tid Range scans were added back in bb437f995. That commit forgot to add handling for TidRangePaths in print_path(). Only people building with OPTIMIZER_DEBUG might have noticed this, which likely is the reason it's taken 4 years for anyone to not

pgsql: Add missing ObjectIdGetDatum() in syscache lookup calls for Oids

2023-07-19 Thread Michael Paquier
Add missing ObjectIdGetDatum() in syscache lookup calls for Oids Based on how postgres.h foes the Oid <-> Datum conversion, there is no existing bugs but let's be consistent. 17 spots have been noticed as incorrectly passing down Oids rather than Datums. Aleksander got one, Zhang two and I the r

pgsql: Add missing initializations of p_perminfo

2023-07-13 Thread Amit Langote
Add missing initializations of p_perminfo In a61b1f74823, we failed to update transformFromClauseItem() and buildNSItemFromLists() to set ParseNamespaceItem.p_perminfo causing it to point to garbage. Pointed out by Tom Lane. Reported-by: Farias de Oliveira Discussion: https://postgr.es/m/317347

pgsql: Add missing initializations of p_perminfo

2023-07-13 Thread Amit Langote
Add missing initializations of p_perminfo In a61b1f74823, we failed to update transformFromClauseItem() and buildNSItemFromLists() to set ParseNamespaceItem.p_perminfo causing it to point to garbage. Pointed out by Tom Lane. Reported-by: Farias de Oliveira Discussion: https://postgr.es/m/317347

pgsql: Add missing const qualifier

2023-07-13 Thread Amit Langote
Add missing const qualifier Missed in commit 785480c9533d9. Pointed out by Tom Lane. Discussion: https://postgr.es/m/2795364.1689221300%40sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/40b3af72a787e5c7c842651a2e04e3f856b9460c Modified Files ---

pgsql: Add missing pg_basebackup TAP test for meson.

2023-06-15 Thread Masahiko Sawada
Add missing pg_basebackup TAP test for meson. 011_in_place_tablespace was missing from the list of pg_basebackup tests to run under meson, so add it. Oversight in 363e8f9115. Discussion: https://postgr.es/m/CAD21AoDTh1A8bvNBF3LQNQg=27xtpsgvpt+4_yyej6p4zv8...@mail.gmail.com Branch -- master

pgsql: Add missing subscription TAP test for meson

2023-06-15 Thread Michael Paquier
Add missing subscription TAP test for meson 033_run_as_table_owner was missing from the list of subscription tests to run under meson, so add it. Oversight in 4826759. Author: Hayato Kuroda Discussion: https://postgr.es/m/tyapr01mb58668f4d85a9a122a158f442f5...@tyapr01mb5866.jpnprd01.prod.outloo

pgsql: Add missing gettext triggers

2023-05-10 Thread Peter Eisentraut
Add missing gettext triggers due to the changes in commit dac048f71e Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d8bcce1b5e99d8f6f12cb7a94190fdc5622355af Modified Files -- src/backend/nls.mk | 3 +++ 1 file changed, 3 insertions(+)

pgsql: Add missing source file to nls.mk

2023-05-07 Thread Peter Eisentraut
Add missing source file to nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b8c3f6df85e78e09c9709fc895aced719aebd7f9 Modified Files -- src/bin/pg_dump/nls.mk | 1 + 1 file changed, 1 insertion(+)

pgsql: Add missing TAP test name

2023-05-03 Thread Peter Eisentraut
Add missing TAP test name Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1ab763fc22adc88e5d779817e7b42b25a9dd7c9e Modified Files -- src/bin/pg_waldump/t/002_save_fullpage.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: Add missing uninstallation rule for BackgroundPsql.pm

2023-05-02 Thread Peter Eisentraut
Add missing uninstallation rule for BackgroundPsql.pm Commit a4c17c8617 added in the install rule but not the uninstall rule. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7039c7cff6736780c3bbb41a90a6dfea0f581ad2 Modified Files -- src/test/perl/Makefi

pgsql: Add missing source files to nls.mk

2023-04-14 Thread Peter Eisentraut
Add missing source files to nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/99322d6eee6445665c1fb131ec6130924b7673b6 Modified Files -- src/bin/pg_dump/nls.mk | 4 src/bin/pg_rewind/nls.mk | 1 + 2 files changed, 5 insertions(+)

pgsql: Add missing XML ID attribute

2023-04-13 Thread Peter Eisentraut
Add missing XML ID attribute Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a34901dd03edb473ddbd81ee5c7332575f6d8881 Modified Files -- doc/src/sgml/pgbufferc

pgsql: Add missing .gitignore entry.

2023-04-07 Thread Tom Lane
Add missing .gitignore entry. Seems an oversight in 7d8219a44. Fix before somebody commits a generated file. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/db6957bae8d7716785aa3748b25a9a4b7c3ff304 Modified Files -- src/bin/pg_waldump/.gitignore | 1 +

pgsql: Add missing XML ID attributes

2023-04-04 Thread Peter Eisentraut
Add missing XML ID attributes Author: Brar Piening Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3077324b03e81ab9894f1f510952273b78d98569 Modified Files --

pgsql: Add missing .gitignore entries.

2023-03-29 Thread Tom Lane
Add missing .gitignore entries. Oversight in commit 7081ac46ace8c459966174400b53418683c9fe5c. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3aa961378b4e517908a4400cdc476ca299693de9 Modified Files -- src/interfaces/ecpg/test/sql/.gitignore | 2 ++ 1 fil

pgsql: Add missing "-I." flag when building pg_bsd_indent.

2023-03-23 Thread Tom Lane
Add missing "-I." flag when building pg_bsd_indent. This is evidently not required by most compilers, but buildfarm member fairywren is unhappy without it. It looks like the meson infrastructure has this right already. Branch -- master Details --- https://git.postgresql.org/pg/commitdif

pgsql: Add missing support for the latest SPI status codes.

2023-02-22 Thread Dean Rasheed
Add missing support for the latest SPI status codes. SPI_result_code_string() was missing support for SPI_OK_TD_REGISTER, and in v15 and later, it was missing support for SPI_OK_MERGE, as was pltcl_process_SPI_result(). The last of those would trigger an error if a MERGE was executed from PL/Tcl.

pgsql: Add missing support for the latest SPI status codes.

2023-02-22 Thread Dean Rasheed
Add missing support for the latest SPI status codes. SPI_result_code_string() was missing support for SPI_OK_TD_REGISTER, and in v15 and later, it was missing support for SPI_OK_MERGE, as was pltcl_process_SPI_result(). The last of those would trigger an error if a MERGE was executed from PL/Tcl.

pgsql: Add missing support for the latest SPI status codes.

2023-02-22 Thread Dean Rasheed
Add missing support for the latest SPI status codes. SPI_result_code_string() was missing support for SPI_OK_TD_REGISTER, and in v15 and later, it was missing support for SPI_OK_MERGE, as was pltcl_process_SPI_result(). The last of those would trigger an error if a MERGE was executed from PL/Tcl.

  1   2   3   >