On Wed, Oct 2, 2013 at 6:32 AM, Alvaro Herrera wrote:
> Andres Freund wrote:
>> I think this removes too many comments from index_drop that explains why
>> it's done that way.
>
> Complaint registered. If either of you can send a patch I will gladly
> push it, otherwise it will take me some time
On Wed, Aug 16, 2017 at 9:27 AM, Peter Eisentraut wrote:
> pg_receivewal: Improve verbose mode
>
> Some informational messages showed up even if verbose mode was not
> used. Move them to verbose mode.
Perhaps this should be back-patched? It seems to me that this is an
oversight from the beginnin
On Mon, Sep 18, 2017 at 6:58 AM, Thomas Munro
wrote:
> While googling around trying to find where I could read Coverity's
> output myself I was intrigued to see that https://scan.coverity.com
> offers integration with Travis CI[1], which suggests the possibility
> of automatically scanning all Com
On Mon, Oct 2, 2017 at 8:08 AM, Andres Freund wrote:
> Replace most usages of ntoh[ls] and hton[sl] with pg_bswap.h.
>
> All postgres internal usages are replaced, it's just libpq example
> usages that haven't been converted. External users of libpq can't
> generally rely on including postgres int
On Tue, Nov 7, 2017 at 7:39 AM, Tom Lane wrote:
> Peter Geoghegan writes:
>> Tom Lane wrote:
>>> Stamp 9.2.24.
>
>> Uh, I thought 9.2 was EOL.
>
> Now it is ...
9.2.24 is the last of the 9.2-series, November being the last minor
release after the 5-year community support window.
--
Michael
-
On Wed, Nov 8, 2017 at 4:43 AM, Tom Lane wrote:
> Andres Freund writes:
>> I think you misunderstand my point - I'm saying that pg_resetxlog should
>> be able to force the use of older checkpoints, basically as a fallback
>> to cases where the previous approach might actually have worked, not
>>
On Thu, Nov 12, 2015 at 4:06 AM, Joe Conway wrote:
> On 11/11/2015 10:54 AM, Robert Haas wrote:
>> On Wed, Nov 11, 2015 at 10:35 AM, Magnus Hagander
>> wrote:
>>> On Wed, Nov 11, 2015 at 4:32 PM, Simon Riggs wrote:
On 11 November 2015 at 14:03, Robert Haas wrote:
> Generate parallel s
On Fri, Nov 13, 2015 at 1:54 AM, Tom Lane wrote:
> I wrote:
>> After looking around, I suspect what actually happened in your test
>> was that we kept pumping pqReadData until it realized it was seeing EOF,
>> whereupon it did pqDropConnection(), and guess what that does:
>
>> /* Discard any
On Thu, Dec 3, 2015 at 8:38 AM, Tom Lane wrote:
> Test Summary Report
> ---
> t/001_initdb.pl (Wstat: 6400 Tests: 8 Failed: 0)
> Non-zero exit status: 25
> Parse errors: Bad plan. You planned 14 tests but ran 8.
> Files=1, Tests=8, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.08
On Sat, Dec 12, 2015 at 9:11 AM, Tom Lane wrote:
> Peter Eisentraut writes:
>> pg_rewind: Don't error if the two clusters are already on the same timeline
>> This previously resulted in an error and a nonzero exit status, but
>> after discussion this should rather be a noop with a zero exit statu
On Mon, Dec 14, 2015 at 4:52 AM, Tom Lane wrote:
> Code and docs review for multiple -c and -f options in psql.
>
> Commit d5563d7df94488bf drew complaints from Coverity, which quite
> correctly complained that one copy of each -c or -f string was being
> leaked. What's more, simple_action_list_a
On Mon, Dec 14, 2015 at 11:16 AM, Michael Paquier wrote:
> - cell = (SimpleActionListCell *)
> - pg_malloc(offsetof(SimpleActionListCell, val) + vallen + 1);
> Thanks! Among all those things this bit is a bit shameful..
(I am the one at the origin of that FWIW)
--
Michael
--
On Mon, Dec 14, 2015 at 2:26 PM, Peter Eisentraut wrote:
> the call to LWLockHeldByMe() is useless.
Yes, but it should be an Assert. I guess that Andres is on it..
--
Michael
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http
On Tue, Dec 22, 2015 at 8:16 AM, Alvaro Herrera
wrote:
> Alvaro Herrera wrote:
>> some bullshit
>
> This commit was supposed to be squashed with the next one --- hence
> the, err, not-terribly-descriptive commit message. This mistake may
> cause future "git bisect" runs to give spurious failures,
On Thu, Jan 21, 2016 at 7:59 AM, Bruce Momjian wrote:
> On Wed, Jan 20, 2016 at 07:41:07PM +, Robert Haas wrote:
>> Support parallel joins, and make related improvements.
>
> Wow, that is big news!
Yuhu!
--
Michael
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org
al_relation_size(oid) > pg_size_bytes('10 GB')".
>
> Author: Pavel Stehule with various improvements by Vitaly Burovoy
> Discussion:
> http://www.postgresql.org/message-id/cafj8prd-tgodknxdygecza4on01_urqprwf-8ldkse-6bdh...@mail.gmail.com
> Reviewed-by: Vitaly Burovoy
On Sat, Feb 20, 2016 at 7:12 PM, Michael Paquier
wrote:
> On Sat, Feb 20, 2016 at 7:07 PM, Dean Rasheed
> wrote:
>> Add pg_size_bytes() to parse human-readable size strings.
>>
>> This will parse strings in the format produced by pg_size_pretty() and
>> retu
On Sat, Feb 20, 2016 at 7:17 PM, Dean Rasheed wrote:
> On 20 February 2016 at 10:12, Michael Paquier
> wrote:
>> Happy first commit.
>
> Arg. Not so much.
>
> Looks like I broke something -- looking into it now :-(
The terabyte conversion is at fault:
Expected:
! -1tb
On Fri, Mar 11, 2016 at 2:29 AM, Andres Freund wrote:
> Checkpoint sorting and balancing.
+1.
--
Michael
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On Fri, Mar 11, 2016 at 2:08 AM, Amit Langote
wrote:
> On 2016/03/11 8:19, Peter Geoghegan wrote:
>> On Thu, Mar 10, 2016 at 1:22 PM, Andres Freund wrote:
>>> Yeha!
>>
>> Fantastic effort, particularly from Masahiko. Well done.
>
> +1!
Yuhu.
--
Michael
--
Sent via pgsql-committers mailing li
On Sat, Mar 19, 2016 at 10:22 AM, Tom Lane wrote:
> Also, stop compiling psqlscan as part of mainloop.c, and make it a
> standalone build target instead. This is a lot cleaner than before, though
> it doesn't really change much in practice as of this commit. (I'm not sure
> whether the MSVC buil
On Tue, Mar 22, 2016 at 10:20 AM, Andrew Dunstan wrote:
>
>
> On 03/21/2016 09:25 AM, Tom Lane wrote:
>>
>> Andres Freund writes:
>>>
>>> On 2016-03-21 22:38:50 +1300, David Rowley wrote:
Perl is not my native tongue, but after a little study and some
testing on a windows machine,
ast avoids any extra replies for
> people not using the feature at all.
>
> Thomas Munro, reviewed by Michael Paquier and by me. Some additional
> tweaks by me.
The commit message does not directly mention that the spec of
walrcv_receive has been changed in a backward-incompatible way so
On Wed, Mar 30, 2016 at 10:39 AM, Robert Haas wrote:
> On Tue, Mar 29, 2016 at 9:37 PM, Michael Paquier
> wrote:
>> On Wed, Mar 30, 2016 at 10:31 AM, Robert Haas wrote:
>>> Add new replication mode synchronous_commit = 'remote_apply'.
>>>
>>> I
On Thu, Mar 31, 2016 at 8:45 AM, Alvaro Herrera
wrote:
> Tom Lane wrote:
>> Alvaro Herrera writes:
>> > Enable logical slots to follow timeline switches
>>
>> Buildfarm doesn't like this one bit :-(
>
> Argh, forgot the alternate expected file when the needed feature is
> disabled. Will fix.
ha
ed by Laurence Rowe, investigated in detail by Michael
>> Paquier,
>> though this is not his proposed fix.
>> 20151016203031.3019.72...@wrigleys.postgresql.org
>>
>> Simple non-invasive patch to allow later backpatch to 9.4 and 9.5
Well...
> Uh. This is wrong. F
On Mon, Apr 4, 2016 at 4:50 PM, Andres Freund wrote:
> On 2016-04-04 08:44:47 +0100, Simon Riggs wrote:
>> That patch does exactly the same thing as the patch you prefer, just
>> does it differently;
>
> No, it doesn't; as explained above.
FWIW, I vote also for reverting this patch. This has been
On Wed, Apr 6, 2016 at 9:27 PM, Andres Freund wrote:
> On 2016-04-06 13:11:40 +0100, Simon Riggs wrote:
>> On 6 April 2016 at 10:09, Andres Freund wrote:
>> > On 2016-04-06 10:04:42 +0100, Simon Riggs wrote:
>> > The issue there is that we continue to issue checkpoints if the only
>> > activity s
On Wed, Apr 6, 2016 at 6:08 PM, Simon Riggs wrote:
> Generic Messages for Logical Decoding
>
> API and mechanism to allow generic messages to be inserted into WAL that are
> intended to be read by logical decoding plugins. This commit adds an optional
> new callback to the logical decoding API.
>
On Thu, Apr 7, 2016 at 10:45 AM, Stephen Frost wrote:
> Use GRANT system to manage access to sensitive functions
>
> Now that pg_dump will properly dump out any ACL changes made to
> functions which exist in pg_catalog, switch to using the GRANT system
> to manage access to those functions.
>
> Th
On Wed, Apr 27, 2016 at 12:04 PM, Andres Freund wrote:
> On 2016-04-26 22:59:44 -0400, Tom Lane wrote:
>> What's the argument that it makes debugging harder? Especially if
>> you aren't using it?
>
> If you try to write a V1 function, but forget or mistype/rename the
> function in PG_FUNCTION_INF
On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich wrote:
> * Christian Ullrich wrote:
>
>> wrong even without considering the debug/release split. If we load a
>> compiled extension built with a CRT we have not seen yet, _after_ the
>> first call to pgwin32_putenv(), that module's CRT's view of i
On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich wrote:
> * Michael Paquier wrote:
>
>> On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich
>> wrote:
>
>>> * Christian Ullrich wrote:
>
>> And actually, by looking at those patches, isn't it a dange
On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich wrote:
> * Michael Paquier wrote:
>> In order to avoid any problems with the load and unload windows, my
>> bet goes for 0001, 0002 and 0003, with the last two patches merged
>> together, 0001 being only a set of independe
On Wed, Sep 21, 2016 at 1:56 AM, Peter Eisentraut wrote:
> Re-add translation markers that were lost
>
> When win32security.c was moved from src/backend/port/win32/security.c,
> the message writing function was changed from write_stderr to log_error,
> but nls.mk was not updated. We could add log
On Mon, Sep 26, 2016 at 12:54 AM, Tom Lane wrote:
> Peter Eisentraut writes:
>> pg_ctl: Detect current standby state from pg_control
>
> Coverity thinks that this patch introduced a bunch of
> null-pointer-dereference hazards, and AFAICS it is right.
> The change in get_controlfile()'s API is com
On Tue, Oct 18, 2016 at 6:28 AM, Tom Lane wrote:
> Heikki Linnakangas writes:
>> Use OpenSSL EVP API for symmetric encryption in pgcrypto.
>
> BTW, "narwhal" seems to have a problem with this.
> Not very clear what, maybe an incompatibility with old openssl versions?
Details are here:
http://bui
On Fri, Dec 2, 2016 at 10:29 AM, Peter Eisentraut wrote:
> Use latch instead of select() in walreceiver
>
> Replace use of poll()/select() by WaitLatchOrSocket(), which is more
> portable and flexible.
>
> Also change walreceiver to use its procLatch instead of a custom latch.
>
> From: Petr Jelin
On Wed, Dec 7, 2016 at 7:46 AM, Andres Freund wrote:
> On 2016-12-05 11:44:37 +, Heikki Linnakangas wrote:
>> Replace PostmasterRandom() with a stronger source, second attempt.
>
> Since this went in I've seen
> 2016-12-06 14:42:17.005 PST [23658][] LOG: wrong key in cancel request for
> pro
On Fri, Feb 17, 2017 at 12:03 PM, Thomas Munro
wrote:
> On Fri, Feb 17, 2017 at 11:34 AM, Thomas Munro
> wrote:
>> On Fri, Feb 17, 2017 at 7:02 AM, Robert Haas wrote:
>>> http://git.postgresql.org/pg/commitdiff/9acb85597f1223ac26a5b19a9345849c43d0ff54
>> Hmm. This will segfault if you're out of
On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote:
> Fujii Masao writes:
>> Fix connection leak in DROP SUBSCRIPTION command.
>> Previously the command forgot to close the connection to the publisher
>> when it failed to drop the replication slot.
>
> If there's a bug here, this seems like an extre
On Wed, Feb 22, 2017 at 8:39 AM, Fujii Masao wrote:
> On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier
> wrote:
>> On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote:
>>> Fujii Masao writes:
>>>> Fix connection leak in DROP SUBSCRIPTION command.
>>>&g
On Sun, Mar 26, 2017 at 7:58 AM, David Rowley
wrote:
> On 26 March 2017 at 09:55, Thomas Munro wrote:
>> On Sun, Mar 26, 2017 at 11:11 AM, Andres Freund wrote:
>>> Faster expression evaluation and targetlist projection.
>>>
>>> This replaces the old, recursive tree-walk based evaluation, with
>>
On Sat, Apr 1, 2017 at 5:27 PM, Thomas Munro
wrote:
> On Sat, Apr 1, 2017 at 8:41 PM, Andres Freund wrote:
>> For the upcoming JIT support LLVM is required. To avoid issues with
>> having to support multiple LLVM versions, add a vendored version of
>> LLVM.
>>
>> The large size of LLVM makes thi
On Thu, Apr 27, 2017 at 9:28 PM, Simon Riggs wrote:
> Additional tests for subtransactions in recovery
>
> Tests for normal and prepared transactions
>
> Author: Nikhil Sontakke, placed in new test file by me
+$node_slave->promote;
+$node_slave->poll_query_until('postgres',
+ "SELECT NOT pg_is_
On Wed, Jan 15, 2014 at 9:29 PM, Andres Freund wrote:
> Hi Fujii, Michael,
>
> Coverity indicated that there's a problem with this - a quick look
> confirms that:
>
> foreach(lc, indexlist)
> (*toastidxs)[i++] = index_open(lfirst_oid(lc), lock);
>
> /* Fetch the first valid index i
On Wed, Jan 15, 2014 at 10:02 PM, Robert Haas wrote:
> On Wed, Jan 15, 2014 at 7:54 AM, Michael Paquier
> wrote:
>> Oops, good catch. If someone could show up and commit the attached to
>> master and REL9_3_STABLE...
>
> Hmm, I don't see an attachment.
Re-oops. S
On Sat, Feb 1, 2014 at 6:33 PM, Fujii Masao wrote:
> On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund wrote:
>> On 2014-02-01 16:47:47 +0900, Fujii Masao wrote:
>>> On Sat, Feb 1, 2014 at 12:50 PM, Robert Haas wrote:
>>> > Introduce replication slots.
>>> >
>>> > Replication slots are a crash-safe
On Thu, Feb 20, 2014 at 1:01 AM, David Fetter wrote:
> On Tue, Feb 18, 2014 at 04:39:27PM -0300, Alvaro Herrera wrote:
>> Heikki Linnakangas wrote:
>> > Add a GUC to report whether data page checksums are enabled.
>>
>> Is there are reason this wasn't back-patched to 9.3? I think it should
>> be.
On Wed, Mar 26, 2014 at 10:42 PM, Andrew Dunstan wrote:
> Which is another way of doing it, I guess. I'm not sure why the usual way
> wasn't adopted there.
Perhaps it was simply forgotten, it is done like that since pg_upgrade
a couple of years back with c2e9b2f.
--
Michael
--
Sent via pgsql-c
On Mon, May 5, 2014 at 5:04 PM, Amit Langote wrote:
> Spotted a typo:
>
> +
> +worker_spi_launch() in worker_spi shows an example if its use.
> +
> +
>
> s/example if/example of
s/((Robert/(Robert/g
--
Michael
--
Sent via pgsql-committers mailing list (pgsql-committ
On Tue, May 13, 2014 at 8:18 AM, Bruce Momjian wrote:
> On Mon, May 5, 2014 at 01:08:32PM +, Heikki Linnakangas wrote:
>> Replace SYSTEMQUOTEs with Windows-specific wrapper functions.
>>
>> It's easy to forget using SYSTEMQUOTEs when constructing command strings
>> for system() or popen(). Ev
On Thu, May 15, 2014 at 12:02 AM, Bruce Momjian wrote:
> On Tue, May 13, 2014 at 08:19:22AM +0900, Michael Paquier wrote:
>> On Tue, May 13, 2014 at 8:18 AM, Bruce Momjian wrote:
>> > On Mon, May 5, 2014 at 01:08:32PM +, Heikki Linnakangas wrote:
>> >> Rep
On Thu, Jul 3, 2014 at 4:08 AM, Andres Freund wrote:
> Rename logical decoding's pg_llog directory to pg_logical.
>
> The old name wasn't very descriptive as of actual contents of the
> directory, which are historical snapshots in the snapshots/
> subdirectory and mappingdata for rewritten tuples
On Tue, Jul 15, 2014 at 3:14 AM, Noah Misch wrote:
> contrib/test_decoding/Makefile sets MODULES, so omit OBJS.
>
> Michael Paquier
>
> Branch
> --
> master
>
> Details
> ---
> http://git.postgresql.org/pg/commitdiff/c0e8fb6148ce9c539f6fbde71f
On Mon, Aug 18, 2014 at 11:38 AM, Fujii Masao wrote:
> Add missing index terms for replication commands in the document.
>
> Previously only CREATE_REPLICATION_SLOT was exposed as an index term.
> That's odd and there is no reason not to add index terms for other
> replication commands.
Wouldn't i
On Thu, Aug 21, 2014 at 8:33 AM, Bruce Momjian wrote:
> On Mon, Aug 18, 2014 at 12:28:52PM +0900, Fujii Masao wrote:
>> I don't feel inclined to do that because it's not a bug fix.
>> I have no objection if many people want that, though...
>
> Agreed. I often avoid backpatching as it requires tho
On Thu, Aug 28, 2014 at 9:28 PM, Fujii Masao wrote:
> Oh,, will check.
That's a problem with pg_dump not able to put quotes where for a
reloption units are used.
For example this table:
create table test (a int) with (autovacuum_vacuum_cost_delay = '80ms');
Results in the following dump:
CREATE T
On Thu, Aug 28, 2014 at 10:51 PM, Michael Paquier
wrote:
> Because of how reloptions is registered in pg_class:
The patch attached fixes pg_upgrade by putting quotes when generating
reloptions and it passes check-world. I imagine that having quotes by
default in the value of reloptions
On Wed, Sep 10, 2014 at 10:04 AM, Andres Freund wrote:
> The best plan after that seems to be to add optional_argument support to
> getopt_long.c - looks easy enough. Do we need a configure test for
> optional_argument? I don't think so, but I could see somebody arguing
> the other way round.
Addi
On Thu, Sep 11, 2014 at 12:06 AM, Andres Freund wrote:
> I've attached a edited version of that patch. Besides cosmetic stuff I
> made one imo important change. Your version looked to the next argument
> for optional arguments: When --help is an optional argument and e.g. the
> commandline is "--h
On Thu, Aug 28, 2014 at 3:27 PM, Fujii Masao wrote:
> OK, reverted.
As this patch needs more care in the way it is stored in pg_class as
reloptions (need more logic to parse correctly units from the actual
values that are store), I just marked it as returned with feedback.
--
Michael
--
Sent v
On Fri, Sep 26, 2014 at 8:59 AM, Andres Freund wrote:
> Add a basic atomic ops API abstracting away platform/architecture details.
locust is not happy with this patch:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=locust&dt=2014-09-26%2000%3A00%3A48
Regards,
--
Michael
--
Sent via pg
On Fri, Sep 26, 2014 at 9:16 AM, Andres Freund wrote:
> On 2014-09-26 09:12:43 +0900, Michael Paquier wrote:
>> On Fri, Sep 26, 2014 at 8:59 AM, Andres Freund wrote:
>> > Add a basic atomic ops API abstracting away platform/architecture details.
>>
>> locust is not
On Sun, Oct 5, 2014 at 10:49 PM, Stephen Frost wrote:
> Coverity is complaining that the new Create/DropReplicatSlot functions
> leak, which is technically correct (though the cases where that happens
> end up being more-or-les immediate-exit cases anyway). In any case,
> here's a patch to clean
On Tue, Oct 7, 2014 at 3:32 AM, Tom Lane wrote:
> Stamp 9.4beta3.
>
Tag REL9_4_BETA3 seems to be still missing.
--
Michael
On Fri, Oct 17, 2014 at 8:31 PM, Andres Freund wrote:
> Thanks. That looks good. Sorry for you having to do that - I'd kind of
> hoped that Michael would send a patch...
>
Sorry, I simply slipped through it. The patch looks good.
--
Michael
On Mon, Oct 27, 2014 at 5:52 PM, Heikki Linnakangas
wrote:
> Fix two bugs in tsquery @> operator.
>
> 1. The comparison for matching terms used only the CRC to decide if there's
> a match. Two different terms with the same CRC gave a match.
>
> 2. It assumed that if the second operand has more ter
On Sat, Nov 1, 2014 at 10:22 PM, Peter Eisentraut wrote:
> On 10/25/14 2:00 PM, Heikki Linnakangas wrote:
> > Oops, I fumbled the backpatch of pg_upgrade changes.
> >
> > Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.
>
> This is still producing a compiler warning:
>
> check.c:471:2: error:
On Wed, Nov 26, 2014 at 7:33 AM, Simon Riggs wrote:
> On 25 November 2014 at 21:40, Stefan Kaltenbrunner
> wrote:
>> On 11/25/2014 09:14 PM, Simon Riggs wrote:
>>> action_at_recovery_target recovery config option
>>>
>>> action_at_recovery_target = pause | promote | shutdown
>>>
>>> Petr Jelinek
On Tue, Dec 2, 2014 at 4:13 AM, Alvaro Herrera wrote:
> Move security_label test
>
> Rather than have the core security_label regression test depend on the
> dummy_seclabel module, have that part of the test be executed by
> dummy_seclabel itself directly. This simplifies the testing rig a bit;
>
earlier parameters, per
> Michael Paquier.
Robert has mentioned here
(ca+tgmoz5aenvfrj2+dr9hy4z3xay_orqzctz7v0qccxqohu...@mail.gmail.com)
as well about simply removing any reference to
pause_at_recovery_action in the code and in the docs, or at least it
is what I understood. Agreeing on this i
On Tue, Dec 9, 2014 at 3:31 PM, Tom Lane wrote:
> Simon Riggs writes:
>> REINDEX SCHEMA
>
> The results from jagarundi and leech suggest that more attention needs to
> be paid to ensuring that tables are reindexed in a consistent order.
> Either that, or you're going to have to dumb down the regr
On Tue, Dec 9, 2014 at 4:56 PM, Michael Paquier
wrote:
> On Tue, Dec 9, 2014 at 3:31 PM, Tom Lane wrote:
>> Simon Riggs writes:
>>> REINDEX SCHEMA
>>
>> The results from jagarundi and leech suggest that more attention needs to
>> be paid to ensuring that
On Thu, Dec 25, 2014 at 10:43 PM, Andres Freund wrote:
> On 2014-12-25 22:39:58 +0900, Fujii Masao wrote:
>> On Thu, Dec 25, 2014 at 8:47 PM, Fujii Masao wrote:
>> > Move pg_lzcompress.c to src/common.
>> >
>> > Exposing compression and decompression APIs of pglz makes possible its
>> > use by ex
On Fri, Dec 26, 2014 at 3:31 AM, Tom Lane wrote:
> Andres Freund writes:
>> Surely not. It seems like a much better idea to not have lzcompress deal
>> with varlena at all but pass that responsibility one layer upwards. That
>> shouldn't be very hard.
I'll figure out something.
> and as noted, i
On Mon, Feb 9, 2015 at 6:18 PM, Heikki Linnakangas
wrote:
> Move pg_crc.c to src/common, and remove pg_crc_tables.h
> (snip)
> contrib/hstore/hstore_gist.c |2 +-
> contrib/ltree/crc32.c |2 +-
> src/backend/utils/adt/tsquery.c |1 +
> src/common/Makefile
On Sat, Feb 21, 2015 at 10:16 AM, Alvaro Herrera
wrote:
> Tom Lane wrote:
>
>> A relevant technique that's been used in a lot of our code is to define
>> an intermediate macro, along the lines of
>>
>> #define SizeofHeapTupleHeader offsetof(HeapTupleHeaderData, t_bits)
>>
>> or maybe it would bett
On Wed, Mar 11, 2015 at 10:20 PM, Alvaro Herrera
wrote:
> Refactor Mkvcbuild.pm to facilitate modules migrations
>
> This is in preparation to "upgrade" some modules from contrib/ to
> src/bin/, per discussion.
Just noticed that:
s/frontent/frontend
Sorry.
--
Michael
--
Sent via pgsql-committ
On Wed, Mar 11, 2015 at 11:18 PM, Andres Freund wrote:
> On 2015-03-11 06:54:16 +, Fujii Masao wrote:
>> Add GUC to enable compression of full page images stored in WAL.
>
> This triggers a couple warnings here (gcc 4.9 and 5):
>
> /home/andres/src/postgresql/src/backend/access/transam/xlogins
On Thu, Mar 12, 2015 at 7:13 PM, Fujii Masao wrote:
> On Wed, Mar 11, 2015 at 11:30 PM, Michael Paquier wrote:
>> On Wed, Mar 11, 2015 at 11:18 PM, Andres Freund wrote:
>>> I've not checked whether they're spurious or not.
>
> Thanks for the report! We c
On Sat, Jan 24, 2015 at 3:06 AM, Alvaro Herrera wrote:
> vacuumdb: enable parallel mode
>
> This mode allows vacuumdb to open several server connections to vacuum
> or analyze several tables simultaneously.
Coverity is still complaining about this block of code where the
return code of PQsendQuer
On Mon, Mar 16, 2015 at 1:38 AM, Andres Freund wrote:
> Merge the various forms of transaction commit & abort records.
Coverity is complaining about the following block of code:
+ xact_info = XLogRecGetInfo(record) & XLOG_XACT_COMMIT;
+
+ if (xact_info != XLOG_XACT_COMMIT &&
+
On Thu, Mar 26, 2015 at 6:49 AM, Andres Freund wrote:
> Centralize definition of integer limits.
>
> Several submitted and even committed patches have run into the problem
> that C89, our baseline, does not provide minimum/maximum values for
> various integer datatypes. C99's stdint.h does, but we
On Mon, Mar 30, 2015 at 2:01 PM, Michael Paquier
wrote:
>
>
>
> On Thu, Mar 26, 2015 at 6:49 AM, Andres Freund wrote:
> > Centralize definition of integer limits.
> >
> > Several submitted and even committed patches have run into the problem
> > that C89, ou
On Mon, Mar 30, 2015 at 7:48 PM, Andres Freund wrote:
> Hi,
>
> On 2015-03-30 14:01:25 +0900, Michael Paquier wrote:
> > On Thu, Mar 26, 2015 at 6:49 AM, Andres Freund
> wrote:
> > > Centralize definition of integer limits.
> > >
> > > Several submi
On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera
wrote:
> psql: fix \connect with URIs and conninfo strings
>
> psql was already accepting conninfo strings as the first parameter in
> \connect, but the way it worked wasn't sane; some of the other
> parameters would get the previous connection's val
On Thu, Apr 2, 2015 at 10:29 AM, Michael Paquier
wrote:
>
>
>
> On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera
> wrote:
>
>> psql: fix \connect with URIs and conninfo strings
>>
>> psql was already accepting conninfo strings as the first parameter in
>&
On Thu, Apr 2, 2015 at 10:58 AM, Michael Paquier
wrote:
>
> On other Linux machines, tests for dblink are failing:
> + ERROR: could not load library
> "/usr/src/pgfarm/build/HEAD/inst/lib/postgresql/dblink.so":
> /usr/src/pgfarm/build/HEAD/inst/lib/lib
On Thu, Apr 2, 2015 at 11:49 AM, Tom Lane wrote:
> Michael Paquier writes:
> > The patch attached fixes all those inconsistencies (tested build on OSX
> and
> > Windows).
>
> I think this is going in the wrong direction entirely, ie doubling down
> on Alvaro's or
On Wed, Apr 8, 2015 at 11:06 AM, Fujii Masao wrote:
> Mark the second argument of pg_log as the translatable string in nls.mk.
nls.mk is still missing file_ops.c in GETTEXT_FILES as it contains
some calls to pg_fatal.
--
Michael
--
Sent via pgsql-committers mailing list (pgsql-committers@post
On Sun, Apr 12, 2015 at 10:17 AM, Alvaro Herrera wrote:
> What pg_basebackup's progress_report() does is have the message in the
> translatable part not include the \r; the \r is in a separate fprintf()
> call.
Like the attached then.
--
Michael
diff --git a/src/bin/pg_rewind/logging.c b/src/bin/
On Mon, Mar 30, 2015 at 9:02 AM, Tom Lane wrote:
> Fix multiple bugs and infelicities in pg_rewind.
>
> Bugs all spotted by Coverity, including wrong realloc() size request
> and memory leaks. Cosmetic improvements by me.
>
> The usage of the global variable "filemap" here is still pretty awful,
On Wed, Apr 15, 2015 at 4:55 PM, Heikki Linnakangas wrote:
> On 04/15/2015 06:41 AM, Fujii Masao wrote:
>> Another question is; should we output the progress report to stderr rather
>> than stdout? I thought this because I found that pg_basebackup reports
>> the progress to stderr.
>
>
> Yeah, prob
On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas
wrote:
> Error out in pg_rewind if lstat() fails.
>
> A "file not found" is expected if the source server is running, so don't
> complain about that. But any other error is definitely not expected.
Nitpicking: strings of pg_fatal need to have a
On Mon, Apr 20, 2015 at 11:39 AM, Peter Eisentraut wrote:
> Move pg_test_fsync from contrib/ to src/bin/
Point of detail that I just noticed: wouldn't it be better to have a
header in pg_test_fsync.c of a shape similar to the other files. Now
there is only that:
/*
*pg_test_fsync.c
*
On Wed, Apr 22, 2015 at 5:38 AM, Tom Lane wrote:
> (I chanced to notice this while wondering why hamster is failing on
> this test. I can't reproduce the failure locally, but ...)
>
With a very slow environment you will be able to reproduce the failure.
--
Michael
On Wed, Apr 22, 2015 at 8:37 PM, Heikki Linnakangas
wrote:
> Make the pg_rewind regression tests more robust on slow systems.
>
> There were a couple of hard-coded sleeps in the tests: to wait for standby
> to catch up with master, and to wait for promotion with "pg_ctl promote"
> to complete. Ins
On Mon, Apr 27, 2015 at 1:36 AM, Tom Lane wrote:
> Peter Eisentraut writes:
>> Add transforms feature
>
> I don't know why this patch is fooling around with compile/link flags,
> but it's broken at least prairiedog and some of the Windows critters.
It breaks as well on all the Windows machines u
On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote:
> w.r.t MSVC builds, it looks like we need entries in $contrib_extraincludes
> in src/tools/msvc/Mkvcbuild.pm at the very least.
If our goal is to put back to green the Windows nodes as quick as
possible, we could bypass their build this way ,
1 - 100 of 140 matches
Mail list logo
