Re: [DOCS] Questionable tag usage

2017-01-12 Thread Robert Haas
vs-link.html Eh, we use both and for internal links and surely want both to be validated. If that's no longer happening I don't think it will be long before it bites us. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-do

Re: [DOCS] [HACKERS] Questionable tag usage

2017-01-10 Thread Robert Haas
ay, we wouldn't care so much what > produces because we wouldn't be using it anymore anyway. > Not that that's a good reason to accept the inconsistency. Since I've spent a fair amount of brainpower trying to use rather than where possible, I'm not innately enthusiast

Re: [DOCS] [HACKERS] Questionable tag usage

2017-01-10 Thread Robert Haas
On Tue, Jan 10, 2017 at 10:58 AM, Tom Lane wrote: > Robert Haas writes: >> On Fri, Jan 6, 2017 at 10:18 AM, Tom Lane wrote: >>>> I don't think there are a lto of people who use dead tree editions anymore, >>>> but they certainly do exist. A lot of people

Re: [DOCS] [HACKERS] Questionable tag usage

2017-01-10 Thread Robert Haas
ve to mouse over it to find out that it would take you somewhere. > Not sure if that's enough of a usability fail to argue for keeping the > old way. Personally, I wouldn't sweat it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --

Re: [DOCS] monitoring.sgml - clarify length of query text displayed in pg_stat_statements

2016-12-02 Thread Robert Haas
rrect, so I have committed it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] Description tweak for vacuumdb

2016-01-06 Thread Robert Haas
probably tweak the phrasing here so that a non-clueful person wouldn't go astray. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [HACKERS] [DOCS] max_worker_processes on the standby

2015-12-11 Thread Robert Haas
On Wed, Dec 9, 2015 at 4:21 PM, Alvaro Herrera wrote: > Robert Haas wrote: >> On Mon, Dec 7, 2015 at 8:33 AM, Fujii Masao wrote: > >> > So firstly you will push those "latest" changes soon? >> >> It seems like these changes haven't been pushed

Re: [HACKERS] [DOCS] max_worker_processes on the standby

2015-12-09 Thread Robert Haas
ila) >> >> Not sure what is going on; my reading of the code certainly says that >> the data should be there. I'm looking into it. >> >> I also noticed that I didn't actually push the whole of the patch >> yesterday -- I neglected to "git add"

Re: [HACKERS] [DOCS] max_worker_processes on the standby

2015-10-30 Thread Robert Haas
vated in the standby because track_commit_timestamp is > enabled. This seems wrong already at this point. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [HACKERS] [DOCS] max_worker_processes on the standby

2015-10-20 Thread Robert Haas
it_ts code were changed > to use this new variable. I also removed the static variable Alvaro added in > previous commit because it's not needed anymore. That sounds good to me. On a quick read-through it looks OK too. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Ent

Re: [DOCS] max_worker_processes on the standby

2015-10-02 Thread Robert Haas
On Fri, Oct 2, 2015 at 2:59 PM, Alvaro Herrera wrote: > Robert Haas wrote: >> The standby can have the feature enabled even though the master has it >> disabled? That seems like it can only lead to heartache. > > Can you elaborate? Sort of. Our rule up until now has

Re: [DOCS] max_worker_processes on the standby

2015-10-02 Thread Robert Haas
ature enabled even though the master has it disabled? That seems like it can only lead to heartache. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] max_worker_processes on the standby

2015-08-08 Thread Robert Haas
ot to replay the WAL records for this feature, then the data on the standby could be partially there but not completely there after promotion, because the DBA might have flipped the switch on and off at different times. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Pos

Re: [DOCS] max_worker_processes on the standby

2015-08-04 Thread Robert Haas
On Tue, Aug 4, 2015 at 12:41 AM, Alvaro Herrera wrote: > Robert Haas wrote: >> On Thu, Jul 16, 2015 at 12:07 AM, Fujii Masao wrote: >> > One example which makes me a bit confusing is; both master and >> > standby are running fine with track_commit_timestamp disabled,

Re: [DOCS] max_worker_processes on the standby

2015-08-03 Thread Robert Haas
is not the same between > master and standby. Simple question is; why do we need to cause > the standby fail in this case? Since I'm not familiar with the code of > track_commit_timestamp yet, I'm not sure whether this behavior is > valid or not. Hmm, that seems like awfully

Re: [DOCS] bgworker / SPI docs patches

2015-07-30 Thread Robert Haas
o, I note > that worker_spi doesn't memset(0) its BackgroundWorker struct, so any > uninitialized fields will contain garbage. Including bgw_library_name and > bgw_function_name. That seems bad. Yeah, that stuff is bad. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterp

Re: [DOCS] bgworker / SPI docs patches

2015-07-29 Thread Robert Haas
On Wed, Jul 29, 2015 at 11:35 AM, Robert Haas wrote: > On Tue, Feb 17, 2015 at 3:29 AM, Craig Ringer wrote: >> After spending a while working on the BDR extension I've found that the >> current documentation on the SPI and bgworkers could use some more detail. >> >&g

Re: [DOCS] bgworker / SPI docs patches

2015-07-29 Thread Robert Haas
m on that point of style. Patch 0002 makes the docs build fail unless 0001 is applied first, so I can't pursue that unless you want to revise that accordingly. I've committed 0003, and will look at 0004 next. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgre

Re: [DOCS] Add link to partial unique index from Constraints (5.3)

2014-04-30 Thread Robert Haas
used to enforce uniqueness in a way other constraints > cannot provide. Currently, it not easy to find this type of constraint as > not a lot of people would read through documentation on indexes when looking > for constraints. I think adding something to that chapter would be good. --

Re: [DOCS] Call for GIST/GIN/SP-GIST opclass documentation

2014-04-08 Thread Robert Haas
ses.html > http://www.postgresql.org/docs/devel/static/gin-builtin-opclasses.html > http://www.postgresql.org/docs/devel/static/spgist-builtin-opclasses.html > > We never had any well-defined place to discuss such opclasses before, > but I think it's past time we did. +1. Great idea.

Re: [DOCS] [HACKERS] Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-09 Thread Robert Haas
the release notes will build as plain text; but that worry > won't go away unless we nuke the text output in all the branches. Sounds OK to me. If there's as many as two people using those files, I'll be surprised. (Of course, I've been surprised before.) -- Robert Haas Enter

[DOCS] Re: Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-05 Thread Robert Haas
ht to just nuke them, because who cares? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

[DOCS] Re: Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-04 Thread Robert Haas
On Tue, Feb 4, 2014 at 1:38 AM, Tom Lane wrote: > Noah Misch writes: >>> Robert Haas writes: >>>> I wonder if these standalone things are really worthwhile. > >> I wonder how difficult it would be to make sufficient link data available >> when >> b

Re: [DOCS] Small patch for "CREATE TRIGGER" documentation

2013-03-08 Thread Robert Haas
#SQL-CREATETRIGGER-NOTES > > More precise would be something along the lines "It is possible that > changes to the > column's value will not cause the trigger to be fired". > > The attached patch hopefully rewords the entire paragraph for clarity. I guess I pre

Re: [DOCS] Contrib module "xml2" status

2013-02-21 Thread Robert Haas
been repeatedly voted down on removing the deprecation text. Could we at least agree on changing the deprecation text to say "This module is deprecated and may be removed in a future release"? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --

Re: [DOCS] CREATE USER

2012-05-02 Thread Robert Haas
#x27;t warn about all of them. Now, one thing we could do is add a deprecation warning, stating that CREATEUSER may be removed in a future release, assuming we want to eventually remove it. But I don't think warning people that CREATEUSER means SUPERUSER and not CREATEROLE is very helpful.

Re: [DOCS] Date/Time Types : internals

2012-04-23 Thread Robert Haas
that calendar was in use. So which calendar are we using, Julian or Gregorian? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] separate Privileges section for SQL reference pages?

2012-04-18 Thread Robert Haas
me. Same here. I think that would be a really great improvement. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] Idea on indexes

2012-04-03 Thread Robert Haas
he current link is exactly where I'd expect it to be. I don't think there's a problem here; not everything can be made prominent. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgr

Re: [DOCS] [COMMITTERS] pgsql: Update docs on numeric storage requirements.

2012-03-23 Thread Robert Haas
On Thu, Mar 22, 2012 at 10:36 PM, Fujii Masao wrote: > On Fri, Mar 23, 2012 at 11:12 AM, Robert Haas wrote: >> On Thu, Mar 22, 2012 at 9:21 PM, Fujii Masao wrote: >>> On Fri, Mar 23, 2012 at 4:41 AM, Robert Haas wrote: >>>> Update docs on numeric storage requirem

Re: [DOCS] [COMMITTERS] pgsql: Update docs on numeric storage requirements.

2012-03-22 Thread Robert Haas
On Thu, Mar 22, 2012 at 9:21 PM, Fujii Masao wrote: > On Fri, Mar 23, 2012 at 4:41 AM, Robert Haas wrote: >> Update docs on numeric storage requirements. >> >> Since 9.1, the minimum overhead is three bytes, not five. > > Thanks for the commit! > > I think that i

Re: [DOCS] PQconninfoParse()

2012-03-22 Thread Robert Haas
On Tue, Oct 18, 2011 at 8:27 PM, Tom Lane wrote: > Robert Haas writes: >> On Sat, Oct 15, 2011 at 11:24 AM, Tom Lane wrote: >>> Uh, is that actually a true statement?  I thought the result *did* >>> include default values.  That's more or less the point of r

Re: [DOCS] [PATCH] Use idiomatic style for varlena structs

2012-03-22 Thread Robert Haas
varlena types are toastable).  The >> particular bit of docs here doesn't pretend to be explaining how to >> write toast-safe code.  I think it might be better from an expository >> standpoint to cover that separately, rather than try to work it into the >> very firs

Re: [DOCS] NUMERIC size

2012-03-22 Thread Robert Haas
committed in 9.1), its header > size is three, five or eight for now. Attached patch fixes this. Nice catch. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes

Re: [DOCS] Update documentation wrt visibility map/index-only scans

2012-03-21 Thread Robert Haas
(Not tested, as I couldn't figure out how to build docs on my system) Committed after some editing and markup repair. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to

Re: [DOCS] docs update for count(*) and index-only scans

2012-01-27 Thread Robert Haas
nces to "other SQL databases". I just modified this so that it's not outright wrong any more. I think it's still more pessimistic than is warranted, but I wasn't sure exactly how to rephrase it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postg

Re: [DOCS] Bug

2012-01-27 Thread Robert Haas
xt? I don't know, but I wish we had a way. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] Cannot build docs on Ubuntu 10.04?

2012-01-27 Thread Robert Haas
ion? I grow weary of figuring this out every time I set up a new machine. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] docs update for count(*) and index-only scans

2011-11-04 Thread Robert Haas
s we will be faster than them. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] Link to PAM pages broken

2011-10-28 Thread Robert Haas
issing pages. > > No response from kernel.org and the link still doesn't work, so we > still have 2 broken links. I'm happy to commit a doc patch if you have one, but otherwise I'm not sure what we can do. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] description of CHECKPOINT command confusing

2011-10-18 Thread Robert Haas
On Fri, Oct 14, 2011 at 1:17 AM, Fujii Masao wrote: >> Slightly updated patch attached. > > Looks good. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To mak

Re: [DOCS] PQconninfoParse()

2011-10-18 Thread Robert Haas
On Sat, Oct 15, 2011 at 11:24 AM, Tom Lane wrote: > Robert Haas writes: >> Maybe we should change this: > >> Note that only options explicitly specified in the string will have >> values set in the result array; no defaults are inserted. > >> To say something

Re: [DOCS] DROP TABLE can be issued by schema owner as well as table owner

2011-10-15 Thread Robert Haas
On Fri, Oct 14, 2011 at 11:11 AM, Bruce Momjian wrote: > Robert Haas wrote: >> On Thu, Oct 13, 2011 at 10:06 AM, Bruce Momjian wrote: >> > I applied the following documentation patch to clarify this issue, and >> > used generic wording "user with the proper permi

Re: [DOCS] PQconninfoParse()

2011-10-15 Thread Robert Haas
On Mon, Oct 10, 2011 at 1:31 PM, Dmitriy Igrishin wrote: > Hey Robert, > > 2011/10/10 Robert Haas >> >> On Tue, Sep 27, 2011 at 9:13 AM, Dmitriy Igrishin >> wrote: >> > First, >> > "Returns parsed connection options from the provided conn

Re: [DOCS] DROP TABLE can be issued by schema owner as well as table owner

2011-10-14 Thread Robert Haas
On Thu, Oct 13, 2011 at 10:06 AM, Bruce Momjian wrote: > I applied the following documentation patch to clarify this issue, and > used generic wording "user with the proper permissions". That doesn't seem like an improvement; what permissions are proper? -- Robert Ha

Re: [DOCS] Document DELETE/UPDATE command tag vs triggers

2011-10-12 Thread Robert Haas
On Wed, Oct 12, 2011 at 2:27 PM, Marti Raudsepp wrote: > On Wed, Oct 12, 2011 at 19:48, Robert Haas wrote: >> Well, I committed about five doc patches that day, and I had to decide >> for each one whether it was worth back-patching, > >> I decided against back-patching

Re: [DOCS] Document DELETE/UPDATE command tag vs triggers

2011-10-12 Thread Robert Haas
On Wed, Oct 12, 2011 at 4:39 AM, Marti Raudsepp wrote: > On Mon, Oct 10, 2011 at 19:58, Robert Haas wrote: >> Committed. > > Thanks! > > Do you think it should be backported to earlier versions too? As it > stands, the documentation is misleading. Well, I committed abo

Re: [DOCS] Discrepancy in 9.1 Documentation on CREATE ROLE

2011-10-12 Thread Robert Haas
On Wed, Oct 12, 2011 at 12:59 AM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Oct 11, 2011 at 11:59 AM, Tom Lane wrote: >>> I think removing them from the docs but continuing to accept them makes >>> sense.  We do still hear from people migrating from 7.4 or old

Re: [DOCS] Discrepancy in 9.1 Documentation on CREATE ROLE

2011-10-11 Thread Robert Haas
On Tue, Oct 11, 2011 at 11:59 AM, Tom Lane wrote: > Bruce Momjian writes: >> Robert Haas wrote: >>> On Tue, Oct 11, 2011 at 10:44 AM, Bruce Momjian wrote: >>>> Robert Haas wrote: >>>>> I wonder if we ought to consider removing CREATEUSER and NOC

Re: [DOCS] Discrepancy in 9.1 Documentation on CREATE ROLE

2011-10-11 Thread Robert Haas
On Tue, Oct 11, 2011 at 10:44 AM, Bruce Momjian wrote: > Robert Haas wrote: >> On Thu, Oct 6, 2011 at 10:48 PM, Ron Adams >> wrote: >> > The help for LOGIN/NOLOGIN at >> > http://www.postgresql.org/docs/9.1/static/sql-createrole.html: "...NOLOGIN >>

Re: [DOCS] Discrepancy in 9.1 Documentation on CREATE ROLE

2011-10-10 Thread Robert Haas
with the completely separate command CREATE USER. See http://www.postgresql.org/docs/9.1/static/sql-createuser.html I wonder if we ought to consider removing CREATEUSER and NOCREATEUSER as synonyms for SUPERUSER and NOSUPERUSER. It looks like that change was made in 8.1, which is n

Re: [DOCS] Small correction in http://www.postgresql.org/docs/9.0/interactive/wal-reliability.html

2011-10-10 Thread Robert Haas
tly, so this part actually > reads just: > >         SCSI drives use sdparm. > > Now.  Perhaps the following makes sense: > >         SCSI drives can be queried using camcontrol > identify, and the write cache both queried and changed using > sdparm when available. Done, i

Re: [DOCS] lo_manage trigger on updates

2011-10-10 Thread Robert Haas
as on ON TRUNCATE trigger as well. Patch? :-) -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] typo on libpq.sgml

2011-10-10 Thread Robert Haas
ter is ignored for >           connections made via a Unix-domain socket, or if keepalives are > disabled. >           It is only supported on systems where the TCP_KEEPINTVL >           socket option is available; on other systems, it has no effect. >           >         >         Fix

Re: [DOCS] Add pg_resetxlog into the index in the document

2011-10-10 Thread Robert Haas
On Wed, Oct 5, 2011 at 11:03 AM, Fujii Masao wrote: > It's helpful to add pg_resetxlog into the index in the document. > Patch attached. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list

Re: [DOCS] PQconninfoParse()

2011-10-10 Thread Robert Haas
t must be specified in > the documentation becase the name of the function mismatches its behaviour. What do you mean by "all" options? Where else are they coming from besides the connection string? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreS

Re: [DOCS] Document DELETE/UPDATE command tag vs triggers

2011-10-10 Thread Robert Haas
Feel free to add one. The categories, or topics, are editable: click on the > "CommitFest Topics" link near the top-right corner, next to the "New Patch" > link. Then "New Topic". Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [DOCS] create foreign table

2011-09-19 Thread Robert Haas
t; Home -> Documentation -> Manuals -> PostgreSQL 9.1 -> PUT YOUR CHAPTER HERE? > > like this: > > Home -> Documentation -> Manuals -> PostgreSQL 9.1 -> I. SQL Commands That's not a bad idea either. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com T

Re: [DOCS] Use of literal in SGML docs

2011-09-15 Thread Robert Haas
he 'literal' tag from some numbers, we > were not consistenly using 'literal' for constants in our docs. > > I can make the change if we decide what we consistently want, or maybe it > is fine as-is. I think it's fine as-is. -- Robert Haas EnterpriseDB: htt

Re: [DOCS] Building PDFs error: \pdfendlink ended up in different nesting level than \pd

2011-09-15 Thread Robert Haas
>> particular chapter. >> >> With the promotion of the contrib stuff, perhaps they should each get >> their own chapter in a new part. > > Is this a TODO?  Did we ever decide on this? Well, some of the contrib modules are such little stupid things that giving them t

Re: [DOCS] create foreign table

2011-09-15 Thread Robert Haas
required. We do document the meaning of server_name, which I think is probably what you were after. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscripti

Re: [DOCS] documenting contrib modules (was Re: Building PDFs error)

2011-09-15 Thread Robert Haas
On Mon, Sep 5, 2011 at 2:08 PM, Bruce Momjian wrote: > Is this a TODO? Well, it's on my personal TODO list to wear down Tom's resistance to the idea. But I'm not sure we have any project-wide consensus on it at this point. -- Robert Haas EnterpriseDB: http://www.en

Re: [DOCS] 5.3.5. Foreign Keys (The SQL Language) possible enhance

2011-09-15 Thread Robert Haas
On Sun, Sep 11, 2011 at 9:09 PM, Bruce Momjian wrote: > Robert Haas wrote: >> On Fri, May 6, 2011 at 9:50 PM, Grzegorz Szpetkowski >> wrote: >> > I have some remark about >> > >> > "Now it is impossible to create orders with product_no entrie

Re: [DOCS] postgres-9.1beta3 typo: recommendable --> recommended

2011-08-15 Thread Robert Haas
ot a natural english speaker but this sounds > like we are recommended to put the users in another database. probably > it is refering to the user's resources... maybe we can make it more > explicit? The only thing that seems weird about it to me is that recommendable is a word tha

Re: [DOCS] psql's ON_ERROR_STOP is misdocumented

2011-06-16 Thread Robert Haas
On Tue, Jun 14, 2011 at 11:14 AM, Tom Lane wrote: > Robert Haas writes: >> Hearing no objections, committed. > > Looking at this a second time, it needs spell-checked.  "variale"? Picky, picky. You say potato, I say potatoe. -- Robert Haas EnterpriseDB: http:/

Re: [DOCS] psql's ON_ERROR_STOP is misdocumented

2011-06-14 Thread Robert Haas
On Mon, Jun 13, 2011 at 11:01 AM, Robert Haas wrote: > On Thu, May 5, 2011 at 11:20 AM, Tom Lane wrote: >> The documentation for ON_ERROR_STOP states, or at least implies by >> omission, that it only affects the behavior in non-interactive scripts: >> >>        By

Re: [DOCS] Information about WAL Configuration needs an update

2011-06-14 Thread Robert Haas
On Mon, Jun 13, 2011 at 2:25 PM, Rafael Martinez wrote: > On Mon, 2011-06-13 at 13:24 -0400, Robert Haas wrote: >> On Fri, Jun 3, 2011 at 3:42 AM, Rafael Martinez >> > >> > You can see the graph with the generation of WAL files + some extra >> > information fo

Re: [DOCS] Documentation and explanatory diagrams

2011-06-14 Thread Robert Haas
27;t do that >> then all image additions have to be done by someone with the proper >> editor. > > Or at least, somebody passes it through the "proper editor" before > committing.  As long as said editor can read SVG output from a > reasonable range of other too

Re: [DOCS] Information about WAL Configuration needs an update

2011-06-13 Thread Robert Haas
Shouldn't we update the documentation with some > information about this? Perhaps, but we'd have to think of something intelligent to say about it first. We can't remove the old WAL files until we successfully checkpoint, and so I think if checkpoints are taking

Re: [DOCS] CIDR address in pg_hba.conf

2011-06-13 Thread Robert Haas
t; >> Even if it happens to work that way at the moment, do we want to >> encourage people to depend on such an implementation artifact? >> >> IOW, if you read "must" as "if you want to trust it to work in future >> versions, you must", the advic

Re: [DOCS] Add link to current_schemas in config.sgml

2011-06-13 Thread Robert Haas
On Mon, Jun 13, 2011 at 1:01 PM, Brendan Jurd wrote: > On 14 June 2011 02:58, Robert Haas wrote: >> On Mon, Jun 13, 2011 at 12:55 PM, Brendan Jurd wrote: >>> On 14 June 2011 02:39, Robert Haas wrote: >>>> On Tue, May 31, 2011 at 2:27 AM, Brendan Jurd wrote: &

Re: [DOCS] 7.2. Table Expressions suggestion about NATURAL JOIN

2011-06-13 Thread Robert Haas
ame names." > > To make that comprehensive you can add something like: "Note that if > there is no any "shared" column between tables, then NATURAL JOIN acts > like ON TRUE (that is, tables are cross-joined)", because it's not > obvious. Done, with diff

Re: [DOCS] Add link to current_schemas in config.sgml

2011-06-13 Thread Robert Haas
On Mon, Jun 13, 2011 at 12:55 PM, Brendan Jurd wrote: > On 14 June 2011 02:39, Robert Haas wrote: >> On Tue, May 31, 2011 at 2:27 AM, Brendan Jurd wrote: >>> This is just a quick docs patch to add a link to the mention of the >>> current_schemas function from

Re: [DOCS] DROP TABLE can be issued by schema owner as well as table owner

2011-06-13 Thread Robert Haas
ommand, NOT who might be able by indirect means to get rid of the object. To cover all bases, we could add ", or the superuser" to the end of the sentence. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] Add link to current_schemas in config.sgml

2011-06-13 Thread Robert Haas
On Tue, May 31, 2011 at 2:27 AM, Brendan Jurd wrote: > This is just a quick docs patch to add a link to the mention of the > current_schemas function from 18.10.1. Statement Behavior. Your patch got mangled by my email client, but I committed what I believe to be the same change. --

Re: [DOCS] synchronous_standby_names and hot_standby_feedback

2011-06-13 Thread Robert Haas
On Mon, Jun 13, 2011 at 6:29 AM, Fujii Masao wrote: > The GucContext of synchronous_standby_names and hot_standby_feedback > is PGC_SIGHUP, so the following should be added into the explanations about > those parameters. Attached patch does that. Committed. -- Robert Haas Enterpris

Re: [DOCS] Improve warnings around CREATE INDEX CONCURRENTLY

2011-06-13 Thread Robert Haas
ons one at a time, > +    obtaining shared locks on their virtual transaction identifiers to wait > for > +    them to complete. Alvaro, did you commit this? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] 7.2. Table Expressions FULL join is only supported with merge-joinable join conditions

2011-06-13 Thread Robert Haas
E t2.value = 'xxx'; ...which are not equivalent to each other, or to the original query. It'd be nice to document this better, but I don't have a clear feeling for exactly what is needed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] Please help me to build docs on the latest 9.1

2011-06-13 Thread Robert Haas
d you tell me what might be the cause? The situation is as > follows: > > The latest commit on my Git repository that "git log -1" shows is. I believe Andrew has fixed this problem. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [DOCS] 7.1. Overview (The SQL Language)

2011-06-13 Thread Robert Haas
, or people will get confused. The next sentence would need some thought, too: The select list specification * means all columns that the table expression happens to provide. Possibly we could add a footnote? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreS

Re: [DOCS] psql's ON_ERROR_STOP is misdocumented

2011-06-13 Thread Robert Haas
RROR_STOP 1 > regression=# select 1/0; select 2; > ERROR:  division by zero > regression=# > > Can we get the docs changed to reflect reality? Here's an attempt at some suitable word-smithing. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

Re: [DOCS] Missing doc for operator args in alter extension

2011-06-13 Thread Robert Haas
On Thu, Apr 7, 2011 at 9:49 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Apr 4, 2011 at 9:10 PM, Daniele Varrazzo >> wrote: >>> the documentation for ALTER EXTENSION is missing the description for >>> the arguments of the form ADD OPERATOR name (left_t

Re: [DOCS] [COMMITTERS] pgsql: More foreign table documentation improvements.

2011-06-13 Thread Robert Haas
On Mon, Jun 13, 2011 at 9:56 AM, Fujii Masao wrote: > On Mon, Jun 13, 2011 at 9:30 PM, Robert Haas wrote: >> More foreign table documentation improvements. >> >> Shigeru Hanada, with some additional wordsmithing by me > > This commit caused the following

[DOCS] Re: [BUGS] BUG #5926: information schema dtd_identifier for element_types, columns, parameters views inconsistent

2011-06-02 Thread Robert Haas
On Wed, May 25, 2011 at 7:29 AM, Susanne Ebrecht wrote: > I think we should fix the documentation here. Patch? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to y

Re: [DOCS] [HACKERS] DOCS: SGML identifier may not exceed 44 characters

2011-06-01 Thread Robert Haas
ther to report it because my machine and openjade are quite old: > > The machine is Red Hat Enterprise Linux ES release 3 (Taroon Update 9), > and docbook.dcl is from the docbook-dtds-1.0-17.2 RPM. > > Maybe that really only affects quite old versions, but I think it wouldn't >

Re: [DOCS] ALTER TABLE doc small thing

2011-05-19 Thread Robert Haas
thing > (maybe just impression purpose). I guess we could remove it, but I don't think it's really doing any harm. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make

Re: [DOCS] 5.3.5. Foreign Keys (The SQL Language) possible enhance

2011-05-19 Thread Robert Haas
_id integer PRIMARY KEY, >    product_no integer REFERENCES products (product_no) NOT NULL, >    quantity integer > ); I don't think we should change the example, but we could probably clarify the wording. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterp

Re: [DOCS] createuser/dropuser username

2011-05-19 Thread Robert Haas
es are doing implicit > quoting (when CREATE ROLE is not), which I think is not fully known > and is undocumented here. For example: I'm not sure this really needs to be documented, but what exactly do you have in mind? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The En

Re: [DOCS] [HACKERS] Uppercase SGML entity declarations

2011-04-14 Thread Robert Haas
On Tue, Apr 5, 2011 at 6:55 PM, Josh Kupershmidt wrote: > On Mon, Apr 4, 2011 at 3:02 PM, Robert Haas wrote: >> In theory, we have >> documentation that explains this: >> >> http://www.postgresql.org/docs/current/static/docguide-toolsets.html > > While we'

Re: [DOCS] [HACKERS] Uppercase SGML entity declarations

2011-04-05 Thread Robert Haas
On Tue, Apr 5, 2011 at 4:59 PM, Peter Eisentraut wrote: > On tis, 2011-04-05 at 14:55 -0400, Robert Haas wrote: >> and I've also had failures, I believe, >> from not being connected to the Internet, which is surprising because >> it's not at all obvious that buil

Re: [DOCS] [HACKERS] Uppercase SGML entity declarations

2011-04-05 Thread Robert Haas
On Tue, Apr 5, 2011 at 2:18 PM, Peter Eisentraut wrote: > On mån, 2011-04-04 at 15:02 -0400, Robert Haas wrote: >> AFAICT, the biggest problem with our existing toolchain is that it's >> hard for some people to get it working.  In theory, we have >> documentation that

Re: [DOCS] Missing doc for operator args in alter extension

2011-04-05 Thread Robert Haas
bvious what to > do for unary operators (i.e. replace the type on the missing side with > NONE). > > Patch to fix the doc attached. I think we might want to make the synopsis, as well as the description of left_arg and right_arg, match what's on the DROP OPERATOR page. Thoug

Re: [DOCS] number of semaphores and semaphore sets

2011-04-05 Thread Robert Haas
ently 3) Yeah, I think you're right. It appears that nothing material has changed here since 8.3, so I'm inclined to back-patch this doc fix back that far. Barring objections, I'll go change this. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Com

Re: [DOCS] Add strftime escapes to Log config

2011-04-05 Thread Robert Haas
On Tue, Mar 29, 2011 at 2:53 PM, Josh Berkus wrote: >> We could also link to >> <http://pubs.opengroup.org/onlinepubs/007908799/xsh/strftime.html>, for >> example. > > That would be helpful.  I still think we want a few examples in our > docs, though. Patch? -

Re: [DOCS] high-availibility..sgml typos

2011-04-05 Thread Robert Haas
On Tue, Apr 5, 2011 at 3:04 AM, Erik Rijkers wrote: > typos. I committed the first two, but I didn't remove the word "then" from "the WAL is then sent to the standby" because I don't think that's a typo. -- Robert Haas EnterpriseDB: http://www.enterprisedb

Re: [DOCS] [HACKERS] Uppercase SGML entity declarations

2011-04-04 Thread Robert Haas
ught changing this at source level would be >> something to propose and submit. > > Given the lack of objections, I have pushed this patch.  Thanks. I think you still need to update Solution.pm to match. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Com

Re: [DOCS] [HACKERS] Uppercase SGML entity declarations

2011-04-04 Thread Robert Haas
ns this: http://www.postgresql.org/docs/current/static/docguide-toolsets.html However, in contrast to the vast majority of our documentation, it stinks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@pos

Re: [DOCS] [HACKERS] Uppercase SGML entity declarations

2011-04-04 Thread Robert Haas
On Mon, Apr 4, 2011 at 2:42 PM, Tom Lane wrote: > Robert Haas writes: >> Even if that doesn't turn out to be the case, this is pretty harmless, >> so maybe we should just apply it and move on. > > I have no great objection to the patch as such; just wondering what the &

Re: [DOCS] [HACKERS] Uppercase SGML entity declarations

2011-04-04 Thread Robert Haas
t apply it and move on. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs

Re: [DOCS] [HACKERS] Uppercase SGML entity declarations

2011-04-04 Thread Robert Haas
king what may seem like a stupid question, but what's not XML compliant about them now, and why do we care? The text is only ever going to parse as SGML (not XML) so I guess I don't see why it matters. I don't really object to the proposed patch but I guess I'm not sure what it

  1   2   3   >