Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid

2019-03-08 Thread Noah Misch
On Wed, Mar 06, 2019 at 07:24:22PM -0800, Noah Misch wrote: > On Mon, Mar 04, 2019 at 06:04:20PM +0900, Kyotaro HORIGUCHI wrote: > > PGSharedMemoryCreate changed to choose a usable shmem id using > > the IpcMemoryAnalyze(). But some of the statuses from > > IpcMemoryAnalyze() is concealed by

Re: Is it too soon for a PG12 open items wiki page?

2019-03-08 Thread David Rowley
On Sat, 9 Mar 2019 at 13:03, Michael Paquier wrote: > It would be a good timing as some issues are already showing up. And > abracadabra: > https://wiki.postgresql.org/wiki/PostgreSQL_12_Open_Items Thanks. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL

Re: Ordered Partitioned Table Scans

2019-03-08 Thread David Rowley
On Sat, 9 Mar 2019 at 09:14, Tom Lane wrote: > I took a quick look through this and I'm not very happy with it. > It seems to me that the premise ought to be "just use an Append > if we can prove the output would be ordered anyway", but that's not > what we actually have here: instead you're

proposal: type info support functions for functions that use "any" type

2019-03-08 Thread Pavel Stehule
Hi, Tom introduced supported functions for calculation function's selectivity. Still I have similar idea to use supported function for calculation function's parameter's types and function return type. Motivation: Reduce a necessity of overloading of functions. My motivation is related primary

Re: \describe*

2019-03-08 Thread Pavel Stehule
Hi > Since this is now waiting for v13, there's a bit more time to entertain > the question of whether we'd rather have these in psql or in a new server > command DESCRIBE [verbose] [system], and if so, whether the output of that > would itself be query-able or not. > Including this feature in

Re: Hash index initial size is too large given NULLs or partial indexes

2019-03-08 Thread Amit Kapila
On Fri, Mar 8, 2019 at 11:57 PM Tomas Vondra wrote: > On 3/8/19 7:14 PM, Jeff Janes wrote: > > > This goes back to when the pre-sizing was implemented in 2008 > > (c9a1cc694abef737548a2a). It seems to be an oversight, rather than > > something that was considered. > > > > Is this a bug that

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Pavel Stehule
pá 8. 3. 2019 v 19:48 odesílatel Pavel Stehule napsal: > > > pá 8. 3. 2019 v 19:44 odesílatel Alvaro Herrera > napsal: > >> On 2019-Mar-08, Alvaro Herrera wrote: >> >> > > Maybe we can call explicitly xmlFreeDoc instead xmlFreeNode >> > > >> > > some like >> > > >> > > if (cur_copy->type ==

Re: Pluggable Storage - Andres's take

2019-03-08 Thread Andres Freund
Hi, On 2019-03-09 11:03:21 +1100, Haribabu Kommi wrote: > Here I attached the rebased patches that I shared earlier. I am adding the > comments to explain the API's in the code, will share those patches later. I've started to add those for the callbacks in the first commit. I'd appreciate a

Re: Should we increase the default vacuum_cost_limit?

2019-03-08 Thread Tom Lane
I wrote: > [ worries about overflow with VacuumCostLimit approaching INT_MAX ] Actually, now that I think a bit harder, that disquisition was silly. In fact, I'm inclined to argue that the already-committed patch is taking the wrong approach, and we should revert it in favor of a different idea.

Re: Re: proposal: make NOTIFY list de-duplication optional

2019-03-08 Thread Thomas Munro
On Fri, Mar 8, 2019 at 1:37 PM Filip Rembiałkowski wrote: > See attached patch... I'm ready to work on so it can get merged in the next > CF. Hi Filip, Seen on Travis: async... FAILED 126 ms Looks like the new error isn't being raised for invalid send mode?

Re: Should we increase the default vacuum_cost_limit?

2019-03-08 Thread Tom Lane
Andrew Dunstan writes: > Increase it to what? Jeff's opinion that it could be INT_MAX without causing trouble is a bit over-optimistic, see vacuum_delay_point(): if (VacuumCostActive && !InterruptPending && VacuumCostBalance >= VacuumCostLimit) { intmsec;

Re: dropdb --force

2019-03-08 Thread Thomas Munro
On Wed, Mar 6, 2019 at 1:39 PM Filip Rembiałkowski wrote: > Here is Pavel's patch rebased to master branch, added the dropdb > --force option, a test case & documentation. Hello, cfbot.cputube.org says this fails on Windows, due to a missing semicolon here: #ifdef HAVE_SETSID

Re: Should we increase the default vacuum_cost_limit?

2019-03-08 Thread Andrew Dunstan
On 3/8/19 6:47 PM, David Rowley wrote: > On Sat, 9 Mar 2019 at 07:10, Tom Lane wrote: >> Jeff Janes writes: >>> Now that this is done, the default value is only 5x below the hard-coded >>> maximum of 10,000. >>> This seems a bit odd, and not very future-proof. Especially since the >>>

Re: Reaping Temp tables to avoid XID wraparound

2019-03-08 Thread Michael Paquier
On Fri, Mar 08, 2019 at 11:14:46AM -0800, Magnus Hagander wrote: > On Mon, Feb 25, 2019 at 10:45 PM Michael Paquier > wrote: >> One problem that I can see with your patch is that you would set the >> XID once any temporary object created, including when objects other >> than tables are created in

Re: pg_basebackup ignores the existing data directory permissions

2019-03-08 Thread Haribabu Kommi
On Fri, Mar 8, 2019 at 11:59 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > pg_basebackup copies the data directory permission mode from the > upstream server. But it doesn't copy the ownership. So if say the > upstream server allows group access and things are owned by >

Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru

2019-03-08 Thread Michael Paquier
On Fri, Mar 08, 2019 at 05:05:53PM -0500, Andrew Dunstan wrote: > I notice that this seems never to have been acted on. I think we should > apply this and remove the (confusing) message setting for the case we'll > now be avoiding. If not we should at least comment there that this is a > case we

Re: Ordered Partitioned Table Scans

2019-03-08 Thread David Rowley
On Sat, 9 Mar 2019 at 10:52, Tom Lane wrote: > > Julien Rouhaud writes: > > On Fri, Mar 8, 2019 at 9:15 PM Tom Lane wrote: > >> I think you should remove all that > >> and restrict this optimization to the case where all the subpaths are > >> natively ordered --- if we have to insert Sorts,

Re: \describe*

2019-03-08 Thread Corey Huinker
On Mon, Mar 4, 2019 at 1:45 PM Corey Huinker wrote: > >>> - Tab completion for \descibe-verbose. >>> I know that \d+ tab completion is also not there, but I think we must >>> have tab completion for \descibe-verbose. >>> >>> postgres=# \describe- >>> \describe-extension >>>

Re: Performance issue in foreign-key-aware join estimation

2019-03-08 Thread David Rowley
On Sat, 9 Mar 2019 at 08:05, Tom Lane wrote: > Setting the CF entry to WOA for now. I wonder though if we should > just push it out to v13 immediately --- are you intending to do more > with it in the near future? Thanks a lot for going over this and providing feedback. I put the patch out

Re: Fwd: Add tablespace tap test to pg_rewind

2019-03-08 Thread Michael Paquier
On Fri, Mar 08, 2019 at 09:42:29PM +0800, Shaoqi Bai wrote: > There is already a databases tap tests in pg_rewind, wonder if there is a > need for tablespace tap tests in pg_rewind. Attached is a initial > patch from me. When working on the first version of pg_rewind for VMware with Heikki,

Re: Is it too soon for a PG12 open items wiki page?

2019-03-08 Thread Michael Paquier
On Fri, Mar 08, 2019 at 10:06:43PM +0900, Amit Langote wrote: > On Fri, Mar 8, 2019 at 7:52 PM Julien Rouhaud wrote: >> It seems like a good timing to me. It would be a good timing as some issues are already showing up. And abracadabra: https://wiki.postgresql.org/wiki/PostgreSQL_12_Open_Items

Re: Pluggable Storage - Andres's take

2019-03-08 Thread Haribabu Kommi
On Thu, Mar 7, 2019 at 6:33 AM Andres Freund wrote: > Hi, > > On 2019-03-05 23:07:21 -0800, Andres Freund wrote: > > My next steps are: > > - final polish & push the basic DDL and pg_dump patches > > Done and pushed. Some collation dependent fallout, I'm hoping I've just > fixed that. > Thanks

Re: Tighten error control for OpenTransientFile/CloseTransientFile

2019-03-08 Thread Michael Paquier
On Fri, Mar 08, 2019 at 10:23:24AM +0900, Michael Paquier wrote: > Argh... Thanks for the lookup, Alvaro. And committed, after an extra pass to beautify the whole experience. -- Michael signature.asc Description: PGP signature

Re: Should we increase the default vacuum_cost_limit?

2019-03-08 Thread David Rowley
On Sat, 9 Mar 2019 at 07:10, Tom Lane wrote: > > Jeff Janes writes: > > Now that this is done, the default value is only 5x below the hard-coded > > maximum of 10,000. > > This seems a bit odd, and not very future-proof. Especially since the > > hard-coded maximum appears to have no logic to it

Re: Checksum errors in pg_stat_database

2019-03-08 Thread Magnus Hagander
On Mon, Mar 4, 2019 at 11:31 AM Julien Rouhaud wrote: > On Fri, Feb 22, 2019 at 3:01 PM Magnus Hagander > wrote: > > > > It tracks things that happen in the general backends. Possibly we should > also consider counting the errors actually found when running base backups? > OTOH, that part of

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-08 Thread Andres Freund
Hi, On 2019-03-08 20:18:27 -0300, Alvaro Herrera wrote: > On 2019-Mar-07, Robert Haas wrote: > > > On Wed, Mar 6, 2019 at 3:41 PM Andres Freund wrote: > > > I think we probably should have pg_dump suppress emitting information > > > about the toast table of partitioned tables? > > > > +1.

Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

2019-03-08 Thread Alvaro Herrera
On 2019-Mar-07, Robert Haas wrote: > On Wed, Mar 6, 2019 at 3:41 PM Andres Freund wrote: > > I think we probably should have pg_dump suppress emitting information > > about the toast table of partitioned tables? > > +1. That seems like the right fix. This patch fixes the upgrade problem for

Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru

2019-03-08 Thread Andrew Dunstan
On 10/9/18 5:15 AM, Kyotaro HORIGUCHI wrote: > At Fri, 5 Oct 2018 15:35:04 +0900, Michael Paquier > wrote in <20181005063504.gb14...@paquier.xyz> >> On Fri, Oct 05, 2018 at 12:16:03PM +0900, Michael Paquier wrote: >>> So, I have come back to this stuff, and finished with the attached >>>

Re: Ordered Partitioned Table Scans

2019-03-08 Thread Tom Lane
Julien Rouhaud writes: > On Fri, Mar 8, 2019 at 9:15 PM Tom Lane wrote: >> I think you should remove all that >> and restrict this optimization to the case where all the subpaths are >> natively ordered --- if we have to insert Sorts, it's hardly going to move >> the needle to worry about

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2019-03-08 Thread Peter Geoghegan
On Fri, Mar 8, 2019 at 10:48 AM Peter Geoghegan wrote: > All of that said, maybe it would be clearer if page deletion was not > the special case that has to opt in to minusinfkey semantics. Perhaps > it would make more sense for everyone else to opt out of minusinfkey > semantics, and to get the

Re: Ordered Partitioned Table Scans

2019-03-08 Thread Julien Rouhaud
On Fri, Mar 8, 2019 at 9:15 PM Tom Lane wrote: > > David Rowley writes: > > [ v9-0001-Allow-Append-to-be-used-in-place-of-MergeAppend-f.patch ] > > I think you should remove all that > and restrict this optimization to the case where all the subpaths are > natively ordered --- if we have to

Re: Checksum errors in pg_stat_database

2019-03-08 Thread Julien Rouhaud
On Mon, Mar 4, 2019 at 8:31 PM Julien Rouhaud wrote: > > On Fri, Feb 22, 2019 at 3:01 PM Magnus Hagander wrote: > > > > It tracks things that happen in the general backends. Possibly we should > > also consider counting the errors actually found when running base backups? > > OTOH, that part

Re: Oddity with parallel safety test for scan/join target in grouping_planner

2019-03-08 Thread Tom Lane
Etsuro Fujita writes: > (2019/02/28 0:52), Robert Haas wrote: >> On Tue, Feb 26, 2019 at 7:26 AM Etsuro Fujita >> wrote: >>> The parallel safety of the final scan/join target is determined from the >>> grouping target, not that target, which [ is wrong ] >> Your patch looks right to me. > I

Re: Ordered Partitioned Table Scans

2019-03-08 Thread Tom Lane
David Rowley writes: > [ v9-0001-Allow-Append-to-be-used-in-place-of-MergeAppend-f.patch ] I took a quick look through this and I'm not very happy with it. It seems to me that the premise ought to be "just use an Append if we can prove the output would be ordered anyway", but that's not what we

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2019-03-08 Thread Peter Geoghegan
On Fri, Mar 8, 2019 at 10:48 AM Peter Geoghegan wrote: > > Question: Wouldn't it be more straightforward to use "1 +inf" as page > > 1's high key? I.e treat any missing columns as positive infinity. > > That might also work, but it wouldn't be more straightforward on > balance. This is because:

Re: Reaping Temp tables to avoid XID wraparound

2019-03-08 Thread Magnus Hagander
On Mon, Feb 25, 2019 at 10:45 PM Michael Paquier wrote: > On Fri, Feb 22, 2019 at 04:01:02PM +0100, Magnus Hagander wrote: > > I did the "insert column in the middle of pg_stat_get_activity", I'm not > > sure that is right -- how do we treate that one? Do we just append at the > > end because

Re: Performance issue in foreign-key-aware join estimation

2019-03-08 Thread Tom Lane
David Rowley writes: > On Thu, 21 Feb 2019 at 15:00, Tom Lane wrote: >> Anyway, I rebased the POC patch up to HEAD, just in case anyone >> still wants to play with it. > Cool. Thanks. I haven't done any of the performance testing that this patch clearly needs, but just in a quick look through

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Pavel Stehule
pá 8. 3. 2019 v 19:44 odesílatel Alvaro Herrera napsal: > On 2019-Mar-08, Alvaro Herrera wrote: > > > > Maybe we can call explicitly xmlFreeDoc instead xmlFreeNode > > > > > > some like > > > > > > if (cur_copy->type == XML_DOCUMENT_NODE) > > > xmlFreeDoc((xmlDocPtr) cur_copy); > > > else > >

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2019-03-08 Thread Peter Geoghegan
On Fri, Mar 8, 2019 at 2:12 AM Heikki Linnakangas wrote: > Now, what do we have as the high key of page 1? Answer: "2 -inf". The > "-inf" is not stored in the key itself, the second key column is just > omitted, and the search code knows to treat it implicitly as a value > that's lower than any

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Alvaro Herrera
On 2019-Mar-08, Alvaro Herrera wrote: > > Maybe we can call explicitly xmlFreeDoc instead xmlFreeNode > > > > some like > > > > if (cur_copy->type == XML_DOCUMENT_NODE) > > xmlFreeDoc((xmlDocPtr) cur_copy); > > else > > xmlFreeNode(cur_copy); > > > > This looks most correct fix for me.

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Alvaro Herrera
(I spent some time trying to reproduce the original bug, but was interrupted for lunch before getting a useful installation. I find it a bit strange that it doesn't crash in x86_64, mind ...) On 2019-Mar-08, Pavel Stehule wrote: > It fixes current issue, but I afraid so these two routines are

Re: Hash index initial size is too large given NULLs or partial indexes

2019-03-08 Thread Tomas Vondra
On 3/8/19 7:14 PM, Jeff Janes wrote: > Referring to this thread: > > https://dba.stackexchange.com/questions/231647/why-are-partial-postgresql-hash-indices-not-smaller-than-full-indices > > When a hash index is created on a populated table, it estimates the > number of buckets to start out

Hash index initial size is too large given NULLs or partial indexes

2019-03-08 Thread Jeff Janes
Referring to this thread: https://dba.stackexchange.com/questions/231647/why-are-partial-postgresql-hash-indices-not-smaller-than-full-indices When a hash index is created on a populated table, it estimates the number of buckets to start out with based on the number of tuples returned by

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Pavel Stehule
pá 8. 3. 2019 v 15:31 odesílatel Alvaro Herrera napsal: > On 2019-Mar-08, Pavel Stehule wrote: > > > looks like error in xmlXPathCompiledEval function, that produce little > bit > > broken result for XML_DOCUMENT_NODE type. I hadn't this problem with > > libxml2 2.7.6 64bit, but I seen this

Re: Should we increase the default vacuum_cost_limit?

2019-03-08 Thread Tom Lane
Jeff Janes writes: > Now that this is done, the default value is only 5x below the hard-coded > maximum of 10,000. > This seems a bit odd, and not very future-proof. Especially since the > hard-coded maximum appears to have no logic to it anyway, at least none > that is documented. Is it just

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-03-08 Thread Tomas Vondra
On 3/8/19 5:38 PM, Antonin Houska wrote: > Antonin Houska wrote: > >> Masahiko Sawada wrote: >> >>> Agreed. >>> >>> For the WAL encryption, I wonder if we can have a encryption key >>> dedicated for WAL. Regardless of keys of tables and indexes all WAL >>> are encrypted with the WAL key. During

Re: Online verification of checksums

2019-03-08 Thread Julien Rouhaud
On Fri, Mar 8, 2019 at 6:50 PM Tomas Vondra wrote: > > On 3/8/19 4:19 PM, Julien Rouhaud wrote: > > On Thu, Mar 7, 2019 at 7:00 PM Andres Freund wrote: > >> > >> On 2019-03-07 12:53:30 +0100, Tomas Vondra wrote: > >>> > >>> But then again, we could just > >>> hack a special version of

Re: Online verification of checksums

2019-03-08 Thread Tomas Vondra
On 3/8/19 4:19 PM, Julien Rouhaud wrote: > On Thu, Mar 7, 2019 at 7:00 PM Andres Freund wrote: >> >> On 2019-03-07 12:53:30 +0100, Tomas Vondra wrote: >>> >>> But then again, we could just >>> hack a special version of ReadBuffer_common() which would just >> >>> (a) check if a page is in shared

Re: Why don't we have a small reserved OID range for patch revisions?

2019-03-08 Thread Tom Lane
John Naylor writes: >> On 2/8/19, Tom Lane wrote: >>> A script such as you suggest might be a good way to reduce the temptation >>> to get lazy at the last minute. Now that the catalog data is pretty >>> machine-readable, I suspect it wouldn't be very hard --- though I'm >>> not volunteering

Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)

2019-03-08 Thread Antonin Houska
Antonin Houska wrote: > Masahiko Sawada wrote: > > > Agreed. > > > > For the WAL encryption, I wonder if we can have a encryption key > > dedicated for WAL. Regardless of keys of tables and indexes all WAL > > are encrypted with the WAL key. During the recovery the startup > > process

Re: Problems with plan estimates in postgres_fdw

2019-03-08 Thread Antonin Houska
Etsuro Fujita wrote: > (2019/03/01 20:16), Antonin Houska wrote: > > Etsuro Fujita wrote: > > >> Conversely, it appears that add_foreign_ordered_paths() added by the > >> patchset > >> would generate such pre-sorted paths *redundantly* when the input_rel is > >> the > >> final scan/join

Re: Update does not move row across foreign partitions in v11

2019-03-08 Thread Amit Langote
On Sat, Mar 9, 2019 at 12:03 AM Alvaro Herrera wrote: > > On 2019-Mar-08, Amit Langote wrote: > > > On Fri, Mar 8, 2019 at 11:09 PM Alvaro Herrera > > wrote: > > > > I'm not sure about copying the same to ddl.sgml. Why is that needed? > > > Update is not DDL. > > > > Hmm, maybe because there's

Re: Minimal logical decoding on standbys

2019-03-08 Thread Amit Khandekar
On Mon, 4 Mar 2019 at 14:09, Amit Khandekar wrote: > > On Fri, 14 Dec 2018 at 06:25, Andres Freund wrote: > > I've a prototype attached, but let's discuss the details in a separate > > thread. This also needs to be changed for pluggable storage, as we don't > > know about table access methods in

Re: Should we increase the default vacuum_cost_limit?

2019-03-08 Thread Jeff Janes
On Wed, Mar 6, 2019 at 2:54 PM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > On 3/6/19 1:38 PM, Jeremy Schneider wrote: > > On 3/5/19 14:14, Andrew Dunstan wrote: > >> This patch is tiny, seems perfectly reasonable, and has plenty of > >> support. I'm going to commit it shortly

Re: Online verification of checksums

2019-03-08 Thread Julien Rouhaud
On Thu, Mar 7, 2019 at 7:00 PM Andres Freund wrote: > > On 2019-03-07 12:53:30 +0100, Tomas Vondra wrote: > > > > But then again, we could just > > hack a special version of ReadBuffer_common() which would just > > > (a) check if a page is in shared buffers, and if it is then consider the > >

Re: psql show URL with help

2019-03-08 Thread David Fetter
On Fri, Mar 08, 2019 at 01:45:03PM +0100, Peter Eisentraut wrote: > On 2019-03-07 23:02, David Fetter wrote: > >> if (psql_version_is_numeric) > >> return /docs/psql_version/ > >> else if (psql_version ends with 'devel') > >> return /docs/devel/ > >> else > >> return /docs/{psql_version but

Re: Update does not move row across foreign partitions in v11

2019-03-08 Thread Alvaro Herrera
On 2019-Mar-08, Amit Langote wrote: > On Fri, Mar 8, 2019 at 11:09 PM Alvaro Herrera > wrote: > > I'm not sure about copying the same to ddl.sgml. Why is that needed? > > Update is not DDL. > > Hmm, maybe because there's already a huge block of text describing > certain limitations of UPDATE

Re: Update does not move row across foreign partitions in v11

2019-03-08 Thread Amit Langote
On Fri, Mar 8, 2019 at 11:09 PM Alvaro Herrera wrote: > > On 2019-Mar-08, Amit Langote wrote: > > > diff --git a/doc/src/sgml/ref/update.sgml b/doc/src/sgml/ref/update.sgml > > index 77430a586c..f5cf8eab85 100644 > > --- a/doc/src/sgml/ref/update.sgml > > +++ b/doc/src/sgml/ref/update.sgml > > @@

Re: House style for DocBook documentation?

2019-03-08 Thread Chapman Flack
On 3/8/19 7:38 AM, Peter Eisentraut wrote: > On 2019-03-08 05:04, Chapman Flack wrote: >> -o If you want to supply text, use , else >> +o If you want to supply text, use or , else > > The choice of vs is for internal links. For external > links you have to use . Understood, but I was

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Alvaro Herrera
On 2019-Mar-08, Pavel Stehule wrote: > looks like error in xmlXPathCompiledEval function, that produce little bit > broken result for XML_DOCUMENT_NODE type. I hadn't this problem with > libxml2 2.7.6 64bit, but I seen this issue on same version on 32bit. > > Currently I had not fresh 32 bit

Re: Update does not move row across foreign partitions in v11

2019-03-08 Thread Alvaro Herrera
On 2019-Mar-08, Amit Langote wrote: > diff --git a/doc/src/sgml/ref/update.sgml b/doc/src/sgml/ref/update.sgml > index 77430a586c..f5cf8eab85 100644 > --- a/doc/src/sgml/ref/update.sgml > +++ b/doc/src/sgml/ref/update.sgml > @@ -291,9 +291,9 @@ UPDATE count > concurrent UPDATE or DELETE on

Re: Update does not move row across foreign partitions in v11

2019-03-08 Thread Amit Langote
On Fri, Mar 8, 2019 at 8:21 PM David Rowley wrote: > > On Sat, 9 Mar 2019 at 00:09, Etsuro Fujita > wrote: > > IMO I think it's better that we also mention that the UPDATE can move > > rows into a foreign partition if the FDW supports it. No? > > In my opinion, there's not much need to talk

Fwd: Add tablespace tap test to pg_rewind

2019-03-08 Thread Shaoqi Bai
Hi hackers, There is already a databases tap tests in pg_rewind, wonder if there is a need for tablespace tap tests in pg_rewind. Attached is a initial patch from me. Here is a patch for runing pg_rewind, it is very similar to src/bin/pg_rewind/t/002_databases.pl, but there is no

Re: Reporting script runtimes in pg_regress

2019-03-08 Thread Alvaro Herrera
On 2019-Mar-08, Christoph Berg wrote: > Re: Peter Eisentraut 2019-03-08 > <3eb194cf-b878-1f63-8623-6d6add0ed...@2ndquadrant.com> > > On 2019-02-21 10:37, Christoph Berg wrote: > > > diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c > > > index a18a6f6c45..8080626e94

Re: Is it too soon for a PG12 open items wiki page?

2019-03-08 Thread Amit Langote
On Fri, Mar 8, 2019 at 7:52 PM Julien Rouhaud wrote: > > On Fri, Mar 8, 2019 at 11:49 AM David Rowley > wrote: > > > > Is it too soon for a PG12 open items wiki page? > > It seems like a good timing to me. > > > I've got a few things I need to keep track of. Normally writing a > > patch and

Re: Reporting script runtimes in pg_regress

2019-03-08 Thread Christoph Berg
Re: Peter Eisentraut 2019-03-08 <3eb194cf-b878-1f63-8623-6d6add0ed...@2ndquadrant.com> > On 2019-02-21 10:37, Christoph Berg wrote: > > diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c > > index a18a6f6c45..8080626e94 100644 > > --- a/src/test/regress/pg_regress.c > >

Re: pg_basebackup ignores the existing data directory permissions

2019-03-08 Thread Peter Eisentraut
pg_basebackup copies the data directory permission mode from the upstream server. But it doesn't copy the ownership. So if say the upstream server allows group access and things are owned by postgres:postgres, and I want to make a copy for local development and make a backup into a directory

Re: Pluggable Storage - Andres's take

2019-03-08 Thread Dagfinn Ilmari Mannsåker
Andres Freund writes: > On 2019-03-07 08:52:21 -0500, Robert Haas wrote: >> On Wed, Mar 6, 2019 at 6:11 PM Andres Freund wrote: >> > slot that's compatible with the "target" table. You can get compatible >> > slot callbakcs by calling table_slot_callbacks(), or directly create one >> > by

Re: psql show URL with help

2019-03-08 Thread Peter Eisentraut
On 2019-03-07 23:02, David Fetter wrote: >> if (psql_version_is_numeric) >> return /docs/psql_version/ >> else if (psql_version ends with 'devel') >> return /docs/devel/ >> else >> return /docs/{psql_version but with text stripped}/ >> >> So that e.g. 12beta would return "12", as would 12rc

Re: House style for DocBook documentation?

2019-03-08 Thread Peter Eisentraut
On 2019-03-08 05:04, Chapman Flack wrote: > I only now noticed that probably this should also have been changed: > > -o If you want to supply text, use , else > +o If you want to supply text, use or , else The choice of vs is for internal links. For external links you have to use . --

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Pavel Stehule
pá 8. 3. 2019 v 13:20 odesílatel Alvaro Herrera napsal: > On 2019-Mar-08, Pavel Stehule wrote: > > > looks like error in xmlXPathCompiledEval function, that produce little > bit > > broken result for XML_DOCUMENT_NODE type. I hadn't this problem with > > libxml2 2.7.6 64bit, but I seen this

Re: Reporting script runtimes in pg_regress

2019-03-08 Thread Peter Eisentraut
On 2019-02-21 10:37, Christoph Berg wrote: > diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c > index a18a6f6c45..8080626e94 100644 > --- a/src/test/regress/pg_regress.c > +++ b/src/test/regress/pg_regress.c > @@ -1794,12 +1794,14 @@ run_schedule(const char *schedule,

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Alvaro Herrera
On 2019-Mar-08, Pavel Stehule wrote: > looks like error in xmlXPathCompiledEval function, that produce little bit > broken result for XML_DOCUMENT_NODE type. I hadn't this problem with > libxml2 2.7.6 64bit, but I seen this issue on same version on 32bit. > > Currently I had not fresh 32 bit

Re: Online verification of checksums

2019-03-08 Thread Michael Banck
Hi, Am Sonntag, den 03.03.2019, 11:51 +0100 schrieb Michael Banck: > Am Samstag, den 02.03.2019, 11:08 -0500 schrieb Stephen Frost: > > I'm not necessairly against skipping to the next file, to be clear, > > but I think I'd be happier if we kept reading the file until we > > actually get EOF. >

Re: WIP: Avoid creation of the free space map for small tables

2019-03-08 Thread Amit Kapila
On Fri, Mar 8, 2019 at 5:13 PM Amit Kapila wrote: > > > Few minor comments: .. > > 2. > + > + /* Transfer any VM files if we can trust their > contents. */ > if (vm_crashsafe_match) > > 3. Can we add a note about this in the Notes section of pg_upgrade > documentation [1]? > > This comment line

Re: WIP: Avoid creation of the free space map for small tables

2019-03-08 Thread Amit Kapila
On Wed, Mar 6, 2019 at 5:19 PM John Naylor wrote: > > On Fri, Jan 25, 2019 at 9:50 AM Amit Kapila wrote: > > Once we agree on the code, we need to test below scenarios: > > (a) upgrade from all supported versions to the latest version > > (b) upgrade standby with and without using rsync. > >

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Pavel Stehule
pá 8. 3. 2019 v 7:41 odesílatel Pavel Stehule napsal: > Hi > > pá 8. 3. 2019 v 3:44 odesílatel Alvaro Herrera > napsal: > >> On 2019-Mar-07, Alvaro Herrera wrote: >> >> > On 2019-Feb-11, Chapman Flack wrote: >> > >> > > xmltable-xpath-result-processing-bugfix-6.patch includes a >>

Re: WIP: Avoid creation of the free space map for small tables

2019-03-08 Thread Amit Kapila
On Mon, Jan 28, 2019 at 2:33 AM John Naylor wrote: > > On Sat, Jan 26, 2019 at 2:14 PM Amit Kapila wrote: > > > > I think there is some value in using the information from > > this function to skip fsm files, but the code doesn't appear to fit > > well, how about moving this check to new

Re: Update does not move row across foreign partitions in v11

2019-03-08 Thread David Rowley
On Sat, 9 Mar 2019 at 00:09, Etsuro Fujita wrote: > IMO I think it's better that we also mention that the UPDATE can move > rows into a foreign partition if the FDW supports it. No? In my opinion, there's not much need to talk about what the limitations are not when you're mentioning what the

Re: Update does not move row across foreign partitions in v11

2019-03-08 Thread Etsuro Fujita
(2019/03/08 19:29), David Rowley wrote: On Fri, 8 Mar 2019 at 15:07, Amit Langote wrote: David, can you confirm if the rewritten text reads unambiguous or perhaps suggest a better wording? So this is the text: + Currently, rows cannot be moved from a foreign-table partition to some +

Re: Is it too soon for a PG12 open items wiki page?

2019-03-08 Thread Julien Rouhaud
On Fri, Mar 8, 2019 at 11:49 AM David Rowley wrote: > > Is it too soon for a PG12 open items wiki page? It seems like a good timing to me. > I've got a few things I need to keep track of. Normally writing a > patch and putting on the next open CF is a good move, but since the > next one is not

Is it too soon for a PG12 open items wiki page?

2019-03-08 Thread David Rowley
Is it too soon for a PG12 open items wiki page? I've got a few things I need to keep track of. Normally writing a patch and putting on the next open CF is a good move, but since the next one is not for PG12, it seems like not the best place. Any objections to me making one now? -- David

Re: Update does not move row across foreign partitions in v11

2019-03-08 Thread David Rowley
On Fri, 8 Mar 2019 at 15:07, Amit Langote wrote: > David, can you confirm if the rewritten text reads unambiguous or perhaps > suggest a better wording? So this is the text: + Currently, rows cannot be moved from a foreign-table partition to some + other partition, but they can be

Add tablespace tap test to pg_rewind

2019-03-08 Thread Shaoqi Bai
Hi hackers, There is already a databases tap tests in pg_rewind, wonder if there is a need for tablespace tap tests in pg_rewind. Attached is a initial patch from me. Here is a patch for runing pg_rewind, it is very similar to src/bin/pg_rewind/t/002_databases.pl, but there is no

Re: Making all nbtree entries unique by having heap TIDs participate in comparisons

2019-03-08 Thread Heikki Linnakangas
On 08/03/2019 12:22, Peter Geoghegan wrote: I would like to work through these other items with you (_bt_binsrch_insert() and so on), but I think that it would be helpful if you made an effort to understand the minusinfkey stuff first. I spent a lot of time improving the explanation of that

Re: insensitive collations

2019-03-08 Thread Peter Eisentraut
On 2019-03-07 20:04, Daniel Verite wrote: > With previous versions, we'd need to call ucol_setAttribute(), > with the attributes and values defined here: > http://icu-project.org/apiref/icu4c/ucol_8h.html > for instance to get colStrength=secondary: > ucol_setAttribute(coll, UCOL_STRENGTH ,

Re: Small doc fix for pageinspect

2019-03-08 Thread Laurenz Albe
Michael Paquier wrote: > On Thu, Mar 07, 2019 at 09:00:24PM +0100, Laurenz Albe wrote: > > This should be backpatched down to 9.6 where the functions have been > > added. > > Thanks, applied. The second argument name of heap_page_item_attrs is > actually "page", and not "t_data", so both your

Re: Covering GiST indexes

2019-03-08 Thread Alexander Korotkov
On Wed, Jan 30, 2019 at 4:16 AM Andreas Karlsson wrote: > > On 29/01/2019 19.58, Andrey Borodin wrote: > > PFA patch without redundant checks. > > I hope it is ok that I fixed a typo and some wording in the comment, > plus re-added the btree query which I accidentally removed in my last mail. > >

Re: PostgreSQL vs SQL/XML Standards

2019-03-08 Thread Pavel Stehule
pá 8. 3. 2019 v 3:44 odesílatel Alvaro Herrera napsal: > On 2019-Mar-07, Alvaro Herrera wrote: > > > On 2019-Feb-11, Chapman Flack wrote: > > > > > xmltable-xpath-result-processing-bugfix-6.patch includes a > regress/expected > > > output for the no-libxml case that was left out of -5. > > > >

Re: pg_basebackup against older server versions

2019-03-08 Thread Sergei Kornilov
HiGreat, thank you! regards, Sergei

Re: [HACKERS] advanced partition matching algorithm for partition-wise join

2019-03-08 Thread Rajkumar Raghuwanshi
On Thu, Mar 7, 2019 at 8:20 PM amul sul wrote: > > > On Thu, Mar 7, 2019 at 1:02 PM amul sul wrote: > >> Thanks Rajkumar, >> >> I am looking into this. >> >> > The crash happens when none of the if-else branch of > handle_missing_partition() > evaluates and returns merged_index unassigned. > >

Re: [HACKERS] CLUSTER command progress monitor

2019-03-08 Thread Tatsuro Yamada
On 2019/03/06 15:38, Tatsuro Yamada wrote: On 2019/03/05 17:56, Tatsuro Yamada wrote: On 2019/03/05 11:35, Robert Haas wrote: On Mon, Mar 4, 2019 at 5:38 AM Tatsuro Yamada wrote: === Current design === CLUSTER command uses Index Scan or Seq Scan when scanning the heap. Depending on which

RE: Timeout parameters

2019-03-08 Thread Nagaura, Ryohei
Hi, Fabien-san. About TCP_USER_TIMEOUT: > From: Fabien COELHO > I could not really test the feature, i.e. I could not trigger a timeout. > Do you have a suggestion on how to test it? Please see the previous mail[1] or current kirk-san's mail. About socket_timeout: > From: Fabien COELHO > are