On Fri, 2 May 2025 at 09:23, vignesh C wrote:
>
> On Fri, 2 May 2025 at 06:30, Tom Lane wrote:
> >
> > vignesh C writes:
> > > I agree with your analysis. I was able to reproduce the issue by
> > > delaying the invalidation of the subscription until the w
On Fri, 2 May 2025 at 10:11, Xuneng Zhou wrote:
>
> Hi,
> Is this an expected behavior?
>
> A race between subscriber LSN feedback and publisher subscription change
> processing allows the walsender to restart decoding past relevant WAL
> records, bypassing the updated subscription rules for tho
On Fri, 2 May 2025 at 06:30, Tom Lane wrote:
>
> vignesh C writes:
> > I agree with your analysis. I was able to reproduce the issue by
> > delaying the invalidation of the subscription until the walsender
> > finished decoding the INSERT operation following the ALTER
&g
On Wed, 30 Apr 2025 at 17:41, Amit Kapila wrote:
>
> On Wed, Apr 30, 2025 at 11:22 AM Tom Lane wrote:
> >
> > Xuneng Zhou pointed out on Discord that the test case added by
> > 7c99dc587 has caused repeated failures in CI --- though oddly,
> > it's not failed in the buildfarm so far as I can find
Hi,
Currently, when a warning is emitted by the publisher, the
corresponding log message does not include the log prefix. This makes
it harder to correlate such messages with other log entries. For
example, in a simulated error scenario where directory removal fails,
the notice message lacks the s
On Sat, 12 Apr 2025 at 01:56, Jonathan S. Katz wrote:
>
> The Core Team would like to extend our congratulations to Jacob
> Champion, who has accepted an invitation to become our newest PostgreSQL
> committer.
>
> Please join us in wishing Jacob much success and few reverts!
Many Congratulations,
On Mon, 7 Apr 2025 at 20:37, vignesh C wrote:
>
Thanks a lot to all the members who participated in the commitfest.
Here are the final numbers at the end of the commitfest:
status | End of Commitfest
+---
Needs rev
Hi,
Thanks a lot to all the members who participated in the commitfest.
Here are the final numbers at the end of the commitfest:
status | End of Commitfest
+---
Needs review: |54
Waiting on Author: |
On Mon, 31 Mar 2025 at 08:34, vignesh C wrote:
>
> On Mon, 24 Mar 2025 at 10:07, vignesh C wrote:
Here's a quick commitfest status report as of today:
status | start | 17th | 24th | 31
On Tue, 1 Apr 2025 at 15:49, Kirill Reshke wrote:
>
> On Tue, 1 Apr 2025, 11:45 vignesh C, wrote:
>>
>>
>> One thing I noticed was that if the materialized view is not refreshed
>> user will get stale data
>>
>> Should we document this?
>
> Doe
On Tue, 18 Mar 2025 at 09:26, jian he wrote:
>
> changed based on this.
>
> also minor documentation tweaks.
Few comments:
1) I felt this is wrong:
diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 9a4d993e2bc..7980513a9bd 100644
--- a/src/bin/psql/tab-complete.in
On Mon, 31 Mar 2025 at 18:35, Bertrand Drouvot
wrote:
>
> Hi,
>
> On Mon, Mar 24, 2025 at 08:41:20AM +0900, Michael Paquier wrote:
> > On Wed, Mar 19, 2025 at 04:00:49PM +0800, Xuneng Zhou wrote:
> > > Hi,
> > > Moving the other two provides a more complete view of the settings. For
> > > newcomer
On Sun, 30 Mar 2025 at 00:20, Andres Freund wrote:
>
> On 2025-03-17 12:16:11 +0530, vignesh C wrote:
> > On Fri, 20 Dec 2024 at 10:50, Andreas Karlsson wrote:
> > >
> > > Hi,
> > >
> > > Jeff pointed out to me that the case conversion functions
On Wed, 2 Apr 2025 at 13:49, Ashutosh Bapat
wrote:
>
> On Tue, Apr 1, 2025 at 10:31 PM Alvaro Herrera
> wrote:
> >
> > On 2025-Apr-01, Ashutosh Bapat wrote:
> >
> > > Just today morning, I found something which looks like another bug in
> > > statistics dump/restore [1]. As Daniel has expressed
On Fri, 4 Apr 2025 at 10:31, Bertrand Drouvot
wrote:
>
> Hi,
>
> On Thu, Apr 03, 2025 at 03:23:31PM +0530, vignesh C wrote:
> > Can we add it to one of the subscription tests, such as 001_rep_changes.pl?
>
> Yeah that sounds like a good place for it. Done in the attac
On Fri, 4 Apr 2025 at 09:36, Amit Kapila wrote:
>
> A few comments:
> *
> pg_createsubscriber.exe -D ..\..\data_standby -d db1 -d db2 -d db1
> --publication pub1 --publication pub1 -P "dbname=postgres port=5432"
> -p 5444 --dry-run
> pg_createsubscriber: error: database "db1" specified more than o
On Thu, 3 Apr 2025 at 12:54, Bertrand Drouvot
wrote:
>
> Hi,
>
> On Thu, Apr 03, 2025 at 09:25:02AM +0530, vignesh C wrote:
> > On Mon, 31 Mar 2025 at 18:35, Bertrand Drouvot
> > wrote:
> > >
> > Couple of suggestions:
>
> Thanks for looking at
On Thu, 3 Apr 2025 at 09:07, Peter Smith wrote:
>
> Hi,
>
> I was away for the last few weeks when this feature got committed, so
> I missed the chance to post my comments earlier.
>
> It seems the final SGML docs are mostly from this [1] suggestion, but
> I think there are one or two more improve
On Tue, 1 Apr 2025 at 16:02, Andrew Dunstan wrote:
>
>
> On 2025-04-01 Tu 5:16 AM, vignesh C wrote:
> > On Sun, 2 Feb 2025 at 00:52, Lars Kanis wrote:
> >> This patch limits the workaround of using __buildin_setjmp on the
> >> Windows MINGW platform. This workar
On Tue, 1 Apr 2025 at 08:43, jian he wrote:
>
> On Mon, Mar 31, 2025 at 11:27 PM Fujii Masao
> wrote:
> >
> > Regarding the patch, here are some review comments:
> >
> > + errmsg("cannot copy from
> > materialized view when the materialized view is n
On Sun, 2 Feb 2025 at 00:52, Lars Kanis wrote:
>
> This patch limits the workaround of using __buildin_setjmp on the
> Windows MINGW platform. This workaround is only necessary for legacy
> MSVCRT based toolchain, but not for UCRT based. It is not available at
> all on clang on ARM64 resulting in
On Tue, 1 Apr 2025 at 06:31, jian he wrote:
>
> On Mon, Mar 31, 2025 at 4:05 PM Kirill Reshke wrote:
>
> Thanks for doing the benchmark.
Few comments to improve the comments, error message and remove
redundant assignment:
1) How about we change below:
/*
* partition's rowtype might differ from
On Mon, 24 Mar 2025 at 10:07, vignesh C wrote:
>
> On Mon, 17 Mar 2025 at 09:26, vignesh C wrote:
>
Here's a quick commitfest status report as of today:
status | start | 10th | 17th |
On Sat, 29 Mar 2025 at 12:08, jian he wrote:
>
>
> I consolidated it into a new function: CopyThisRelTo.
Few comments:
1) Here the error message is not correct, we are printing the original
table from where copy was done which is a regular table and not a
foreign table, we should use childreloid
On Fri, 28 Mar 2025 at 08:39, jian he wrote:
>
> hi.
>
> I made a mistake.
> The regress test sql file should have a new line at the end of the file.
Couple of suggestions:
1) Can you add some comments here, this is the only code that is
different from the regular table handling code:
+
On Wed, 19 Mar 2025 at 18:12, David Rowley wrote:
>
> On Wed, 19 Mar 2025 at 23:22, Ilia Evdokimov
> wrote:
> > Everything seems fine with the ANALYZE command autocompletion. Regarding
> > VACUUM, I'm not entirely convinced we should provide autocompletion in
> > every case. I'd prefer to keep
On Mon, 17 Mar 2025 at 05:49, Tom Lane wrote:
>
> Jelte Fennema-Nio writes:
> > On Sun, 15 Dec 2024 at 10:00, Alexander Lakhin wrote:
> >> shows that the subscription and publication tests are not concurrent-safe,
> >> because modifying the same pg_database entry might fail with the "tuple
> >>
On Tue, 25 Mar 2025 at 16:09, Ashutosh Bapat
wrote:
>
> On Mon, Mar 24, 2025 at 5:44 PM Alvaro Herrera
> wrote:
> >
> > On 2025-Mar-24, Ashutosh Bapat wrote:
> >
> > > One concern I have with directory format is the dumped database is not
> > > readable. This might make investigating a but ident
On Fri, 31 Jan 2025 at 21:05, Daniel Gustafsson wrote:
>
> > On 31 Jan 2025, at 16:29, Andres Freund wrote:
>
> >> #ifdef ENABLE_GSS
> >> -#if defined(HAVE_GSSAPI_H)
> >> -#include
> >> -#else
> >> -#include
> >> -#endif /* HAVE_GSSAPI_H */
> >> +#include "libpq/pg-gssapi.h"
> >> #endif /* ENAB
On Sat, 20 Jul 2024 at 00:03, Robert Haas wrote:
>
> On Tue, Jul 16, 2024 at 8:04 AM Yasir wrote:
> > Please ignore the above 4 lines in my review. See my comments in blue.
>
> OK, so I think it's unclear what the next steps are for this patch.
>
> 1. On June 3rd, Michael Paquier said that Tom La
On Wed, 31 Jul 2024 at 05:25, Noah Misch wrote:
>
> On Mon, Jul 15, 2024 at 03:44:48PM +1200, Thomas Munro wrote:
> > On Fri, Jul 12, 2024 at 11:43 PM Noah Misch wrote:
> > > On Sat, May 18, 2024 at 05:29:12PM +1200, Thomas Munro wrote:
> > > > On Fri, May 17, 2024 at 4:46 PM Thomas Munro
> > >
On Wed, 26 Mar 2025 at 02:05, Euler Taveira wrote:
>
> On Tue, Mar 25, 2025, at 8:07 AM, Shubham Khanna wrote:
>
> The following code is not accurate. If I specify --all, --database and
> --subscription, it will report only --database. The user will remove it and
> run
> again. At this time, --su
On Mon, 24 Mar 2025 at 13:21, jian he wrote:
>
> I am not sure this is what we want.
> Anyway, I attached both two version
Few comments
1) I understood the problem, your first approach is ok for me.
2) Here in error we say column c1 violates not-null constraint and in
the context we show column
On Fri, 21 Mar 2025 at 16:44, Nisha Moond wrote:
>
> On Fri, Mar 21, 2025 at 3:38 PM Amit Kapila wrote:
> >
> > On Fri, Mar 21, 2025 at 1:48 PM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Fri, Mar 21, 2025 at 12:50 PM Nisha Moond wrote:
> > >
> > > > Thanks, Hou-san, for the review and fix pa
On Sat, 1 Mar 2025 at 04:35, Jeff Davis wrote:
>
> On Mon, 2024-12-16 at 20:05 -0800, Jeff Davis wrote:
> > On Wed, 2024-10-30 at 08:08 -0700, Jeff Davis wrote:
> >
>
> Rebased v14.
>
> The approach has changed multiple times. It starte off with more in-
> core code, but in response to review feed
On Sat, 1 Mar 2025 at 04:35, Jeff Davis wrote:
>
> On Mon, 2024-12-16 at 20:05 -0800, Jeff Davis wrote:
> > On Wed, 2024-10-30 at 08:08 -0700, Jeff Davis wrote:
> >
>
> Rebased v14.
>
> The approach has changed multiple times. It starte off with more in-
> core code, but in response to review feed
On Mon, 17 Mar 2025 at 09:26, vignesh C wrote:
>
Here's a quick commitfest status report as of today:
status | start | 10th | 17th | 24th
+-+-+-+-
Needs review: | 198 | 182
Hi,
Currently, error reports for database, publication, subscription, and
replication slots do not include the option name. This has been
addressed by including the option name in the error messages, ensuring
consistency similar to remove option. Additionally, pg_log_error and
exit(1) have been re
On Fri, 21 Mar 2025 at 18:59, Shubham Khanna
wrote:
>
>
> During the recent testing, I observed that the tests were failing when
> using wait_for_slot_catchup(). To address this, I reverted to using
> wait_for_subscription_sync(), which was employed previously and has
> proven to be more reliable
On Tue, 11 Mar 2025 at 18:24, jian he wrote:
>
> after my change:
>
> COPY TO can be used only with plain tables, not views, and does not
> copy rows from child tables,
> however COPY TO can be used with partitioned tables.
> For example, in a table inheritance hierarchy, COPY table T
On Thu, 13 Mar 2025 at 18:10, Heikki Linnakangas wrote:
>
>
> Hmm, this problem isn't limited to this one pg_upgrade test, right? It
> could happen with any pg_upgrade invocation. And perhaps in a running
> server too, if a relfilenumber is reused quickly. In dropdb() and
> DropTableSpace() we do
On Thu, 20 Mar 2025 at 22:09, Alvaro Herrera wrote:
>
> On 2025-Mar-20, vignesh C wrote:
>
> > Will it help the execution time if we use --jobs in case of pg_dump
> > and pg_restore wherever supported:
>
> As I said in another thread, I think we should enable this test
On Wed, 19 Mar 2025 at 17:13, Ashutosh Bapat
wrote:
>
> On Thu, Mar 13, 2025 at 6:10 PM Ashutosh Bapat
> wrote:
> > >
> > > I think the fix is to explicitly pass --lc-monetary to the old cluster
> > > and the restored cluster. 003 patch in the attached patch set does
> > > that. Please check if i
On Thu, 20 Mar 2025 at 10:25, Shubham Khanna
wrote:
>
>
> I have created two patches, v16-0001 and v16-0002, to address the
> performance issue. I conducted performance testing, and here are the
> results:
> - The difference in execution time between HEAD and the v15 patch was 53.2%.
> - After rem
On Thu, 20 Mar 2025 at 09:06, Shubham Khanna
wrote:
>
> The attached patch contains the suggested changes.
Couple of minor comments:
1) The second and third line comments can be in same line:
+# Create user-defined publications, wait for streaming replication to sync them
+# to the standby, then
On Wed, 19 Mar 2025 at 14:46, Ilia Evdokimov
wrote:
>
> Looks good overall. However, after pressing Tab, ONLY appears in the
> completion list, but it doesn't autocomplete after typing the first letter.
In which case you noticed this?
Regards,
Vignesh
On Wed, 19 Mar 2025 at 14:32, Shubham Khanna
wrote:
>
>
> Changed -r to -R based on the shared analysis to avoid conflict with
> the --retain option used in pg_upgrade and to maintain consistency
> across tools.
>
> The attached patch contains the suggested change.
Few suggestions:
1) I felt the
On Wed, 19 Mar 2025 at 11:44, Shubham Khanna
wrote:
>
>
> I agree with you on this; switching to a single query with safe_psql()
> will indeed simplify the test and make the verification logic cleaner.
>
> The attached patch contains the suggested change.
Few comments:
1) I felt we are not doing
On Wed, 19 Mar 2025 at 13:27, Ilia Evdokimov
wrote:
>
> It would be nice if this works with VACUUM VERBOSE ANALYZE ONLY table;
Thanks for the comment, here is an updated v3 version with the change
for the same.
Regards,
Vignesh
v3-0001-psql-Tab-completion-for-VACUUM-and-ANALYZE-.-ONLY.patch
De
On Wed, 19 Mar 2025 at 10:39, Shubham Khanna
wrote:
>
> On Tue, Mar 18, 2025 at 5:17 PM Amit Kapila wrote:
> >
> > On Tue, Mar 18, 2025 at 4:01 PM Shubham Khanna
> > wrote:
> > >
> > > On Tue, Mar 18, 2025 at 12:07 PM David G. Johnston
> > > wrote:
> > > >
> > >
> > > > It would be good if we c
On Tue, 18 Mar 2025 at 17:34, Shubham Khanna
wrote:
>
> I have added an additional test case to 040_pg_createsubscriber.pl as
> suggested.
>
> The attached patch contains the suggested changes.
How about we change the below code:
+# Verify that user databases (postgres, $db1, $db2) got subscript
On Tue, 18 Mar 2025 at 20:43, Ilia Evdokimov
wrote:
>
>
> On 18.03.2025 17:57, Ilia Evdokimov wrote:
> > Hi,
> >
> > Thank you for the patch. However, Is it ok if I can't tab 'ONLY' in
> > VACUUM ANALYZE command?
How about we handle it like in the attached patch?
Apart from this, similar handling
On Thu, 27 Feb 2025 at 11:42, vignesh C wrote:
>
> On Thu, 6 Feb 2025 at 16:29, Umar Hayat wrote:
>
> This will include "ONLY" also when we display the tables too:
> + else if (HeadMatches("ANALYZE"))
> +
> COMPLETE_WITH_SCHEMA_QUERY_PLUS(Query_for
On Mon, 17 Mar 2025 at 16:51, Ashutosh Bapat
wrote:
>
> On Mon, Mar 17, 2025 at 4:02 PM vignesh C wrote:
> >
> > On Mon, 17 Mar 2025 at 11:28, Shubham Khanna
> > wrote:
> > >
> > > On Fri, Mar 14, 2025 at 5:43 PM Nisha Moond
> > > wrote
On Mon, 10 Mar 2025 at 16:26, Peter Eisentraut wrote:
>
> On 26.02.25 06:15, Paul Jungwirth wrote:
> > > ON DELETE RESTRICT must be specified when PERIOD BUSINESS_TIME is
> > also specified.
> >
> > Here are some patches removing support for RESTRICT
>
> I have committed this.
>
> I think this is
On Mon, 17 Mar 2025 at 23:03, Jeff Davis wrote:
>
> On Sun, 2025-03-16 at 19:10 +0530, vignesh C wrote:
> > We currently have two Commitfest entries for the same thread at [1]
> > and [2]. Are both still necessary, or can we consolidate tracking
> > into
> > a singl
On Mon, 17 Mar 2025 at 16:57, Ashutosh Bapat
wrote:
>
> On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila wrote:
> >
> > On Mon, Mar 17, 2025 at 3:44 PM vignesh C wrote:
> > >
> > > While reviewing another patch, I found a couple of typos:
>
On Mon, 17 Mar 2025 at 11:28, Shubham Khanna
wrote:
>
> On Fri, Mar 14, 2025 at 5:43 PM Nisha Moond wrote:
>
> Fixed.
>
> The attached patch contains the suggested changes.
I feel like we're trying to address two separate tasks in this thread:
a) Enhancing pg_createsubscriber to automatically re
On Thu, 13 Mar 2025 at 18:10, Heikki Linnakangas wrote:
>
> Hmm, this problem isn't limited to this one pg_upgrade test, right? It
> could happen with any pg_upgrade invocation. And perhaps in a running
> server too, if a relfilenumber is reused quickly.
Yes, it can happen with these scenarios.
Hi,
While reviewing another patch, I found a couple of typos:
1) subid should have been pubid in AlterPublicationOwner and
AlterPublicationOwner_oid functions.
2) Only tuples with XIDs/MXIDs older than the the
FreezeLimit/MultiXactCutoff are frozen in the common case.
Should have been"
Only tuples
On Mon, 17 Mar 2025 at 13:42, Dmitry Dolgov <9erthali...@gmail.com> wrote:
>
> > On Mon, Mar 17, 2025 at 12:07:44PM GMT, vignesh C wrote:
> >
> > I noticed that the feedback from Sami at [1] has not yet been
> > addressed, I have changed the status to Waiting on Au
On Mon, 3 Feb 2025 at 21:08, Dmitry Koval wrote:
>
> Hi, Alexander!
> Thanks for your advices and recommendations!
>
> >I don't think we need a separate 0003 patch with refactoring. It's
> >probably good idea to keep this functionality as a separate patch, but
> >let's make then it a 0001, whi
On Fri, 7 Mar 2025 at 17:22, Andreas Karlsson wrote:
>
> Hi,
>
> Here is a rebased version of it to make the CI happy. I plan to work
> more on this next week but am happy with any feedback on what is already
> there.
I noticed that Kirill's comments from [1] are not yet addressed, I
have changed
On Thu, 27 Feb 2025 at 23:30, Alena Rybakina wrote:
>
> Hi!
> On 17.02.2025 17:46, Alena Rybakina wrote:
> > On 04.02.2025 18:22, Alena Rybakina wrote:
> >> Hi! Thank you for your review!
> >>
> >> On 02.02.2025 23:43, Alexander Korotkov wrote:
> >>> On Mon, Jan 13, 2025 at 3:26 PM Alena Rybakina
On Mon, 27 Jan 2025 at 07:51, jian he wrote:
>
> hi.
>
> I forgot to attach the patch.
> here we are.
I noticed that David's comments from [1] have not yet been addressed,
I have changed the status of commitfest entry to "Waiting on Author",
please address them and change the status to "Needs rev
On Fri, 20 Dec 2024 at 10:50, Andreas Karlsson wrote:
>
> Hi,
>
> Jeff pointed out to me that the case conversion functions in ICU have
> UTF-8 specific versions which means we can call those directly if the
> database encoding is UTF-8 and skip having to convert to and from UChar.
>
> Since most
On Mon, 3 Mar 2025 at 17:26, Álvaro Herrera wrote:
>
> On 2025-Feb-18, Sami Imseih wrote:
>
> > > It's not a question about whether it's possible to implement this,
> > > but about whether it makes sense. In case of plain constants it's
> > > straightforward -- they will not change anything meanin
On Fri, 28 Feb 2025 at 19:37, wrote:
>
> Hi,
>
> Fix an error in the patch.
Currently we have the following commitfest entries for this thread:
[1] - https://commitfest.postgresql.org/patch/5611/
[2] - https://commitfest.postgresql.org/patch/5513/
I have closed the second entry at [2].
Regards,
On Fri, 14 Mar 2025 at 14:11, Peter Eisentraut wrote:
>
> On 05.03.25 17:40, Peter Eisentraut wrote:
> > On 03.03.25 11:17, Peter Eisentraut wrote:
> >> Update for the hackers list: This patch set was briefly committed but
> >> had to be reverted because it crashed on some older Python versions;
>
On Tue, 11 Mar 2025 at 09:41, vignesh C wrote:
>
Here's a quick commitfest status report as of today:
status | start | 10th | 17th
+-+-+-
Needs review: | 198 | 182 | 134
Waiting o
On Sat, 8 Mar 2025 at 02:41, Jeff Davis wrote:
>
> On Wed, 2025-03-05 at 20:43 -0600, Nathan Bossart wrote:
> > I see. Do we provide any suggested next steps for users to assess
> > the
> > potentially-affected relations?
>
> I don't know exactly where we should document it, but I've attached a
>
On Wed, 12 Mar 2025 at 20:14, Yura Sokolov wrote:
>
> Otherwise v6 is just rebased v5.
I noticed that Tomas's comments from [1] are not yet addressed, I have
changed the commitfest status to Waiting on Author, please address
them and update it to Needs review.
[1] -
https://www.postgresql.org/me
On Wed, 12 Feb 2025 at 00:11, Matheus Alcantara
wrote:
>
> Hi,
>
> Em ter., 11 de fev. de 2025 às 03:39, jian he
> escreveu:
> > hi. some minor issue i found.
> >
> > +#include "storage/block.h"
> > no need, since "#include "storage/bufmgr.h" already included it.
> >
> Fixed
>
> > do we need to a
On Sat, 29 Jun 2024 at 02:27, David G. Johnston
wrote:
>
> A documentation comment came in [1] causing me to review some of our backup
> documentation and I left the current content and location of the standalone
> backups was odd. I propose to move it to a better place, under file system
> ba
On Fri, 14 Mar 2025 at 03:38, Daniel Gustafsson wrote:
>
>
>
> > On 13 Mar 2025, at 19:31, Tom Lane wrote:
> >
> > Jacob Champion writes:
> >> Adding the PG prefix to the envvar name addresses my collision
> >> concern, but I think Tom's comment upthread [1] was saying that we
> >> should not pr
On Thu, 12 Sept 2024 at 04:30, Jacob Champion
wrote:
>
> On Wed, Sep 11, 2024 at 12:08 PM Lars Kanis wrote:
> > How did you verify the issue on the server side - with YugabyteDB or
> > with a modified Postgres server? I'd like to verify the GSSAPI part and
> > I'm familiar with the Postgres serve
On Fri, 7 Feb 2025 at 05:45, Anton A. Melnikov
wrote:
>
> Here is a small patch that does it and eliminates multiple warnings.
> Would be glad if you take a look on it.
I noticed that Kirill's comments from [1] are not yet addressed, I
have changed the status of commitfest entry to Waiting on Aut
On Sun, 9 Mar 2025 at 03:27, Nathan Bossart wrote:
>
> On Sun, Mar 09, 2025 at 03:01:41AM +0530, Ayush Vatsa wrote:
> > Maybe we can move ahead with the patch if we can see no other concerns.
>
> I think we should allow some time in case others want to review the patch.
> I do see a concern upthre
On Sat, 8 Mar 2025 at 08:06, Matthias van de Meent
wrote:
>
> Here's a patchset that uses that approach. Naming of functions, types,
> fields and arguments TBD. The patch works and passes the new
> VACUUM-conflict tests, though I suspect the SP-GIST tests to have
> bugs, as an intermediate version
On Wed, 5 Mar 2025 at 16:43, Matthias van de Meent
wrote:
>
> On Sun, 2 Mar 2025 at 01:35, Tom Lane wrote:
> >
> > Peter Geoghegan writes:
> > > Is everybody in agreement about committing and back patching this fix,
> > > which simply disables the optimization altogether?
> > > I myself don't se
On Thu, 14 Nov 2024 at 14:26, Daniil Davydov <3daniss...@gmail.com> wrote:
>
> On Wed, Oct 30, 2024 at 7:32 PM Rafia Sabih wrote:
>
> > Good catch. I agree with this being an unwarranted behaviour.
> > A minor comment from my end is the wording of the error message.
> > Based on the Postgresql err
On Wed, 27 Nov 2024 at 21:29, Nathan Bossart wrote:
>
> On Wed, Nov 27, 2024 at 03:20:19PM +0900, Michael Paquier wrote:
> > On Mon, Nov 25, 2024 at 01:29:31PM -0600, Nathan Bossart wrote:
> >> Or we could just enforce that you have an active snapshot whenever you
> >> modify a catalog with a TOAS
On Tue, 29 Oct 2024 at 13:38, Арсений Косицын wrote:
>
>
> Hi everyone!
>
> A situation has been discovered in which empty .log files are being created.
>
> --Reproduce:
>
> 1) You need to set the following parameters in the "postgresql.conf" file:
>
> log_destination = 'csvlog'
> logging_collecto
On Wed, 5 Mar 2025 at 11:46, Amit Kapila wrote:
>
> On Tue, Mar 4, 2025 at 4:44 PM Jakub Wartak
>
> I can go with the last patch as you observed that in a real-world
> case, and we can look at others (if any) on a case-to-case basis.
> Fujii-San, others, do you have any opinion on this?
+1 for th
On Fri, 14 Mar 2025 at 06:25, Euler Taveira wrote:
>
> On Thu, Mar 13, 2025, at 11:10 AM, vignesh C wrote:
>
> Few comments:
>
>
> Thanks for taking a look.
>
> 1) After selecting max_active_replication_origins setting in the
> SELECT query having order by, the fir
On Tue, 4 Feb 2025 at 12:07, Zharkov Roman wrote:
>
> Hello,
>
> Here is a new patch version.
> I tried to use perl 'version' instead of 'api_versionstring' to sync
> with configure script.
One suggestion, there are many other external libraries for which we
don't display the version, can we incl
On Thu, 27 Feb 2025 at 18:51, Andres Freund wrote:
>
> Hi,
>
> On 2025-02-27 13:53:17 +0100, Andreas Karlsson wrote:
> > We use EXTRA_REGRESS_OPTS to make sure the whole test suite passes with our
> > extension loaded and since I prefer develop in meson over using autotools
> > and make the lack o
On Tue, 4 Feb 2025 at 12:07, Zharkov Roman wrote:
>
> Hello,
>
> Here is a new patch version.
> I tried to use perl 'version' instead of 'api_versionstring' to sync
> with configure script.
Thanks for the patch, this looks good to me.
Regards,
Vignesh
On Thu, 13 Mar 2025 at 05:59, Euler Taveira wrote:
>
> On Wed, Mar 12, 2025, at 8:47 AM, vignesh C wrote:
>
> I reviewed the discussion on this thread and believe we now have an
> agreement on the design and GUC names. However, the patch still needs
> updates and extensive t
Hi,
In one of the recent buildfarm runs, the test
pg_upgrade/004_subscription test fails at [1].
It has failed with the following:
Restoring database schemas in the new cluster
*failure*
Consult the last few lines of
"C:/prog/bf/root/HEAD/pgsql.build/testrun/pg_upgrade/004_subscription/data/t_004
On Thu, 13 Mar 2025 at 10:53, Peter Smith wrote:
>
>
> If time permits I'll try to help you get some of the ("needs review")
> threads moving by checking the simple ones first.
Thanks, Peter! Would anyone else like to volunteer for this
CommitFest? Since it's the last one, more help would be grea
On Wed, 12 Mar 2025 at 16:15, Dilip Kumar wrote:
>
> Thanks, Vignesh, for adding the test. I believe you've tested the
> effect of DROP PUBLICATION. However, I think we should also test the
> behavior of ALTER SUBSCRIPTION...SET PUBLICATION before creating the
> PUBLICATION, and then create the PU
On Thu, 13 Mar 2025 at 09:18, Dilip Kumar wrote:
>
> Thanks looks good to me.
>
> While looking at the patch, I have a few comments/questions
>
> + if (pub)
> + result = lappend(result, pub);
> + else
> + {
> + /*
> + * When executing 'ALTER SUBSCRIPTION ... SET PUBLICATION', the
> + * apply worke
On Thu, 13 Mar 2025 at 05:59, Euler Taveira wrote:
>
> On Wed, Mar 12, 2025, at 8:47 AM, vignesh C wrote:
>
> I reviewed the discussion on this thread and believe we now have an
> agreement on the design and GUC names. However, the patch still needs
> updates and extensive t
On Wed, 12 Mar 2025 at 09:14, vignesh C wrote:
>
> The patch was not applying on top of HEAD because of recent commits,
> here is a rebased version.
I have moved this to the next CommitFest since it will not be
committed in the current release. This also allows reviewers to foc
On Fri, 7 Mar 2025 at 21:21, Euler Taveira wrote:
>
> On Fri, Mar 7, 2025, at 11:47 AM, Peter Eisentraut wrote:
>
> Is that maximum active for the whole system, or maximum active per
> session, or maximum active per created origin, or some combination of these?
>
>
> It is a cluster-wide setting.
On Thu, 20 Feb 2025 at 12:50, Zhijie Hou (Fujitsu)
wrote:
>
>
> Here is the v28 patch set, which converts the subscription option
> max_conflict_retention_duration into a GUC. Other logic remains unchanged.
After discussing with Hou internally, I have moved this to the next
CommitFest since it wi
On Fri, 28 Feb 2025 at 19:37, wrote:
>
> Hi,
>
> Fix an error in the patch.
I felt you might have missed attaching the test patches added at [1].
Also the test from [1] is failing with the latest v6 version patch.
This change is not required:
extern void XLogRecGetBlockRefInfo(XLogReaderState *
On Sat, 1 Mar 2025 at 19:01, Amit Kapila wrote:
>
> On Mon, Feb 3, 2025 at 4:23 AM Peter Smith wrote:
> >
> > A recent commit [1] added a new section "29.6. Generated Column
> > Replication" to the documentation [2]. But, no "Examples" were
> > included.
> >
> > I've created this new thread to ma
On Fri, 21 Feb 2025 at 14:25, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Ashutosh,
>
> Thanks for the reply.
>
> > > ISTM the inconsistency is introduced since the initial commit. I think
> > > they should
> > be unified either
> > > 1) update the doc or 2) accept when -d is not specified. Personall
1 - 100 of 1363 matches
Mail list logo
