Re: Add tests for object size limits of injection points

2025-11-11 Thread Chao Li
> On Nov 10, 2025, at 18:27, Xuneng Zhou wrote: > > Hi Michael, Chao, > > On Mon, Nov 10, 2025 at 11:32 AM Michael Paquier wrote: >> >> On Mon, Nov 10, 2025 at 10:30:31AM +0800, Chao Li wrote: >>> Is really confused. The error message says “maximum of 64”, but the >>> test right uses a name

Re: Add tests for object size limits of injection points

2025-11-11 Thread Xuneng Zhou
Hi, On Wed, Nov 12, 2025 at 9:37 AM Michael Paquier wrote: > > On Mon, Nov 10, 2025 at 06:27:41PM +0800, Xuneng Zhou wrote: > > Thanks for the patch. I also agree with Chao's suggestion that the > > error message better reflects the actual character limits. I > > implemented a patch for that and

Re: Add tests for object size limits of injection points

2025-11-11 Thread Michael Paquier
On Mon, Nov 10, 2025 at 06:27:41PM +0800, Xuneng Zhou wrote: > Thanks for the patch. I also agree with Chao's suggestion that the > error message better reflects the actual character limits. I > implemented a patch for that and updated the test patch as well. > Please check. The restriction relate

Re: Add tests for object size limits of injection points

2025-11-10 Thread Michael Paquier
On Mon, Nov 10, 2025 at 06:27:41PM +0800, Xuneng Zhou wrote: > Thanks for the patch. I also agree with Chao's suggestion that the > error message better reflects the actual character limits. I > implemented a patch for that and updated the test patch as well. > Please check. Yes, that works here.

Re: Add tests for object size limits of injection points

2025-11-10 Thread Daniel Gustafsson
> On 10 Nov 2025, at 02:11, Michael Paquier wrote: > While looking at a recent patch for injection points that has resulted > in 16a2f706951e, I have been reminded that the point name, library > name and function name have hardcoded limits, and it is now possible > to have them tested by SQL. Wh

Re: Add tests for object size limits of injection points

2025-11-10 Thread Xuneng Zhou
Hi Michael, Chao, On Mon, Nov 10, 2025 at 11:32 AM Michael Paquier wrote: > > On Mon, Nov 10, 2025 at 10:30:31AM +0800, Chao Li wrote: > > Is really confused. The error message says “maximum of 64”, but the > > test right uses a name of length 64. I know that the tricky is the > > ‘\0’ terminator

Re: Add tests for object size limits of injection points

2025-11-09 Thread Michael Paquier
On Mon, Nov 10, 2025 at 10:30:31AM +0800, Chao Li wrote: > Is really confused. The error message says “maximum of 64”, but the > test right uses a name of length 64. I know that the tricky is the > ‘\0’ terminator, but should SQL writer have to keep mind about the > ‘\0’ terminator? Should they jus

Re: Add tests for object size limits of injection points

2025-11-09 Thread Chao Li
> On Nov 10, 2025, at 09:11, Michael Paquier wrote: > > Hi all, > > While looking at a recent patch for injection points that has resulted > in 16a2f706951e, I have been reminded that the point name, library > name and function name have hardcoded limits, and it is now possible > to have them

Add tests for object size limits of injection points

2025-11-09 Thread Michael Paquier
Hi all, While looking at a recent patch for injection points that has resulted in 16a2f706951e, I have been reminded that the point name, library name and function name have hardcoded limits, and it is now possible to have them tested by SQL. Attached is a patch to do so. Thoughts? -- Michael Fr