> Pushed.
>
> --
> With Regards,
> Amit Kapila.
>
>
Hi!
While working on 64–bit XID's patch set, I stumble into problems with
contrib/test_decoding/catalog_change_snapshot test [0].
AFAICS, the problem is not related to the 64–bit XID's patch set and the
problem is in InitialRunningXacts array,
On Sat, Aug 27, 2022 at 7:06 PM Masahiko Sawada wrote:
>
> On Sat, Aug 27, 2022 at 7:24 PM Amit Kapila wrote:
> >
> > On Sat, Aug 27, 2022 at 1:06 PM Masahiko Sawada
> > wrote:
> > >
> > > > >
> > > > > I think then we should change this code in the master branch patch
> > > > > with an
On Sat, Aug 27, 2022 at 7:24 PM Amit Kapila wrote:
>
> On Sat, Aug 27, 2022 at 1:06 PM Masahiko Sawada wrote:
> >
> > On Sat, Aug 27, 2022 at 3:56 PM Amit Kapila wrote:
> > >
> > > On Fri, Jul 29, 2022 at 12:15 PM Amit Kapila
> > > wrote:
> > > >
> > > > >
> > > > > Yeah, your description
On Sat, Aug 27, 2022 at 1:06 PM Masahiko Sawada wrote:
>
> On Sat, Aug 27, 2022 at 3:56 PM Amit Kapila wrote:
> >
> > On Fri, Jul 29, 2022 at 12:15 PM Amit Kapila
> > wrote:
> > >
> > > >
> > > > Yeah, your description makes sense to me. I've also considered how to
> > > > hit this path but I
On Sat, Aug 27, 2022 at 3:56 PM Amit Kapila wrote:
>
> On Fri, Jul 29, 2022 at 12:15 PM Amit Kapila wrote:
> >
> > >
> > > Yeah, your description makes sense to me. I've also considered how to
> > > hit this path but I guess it is never hit. Thinking of it in another
> > > way, first of all, at
On Fri, Jul 29, 2022 at 12:15 PM Amit Kapila wrote:
>
> >
> > Yeah, your description makes sense to me. I've also considered how to
> > hit this path but I guess it is never hit. Thinking of it in another
> > way, first of all, at least 2 catalog modifying transactions have to
> > be running
On Thu, Aug 11, 2022 at 3:10 PM Amit Kapila wrote:
>
> On Mon, Aug 8, 2022 at 9:34 AM Amit Kapila wrote:
> >
> > On Wed, Aug 3, 2022 at 1:20 PM Masahiko Sawada
> > wrote:
> > >
> > >
> > > Oops, thanks for pointing it out. I've fixed it and attached updated
> > > patches for all branches so as
On Mon, Aug 8, 2022 at 9:34 AM Amit Kapila wrote:
>
> On Wed, Aug 3, 2022 at 1:20 PM Masahiko Sawada wrote:
> >
> >
> > Oops, thanks for pointing it out. I've fixed it and attached updated
> > patches for all branches so as not to confuse the patch version. There
> > is no update from v12 patch
On Wed, Aug 3, 2022 at 1:20 PM Masahiko Sawada wrote:
>
> On Wed, Aug 3, 2022 at 3:52 PM shiy.f...@fujitsu.com
> wrote:
> >
> > On Wed, Aug 3, 2022 12:06 PM Masahiko Sawada wrote:
> > >
> > > I've attached updated patches that incorporated the above comments as
> > > well as the comments from
On Wed, Aug 3, 2022 12:06 PM Masahiko Sawada wrote:
>
> I've attached updated patches that incorporated the above comments as
> well as the comments from Shi yu. Please review them.
>
Thanks for updating the patch.
I noticed that in SnapBuildXidSetCatalogChanges(), "i" is initialized in the
At Wed, 3 Aug 2022 08:51:40 +0530, Amit Kapila wrote
in
> On Wed, Aug 3, 2022 at 7:05 AM Masahiko Sawada wrote:
> > Looking at other codes in snapbuild.c, we call CloseTransientFile()
> > before erroring out in SnapBuildSerialize(). I think it's better to
> > keep it consistent with nearby
On Tue, Aug 2, 2022 at 5:31 PM shiy.f...@fujitsu.com
wrote:
>
> On Mon, Aug 1, 2022 10:31 PM Amit Kapila wrote:
> >
> > On Mon, Aug 1, 2022 at 7:46 AM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 29, 2022 at 3:45 PM Amit Kapila
> > wrote:
> > > >
> > >
> > > I've attached updated patches
On Wed, Aug 3, 2022 at 7:05 AM Masahiko Sawada wrote:
>
> On Wed, Aug 3, 2022 at 10:20 AM Kyotaro Horiguchi
> wrote:
> >
> > At Tue, 2 Aug 2022 13:54:43 +0530, Amit Kapila
> > wrote in
> > > On Tue, Aug 2, 2022 at 12:00 PM Kyotaro Horiguchi
> > > wrote:
> > > >
> > > > + {
> > > > +
On Wed, Aug 3, 2022 at 10:20 AM Kyotaro Horiguchi
wrote:
>
> At Tue, 2 Aug 2022 13:54:43 +0530, Amit Kapila
> wrote in
> > On Tue, Aug 2, 2022 at 12:00 PM Kyotaro Horiguchi
> > wrote:
> > >
> > > + {
> > > + int save_errno = errno;
> > > +
> > > +
At Tue, 2 Aug 2022 13:54:43 +0530, Amit Kapila wrote
in
> On Tue, Aug 2, 2022 at 12:00 PM Kyotaro Horiguchi
> wrote:
> >
> > + {
> > + int save_errno = errno;
> > +
> > + CloseTransientFile(fd);
> > +
> > + if (readBytes < 0)
On Mon, Aug 1, 2022 10:31 PM Amit Kapila wrote:
>
> On Mon, Aug 1, 2022 at 7:46 AM Masahiko Sawada
> wrote:
> >
> > On Fri, Jul 29, 2022 at 3:45 PM Amit Kapila
> wrote:
> > >
> >
> > I've attached updated patches for all branches. Please review them.
> >
>
> Thanks, the patches look mostly
On Tue, Aug 2, 2022 at 12:00 PM Kyotaro Horiguchi
wrote:
>
> At Mon, 1 Aug 2022 20:01:00 +0530, Amit Kapila
> wrote in
> > On Mon, Aug 1, 2022 at 7:46 AM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 29, 2022 at 3:45 PM Amit Kapila
> > > wrote:
> > > >
> > >
> > > I've attached updated
At Mon, 1 Aug 2022 20:01:00 +0530, Amit Kapila wrote
in
> On Mon, Aug 1, 2022 at 7:46 AM Masahiko Sawada wrote:
> >
> > On Fri, Jul 29, 2022 at 3:45 PM Amit Kapila wrote:
> > >
> >
> > I've attached updated patches for all branches. Please review them.
> >
>
> Thanks, the patches look mostly
On Fri, Jul 29, 2022 at 5:36 AM Masahiko Sawada wrote:
>
> On Thu, Jul 28, 2022 at 8:57 PM Amit Kapila wrote:
> >
> > On Thu, Jul 28, 2022 at 3:23 PM Amit Kapila wrote:
> >
> > I have another comment on this patch:
> > SnapBuildPurgeOlderTxn()
> > {
> > ...
> > + if (surviving_xids > 0)
> > +
On Thu, Jul 28, 2022 at 8:57 PM Amit Kapila wrote:
>
> On Thu, Jul 28, 2022 at 3:23 PM Amit Kapila wrote:
> >
> > On Tue, Jul 26, 2022 at 1:22 PM Masahiko Sawada
> > wrote:
> > >
> > > Okay, I've attached an updated patch that does the above idea. Could
> > > you please do the performance
On Thu, Jul 28, 2022 at 3:23 PM Amit Kapila wrote:
>
> On Tue, Jul 26, 2022 at 1:22 PM Masahiko Sawada wrote:
> >
> > Okay, I've attached an updated patch that does the above idea. Could
> > you please do the performance tests again to see if the idea can help
> > reduce the overhead, Shi yu?
>
On Tue, Jul 26, 2022 at 1:22 PM Masahiko Sawada wrote:
>
> Okay, I've attached an updated patch that does the above idea. Could
> you please do the performance tests again to see if the idea can help
> reduce the overhead, Shi yu?
>
While reviewing the patch for HEAD, I have changed a few
On Thu, Jul 28, 2022 at 12:56 PM Masahiko Sawada wrote:
>
> On Thu, Jul 28, 2022 at 4:13 PM Amit Kapila wrote:
> >
> > >
> > > While editing back branch patches, I realized that the following
> > > (parsed->xinfo & XACT_XINFO_HAS_INVALS) and (parsed->nmsgs > 0) are
> > > equivalent:
> > >
> > >
On Thu, Jul 28, 2022 at 4:13 PM Amit Kapila wrote:
>
> On Thu, Jul 28, 2022 at 11:56 AM Masahiko Sawada
> wrote:
> >
> > On Thu, Jul 28, 2022 at 12:21 PM Amit Kapila
> > wrote:
> > >
> > > On Thu, Jul 28, 2022 at 7:18 AM Masahiko Sawada
> > > wrote:
> > > >
> >
> > While editing back branch
On Thu, Jul 28, 2022 at 11:56 AM Masahiko Sawada wrote:
>
> On Thu, Jul 28, 2022 at 12:21 PM Amit Kapila wrote:
> >
> > On Thu, Jul 28, 2022 at 7:18 AM Masahiko Sawada
> > wrote:
> > >
>
> While editing back branch patches, I realized that the following
> (parsed->xinfo &
() an
On Thu, Jul 28, 2022 at 12:21 PM Amit Kapila wrote:
>
> On Thu, Jul 28, 2022 at 7:18 AM Masahiko Sawada wrote:
> >
> > On Wed, Jul 27, 2022 at 8:33 PM Amit Kapila wrote:
> > >
> >
> > > I have changed accordingly in the attached
> > > and apart from that slightly modified the comments
On Thu, Jul 28, 2022 at 7:18 AM Masahiko Sawada wrote:
>
> On Wed, Jul 27, 2022 at 8:33 PM Amit Kapila wrote:
> >
>
> > I have changed accordingly in the attached
> > and apart from that slightly modified the comments and commit message.
> > Do let me know what you think of the attached?
>
> It
On Wed, Jul 27, 2022 at 8:33 PM Amit Kapila wrote:
>
> On Mon, Jul 25, 2022 at 11:26 AM Masahiko Sawada
> wrote:
> >
> > On Mon, Jul 25, 2022 at 10:45 AM Masahiko Sawada
> > wrote:
> >
> > I've attached the patch for REl15 that I forgot.
> >
>
> I feel the place to remember running xacts
On Mon, Jul 25, 2022 at 11:26 AM Masahiko Sawada wrote:
>
> On Mon, Jul 25, 2022 at 10:45 AM Masahiko Sawada
> wrote:
>
> I've attached the patch for REl15 that I forgot.
>
I feel the place to remember running xacts information in
SnapBuildProcessRunningXacts is not appropriate. Because in
On Tue, Jul 26, 2022 3:52 PM Masahiko Sawada wrote:
>
> On Tue, Jul 26, 2022 at 2:18 PM Amit Kapila
> wrote:
> >
> > On Tue, Jul 26, 2022 at 7:00 AM Masahiko Sawada
> wrote:
> > >
> > > On Mon, Jul 25, 2022 at 7:57 PM shiy.f...@fujitsu.com
> > > wrote:
> > > >
> > > >
> > > > case 3
> > > >
On Tue, Jul 26, 2022 at 2:18 PM Amit Kapila wrote:
>
> On Tue, Jul 26, 2022 at 7:00 AM Masahiko Sawada wrote:
> >
> > On Mon, Jul 25, 2022 at 7:57 PM shiy.f...@fujitsu.com
> > wrote:
> > >
> > > Hi,
> > >
> > > I did some performance test for the master branch patch (based on v6
> > > patch)
On Tue, Jul 26, 2022 at 7:00 AM Masahiko Sawada wrote:
>
> On Mon, Jul 25, 2022 at 7:57 PM shiy.f...@fujitsu.com
> wrote:
> >
> > Hi,
> >
> > I did some performance test for the master branch patch (based on v6 patch)
> > to
> > see if the bsearch() added by this patch will cause any overhead.
On Mon, Jul 25, 2022 at 7:57 PM shiy.f...@fujitsu.com
wrote:
>
> Hi,
>
> I did some performance test for the master branch patch (based on v6 patch) to
> see if the bsearch() added by this patch will cause any overhead.
Thank you for doing performance tests!
>
> I tested them three times and
Hi,
I did some performance test for the master branch patch (based on v6 patch) to
see if the bsearch() added by this patch will cause any overhead.
I tested them three times and took the average.
The results are as follows, and attach the bar chart.
case 1
-
No catalog modifying
On Mon, Jul 25, 2022 at 10:45 AM Masahiko Sawada wrote:
>
> On Sat, Jul 23, 2022 at 8:32 PM Amit Kapila wrote:
> >
> > On Fri, Jul 22, 2022 at 11:48 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Jul 20, 2022 at 5:50 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Wed, Jul 20, 2022 at 1:28
On Fri, Jul 22, 2022 at 11:48 AM Masahiko Sawada wrote:
>
> On Wed, Jul 20, 2022 at 5:50 PM Amit Kapila wrote:
> >
> > On Wed, Jul 20, 2022 at 1:28 PM Masahiko Sawada
> > wrote:
> > >
> >
> > This is required if we don't want to introduce a new set of functions
> > as you proposed above. I am
On Wed, Jul 20, 2022 at 5:50 PM Amit Kapila wrote:
>
> On Wed, Jul 20, 2022 at 1:28 PM Masahiko Sawada wrote:
> >
> > On Wed, Jul 20, 2022 at 2:19 PM Amit Kapila wrote:
> > >
> > > On Wed, Jul 20, 2022 at 9:01 AM Masahiko Sawada
> > > wrote:
> > >
> > > > Another idea would be to have
On Wed, Jul 20, 2022 at 1:28 PM Masahiko Sawada wrote:
>
> On Wed, Jul 20, 2022 at 2:19 PM Amit Kapila wrote:
> >
> > On Wed, Jul 20, 2022 at 9:01 AM Masahiko Sawada
> > wrote:
> >
> > > Another idea would be to have functions, say
> > > SnapBuildCommitTxnWithXInfo() and
On Wed, Jul 20, 2022 at 2:19 PM Amit Kapila wrote:
>
> On Wed, Jul 20, 2022 at 9:01 AM Masahiko Sawada wrote:
> >
> > On Wed, Jul 20, 2022 at 12:11 PM Amit Kapila
> > wrote:
> > >
> > > On Tue, Jul 19, 2022 at 7:28 PM Masahiko Sawada
> > > wrote:
> > >
> > > Why do you think we can't remove
On Wed, Jul 20, 2022 at 4:16 PM Kyotaro Horiguchi
wrote:
>
> At Wed, 20 Jul 2022 10:58:16 +0900, Masahiko Sawada
> wrote in
> > On Wed, Jul 20, 2022 at 9:58 AM Kyotaro Horiguchi
> > wrote:
> > > Mmm. the patch changed that behavior. AllocateSnapshotBuilder always
> > > allocate the array with
At Wed, 20 Jul 2022 10:58:16 +0900, Masahiko Sawada
wrote in
> On Wed, Jul 20, 2022 at 9:58 AM Kyotaro Horiguchi
> wrote:
> > Mmm. the patch changed that behavior. AllocateSnapshotBuilder always
> > allocate the array with a fixed size. SnapBuildAddCommittedTxn still
> > assumes
On Wed, Jul 20, 2022 at 9:01 AM Masahiko Sawada wrote:
>
> On Wed, Jul 20, 2022 at 12:11 PM Amit Kapila wrote:
> >
> > On Tue, Jul 19, 2022 at 7:28 PM Masahiko Sawada
> > wrote:
> >
> > Why do you think we can't remove
> > ReorderBufferInitialXactsSetCatalogChanges() from the back branch
> >
On Wed, Jul 20, 2022 at 12:11 PM Amit Kapila wrote:
>
> On Tue, Jul 19, 2022 at 7:28 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 19, 2022 at 9:25 PM Amit Kapila wrote:
> > >
> > > On Tue, Jul 19, 2022 at 1:10 PM Masahiko Sawada
> > > wrote:
> > > >
> > >
> > > > BTW on backbranches, I think
On Tue, Jul 19, 2022 at 7:28 PM Masahiko Sawada wrote:
>
> On Tue, Jul 19, 2022 at 9:25 PM Amit Kapila wrote:
> >
> > On Tue, Jul 19, 2022 at 1:10 PM Masahiko Sawada
> > wrote:
> > >
> >
> > > BTW on backbranches, I think that the reason why we add
> > > initial_running_xacts stuff to
On Wed, Jul 20, 2022 at 9:58 AM Kyotaro Horiguchi
wrote:
>
> At Tue, 19 Jul 2022 17:31:07 +0900, Masahiko Sawada
> wrote in
> > On Tue, Jul 19, 2022 at 4:35 PM Kyotaro Horiguchi
> > wrote:
> > > At Tue, 19 Jul 2022 10:17:15 +0530, Amit Kapila
> > > wrote in
> > > > Good work. I wonder
At Tue, 19 Jul 2022 17:31:07 +0900, Masahiko Sawada
wrote in
> On Tue, Jul 19, 2022 at 4:35 PM Kyotaro Horiguchi
> wrote:
> > At Tue, 19 Jul 2022 10:17:15 +0530, Amit Kapila
> > wrote in
> > > Good work. I wonder without comments this may create a problem in the
> > > future. OTOH, I don't
On Tue, Jul 19, 2022 at 9:25 PM Amit Kapila wrote:
>
> On Tue, Jul 19, 2022 at 1:10 PM Masahiko Sawada wrote:
> >
> > On Mon, Jul 18, 2022 at 8:49 PM Amit Kapila wrote:
> > >
> > > On Sun, Jul 17, 2022 at 6:29 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Fri, Jul 15, 2022 at 3:32 PM
On Tue, Jul 19, 2022 at 2:01 PM Masahiko Sawada wrote:
>
> On Tue, Jul 19, 2022 at 4:35 PM Kyotaro Horiguchi
> wrote:
>
> >
> >
> > + Assert((xcnt > 0) && (xcnt == rb->catchange_ntxns));
> >
> > (xcnt > 0) is obvious here (otherwise means dlist_foreach is broken..).
> > (xcnt ==
On Tue, Jul 19, 2022 at 1:10 PM Masahiko Sawada wrote:
>
> On Mon, Jul 18, 2022 at 8:49 PM Amit Kapila wrote:
> >
> > On Sun, Jul 17, 2022 at 6:29 PM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 15, 2022 at 3:32 PM shiy.f...@fujitsu.com
> > > wrote:
> > > >
> > >
> > > I've attached
On Tue, Jul 19, 2022 at 1:43 PM Kyotaro Horiguchi
wrote:
>
> At Tue, 19 Jul 2022 16:57:14 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > At Tue, 19 Jul 2022 16:02:26 +0900, Masahiko Sawada
> > wrote in
> > > On Tue, Jul 19, 2022 at 1:47 PM Amit Kapila
> > > wrote:
> > > > Good work. I wonder
On Tue, Jul 19, 2022 at 4:35 PM Kyotaro Horiguchi
wrote:
Thank you for the comments!
>
> At Tue, 19 Jul 2022 10:17:15 +0530, Amit Kapila
> wrote in
> > Good work. I wonder without comments this may create a problem in the
> > future. OTOH, I don't see adding a check "catchange.xcnt > 0"
At Tue, 19 Jul 2022 16:57:14 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Tue, 19 Jul 2022 16:02:26 +0900, Masahiko Sawada
> wrote in
> > On Tue, Jul 19, 2022 at 1:47 PM Amit Kapila wrote:
> > > Good work. I wonder without comments this may create a problem in the
> > > future. OTOH, I
At Tue, 19 Jul 2022 16:02:26 +0900, Masahiko Sawada
wrote in
> On Tue, Jul 19, 2022 at 1:47 PM Amit Kapila wrote:
> > Good work. I wonder without comments this may create a problem in the
> > future. OTOH, I don't see adding a check "catchange.xcnt > 0" before
> > freeing the memory any less
On Tue, Jul 19, 2022 at 4:28 PM osumi.takami...@fujitsu.com
wrote:
>
> On Sunday, July 17, 2022 9:59 PM Masahiko Sawada
> wrote:
> > I've attached patches for all supported branches including the master.
> Hi,
>
>
> Minor comments for REL14.
>
> (1) There are some foreign characters in the
On Mon, Jul 18, 2022 at 8:49 PM Amit Kapila wrote:
>
> On Sun, Jul 17, 2022 at 6:29 PM Masahiko Sawada wrote:
> >
> > On Fri, Jul 15, 2022 at 3:32 PM shiy.f...@fujitsu.com
> > wrote:
> > >
> >
> > I've attached patches for all supported branches including the master.
> >
>
> For back branch
At Tue, 19 Jul 2022 10:17:15 +0530, Amit Kapila wrote
in
> Good work. I wonder without comments this may create a problem in the
> future. OTOH, I don't see adding a check "catchange.xcnt > 0" before
> freeing the memory any less robust. Also, for consistency, we can use
> a similar check based
On Sunday, July 17, 2022 9:59 PM Masahiko Sawada wrote:
> I've attached patches for all supported branches including the master.
Hi,
Minor comments for REL14.
(1) There are some foreign characters in the patches (in the commit message)
When I had a look at your patch for back branches with
On Tue, Jul 19, 2022 at 1:47 PM Amit Kapila wrote:
>
> On Tue, Jul 19, 2022 at 6:34 AM Masahiko Sawada wrote:
> >
> > On Mon, Jul 18, 2022 at 1:12 PM Amit Kapila wrote:
> > >
> > > On Fri, Jul 15, 2022 at 8:09 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > This patch should have the fix for
On Tue, Jul 19, 2022 at 6:34 AM Masahiko Sawada wrote:
>
> On Mon, Jul 18, 2022 at 1:12 PM Amit Kapila wrote:
> >
> > On Fri, Jul 15, 2022 at 8:09 PM Masahiko Sawada
> > wrote:
> > >
> > > This patch should have the fix for the issue that Shi yu reported. Shi
> > > yu, could you please test it
On Mon, Jul 18, 2022 at 12:28 PM shiy.f...@fujitsu.com
wrote:
>
> On Fri, Jul 15, 2022 10:39 PM Masahiko Sawada wrote:
> >
> > This patch should have the fix for the issue that Shi yu reported. Shi
> > yu, could you please test it again with this patch?
> >
>
> Thanks for updating the patch!
> I
On Mon, Jul 18, 2022 at 1:12 PM Amit Kapila wrote:
>
> On Fri, Jul 15, 2022 at 8:09 PM Masahiko Sawada wrote:
> >
> > This patch should have the fix for the issue that Shi yu reported. Shi
> > yu, could you please test it again with this patch?
> >
>
> Can you explain the cause of the failure
On Sun, Jul 17, 2022 at 6:29 PM Masahiko Sawada wrote:
>
> On Fri, Jul 15, 2022 at 3:32 PM shiy.f...@fujitsu.com
> wrote:
> >
>
> I've attached patches for all supported branches including the master.
>
For back branch patches,
* Wouldn't it be better to move purge logic into the function
On Fri, Jul 15, 2022 at 8:09 PM Masahiko Sawada wrote:
>
> This patch should have the fix for the issue that Shi yu reported. Shi
> yu, could you please test it again with this patch?
>
Can you explain the cause of the failure and your fix for the same?
--
With Regards,
Amit Kapila.
On Fri, Jul 15, 2022 10:39 PM Masahiko Sawada wrote:
>
> This patch should have the fix for the issue that Shi yu reported. Shi
> yu, could you please test it again with this patch?
>
Thanks for updating the patch!
I have tested and confirmed that the problem I found has been fixed.
Regards,
On Fri, Jul 15, 2022 at 3:32 PM shiy.f...@fujitsu.com
wrote:
>
> On Mon, Jul 11, 2022 9:54 PM Masahiko Sawada wrote:
> >
> > I've attached an updated patch, please review it.
> >
>
> Thanks for your patch. Here are some comments for the REL14-v1 patch.
>
> 1.
> + Sizesz
On Fri, Jul 15, 2022 at 10:43 PM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, July 14, 2022 10:31 AM Masahiko Sawada
> wrote:
> > I've attached an updated patch that incorporated comments from Amit and Shi.
> Hi,
>
>
> Minor comments for v4.
Thank you for the comments!
>
> (1) typo in
On Thursday, July 14, 2022 10:31 AM Masahiko Sawada
wrote:
> I've attached an updated patch that incorporated comments from Amit and Shi.
Hi,
Minor comments for v4.
(1) typo in the commit message
"When decoding a COMMIT record, we check both the list and the ReorderBuffer to
see if
if the
On Mon, Jul 11, 2022 9:54 PM Masahiko Sawada wrote:
>
> I've attached an updated patch, please review it.
>
Thanks for your patch. Here are some comments for the REL14-v1 patch.
1.
+ Sizesz = sizeof(TransactionId) * nxacts;;
There is a redundant semicolon at the
On Thu, Jul 14, 2022 at 12:06 PM Masahiko Sawada wrote:
>
> On Thu, Jul 14, 2022 at 11:16 AM shiy.f...@fujitsu.com
> wrote:
> >
> > On Tue, Jul 12, 2022 5:23 PM Masahiko Sawada wrote:
> > >
> > > On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
> > > wrote:
> > > >
> > > > It happened
On Thu, Jul 14, 2022 at 11:16 AM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Jul 12, 2022 5:23 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
> > wrote:
> > >
> > > It happened when executing the following code because it tried to free a
> > NULL
> > >
On Tue, Jul 12, 2022 5:23 PM Masahiko Sawada wrote:
>
> On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
> wrote:
> >
> > It happened when executing the following code because it tried to free a
> NULL
> > pointer (catchange_xip).
> >
> > /* be tidy */
> > if (ondisk)
> >
On Tue, Jul 12, 2022 at 12:40 PM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Jul 12, 2022 8:49 AM Masahiko Sawada wrote:
> >
> > I've attached an updated patch.
> >
> > While trying this idea, I noticed there is no API to get the length of
> > dlist, as we discussed offlist. Alternative idea was to
On Tue, Jul 12, 2022 at 5:52 PM Amit Kapila wrote:
>
> On Tue, Jul 12, 2022 at 1:13 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 12, 2022 at 3:25 PM Amit Kapila wrote:
> > >
> > > On Tue, Jul 12, 2022 at 11:38 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Tue, Jul 12, 2022 at 10:28 AM
On Tue, Jul 12, 2022 at 7:59 PM Amit Kapila wrote:
>
> On Tue, Jul 12, 2022 at 2:53 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
> > wrote:
> > >
> > >
> > > It happened when executing the following code because it tried to free a
> > > NULL
> > >
On Tue, Jul 12, 2022 at 2:53 PM Masahiko Sawada wrote:
>
> On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
> wrote:
> >
> >
> > It happened when executing the following code because it tried to free a
> > NULL
> > pointer (catchange_xip).
> >
> > /* be tidy */
> > if
On Tue, Jul 12, 2022 at 5:58 PM shiy.f...@fujitsu.com
wrote:
>
> On Tue, Jul 12, 2022 8:49 AM Masahiko Sawada wrote:
> >
> > I've attached an updated patch.
> >
>
> Hi,
>
> I met a segmentation fault in test_decoding test after applying the patch for
> master
> branch. Attach the backtrace.
On Tue, Jul 12, 2022 8:49 AM Masahiko Sawada wrote:
>
> I've attached an updated patch.
>
Hi,
I met a segmentation fault in test_decoding test after applying the patch for
master
branch. Attach the backtrace.
It happened when executing the following code because it tried to free a NULL
On Tue, Jul 12, 2022 at 1:13 PM Masahiko Sawada wrote:
>
> On Tue, Jul 12, 2022 at 3:25 PM Amit Kapila wrote:
> >
> > On Tue, Jul 12, 2022 at 11:38 AM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Jul 12, 2022 at 10:28 AM Masahiko Sawada
> > > wrote:
> > > >
> > > >
> > > > I'm doing
On Tue, Jul 12, 2022 at 3:25 PM Amit Kapila wrote:
>
> On Tue, Jul 12, 2022 at 11:38 AM Masahiko Sawada
> wrote:
> >
> > On Tue, Jul 12, 2022 at 10:28 AM Masahiko Sawada
> > wrote:
> > >
> > >
> > > I'm doing benchmark tests and will share the results.
> > >
> >
> > I've done benchmark tests
On Tue, Jul 12, 2022 at 11:38 AM Masahiko Sawada wrote:
>
> On Tue, Jul 12, 2022 at 10:28 AM Masahiko Sawada
> wrote:
> >
> >
> > I'm doing benchmark tests and will share the results.
> >
>
> I've done benchmark tests to measure the overhead introduced by doing
> bsearch() every time when
On Tue, Jul 12, 2022 at 10:28 AM Masahiko Sawada wrote:
>
> On Tue, Jul 12, 2022 at 9:48 AM Masahiko Sawada wrote:
> >
> > On Fri, Jul 8, 2022 at 8:20 PM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 8, 2022 at 5:59 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Fri, Jul 8, 2022 at
On Tue, Jul 12, 2022 8:49 AM Masahiko Sawada wrote:
>
> I've attached an updated patch.
>
> While trying this idea, I noticed there is no API to get the length of
> dlist, as we discussed offlist. Alternative idea was to use List
> (T_XidList) but I'm not sure it's a great idea since deleting
On Tue, Jul 12, 2022 at 9:48 AM Masahiko Sawada wrote:
>
> On Fri, Jul 8, 2022 at 8:20 PM Masahiko Sawada wrote:
> >
> > On Fri, Jul 8, 2022 at 5:59 PM Amit Kapila wrote:
> > >
> > > On Fri, Jul 8, 2022 at 12:46 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Fri, Jul 8, 2022 at 3:27 PM
On Fri, Jul 8, 2022 at 8:20 PM Masahiko Sawada wrote:
>
> On Fri, Jul 8, 2022 at 5:59 PM Amit Kapila wrote:
> >
> > On Fri, Jul 8, 2022 at 12:46 PM Masahiko Sawada
> > wrote:
> > >
> > > On Fri, Jul 8, 2022 at 3:27 PM Amit Kapila
> > > wrote:
> > > >
> > >
> > > > 1.
> > > > In
On Wed, Jul 6, 2022 at 3:01 PM Amit Kapila wrote:
>
> On Wed, Jul 6, 2022 at 7:38 AM Masahiko Sawada wrote:
> >
> > I'll post a new version patch in the next email with replying to other
> > comments.
> >
>
> Okay, thanks for working on this. Few comments/suggestions on
>
On Fri, Jul 8, 2022 at 5:59 PM Amit Kapila wrote:
>
> On Fri, Jul 8, 2022 at 12:46 PM Masahiko Sawada wrote:
> >
> > On Fri, Jul 8, 2022 at 3:27 PM Amit Kapila wrote:
> > >
> >
> > > 1.
> > > In ReorderBufferGetCatalogChangesXacts(), isn't it better to use the
> > > list length of
On Fri, Jul 8, 2022 at 12:46 PM Masahiko Sawada wrote:
>
> On Fri, Jul 8, 2022 at 3:27 PM Amit Kapila wrote:
> >
>
> > 1.
> > In ReorderBufferGetCatalogChangesXacts(), isn't it better to use the
> > list length of 'catchange_txns' to allocate xids array? If we can do
> > so, then we will save
On Fri, Jul 8, 2022 at 3:27 PM Amit Kapila wrote:
>
> On Fri, Jul 8, 2022 at 6:45 AM Masahiko Sawada wrote:
> >
> > On Thu, Jul 7, 2022 at 3:40 PM Amit Kapila wrote:
> > >
> > > On Thu, Jul 7, 2022 at 8:21 AM Masahiko Sawada
> > > wrote:
> >
> > I've attached the new version patch that
On Fri, Jul 8, 2022 at 6:45 AM Masahiko Sawada wrote:
>
> On Thu, Jul 7, 2022 at 3:40 PM Amit Kapila wrote:
> >
> > On Thu, Jul 7, 2022 at 8:21 AM Masahiko Sawada
> > wrote:
>
> I've attached the new version patch that incorporates the comments and
> the optimizations discussed above.
>
On Thu, Jul 7, 2022 at 3:40 PM Amit Kapila wrote:
>
> On Thu, Jul 7, 2022 at 8:21 AM Masahiko Sawada wrote:
> >
> > On Wed, Jul 6, 2022 at 5:55 PM Amit Kapila wrote:
> > >
> > > On Wed, Jul 6, 2022 at 12:19 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Tue, Jul 5, 2022 at 8:00 PM Amit
On Thu, Jul 7, 2022 at 8:21 AM Masahiko Sawada wrote:
>
> On Wed, Jul 6, 2022 at 5:55 PM Amit Kapila wrote:
> >
> > On Wed, Jul 6, 2022 at 12:19 PM Masahiko Sawada
> > wrote:
> > >
> > > On Tue, Jul 5, 2022 at 8:00 PM Amit Kapila
> > > wrote:
> > > >
> > > > 2. Are we anytime removing
On Wed, Jul 6, 2022 at 5:55 PM Amit Kapila wrote:
>
> On Wed, Jul 6, 2022 at 12:19 PM Masahiko Sawada wrote:
> >
> > On Tue, Jul 5, 2022 at 8:00 PM Amit Kapila wrote:
> > >
> > > 2. Are we anytime removing transaction ids from catchanges->xip array?
> >
> > No.
> >
> > > If not, is there a
On Wed, Jul 6, 2022 at 12:19 PM Masahiko Sawada wrote:
>
> On Tue, Jul 5, 2022 at 8:00 PM Amit Kapila wrote:
> >
> > 2. Are we anytime removing transaction ids from catchanges->xip array?
>
> No.
>
> > If not, is there a reason for the same? I think we can remove it
> > either at commit/abort or
On Tue, Jul 5, 2022 at 8:00 PM Amit Kapila wrote:
>
> On Mon, Jul 4, 2022 at 6:12 PM Amit Kapila wrote:
> >
> > On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> > wrote:
> > >
> > > I've attached three POC patches:
> > >
> >
> > I think it will be a good idea if you can add a short commit
On Wed, Jul 6, 2022 at 7:38 AM Masahiko Sawada wrote:
>
> I'll post a new version patch in the next email with replying to other
> comments.
>
Okay, thanks for working on this. Few comments/suggestions on
poc_remember_last_running_xacts_v2 patch:
1.
On Mon, Jul 4, 2022 at 9:42 PM Amit Kapila wrote:
>
> On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> wrote:
> >
> > I've attached three POC patches:
> >
>
> I think it will be a good idea if you can add a short commit message
> at least to say which patch is proposed for HEAD and which one
On Mon, Jul 4, 2022 at 6:12 PM Amit Kapila wrote:
>
> On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> wrote:
> >
> > I've attached three POC patches:
> >
>
> I think it will be a good idea if you can add a short commit message
> at least to say which patch is proposed for HEAD and which one
On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada wrote:
>
> I've attached three POC patches:
>
I think it will be a good idea if you can add a short commit message
at least to say which patch is proposed for HEAD and which one is for
back branches. Also, it would be good if you can add some
On Tue, Jun 14, 2022 at 3:57 PM Amit Kapila wrote:
>
> On Mon, Jun 13, 2022 at 8:29 AM Masahiko Sawada wrote:
> >
> > On Tue, Jun 7, 2022 at 9:32 PM Amit Kapila wrote:
> > >
> > > On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Wed, May 25, 2022 at 12:11 PM
On Mon, Jun 13, 2022 at 8:29 AM Masahiko Sawada wrote:
>
> On Tue, Jun 7, 2022 at 9:32 PM Amit Kapila wrote:
> >
> > On Mon, May 30, 2022 at 11:13 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, May 25, 2022 at 12:11 PM Masahiko Sawada
> > > wrote:
> > > >
> > >
> > >
1 - 100 of 126 matches
Mail list logo
