Re: [HACKERS] SERIALIZABLE with parallel query

On Tue, Sep 26, 2017 at 4:41 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Mon, Sep 25, 2017 at 6:57 PM, Thomas Munro < > thomas.mu...@enterprisedb.com> wrote: > >> On Mon, Sep 25, 2017 at 8:37 PM, Haribabu Kommi >> <kommi.harib...@gmail.c

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Nov 8, 2017 at 8:46 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Nov 7, 2017 at 4:31 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > >> Updated patch attached. > > Patch rebased. > > I think the earlier concerns about the perform

Re: [HACKERS] SERIALIZABLE with parallel query

On Fri, Dec 8, 2017 at 11:33 AM, Thomas Munro wrote: > On Thu, Nov 30, 2017 at 2:44 PM, Thomas Munro > wrote: > > On Thu, Nov 30, 2017 at 2:32 PM, Michael Paquier > > wrote: > >> Could this question be

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Wed, Nov 29, 2017 at 4:25 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Nov 8, 2017 at 8:50 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > Ok. Removed the documentation changes that it cannot be used for normal > > scenarios,

Re: [HACKERS] pg_stat_wal_write statistics view

On Mon, Nov 27, 2017 at 2:12 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > On Wed, Nov 8, 2017 at 8:46 AM, Robert Haas <robertmh...@gmail.com> wrote: > >> On Tue, Nov 7, 2017 at 4:31 AM, Haribabu Kommi <kommi.harib...@gmail.com> >> wrote: &

Enhance pg_stat_wal_receiver view to display connected host

Hi Hackers, With the multi host connection string feature, it is possible to specify multiple hosts in primary_conninfo that is used in streaming replication to make sure that WAL streaming is not affected. Currently there is no information that is available in the standby node to find out to

Re: Postgres 11 release notes

On Wed, May 23, 2018 at 11:34 AM, Bruce Momjian <br...@momjian.us> wrote: > On Mon, May 21, 2018 at 06:28:36PM +1000, Haribabu Kommi wrote: > > On Sat, May 12, 2018 at 1:08 AM, Bruce Momjian <br...@momjian.us> wrote: > > > > I have committed the first draft

Re: Postgres 11 release notes

-11.html > Thanks for preparing the release notes. >Have pg_dump dump all aspects of a database (Haribabu Kommi) > >pg_dump and pg_restore, without --clean, no longer dump/restore database > comments and security labels. There is small change in option name, the option to print database

Re: Libpq support to connect to standby server as priority

eds to take as two different options. prefer-read is simple to support than read-only. Here I attached an updated patch that is rebased to the latest master and also fixed some of the corner scenarios. Regards, Haribabu Kommi Fujitsu Australia 0001-Allow-target-session-attrs-to-accept-prefer-read-opti.patch Description: Binary data

Re: Does logical replication supports cross platform servers?

On Tue, Jun 12, 2018 at 1:29 PM Craig Ringer wrote: > On 12 June 2018 at 11:04, Haribabu Kommi wrote: > >> Hi All, >> >> I am not able to find any docs suggesting that PostgreSQL logical >> replication supports >> cross platform servers (windows --> Lin

Re: Column store in Greenplum

LOuQFkIps/1TNHW0lGAwAJ > > Unique indexes are not supported on column oriented tables. > Identifying a concurrent transaction that might be inserting duplicate > tuples becomes hard because (1) lack of MVCC information in tuples and > (2) one block directory tuple covers multiple row numbers. > Thanks for sharing your design details, I will go through them clearly to understand with the current proposed pluggable table access method interfaces can handle all the other storage methods that are implemented outside PostgreSQL. [1] - https://www.postgresql.org/message-id/CAJrrPGfRGtRz_-Qyt_hK9KCQYdN%3DpbpjPooAHM9dZhJmqwN8fg%40mail.gmail.com [2] - https://www.postgresql.org/message-id/cajrrpgfac7wc9nk6ptty6yn-nn+hcy8xolah2doyhvg5d6h...@mail.gmail.com Regards, Haribabu Kommi Fujitsu Australia

pg_stat_statements_reset() function execute permissions doc update

://www.postgresql.org/message-id/flat/3368121530260059%40web21g.yandex.ru#655724e8e402df4f8b29fc91d44cf260 Regards, Haribabu Kommi Fujitsu Australia 0001-pg_stat_statements_reset-function-execution-permissi.patch Description: Binary data

Re: Does logical replication supports cross platform servers?

On Sun, Jun 24, 2018 at 6:36 AM Bruce Momjian wrote: > On Wed, Jun 13, 2018 at 11:42:14AM +1000, Haribabu Kommi wrote: > > > > Thanks for the confirmation. > > This is a good use case that must be explicitly mentioned in the docs. > > How about the attached patch? >

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Sat, Jun 23, 2018 at 5:45 AM Euler Taveira wrote: > 2018-06-22 12:06 GMT-03:00 Robert Haas : > > On Wed, Jun 20, 2018 at 10:19 AM, Euler Taveira > wrote: > >> 2018-06-20 4:30 GMT-03:00 Haribabu Kommi : > >>> Attached is a simple patch with implementation. C

Re: I'd like to discuss scaleout at PGCon

er pool and lock manager, how about adding many instances and all share the buffers using RDMA to provide better scaling with shared everything. Currently I didn't know have any idea whether is it possible or not and also the problems in using RDMA. Just want to check whether is it worth idea to consider in supporting scale out? Regards, Haribabu Kommi Fujitsu Australia

New function pg_stat_statements_reset_query() to reset statistics of a specific query

it will be useful if we a function that resets the stats of a single query, instead of reseting all the queries. Attached is a simple patch with implementation. Comments? Regards, Haribabu Kommi Fujitsu Australia 0001-Function-to-reset-statistics-of-a-specific-statement.patch Description: Binary data

jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

The jitflags in the PlannedStmt structure of type "int", but in _out and _read functions it is treated as of "bool" type. WRITE_BOOL_FIELD(jitFlags); READ_BOOL_FIELD(jitFlags); I am thinking of it is a copy paste mistake as the other members around the initflags are of "bool" type or is there

Re: Enhance pg_stat_wal_receiver view to display connected host

On Fri, Jan 5, 2018 at 12:05 AM, Michael Paquier wrote: > On Thu, Jan 04, 2018 at 08:54:37AM -0300, Alvaro Herrera wrote: > > I think more attention should be given to the libpq side of this patch; > > maybe have a 0001 with only the new libpq function, to easily

Re: [HACKERS] Pluggable storage

On Fri, Jan 5, 2018 at 9:55 AM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Thu, Jan 4, 2018 at 8:03 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > >> On Thu, Jan 4, 2018 at 10:00 AM, Alexander Korotkov < >> a.korot...@postgrespro.r

Re: Enhance pg_stat_wal_receiver view to display connected host

On Thu, Dec 21, 2017 at 11:12 PM, Michael Paquier <michael.paqu...@gmail.com > wrote: > On Thu, Dec 21, 2017 at 8:16 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > The current connected host details are already available in the PGconn > > structu

Re: [HACKERS] Planning counters in pg_stat_statements

On Tue, Nov 7, 2017 at 4:10 PM, Thomas Munro wrote: > Hi hackers, > > I have often wanted $SUBJECT and was happy to find that Fujii-san had > posted a patch five years ago[1]. The reception then seemed positive. > So here is a refurbished and (hopefully) improved

Re: Enhance pg_stat_wal_receiver view to display connected host

[ Including Hackers as earlier mail mistakenly removed it ] On Tue, Jan 16, 2018 at 2:55 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Jan 15, 2018 at 05:51:58PM +1100, Haribabu Kommi wrote: > > Instead of effective_conninfo, I changed the column name as > &

Re: Enhance pg_stat_wal_receiver view to display connected host

On Tue, Jan 16, 2018 at 5:56 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > On Tue, Jan 16, 2018 at 2:55 PM, Michael Paquier < > michael.paqu...@gmail.com> wrote: > >> >> Note that I still find this API confusing, it seems to me that just &

Re: pgsql: Move handling of database properties from pg_dumpall into pg_dum

On Tue, Jan 23, 2018 at 8:56 AM, Tom Lane wrote: > I wrote: > > Specifically, I see failures like this on machines where the prevailing > > locale isn't C or US: > > > pg_restore: [archiver (db)] Error while PROCESSING TOC: > > pg_restore: [archiver (db)] Error from TOC entry

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Thu, Jan 18, 2018 at 8:25 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > [ pg_dump-and-pg_dumpall-database-handling-refactoring_v12.patch ] > > I started to look through this, and almost immediately found that the

Re: Enhance pg_stat_wal_receiver view to display connected host

On Tue, Jan 9, 2018 at 12:15 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Jan 05, 2018 at 09:15:36AM -0300, Alvaro Herrera wrote: > > Haribabu Kommi wrote: > > > > > And also not returning "default host" details, because for the

Re: [HACKERS] Planning counters in pg_stat_statements

On Thu, Jan 11, 2018 at 10:00 PM, Thomas Munro < thomas.mu...@enterprisedb.com> wrote: > On Thu, Jan 11, 2018 at 7:36 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > > +OUT plans int8, > > > > Addition of this column is good to find out

Re: Enhance pg_stat_wal_receiver view to display connected host

On Fri, Jan 12, 2018 at 3:26 PM, Michael Paquier wrote: > On Fri, Jan 12, 2018 at 11:37:22AM +0900, Michael Paquier wrote: > > I have redone my set of previous tests and can confirm that PQhost is > > behaving as I would expect it should, and those results are the same

Re: Enhance pg_stat_wal_receiver view to display connected host

On Fri, Jan 12, 2018 at 4:06 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Jan 12, 2018 at 03:55:04PM +1100, Haribabu Kommi wrote: > > Before posting the patch, first I did the same, upon further study > > I didn't find any scenario where the value is no

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Sun, Jan 14, 2018 at 9:44 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sun, Jan 14, 2018 at 02:19:26PM +1100, Haribabu Kommi wrote: > > While working on [1], we find out the inconsistency in PQHost() behavior > > if the connecting string that is passed to

Re: [HACKERS] Pluggable storage

On Tue, Jan 9, 2018 at 11:42 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > Updated patches are attached. > To integrate the columnar store with the pluggable storage API, I found that there are couple of other things also that needs to be supported. 1. Choosing the rig

Re: Enhance pg_stat_wal_receiver view to display connected host

On Mon, Jan 29, 2018 at 7:06 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Jan 16, 2018 at 05:56:22PM +1100, Haribabu Kommi wrote: > > Without PQhostaddr() function, for the connections where the host is not > > specified, it will be difficult to find

Re: Enhance pg_stat_wal_receiver view to display connected host

On Wed, Jan 3, 2018 at 12:25 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > update patch attached. > Last patch has undefined symbol, corrected patch attached. Regards, Hari Babu Fujitsu Australia pg_stat_wal_receiver-to-display-connected-host_v3.patch Description: Binary data

Re: [HACKERS] Pluggable storage

On Thu, Jan 4, 2018 at 10:00 AM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Wed, Jan 3, 2018 at 10:08 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > >> >> On Wed, Dec 27, 2017 at 11:33 PM, Alexander Korotkov < >> a.korot...

Re: [HACKERS] Pluggable storage

On Thu, Jun 14, 2018 at 12:25 PM Amit Kapila wrote: > On Thu, Jun 14, 2018 at 1:50 AM, Haribabu Kommi > wrote: > > > > On Fri, Apr 20, 2018 at 4:44 PM Haribabu Kommi > > > wrote: > > > > VACUUM: > > Not much changes are done in this apart movin

Re: Pluggable Storage - Andres's take

On Tue, Jul 24, 2018 at 11:31 PM Haribabu Kommi wrote: > On Tue, Jul 17, 2018 at 11:01 PM Haribabu Kommi > wrote: > >> >> I added new API in the tableam.h to get all the page visible tuples to > abstract the bitgetpage() function. > > >>- Merge tableam.h and

Re: Fallout from PQhost() semantics changes

_HOST_ADDRESS. In fact, I think there's probably a good case for doing something > comparable to libpq-internal-PQhost-usage-1.patch all the way back. > In exactly what scenario is it sane to be comparing "/tmp" or > "localhost" to a server's SSL certificate? > Yes, I agree that this problem present from a long, but may be till now everyone using along with host only? Regards, Haribabu Kommi Fujitsu Australia

Re: Pluggable Storage - Andres's take

h. I plan to push a tree including a lot of fixes and improvements > soon. > Sorry for coming late to this thread. That's good. Did you find any problems in porting zheap into pluggable storage? Does it needs any API changes or new API requirement? > On 2018-08-03 12:35:50 +1000, Hari

Re: Pluggable Storage - Andres's take

On Tue, Aug 21, 2018 at 6:59 PM Andres Freund wrote: > On 2018-08-21 16:55:47 +1000, Haribabu Kommi wrote: > > On Sun, Aug 5, 2018 at 7:48 PM Andres Freund wrote: > > > I'm currently in the process of rebasing zheap onto the pluggable > > > storage work. Th

Re: Pluggable Storage - Andres's take

On Fri, Aug 24, 2018 at 12:50 PM Andres Freund wrote: > Hi, > > On 2018-08-24 11:55:41 +1000, Haribabu Kommi wrote: > > On Tue, Aug 21, 2018 at 6:59 PM Andres Freund > wrote: > > > > > On 2018-08-21 16:55:47 +1000, Haribabu Kommi wrote: > > > >

Re: Pluggable Storage - Andres's take

On Mon, Jul 16, 2018 at 11:35 PM Andres Freund wrote: > On 2018-07-04 20:11:21 +1000, Haribabu Kommi wrote: > > On Tue, Jul 3, 2018 at 5:06 PM Andres Freund wrote: > > > > The most fundamental issues I had with Haribabu's last version from [2] > > > are the fo

Re: [bug fix] Produce a crash dump before main() on Windows

process, if no one present to observe the scenario? Doesn't this change can generate backward compatibility problems to particular users? I don't have any other comments with the current patch. Regards, Haribabu Kommi Fujitsu Australia

Re: Libpq support to connect to standby server as priority

On Tue, Jul 17, 2018 at 12:42 AM Laurenz Albe wrote: > Haribabu Kommi wrote: > > > On Wed, Jul 4, 2018 at 11:14 PM Laurenz Albe > wrote: > > > > Haribabu Kommi wrote: > > > > > > > > - I think the construction with "read_write_host_inde

Re: [bug fix] Produce a crash dump before main() on Windows

On Wed, Jul 18, 2018 at 4:10 PM Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > From: Haribabu Kommi [mailto:kommi.harib...@gmail.com] > > I reviewed patch and it works as per the subject, but I am not able to > verify > > the actual > > bug th

Re: Libpq support to connect to standby server as priority

On Wed, Jul 11, 2018 at 6:00 PM Haribabu Kommi wrote: > > > On Wed, Jul 4, 2018 at 11:14 PM Laurenz Albe > wrote: > >> Haribabu Kommi wrote: >> >> > - I think the construction with "read_write_host_index" makes the code >> even more >

Re: [bug fix] Produce a crash dump before main() on Windows

On Wed, Jul 18, 2018 at 6:39 PM Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > From: Haribabu Kommi [mailto:kommi.harib...@gmail.com] > > May be I can give a try by modifying the source code to get the crash. > > > Thank you, that would be great if you c

Re: Libpq support to connect to standby server as priority

K. I will work on the code refactoring first and then provide the prefer-read option on top it. Regards, Haribabu Kommi Fujitsu Australia

Re: Pluggable Storage - Andres's take

On Tue, Jul 17, 2018 at 11:01 PM Haribabu Kommi wrote: > > On Mon, Jul 16, 2018 at 11:35 PM Andres Freund wrote: > >> On 2018-07-04 20:11:21 +1000, Haribabu Kommi wrote: >> > On Tue, Jul 3, 2018 at 5:06 PM Andres Freund >> wrote: >> > >> > >

Re: Pluggable Storage - Andres's take

On Tue, Sep 4, 2018 at 10:33 AM Andres Freund wrote: > Hi, > > Thanks for the patches! > > On 2018-09-03 19:06:27 +1000, Haribabu Kommi wrote: > > I found couple of places where the zheap is using some extra logic in > > verifying > > whether it is zheap AM or n

Re: Pluggable Storage - Andres's take

On Wed, Sep 5, 2018 at 2:04 PM Haribabu Kommi wrote: > > On Tue, Sep 4, 2018 at 10:33 AM Andres Freund wrote: > >> Hi, >> >> Thanks for the patches! >> >> On 2018-09-03 19:06:27 +1000, Haribabu Kommi wrote: >> > I found couple of

Re: Pluggable Storage - Andres's take

ne functions. Having one-line tableam.c wrappers makes this > more expensive than necessary. We'll have a big enough trouble not > regressing performancewise. > OK. > - change scan level slot creation to use tableam function for doing so > - get rid of slot->tts_tid, tts_tupleOid and potentially tts_tableOid > so with this there shouldn't be a way from slot to tid mapping or there should be some other way. > - COPY's multi_insert path should probably deal with a bunch of slots, > rather than forming HeapTuples > OK. - bitmap index scans probably need a new tableam.h callback, abstracting > bitgetpage() > OK. Regards, Haribabu Kommi Fujitsu Australia

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

rid Oid, dbid Oid, queryid bigint) returns > void > And you forgot to change return type in docs (and description of return > value) > Corrected and also added details of the returns value. Update patch attached. Regards, Haribabu Kommi Fujitsu Australia From f3d4c1a319ceefafabd45039b4

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Tue, Jul 10, 2018 at 12:26 AM Fujii Masao wrote: > On Sun, Jul 8, 2018 at 11:48 AM, Haribabu Kommi > wrote: > > > > On Fri, Jul 6, 2018 at 3:22 AM Fujii Masao > wrote: > >> > >> On Wed, Jul 4, 2018 at 7:12 PM, Haribabu Kommi < > kommi.harib..

Re: Libpq support to connect to standby server as priority

On Wed, Jul 4, 2018 at 11:14 PM Laurenz Albe wrote: > Haribabu Kommi wrote: > > On Wed, Jan 24, 2018 at 9:01 AM Jing Wang wrote: > > > Hi All, > > > > > > Recently I put a proposal to support 'prefer-read' parameter in > target_session_attrs in libpq. Now

Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)

d to me that it's clearly a bug > on principle, hence this patch. > I checked the patch and I agree with the change 1). And regarding change 2) whether it is zeroing the contents of the page or not, it does read? because if it exists in the buffer pool, we are counting them as hits irrespective of the mode? Am I missing something? Regards, Haribabu Kommi Fujitsu Australia

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Fri, Jul 6, 2018 at 3:22 AM Fujii Masao wrote: > On Wed, Jul 4, 2018 at 7:12 PM, Haribabu Kommi > wrote: > > > > Update patch attached. > > + if (userid != 0 && dbid != 0 && queryid != 0) > > UINT64CONST() should be used for the constant for

Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)

On Thu, Jul 12, 2018 at 8:32 AM Thomas Munro wrote: > On Thu, Jul 12, 2018 at 12:46 AM, Haribabu Kommi > wrote: > >> > On 2018-04-30 14:59:31 +1200, Thomas Munro wrote: > >> >> In EXPLAIN (BUFFERS), there are two kinds of cache misses that show >

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Mon, Jul 9, 2018 at 3:39 PM Haribabu Kommi wrote: > > On Mon, Jul 9, 2018 at 12:24 PM Michael Paquier > wrote: > >> On Fri, Jul 06, 2018 at 05:10:18PM -0400, Alvaro Herrera wrote: >> > Ugh, it's true :-( >> > >> https://git.postgresql.o

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

ctions, attached patch removes all permissions from PUBLIC as before this change went in. Or do we need to add command for revoke only from pg_read_all_stats? Regards, Haribabu Kommi Fujitsu Australia 0001-Revoke-pg_stat_statements_reset-permissions.patch Description: Binary data

PQHost() undefined behavior if connecting string contains both host and hostaddr types

While working on [1], we find out the inconsistency in PQHost() behavior if the connecting string that is passed to connect to the server contains multiple hosts with both host and hostaddr types. For example, host=host1,host2 hostaddr=127.0.0.1,127.0.0.1 port=5434,5432 As the hostaddr is given

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

On Fri, Jan 19, 2018 at 10:35 AM, Tom Lane wrote: > I wrote: > > What I think we should do for the time being is to have pg_dump treat > > database tablespace as a property it can't adjust after creation, just > > as it can't adjust locale or encoding. That's a loss of

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Tue, Mar 27, 2018 at 3:03 PM, David G. Johnston < david.g.johns...@gmail.com> wrote: > On Mon, Mar 26, 2018 at 8:24 PM, Michael Paquier <mich...@paquier.xyz> > wrote: > >> On Tue, Mar 27, 2018 at 11:43:27AM +1100, Haribabu Kommi wrote: >> > Patch at

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Tue, Mar 27, 2018 at 12:23 AM, Michael Paquier <mich...@paquier.xyz> wrote: > On Mon, Mar 26, 2018 at 11:39:51PM +1100, Haribabu Kommi wrote: > > And if we are not going to change the above, then PQhost() function > > returns 3 values, > > - NULL when the c

Re: Enhance pg_stat_wal_receiver view to display connected host

On Wed, Mar 28, 2018 at 12:54 PM, Michael Paquier <mich...@paquier.xyz> wrote: > On Wed, Mar 28, 2018 at 11:28:32AM +1100, Haribabu Kommi wrote: > > I updated the pg_stat_wal_receiver patch with the new PQhost() function > > behavior and updated the view with two co

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Wed, Mar 28, 2018 at 3:35 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/27/18 02:20, Michael Paquier wrote: > > On Tue, Mar 27, 2018 at 04:47:41PM +1100, Haribabu Kommi wrote: > >> updated patch attached with additional doc updates as per

Re: Enhance pg_stat_wal_receiver view to display connected host

On Tue, Jan 30, 2018 at 4:02 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Jan 30, 2018 at 03:10:12PM +1100, Haribabu Kommi wrote: > > Ok, understood. As the libpq gives preference to hostaddr connection > > parameter than host while connecting. How about

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Mon, Mar 26, 2018 at 4:17 PM, Michael Paquier <mich...@paquier.xyz> wrote: > On Mon, Mar 26, 2018 at 11:28:41AM +0900, Kyotaro HORIGUCHI wrote: > > At Sun, 25 Mar 2018 22:27:09 +1100, Haribabu Kommi < > kommi.harib...@gmail.com> wrote in

Re: ALTER TABLE ADD COLUMN fast default

On Mon, Mar 26, 2018 at 9:32 AM, Andrew Dunstan wrote: > > > Thanks for this, all looks good. Here is the consolidate patch > rebased. If there are no further comments I propose to commit this in > a few days time. I have some comments with the committed patch.

Re: Enhance pg_stat_wal_receiver view to display connected host

On Fri, Mar 30, 2018 at 7:26 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Wed, Mar 28, 2018 at 3:09 PM, Michael Paquier <mich...@paquier.xyz> > wrote: > > On Wed, Mar 28, 2018 at 03:41:33PM +1100, Haribabu Kommi wrote: > >> On Wed, Mar 28, 2018 a

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Mon, Mar 26, 2018 at 6:34 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello. > > At Mon, 26 Mar 2018 17:49:22 +1100, Haribabu Kommi < > kommi.harib...@gmail.com> wrote in <CAJrrPGdYQ92R1hNArCByu+gN_ > sgsfmjgvberjh0n9w8ry24...@mail.gmail.

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Sun, Mar 25, 2018 at 12:56 AM, Michael Paquier <mich...@paquier.xyz> wrote: > On Sat, Mar 24, 2018 at 01:49:28AM +1100, Haribabu Kommi wrote: > > Here I attached the updated patch that returns either the connected > > host/hostaddr > > or NULL in case if the co

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Wed, Mar 21, 2018 at 6:06 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/16/18 00:03, Kyotaro HORIGUCHI wrote: > > I agree to the conclusion that PQhost() shouldn't return hostaddr > > "if it has any host name to return". But I still haven't found > > the reason for

Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

On Thu, Mar 22, 2018 at 12:28 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/21/18 03:40, Michael Paquier wrote: > >>> Moreover, I wonder whether we shouldn't remove the branch where > >>> conn->connhost is NULL. When would that be the case? The current > >>> behavior is

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Sat, Jun 23, 2018 at 2:52 PM Ashutosh Sharma wrote: > On Sat, Jun 23, 2018 at 7:36 AM, Haribabu Kommi > wrote: > > On Sat, Jun 23, 2018 at 5:45 AM Euler Taveira > wrote: > >> > >> 2018-06-22 12:06 GMT-03:00 Robert Haas : > >> > On Wed, Jun 20, 20

Re: Does logical replication supports cross platform servers?

On Thu, Jun 28, 2018 at 11:12 PM Bruce Momjian wrote: > On Wed, Jun 27, 2018 at 11:16:07PM +1000, Haribabu Kommi wrote: > > On Sun, Jun 24, 2018 at 6:36 AM Bruce Momjian wrote: > > > > On Wed, Jun 13, 2018 at 11:42:14AM +1000, Haribabu Kommi wrote: >

Re: Pluggable Storage - Andres's take

On Tue, Oct 9, 2018 at 1:46 PM Haribabu Kommi wrote: > On Wed, Oct 3, 2018 at 3:16 PM Andres Freund wrote: > >> On 2018-09-27 20:03:58 -0700, Andres Freund wrote: >> > On 2018-09-28 12:21:08 +1000, Haribabu Kommi wrote: >> > > Here I attached further clea

Re: Pluggable Storage - Andres's take

On Thu, Oct 18, 2018 at 1:04 PM Haribabu Kommi wrote: > On Tue, Oct 9, 2018 at 1:46 PM Haribabu Kommi > wrote: > >> >> I also observed the failure of aggregates.sql, will look into it. >> > > The random failure of aggregates.sql is as follows > > SEL

Re: Pluggable Storage - Andres's take

On Mon, Oct 22, 2018 at 6:16 PM Haribabu Kommi wrote: > On Thu, Oct 18, 2018 at 1:04 PM Haribabu Kommi > wrote: > >> On Tue, Oct 9, 2018 at 1:46 PM Haribabu Kommi >> wrote: >> >>> >>> I also observed the failure of aggregates.sql, wi

Re: Pluggable Storage - Andres's take

On Tue, Oct 23, 2018 at 5:49 PM Haribabu Kommi wrote: > I am able to generate the simple test and found the problem. The issue > with the following > SQL. > > SELECT * >INTO TABLE xacttest >FROM aggtest; > > During the processing of the above query, the

Re: Pluggable Storage - Andres's take

On Tue, Oct 9, 2018 at 1:46 PM Haribabu Kommi wrote: > On Wed, Oct 3, 2018 at 3:16 PM Andres Freund wrote: > >> On 2018-09-27 20:03:58 -0700, Andres Freund wrote: >> > On 2018-09-28 12:21:08 +1000, Haribabu Kommi wrote: >> > > Here I attached further clea

Re: Pluggable Storage - Andres's take

es that are added specific cost functions. > Estimation for heap lookup during index scans > should be also pluggable, but not yet implemented (TODO). > Yes, Is it possible to use the same API that is added by above patch? Regards, Haribabu Kommi Fujitsu Australia

Re: View to get all the extension control file details

On Sat, Oct 13, 2018 at 3:57 AM Robert Haas wrote: > On Wed, Oct 10, 2018 at 8:27 AM Haribabu Kommi > wrote: > > Here is the patch as per the above discussion. > > One potential problem with this is that we could add more control-file > attributes in the future, an

Re: Pluggable Storage - Andres's take

On Mon, Oct 29, 2018 at 7:40 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Fri, 26 Oct 2018 at 13:25, Haribabu Kommi > wrote: > > > > Here I attached the cumulative patch with all fixes that are shared in > earlier mails by me. > > Except fast

Re: Resource cleanup callbacks for foreign data wrappers

te connection as it is done in postgres_fdw module GetConnection() function. Instead of inventing new resource owner callback, transaction callback may solve your problem. Regards, Haribabu Kommi Fujitsu Australia

Re: PostgreSQL Limits and lack of documentation about them.

lso try to find such limits of PostgreSQL, but I couldn't find it. +1 to add them to docs. Regards, Haribabu Kommi Fujitsu Australia

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

are of resetting already existing statements from the already running server. With the above change, the regression test is stable. Comments? Regards, Haribabu Kommi Fujitsu Australia

Re: Pluggable Storage - Andres's take

On Wed, Oct 31, 2018 at 9:34 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Mon, 29 Oct 2018 at 05:56, Haribabu Kommi > wrote: > > > >> This problem couldn't be reproduced on the master branch, so I've tried > to > >> investigate it. It comes f

Re: Pluggable Storage - Andres's take

On Tue, Oct 23, 2018 at 6:11 PM Haribabu Kommi wrote: > > On Tue, Oct 23, 2018 at 5:49 PM Haribabu Kommi > wrote: > >> I am able to generate the simple test and found the problem. The issue >> with the following >> SQL. >> >> SELECT * >>INTO

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Thu, Nov 8, 2018 at 4:53 PM Amit Kapila wrote: > On Sun, Nov 4, 2018 at 6:37 AM Haribabu Kommi > wrote: > > > > On Sun, Nov 4, 2018 at 11:17 AM Michael Paquier > wrote: > >> > >> On Sat, Nov 03, 2018 at 03:56:14PM +0530, Amit Kapila wrote: > >&

Re: notice processors for isolationtester

d this patch adding notice processors, and then it does. > I reviewed and tested the patch. It is working as expected. Providing session name helps in debugging. Marking the patch as ready for committer. Regards, Haribabu Kommi Fujitsu Australia

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Mon, Nov 12, 2018 at 6:34 PM Amit Kapila wrote: > On Mon, Nov 12, 2018 at 10:55 AM Haribabu Kommi > wrote: > > > > I can revert it back to void, > > > > +1, as we don't see any good reason to break backward compatibility. > Thanks for the review. Attached t

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

it doesn't already exist, why that > should be a requirement for this patch? Do you have any strong > opinion about introducing return code with this patch? > I thought that returning the affected number of statements with the change of adding new parameters to the reset function will be helpful to find out how many statements are affected? I can revert it back to void, if I am the only one interested with that change. Regards, Haribabu Kommi Fujitsu Australia

Re: Libpq support to connect to standby server as priority

On Tue, Nov 13, 2018 at 7:26 AM Laurenz Albe wrote: > Tom Lane wrote: > > Laurenz Albe writes: > > > Haribabu Kommi wrote: > > > > Added comments along the lines that you mentioned. And also try > > > > to update some more comments. > > > L

Re: libpq debug log

> From time(b) to time(c): time for traffic > From time(c) to time(d): time for backend processing > From time(d) to time(e): time for traffic > From time(e) to time(f): time for libpq processing > Thanks for the patch. I have some comments related to the trace output that is getting printed. The amount of log it is generating may not be understood to many of the application developers. IMO, this should print only the necessary information that can understood by any one by default and full log with more configuration? Regards, Haribabu Kommi Fujitsu Australia

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Wed, Nov 14, 2018 at 12:26 AM Amit Kapila wrote: > On Tue, Nov 13, 2018 at 11:32 AM Haribabu Kommi > wrote: > > > > On Mon, Nov 12, 2018 at 6:34 PM Amit Kapila > wrote: > >> > I can revert it back to void, > >> > > >> > >> +1,

Re: Pluggable Storage - Andres's take

On Fri, Nov 2, 2018 at 11:17 AM Haribabu Kommi wrote: > On Wed, Oct 31, 2018 at 9:34 PM Dmitry Dolgov <9erthali...@gmail.com> > wrote: > >> FYI, alongside with reviewing the code changes I've ran few performance >> tests >> (that's why I hit this issue with pgb

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Thu, Nov 15, 2018 at 5:18 PM Amit Kapila wrote: > On Thu, Nov 15, 2018 at 11:38 AM Amit Kapila > wrote: > > > > On Thu, Nov 15, 2018 at 2:05 AM Haribabu Kommi > wrote: > > > > > > On Wed, Nov 14, 2018 at 8:45 PM Amit Kapila > wrote: > > >&

Re: [bug fix] Produce a crash dump before main() on Windows

1. Starting of Postgres server using pg_ctl without service is of production use or not? 2. Without this fix, how difficult is the problem to find out that something is preventing the server to start? In case if it is easy to find out, may be better to provide some troubleshoot guide for windows users can help. I am in favor of doc fix if it easy to find the problem instead of assuming the user usage. Regards, Haribabu Kommi Fujitsu Australia

Re: Libpq support to connect to standby server as priority

On Fri, Sep 28, 2018 at 5:31 PM Haribabu Kommi wrote: > > On Thu, Jul 19, 2018 at 10:59 PM Haribabu Kommi > wrote: > >> >> On Wed, Jul 18, 2018 at 10:53 PM Robert Haas >> wrote: >> >>> On Wed, Jul 4, 2018 at 9:14 AM, Laurenz Albe >>>

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On Wed, Nov 14, 2018 at 8:45 PM Amit Kapila wrote: > On Wed, Nov 14, 2018 at 7:04 AM Haribabu Kommi > wrote: > > > > On Wed, Nov 14, 2018 at 12:26 AM Amit Kapila > wrote: > >> > >> On Tue, Nov 13, 2018 at 11:32 AM Haribabu Kommi > >> wrote: &g

  1   2   3   >