384|CLUSTER|rebuilding index|16387|10|10|0|0|4
22283|13593|postgres|16384|CLUSTER|performing final
cleanup|16387|10|10|0|0|5
===
Thanks,
Tatsuro Yamada
committed your patch to
fix the problem. Thanks! I'll test it later. :)
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=da47e43dc32e3c5916396f0cbcfa974b371e4875
Thanks,
Tatsuro Yamada
withdraw my patch.
Anyway, I want to avoid this feature being reverted.
Do you have any ideas to fix the problem?
Thanks,
Tatsuro Yamada
ows + numrows, childtargrows,
, )
Thanks,
Tatsuro Yamada
Hi Michael, Alvaro and Robert!
On 2019/08/14 11:52, Michael Paquier wrote:
On Wed, Aug 14, 2019 at 11:38:01AM +0900, Tatsuro Yamada wrote:
On 2019/08/13 14:40, Tatsuro Yamada wrote:
On 2019/08/02 3:43, Alvaro Herrera wrote:
Hmm, I'm trying this out now and I don't see the index_rebuild_count
Hi Alvaro,
On 2019/08/13 23:01, Alvaro Herrera wrote:
Hello,
On 2019-Jul-03, Tatsuro Yamada wrote:
My ex-colleague Vinayak created same patch in 2017 [1], and he
couldn't get commit because there are some reasons such as the
patch couldn't handle analyzing Foreign table. Therefore, I wonder
Hi Alvaro and All,
On 2019/08/13 14:40, Tatsuro Yamada wrote:
Hi Alvaro!
On 2019/08/02 3:43, Alvaro Herrera wrote:
Hmm, I'm trying this out now and I don't see the index_rebuild_count
ever go up. I think it's because the indexes are built using parallel
index build ... or maybe
a period at the end when the CLUSTER command
keeps working, but it's gone from pg_stat_progress_cluster.
Thanks for your report.
I'll investigate it. :)
Thanks,
Tatsuro Yamada
Hi Robert and All!
On 2019/08/02 2:48, Robert Haas wrote:> On Thu, Aug 1, 2019 at 4:45 AM Thomas Munro
wrote:
On Tue, Jul 23, 2019 at 4:51 PM Tatsuro Yamada
wrote:
Attached v4 patch file only includes this fix.
I've moved this to the September CF, where it is in "Needs revie
Hi Horiguchi-san, Alvaro, Anthony, Julien and Robert,
On 2019/07/22 17:30, Kyotaro Horiguchi wrote:
Hello.
# It's very good timing, as you came in while I have a time after
# finishing a quite nerve-wrackig task..
At Mon, 22 Jul 2019 15:02:16 +0900, Tatsuro Yamada
wrote in <0876b4fe-2
Hi Horiguchi-san!
On 2019/07/11 19:56, Kyotaro Horiguchi wrote:
Hello.
At Tue, 9 Jul 2019 17:38:44 +0900, Tatsuro Yamada
wrote in <244cb241-168b-d6a9-c45f-a80c34cdc...@nttcom.co.jp>
Hi Alvaro, Anthony, Julien and Robert,
On 2019/07/09 3:47, Julien Rouhaud wrote:
On Mon, Jul 8, 201
5|13599|postgres|16384|f|16384|analyzing complete|0|0 <-- Added and fixed. :)
---------
Thanks,
Tatsuro Yamada
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index bf72d0c..c368444 100644
--- a/doc/src/sgml/monitoring.sgml
+
ave a question of the last line of the result.
I'm not sure it is able or not, but I guess it would be better
to keep the phase name (analyzing sample) on the view until the
end of this command. :)
Regards,
Tatsuro Yamada
handle Foreign table.
I'll review your patch in this week. :)
[1] ANALYZE command progress checker
https://www.postgresql.org/message-id/flat/968b4eda-2417-8b7b-d468-71643cf088b6%40openscg.com#574488592fcc9708c38fa44b0dae9006
Regards,
Tatsuro Yamada
Hi Robert and Reviewers!
On 2019/03/26 0:02, Robert Haas wrote:
On Sun, Mar 24, 2019 at 9:02 PM Tatsuro Yamada
wrote:
Please find attached files. :)
Committed. Thanks!
Thank you!
Hope this feature will help DBA and user. :)
Regards,
Tatsuro Yamada
NTT Open Source Software Center
or "writing new heap".
- Fix document
- Revised the patch on the current head:
940311e4bb32a5fe99155052e41179c88b5d48af.
Please find attached files. :)
Regards,
Tatsuro Yamada
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index ac2721c..26a6899 100644
---
On 2019/03/19 10:43, Tatsuro Yamada wrote:
Hi Rafia!
On 2019/03/18 20:42, Rafia Sabih wrote:
On Fri, 8 Mar 2019 at 09:14, Tatsuro Yamada
wrote:
Attached file is rebased patch on current HEAD.
I changed a status. :)
Looks like the patch needs a rebase.
I was on the commit
Hi Rafia!
On 2019/03/18 20:42, Rafia Sabih wrote:
On Fri, 8 Mar 2019 at 09:14, Tatsuro Yamada
wrote:
Attached file is rebased patch on current HEAD.
I changed a status. :)
Looks like the patch needs a rebase.
I was on the commit fb5806533f9fe0433290d84c9b019399cd69e9c2
PFA reject file
On 2019/03/06 15:38, Tatsuro Yamada wrote:
On 2019/03/05 17:56, Tatsuro Yamada wrote:
On 2019/03/05 11:35, Robert Haas wrote:
On Mon, Mar 4, 2019 at 5:38 AM Tatsuro Yamada
wrote:
=== Current design ===
CLUSTER command uses Index Scan or Seq Scan when scanning the heap.
Depending on which
On 2019/03/05 17:56, Tatsuro Yamada wrote:
Hi Robert!
On 2019/03/05 11:35, Robert Haas wrote:
On Mon, Mar 4, 2019 at 5:38 AM Tatsuro Yamada
wrote:
=== Current design ===
CLUSTER command uses Index Scan or Seq Scan when scanning the heap.
Depending on which one is chosen, the command
On 2019/03/06 1:13, Robert Haas wrote:
On Tue, Mar 5, 2019 at 3:56 AM Tatsuro Yamada
wrote:
=== Discussion points ===
- Progress counter for "3. sorting tuples" phase
- Should we add pgstat_progress_update_param() in tuplesort.c like a
"trace_sort&qu
Hi Robert!
On 2019/03/05 11:35, Robert Haas wrote:
On Mon, Mar 4, 2019 at 5:38 AM Tatsuro Yamada
wrote:
=== Current design ===
CLUSTER command uses Index Scan or Seq Scan when scanning the heap.
Depending on which one is chosen, the command will proceed in the
following sequence of phases
Hi David,
On 2019/03/05 17:29, David Steele wrote:
On 3/1/19 7:48 AM, Etsuro Fujita wrote:
(2019/03/01 14:17), Tatsuro Yamada wrote:
Attached patch is wip patch.
Is it possible to remove the following patch?
Because I registered the patch twice on CF Mar.
https://commitfest.postgresql.org
On 2019/03/02 4:15, Robert Haas wrote:
On Thu, Feb 28, 2019 at 11:54 PM Tatsuro Yamada
wrote:
Attached patch is wip patch.
I rewrote the current design of the progress monitor and also
wrote discussion points in the middle of this email. I'd like to
get any feedback from -hackers
On 2019/03/02 4:15, Robert Haas wrote:
On Thu, Feb 28, 2019 at 11:54 PM Tatsuro Yamada
wrote:
Attached patch is wip patch.
Thanks for your comments! :)
I revised the code and the document.
+ CLUSTER and VACUUM FULL,
showing current progress.
and -> or
Fixed.
+ cert
Attached patch is wip patch.
Is it possible to remove the following patch?
Because I registered the patch twice on CF Mar.
https://commitfest.postgresql.org/22/2049/
Thanks,
Tatsuro Yamada
On 2019/02/23 6:02, Robert Haas wrote:
On Fri, Dec 28, 2018 at 3:20 AM Tatsuro Yamada
wrote:
This patch is rebased on HEAD.
I'll tackle revising the patch based on feedbacks next month.
+ Running VACUUM FULL is listed in
pg_stat_progress_cluster
+ view because it uses CLUSTER command
t important comments but for readability. :)
Thanks,
Tatsuro Yamada
Hi Michael,
On 2019/01/28 15:31, Michael Paquier wrote:
On Mon, Jan 28, 2019 at 02:18:25PM +0900, Tatsuro Yamada wrote:
I modified the patch to handle the both:
- quoted index names
- complete partial numbers
Committed, which should close the loop for this thread. If you have
Hi Peter,
On 2019/01/25 20:09, Peter Eisentraut wrote:
On 26/12/2018 07:07, Tatsuro Yamada wrote:
+#define Query_for_list_of_attribute_numbers \
+"SELECT attnum "\
+" FROM pg_catalog.pg_attribute a, "\
+" pg_catalog.pg_class c "\
+" WHERE c.oid =
and index scan. However I'm going to register the patch on next CF.
I'm happy if you have interested in the patch.
This patch is rebased on HEAD.
I'll tackle revising the patch based on feedbacks next month.
Happy holidays!
Tatsuro Yamada
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src
< fix_manual_of_alter_index_v2.patch
patching file doc/src/sgml/ref/alter_index.sgml
=
Thanks,
Tatsuro Yamada
On 2018/12/25 14:27, Michael Paquier wrote:
On Tue, Dec 25, 2018 at 10:56:04AM +0900, Tatsuro Yamada wrote:
Hmm... Okey, I agree. Why I implemented the exotic part of the
feature is that it is for user-friendly. However, I suppose that
user know the syntax because the syntax is used
On 2018/12/21 16:13, Michael Paquier wrote:
On Fri, Dec 21, 2018 at 02:51:51PM +0900, Tatsuro Yamada wrote:
Attached file is a WIP patch.
Before sorting out the exotic part of the feature, why not first fixing
the simple cases where we know that tab completion is broken and can be
improved
On 2018/12/20 10:47, Tatsuro Yamada wrote:
On 2018/12/20 10:38, Michael Paquier wrote:
On Thu, Dec 20, 2018 at 10:05:30AM +0900, Tatsuro Yamada wrote:
Alright, I'll create new patches including these:
- No completion after "ALTER TABLE/INDEX SET STATISTICS" instead of sch
On 2018/12/20 10:38, Michael Paquier wrote:
On Thu, Dec 20, 2018 at 10:05:30AM +0900, Tatsuro Yamada wrote:
Alright, I'll create new patches including these:
- No completion after "ALTER TABLE/INDEX SET STATISTICS" instead of schema
names
- Complete "ALTER INDEX foo A
On 2018/12/19 18:22, Michael Paquier wrote:
On Wed, Dec 19, 2018 at 04:26:27PM +0900, Tatsuro Yamada wrote:
Yep, I already did that for ALTER INDEX in
tab_completion_alter_index_set_statistics.patch like this:
+ /* ALTER INDEX ALTER COLUMN SET STATISTICS */
+ else if (HeadMatches("
On 2018/12/19 14:27, Michael Paquier wrote:
On Tue, Dec 04, 2018 at 02:31:51PM +0900, Tatsuro Yamada wrote:
- For now, there is no column_number column on "\d index_name" result.
So, if tab-completion suggested column_numbers, user can't match
these easily.
Well, it depend
Hi Alvaro,
On 2018/12/19 2:23, Alvaro Herrera wrote:
Hello Yamada-san,
On 2018-Dec-03, Tatsuro Yamada wrote:
Thank you for managing the CF and Sorry for the late reply.
I'll rebase it for the next CF and also I'll clear my head because the patch
needs design change to address the feedbacks
At Wed, 28 Nov 2018 14:41:40 +0900, Tatsuro Yamada wrote in
<54bd214b-d0d3-8654->>>>
* tab_completion_alter_index_set_statistics.patch
===
There are two problems. You can use these DDL before testing.
#create table hoge (a integer, b integer);
#create index i
On 2018/11/29 21:20, Dmitry Dolgov wrote:
On Fri, Aug 24, 2018 at 7:06 AM Tatsuro Yamada
wrote:
On 2017/11/22 6:07, Peter Geoghegan wrote:
On Mon, Oct 2, 2017 at 6:04 AM, Robert Haas wrote:
Progress reporting on sorts seems like a tricky problem to me, as I
said before. In most cases
On 2018/11/28 13:14, Kyotaro HORIGUCHI wrote:
Hello.
At Wed, 28 Nov 2018 11:27:23 +0900, Tatsuro Yamada
wrote in
Hi,
On 2018/11/26 11:05, Tatsuro Yamada wrote:
I couldn't write patches details on previous email, so I write
more explanation for that on this email
Hi,
On 2018/11/26 11:05, Tatsuro Yamada wrote:
Hi,
Attached patches are following:
* tab_completion_alter_index_set_statistics.patch
- Add column name completion after ALTER COLUMN
- Avoid schema completion after SET STATISTICS
* fix_manual_of_alter_index.patch
- ALTER INDEX
column number but also column name. So, I fixed the manual.
* tab_completion_alter_table_set_statistics.patch
- Avoid schema completion after SET STATISTICS
Regards,
Tatsuro Yamada
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 9dbd555166..31f4b7d862 100644
On 2018/08/31 2:28, Peter Eisentraut wrote:
On 17/08/2018 05:32, Tatsuro Yamada wrote:
Hi Robert,
On 2018/08/17 4:32, Robert Haas wrote:
On Thu, Aug 16, 2018 at 1:20 AM, Tatsuro Yamada
wrote:
As you can see, queries with and without a semicolon are mixed, it is hard
to understand the end
and revise the patch! :)
In this year, I will try to review someone's patch as you did.
Please let me know if you need reviewer.
Regards,
Tatsuro Yamada
On 2018/08/21 12:57, Tatsuro Yamada wrote:
> On 2018/08/21 12:40, Michael Paquier wrote:
>> On Tue, Aug 21, 2018 at 12:26:15PM +0900, Tatsuro Yamada wrote:
>>> BTW, can I add the patch to the Commitfest September?
>>
>> You should.
>
> Thanks, I'll do that
Jeff Janes!
I'm now working on improving the patch based on Robert's comment related to
"Seqscan and Sort case" and also considering how to handle the "Index scan
case".
Please find attached file.
Regards,
Tatsuro Yamada
diff --git a/doc/src/sgml/monitoring.sgml b/doc/
On 2018/08/21 12:57, Tatsuro Yamada wrote:
On 2018/08/21 12:40, Michael Paquier wrote:
On Tue, Aug 21, 2018 at 12:26:15PM +0900, Tatsuro Yamada wrote:
BTW, can I add the patch to the Commitfest September?
You should.
Thanks, I'll do that.
I'll send 2 patches in this week, probably.
I
On 2018/08/21 12:40, Michael Paquier wrote:
On Tue, Aug 21, 2018 at 12:26:15PM +0900, Tatsuro Yamada wrote:
BTW, can I add the patch to the Commitfest September?
You should.
Thanks, I'll do that.
The patch includes improvements and bug fix as you know, So, I can divide the
patch into 2
On 2018/08/20 17:38, Michael Paquier wrote:
On Mon, Aug 20, 2018 at 03:51:07PM +0900, Tatsuro Yamada wrote:
On 2018/08/20 13:54, Michael Paquier wrote:
Therefore, "-P" is a manual bag. I investigated more using git log command and
understood followings:
1. -P option was removed on
On 2018/08/20 13:54, Michael Paquier wrote:
On Mon, Aug 20, 2018 at 12:30:29PM +0900, Tatsuro Yamada wrote:
vacuumlo:
Document
- Add long options
- Add environment section
Let's keep things simple by not adding long options where it is not
especially obvious, so I would
nect to
-h, -H, --host=HOSTNAMEdatabase server host or socket directory
-p, --port=PORTdatabase server port number
-U, --username=USERNAMEconnect as specified database user
Please find the attached patch.
Regards,
Tatsuro Yamada
diff --git a/cont
On 2018/08/17 12:42, Tatsuro Yamada wrote:
On 2018/08/17 11:47, Michael Paquier wrote:
On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
I agree on both points. Any objections if I apply what's proposed here
on HEAD?
I have been looking at this patch. And while consistency
improved a bit...
Yeah, I'll revise the patch based on your suggestions.
Regards,
Tatsuro Yamada
On 2018/08/17 12:31, Michael Paquier wrote:
On Fri, Aug 17, 2018 at 12:19:42PM +0900, Tatsuro Yamada wrote:
But if you think it needs back-patch, please let me know, I can create it.
This would not be back-patched.
I see.
Thanks,
Tatsuro Yamada
Hi Robert,
On 2018/08/17 4:32, Robert Haas wrote:
On Thu, Aug 16, 2018 at 1:20 AM, Tatsuro Yamada
wrote:
As you can see, queries with and without a semicolon are mixed, it is hard
to understand the end of each query. This is not beautiful and
user-friendly,
do not you think so?
I agree
have no objection. The patch is for improvement, not bug fix.
But if you think it needs back-patch, please let me know, I can create it.
Thank you for taking your time!
Regards,
Tatsuro Yamada
NTT Open Source Software Center
-?, --help show this help, then exit
Above oid2name's "-d, -H, -p and -U" options are related to Connection
Options. So, it would be beter to write it in Connection options.
For consistency, attached patch divides the Options section of oid2name
into two sections, Options and Conn
Hi Tom,
On 2018/08/15 22:27, Tom Lane wrote:
Tatsuro Yamada writes:
Attached patch gives the following query a semicolon for readability.
s/SELECT pg_catalog.set_config ('search_path', '', false)/
SELECT pg_catalog.set_config ('search_path', '', false);/
I'm not exactly convinced
; and "make installcheck-world" on 777e6ddf1
and are fine.
Regards,
Tatsuro Yamada
NTT Open Source Software Center
diff --git a/src/bin/scripts/common.c b/src/bin/scripts/common.c
index db2b9f0d68..a80089ccde 100644
--- a/src/bin/scripts/common.c
+++ b/src/bin/scripts/common.c
@@ -335,7 +335,
Hi Alexander,
On 2018/08/10 20:27, Alexander Korotkov wrote:
On Fri, Aug 10, 2018 at 1:37 PM Alexander Korotkov
wrote:
On Fri, Aug 10, 2018 at 6:24 AM Tatsuro Yamada
wrote:
Attached patch for fixing documents of "61.2. Index Access Method Functions" and
"61.6. Index
nd revise it because I'm a non-native
English speaker.
Regards,
Tatsuro Yamada
NTT Open Source Software Center
diff --git a/doc/src/sgml/indexam.sgml b/doc/src/sgml/indexam.sgml
index c72c522175..2ef638dc7d 100644
--- a/doc/src/sgml/indexam.sgml
+++ b/doc/src/sgml/indexam.sgml
@@ -385,7 +385,8 @@ amc
Hi Heikki,
On 2018/08/09 16:45, Heikki Linnakangas wrote:
On 09/08/18 10:22, Tatsuro Yamada wrote:
Attached patch for fixing a typo in optimizer/README.
s/Partition-wise/Partitionwise/
It is the only place the keyword "Partition-wise" exists, so I created the
patch.
Tha
Hi,
Attached patch for fixing a typo in optimizer/README.
s/Partition-wise/Partitionwise/
It is the only place the keyword "Partition-wise" exists, so I created the
patch.
Regards,
Tatsuro Yamada
NTT Open Source Software Center
diff --git a/src/backend/optimizer/README b/s
On 2018/07/09 23:52, David Fetter wrote:
On Mon, Jul 09, 2018 at 10:36:30AM -0400, Bruce Momjian wrote:
On Sun, Jul 8, 2018 at 10:28:15PM -0700, Andres Freund wrote:
On 2018-07-09 14:18:14 +0900, Tatsuro Yamada wrote:
Hi Bruce,
I expect a torrent of feedback.;-)
Could you add this fix
ent to ExplainOneQuery_hook's parameter list
(Tatsuro Yamada, Thomas Munro)
Discussion:
https://postgr.es/m/890e8dd9-c1c7-a422-6892-874f5eaee...@lab.ntt.co.jp
I guess "E.1.3.11. Source Code" or "E.1.3.12. Additional Modules" sections are
suitable
Hi Stephen,
On 2018/03/14 12:36, Stephen Frost wrote:
Greetings,
* Tatsuro Yamada (yamada.tats...@lab.ntt.co.jp) wrote:
I found a bug, maybe.
I don't think so...
* Result of Select: failed
# select
subq_1.c0
from
test as ref_0
ubLinkType == ROWCOMPARE_SUBLINK))
ereport(ERROR,
(errcode(ERRCODE_CARDINALITY_VIOLATION),
errmsg("more than one row returned by a subquery used as an
expression")));
Thanks,
Tatsuro Yamada
guc.c
patching file src/include/utils/plancache.h
patching file src/test/regress/expected/plancache.out
patching file src/test/regress/sql/plancache.sql
- Result of regression test
===
All 186 tests passed.
===
Regards,
Tatsuro Yamada
On 2018/01/12 2:02, Tom Lane wrote:
Thomas Munro <thomas.mu...@enterprisedb.com> writes:
On Fri, Jan 12, 2018 at 12:16 AM, Tatsuro Yamada
<yamada.tats...@lab.ntt.co.jp> wrote:
I found a variable (queryEnv) which should be added in
ExplainOneQuery_hook because if it is missing, h
the same bug because there is no contrib
module using ExplainOneQuery_hook in contrib directory.
(It might unnecessary thing, maybe.)
Regards,
Tatsuro Yamada
Hi,
I found a variable (queryEnv) which should be added in
ExplainOneQuery_hook because if it is missing, hook function
can't call ExplainOnePlan.
Sorry if this wasn't correct.
Please find attached a patch.
Tatsuro Yamada
NTT Open Source Software Center
diff --git a/src/backend/commands
Hi,
The declaration of estimate_path_cost_size uses baserel, but
the actual definition uses foreignrel. It would be better to sync.
Please find attached a patch.
Tatsuro Yamada
NTT Open Source Software Center
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw
101 - 174 of 174 matches
Mail list logo
