[HACKERS] Repetition of warning message while REVOKE

2010-03-04 Thread Piyush Newe
Hi, Description: === Repetition of warning message with revoke. How to reproduce : == create table tbl(col int); create user usr; grant select on tbl to usr; \c postgres usr; REVOKE SELECT on tbl from usr; Actual output: WARNING: no privileges

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-04 Thread Dave Page
On Wed, Mar 3, 2010 at 12:18 PM, Andrew Dunstan and...@dunslane.net wrote: I think these might need to have c:\pgBuild\{libxslt,iconv}\bin added to the PATH in the buildfarm.conf file, right after where c:\pgBuild\libxml2\bin is added. This is now done. Sorry for the delay. -- Dave Page

[HACKERS] problem about inet

2010-03-04 Thread fanng yuan
Hi Guys: I just do some research on ip address storage and comparing. I found pgsql already fixed that issue. I want to get some point from your guys about how this work. Could you give me some data about that . Also I'm interesting in pgsql . Could you give me some suggestion about how to hack

[HACKERS] Streaming replication and privilege

2010-03-04 Thread Fujii Masao
Hi, Currently superuser privilege is required when the standby connects to the primary. But there is the complaint that we should add new privilege for replication and use it instead of superuser because current approach is not good for security (*1). This has been listed as one of TODO items of

Re: [HACKERS] USE_LIBXSLT in MSVC builds

2010-03-04 Thread Andrew Dunstan
Dave Page wrote: On Wed, Mar 3, 2010 at 12:18 PM, Andrew Dunstan and...@dunslane.net wrote: I think these might need to have c:\pgBuild\{libxslt,iconv}\bin added to the PATH in the buildfarm.conf file, right after where c:\pgBuild\libxml2\bin is added. This is now done. Sorry for

Re: [HACKERS] Incrementally Updated Backups and restartpoints

2010-03-04 Thread Fujii Masao
Hi, I thought of this issue again since the related question arrived. http://archives.postgresql.org/pgsql-admin/2010-03/msg00036.php On Thu, Jan 14, 2010 at 7:13 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Jan 13, 2010 at 9:34 PM, Heikki Linnakangas

Re: [HACKERS] HS/SR and smart shutdown

2010-03-04 Thread Fujii Masao
On Mon, Feb 1, 2010 at 11:49 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Jan 30, 2010 at 12:54 PM, Fujii Masao masao.fu...@gmail.com wrote: HOWEVER, I do believe this is an issue we could live with for 9.0 if it's going to lead to a whole lot of additional debugging of SR.  But if

Re: [HACKERS] problem about inet

2010-03-04 Thread Kevin Grittner
fanng yuan wrote: I just do some research on ip address storage and comparing. I found pgsql already fixed that issue. I want to get some point from your guys about how this work. I'm not sure what you're looking for, exactly. Does this page help?:

Re: [HACKERS] Linux start script updates

2010-03-04 Thread Kevin Grittner
Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: Exactly. With Fedora respecting the standard in this regard, I'm convinced we should, too. In reviewing things based on Peter's question, I did start to have doubts about *not*

Re: [HACKERS] HS/SR and smart shutdown

2010-03-04 Thread Greg Stark
On Thu, Mar 4, 2010 at 12:11 PM, Fujii Masao masao.fu...@gmail.com wrote: There is no post about this for over a month. Can I remove this from TODO item of SR for 9.0? Thought? Objection? Does smart shutdown still fail to shut down a slave? -- greg -- Sent via pgsql-hackers mailing list

Re: [HACKERS] HS/SR and smart shutdown

2010-03-04 Thread Fujii Masao
On Thu, Mar 4, 2010 at 11:55 PM, Greg Stark gsst...@mit.edu wrote: On Thu, Mar 4, 2010 at 12:11 PM, Fujii Masao masao.fu...@gmail.com wrote: There is no post about this for over a month. Can I remove this from TODO item of SR for 9.0? Thought? Objection? Does smart shutdown still fail to

Re: [HACKERS] Repetition of warning message while REVOKE

2010-03-04 Thread Tom Lane
Piyush Newe piyush.n...@enterprisedb.com writes: create table tbl(col int); create user usr; grant select on tbl to usr; \c postgres usr; REVOKE SELECT on tbl from usr; WARNING: no privileges could be revoked for tbl WARNING: no privileges could be revoked for tbl WARNING: no privileges

[HACKERS] one-off error in to_char formatting

2010-03-04 Thread Erik Rijkers
ISTM this is a bug, no? (9.0devel, cvs 2010.03.04 01:30) replicas=# select length( to_char(1, '0') ); length 2 (1 row) There seems to be an erroneously prefixed space: replicas=# select '' || to_char(1, repeat('0',8)) || ''; ?column? - 0001 (1 row)

Re: [HACKERS] Streaming replication and privilege

2010-03-04 Thread Robert Haas
On Thu, Mar 4, 2010 at 5:47 AM, Fujii Masao masao.fu...@gmail.com wrote: Currently superuser privilege is required when the standby connects to the primary. But there is the complaint that we should add new privilege for replication and use it instead of superuser because current approach is

Re: [HACKERS] one-off error in to_char formatting

2010-03-04 Thread Tom Lane
Erik Rijkers e...@xs4all.nl writes: There seems to be an erroneously prefixed space: No, that's where the sign goes. You can suppress it with FM, if you don't want fixed-width output. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Linux start script updates

2010-03-04 Thread Robert Haas
On Thu, Mar 4, 2010 at 9:46 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: Exactly.  With Fedora respecting the standard in this regard, I'm convinced we should, too.  In

Re: [HACKERS] HS/SR and smart shutdown

2010-03-04 Thread Robert Haas
On Thu, Mar 4, 2010 at 10:17 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Mar 4, 2010 at 11:55 PM, Greg Stark gsst...@mit.edu wrote: On Thu, Mar 4, 2010 at 12:11 PM, Fujii Masao masao.fu...@gmail.com wrote: There is no post about this for over a month. Can I remove this from TODO item

[HACKERS] Assertion failure twophase.c (2) (testing HS/SR)

2010-03-04 Thread Erik Rijkers
in a 9.0devel, primary+standby, cvs from 2010.03.04 01:30 With three patches: new_smart_shutdown_20100201.patch extend_format_of_recovery_info_funcs_v4.20100303.patch fix-KnownAssignedXidsRemoveMany-1.patch pg_dump -d $db8.4.2 | psql -d $db9.0devel-primary FailedAssertion, File:

Re: [HACKERS] Repetition of warning message while REVOKE

2010-03-04 Thread Tom Lane
I wrote: Piyush Newe piyush.n...@enterprisedb.com writes: create table tbl(col int); create user usr; grant select on tbl to usr; \c postgres usr; REVOKE SELECT on tbl from usr; WARNING: no privileges could be revoked for tbl WARNING: no privileges could be revoked for tbl WARNING: no

Re: [HACKERS] Repetition of warning message while REVOKE

2010-03-04 Thread Joshua D. Drake
On Thu, 2010-03-04 at 11:23 -0500, Tom Lane wrote: I wrote: Piyush Newe piyush.n...@enterprisedb.com writes: create table tbl(col int); create user usr; grant select on tbl to usr; \c postgres usr; REVOKE SELECT on tbl from usr; WARNING: no privileges could be revoked for tbl

Re: [HACKERS] Linux start script updates

2010-03-04 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: AFAIR Peter is the only one who has complained about the script being longer, and I'm really not sure why that's a big deal. I'll take that under advisement for later. I'm not inclined to think there's anything here worth trying to squeeze into 9.0,

Re: [HACKERS] Linux start script updates

2010-03-04 Thread Robert Haas
On Thu, Mar 4, 2010 at 12:00 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas robertmh...@gmail.com wrote: AFAIR Peter is the only one who has complained about the script being longer, and I'm really not sure why that's a big deal. I'll take that under advisement for later.  

Re: [HACKERS] HS/SR and smart shutdown

2010-03-04 Thread Greg Stark
On Thu, Mar 4, 2010 at 3:56 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Mar 4, 2010 at 10:17 AM, Fujii Masao masao.fu...@gmail.com wrote: Yes. More precisely, smart shutdown during recovery does not complete until recovery ends. Well, I don't think we should let smart shutdown just

Re: [HACKERS] HS/SR and smart shutdown

2010-03-04 Thread Robert Haas
On Thu, Mar 4, 2010 at 12:39 PM, Greg Stark gsst...@mit.edu wrote: On Thu, Mar 4, 2010 at 3:56 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Mar 4, 2010 at 10:17 AM, Fujii Masao masao.fu...@gmail.com wrote: Yes. More precisely, smart shutdown during recovery does not complete until

Re: [HACKERS] Streaming replication and privilege

2010-03-04 Thread Josh Berkus
On 3/4/10 2:47 AM, Fujii Masao wrote: This TODO item really needs to be addressed for 9.0? Frankly I'm not familiar with that area, so I've not work on it at all yet, but I'm going to create the patch if many people want it for 9.0. What is your opinion? I think it falls under nice to have,

[HACKERS] machine-readable pg_controldata?

2010-03-04 Thread Josh Berkus
All, Currently, the only way for admin scripts to get individual data items out of pg_controldata (such as the next XID or the catalog version) is via grep and regex. Given that people are going to be relying on some of this data for replication admin in the future, it seems past time to have a

Re: [HACKERS] machine-readable pg_controldata?

2010-03-04 Thread Magnus Hagander
2010/3/4 Josh Berkus j...@agliodbs.com: All, Currently, the only way for admin scripts to get individual data items out of pg_controldata (such as the next XID or the catalog version) is via grep and regex. Given that people are going to be relying on some of this data for replication admin

[HACKERS] Explicit psqlrc

2010-03-04 Thread Magnus Hagander
I've now for the second time found myself wanting to specify an explicit psqlrc file instead of just parsing ~/.psqlrc, so attached is a patch that accepts the PSQLRC environment variable to control which psqlrc file is used. Any objections to this (obviously including documentation - this is

Re: [HACKERS] machine-readable pg_controldata?

2010-03-04 Thread Joshua Tolley
On Thu, Mar 04, 2010 at 10:54:15PM +0100, Magnus Hagander wrote: 2010/3/4 Josh Berkus j...@agliodbs.com: pg_controldata --catalog_version Even better would be the ability to get everything which is in pg_controldata currently as part of a system view in a running PostgreSQL; I can get

Re: [HACKERS] machine-readable pg_controldata?

2010-03-04 Thread Joe Conway
On 03/04/2010 02:09 PM, Joshua Tolley wrote: On Thu, Mar 04, 2010 at 10:54:15PM +0100, Magnus Hagander wrote: 2010/3/4 Josh Berkus j...@agliodbs.com: pg_controldata --catalog_version Even better would be the ability to get everything which is in pg_controldata currently as part of a system

Re: [HACKERS] Explicit psqlrc

2010-03-04 Thread David Christensen
On Mar 4, 2010, at 4:00 PM, Magnus Hagander wrote: I've now for the second time found myself wanting to specify an explicit psqlrc file instead of just parsing ~/.psqlrc, so attached is a patch that accepts the PSQLRC environment variable to control which psqlrc file is used. Any objections

Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-03-04 Thread Erik Rijkers
On Wed, March 3, 2010 15:03, Fujii Masao wrote: On Tue, Mar 2, 2010 at 10:52 PM, Fujii Masao masao.fu...@gmail.com wrote: Here is the revised patch. I used new local variable instead of lastPageTLI to track the tli of last applied record. It is updated with the tli of the log page header when

[HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-04 Thread Kevin Flanagan
I have PostgreSQL 8.4 installed on Windows XP, and am using Visual Studio 2005 to write a C-Language function. I have the most basic hello-world type example (just the 'add_one' function from http://www.postgresql.org/docs/8.4/interactive/xfunc-c.html) in a DLL, set to compile to C code rather

Re: [HACKERS] Repetition of warning message while REVOKE

2010-03-04 Thread Stephen Frost
All, * Joshua D. Drake (j...@commandprompt.com) wrote: On Thu, 2010-03-04 at 11:23 -0500, Tom Lane wrote: I'm not sure offhand about a reasonable way to rearrange the code to avoid duplicate messages. Perhaps just add what can't be revoked? meaning: WARNING: no privileges could be

Re: [HACKERS] Repetition of warning message while REVOKE

2010-03-04 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: * Joshua D. Drake (j...@commandprompt.com) wrote: Perhaps just add what can't be revoked? meaning: WARNING: no privileges could be revoked for tbl for column foo Then they aren't actually duplicate. Yeah, they really aren't, after all. Yeah, I agree

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-04 Thread Craig Ringer
Kevin Flanagan wrote: the compiler complained about various missing include files, starting with ‘libintl.h’. Having read the post at http://archives.postgresql.org/pgsql-general/2009-03/msg00332.php I created an empty libint.h in an include dir NFI why Pg for win32 doesn't bundle a copy of